Philipp Hörist pushed to branch master at gajim / gajim
Commits: 0ebc5171 by Philipp Hörist at 2019-08-22T18:23:11Z Bookmarks: Check if there was a change before store
- - - - -
1 changed file:
- gajim/common/modules/bookmarks.py
Changes:
===================================== gajim/common/modules/bookmarks.py ===================================== @@ -200,13 +200,17 @@ class Bookmarks(BaseModule): bookmark = self.get_bookmark_from_jid(jid) if bookmark is None: bookmark = BookmarkData(jid=jid, **kwargs) + self._bookmarks.append(bookmark) self._log.info('Add new bookmark: %s', bookmark) else: + modified_bookmark = bookmark._replace(**kwargs) + if modified_bookmark == bookmark: + # No change happened + return self._log.info('Modify bookmark: %s %s', jid, kwargs) self._bookmarks.remove(bookmark) - bookmark = bookmark._replace(**kwargs) + self._bookmarks.append(modified_bookmark)
- self._bookmarks.append(bookmark) self.store_bookmarks()
def remove(self, jid: str, publish: bool = True) -> None:
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/0ebc51714c156832531bb1b9f4ab44db659...