Philipp Hörist pushed to branch master at gajim / gajim
Commits:
-
0ebc5171
by Philipp Hörist at 2019-08-22T18:23:11Z
1 changed file:
Changes:
| ... | ... | @@ -200,13 +200,17 @@ class Bookmarks(BaseModule): |
| 200 | 200 |
bookmark = self.get_bookmark_from_jid(jid)
|
| 201 | 201 |
if bookmark is None:
|
| 202 | 202 |
bookmark = BookmarkData(jid=jid, **kwargs)
|
| 203 |
+ self._bookmarks.append(bookmark)
|
|
| 203 | 204 |
self._log.info('Add new bookmark: %s', bookmark)
|
| 204 | 205 |
else:
|
| 206 |
+ modified_bookmark = bookmark._replace(**kwargs)
|
|
| 207 |
+ if modified_bookmark == bookmark:
|
|
| 208 |
+ # No change happened
|
|
| 209 |
+ return
|
|
| 205 | 210 |
self._log.info('Modify bookmark: %s %s', jid, kwargs)
|
| 206 | 211 |
self._bookmarks.remove(bookmark)
|
| 207 |
- bookmark = bookmark._replace(**kwargs)
|
|
| 212 |
+ self._bookmarks.append(modified_bookmark)
|
|
| 208 | 213 |
|
| 209 |
- self._bookmarks.append(bookmark)
|
|
| 210 | 214 |
self.store_bookmarks()
|
| 211 | 215 |
|
| 212 | 216 |
def remove(self, jid: str, publish: bool = True) -> None:
|