Commits February 2016

commits@gajim.org

1 participants
40 discussions

gajim: Make last message correction work correctly in PM. See #8220
by Gajim 29 Feb '16

29 Feb '16

changeset 9f7c62b5dbda in /home/hg/repos/gajim author: Yann Leboulanger <asterix(a)lagaule.org> branches: details:http://hg.gajim.org/gajim?cmd=changeset;node=9f7c62b5dbda description: Make last message correction work correctly in PM. See #8220 diffstat: src/groupchat_control.py | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diffs (13 lines): diff -r de72c20ba060 -r 9f7c62b5dbda src/groupchat_control.py --- a/src/groupchat_control.py Sun Feb 21 16:45:31 2016 +0100 +++ b/src/groupchat_control.py Sat Feb 27 18:54:19 2016 +0100 @@ -1368,7 +1368,8 @@ # print if a control is open obj.session.control.print_conversation(obj.msgtxt, tim=obj.timestamp, xhtml=obj.xhtml, encrypted=obj.encrypted, - displaymarking=obj.displaymarking) + displaymarking=obj.displaymarking, correct_id=(obj.id_, + obj.correct_id)) else: # otherwise pass it off to the control to be queued self.on_private_message(nick, obj.msgtxt, obj.timestamp,

1 0

gajim: rename msg_id to msg_log_id where it's the id from logs d...
by Gajim 29 Feb '16

29 Feb '16

changeset 85fc8e1684ff in /home/hg/repos/gajim author: Yann Leboulanger <asterix(a)lagaule.org> branches: details:http://hg.gajim.org/gajim?cmd=changeset;node=85fc8e1684ff description: rename msg_id to msg_log_id where it's the id from logs database diffstat: src/chat_control.py | 8 ++++---- src/common/connection_handlers_events.py | 6 +++--- src/common/contacts.py | 4 ++-- src/common/logger.py | 10 +++++----- src/groupchat_control.py | 6 +++--- src/roster_window.py | 20 ++++++++++---------- src/session.py | 18 +++++++++--------- 7 files changed, 36 insertions(+), 36 deletions(-) diffs (284 lines): diff -r 9f7c62b5dbda -r 85fc8e1684ff src/chat_control.py --- a/src/chat_control.py Sat Feb 27 18:54:19 2016 +0100 +++ b/src/chat_control.py Sat Feb 27 19:52:46 2016 +0100 @@ -849,7 +849,7 @@ def print_conversation_line(self, text, kind, name, tim, other_tags_for_name=[], other_tags_for_time=[], other_tags_for_text=[], count_as_new=True, subject=None, old_kind=None, xhtml=None, simple=False, - xep0184_id=None, graphics=True, displaymarking=None, msg_id=None, + xep0184_id=None, graphics=True, displaymarking=None, msg_log_id=None, correct_id=None): """ Print 'chat' type messages @@ -925,7 +925,7 @@ self.account, self.contact, type_) event = gajim.events.create_event(type_, (text, subject, self, - msg_id), show_in_roster=show_in_roster, + msg_log_id), show_in_roster=show_in_roster, show_in_systray=show_in_systray) gajim.events.add_event(self.account, full_jid, event) # We need to redraw contact if we show in roster @@ -2448,7 +2448,7 @@ def print_conversation(self, text, frm='', tim=None, encrypted=False, subject=None, xhtml=None, simple=False, xep0184_id=None, - displaymarking=None, msg_id=None, correct_id=None): + displaymarking=None, msg_log_id=None, correct_id=None): """ Print a line in the conversation @@ -2513,7 +2513,7 @@ ChatControlBase.print_conversation_line(self, text, kind, name, tim, subject=subject, old_kind=self.old_msg_kind, xhtml=xhtml, simple=simple, xep0184_id=xep0184_id, displaymarking=displaymarking, - msg_id=msg_id, correct_id=correct_id) + msg_log_id=msg_log_id, correct_id=correct_id) if text.startswith('/me ') or text.startswith('/me\n'): self.old_msg_kind = None else: diff -r 9f7c62b5dbda -r 85fc8e1684ff src/common/connection_handlers_events.py --- a/src/common/connection_handlers_events.py Sat Feb 27 18:54:19 2016 +0100 +++ b/src/common/connection_handlers_events.py Sat Feb 27 19:52:46 2016 +0100 @@ -1395,7 +1395,7 @@ self.sent = self.msg_obj.sent self.conn = self.msg_obj.conn self.popup = False - self.msg_id = None # id in log database + self.msg_log_id = None # id in log database self.attention = False # XEP-0224 self.correct_id = None # XEP-0308 self.msghash = None @@ -1600,7 +1600,7 @@ class MessageSentEvent(nec.NetworkIncomingEvent): name = 'message-sent' base_network_events = [] - + def generate(self): if not self.automatic_message: self.conn.sent_message_ids.append(self.msg_id) @@ -1616,7 +1616,7 @@ class MessageErrorEvent(nec.NetworkIncomingEvent, HelperEvent): name = 'message-error' base_network_events = [] - + def generate(self): self.get_id() #only alert for errors of explicitly sent messages (see https://trac.gajim.org/ticket/8222) diff -r 9f7c62b5dbda -r 85fc8e1684ff src/common/contacts.py --- a/src/common/contacts.py Sat Feb 27 18:54:19 2016 +0100 +++ b/src/common/contacts.py Sat Feb 27 19:52:46 2016 +0100 @@ -94,7 +94,7 @@ """ def __init__(self, jid, account, name='', groups=[], show='', status='', sub='', ask='', resource='', priority=0, keyID='', client_caps=None, - our_chatstate=None, chatstate=None, last_status_time=None, msg_id=None, + our_chatstate=None, chatstate=None, last_status_time=None, msg_log_id=None, last_activity_time=None): if not isinstance(jid, str): print('no str') @@ -110,7 +110,7 @@ self.priority = priority self.keyID = keyID - self.msg_id = msg_id + self.msg_log_id = msg_log_id self.last_status_time = last_status_time self.last_activity_time = last_activity_time diff -r 9f7c62b5dbda -r 85fc8e1684ff src/common/logger.py --- a/src/common/logger.py Sat Feb 27 18:54:19 2016 +0100 +++ b/src/common/logger.py Sat Feb 27 19:52:46 2016 +0100 @@ -448,12 +448,12 @@ sql = 'DELETE FROM unread_messages WHERE message_id IN (%s)' % ids self.simple_commit(sql) - def set_shown_unread_msgs(self, msg_id): + def set_shown_unread_msgs(self, msg_log_id): """ Mark unread message as shown un GUI """ sql = 'UPDATE unread_messages SET shown = 1 where message_id = %s' % \ - msg_id + msg_log_id self.simple_commit(sql) def reset_shown_unread_messages(self): @@ -475,7 +475,7 @@ except Exception: pass for message in results: - msg_id = message[0] + msg_log_id = message[0] shown = message[1] # here we get infos for that message, and related jid from jids table # do NOT change order of SELECTed things, unless you change function(s) @@ -485,12 +485,12 @@ jids.jid FROM logs, jids WHERE logs.log_line_id = %d AND logs.jid_id = jids.jid_id - ''' % msg_id + ''' % msg_log_id ) results = self.cur.fetchall() if len(results) == 0: # Log line is no more in logs table. remove it from unread_messages - self.set_read_messages([msg_id]) + self.set_read_messages([msg_log_id]) continue all_messages.append(results[0] + (shown,)) return all_messages diff -r 9f7c62b5dbda -r 85fc8e1684ff src/groupchat_control.py --- a/src/groupchat_control.py Sat Feb 27 18:54:19 2016 +0100 +++ b/src/groupchat_control.py Sat Feb 27 19:52:46 2016 +0100 @@ -1076,14 +1076,14 @@ correct_id=(obj.stanza.getID(), None)) obj.needs_highlight = self.needs_visual_notification(obj.msgtxt) - def on_private_message(self, nick, msg, tim, xhtml, session, msg_id=None, + def on_private_message(self, nick, msg, tim, xhtml, session, msg_log_id=None, encrypted=False, displaymarking=None): # Do we have a queue? fjid = self.room_jid + '/' + nick no_queue = len(gajim.events.get_events(self.account, fjid)) == 0 event = gajim.events.create_event('pm', (msg, '', 'incoming', tim, - encrypted, '', msg_id, xhtml, session, None, displaymarking, False)) + encrypted, '', msg_log_id, xhtml, session, None, displaymarking, False)) gajim.events.add_event(self.account, fjid, event) autopopup = gajim.config.get('autopopup') @@ -1373,7 +1373,7 @@ else: # otherwise pass it off to the control to be queued self.on_private_message(nick, obj.msgtxt, obj.timestamp, - obj.xhtml, self.session, msg_id=obj.msg_id, + obj.xhtml, self.session, msg_log_id=obj.msg_log_id, encrypted=obj.encrypted, displaymarking=obj.displaymarking) def _nec_ping_reply(self, obj): diff -r 9f7c62b5dbda -r 85fc8e1684ff src/roster_window.py --- a/src/roster_window.py Sat Feb 27 18:54:19 2016 +0100 +++ b/src/roster_window.py Sat Feb 27 19:52:46 2016 +0100 @@ -1860,7 +1860,7 @@ tim = time.localtime(float(result[2])) session.roster_message(jid, result[1], tim, msg_type='chat', - msg_id=result[0]) + msg_log_id=result[0]) gajim.logger.set_shown_unread_msgs(result[0]) elif (time.time() - result[2]) > 2592000: @@ -1961,16 +1961,16 @@ pending events """ - msg_ids = [] + msg_log_ids = [] for ev in event_list: if ev.type_ != 'printed_chat': continue if len(ev.parameters) > 3 and ev.parameters[3]: - # There is a msg_id - msg_ids.append(ev.parameters[3]) - - if msg_ids: - gajim.logger.set_read_messages(msg_ids) + # There is a msg_log_id + msg_log_ids.append(ev.parameters[3]) + + if msg_log_ids: + gajim.logger.set_read_messages(msg_log_ids) contact_list = ((event.jid.split('/')[0], event.account) for event in \ event_list) @@ -2766,14 +2766,14 @@ obj.session.control.print_conversation(obj.msgtxt, typ, tim=obj.timestamp, encrypted=obj.encrypted, subject=obj.subject, xhtml=obj.xhtml, displaymarking=obj.displaymarking, - msg_id=obj.msg_id, correct_id=(obj.id_, obj.correct_id), + msg_log_id=obj.msg_log_id, correct_id=(obj.id_, obj.correct_id), xep0184_id=xep0184_id) - if obj.msg_id: + if obj.msg_log_id: pw = obj.session.control.parent_win end = obj.session.control.was_at_the_end if not pw or (pw.get_active_control() and obj.session.control \ == pw.get_active_control() and pw.is_active() and end): - gajim.logger.set_read_messages([obj.msg_id]) + gajim.logger.set_read_messages([obj.msg_log_id]) elif obj.popup and obj.mtype == 'chat': contact = gajim.contacts.get_contact(obj.conn.name, obj.jid) obj.session.control = gajim.interface.new_chat(contact, diff -r 9f7c62b5dbda -r 85fc8e1684ff src/session.py --- a/src/session.py Sat Feb 27 18:54:19 2016 +0100 +++ b/src/session.py Sat Feb 27 19:52:46 2016 +0100 @@ -99,7 +99,7 @@ msg_to_log = obj.xhtml else: msg_to_log = obj.msgtxt - obj.msg_id = gajim.logger.write(log_type, obj.fjid, + obj.msg_log_id = gajim.logger.write(log_type, obj.fjid, msg_to_log, tim=obj.timestamp, subject=obj.subject) except exceptions.PysqliteOperationalError as e: gajim.nec.push_incoming_event(InformationEvent(None, @@ -142,8 +142,8 @@ # Brand new message, incoming. contact.our_chatstate = obj.chatstate contact.chatstate = obj.chatstate - if obj.msg_id: # Do not overwrite an existing msg_id with None - contact.msg_id = obj.msg_id + if obj.msg_log_id: # Do not overwrite an existing msg_log_id with None + contact.msg_log_id = obj.msg_log_id # THIS MUST BE AFTER chatstates handling # AND BEFORE playsound (else we ear sounding on chatstates!) @@ -182,7 +182,7 @@ gajim.interface.remote_ctrl.raise_signal('NewMessage', ( self.conn.name, [obj.fjid, obj.msgtxt, obj.timestamp, obj.encrypted, obj.mtype, obj.subject, obj.chatstate, - obj.msg_id, obj.user_nick, obj.xhtml, obj.form_node])) + obj.msg_log_id, obj.user_nick, obj.xhtml, obj.form_node])) def roster_message2(self, obj): """ @@ -255,7 +255,7 @@ (obj.mtype == 'normal' and not obj.popup): event = gajim.events.create_event(type_, (obj.msgtxt, obj.subject, obj.mtype, obj.timestamp, obj.encrypted, obj.resource, - obj.msg_id, obj.xhtml, self, obj.form_node, obj.displaymarking, + obj.msg_log_id, obj.xhtml, self, obj.form_node, obj.displaymarking, obj.forwarded and obj.sent), show_in_roster=obj.show_in_roster, show_in_systray=obj.show_in_systray) @@ -263,7 +263,7 @@ gajim.events.add_event(self.conn.name, fjid, event) def roster_message(self, jid, msg, tim, encrypted=False, msg_type='', - subject=None, resource='', msg_id=None, user_nick='', xhtml=None, + subject=None, resource='', msg_log_id=None, user_nick='', xhtml=None, form_node=None, displaymarking=None): """ Display the message or show notification in the roster @@ -332,8 +332,8 @@ self.control.print_conversation(msg, typ, tim=tim, encrypted=encrypted, subject=subject, xhtml=xhtml, displaymarking=displaymarking) - if msg_id: - gajim.logger.set_read_messages([msg_id]) + if msg_log_id: + gajim.logger.set_read_messages([msg_log_id]) return @@ -351,7 +351,7 @@ contact) event = gajim.events.create_event(type_, (msg, subject, msg_type, tim, - encrypted, resource, msg_id, xhtml, self, form_node, displaymarking, + encrypted, resource, msg_log_id, xhtml, self, form_node, displaymarking, False), show_in_roster=show_in_roster, show_in_systray=show_in_systray)

1 0

gajim: pending events are now in objects rather that storing par...
by Gajim 29 Feb '16

29 Feb '16

changeset 5c6c77423355 in /home/hg/repos/gajim author: Yann Leboulanger <asterix(a)lagaule.org> branches: details:http://hg.gajim.org/gajim?cmd=changeset;node=5c6c77423355 description: pending events are now in objects rather that storing parameters in tuple diffstat: src/chat_control.py | 85 +++++++++++++-------------- src/common/commands.py | 13 +-- src/common/events.py | 133 ++++++++++++++++++++++++++++++++++++++---- src/common/stanza_session.py | 4 +- src/filetransfers_window.py | 2 +- src/groupchat_control.py | 6 +- src/gui_interface.py | 71 ++++++++++++---------- src/roster_window.py | 41 ++++++------ src/session.py | 27 ++++--- 9 files changed, 247 insertions(+), 135 deletions(-) diffs (truncated from 819 to 300 lines): diff -r 85fc8e1684ff -r 5c6c77423355 src/chat_control.py --- a/src/chat_control.py Sat Feb 27 19:52:46 2016 +0100 +++ b/src/chat_control.py Mon Feb 29 21:04:08 2016 +0100 @@ -46,6 +46,7 @@ import notify import re +from common import events from common import gajim from common import helpers from common import exceptions @@ -912,20 +913,23 @@ # other_tags_for_text == ['marked'] --> highlighted gc message if gc_message: if 'marked' in other_tags_for_text: - type_ = 'printed_marked_gc_msg' + event_type = events.PrintedMarkedGcMsgEvent else: - type_ = 'printed_gc_msg' + event_type = events.PrintedGcMsgEvent event = 'gc_message_received' else: - type_ = 'printed_' + self.type_id + if self.type_id == message_control.TYPE_CHAT: + event_type = events.PrintedChatEvent + else: + event_type = events.PrintedPmEvent event = 'message_received' show_in_roster = notify.get_show_in_roster(event, self.account, self.contact, self.session) show_in_systray = notify.get_show_in_systray(event, - self.account, self.contact, type_) - - event = gajim.events.create_event(type_, (text, subject, self, - msg_log_id), show_in_roster=show_in_roster, + self.account, self.contact, event_type.type_) + + event = event_type(text, subject, self, msg_log_id, + show_in_roster=show_in_roster, show_in_systray=show_in_systray) gajim.events.add_event(self.account, full_jid, event) # We need to redraw contact if we show in roster @@ -2677,7 +2681,7 @@ gajim.nec.push_outgoing_event(MessageOutgoingEvent(None, account=self.account, jid=self.contact.jid, chatstate=state, - msg_id=contact.msg_id, control=self)) + msg_id=contact.msg_log_id, control=self)) contact.our_chatstate = state if state == 'active': @@ -3010,23 +3014,20 @@ for event in events: if event.type_ != self.type_id: continue - data = event.parameters - kind = data[2] - if kind == 'error': + if event.kind == 'error': kind = 'info' else: kind = 'print_queue' - if data[11]: + if event.sent_forwarded: kind = 'out' - dm = data[10] - self.print_conversation(data[0], kind, tim=data[3], - encrypted=data[4], subject=data[1], xhtml=data[7], - displaymarking=dm) - if len(data) > 6 and isinstance(data[6], int): - message_ids.append(data[6]) - - if len(data) > 8 and not self.session: - self.set_session(data[8]) + self.print_conversation(event.message, kind, tim=event.time, + encrypted=event.encrypted, subject=event.subject, + xhtml=event.xhtml, displaymarking=event.displaymarking) + if isinstance(event.msg_log_id, int): + message_ids.append(event.msg_log_id) + + if event.session and not self.session: + self.set_session(event.session) if message_ids: gajim.logger.set_read_messages(message_ids) gajim.events.remove_events(self.account, jid_with_resource, @@ -3258,7 +3259,7 @@ def _get_file_props_event(self, file_props, type_): evs = gajim.events.get_events(self.account, self.contact.jid, [type_]) for ev in evs: - if ev.parameters == file_props: + if ev.file_props == file_props: return ev return None @@ -3322,15 +3323,13 @@ self._add_info_bar_message(markup, [b], file_props, Gtk.MessageType.ERROR) def _on_accept_gc_invitation(self, widget, event): - room_jid = event.parameters[0] - password = event.parameters[2] - is_continued = event.parameters[3] try: - if is_continued: - gajim.interface.join_gc_room(self.account, room_jid, - gajim.nicks[self.account], password, is_continued=True) + if event.is_continued: + gajim.interface.join_gc_room(self.account, event.room_jid, + gajim.nicks[self.account], event.password, + is_continued=True) else: - dialogs.JoinGroupchatWindow(self.account, room_jid) + dialogs.JoinGroupchatWindow(self.account, event.room_jid) except GajimGeneralException: pass gajim.events.remove_events(self.account, self.contact.jid, event=event) @@ -3339,17 +3338,15 @@ gajim.events.remove_events(self.account, self.contact.jid, event=event) def _get_gc_invitation(self, event): - room_jid = event.parameters[0] - comment = event.parameters[1] - markup = '<b>%s:</b> %s' % (_('Groupchat Invitation'), room_jid) - if comment: - markup += ' (%s)' % comment + markup = '<b>%s:</b> %s' % (_('Groupchat Invitation'), event.room_jid) + if event.comment: + markup += ' (%s)' % event.comment b1 = Gtk.Button(_('_Join')) b1.connect('clicked', self._on_accept_gc_invitation, event) b2 = Gtk.Button(stock=Gtk.STOCK_CANCEL) b2.connect('clicked', self._on_cancel_gc_invitation, event) - self._add_info_bar_message(markup, [b1, b2], event.parameters, - Gtk.MessageType.QUESTION) + self._add_info_bar_message(markup, [b1, b2], (event.room_jid, + event.comment), Gtk.MessageType.QUESTION) def on_event_added(self, event): if event.account != self.account: @@ -3357,19 +3354,19 @@ if event.jid != self.contact.jid: return if event.type_ == 'file-request': - self._got_file_request(event.parameters) + self._got_file_request(event.file_props) elif event.type_ == 'file-completed': - self._got_file_completed(event.parameters) + self._got_file_completed(event.file_props) elif event.type_ in ('file-error', 'file-stopped'): msg_err = '' - if event.parameters.error == -1: + if event.file_props.error == -1: msg_err = _('Remote contact stopped transfer') - elif event.parameters.error == -6: + elif event.file_props.error == -6: msg_err = _('Error opening file') - self._got_file_error(event.parameters, event.type_, + self._got_file_error(event.file_props, event.type_, _('File transfer stopped'), msg_err) elif event.type_ in ('file-request-error', 'file-send-error'): - self._got_file_error(event.parameters, event.type_, + self._got_file_error(event.file_props, event.type_, _('File transfer cancelled'), _('Connection with peer cannot be established.')) elif event.type_ == 'gc-invitation': @@ -3392,11 +3389,11 @@ removed = False for ib_msg in self.info_bar_queue: if ev.type_ == 'gc-invitation': - if ev.parameters[0] == ib_msg[2][0]: + if ev.room_jid == ib_msg[2][0]: self.info_bar_queue.remove(ib_msg) removed = True else: # file-* - if ib_msg[2] == ev.parameters: + if ib_msg[2] == ev.file_props: self.info_bar_queue.remove(ib_msg) removed = True if removed: diff -r 85fc8e1684ff -r 5c6c77423355 src/common/commands.py --- a/src/common/commands.py Sat Feb 27 19:52:46 2016 +0100 +++ b/src/common/commands.py Mon Feb 29 21:04:08 2016 +0100 @@ -287,9 +287,9 @@ if ev_typ == 'printed_chat': ev_typ = 'chat' gajim.nec.push_outgoing_event(MessageOutgoingEvent(None, - account=account, jid=j, message=event.parameters[0], - type_=ev_typ, subject=event.parameters[1], - resource=resource, forward_from=jid, delayed=event.time_)) + account=account, jid=j, message=event.message, type_=ev_typ, + subject=event.subject, resource=resource, forward_from=jid, + delayed=event.time_)) # Inform other client of completion response, cmd = self.buildResponse(request, status = 'completed') @@ -321,10 +321,9 @@ if ev_typ == 'printed_chat': ev_typ = 'chat' gajim.nec.push_outgoing_event(MessageOutgoingEvent(None, - account=account, jid=j, message=event.parameters[0], - type_=ev_typ, subject=event.parameters[1], - resource=resource, forward_from=jid, delayed=event.time_, - now=True)) + account=account, jid=j, message=event.message, type_=ev_typ, + subject=event.subject, resource=resource, forward_from=jid, + delayed=event.time_, now=True)) response, cmd = self.buildResponse(request, status = 'completed') cmd.addChild('note', {}, _('The status has been changed.')) diff -r 85fc8e1684ff -r 5c6c77423355 src/common/events.py --- a/src/common/events.py Sat Feb 27 19:52:46 2016 +0100 +++ b/src/common/events.py Mon Feb 29 21:04:08 2016 +0100 @@ -31,8 +31,7 @@ Information concerning each event """ - def __init__(self, type_, time_, parameters, show_in_roster=False, - show_in_systray=True): + def __init__(self, time_=None, show_in_roster=False, show_in_systray=True): """ type_ in chat, normal, file-request, file-error, file-completed, file-request-error, file-send-error, file-stopped, gc_msg, pm, @@ -41,27 +40,138 @@ parameters is (per type_): chat, normal, pm: [message, subject, kind, time, encrypted, resource, - msg_id] + msg_log_id] where kind in error, incoming file-*: file_props gc_msg: None - printed_chat: [message, subject, control, msg_id] + printed_chat: [message, subject, control, msg_log_id] printed_*: None messages that are already printed in chat, but not read - gc-invitation: [room_jid, reason, password, is_continued] + gc-invitation: [room_jid, reason, password, is_continued, jid_from] subscription_request: [text, nick] unsubscribed: contact jingle-incoming: (fulljid, sessionid, content_types) """ - self.type_ = type_ - self.time_ = time_ - self.parameters = parameters + if time_: + self.time_ = time_ + else: + self.time_ = time.time() self.show_in_roster = show_in_roster self.show_in_systray = show_in_systray # Set when adding the event self.jid = None self.account = None +class ChatEvent(Event): + type_ = 'chat' + def __init__ (self, message, subject, kind, time, encrypted, resource, + msg_log_id=None, xhtml=None, session=None, form_node=None, displaymarking=None, + sent_forwarded=False, time_=None, show_in_roster=False, + show_in_systray=True): + Event.__init__(self, time_, show_in_roster=show_in_roster, + show_in_systray=show_in_systray) + self.message = message + self.subject = subject + self.kind = kind + self.time = time + self.encrypted = encrypted + self.resource = resource + self.msg_log_id = msg_log_id + self.xhtml = xhtml + self.session = session + self.form_node = form_node + self.displaymarking = displaymarking + self.sent_forwarded = sent_forwarded + +class NormalEvent(ChatEvent): + type_ = 'normal' + +class PmEvent(ChatEvent): + type_ = 'pm' + +class PrintedChatEvent(Event): + type_ = 'printed_chat' + def __init__(self, message, subject, control, msg_log_id, time_=None, + show_in_roster=False, show_in_systray=True): + Event.__init__(self, time_, show_in_roster=show_in_roster, + show_in_systray=show_in_systray) + self.message = message + self.subject = subject + self.control = control + self.msg_log_id = msg_log_id + +class PrintedGcMsgEvent(PrintedChatEvent): + type_ = 'printed_gc_msg' + +class PrintedMarkedGcMsgEvent(PrintedChatEvent): + type_ = 'printed_marked_gc_msg' + +class PrintedPmEvent(PrintedChatEvent): + type_ = 'printed_pm' +

1 0

gajim: handle message correction correctly even if we don't prin...
by Gajim 29 Feb '16

29 Feb '16

changeset ad4236d5a427 in /home/hg/repos/gajim author: Yann Leboulanger <asterix(a)lagaule.org> branches: details:http://hg.gajim.org/gajim?cmd=changeset;node=ad4236d5a427 description: handle message correction correctly even if we don't print the message instantly in a chat window. Fixes #8220 diffstat: src/chat_control.py | 5 +++-- src/common/events.py | 5 +++-- src/session.py | 3 ++- 3 files changed, 8 insertions(+), 5 deletions(-) diffs (57 lines): diff -r 5c6c77423355 -r ad4236d5a427 src/chat_control.py --- a/src/chat_control.py Mon Feb 29 21:04:08 2016 +0100 +++ b/src/chat_control.py Mon Feb 29 21:29:20 2016 +0100 @@ -881,7 +881,7 @@ if not count_as_new: return - if kind in ('incoming', 'outgoing'): + if kind in ('incoming', 'incoming_queue', 'outgoing'): self.last_received_txt[name] = text if correct_id: self.last_received_id[name] = correct_id[0] @@ -3022,7 +3022,8 @@ kind = 'out' self.print_conversation(event.message, kind, tim=event.time, encrypted=event.encrypted, subject=event.subject, - xhtml=event.xhtml, displaymarking=event.displaymarking) + xhtml=event.xhtml, displaymarking=event.displaymarking, + correct_id=event.correct_id) if isinstance(event.msg_log_id, int): message_ids.append(event.msg_log_id) diff -r 5c6c77423355 -r ad4236d5a427 src/common/events.py --- a/src/common/events.py Mon Feb 29 21:04:08 2016 +0100 +++ b/src/common/events.py Mon Feb 29 21:29:20 2016 +0100 @@ -65,8 +65,8 @@ class ChatEvent(Event): type_ = 'chat' def __init__ (self, message, subject, kind, time, encrypted, resource, - msg_log_id=None, xhtml=None, session=None, form_node=None, displaymarking=None, - sent_forwarded=False, time_=None, show_in_roster=False, + msg_log_id, correct_id=None, xhtml=None, session=None, form_node=None, + displaymarking=None, sent_forwarded=False, time_=None, show_in_roster=False, show_in_systray=True): Event.__init__(self, time_, show_in_roster=show_in_roster, show_in_systray=show_in_systray) @@ -77,6 +77,7 @@ self.encrypted = encrypted self.resource = resource self.msg_log_id = msg_log_id + self.correct_id = correct_id self.xhtml = xhtml self.session = session self.form_node = form_node diff -r 5c6c77423355 -r ad4236d5a427 src/session.py --- a/src/session.py Mon Feb 29 21:04:08 2016 +0100 +++ b/src/session.py Mon Feb 29 21:29:20 2016 +0100 @@ -255,7 +255,8 @@ if (not self.control and obj.mtype != 'normal') or \ (obj.mtype == 'normal' and not obj.popup): event = event_t(obj.msgtxt, obj.subject, obj.mtype, obj.timestamp, - obj.encrypted, obj.resource, obj.msg_log_id, xhtml=obj.xhtml, + obj.encrypted, obj.resource, obj.msg_log_id, + correct_id=(obj.id_, obj.correct_id), xhtml=obj.xhtml, session=self, form_node=obj.form_node, displaymarking=obj.displaymarking, sent_forwarded=obj.forwarded and obj.sent,

1 0

gajim-plugins: prevent crash when upgrading and no other plugin ...
by Gajim Plugins 27 Feb '16

27 Feb '16

changeset 2560a9ae79ca in /home/hg/repos/gajim-plugins author: Yann Leboulanger <asterix(a)lagaule.org> branches: details:gajim-plugins?cmd=changeset;node=2560a9ae79ca description: prevent crash when upgrading and no other plugin is installed. Fixes #121 diffstat: plugin_installer/manifest.ini | 2 +- plugin_installer/plugin_installer.py | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diffs (27 lines): diff -r 5379369582e4 -r 2560a9ae79ca plugin_installer/manifest.ini --- a/plugin_installer/manifest.ini Mon Feb 08 20:26:32 2016 +0100 +++ b/plugin_installer/manifest.ini Sat Feb 27 13:46:45 2016 +0100 @@ -1,7 +1,7 @@ [info] name: Plugin Installer short_name: plugin_installer -version: 0.11.21 +version: 0.11.22 description: Install and upgrade plugins from ftp authors: Denis Fomin <fominde(a)gmail.com> Yann Leboulanger <asterix(a)lagaule.org> diff -r 5379369582e4 -r 2560a9ae79ca plugin_installer/plugin_installer.py --- a/plugin_installer/plugin_installer.py Mon Feb 08 20:26:32 2016 +0100 +++ b/plugin_installer/plugin_installer.py Sat Feb 27 13:46:45 2016 +0100 @@ -357,7 +357,10 @@ plugin.activatable = False max_row = [plugin, plugin.name, is_active, plugin.activatable, icon] # support old plugin system - row_len = len(self.installed_plugins_model[0]) + if len(self.installed_plugins_model): + row_len = len(self.installed_plugins_model[0]) + else: + row_len = 5 row = max_row[0: row_len] self.installed_plugins_model.append(row)

1 0

gajim: added automatic_message flag to GcMessageOutgoingEvent (b...
by Gajim 22 Feb '16

22 Feb '16

changeset 3fc163aa0369 in /home/hg/repos/gajim author: tmolitor <thilo(a)eightysoft.de> branches: gajim_0.16 details:http://hg.gajim.org/gajim?cmd=changeset;node=3fc163aa0369 description: added automatic_message flag to GcMessageOutgoingEvent (bugfix) diffstat: src/common/connection_handlers_events.py | 1 + src/groupchat_control.py | 3 ++- 2 files changed, 3 insertions(+), 1 deletions(-) diffs (24 lines): diff -r cb53e4ae5b4a -r 3fc163aa0369 src/common/connection_handlers_events.py --- a/src/common/connection_handlers_events.py Sat Feb 20 20:04:47 2016 +0100 +++ b/src/common/connection_handlers_events.py Sun Feb 21 16:45:31 2016 +0100 @@ -2671,6 +2671,7 @@ self.is_loggable = True self.control = None self.correction_msg = None + self.automatic_message = True def generate(self): return True diff -r cb53e4ae5b4a -r 3fc163aa0369 src/groupchat_control.py --- a/src/groupchat_control.py Sat Feb 20 20:04:47 2016 +0100 +++ b/src/groupchat_control.py Sun Feb 21 16:45:31 2016 +0100 @@ -2020,7 +2020,8 @@ gajim.nec.push_outgoing_event(GcMessageOutgoingEvent(None, account=self.account, jid=self.room_jid, message=message, xhtml=xhtml, label=label, callback=_cb, - callback_args=[_cb] + [message], correction_msg=correction_msg)) + callback_args=[_cb] + [message], correction_msg=correction_msg, + automatic_message=False)) self.msg_textview.get_buffer().set_text('') self.msg_textview.grab_focus()

1 0

gajim: Added missing "import hashlib"
by Gajim 22 Feb '16

22 Feb '16

changeset 58023a4af19f in /home/hg/repos/gajim author: tmolitor <thilo(a)eightysoft.de> branches: gajim_0.16 details:http://hg.gajim.org/gajim?cmd=changeset;node=58023a4af19f description: Added missing "import hashlib" diffstat: src/common/connection_handlers_events.py | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diffs (11 lines): diff -r 3fc163aa0369 -r 58023a4af19f src/common/connection_handlers_events.py --- a/src/common/connection_handlers_events.py Sun Feb 21 16:45:31 2016 +0100 +++ b/src/common/connection_handlers_events.py Wed Feb 10 16:56:44 2016 +0100 @@ -24,6 +24,7 @@ from time import (localtime, time as time_time) from calendar import timegm import hmac +import hashlib from common import atom from common import nec

1 0

gajim: don't show delivery error messages for automatic message ...
by Gajim 22 Feb '16

22 Feb '16

changeset 9dade752042f in /home/hg/repos/gajim author: tmolitor <thilo(a)eightysoft.de> branches: gajim_0.16 details:http://hg.gajim.org/gajim?cmd=changeset;node=9dade752042f description: don't show delivery error messages for automatic message stanzas. Fixes #8222 diffstat: src/chat_control.py | 2 +- src/common/connection.py | 56 ++++++++++++++++++++----------- src/common/connection_handlers.py | 4 +- src/common/connection_handlers_events.py | 19 ++++++++++- 4 files changed, 58 insertions(+), 23 deletions(-) diffs (173 lines): diff -r e523ae54f39f -r 9dade752042f src/chat_control.py --- a/src/chat_control.py Sun Feb 21 19:03:44 2016 +0100 +++ b/src/chat_control.py Mon Feb 08 22:31:36 2016 +0100 @@ -866,7 +866,7 @@ keyID=keyID, type_=type_, chatstate=chatstate, msg_id=msg_id, resource=resource, user_nick=self.user_nick, xhtml=xhtml, label=label, callback=_cb, callback_args=[callback] + callback_args, - control=self, attention=attention, correction_msg=correction_msg)) + control=self, attention=attention, correction_msg=correction_msg, automatic_message=False)) # Record the history of sent messages self.save_message(message, 'sent') diff -r e523ae54f39f -r 9dade752042f src/common/connection.py --- a/src/common/connection.py Sun Feb 21 19:03:44 2016 +0100 +++ b/src/common/connection.py Mon Feb 08 22:31:36 2016 +0100 @@ -2115,17 +2115,42 @@ if obj.account != self.name: return + # parameters of this function are packet into _cb_parameters for later usage in _nec_stanza_message_outgoing's cb() def cb(jid, msg, keyID, forward_from, session, original_message, subject, type_, msg_iq, xhtml): if isinstance(msg_iq, list): for iq in msg_iq: gajim.nec.push_incoming_event(StanzaMessageOutgoingEvent( - None, conn=self, msg_iq=iq, now=obj.now)) + None, conn=self, msg_iq=iq, now=obj.now, automatic_message=obj.automatic_message, + _cb_parameters={"jid":jid, "msg":msg, "keyID":keyID, "forward_from":forward_from, + "session":session, "original_message":original_message, "subject":subject, "type_":type_, + "msg_iq":msg_iq, "xhtml":xhtml, "obj":obj})) else: gajim.nec.push_incoming_event(StanzaMessageOutgoingEvent(None, - conn=self, msg_iq=msg_iq, now=obj.now)) + conn=self, msg_iq=msg_iq, now=obj.now, automatic_message=obj.automatic_message, + _cb_parameters={"jid":jid, "msg":msg, "keyID":keyID, "forward_from":forward_from, + "session":session, "original_message":original_message, "subject":subject, "type_":type_, + "msg_iq":msg_iq, "xhtml":xhtml, "obj":obj})) + + self._prepare_message(obj.jid, obj.message, obj.keyID, type_=obj.type_, + subject=obj.subject, chatstate=obj.chatstate, msg_id=obj.msg_id, + resource=obj.resource, user_nick=obj.user_nick, xhtml=obj.xhtml, + label=obj.label, session=obj.session, forward_from=obj.forward_from, + form_node=obj.form_node, original_message=obj.original_message, + delayed=obj.delayed, attention=obj.attention, + correction_msg=obj.correction_msg, callback=cb) + + def _nec_stanza_message_outgoing(self, obj): + if obj.conn.name != self.name: + return + obj.msg_id = self.connection.send(obj.msg_iq, now=obj.now) + + # obj in this function is the obj as seen in _nec_message_outgoing() + def cb(obj, jid, msg, keyID, forward_from, session, original_message, + subject, type_, msg_iq, xhtml, msg_id): gajim.nec.push_incoming_event(MessageSentEvent(None, conn=self, - jid=jid, message=msg, keyID=keyID, chatstate=obj.chatstate)) + jid=jid, message=msg, keyID=keyID, chatstate=obj.chatstate, + automatic_message=obj.automatic_message, msg_id=msg_id)) if obj.callback: obj.callback(msg_iq, *obj.callback_args) @@ -2140,19 +2165,8 @@ else: self.log_message(jid, msg, forward_from, session, original_message, subject, type_, xhtml) - - self._prepare_message(obj.jid, obj.message, obj.keyID, type_=obj.type_, - subject=obj.subject, chatstate=obj.chatstate, msg_id=obj.msg_id, - resource=obj.resource, user_nick=obj.user_nick, xhtml=obj.xhtml, - label=obj.label, session=obj.session, forward_from=obj.forward_from, - form_node=obj.form_node, original_message=obj.original_message, - delayed=obj.delayed, attention=obj.attention, - correction_msg=obj.correction_msg, callback=cb) - - def _nec_stanza_message_outgoing(self, obj): - if obj.conn.name != self.name: - return - obj.msg_id = self.connection.send(obj.msg_iq, now=obj.now) + + cb(msg_id=obj.msg_id, **obj._cb_parameters) def send_contacts(self, contacts, fjid, type_='message'): """ @@ -2707,9 +2721,10 @@ obj.correction_msg.setBody(obj.message) if obj.xhtml: obj.correction_msg.setXHTML(xhtml) - self.connection.send(obj.correction_msg) + obj.msg_id = self.connection.send(obj.correction_msg) gajim.nec.push_incoming_event(MessageSentEvent(None, conn=self, - jid=obj.jid, message=obj.message, keyID=None, chatstate=None)) + jid=obj.jid, message=obj.message, keyID=None, chatstate=None, + automatic_message=obj.automatic_message, msg_id=obj.msg_id)) if obj.callback: obj.callback(obj.correction_msg, obj.message) return @@ -2720,9 +2735,10 @@ xhtml=obj.xhtml) if obj.label is not None: msg_iq.addChild(node=label) - self.connection.send(msg_iq) + obj.msg_id = self.connection.send(msg_iq) gajim.nec.push_incoming_event(MessageSentEvent(None, conn=self, - jid=obj.jid, message=obj.message, keyID=None, chatstate=None)) + jid=obj.jid, message=obj.message, keyID=None, chatstate=None, + automatic_message=obj.automatic_message, msg_id=obj.msg_id)) if obj.callback: obj.callback(msg_iq, obj.message) diff -r e523ae54f39f -r 9dade752042f src/common/connection_handlers.py --- a/src/common/connection_handlers.py Sun Feb 21 19:03:44 2016 +0100 +++ b/src/common/connection_handlers.py Mon Feb 08 22:31:36 2016 +0100 @@ -1237,7 +1237,7 @@ self.dispatch('DB_ERROR', (pritext, sectext)) gajim.nec.push_incoming_event(MessageErrorEvent(None, conn=self, fjid=frm, error_code=msg.getErrorCode(), error_msg=error_msg, - msg=msgtxt, time_=tim, session=session)) + msg=msgtxt, time_=tim, session=session, stanza=msg)) def _LastResultCB(self, con, iq_obj): log.debug('LastResultCB') @@ -1425,6 +1425,8 @@ # ID of urn:xmpp:ping requests self.awaiting_xmpp_ping_id = None self.continue_connect_info = None + # IDs of sent messages (https://trac.gajim.org/ticket/8222) + self.sent_message_ids = [] try: self.sleeper = common.sleepy.Sleepy() diff -r e523ae54f39f -r 9dade752042f src/common/connection_handlers_events.py --- a/src/common/connection_handlers_events.py Sun Feb 21 19:03:44 2016 +0100 +++ b/src/common/connection_handlers_events.py Mon Feb 08 22:31:36 2016 +0100 @@ -1582,14 +1582,30 @@ class MessageSentEvent(nec.NetworkIncomingEvent): name = 'message-sent' base_network_events = [] + + def generate(self): + if not self.automatic_message: + self.conn.sent_message_ids.append(self.msg_id) + # only record the last 20000 message ids (should be about 1MB [36 byte per uuid] + # and about 24 hours if you send out a message every 5 seconds) + self.conn.sent_message_ids = self.conn.sent_message_ids[-20000:] + return True class MessageNotSentEvent(nec.NetworkIncomingEvent): name = 'message-not-sent' base_network_events = [] -class MessageErrorEvent(nec.NetworkIncomingEvent): +class MessageErrorEvent(nec.NetworkIncomingEvent, HelperEvent): name = 'message-error' base_network_events = [] + + def generate(self): + self.get_id() + #only alert for errors of explicitly sent messages (see https://trac.gajim.org/ticket/8222) + if self.id_ in self.conn.sent_message_ids: + self.conn.sent_message_ids.remove(self.id_) + return True + return False class AnonymousAuthEvent(nec.NetworkIncomingEvent): name = 'anonymous-auth' @@ -2610,6 +2626,7 @@ self.control = None self.attention = False self.correction_msg = None + self.automatic_message = True def generate(self): return True

1 0

gajim: Ignore received message duplicates using sender jid, mess...
by Gajim 22 Feb '16

22 Feb '16

changeset f91bc11c887e in /home/hg/repos/gajim author: tmolitor <thilo(a)eightysoft.de> branches: gajim_0.16 details:http://hg.gajim.org/gajim?cmd=changeset;node=f91bc11c887e description: Ignore received message duplicates using sender jid, message id and message content. See #8258 diffstat: src/common/connection_handlers.py | 2 ++ src/common/connection_handlers_events.py | 17 +++++++++++++++++ 2 files changed, 19 insertions(+), 0 deletions(-) diffs (50 lines): diff -r 9dade752042f -r f91bc11c887e src/common/connection_handlers.py --- a/src/common/connection_handlers.py Mon Feb 08 22:31:36 2016 +0100 +++ b/src/common/connection_handlers.py Mon Feb 08 23:08:26 2016 +0100 @@ -2171,6 +2171,8 @@ gajim.nec.push_incoming_event(SignedInEvent(None, conn=self)) self.send_awaiting_pep() self.continue_connect_info = None + # hashes of already received messages + self.received_message_hashes = [] def request_gmail_notifications(self): if not self.connection or self.connected < 2: diff -r 9dade752042f -r f91bc11c887e src/common/connection_handlers_events.py --- a/src/common/connection_handlers_events.py Mon Feb 08 22:31:36 2016 +0100 +++ b/src/common/connection_handlers_events.py Mon Feb 08 23:08:26 2016 +0100 @@ -1393,10 +1393,12 @@ self.encrypted = self.msg_obj.encrypted self.forwarded = self.msg_obj.forwarded self.sent = self.msg_obj.sent + self.conn = self.msg_obj.conn self.popup = False self.msg_id = None # id in log database self.attention = False # XEP-0224 self.correct_id = None # XEP-0308 + self.msghash = None self.receipt_request_tag = self.stanza.getTag('request', namespace=nbxmpp.NS_RECEIPTS) @@ -1447,6 +1449,21 @@ if replace: self.correct_id = replace.getAttr('id') + # ignore message duplicates + if self.msgtxt and self.id_ and self.jid: + self.msghash = hashlib.sha256("%s|%s|%s" % ( + hashlib.sha256(str(self.msgtxt)).hexdigest(), + hashlib.sha256(str(self.id_)).hexdigest(), + hashlib.sha256(str(self.jid)).hexdigest())).digest() + if self.msghash in self.conn.received_message_hashes: + log.info("Ignoring duplicated message from '%s' with id '%s'" % (str(self.jid), str(self.id_))) + return False + else: + log.debug("subhashes: msgtxt, id_, jid = ('%s', '%s', '%s')" % (hashlib.sha256(str(self.msgtxt)).hexdigest(), hashlib.sha256(str(self.id_)).hexdigest(), hashlib.sha256(str(self.jid)).hexdigest())) + self.conn.received_message_hashes.append(self.msghash) + # only record the last 20000 hashes (should be about 1MB [32 bytes per hash] + # and about 24 hours if you receive a message every 5 seconds) + self.conn.received_message_hashes = self.conn.received_message_hashes[-20000:] return True class ChatstateReceivedEvent(nec.NetworkIncomingEvent):

1 0

gajim: reply to message receipt only when we are the recipient o...
by Gajim 22 Feb '16

22 Feb '16

changeset cb53e4ae5b4a in /home/hg/repos/gajim author: Yann Leboulanger <asterix(a)lagaule.org> branches: gajim_0.16 details:http://hg.gajim.org/gajim?cmd=changeset;node=cb53e4ae5b4a description: reply to message receipt only when we are the recipient of the message. see #7548. [tmolitor] display message receipt (xep 0184) for carbon copied messages. Fixes #8258 diffstat: src/common/connection_handlers.py | 11 ++++++++++- src/common/connection_handlers_events.py | 3 +++ src/roster_window.py | 5 ++++- 3 files changed, 17 insertions(+), 2 deletions(-) diffs (60 lines): diff -r f91bc11c887e -r cb53e4ae5b4a src/common/connection_handlers.py --- a/src/common/connection_handlers.py Mon Feb 08 23:08:26 2016 +0100 +++ b/src/common/connection_handlers.py Sat Feb 20 20:04:47 2016 +0100 @@ -1171,10 +1171,19 @@ contact = gajim.contacts.get_contact(self.name, obj.jid) nick = obj.resource gc_contact = gajim.contacts.get_gc_contact(self.name, obj.jid, nick) + jid_to = obj.stanza.getTo() + reply = False + if not jid_to: + reply = True + else: + fjid_to = helpers.parse_jid(str(jid_to)) + jid_to = gajim.get_jid_without_resource(fjid_to) + if jid_to == gajim.get_jid_from_account(self.name): + reply = True if obj.receipt_request_tag and gajim.config.get_per('accounts', self.name, 'answer_receipts') and ((contact and contact.sub \ not in (u'to', u'none')) or gc_contact) and obj.mtype != 'error' and \ - not obj.forwarded: + reply: receipt = nbxmpp.Message(to=obj.fjid, typ='chat') receipt.setID(obj.id_) receipt.setTag('received', namespace='urn:xmpp:receipts', diff -r f91bc11c887e -r cb53e4ae5b4a src/common/connection_handlers_events.py --- a/src/common/connection_handlers_events.py Mon Feb 08 23:08:26 2016 +0100 +++ b/src/common/connection_handlers_events.py Sat Feb 20 20:04:47 2016 +0100 @@ -2358,6 +2358,9 @@ self.control_focused = True def handle_incoming_msg_event(self, msg_obj): + # don't alert for carbon copied messages from ourselves + if msg_obj.sent: + return if not msg_obj.msgtxt: return self.jid = msg_obj.jid diff -r f91bc11c887e -r cb53e4ae5b4a src/roster_window.py --- a/src/roster_window.py Mon Feb 08 23:08:26 2016 +0100 +++ b/src/roster_window.py Sat Feb 20 20:04:47 2016 +0100 @@ -2739,15 +2739,18 @@ return if obj.session.control and obj.mtype == 'chat': typ = '' + xep0184_id = None if obj.mtype == 'error': typ = 'error' if obj.forwarded and obj.sent: typ = 'out' + xep0184_id = obj.id_ obj.session.control.print_conversation(obj.msgtxt, typ, tim=obj.timestamp, encrypted=obj.encrypted, subject=obj.subject, xhtml=obj.xhtml, displaymarking=obj.displaymarking, - msg_id=obj.msg_id, correct_id=(obj.id_, obj.correct_id)) + msg_id=obj.msg_id, correct_id=(obj.id_, obj.correct_id), + xep0184_id=xep0184_id) if obj.msg_id: pw = obj.session.control.parent_win end = obj.session.control.was_at_the_end

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits February 2016