Commits March 2020

commits@gajim.org

1 participants
104 discussions

[Git][gajim/gajim][master] 3 commits: MAM: Refactor handling query result
by Philipp Hörist 31 Mar '20

31 Mar '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 8744bc0e by lovetox at 2020-03-31T22:20:49+02:00 MAM: Refactor handling query result - - - - - af663ca7 by lovetox at 2020-03-31T22:20:49+02:00 MAM: Always include JID in logging messages - - - - - 798a9812 by lovetox at 2020-03-31T22:20:49+02:00 MAM: Refactor handling interval query result - - - - - 1 changed file: - gajim/common/modules/mam.py Changes: ===================================== gajim/common/modules/mam.py ===================================== @@ -264,7 +264,7 @@ class MAM(BaseModule): own_jid = self._con.get_own_jid().getBare() if own_jid in self._mam_query_ids: - self._log.warning('MAM request for %s already running', own_jid) + self._log.warning('Request already running: %s', own_jid) return archive = app.logger.get_archive_infos(own_jid) @@ -281,12 +281,14 @@ class MAM(BaseModule): start_date = None queryid = self._get_query_id(own_jid) if mam_id: - self._log.info('MAM query after: %s', mam_id) + self._log.info('Request archive: %s, after mam-id %s', + own_jid, mam_id) else: # First Start, we request the last week start_date = datetime.utcnow() - timedelta(days=7) - self._log.info('First start: query archive start: %s', start_date) + self._log.info('Request archive: %s, after date %s', + own_jid, start_date) self._nbxmpp('MAM').make_query(own_jid, queryid, @@ -310,14 +312,14 @@ class MAM(BaseModule): if archive is None or archive.last_mam_id is None: # First join start_date = datetime.utcnow() - timedelta(days=1) - self._log.info('First join: query archive %s from: %s', + self._log.info('Request archive: %s, after date %s', jid, start_date) elif threshold == SyncThreshold.NO_THRESHOLD: # Not our first join and no threshold set mam_id = archive.last_mam_id - self._log.info('Request from archive: %s, after mam-id %s', + self._log.info('Request archive: %s, after mam-id %s', jid, archive.last_mam_id) else: @@ -325,7 +327,7 @@ class MAM(BaseModule): # last join and check against threshold last_timestamp = archive.last_muc_timestamp if last_timestamp is None: - self._log.info('No last muc timestamp found') + self._log.info('No last muc timestamp found: %s', jid) last_timestamp = 0 last = datetime.utcfromtimestamp(float(last_timestamp)) @@ -333,13 +335,13 @@ class MAM(BaseModule): # To much time has elapsed since last join, apply threshold start_date = datetime.utcnow() - timedelta(days=threshold) self._log.info('Too much time elapsed since last join, ' - 'request from: %s, threshold: %s', - start_date, threshold) + 'request archive: %s, after date %s, ' + 'threshold: %s', jid, start_date, threshold) else: # Request from last mam-id mam_id = archive.last_mam_id - self._log.info('Request from archive %s after %s:', + self._log.info('Request archive: %s, after mam-id %s:', jid, archive.last_mam_id) if jid in self._catch_up_finished: @@ -368,12 +370,28 @@ class MAM(BaseModule): self.request_archive_on_signin() return - if result.rsm.last is None: - self._log.info('MAM catchup finished: %s', result.jid) + if result.complete: self._catch_up_finished.append(result.jid) - return + self._log.info('Request finished: %s, last mam id: %s', + result.jid, result.rsm.last) + + if result.rsm.last is not None: + # <last> is not provided if the requested page was empty + # so this means we did not get anything hence we only need + # to update the archive info if <last> is present + app.logger.set_archive_infos(result.jid, + last_mam_id=result.rsm.last, + last_muc_timestamp=time.time()) - if not result.complete: + if start_date is not None and not groupchat: + # Record the earliest timestamp we request from + # the account archive. For the account archive we only + # set start_date at the very first request. + app.logger.set_archive_infos( + result.jid, + oldest_mam_timestamp=start_date.timestamp()) + + else: app.logger.set_archive_infos(result.jid, last_mam_id=result.rsm.last) queryid = self._get_query_id(result.jid) @@ -386,36 +404,20 @@ class MAM(BaseModule): 'start': None, 'groupchat': groupchat}) - else: - app.logger.set_archive_infos(result.jid, - last_mam_id=result.rsm.last, - last_muc_timestamp=time.time()) - - if start_date is not None and not groupchat: - # Record the earliest timestamp we request from - # the account archive. For the account archive we only - # set start_date at the very first request. - app.logger.set_archive_infos( - result.jid, - oldest_mam_timestamp=start_date.timestamp()) - - self._catch_up_finished.append(result.jid) - self._log.info('End of MAM query, last mam id: %s', - result.rsm.last) - def request_archive_interval(self, start_date, end_date, after=None, queryid=None): + jid = self._con.get_own_jid().getBare() + if after is None: - self._log.info('Request interval from %s to %s', - start_date, end_date) + self._log.info('Request interval: %s, from %s to %s', + jid, start_date, end_date) else: - self._log.info('Query page after %s', after) + self._log.info('Request page: %s, after %s', jid, after) - jid = self._con.get_own_jid().getBare() if queryid is None: queryid = self._get_query_id(jid) self._mam_query_ids[jid] = queryid @@ -443,30 +445,21 @@ class MAM(BaseModule): else: timestamp = ArchiveState.ALL - if result.rsm.last is None: + if result.complete: + self._log.info('Request finished: %s, last mam id: %s', + result.jid, result.rsm.last) + app.logger.set_archive_infos(result.jid, + oldest_mam_timestamp=timestamp) app.nec.push_incoming_event(NetworkEvent( 'archiving-interval-finished', account=self._account, query_id=queryid)) - app.logger.set_archive_infos(result.jid, - oldest_mam_timestamp=timestamp) - self._log.info('End of MAM request, no items retrieved') - return - - if not result.complete: + else: self.request_archive_interval(start_date, end_date, result.rsm.last, queryid) - else: - self._log.info('Request finished') - app.logger.set_archive_infos(result.jid, - oldest_mam_timestamp=timestamp) - app.nec.push_incoming_event(NetworkEvent( - 'archiving-interval-finished', - account=self._account, - query_id=queryid)) def get_instance(*args, **kwargs): View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/36940440f9bbfaac71d3f94d60ebce2… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/36940440f9bbfaac71d3f94d60ebce2… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/python-nbxmpp][master] MUC: Improve muc user info parsing
by Philipp Hörist 30 Mar '20

30 Mar '20

Philipp Hörist pushed to branch master at gajim / python-nbxmpp Commits: dd3108eb by lovetox at 2020-03-30T22:26:26+02:00 MUC: Improve muc user info parsing - - - - - 1 changed file: - nbxmpp/modules/muc.py Changes: ===================================== nbxmpp/modules/muc.py ===================================== @@ -32,6 +32,8 @@ from nbxmpp.protocol import DataForm from nbxmpp.protocol import DataField from nbxmpp.protocol import isResultNode from nbxmpp.protocol import NodeProcessed +from nbxmpp.protocol import StanzaMalformed +from nbxmpp.protocol import InvalidJid from nbxmpp.simplexml import Node from nbxmpp.structs import StanzaHandler from nbxmpp.const import InviteType @@ -160,7 +162,12 @@ class MUC(BaseModule): if codes: properties.muc_status_codes = codes - properties.muc_user = self._parse_muc_user(muc_user) + try: + properties.muc_user = self._parse_muc_user(muc_user) + except StanzaMalformed as error: + self._log.warning(error) + self._log.warning(stanza) + raise NodeProcessed def _process_groupchat_message(self, _client, stanza, properties): properties.from_muc = True @@ -170,7 +177,12 @@ class MUC(BaseModule): muc_user = stanza.getTag('x', namespace=NS_MUC_USER) if muc_user is not None: - properties.muc_user = self._parse_muc_user(muc_user) + try: + properties.muc_user = self._parse_muc_user(muc_user) + except StanzaMalformed as error: + self._log.warning(error) + self._log.warning(stanza) + raise NodeProcessed addresses = stanza.getTag('addresses', namespace=NS_ADDRESS) if addresses is not None: @@ -533,22 +545,36 @@ class MUC(BaseModule): if item is None: return None - item_dict = item.getAttrs(copy=True) - if 'role' in item_dict: - item_dict['role'] = Role(item_dict['role']) - else: - item_dict['role'] = None + item_dict = item.getAttrs() - if 'affiliation' in item_dict: - item_dict['affiliation'] = Affiliation(item_dict['affiliation']) - else: - item_dict['affiliation'] = None + role = item_dict.get('role') + if role is None: + raise StanzaMalformed('role attr missing') - if 'jid' in item_dict: - item_dict['jid'] = JID(item_dict['jid']) - else: - item_dict['jid'] = None + try: + role = Role(role) + except ValueError: + raise StanzaMalformed('invalid role %s' % role) + + affiliation = item_dict.get('affiliation') + if affiliation is None: + raise StanzaMalformed('affiliation attr missing') - item_dict['actor'] = item.getTagAttr('actor', 'nick') - item_dict['reason'] = item.getTagData('reason') - return MucUserData(**item_dict) + try: + affiliation = Affiliation(affiliation) + except ValueError: + raise StanzaMalformed('invalid affiliation %s' % affiliation) + + jid = item_dict.get('jid') + if jid is not None: + try: + jid = JID(jid) + except InvalidJid as error: + raise StanzaMalformed('invalid jid %s, %s' % (jid, error)) + + return MucUserData(affiliation=affiliation, + jid=jid, + nick=item.getAttr('nick'), + role=role, + actor=item.getTagAttr('actor', 'nick'), + reason=item.getTagData('reason')) View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/dd3108eba7e6c63e915f604b… -- View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/dd3108eba7e6c63e915f604b… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] ChatControlBase: Don’t allow dropping data on message input
by Philipp Hörist 29 Mar '20

29 Mar '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 36940440 by Daniel Brötzmann at 2020-03-29T09:14:30+02:00 ChatControlBase: Don’t allow dropping data on message input - - - - - 1 changed file: - gajim/chat_control_base.py Changes: ===================================== gajim/chat_control_base.py ===================================== @@ -201,6 +201,7 @@ class ChatControlBase(ChatCommandProcessor, CommandTools, EventHelper): # add MessageInputTextView to UI and connect signals self.msg_textview = MessageInputTextView() + self.msg_textview.drag_dest_unset() self.msg_scrolledwindow = ScrolledWindow() self.msg_scrolledwindow.add(self.msg_textview) @@ -217,15 +218,6 @@ class ChatControlBase(ChatCommandProcessor, CommandTools, EventHelper): self.on_msg_textview_populate_popup) self.handlers[id_] = self.msg_textview - # Setup DND - id_ = self.msg_textview.connect('drag_data_received', - self._on_drag_data_received) - self.handlers[id_] = self.msg_textview - self.msg_textview.drag_dest_set( - Gtk.DestDefaults.ALL, - self.dnd_list, - Gdk.DragAction.COPY) - # the following vars are used to keep history of user's messages self.sent_history = [] self.sent_history_pos = 0 View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/36940440f9bbfaac71d3f94d60ebce2c… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/36940440f9bbfaac71d3f94d60ebce2c… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Interface: Close all account related windows on disable
by Philipp Hörist 29 Mar '20

29 Mar '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 29b5abc7 by lovetox at 2020-03-29T09:11:11+02:00 Interface: Close all account related windows on disable - - - - - 2 changed files: - gajim/gtk/util.py - gajim/gui_interface.py Changes: ===================================== gajim/gtk/util.py ===================================== @@ -700,6 +700,15 @@ def make_href_markup(string): return URL_REGEX.sub(_to_href, string) +def get_app_windows(account): + windows = [] + for win in app.app.get_windows(): + if hasattr(win, 'account'): + if win.account == account: + windows.append(win) + return windows + + def get_app_window(name, account=None, jid=None): for win in app.app.get_windows(): if type(win).__name__ != name: ===================================== gajim/gui_interface.py ===================================== @@ -105,6 +105,7 @@ from gajim.gtk.util import get_show_in_roster from gajim.gtk.util import get_show_in_systray from gajim.gtk.util import open_window from gajim.gtk.util import get_app_window +from gajim.gtk.util import get_app_windows from gajim.gtk.const import ControlType @@ -1751,6 +1752,11 @@ class Interface: for jid in self.minimized_controls[account]: ctrl = self.minimized_controls[account][jid] ctrl.shutdown() + + for win in get_app_windows(account): + # Close all account specific windows + win.destroy() + if account == app.ZEROCONF_ACC_NAME: app.connections[account].disable_account() app.connections[account].cleanup() View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/29b5abc70e12055c1da3962ea830665a… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/29b5abc70e12055c1da3962ea830665a… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] AccountWizard: Update account switch after adding account
by Philipp Hörist 29 Mar '20

29 Mar '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 08b372d9 by Daniel Brötzmann at 2020-03-29T08:22:03+02:00 AccountWizard: Update account switch after adding account - - - - - 2 changed files: - gajim/gtk/accounts.py - gajim/gui_interface.py Changes: ===================================== gajim/gtk/accounts.py ===================================== @@ -169,6 +169,9 @@ class AccountsWindow(Gtk.ApplicationWindow): log.warning('select_account() failed, account %s not found', account) + def enable_account(self, account, state): + self._accounts[account].enable_account(state) + class Settings(Gtk.ScrolledWindow): def __init__(self): @@ -436,6 +439,9 @@ class Account: self._account_row.update_account_label() self._menu.update_account_label(self._account) + def enable_account(self, state): + self._account_row.enable_account(state) + @property def menu(self): return self._menu @@ -469,14 +475,14 @@ class AccountRow(Gtk.ListBoxRow): Gtk.IconSize.MENU) next_icon.get_style_context().add_class('insensitive-fg-color') - switch = Gtk.Switch() - switch.set_active( + self._switch = Gtk.Switch() + self._switch.set_active( app.config.get_per('accounts', self._account, 'active')) - switch.set_vexpand(False) + self._switch.set_vexpand(False) if (self._account == app.ZEROCONF_ACC_NAME and not app.is_installed('ZEROCONF')): - switch.set_active(False) + self._switch.set_active(False) self.set_activatable(False) self.set_sensitive(False) if sys.platform in ('win32', 'darwin'): @@ -485,9 +491,10 @@ class AccountRow(Gtk.ListBoxRow): tooltip = _('Please check if Avahi is installed.') self.set_tooltip_text(tooltip) - switch.connect('state-set', self._on_enable_switch, self._account) + self._switch.connect( + 'state-set', self._on_enable_switch, self._account) - box.add(switch) + box.add(self._switch) box.add(self._label) box.add(next_icon) self.add(box) @@ -503,6 +510,9 @@ class AccountRow(Gtk.ListBoxRow): def update_account_label(self): self._label.set_text(app.get_account_label(self._account)) + def enable_account(self, state): + self._switch.set_state(state) + def _on_enable_switch(self, switch, state, account): def _disable(): app.connections[account].change_status('offline', 'offline') ===================================== gajim/gui_interface.py ===================================== @@ -1742,6 +1742,9 @@ class Interface: self.roster.send_status(account, 'online', '') app.config.set_per('accounts', account, 'active', True) app.app.update_app_actions_state() + window = get_app_window('AccountsWindow') + if window is not None: + GLib.idle_add(window.enable_account, account, True) def disable_account(self, account): self.roster.close_all(account, force=True) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/08b372d960065c5dfb8e5fc37a8e3334… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/08b372d960065c5dfb8e5fc37a8e3334… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Refactor passwords
by Philipp Hörist 29 Mar '20

29 Mar '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 7d3eb49d by André at 2020-03-29T08:18:18+02:00 Refactor passwords - - - - - 1 changed file: - gajim/common/passwords.py Changes: ===================================== gajim/common/passwords.py ===================================== @@ -21,6 +21,7 @@ # along with Gajim. If not, see <http://www.gnu.org/licenses/>. import logging +import keyring from gajim.common import app @@ -29,155 +30,104 @@ __all__ = ['get_password', 'save_password'] log = logging.getLogger('gajim.password') -try: - import keyring - from keyring.core import recommended - KEYRING_AVAILABLE = True -except ImportError: - KEYRING_AVAILABLE = False - log.warning('python-keyring missing, falling back to plaintext storage') +backends = keyring.backend.get_all_keyring() +for backend in backends: + log.info('Found keyring backend: %s', backend) +keyring_backend = keyring.get_keyring() +log.info('Select %s backend', keyring_backend) -class PasswordStorage: - """Interface for password stores""" - def get_password(self, account_name): - """Return the password for account_name, or None if not found.""" - raise NotImplementedError +KEYRING_AVAILABLE = any(keyring.core.recommended(backend) + for backend in backends) - def save_password(self, account_name, password): - """Save password for account_name. Return a bool indicating success.""" - raise NotImplementedError - def delete_password(self, account_name): - """Delete password for account_name. Return a bool indicating success.""" - raise NotImplementedError +class SecretPasswordStorage: + """ + Store password using Keyring + """ -class SecretPasswordStorage(PasswordStorage): - """ Store password using Keyring """ - identifier = 'keyring:' - - def __init__(self): - self.keyring = keyring.get_keyring() - log.info('Select %s backend', self.keyring) - - def save_password(self, account_name, password): + @staticmethod + def save_password(account_name, password): + if not KEYRING_AVAILABLE: + log.warning('No recommended keyring backend available.' + 'Passwords cannot be stored.') + return True try: log.info('Save password to keyring') - self.keyring.set_password('gajim', account_name, password) + keyring_backend.set_password('gajim', account_name, password) return True except Exception: log.exception('Save password failed') return False - def get_password(self, account_name): + @staticmethod + def get_password(account_name): log.info('Request password from keyring') + if not KEYRING_AVAILABLE: + return try: - return self.keyring.get_password('gajim', account_name) + # For security reasons remove clear-text password + ConfigPasswordStorage.delete_password(account_name) + return keyring_backend.get_password('gajim', account_name) except Exception: log.exception('Request password failed') return - def delete_password(self, account_name): + @staticmethod + def delete_password(account_name): log.info('Remove password from keyring') + if not KEYRING_AVAILABLE: + return try: - return self.keyring.delete_password('gajim', account_name) + return keyring_backend.delete_password('gajim', account_name) except keyring.errors.PasswordDeleteError as error: log.warning('Removing password failed: %s', error) except Exception: log.exception('Removing password failed') -class PasswordStorageManager(PasswordStorage): - """Access all the implemented password storage backends, knowing which ones - are available and which we prefer to use. - Also implements storing directly in gajim config.""" +class ConfigPasswordStorage: + """ + Store password directly in Gajim's config + """ - def __init__(self): - self.preferred_backend = None + @staticmethod + def get_password(account_name): + return app.config.get_per('accounts', account_name, 'password') - self.secret = None - - self.connect_backends() - self.set_preferred_backend() + @staticmethod + def save_password(account_name, password): + app.config.set_per('accounts', account_name, 'password', password) + return True - def connect_backends(self): - """Initialize backend connections, determining which ones are available. - """ + @staticmethod + def delete_password(account_name): + app.config.set_per('accounts', account_name, 'password', '') + return True - if not app.config.get('use_keyring') or not KEYRING_AVAILABLE: - return - backends = keyring.backend.get_all_keyring() - for backend in backends: - log.info('Found keyring backend: %s', backend) - - for backend in backends: - if recommended(backend): - self.secret = SecretPasswordStorage() - return - log.warning('No recommended keyring backend found, ' - 'plain storage is used') - - def get_password(self, account_name): - pw = app.config.get_per('accounts', account_name, 'password') - if not pw: - return pw - if pw.startswith(SecretPasswordStorage.identifier) and self.secret: - backend = self.secret - else: - backend = None - - if backend: - pw = backend.get_password(account_name) - - if backend != self.preferred_backend: - # migrate password to preferred_backend - self.save_password(account_name, pw) - return pw - - def save_password(self, account_name, password): - if account_name in app.connections: - app.connections[account_name].password = password - - if not app.config.get_per('accounts', account_name, 'savepass'): - return True +def get_password(account_name): + if app.config.get('use_keyring'): + return SecretPasswordStorage.get_password(account_name) + return ConfigPasswordStorage.get_password(account_name) - if self.preferred_backend: - if self.preferred_backend.save_password(account_name, password): - app.config.set_per('accounts', account_name, 'password', - self.preferred_backend.identifier) - else: - app.config.set_per('accounts', account_name, 'password', password) - return True - def delete_password(self, account_name): - if account_name in app.connections: - app.connections[account_name].password = None +def save_password(account_name, password): + if account_name in app.connections: + app.connections[account_name].password = password - if self.preferred_backend is not None: - self.preferred_backend.delete_password(account_name) - app.config.set_per('accounts', account_name, 'password', None) + if not app.config.get_per('accounts', account_name, 'savepass'): return True - def set_preferred_backend(self): - if self.secret: - self.preferred_backend = self.secret - else: - self.preferred_backend = None + if app.config.get('use_keyring'): + return SecretPasswordStorage.save_password(account_name, password) + return ConfigPasswordStorage.save_password(account_name, password) -passwordStorageManager = None - -def get_storage(): - global passwordStorageManager - if not passwordStorageManager: - passwordStorageManager = PasswordStorageManager() - return passwordStorageManager - -def get_password(account_name): - return get_storage().get_password(account_name) def delete_password(account_name): - return get_storage().delete_password(account_name) + if account_name in app.connections: + app.connections[account_name].password = None -def save_password(account_name, password): - return get_storage().save_password(account_name, password) + if app.config.get('use_keyring'): + return SecretPasswordStorage.delete_password(account_name) + return ConfigPasswordStorage.delete_password(account_name) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/7d3eb49dfd37782f0449775063c93cff… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/7d3eb49dfd37782f0449775063c93cff… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 3 commits: MAM: Use nbxmpp methods
by Philipp Hörist 28 Mar '20

28 Mar '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 9bb4c42a by lovetox at 2020-03-28T23:07:36+01:00 MAM: Use nbxmpp methods - - - - - f92842d7 by lovetox at 2020-03-28T23:07:44+01:00 MAM: Remove mam:1 support - - - - - d7c0852f by lovetox at 2020-03-28T23:07:44+01:00 MUC: Only depend on MAM for history - - - - - 9 changed files: - gajim/application.py - gajim/common/logger.py - gajim/common/modules/mam.py - gajim/common/modules/message.py - gajim/common/modules/muc.py - gajim/gtk/groupchat_info.py - gajim/gtk/history_sync.py - gajim/gtk/mam_preferences.py - gajim/gtk/server_info.py Changes: ===================================== gajim/application.py ===================================== @@ -593,7 +593,7 @@ class GajimApplication(Gtk.Application): if event.feature == nbxmpp.NS_VCARD: action = '%s-profile' % event.account self.lookup_action(action).set_enabled(True) - elif event.feature in (nbxmpp.NS_MAM_1, nbxmpp.NS_MAM_2): + elif event.feature == nbxmpp.NS_MAM_2: action = '%s-archive' % event.account self.lookup_action(action).set_enabled(True) elif event.feature == nbxmpp.NS_PRIVACY: ===================================== gajim/common/logger.py ===================================== @@ -1333,42 +1333,6 @@ class Logger: return True return False - @timeit - def search_for_duplicate(self, account, jid, timestamp, msg): - """ - Check if a message is already in the `logs` table - - :param account: The account - - :param jid: The jid as string - - :param timestamp: The timestamp in UTC epoch - - :param msg: The message text - """ - - # Add 10 seconds around the timestamp - start_time = timestamp - 30 - end_time = timestamp + 30 - - account_id = self.get_account_id(account) - log.debug('start: %s, end: %s, jid: %s, message: %s', - start_time, end_time, jid, msg) - - sql = ''' - SELECT * FROM logs - NATURAL JOIN jids WHERE jid = ? AND message = ? AND account_id = ? - AND time BETWEEN ? AND ? - ''' - - result = self._con.execute( - sql, (jid, msg, account_id, start_time, end_time)).fetchone() - - if result is not None: - log.debug('Message already in DB') - return True - return False - @timeit def find_stanza_id(self, account, archive_jid, stanza_id, origin_id=None, groupchat=False): @@ -1679,6 +1643,23 @@ class Logger: log.info('Set message archive info: %s %s', jid, kwargs) self._timeout_commit() + @timeit + def reset_archive_infos(self, jid): + """ + Set archive infos + + :param jid: The jid of the archive + + """ + jid_id = self.get_jid_id(jid) + sql = '''UPDATE last_archive_message + SET last_mam_id = NULL, oldest_mam_timestamp = NULL, + last_muc_timestamp = NULL + WHERE jid_id = ?''' + self._con.execute(sql, (jid_id,)) + log.info('Reset message archive info: %s', jid) + self._timeout_commit() + @timeit def _fill_disco_info_cache(self): sql = '''SELECT disco_info as "disco_info [disco_info]", ===================================== gajim/common/modules/mam.py ===================================== @@ -15,10 +15,12 @@ # XEP-0313: Message Archive Management import time -from datetime import datetime, timedelta +from datetime import datetime +from datetime import timedelta import nbxmpp from nbxmpp.util import generate_id +from nbxmpp.util import is_error_result from nbxmpp.structs import StanzaHandler from gajim.common import app @@ -36,6 +38,14 @@ from gajim.common.modules.base import BaseModule class MAM(BaseModule): + + _nbxmpp_extends = 'MAM' + _nbxmpp_methods = [ + 'request_preferences', + 'set_preferences', + 'make_query', + ] + def __init__(self, con): BaseModule.__init__(self, con) @@ -49,33 +59,30 @@ class MAM(BaseModule): ] self.available = False - self.archiving_namespace = None self._mam_query_ids = {} # Holds archive jids where catch up was successful self._catch_up_finished = [] def pass_disco(self, info): - if nbxmpp.NS_MAM_2 in info.features: - self.archiving_namespace = nbxmpp.NS_MAM_2 - elif nbxmpp.NS_MAM_1 in info.features: - self.archiving_namespace = nbxmpp.NS_MAM_1 - else: + if nbxmpp.NS_MAM_2 not in info.features: return self.available = True - self._log.info('Discovered MAM %s: %s', - self.archiving_namespace, info.jid) + self._log.info('Discovered MAM: %s', info.jid) app.nec.push_incoming_event( NetworkEvent('feature-discovered', account=self._account, - feature=self.archiving_namespace)) + feature=nbxmpp.NS_MAM_2)) def reset_state(self): self._mam_query_ids.clear() self._catch_up_finished.clear() + def _remove_query_id(self, jid): + self._mam_query_ids.pop(jid, None) + def is_catch_up_finished(self, jid): return jid in self._catch_up_finished @@ -112,27 +119,26 @@ class MAM(BaseModule): if properties.type.is_groupchat: archive_jid = properties.jid.getBare() + timestamp = properties.timestamp + disco_info = app.logger.get_last_disco_info(archive_jid) if disco_info is None: # This is the case on MUC creation # After MUC configuration we receive a configuration change # message before we had the chance to disco the new MUC return - namespace = disco_info.mam_namespace - timestamp = properties.timestamp - if namespace is None: - # MUC History - app.logger.set_archive_infos( - archive_jid, - last_muc_timestamp=timestamp) + + if disco_info.mam_namespace != nbxmpp.NS_MAM_2: return else: + if not self.available: + return + archive_jid = self._con.get_own_jid().getBare() - namespace = self.archiving_namespace timestamp = None - if properties.stanza_id is None or namespace != nbxmpp.NS_MAM_2: + if properties.stanza_id is None: return if not archive_jid == properties.stanza_id.by: @@ -179,16 +185,15 @@ class MAM(BaseModule): stanza_id, message_id = self._get_unique_id(properties) - if properties.mam.is_ver_2: - # Search only with stanza-id for duplicates on mam:2 - if app.logger.find_stanza_id(self._account, - str(properties.mam.archive), - stanza_id, - message_id, - groupchat=is_groupchat): - self._log.info('Found duplicate with stanza-id: %s, ' - 'message-id: %s', stanza_id, message_id) - raise nbxmpp.NodeProcessed + # Search for duplicates + if app.logger.find_stanza_id(self._account, + str(properties.mam.archive), + stanza_id, + message_id, + groupchat=is_groupchat): + self._log.info('Found duplicate with stanza-id: %s, ' + 'message-id: %s', stanza_id, message_id) + raise nbxmpp.NodeProcessed additional_data = AdditionalDataDict() if properties.has_user_delay: @@ -223,12 +228,6 @@ class MAM(BaseModule): return stanza_id = message_id - if properties.mam.namespace == nbxmpp.NS_MAM_1: - if app.logger.search_for_duplicate( - self._account, with_, properties.mam.timestamp, msgtxt): - self._log.info('Found duplicate with fallback for mam:1') - return - app.logger.insert_into_logs(self._account, with_, properties.mam.timestamp, @@ -253,7 +252,7 @@ class MAM(BaseModule): ) def _is_valid_request(self, properties): - valid_id = self._mam_query_ids.get(str(properties.mam.archive), None) + valid_id = self._mam_query_ids.get(properties.mam.archive, None) return valid_id == properties.mam.query_id def _get_query_id(self, jid): @@ -261,59 +260,8 @@ class MAM(BaseModule): self._mam_query_ids[jid] = query_id return query_id - def _parse_iq(self, stanza): - if not nbxmpp.isResultNode(stanza): - self._log.error('Error on MAM query: %s', stanza.getError()) - raise InvalidMamIQ - - fin = stanza.getTag('fin') - if fin is None: - self._log.error('Malformed MAM query result received: %s', stanza) - raise InvalidMamIQ - - set_ = fin.getTag('set', namespace=nbxmpp.NS_RSM) - if set_ is None: - self._log.error( - 'Malformed MAM query result received (no "set" Node): %s', - stanza) - raise InvalidMamIQ - return fin, set_ - - def _get_from_jid(self, stanza): - jid = stanza.getFrom() - if jid is None: - # No from means, iq from our own archive - jid = self._con.get_own_jid().getStripped() - else: - jid = jid.getStripped() - return jid - - def request_archive_count(self, start_date, end_date): - jid = self._con.get_own_jid().getStripped() - self._log.info('Request archive count from: %s', jid) - query_id = self._get_query_id(jid) - query = self._get_archive_query( - query_id, start=start_date, end=end_date, max_=0) - self._con.connection.SendAndCallForResponse( - query, self._received_count, {'query_id': query_id}) - return query_id - - def _received_count(self, _nbxmpp_client, stanza, query_id): - try: - _, set_ = self._parse_iq(stanza) - except InvalidMamIQ: - return - - jid = self._get_from_jid(stanza) - self._mam_query_ids.pop(jid) - - count = set_.getTagData('count') - self._log.info('Received archive count: %s', count) - app.nec.push_incoming_event(ArchivingCountReceived( - None, query_id=query_id, count=count)) - def request_archive_on_signin(self): - own_jid = self._con.get_own_jid().getStripped() + own_jid = self._con.get_own_jid().getBare() if own_jid in self._mam_query_ids: self._log.warning('MAM request for %s already running', own_jid) @@ -331,49 +279,53 @@ class MAM(BaseModule): app.config.del_per('accounts', self._account, 'last_mam_id') start_date = None - query_id = self._get_query_id(own_jid) + queryid = self._get_query_id(own_jid) if mam_id: self._log.info('MAM query after: %s', mam_id) - query = self._get_archive_query(query_id, after=mam_id) + else: # First Start, we request the last week start_date = datetime.utcnow() - timedelta(days=7) self._log.info('First start: query archive start: %s', start_date) - query = self._get_archive_query(query_id, start=start_date) + + self._nbxmpp('MAM').make_query(own_jid, + queryid, + after=mam_id, + start=start_date, + callback=self._result_finished, + user_data={'queryid': queryid, + 'start': start_date, + 'groupchat': False}) if own_jid in self._catch_up_finished: self._catch_up_finished.remove(own_jid) - self._send_archive_query(query, query_id, start_date) def request_archive_on_muc_join(self, jid): archive = app.logger.get_archive_infos(jid) threshold = get_sync_threshold(jid, archive) self._log.info('Threshold for %s: %s', jid, threshold) - query_id = self._get_query_id(jid) + + mam_id = None start_date = None if archive is None or archive.last_mam_id is None: - # First Start, we dont request history - # Depending on what a MUC saves, there could be thousands - # of Messages even in just one day. + # First join start_date = datetime.utcnow() - timedelta(days=1) self._log.info('First join: query archive %s from: %s', jid, start_date) - query = self._get_archive_query( - query_id, jid=jid, start=start_date) elif threshold == SyncThreshold.NO_THRESHOLD: # Not our first join and no threshold set + + mam_id = archive.last_mam_id self._log.info('Request from archive: %s, after mam-id %s', jid, archive.last_mam_id) - query = self._get_archive_query( - query_id, jid=jid, after=archive.last_mam_id) else: # Not our first join, check how much time elapsed since our # last join and check against threshold last_timestamp = archive.last_muc_timestamp if last_timestamp is None: - self._log.info('No last muc timestamp found ( mam:1? )') + self._log.info('No last muc timestamp found') last_timestamp = 0 last = datetime.utcfromtimestamp(float(last_timestamp)) @@ -383,242 +335,138 @@ class MAM(BaseModule): self._log.info('Too much time elapsed since last join, ' 'request from: %s, threshold: %s', start_date, threshold) - query = self._get_archive_query( - query_id, jid=jid, start=start_date) + else: # Request from last mam-id + mam_id = archive.last_mam_id self._log.info('Request from archive %s after %s:', jid, archive.last_mam_id) - query = self._get_archive_query( - query_id, jid=jid, after=archive.last_mam_id) if jid in self._catch_up_finished: self._catch_up_finished.remove(jid) - self._send_archive_query(query, query_id, start_date, groupchat=True) - - def _send_archive_query(self, query, query_id, start_date=None, - groupchat=False): - self._con.connection.SendAndCallForResponse( - query, self._result_finished, {'query_id': query_id, - 'start_date': start_date, - 'groupchat': groupchat}) - - def _result_finished(self, _nbxmpp_client, stanza, query_id, - start_date, groupchat): - try: - fin, set_ = self._parse_iq(stanza) - except InvalidMamIQ: - return - jid = self._get_from_jid(stanza) + queryid = self._get_query_id(jid) + self._nbxmpp('MAM').make_query(jid, + queryid, + after=mam_id, + start=start_date, + callback=self._result_finished, + user_data={'queryid': queryid, + 'start': start_date, + 'groupchat': True}) + + def _result_finished(self, result, user_data): + queryid, start_date, groupchat = user_data.values() + self._remove_query_id(result.jid) + + if is_error_result(result): + if result.condition == 'item-not-found': + app.logger.reset_archive_infos(result.jid) + if groupchat: + self.request_archive_on_muc_join(result.jid) + else: + self.request_archive_on_signin() + return - last = set_.getTagData('last') - if last is None: - self._log.info('End of MAM query, no items retrieved') - self._catch_up_finished.append(jid) - self._mam_query_ids.pop(jid) + if result.rsm.last is None: + self._log.info('MAM catchup finished: %s', result.jid) + self._catch_up_finished.append(result.jid) return - complete = fin.getAttr('complete') - if complete != 'true': - app.logger.set_archive_infos(jid, last_mam_id=last) - self._mam_query_ids.pop(jid) - query_id = self._get_query_id(jid) - query = self._get_archive_query(query_id, jid=jid, after=last) - self._send_archive_query(query, query_id, groupchat=groupchat) + if not result.complete: + app.logger.set_archive_infos(result.jid, + last_mam_id=result.rsm.last) + queryid = self._get_query_id(result.jid) + + self._nbxmpp('MAM').make_query(result.jid, + queryid, + after=result.rsm.last, + callback=self._result_finished, + user_data={'queryid': queryid, + 'start': None, + 'groupchat': groupchat}) + else: - self._mam_query_ids.pop(jid) - app.logger.set_archive_infos( - jid, last_mam_id=last, last_muc_timestamp=time.time()) + app.logger.set_archive_infos(result.jid, + last_mam_id=result.rsm.last, + last_muc_timestamp=time.time()) + if start_date is not None and not groupchat: # Record the earliest timestamp we request from # the account archive. For the account archive we only # set start_date at the very first request. app.logger.set_archive_infos( - jid, oldest_mam_timestamp=start_date.timestamp()) + result.jid, + oldest_mam_timestamp=start_date.timestamp()) + + self._catch_up_finished.append(result.jid) + self._log.info('End of MAM query, last mam id: %s', + result.rsm.last) - self._catch_up_finished.append(jid) - self._log.info('End of MAM query, last mam id: %s', last) + def request_archive_interval(self, + start_date, + end_date, + after=None, + queryid=None): - def request_archive_interval(self, start_date, end_date, after=None, - query_id=None): - jid = self._con.get_own_jid().getStripped() if after is None: - self._log.info('Request intervall from %s to %s from %s', - start_date, end_date, jid) + self._log.info('Request interval from %s to %s', + start_date, end_date) else: - self._log.info('Query page after %s from %s', after, jid) - if query_id is None: - query_id = self._get_query_id(jid) - self._mam_query_ids[jid] = query_id - query = self._get_archive_query(query_id, start=start_date, - end=end_date, after=after, max_=30) - - self._con.connection.SendAndCallForResponse( - query, self._intervall_result, {'query_id': query_id, - 'start_date': start_date, - 'end_date': end_date}) - return query_id - - def _intervall_result(self, _nbxmpp_client, stanza, query_id, - start_date, end_date): - try: - fin, set_ = self._parse_iq(stanza) - except InvalidMamIQ: + self._log.info('Query page after %s', after) + + jid = self._con.get_own_jid().getBare() + if queryid is None: + queryid = self._get_query_id(jid) + self._mam_query_ids[jid] = queryid + + self._nbxmpp('MAM').make_query(jid, + queryid, + after=after, + start=start_date, + end=end_date, + callback=self._on_interval_result, + user_data={'queryid': queryid, + 'start_date': start_date, + 'end_date': end_date}) + return queryid + + def _on_interval_result(self, result, user_data): + queryid, start_date, end_date = user_data.values() + self._remove_query_id(result.jid) + + if is_error_result(result): return - jid = self._get_from_jid(stanza) - self._mam_query_ids.pop(jid) if start_date: timestamp = start_date.timestamp() else: timestamp = ArchiveState.ALL - last = set_.getTagData('last') - if last is None: - app.nec.push_incoming_event(ArchivingIntervalFinished( - None, query_id=query_id)) - app.logger.set_archive_infos( - jid, oldest_mam_timestamp=timestamp) + if result.rsm.last is None: + app.nec.push_incoming_event(NetworkEvent( + 'archiving-interval-finished', + account=self._account, + query_id=queryid)) + + app.logger.set_archive_infos(result.jid, + oldest_mam_timestamp=timestamp) self._log.info('End of MAM request, no items retrieved') return - complete = fin.getAttr('complete') - if complete != 'true': - self.request_archive_interval(start_date, end_date, last, query_id) + if not result.complete: + self.request_archive_interval(start_date, + end_date, + result.rsm.last, + queryid) else: self._log.info('Request finished') - app.logger.set_archive_infos( - jid, oldest_mam_timestamp=timestamp) - app.nec.push_incoming_event(ArchivingIntervalFinished( - None, query_id=query_id)) - - def _get_archive_query(self, query_id, jid=None, start=None, end=None, - with_=None, after=None, max_=70): - # Muc archive query? - disco_info = app.logger.get_last_disco_info(jid) - if disco_info is None: - # Query to our own archive - namespace = self.archiving_namespace - else: - namespace = disco_info.mam_namespace - - iq = nbxmpp.Iq('set', to=jid) - query = iq.addChild('query', namespace=namespace) - form = query.addChild(node=nbxmpp.DataForm(typ='submit')) - field = nbxmpp.DataField(typ='hidden', - name='FORM_TYPE', - value=namespace) - form.addChild(node=field) - if start: - field = nbxmpp.DataField( - typ='text-single', - name='start', - value=start.strftime('%Y-%m-%dT%H:%M:%SZ')) - form.addChild(node=field) - if end: - field = nbxmpp.DataField(typ='text-single', - name='end', - value=end.strftime('%Y-%m-%dT%H:%M:%SZ')) - form.addChild(node=field) - if with_: - field = nbxmpp.DataField(typ='jid-single', - name='with', - value=with_) - form.addChild(node=field) - - set_ = query.setTag('set', namespace=nbxmpp.NS_RSM) - set_.setTagData('max', max_) - if after: - set_.setTagData('after', after) - query.setAttr('queryid', query_id) - return iq - - def request_mam_preferences(self): - self._log.info('Request MAM preferences') - iq = nbxmpp.Iq('get', self.archiving_namespace) - iq.setQuery('prefs') - self._con.connection.SendAndCallForResponse( - iq, self._preferences_received) - - def _preferences_received(self, _nbxmpp_client, stanza): - if not nbxmpp.isResultNode(stanza): - self._log.info('Error: %s', stanza.getError()) - app.nec.push_incoming_event(MAMPreferenceError( - None, conn=self._con, error=stanza.getError())) - return - - self._log.info('Received MAM preferences') - prefs = stanza.getTag('prefs', namespace=self.archiving_namespace) - if prefs is None: - self._log.error('Malformed stanza (no prefs node): %s', stanza) - return - - rules = [] - default = prefs.getAttr('default') - for item in prefs.getTag('always').getTags('jid'): - rules.append((item.getData(), 'Always')) - - for item in prefs.getTag('never').getTags('jid'): - rules.append((item.getData(), 'Never')) - - app.nec.push_incoming_event(MAMPreferenceReceived( - None, conn=self._con, rules=rules, default=default)) - - def set_mam_preferences(self, rules, default): - iq = nbxmpp.Iq(typ='set') - prefs = iq.addChild(name='prefs', - namespace=self.archiving_namespace, - attrs={'default': default}) - always = prefs.addChild(name='always') - never = prefs.addChild(name='never') - for item in rules: - jid, archive = item - if archive: - always.addChild(name='jid').setData(jid) - else: - never.addChild(name='jid').setData(jid) - - self._con.connection.SendAndCallForResponse( - iq, self._preferences_saved) - - def _preferences_saved(self, _nbxmpp_client, stanza): - if not nbxmpp.isResultNode(stanza): - self._log.info('Error: %s', stanza.getError()) - app.nec.push_incoming_event(MAMPreferenceError( - None, conn=self._con, error=stanza.getError())) - else: - self._log.info('Preferences saved') - app.nec.push_incoming_event( - MAMPreferenceSaved(None, conn=self._con)) - - -class MAMPreferenceError(NetworkIncomingEvent): - name = 'mam-prefs-error' - - -class MAMPreferenceReceived(NetworkIncomingEvent): - name = 'mam-prefs-received' - - -class MAMPreferenceSaved(NetworkIncomingEvent): - name = 'mam-prefs-saved' - - -class ArchivingCountReceived(NetworkIncomingEvent): - name = 'archiving-count-received' - - -class ArchivingIntervalFinished(NetworkIncomingEvent): - name = 'archiving-interval-finished' - - -class ArchivingErrorReceived(NetworkIncomingEvent): - name = 'archiving-error-received' - - -class InvalidMamIQ(Exception): - pass + app.logger.set_archive_infos(result.jid, + oldest_mam_timestamp=timestamp) + app.nec.push_incoming_event(NetworkEvent( + 'archiving-interval-finished', + account=self._account, + query_id=queryid)) def get_instance(*args, **kwargs): ===================================== gajim/common/modules/message.py ===================================== @@ -266,15 +266,16 @@ class Message(BaseModule): if properties.type.is_groupchat: disco_info = app.logger.get_last_disco_info( properties.jid.getBare()) - namespace = disco_info.mam_namespace + + if disco_info.mam_namespace != nbxmpp.NS_MAM_2: + return None, None + archive = properties.jid else: - namespace = self._con.get_module('MAM').archiving_namespace - archive = self._con.get_own_jid() + if not self._con.get_module('MAM').available: + return None, None - if namespace != nbxmpp.NS_MAM_2: - # Only mam:2 ensures valid stanza-id - return None, None + archive = self._con.get_own_jid() if archive.bareMatch(properties.stanza_id.by): return properties.stanza_id.id, None ===================================== gajim/common/modules/muc.py ===================================== @@ -17,9 +17,6 @@ import time import logging -from datetime import datetime -from datetime import timedelta -from datetime import timezone import nbxmpp from nbxmpp.const import InviteType @@ -35,10 +32,8 @@ from gajim.common import helpers from gajim.common import ged from gajim.common.const import KindConstant from gajim.common.const import MUCJoinedState -from gajim.common.const import SyncThreshold from gajim.common.helpers import AdditionalDataDict from gajim.common.helpers import get_default_muc_config -from gajim.common.helpers import get_sync_threshold from gajim.common.helpers import to_user_string from gajim.common.helpers import event_filter from gajim.common import idle @@ -185,7 +180,7 @@ class MUC(BaseModule): status=self._con.status_message) muc_x = presence.setTag(nbxmpp.NS_MUC + ' x') - self._add_history_query(muc_x, str(muc_data.jid)) + muc_x.setTag('history', {'maxchars': '0'}) if muc_data.password is not None: muc_x.setTagData('password', muc_data.password) @@ -340,32 +335,6 @@ class MUC(BaseModule): show=self._con.status, status=self._con.status_message) - def _add_history_query(self, muc_x, room_jid): - disco_info = app.logger.get_last_disco_info(room_jid) - if disco_info.has_mam: - # The room is MAM capable dont get MUC History - muc_x.setTag('history', {'maxchars': '0'}) - else: - # Request MUC History (not MAM) - archive = app.logger.get_archive_infos(room_jid) - threshold = get_sync_threshold(room_jid, archive) - - since_epoch = 0 - if archive is not None and archive.last_muc_timestamp is not None: - since_epoch = float(archive.last_muc_timestamp) - - since_date = datetime.fromtimestamp(since_epoch, timezone.utc) - if threshold != SyncThreshold.NO_THRESHOLD: - now = datetime.now(timezone.utc) - threshold_date = now - timedelta(days=threshold) - since_date = max(threshold_date, since_date) - - date_string = since_date.strftime('%Y-%m-%dT%H:%M:%SZ') - muc_x.setTag('history', {'since': date_string}) - self._log.info('Request MUC history since: %s (%s)', - date_string, since_date.timestamp()) - self._log.info('Threshold for %s: %s', room_jid, threshold) - def _on_error_presence(self, _con, _stanza, properties): room_jid = properties.jid.getBare() muc_data = self._manager.get(room_jid) ===================================== gajim/gtk/groupchat_info.py ===================================== @@ -18,7 +18,6 @@ from gi.repository import Gdk from gi.repository import GLib from gi.repository import Gtk -from nbxmpp.protocol import NS_MAM_1 from nbxmpp.protocol import NS_MAM_2 from gajim.common import app @@ -206,8 +205,7 @@ class GroupChatInfoScrolled(Gtk.ScrolledWindow): grid.remove_row(row) features = list(features) - has_mam = NS_MAM_2 in features or NS_MAM_1 in features - if has_mam: + if NS_MAM_2 in features: features.append('mam') row = 10 ===================================== gajim/gtk/history_sync.py ===================================== @@ -19,6 +19,8 @@ from datetime import datetime, timedelta from gi.repository import Gtk from gi.repository import GLib +from nbxmpp.util import is_error_result + from gajim.common import app from gajim.common import ged from gajim.common.i18n import _ @@ -139,18 +141,25 @@ class HistorySyncAssistant(Gtk.Assistant, EventHelper): log.info('Start: %s', self.start) log.info('End: %s', self.end) - self.query_id = self.con.get_module('MAM').request_archive_count( - self.start, self.end) + jid = self.con.get_own_jid().getBare() - def _received_count(self, event): - if event.query_id != self.query_id: + self.con.get_module('MAM').make_query(jid, + start=self.start, + end=self.end, + max_=0, + callback=self._received_count) + + + def _received_count(self, result): + if is_error_result(result): return - if event.count is not None: - self.download_history.count = int(event.count) + if result.rsm.count is not None: + self.download_history.count = int(result.rsm.count) self.query_id = self.con.get_module('MAM').request_archive_interval( self.start, self.end) + @event_filter(['account']) def _received_finished(self, event): if event.query_id != self.query_id: return ===================================== gajim/gtk/mam_preferences.py ===================================== @@ -17,12 +17,14 @@ import logging from gi.repository import Gtk from gi.repository import Gdk +from nbxmpp.util import is_error_result + from gajim.common import app -from gajim.common import ged from gajim.common.i18n import _ from gajim.gtk.util import get_builder from gajim.gtk.util import EventHelper +from gajim.gtk.util import ensure_not_destroyed from gajim.gtk.dialogs import DialogButton from gajim.gtk.dialogs import NewConfirmationDialog from gajim.gtk.dialogs import InformationDialog @@ -43,6 +45,7 @@ class MamPreferences(Gtk.ApplicationWindow, EventHelper): self.account = account self._con = app.connections[account] + self._destroyed = False self._ui = get_builder('mam_preferences.ui') self.add(self._ui.get_object('mam_box')) @@ -50,33 +53,40 @@ class MamPreferences(Gtk.ApplicationWindow, EventHelper): self._spinner = Gtk.Spinner() self._ui.overlay.add_overlay(self._spinner) - self.register_events([ - ('mam-prefs-received', ged.GUI1, self._mam_prefs_received), - ('mam-prefs-saved', ged.GUI1, self._mam_prefs_saved), - ('mam-prefs-error', ged.GUI1, self._mam_prefs_error), - ]) - self._set_mam_box_state(False) + self.connect('destroy', self._on_destroy) self._ui.connect_signals(self) self.show_all() self._activate_spinner() - self._con.get_module('MAM').request_mam_preferences() + self._con.get_module('MAM').request_preferences( + callback=self._mam_prefs_received) - def _mam_prefs_received(self, obj): - if obj.conn.name != self.account: + def _on_destroy(self, *args): + self._destroyed = True + + @ensure_not_destroyed + def _mam_prefs_received(self, result): + if is_error_result(result): + self._on_error(result.get_text()) return + self._disable_spinner() self._set_mam_box_state(True) - self._ui.default_combo.set_active_id(obj.default) + self._ui.default_combo.set_active_id(result.default) self._ui.preferences_store.clear() - for item in obj.rules: - self._ui.preferences_store.append(item) + for jid in result.always: + self._ui.preferences_store.append((str(jid), 'Always')) - def _mam_prefs_saved(self, obj): - if obj.conn.name != self.account: + for jid in result.never: + self._ui.preferences_store.append((str(jid), 'Never')) + + @ensure_not_destroyed + def _mam_prefs_saved(self, result): + if is_error_result(result): + self._on_error(result.get_text()) return self._disable_spinner() @@ -91,18 +101,11 @@ class MamPreferences(Gtk.ApplicationWindow, EventHelper): [DialogButton.make('OK', callback=_on_ok)]).show() - def _mam_prefs_error(self, obj=None): - if obj and obj.conn.name != self.account: - return - + def _on_error(self, error): self._disable_spinner() - if not obj: - msg = _('No response from the Server') - else: - msg = _('Error received: {}').format(obj.error_msg) - - InformationDialog(_('Archiving Preferences Error'), msg) + InformationDialog(_('Archiving Preferences Error'), + _('Error received: {}').format(error)) self._set_mam_box_state(True) @@ -130,11 +133,17 @@ class MamPreferences(Gtk.ApplicationWindow, EventHelper): def _on_save(self, _button): self._activate_spinner() self._set_mam_box_state(False) - items = [] + always = [] + never = [] default = self._ui.default_combo.get_active_id() for item in self._ui.preferences_store: - items.append((item[0].lower(), item[1])) - self._con.get_module('MAM').set_mam_preferences(items, default) + jid, type_ = item + if type_ == 'Always': + always.append(jid) + else: + never.append(jid) + self._con.get_module('MAM').set_preferences( + default, always, never, callback=self._mam_prefs_saved) def _activate_spinner(self): self._spinner.show() ===================================== gajim/gtk/server_info.py ===================================== @@ -288,8 +288,7 @@ class ServerInfo(Gtk.ApplicationWindow, EventHelper): con.get_module('Carbons').supported, nbxmpp.NS_CARBONS), Feature('XEP-0313: Message Archive Management', - con.get_module('MAM').available, - con.get_module('MAM').archiving_namespace), + con.get_module('MAM').available), Feature('XEP-0363: HTTP File Upload', con.get_module('HTTPUpload').available, http_upload_info), View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/df2f93c08603a48079d87bbd12aa51e… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/df2f93c08603a48079d87bbd12aa51e… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/python-nbxmpp][master] 3 commits: MAM: Make queryid argument optional
by Philipp Hörist 28 Mar '20

28 Mar '20

Philipp Hörist pushed to branch master at gajim / python-nbxmpp Commits: 038bb408 by lovetox at 2020-03-28T18:06:51+01:00 MAM: Make queryid argument optional - - - - - 5e6bb0f9 by lovetox at 2020-03-28T18:06:51+01:00 MAM: Parse complete attribute correctly - - - - - c6b3a7a5 by lovetox at 2020-03-28T18:13:01+01:00 TCP: Add comment - - - - - 2 changed files: - nbxmpp/modules/mam.py - nbxmpp/tcp.py Changes: ===================================== nbxmpp/modules/mam.py ===================================== @@ -44,7 +44,7 @@ class MAM(BaseModule): @call_on_response('_query_result') def make_query(self, jid, - queryid, + queryid=None, start=None, end=None, with_=None, @@ -52,7 +52,8 @@ class MAM(BaseModule): max_=70): iq = Iq(typ='set', to=jid, queryNS=NS_MAM_2) - iq.getQuery().setAttr('queryid', queryid) + if queryid is not None: + iq.getQuery().setAttr('queryid', queryid) payload = [ self._make_query_form(start, end, with_), @@ -117,7 +118,7 @@ class MAM(BaseModule): 'stanza-malformed', 'rsm set missing') - complete = bool(fin.getAttr('complete')) + complete = fin.getAttr('complete') == 'true' return MAMQueryData(jid=jid, complete=complete, ===================================== nbxmpp/tcp.py ===================================== @@ -241,6 +241,10 @@ class TCPConnection(Connection): except Exception: self._log.exception('Error while executing data-received:') + # Call next async read only after the received data is processed + # otherwise this can lead to problems if we call + # start_tls_negotiation() while we have a pending read which is + # the case for START TLS because its triggered by <proceed> self._read_async() def _write_stanzas(self): View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/compare/78da85211708d6c1c87e7d2… -- View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/compare/78da85211708d6c1c87e7d2… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/python-nbxmpp][master] Revert "TCP: Initiate new read before data-received signal"
by Philipp Hörist 28 Mar '20

28 Mar '20

Philipp Hörist pushed to branch master at gajim / python-nbxmpp Commits: 78da8521 by Philipp Hörist at 2020-03-28T17:30:13+01:00 Revert "TCP: Initiate new read before data-received signal" This reverts commit 80ec5753de06bc8e92dd49b2aec4f8b13ec8401d - - - - - 1 changed file: - nbxmpp/tcp.py Changes: ===================================== nbxmpp/tcp.py ===================================== @@ -236,13 +236,13 @@ class TCPConnection(Connection): self._log_stanza(data, received=True) - self._read_async() - try: self.notify('data-received', data) except Exception: self._log.exception('Error while executing data-received:') + self._read_async() + def _write_stanzas(self): self._write_stanza_buffer = self._write_queue self._write_queue = deque([]) View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/78da85211708d6c1c87e7d23… -- View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/78da85211708d6c1c87e7d23… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/python-nbxmpp][master] RSM: Parse correct node
by Philipp Hörist 28 Mar '20

28 Mar '20

Philipp Hörist pushed to branch master at gajim / python-nbxmpp Commits: 087a2798 by lovetox at 2020-03-28T08:50:53+01:00 RSM: Parse correct node - - - - - 1 changed file: - nbxmpp/modules/rsm.py Changes: ===================================== nbxmpp/modules/rsm.py ===================================== @@ -21,8 +21,8 @@ from nbxmpp.structs import RSMData def parse_rsm(stanza): - set_ = stanza.getTag('set', namespace=NS_RSM) - if set_ is None: + stanza = stanza.getTag('set', namespace=NS_RSM) + if stanza is None: return None after = stanza.getTagData('after') or None View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/087a2798bb13d1840972184b… -- View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/087a2798bb13d1840972184b… You're receiving this email because of your account on dev.gajim.org.

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits March 2020