Commits

commits@gajim.org

17632 discussions

[Git][gajim/gajim][master] cq: Typecheck more modules
by Philipp Hörist (＠lovetox) 13 Dec '22

13 Dec '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: fc4a56e2 by Philipp Hörist at 2022-12-13T22:38:08+01:00 cq: Typecheck more modules - - - - - 3 changed files: - gajim/gtk/groupchat_manage.py - gajim/gtk/profile.py - pyproject.toml Changes: ===================================== gajim/gtk/groupchat_manage.py ===================================== @@ -236,7 +236,7 @@ def _on_avatar_update_clicked(self, _button: Gtk.Button) -> None: return vcard = VCard() - vcard.set_avatar(data, 'image/png') + vcard.set_avatar(data, 'image/png') # pyright: ignore self._client.get_module('VCardTemp').set_vcard( vcard, ===================================== gajim/gtk/profile.py ===================================== @@ -237,7 +237,7 @@ def _on_cancel_clicked(self, _button: Gtk.Button) -> None: self._ui.nickname_entry.set_sensitive(False) self._ui.avatar_image.set_from_surface(self._current_avatar) self._ui.nickname_entry.set_text(app.nicks[self.account]) - self._vcard_grid.set_vcard(self._current_vcard.copy()) + self._vcard_grid.set_vcard(self._current_vcard.copy()) # pyright: ignore # noqa self._new_avatar = False def _on_save_clicked(self, _button: Gtk.Button) -> None: @@ -256,7 +256,7 @@ def _on_save_clicked(self, _button: Gtk.Button) -> None: self._vcard_grid.sort() vcard = self._vcard_grid.get_vcard() - self._current_vcard = vcard.copy() + self._current_vcard = vcard.copy() # pyright: ignore client = app.get_client(self.account) client.get_module('VCard4').set_vcard( @@ -355,7 +355,8 @@ def _on_update_avatar(self, _button: Gtk.Button) -> None: return self._new_avatar = Avatar() - self._new_avatar.add_image_source(data, 'image/png', height, width) + self._new_avatar.add_image_source(data, 'image/png', height, width) # pyright: ignore # noqa + self._new_avatar = False scale = self.get_scale_factor() surface = app.app.avatar_storage.surface_from_filename( ===================================== pyproject.toml ===================================== @@ -106,6 +106,7 @@ include = [ "gajim/gtk/groupchat_invitation.py", "gajim/gtk/groupchat_inviter.py", "gajim/gtk/groupchat_join.py", + "gajim/gtk/groupchat_manage.py", "gajim/gtk/groupchat_nick.py", "gajim/gtk/groupchat_nick_completion.py", "gajim/gtk/groupchat_outcasts.py", @@ -133,6 +134,7 @@ include = [ "gajim/gtk/preview_audio.py", "gajim/gtk/preview_audio_analyzer.py", "gajim/gtk/preview_audio_visualizer.py", + "gajim/gtk/profile.py", "gajim/gtk/proxies.py", "gajim/gtk/remove_account.py", "gajim/gtk/resource_selector.py", View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/fc4a56e2c1929866eb618ed5ba34b989… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/fc4a56e2c1929866eb618ed5ba34b989… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] refactor: Import MenuList type hints
by Philipp Hörist (＠lovetox) 13 Dec '22

13 Dec '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: 75104e75 by Philipp Hörist at 2022-12-13T20:47:11+01:00 refactor: Import MenuList type hints - - - - - 1 changed file: - gajim/gtk/menus.py Changes: ===================================== gajim/gtk/menus.py ===================================== @@ -20,7 +20,6 @@ from typing import Callable from typing import cast from typing import Optional -from typing import Union from datetime import datetime import textwrap @@ -46,7 +45,6 @@ from gajim.common.const import XmppUriQuery from gajim.common.preview import Preview from gajim.common.structs import URI -from gajim.common.structs import VariantMixin from gajim.common.text_helpers import escape_iri_path_segment from gajim.common.modules.contacts import GroupchatContact from gajim.common.modules.contacts import can_add_to_roster @@ -57,10 +55,9 @@ from gajim.gui.structs import RemoveHistoryActionParams from gajim.gui.structs import RetractMessageParam from gajim.gui.util import GajimMenu +from gajim.gui.util import MenuItemListT -MenuValueT = Union[None, str, GLib.Variant, VariantMixin] -MenuItemListT = list[tuple[str, str, MenuValueT]] UriMenuItemsT = list[tuple[str, list[str], str]] UriMenuBuilderT = Callable[[URI, str], UriMenuItemsT] View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/75104e75c3ad82b01feff4e64d8d54f6… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/75104e75c3ad82b01feff4e64d8d54f6… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] refactor: Menus: Port component search menu to GajimMenu
by Philipp Hörist (＠lovetox) 13 Dec '22

13 Dec '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: d1f57886 by Philipp Hörist at 2022-12-13T20:29:56+01:00 refactor: Menus: Port component search menu to GajimMenu - - - - - 1 changed file: - gajim/gtk/menus.py Changes: ===================================== gajim/gtk/menus.py ===================================== @@ -636,26 +636,17 @@ def get_groupchat_participant_menu(account: str, return menu -def get_component_search_menu(jid: Optional[str], copy_text: str) -> Gio.Menu: - menu_items: list[tuple[str, str]] = [ - ('app.copy-text', _('Copy')), +def get_component_search_menu(jid: Optional[str], copy_text: str) -> GajimMenu: + menuitems: MenuItemListT = [ + (_('Copy'), 'app.copy-text', copy_text), ] + if jid is not None: - menu_items.append( - ('app.start-chat', _('Start Chat…'))) - - menu = Gio.Menu() - for item in menu_items: - action, label = item - menuitem = Gio.MenuItem.new(label, action) - if action == 'app.copy-text': - data = copy_text - else: - data = jid - variant = GLib.Variant('s', data) - menuitem.set_action_and_target_value(action, variant) - menu.append_item(menuitem) - return menu + menuitems.append( + (_('Start Chat…'), 'app.start-chat', jid) + ) + + return GajimMenu.from_list(menuitems) def get_chat_row_menu(contact: types.ChatContactT, View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/d1f57886eedd4b9c787183a17294d549… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/d1f57886eedd4b9c787183a17294d549… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] refactor: Menus: Don’t pass action with Gio.MenuItem.new()
by Philipp Hörist (＠lovetox) 13 Dec '22

13 Dec '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: 53bf4e2f by Philipp Hörist at 2022-12-13T20:17:29+01:00 refactor: Menus: Don’t pass action with Gio.MenuItem.new() The action gets feeded to parse_detail_name() which breaks when the action name has "(" in it. - - - - - 1 changed file: - gajim/gtk/util.py Changes: ===================================== gajim/gtk/util.py ===================================== @@ -893,8 +893,11 @@ def make_menu_item(label: str, action: Optional[str] = None, value: MenuValueT = None) -> Gio.MenuItem: + item = Gio.MenuItem.new(label) + if value is None: - return Gio.MenuItem.new(label, action) + item.set_action_and_target_value(action, None) + return item item = Gio.MenuItem.new(label) if isinstance(value, str): View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/53bf4e2fa6ee915bb442831f32d1b529… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/53bf4e2fa6ee915bb442831f32d1b529… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] refactor: Menus: Don’t pass params with action name
by Philipp Hörist (＠lovetox) 13 Dec '22

13 Dec '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: dab9bf29 by Philipp Hörist at 2022-12-13T20:00:57+01:00 refactor: Menus: Don’t pass params with action name For consistency sake - - - - - 1 changed file: - gajim/gtk/menus.py Changes: ===================================== gajim/gtk/menus.py ===================================== @@ -107,8 +107,11 @@ def get_singlechat_menu(contact: types.BareContact) -> GajimMenu: def get_private_chat_menu(contact: types.GroupchatParticipant) -> GajimMenu: menu = GajimMenu() + + value = GLib.Variant('as', ['']) + menu.add_item(_('Details'), 'win.show-contact-info') - menu.add_item(_('Upload File…'), 'win.send-file-httpupload([""])') + menu.add_item(_('Upload File…'), 'win.send-file-httpupload', value) menu.add_item(_('Search…'), 'win.search-history') if can_add_to_roster(contact): @@ -121,8 +124,10 @@ def get_private_chat_menu(contact: types.GroupchatParticipant) -> GajimMenu: def get_send_file_submenu() -> GajimMenu: menu = GajimMenu() - menu.add_item(_('Upload File…'), 'win.send-file-httpupload([""])') - menu.add_item(_('Send File Directly…'), 'win.send-file-jingle([""])') + value = GLib.Variant('as', ['']) + + menu.add_item(_('Upload File…'), 'win.send-file-httpupload', value) + menu.add_item(_('Send File Directly…'), 'win.send-file-jingle', value) return menu @@ -456,10 +461,13 @@ def get_subscription_menu(account: str, jid: JID) -> GajimMenu: def get_start_chat_button_menu() -> GajimMenu: + + value = GLib.Variant('as', ['', '']) + menuitems: MenuItemListT = [ - (_('Start Chat…'), 'app.start-chat(["", ""])', None), - (_('Create Group Chat…'), 'app.create-groupchat::', None), - (_('Add Contact…'), 'app.add-contact::', None), + (_('Start Chat…'), 'app.start-chat', value), + (_('Create Group Chat…'), 'app.create-groupchat', ''), + (_('Add Contact…'), 'app.add-contact', ''), ] return GajimMenu.from_list(menuitems) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/dab9bf290c83e02ced74d118632f0e5b… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/dab9bf290c83e02ced74d118632f0e5b… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] cfix: Menus: Don’t quote string value
by Philipp Hörist (＠lovetox) 13 Dec '22

13 Dec '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: 0f3204b4 by Philipp Hörist at 2022-12-13T19:46:56+01:00 cfix: Menus: Don’t quote string value - - - - - 1 changed file: - gajim/gtk/menus.py Changes: ===================================== gajim/gtk/menus.py ===================================== @@ -71,7 +71,7 @@ def get_self_contact_menu(contact: types.BareContact) -> GajimMenu: menu = GajimMenu() - menu.add_item(_('Profile'), f'app.{account}-profile', f'"{account}"') + menu.add_item(_('Profile'), f'app.{account}-profile', account) submenu = get_send_file_submenu() menu.append_submenu(_('Send File'), submenu) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/0f3204b4dcb73207fe8a54284465685f… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/0f3204b4dcb73207fe8a54284465685f… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] cfix: Menus: Remove obsolete string escaping
by Philipp Hörist (＠lovetox) 13 Dec '22

13 Dec '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: e070a951 by Philipp Hörist at 2022-12-13T19:43:42+01:00 cfix: Menus: Remove obsolete string escaping - - - - - 1 changed file: - gajim/gtk/menus.py Changes: ===================================== gajim/gtk/menus.py ===================================== @@ -661,8 +661,6 @@ def get_chat_row_menu(contact: types.ChatContactT, menu_items: MenuItemListT = [] - text = text.replace('"', '\\"') - format_string = app.settings.get('date_time_format') timestamp_formatted = timestamp.strftime(format_string) copy_text = f'{timestamp_formatted} - {name}: {text}' View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/e070a95190ac941a4cb8a8e0ef9a99fe… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/e070a95190ac941a4cb8a8e0ef9a99fe… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] other: Scripts: Execute pyright last in pre-push-tests
by Philipp Hörist (＠lovetox) 13 Dec '22

13 Dec '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: 0bdce8ac by Philipp Hörist at 2022-12-13T19:40:15+01:00 other: Scripts: Execute pyright last in pre-push-tests It takes the most time, so execute it last - - - - - 1 changed file: - scripts/pre-push-tests.sh Changes: ===================================== scripts/pre-push-tests.sh ===================================== @@ -6,10 +6,13 @@ set -e GREEN='\033[0;32m' -pyright -echo "${GREEN}pyright: \t OK" ruff . echo "${GREEN}ruff: \t\t OK" + codespell gajim echo "${GREEN}codespell: \t OK" + +pyright +echo "${GREEN}pyright: \t OK" + echo "${GREEN}ready to push" View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/0bdce8acbd60c56b358328f68a45f3a2… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/0bdce8acbd60c56b358328f68a45f3a2… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix: Menus: Don’t use GLib variant text format parsing
by Philipp Hörist (＠lovetox) 13 Dec '22

13 Dec '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: 221097db by Philipp Hörist at 2022-12-13T19:38:09+01:00 fix: Menus: Don’t use GLib variant text format parsing All strings would need to be escaped, not using the text format is less error prone. Fixes #11331 - - - - - 2 changed files: - gajim/gtk/menus.py - gajim/gtk/util.py Changes: ===================================== gajim/gtk/menus.py ===================================== @@ -84,11 +84,11 @@ def get_self_contact_menu(contact: types.BareContact) -> GajimMenu: def get_singlechat_menu(contact: types.BareContact) -> GajimMenu: account = contact.account - value = f'"{contact.jid}"' - menu = GajimMenu() menu.add_item(_('Details'), 'win.show-contact-info') - menu.add_item(_('Block Contact…'), f'app.{account}-block-contact', value) + menu.add_item(_('Block Contact…'), + f'app.{account}-block-contact', + str(contact.jid)) submenu = get_send_file_submenu() menu.append_submenu(_('Send File'), submenu) @@ -131,7 +131,7 @@ def get_groupchat_menu(contact: GroupchatContact) -> GajimMenu: (_('Details'), 'win.show-contact-info', None), (_('Change Nickname…'), 'win.muc-change-nickname', None), (_('Request Voice'), 'win.muc-request-voice', None), - (_('Execute Command…'), 'win.muc-execute-command', '""'), + (_('Execute Command…'), 'win.muc-execute-command', ''), (_('Search…'), 'win.search-history', None) ] @@ -140,26 +140,24 @@ def get_groupchat_menu(contact: GroupchatContact) -> GajimMenu: def get_account_menu(account: str) -> GajimMenu: - val = f'"{account}"' - menuitems: MenuItemListT = [ - (_('Profile'), f'app.{account}-profile', val), - (_('Discover Services…'), f'app.{account}-services', val), - (_('Server Info'), f'app.{account}-server-info', val), + (_('Profile'), f'app.{account}-profile', account), + (_('Discover Services…'), f'app.{account}-services', account), + (_('Server Info'), f'app.{account}-server-info', account), ] menu = GajimMenu.from_list(menuitems) advanced_menuitems: MenuItemListT = [ - (_('Archiving Preferences'), f'app.{account}-archive', val), - (_('Blocking List'), f'app.{account}-blocking', val), - (_('PEP Configuration'), f'app.{account}-pep-config', val), - (_('Synchronise History…'), f'app.{account}-sync-history', val), + (_('Archiving Preferences'), f'app.{account}-archive', account), + (_('Blocking List'), f'app.{account}-blocking', account), + (_('PEP Configuration'), f'app.{account}-pep-config', account), + (_('Synchronise History…'), f'app.{account}-sync-history', account), ] if app.settings.get('developer_modus'): advanced_menuitems.append( - (_('Bookmarks'), f'app.{account}-bookmarks', val)) + (_('Bookmarks'), f'app.{account}-bookmarks', account)) menu.append_submenu(_('Advanced'), GajimMenu.from_list(advanced_menuitems)) @@ -208,10 +206,10 @@ def build_accounts_menu() -> None: def get_encryption_menu() -> GajimMenu: menuitems: MenuItemListT = [ - (_('Disabled'), 'win.set-encryption', '""'), - ('OMEMO', 'win.set-encryption', '"OMEMO"'), - ('OpenPGP', 'win.set-encryption', '"OpenPGP"'), - ('PGP', 'win.set-encryption', '"PGP"'), + (_('Disabled'), 'win.set-encryption', ''), + ('OMEMO', 'win.set-encryption', 'OMEMO'), + ('OpenPGP', 'win.set-encryption', 'OpenPGP'), + ('PGP', 'win.set-encryption', 'PGP'), ] return GajimMenu.from_list(menuitems) @@ -415,7 +413,7 @@ def get_roster_menu(account: str, jid: str, gateway: bool = False) -> GajimMenu: if jid_is_blocked(account, jid): block_label = _('Unblock') - value = f'"{jid}"' + value = str(jid) menuitems: MenuItemListT = [ (_('Details'), f'app.{account}-contact-info', value), @@ -445,7 +443,7 @@ def get_subscription_menu(account: str, jid: JID) -> GajimMenu: jid=jid, type='contact', select=True) - value = f'"{jid}"' + value = str(jid) menuitems: MenuItemListT = [ (_('Start Chat'), 'win.add-chat', params), (_('Details'), f'win.contact-info-{account}', value), @@ -545,26 +543,26 @@ def get_groupchat_admin_menu(self_contact: types.GroupchatParticipant, return menu action = 'win.muc-change-affiliation' + real_jid = str(contact.real_jid) if is_affiliation_change_allowed(self_contact, contact, 'owner'): - value = f'["{contact.real_jid}", "owner"]' + value = GLib.Variant('as', [real_jid, 'owner']) menu.add_item(_('Make Owner'), action, value) if is_affiliation_change_allowed(self_contact, contact, 'admin'): - value = f'["{contact.real_jid}", "admin"]' + value = GLib.Variant('as', [real_jid, 'admin']) menu.add_item(_('Make Admin'), action, value) if is_affiliation_change_allowed(self_contact, contact, 'member'): - value = f'["{contact.real_jid}", "member"]' + value = GLib.Variant('as', [real_jid, 'member']) menu.add_item(_('Make Member'), action, value) if is_affiliation_change_allowed(self_contact, contact, 'none'): - value = f'["{contact.real_jid}", "none"]' + value = GLib.Variant('as', [real_jid, 'none']) menu.add_item(_('Revoke Member'), action, value) if is_affiliation_change_allowed(self_contact, contact, 'outcast'): - value = f'"{contact.real_jid}"' - menu.add_item(_('Ban…'), 'win.muc-ban', value) + menu.add_item(_('Ban…'), 'win.muc-ban', real_jid) if not menu.get_n_items(): menu.add_item(_('Not Available'), 'dummy', None) @@ -582,18 +580,19 @@ def get_groupchat_mod_menu(self_contact: types.GroupchatParticipant, menu.add_item(_('Not Available'), 'dummy', None) return menu + contact_name = str(contact.name) + if is_role_change_allowed(self_contact, contact): - value = f'"{contact.name}"' - menu.add_item(_('Kick…'), 'win.muc-kick', value) + menu.add_item(_('Kick…'), 'win.muc-kick', contact_name) action = 'win.muc-change-role' if is_role_change_allowed(self_contact, contact): if contact.role.is_visitor: - value = f'["{contact.name}", "participant"]' + value = GLib.Variant('as', [contact_name, 'participant']) menu.add_item(_('Grant Voice'), action, value) else: - value = f'["{contact.name}", "visitor"]' + value = value = GLib.Variant('as', [contact_name, 'visitor']) menu.add_item(_('Revoke Voice'), action, value) if not menu.get_n_items(): @@ -607,7 +606,7 @@ def get_groupchat_participant_menu(account: str, contact: types.GroupchatParticipant ) -> GajimMenu: - value = f'"{contact.name}"' + value = str(contact.name) general_items: MenuItemListT = [ (_('Details'), 'win.muc-contact-info', value), @@ -616,7 +615,7 @@ def get_groupchat_participant_menu(account: str, real_contact = contact.get_real_contact() if real_contact is not None and can_add_to_roster(real_contact): - value = f'["{account}", "{real_contact.jid}"]' + value = GLib.Variant('as', [account, str(real_contact.jid)]) action = f'app.{account}-add-contact' general_items.insert(1, (_('Add to Contact List…'), action, value)) @@ -670,7 +669,7 @@ def get_chat_row_menu(contact: types.ChatContactT, menu_items.append( (p_('Message row action', 'Copy'), 'win.copy-message', - f'"{copy_text}"')) + copy_text)) menu_items.append( (p_('Message row action', 'Select Messages…'), @@ -687,9 +686,7 @@ def get_chat_row_menu(contact: types.ChatContactT, show_quote = False if show_quote: menu_items.append(( - p_('Message row action', 'Quote…'), - 'win.quote', - f'"{text}"')) + p_('Message row action', 'Quote…'), 'win.quote', text)) show_correction = False if message_id is not None: @@ -728,14 +725,13 @@ def get_chat_row_menu(contact: types.ChatContactT, def get_preview_menu(preview: Preview) -> GajimMenu: menu_items: MenuItemListT = [] - variant = GLib.Variant('s', preview.id) - - download = (_('_Download'), 'win.preview-download', variant) - open_file = (_('_Open'), 'win.preview-open', variant) - save_as = (_('_Save as…'), 'win.preview-save-as', variant) - open_folder = (_('Open _Folder'), 'win.preview-open-folder', variant) - copy_link = (_('_Copy Link'), 'win.preview-copy-link', variant) - open_link = (_('Open Link in _Browser'), 'win.preview-open-link', variant) + download = (_('_Download'), 'win.preview-download', preview.id) + open_file = (_('_Open'), 'win.preview-open', preview.id) + save_as = (_('_Save as…'), 'win.preview-save-as', preview.id) + open_folder = (_('Open _Folder'), 'win.preview-open-folder', preview.id) + copy_link = (_('_Copy Link'), 'win.preview-copy-link', preview.id) + open_link = (_('Open Link in _Browser'), 'win.preview-open-link', + preview.id) if preview.is_geo_uri: menu_items.append(open_file) @@ -775,8 +771,8 @@ def get_workspace_menu(workspace_id: str, has_unread: bool) -> GajimMenu: remove_action = 'win.remove-workspace' menuitems: MenuItemListT = [ - (_('Edit…'), 'win.edit-workspace', f'"{workspace_id}"'), - (_('Remove'), remove_action, f'"{workspace_id}"'), + (_('Edit…'), 'win.edit-workspace', workspace_id), + (_('Remove'), remove_action, workspace_id), ] if has_unread: @@ -784,7 +780,7 @@ def get_workspace_menu(workspace_id: str, has_unread: bool) -> GajimMenu: 0, (_('Mark as read'), 'win.mark-workspace-as-read', - f'"{workspace_id}"')) + workspace_id)) return GajimMenu.from_list(menuitems) ===================================== gajim/gtk/util.py ===================================== @@ -898,7 +898,7 @@ def make_menu_item(label: str, item = Gio.MenuItem.new(label) if isinstance(value, str): - item.set_detailed_action(f'{action}({value})') + item.set_action_and_target_value(action, GLib.Variant('s', value)) elif isinstance(value, VariantMixin): item.set_action_and_target_value(action, value.to_variant()) else: View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/221097dbf51c062a50611045fb42bbb6… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/221097dbf51c062a50611045fb42bbb6… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/python-nbxmpp][soup3] fix: Create Temp File
by Philipp Hörist (＠lovetox) 12 Dec '22

12 Dec '22

Philipp Hörist pushed to branch soup3 at gajim / python-nbxmpp Commits: 5399e2ca by Philipp Hörist at 2022-12-12T22:11:58+01:00 fix: Create Temp File - - - - - 2 changed files: - nbxmpp/http.py - test/unit/test_http.py Changes: ===================================== nbxmpp/http.py ===================================== @@ -189,7 +189,7 @@ class HTTPRequest(GObject.GObject): self._request_content_type = content_type self._request_content_length = len(data) - def set_response_body_path(self, path: Path) -> None: + def set_response_body_from_path(self, path: Path) -> None: self._response_body_file = Gio.File.new_for_path(str(path)) def connect(self, ===================================== test/unit/test_http.py ===================================== @@ -1,4 +1,5 @@ from time import time +import tempfile import unittest from unittest.mock import call from unittest.mock import Mock @@ -37,7 +38,7 @@ class HTTP(unittest.TestCase): def tearDownClass(cls): pass - def test_in_memory_download_to_file(self): + def test_download_to_file(self): mainloop = GLib.MainLoop() @@ -46,8 +47,8 @@ class HTTP(unittest.TestCase): callback_mock = Mock() - request.set_response_body_path( - Path('/home/lovetox/Downloads/test123')) + temp_dir = tempfile.gettempdir() + request.set_response_body_from_path(Path(temp_dir) / 'file') request.connect('response-progress', callback_mock.progress) request.connect('starting-response-body', callback_mock.starting) request.connect('finished', callback_mock.finished) View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/5399e2cae39586f380d83286… -- View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/5399e2cae39586f380d83286… You're receiving this email because of your account on dev.gajim.org.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits