Philipp Hörist pushed to branch master at gajim / gajim

Commits: 53bf4e2f by Philipp Hörist at 2022-12-13T20:17:29+01:00 refactor: Menus: Don’t pass action with Gio.MenuItem.new()

The action gets feeded to parse_detail_name() which breaks when the action name has "(" in it.

- - - - -

1 changed file:

- gajim/gtk/util.py

Changes:

===================================== gajim/gtk/util.py ===================================== @@ -893,8 +893,11 @@ def make_menu_item(label: str, action: Optional[str] = None, value: MenuValueT = None) -> Gio.MenuItem:

+ item = Gio.MenuItem.new(label) + if value is None: - return Gio.MenuItem.new(label, action) + item.set_action_and_target_value(action, None) + return item

item = Gio.MenuItem.new(label) if isinstance(value, str):

View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/53bf4e2fa6ee915bb442831f32d1b5295...