Commits

commits@gajim.org

17632 discussions

[Git][gajim/gajim][master] 2 commits: cq: Scripts: cast filename to string
by Philipp Hörist (＠lovetox) 23 Dec '22

23 Dec '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: 218ea886 by Philipp Hörist at 2022-12-23T00:48:00+01:00 cq: Scripts: cast filename to string - - - - - 0ff8fb9a by Philipp Hörist at 2022-12-23T00:49:45+01:00 refactor: Plugins: Move PluginManifest into own module This fixes import cycles - - - - - 11 changed files: - .ci/deploy.py - gajim/common/application.py - gajim/common/events.py - gajim/gtk/app_page.py - gajim/gtk/plugins.py - gajim/plugins/__init__.py - gajim/plugins/gajimplugin.py - + gajim/plugins/manifest.py - gajim/plugins/pluginmanager.py - gajim/plugins/repository.py - pyproject.toml Changes: ===================================== .ci/deploy.py ===================================== @@ -1,6 +1,7 @@ #!/usr/bin/env python3 from typing import Any +from typing import cast from typing import Optional import functools @@ -102,7 +103,7 @@ def download_artifacts(path: Path) -> None: for response in responses: for artifact in response: - filename = artifact['fileName'] + filename = cast(str, artifact['fileName']) file_url = artifact['fileUrl'] log.info('Download %s', filename) ===================================== gajim/common/application.py ===================================== @@ -61,7 +61,7 @@ from gajim.common.storage.draft import DraftStorage from gajim.common.storage.archive import MessageArchiveStorage -from gajim.plugins import PluginManager +from gajim.plugins.pluginmanager import PluginManager from gajim.plugins.repository import PluginRepository ===================================== gajim/common/events.py ===================================== @@ -45,7 +45,7 @@ if typing.TYPE_CHECKING: from gajim.common.client import Client from gajim.common.modules.httpupload import HTTPFileTransfer - from gajim.plugins.pluginmanager import PluginManifest + from gajim.plugins.manifest import PluginManifest ChatListEventT = Union[ 'MessageReceived', ===================================== gajim/gtk/app_page.py ===================================== @@ -26,7 +26,7 @@ from gajim.common import app from gajim.common.helpers import open_uri from gajim.common.i18n import _ -from gajim.plugins.pluginmanager import PluginManifest +from gajim.plugins.manifest import PluginManifest from .builder import get_builder from .status_message_selector import StatusMessageSelector ===================================== gajim/gtk/plugins.py ===================================== @@ -38,7 +38,7 @@ from gajim.common.types import PluginRepositoryT from gajim.plugins.helpers import GajimPluginActivateException -from gajim.plugins.pluginmanager import PluginManifest +from gajim.plugins.manifest import PluginManifest from gajim.gui.dialogs import WarningDialog from gajim.gui.dialogs import DialogButton ===================================== gajim/plugins/__init__.py ===================================== @@ -1,18 +0,0 @@ -# This file is part of Gajim. -# -# Gajim is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published -# by the Free Software Foundation; version 3 only. -# -# Gajim is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with Gajim. If not, see <http://www.gnu.org/licenses/>. - -from gajim.plugins.pluginmanager import PluginManager -from gajim.plugins.gajimplugin import GajimPlugin - -__all__ = ['PluginManager', 'GajimPlugin'] ===================================== gajim/plugins/gajimplugin.py ===================================== @@ -26,6 +26,8 @@ from gajim.common.modules.base import BaseModule from gajim.common.types import PluginExtensionPoints +from gajim.plugins.manifest import PluginManifest + log = logging.getLogger('gajim.p.plugin') @@ -38,7 +40,7 @@ class GajimPlugin: __path__: str = '' encryption_name: str = '' - manifest: Any + manifest: PluginManifest gui_extension_points: PluginExtensionPoints = {} ''' ===================================== gajim/plugins/manifest.py ===================================== @@ -0,0 +1,123 @@ +# This file is part of Gajim. +# +# Gajim is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published +# by the Free Software Foundation; version 3 only. +# +# Gajim is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with Gajim. If not, see <http://www.gnu.org/licenses/>. + +from __future__ import annotations + +from typing import Any +from typing import Optional + +import sys +import json +from dataclasses import dataclass +from pathlib import Path + +from packaging.version import Version as V +from packaging.requirements import Requirement + +import gajim +from gajim.common.i18n import _ + +from gajim.plugins.plugins_i18n import _ as p_ +from gajim.plugins.helpers import is_shipped_plugin + + +BLOCKED_PLUGINS = [ + 'appindicator_integration', + 'plugin_installer', + 'syntax_highlight', + 'url_image_preview' +] + +GAJIM_VERSION = V(gajim.__version__.split('+', 1)[0]).base_version + + +@dataclass(frozen=True, eq=True) +class PluginManifest: + name: str + short_name: str + description: str + authors: list[str] + homepage: str + config_dialog: bool + version: V + requirements: list[Requirement] + platforms: list[str] + path: Optional[Path] = None + + def __hash__(self): + return hash(f'{self.short_name}_{self.version}') + + @property + def is_usable(self) -> bool: + if self.short_name in BLOCKED_PLUGINS: + return False + + if not self._check_requirements(): + return False + + platform = sys.platform + if platform not in ('win32', 'darwin', 'linux'): + # sys.platform can return an unknown amount of unix/linux derivates + platform = 'others' + + return platform in self.platforms + + @property + def is_shipped(self) -> bool: + if self.path is None: + return False + return is_shipped_plugin(self.path) + + def get_remote_url(self, repository_url: str) -> str: + filename = f'{self.short_name}_{self.version}.zip' + return f'{repository_url}/{self.short_name}/{filename}' + + @classmethod + def from_path(cls, path: Path) -> PluginManifest: + manifest_path = path / 'plugin-manifest.json' + if not manifest_path.exists(): + raise ValueError(f'Not a plugin path: {path}') + + if manifest_path.is_dir(): + raise ValueError(f'Not a plugin path: {path}') + + with manifest_path.open(encoding='utf8') as f: + try: + manifest = json.load(f) + except Exception as error: + raise ValueError(f'Error while parsing manifest: ' + f'{path}, {error}') + return cls.from_manifest_json(manifest, manifest_path) + + def _check_requirements(self) -> bool: + for req in self.requirements: + if GAJIM_VERSION in req.specifier: + return True + return False + + @classmethod + def from_manifest_json(cls, + manifest: dict[str, Any], + path: Optional[Path] = None) -> PluginManifest: + return cls( + name=manifest['name'], + short_name=manifest['short_name'], + description=p_(manifest['description']), + authors=manifest['authors'], + homepage=manifest['homepage'], + config_dialog=manifest['config_dialog'], + version=V(manifest['version']), + requirements=[Requirement(r) for r in manifest['requirements']], + platforms=manifest['platforms'], + path=path.parent if path is not None else path) ===================================== gajim/plugins/pluginmanager.py ===================================== @@ -21,19 +21,13 @@ import os import sys -import json import zipfile import logging from shutil import rmtree, move -from dataclasses import dataclass from pathlib import Path from importlib.util import spec_from_file_location from importlib.util import module_from_spec -from packaging.version import Version as V -from packaging.requirements import Requirement - -import gajim from gajim.common import app from gajim.common import configpaths from gajim.common import modules @@ -43,24 +37,17 @@ from gajim.common.i18n import _ from gajim.common.exceptions import PluginsystemError from gajim.common.util.classes import Singleton -from gajim.plugins.plugins_i18n import _ as p_ from gajim.plugins.helpers import GajimPluginActivateException from gajim.plugins.helpers import is_shipped_plugin from gajim.plugins.gajimplugin import GajimPlugin from gajim.plugins.gajimplugin import GajimPluginException +from gajim.plugins.manifest import PluginManifest log = logging.getLogger('gajim.p.manager') RmErrorT = tuple[type[BaseException], BaseException, TracebackType] -BLOCKED_PLUGINS = [ - 'appindicator_integration', - 'plugin_installer', - 'syntax_highlight', - 'url_image_preview' -] - FIELDS = ('name', 'short_name', 'version', @@ -68,89 +55,6 @@ 'authors', 'homepage') -GAJIM_VERSION = V(gajim.__version__.split('+', 1)[0]).base_version - - -@dataclass(frozen=True, eq=True) -class PluginManifest: - name: str - short_name: str - description: str - authors: list[str] - homepage: str - config_dialog: bool - version: V - requirements: list[Requirement] - platforms: list[str] - path: Optional[Path] = None - - def __hash__(self): - return hash(f'{self.short_name}_{self.version}') - - @property - def is_usable(self) -> bool: - if self.short_name in BLOCKED_PLUGINS: - return False - - if not self._check_requirements(): - return False - - platform = sys.platform - if platform not in ('win32', 'darwin', 'linux'): - # sys.platform can return an unknown amount of unix/linux derivates - platform = 'others' - - return platform in self.platforms - - @property - def is_shipped(self) -> bool: - if self.path is None: - return False - return is_shipped_plugin(self.path) - - def get_remote_url(self, repository_url: str) -> str: - filename = f'{self.short_name}_{self.version}.zip' - return f'{repository_url}/{self.short_name}/{filename}' - - @classmethod - def from_path(cls, path: Path) -> PluginManifest: - manifest_path = path / 'plugin-manifest.json' - if not manifest_path.exists(): - raise ValueError(f'Not a plugin path: {path}') - - if manifest_path.is_dir(): - raise ValueError(f'Not a plugin path: {path}') - - with manifest_path.open(encoding='utf8') as f: - try: - manifest = json.load(f) - except Exception as error: - raise ValueError(f'Error while parsing manifest: ' - f'{path}, {error}') - return cls.from_manifest_json(manifest, manifest_path) - - def _check_requirements(self) -> bool: - for req in self.requirements: - if GAJIM_VERSION in req.specifier: - return True - return False - - @classmethod - def from_manifest_json(cls, - manifest: dict[str, Any], - path: Optional[Path] = None) -> PluginManifest: - return cls( - name=manifest['name'], - short_name=manifest['short_name'], - description=p_(manifest['description']), - authors=manifest['authors'], - homepage=manifest['homepage'], - config_dialog=manifest['config_dialog'], - version=V(manifest['version']), - requirements=[Requirement(r) for r in manifest['requirements']], - platforms=manifest['platforms'], - path=path.parent if path is not None else path) - class PluginManager(metaclass=Singleton): ''' ===================================== gajim/plugins/repository.py ===================================== @@ -28,7 +28,7 @@ from gajim.common import configpaths from gajim.common.helpers import Observable from gajim.common.helpers import make_http_request -from gajim.plugins.pluginmanager import PluginManifest +from gajim.plugins.manifest import PluginManifest log = logging.getLogger('gajim.p.repository') ===================================== pyproject.toml ===================================== @@ -36,6 +36,7 @@ exclude = [ "gajim/gtk/settings.py", "gajim/gtk/server_info.py", "gajim/gtk/groupchat_info.py", + "gajim/plugins/pluginmanager.py", ] include = [ "launch.py", @@ -75,10 +76,7 @@ include = [ "gajim/gajim.py", "gajim/gajim_remote.py", "gajim/gtk/*", - "gajim/plugins/gajimplugin.py", - "gajim/plugins/helpers.py", - "gajim/plugins/plugins_i18n.py", - "gajim/plugins/repository.py", + "gajim/plugins/*", ] View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/184e3fab4b17715514724f9e1f7c098… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/184e3fab4b17715514724f9e1f7c098… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] ci: Temporary freeze pyright version
by Philipp Hörist (＠lovetox) 22 Dec '22

22 Dec '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: 184e3fab by Philipp Hörist at 2022-12-22T23:27:42+01:00 ci: Temporary freeze pyright version - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -27,7 +27,7 @@ test-pyright: script: - pip3 install git+https://dev.gajim.org/gajim/python-nbxmpp.git - PYGOBJECT_STUB_CONFIG=Gtk3,Gdk3,Soup2 pip3 install git+https://github.com/pygobject/pygobject-stubs.git - - npm install pyright + - npm install pyright(a)1.1.284 - python3 .ci/link-gtk.py - $(npm bin)/pyright --version - $(npm bin)/pyright View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/184e3fab4b17715514724f9e1f7c0985… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/184e3fab4b17715514724f9e1f7c0985… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix: AccountWizard: Remove subscriptions after successfull login
by Philipp Hörist (＠lovetox) 22 Dec '22

22 Dec '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: 119590f4 by Philipp Hörist at 2022-12-22T22:19:37+01:00 fix: AccountWizard: Remove subscriptions after successfull login Calling _disconnect() removes all subscriptions and cleans up the client. Fixes #11342 - - - - - 1 changed file: - gajim/gtk/account_wizard.py Changes: ===================================== gajim/gtk/account_wizard.py ===================================== @@ -381,6 +381,7 @@ def _on_login_successful(self, client: Client, _signal_name: str) -> None: client.custom_host) self.get_page('success').set_account(account) self.show_page('success', Gtk.StackTransitionType.SLIDE_LEFT) + self._disconnect() def _on_connected(self, client: Client, _signal_name: str) -> None: client.get_module('Register').request_register_form( @@ -402,8 +403,10 @@ def _on_anonymous_supported(self, proxy_name, client.custom_host, anonymous=True) + self.get_page('success').set_account(account) self.show_page('success', Gtk.StackTransitionType.SLIDE_LEFT) + self._disconnect() def _on_disconnected(self, client: Client, _signal_name: str) -> None: domain, error, text = client.get_error() @@ -430,15 +433,6 @@ def _on_disconnected(self, client: Client, _signal_name: str) -> None: _('Signup not allowed'), _('This server does not allow signup.')) - elif domain == StreamError.STREAM: - # The credential test often ends with a stream error, because - # after auth there should be a stream restart but nbxmpp ends - # the stream with </stream> which is considered not-well-formed - # by the server. This ignores all stream errors if we already - # know that we succeeded. - if self.get_current_page() != 'success': - self._show_error_page(_('Error'), _('Error'), text or error) - else: self._show_error_page(_('Error'), _('Error'), text or error) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/119590f4dbcf8e0db0df624e8d98c4aa… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/119590f4dbcf8e0db0df624e8d98c4aa… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix: ConversationView: Simplify merging messages
by Philipp Hörist (＠lovetox) 21 Dec '22

21 Dec '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: b2f70668 by Philipp Hörist at 2022-12-21T23:39:51+01:00 fix: ConversationView: Simplify merging messages Simplify the logic and fix wrong merges under some conditions - - - - - 1 changed file: - gajim/gtk/conversation/view.py Changes: ===================================== gajim/gtk/conversation/view.py ===================================== @@ -614,13 +614,8 @@ def _update_descendants(self, message: MessageRow) -> None: if not isinstance(row, MessageRow): return - if message.is_mergeable(row): - row.set_merged(True) - continue - - if message.is_same_sender(row): - row.set_merged(False) - self._update_descendants(row) + merge = message.is_mergeable(row) + row.set_merged(merge) return def reduce_message_count(self, before: bool) -> bool: View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/b2f70668e8d030aaeea528a62e30c4ba… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/b2f70668e8d030aaeea528a62e30c4ba… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/python-nbxmpp][soup3] refactor
by Philipp Hörist (＠lovetox) 20 Dec '22

20 Dec '22

Philipp Hörist pushed to branch soup3 at gajim / python-nbxmpp Commits: d4889d71 by Philipp Hörist at 2022-12-20T21:14:03+01:00 refactor - - - - - 2 changed files: - nbxmpp/http.py - test/unit/test_http.py Changes: ===================================== nbxmpp/http.py ===================================== @@ -37,7 +37,17 @@ from nbxmpp.const import HTTPRequestError log = logging.getLogger('nbxmpp.http') -HTTP_METHODS_T = Literal['GET', 'POST'] +HTTP_METHODS_T = Literal[ + 'CONNECT', + 'DELETE', + 'GET', + 'HEAD', + 'OPTIONS', + 'PATCH', + 'POST', + 'PUT', + 'TRACE', +] CHUNK_SIZE = 32768 DEFAULT_USER_AGENT = f'nbxmpp/{nbxmpp.__version__}' SIGNAL_ACTIONS = GObject.SignalFlags.RUN_LAST | GObject.SignalFlags.ACTION @@ -224,26 +234,17 @@ class HTTPRequest(GObject.GObject): callback, user_data = args[-1] callback(self, *signal_args, *user_data) - def post(self, + def send(self, + method: HTTP_METHODS_T, uri_string: str, timeout: Optional[int] = None, callback: Optional[Callable[[HTTPRequest], Any]] = None, + user_data: Optional[Any] = None ) -> None: - if callback is not None: + if callback: self.connect('finished', callback) - self._send('POST', uri_string, timeout=timeout) - - def get(self, - uri_string: str, - timeout: Optional[int] = None, - callback: Optional[Callable[[HTTPRequest], Any]] = None, - user_data: Optional[Any] = None - ) -> None: - - if callback is not None: - self.connect('finished', callback) - self._send('GET', uri_string, timeout=timeout) + self._send(method, uri_string, timeout) def _send(self, method: HTTP_METHODS_T, ===================================== test/unit/test_http.py ===================================== @@ -54,7 +54,7 @@ class HTTP(unittest.TestCase): request.connect('finished', callback_mock.finished) request.connect('destroy', lambda *args: mainloop.quit()) - request.get(SMALL_FILE_URL, timeout=10) + request.send('GET', SMALL_FILE_URL, timeout=10) mainloop.run() @@ -78,7 +78,7 @@ class HTTP(unittest.TestCase): request.connect('starting-response-body', callback_mock.starting) request.connect('finished', callback_mock.finished) request.connect('destroy', lambda *args: mainloop.quit()) - request.get(SMALL_FILE_URL, timeout=10) + request.send('GET', SMALL_FILE_URL, timeout=10) mainloop.run() @@ -102,7 +102,7 @@ class HTTP(unittest.TestCase): request.connect('starting-response-body', callback_mock.starting) request.connect('finished', callback_mock.finished) request.connect('destroy', lambda *args: mainloop.quit()) - request.get(SMALL_FILE_URL, timeout=10) + request.send('GET', SMALL_FILE_URL, timeout=10) GLib.timeout_add(10, request.cancel) @@ -132,7 +132,7 @@ class HTTP(unittest.TestCase): request.connect('response-progress', _on_progress) request.connect('finished', callback_mock.finished) request.connect('destroy', lambda *args: mainloop.quit()) - request.get(BIG_FILE_URL, timeout=10) + request.send('GET', BIG_FILE_URL, timeout=10) mainloop.run() @@ -154,7 +154,7 @@ class HTTP(unittest.TestCase): request.connect('finished', callback_mock.finished) request.connect('response-progress', callback_mock.progress) request.connect('destroy', lambda *args: mainloop.quit()) - request.get(NO_FILE_URL, timeout=5) + request.send('GET', NO_FILE_URL, timeout=5) mainloop.run() @@ -177,7 +177,7 @@ class HTTP(unittest.TestCase): request.connect('starting-response-body', callback_mock.starting) request.connect('finished', callback_mock.finished) request.connect('destroy', lambda *args: mainloop.quit()) - request.get(BIG_FILE_URL, timeout=1) + request.send('GET', BIG_FILE_URL, timeout=1) mainloop.run() @@ -199,7 +199,7 @@ class HTTP(unittest.TestCase): request.connect('starting', callback_mock.starting, 1, 2, 3) request.connect('got-body', callback_mock.got_body) request.connect('destroy', lambda *args: mainloop.quit()) - request.get(SMALL_FILE_URL, timeout=10) + request.send('GET', SMALL_FILE_URL, timeout=10) mainloop.run() View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/d4889d71dc3550fb8bd00b43… -- View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/d4889d71dc3550fb8bd00b43… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] other: Add more package metadata
by Philipp Hörist (＠lovetox) 20 Dec '22

20 Dec '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: 71adf765 by Philipp Hörist at 2022-12-20T21:12:20+01:00 other: Add more package metadata - - - - - 1 changed file: - setup.cfg Changes: ===================================== setup.cfg ===================================== @@ -2,12 +2,20 @@ name = gajim version = attr: gajim.__version__ description = A GTK XMPP client +long_description = file: README.md +long_description_content_type = text/markdown author = Philipp Hoerist, Yann Leboulanger author_email = gajim-devel(a)gajim.org url = https://gajim.org license = GPL v3 +keywords = chat,messaging,im,xmpp,voip classifiers = - Programming Language :: Python :: 3 + Development Status :: 5 - Production/Stable + Environment :: X11 Applications :: GTK + License :: OSI Approved :: GNU General Public License v3 (GPLv3) + Operating System :: OS Independent + Programming Language :: Python :: 3.9 + Topic :: Communications :: Chat [options] python_requires = >=3.9 View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/71adf7654b9219c70cb61ff0e328ca75… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/71adf7654b9219c70cb61ff0e328ca75… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][soup3] soup
by Philipp Hörist (＠lovetox) 20 Dec '22

20 Dec '22

Philipp Hörist pushed to branch soup3 at gajim / gajim Commits: bcad2326 by Philipp Hörist at 2022-12-20T18:41:23+01:00 soup - - - - - 8 changed files: - gajim/common/application.py - gajim/common/client.py - gajim/common/helpers.py - gajim/common/modules/httpupload.py - gajim/common/preview.py - + gajim/common/util/http.py - gajim/gtk/exception.py - gajim/plugins/repository.py Changes: ===================================== gajim/common/application.py ===================================== @@ -29,9 +29,9 @@ from gi.repository import Gio from gi.repository import GLib -from gi.repository import Soup from nbxmpp.const import ConnectionType from nbxmpp.const import ConnectionProtocol +from nbxmpp.http import HTTPRequest from gajim.common import app from gajim.common import ged @@ -48,7 +48,6 @@ from gajim.common.events import GajimUpdateAvailable from gajim.common.events import SignedIn from gajim.common.client import Client -from gajim.common.helpers import make_http_request from gajim.common.helpers import get_random_string from gajim.common.helpers import get_global_show from gajim.common.helpers import from_one_line @@ -60,6 +59,7 @@ from gajim.common.storage.cache import CacheStorage from gajim.common.storage.draft import DraftStorage from gajim.common.storage.archive import MessageArchiveStorage +from gajim.common.util.http import create_http_request from gajim.plugins import PluginManager from gajim.plugins.repository import PluginRepository @@ -310,22 +310,21 @@ def _check_for_updates(self) -> None: def check_for_gajim_updates(self) -> None: self._log.info('Checking for Gajim updates') - make_http_request('https://gajim.org/current-version.json', - self._on_update_response) + request = create_http_request() + request.get('https://gajim.org/current-version.json', + callback=self._on_update_response) - def _on_update_response(self, - _session: Soup.Session, - message: Soup.Message) -> None: + def _on_update_response(self, request: HTTPRequest) -> None: + + if not request.is_complete(): + self._log.warning('Error while performing gajim update check: %s', + request.get_error(), request.get_status()) + return now = datetime.now() app.settings.set('last_update_check', now.strftime('%Y-%m-%d %H:%M')) - response_body = message.props.response_body - if response_body is None or not response_body.data: - self._log.warning('Could not reach gajim.org for update check') - return - - data = json.loads(response_body.data) + data = json.loads(request.get_data()) latest_version = data['current_version'] if V(latest_version) > V(app.version): ===================================== gajim/common/client.py ===================================== @@ -55,6 +55,7 @@ from gajim.common.idle import IdleMonitorManager from gajim.common.i18n import _ from gajim.common.structs import OutgoingMessage +from gajim.common.util.http import create_http_session from gajim.gui.util import open_window @@ -175,6 +176,8 @@ def _create_client(self) -> None: self._client.set_password(self.password) + self._client.set_http_session(create_http_session()) + self._client.subscribe('resume-failed', self._on_resume_failed) self._client.subscribe('resume-successful', self._on_resume_successful) self._client.subscribe('disconnected', self._on_disconnected) ===================================== gajim/common/helpers.py ===================================== @@ -1551,7 +1551,7 @@ def make_path_from_jid(base_path: Path, jid: JID) -> Path: def make_http_request(uri: str, callback: Any, user_data: Optional[Any] = None) -> None: - + # TODO REMOVE proxy = determine_proxy() if proxy is None: resolver = None ===================================== gajim/common/modules/httpupload.py ===================================== @@ -53,6 +53,7 @@ from gajim.common.modules.base import BaseModule from gajim.common.exceptions import FileError from gajim.common.structs import OutgoingMessage +from gajim.common.util.http import create_http_request class HTTPUpload(BaseModule): @@ -70,8 +71,8 @@ def __init__(self, con: types.Client) -> None: self._proxy_resolver: Optional[Gio.SimpleProxyResolver] = None self._queued_messages: dict[int, Soup.Message] = {} self._session = Soup.Session() - self._session.props.ssl_strict = False - self._session.props.user_agent = f'Gajim {app.version}' + # self._session.props.ssl_strict = False + # self._session.props.user_agent = f'Gajim {app.version}' self._running_transfers: dict[ tuple[str, JID], set[HTTPFileTransfer]] = defaultdict(set) @@ -283,16 +284,13 @@ def _upload_file(self, transfer: HTTPFileTransfer) -> None: transfer.set_started() assert transfer.put_uri is not None - message = Soup.Message.new('PUT', transfer.put_uri) - message.connect('starting', self._check_certificate, transfer) + request = create_http_request(self._account) + request.set_user_data(transfer) + request.connect('accept-certificate', self._check_certificate) + request.connect('request-progress', self._on_request_progress) - # Set CAN_REBUILD so chunks get discarded after they have been - # written to the network - message.set_flags(Soup.MessageFlags.CAN_REBUILD | - Soup.MessageFlags.NO_REDIRECT) - - assert message.props.request_body is not None - message.props.request_body.set_accumulate(False) + request.set_ + request.send('PUT', transfer.put_uri, callback=self._on_finish) assert message.props.request_headers is not None message.props.request_headers.set_content_type(transfer.mime, None) ===================================== gajim/common/preview.py ===================================== @@ -14,12 +14,14 @@ from __future__ import annotations -from dataclasses import dataclass, field from typing import Any +from typing import cast from typing import Callable from typing import Optional import logging +from dataclasses import dataclass +from dataclasses import field import os import re from pathlib import Path @@ -30,6 +32,8 @@ from gi.repository import Gio from gi.repository import GLib from gi.repository import Soup +from nbxmpp.const import HTTPRequestError +from nbxmpp.http import HTTPRequest from nbxmpp.util import convert_tls_error_flags from gajim.common import app @@ -40,7 +44,6 @@ from gajim.common.helpers import load_file_async from gajim.common.helpers import write_file_async from gajim.common.helpers import get_tls_error_phrases -from gajim.common.helpers import get_account_proxy from gajim.common.i18n import _ from gajim.common.preview_helpers import aes_decrypt from gajim.common.preview_helpers import filename_from_uri @@ -52,6 +55,7 @@ from gajim.common.preview_helpers import guess_mime_type from gajim.common.preview_helpers import pixbuf_from_data from gajim.common.types import GdkPixbufType +from gajim.common.util.http import create_http_request log = logging.getLogger('gajim.c.preview') @@ -104,12 +108,11 @@ def __init__(self, self.thumbnail: Optional[bytes] = None self.mime_type: str = '' self.file_size: int = 0 - self._received_size: int = 0 self.download_in_progress = False self.info_message: Optional[str] = None - self._soup_message: Optional[Soup.Message] = None + self._request = None self.key: Optional[bytes] = None self.iv: Optional[bytes] = None @@ -154,8 +157,8 @@ def filename(self) -> str: return self._filename @property - def soup_message(self) -> Soup.Message: - return self._soup_message + def request(self) -> HTTPRequest: + return self._request @property def request_uri(self) -> Optional[str]: @@ -193,20 +196,12 @@ def create_thumbnail(self, data: bytes) -> bool: return False return True - def reset_received_size(self) -> None: - self._received_size = 0 - def update_widget(self, data: Optional[GdkPixbufType] = None) -> None: self._widget.update(self, data) - def update_progress(self, size: int, message: Soup.Message) -> None: + def update_progress(self, progress: float, request: HTTPRequest) -> None: self.download_in_progress = True - self._soup_message = message - self._received_size += size - if self.file_size == 0 or self._received_size == 0: - return - - progress = self._received_size / self.file_size + self._request = request self._widget.update_progress(self, progress) @@ -273,24 +268,6 @@ def _get_session(self, account: str) -> Soup.Session: self._sessions[account] = self._create_session(account) return self._sessions[account][0] - @staticmethod - def _create_session(account: str) -> tuple[ - Soup.Session, Optional[Gio.SimpleProxyResolver]]: - session = Soup.Session() - session.add_feature_by_type(Soup.ContentSniffer) - session.props.https_aliases = ['aesgcm'] - session.props.ssl_strict = False - session.props.user_agent = f'Gajim {app.version}' - - proxy = get_account_proxy(account) - if proxy is None: - resolver = None - else: - resolver = proxy.get_resolver() - - session.props.proxy_resolver = resolver - return session, resolver - @staticmethod def _accept_uri(urlparts: ParseResult, uri: str, @@ -476,58 +453,62 @@ def download_content(self, log.info('Download already in progress') return - preview.reset_received_size() if preview.account is None: # History Window can be opened without account context # This means we can not apply proxy settings return log.info('Start downloading: %s', preview.request_uri) - message = Soup.Message.new('GET', preview.request_uri) - message.connect('starting', self._check_certificate, preview) - message.connect( - 'content-sniffed', self._on_content_sniffed, preview, force) - message.connect('got-chunk', self._on_got_chunk, preview) - session = self._get_session(preview.account) - session.queue_message(message, self._on_finished, preview) + request = create_http_request(preview.account, sniffer=True) + request.set_user_data(preview) + request.connect('accept-certificate', self._check_certificate) + request.connect('content-sniffed', self._on_content_sniffed, force) + request.connect('response-progress', self._on_response_progress) + + request.get(preview.request_uri, callback=self._on_finished) def _check_certificate(self, - message: Soup.Message, - preview: Preview) -> None: - _https_used, _tls_certificate, tls_errors = message.get_https_status() + request: HTTPRequest, + certificate: Gio.TlsCertificate, + certificate_errors: Gio.TlsCertificateFlags, + ) -> bool: if not app.settings.get('preview_verify_https'): - return + return True - if tls_errors: - phrases = get_tls_error_phrases(convert_tls_error_flags(tls_errors)) - log.warning( - 'TLS verification failed: %s (0x%02x)', phrases, tls_errors) - session = self._get_session(preview.account) - session.cancel_message(message, Soup.Status.CANCELLED) - preview.info_message = _('TLS verification failed: %s') % phrases[0] - preview.update_widget() + phrases = get_tls_error_phrases( + convert_tls_error_flags(certificate_errors)) + log.warning( + 'TLS verification failed: %s (0x%02x)', phrases, certificate_errors) + + preview = cast(Preview, request.get_user_data()) + preview.info_message = _('TLS verification failed: %s') % phrases[0] + preview.update_widget() + return False def _on_content_sniffed(self, - message: Soup.Message, - type_: str, + request: HTTPRequest, + content_type: str, _params: GLib.HashTable, - preview: Preview, - force: bool) -> None: - file_size = message.props.response_headers.get_content_length() - uri = message.props.uri.to_string(False) - session = self._get_session(preview.account) - preview.mime_type = type_ + force: bool + ) -> None: + + file_size = request.get_response_headers().get_content_length() + uri = request.get_uri().to_string() + + + preview = cast(Preview, request.get_user_data()) + preview.mime_type = content_type preview.file_size = file_size - if type_ not in ALLOWED_MIME_TYPES and not force: - log.info('Not an allowed content type: %s, %s', type_, uri) - session.cancel_message(message, Soup.Status.CANCELLED) + if content_type not in ALLOWED_MIME_TYPES and not force: + log.info('Not an allowed content type: %s, %s', content_type, uri) + request.cancel() return if file_size == 0: log.info('File size is unknown (zero) for URL: "%s"', uri) - session.cancel_message(message, Soup.Status.CANCELLED) + request.cancel() return if file_size > int(app.settings.get('preview_max_file_size')): @@ -537,42 +518,37 @@ def _on_content_sniffed(self, if force: preview.info_message = None else: - session.cancel_message(message, Soup.Status.CANCELLED) + request.cancel() preview.info_message = _('Automatic preview disabled ' '(file too big)') preview.update_widget() - def _on_got_chunk(self, - message: Soup.Message, - chunk: Soup.Buffer, - preview: Preview - ) -> None: - preview.update_progress(len(chunk.get_data()), message) + def _on_response_progress(self, + request: HTTPRequest, + progress: float, + ) -> None: - def _on_finished(self, - _session: Soup.Session, - message: Soup.Message, - preview: Preview - ) -> None: + preview = cast(Preview, request.get_user_data()) + preview.update_progress(progress, request) + def _on_finished(self, request: HTTPRequest) -> None: + + preview = cast(Preview, request.get_user_data()) preview.download_in_progress = False - if message.status_code != Soup.Status.OK: - log.warning('Download failed: %s', preview.request_uri) - status_code = Soup.Status.get_phrase(message.status_code) - log.warning(status_code) - preview.reset_received_size() - if message.status_code != 1: - # status_code 1: 'Cancelled' - preview.info_message = _('Download failed (%s)') % status_code + if not request.is_complete(): + error = request.get_error_string() + log.warning('Download failed: %s - %s', preview.request_uri, error) + if request.get_error() != HTTPRequestError.CANCELLED: + preview.info_message = _('Download failed (%s)') % error preview.update_widget() return preview.info_message = None - data = message.props.response_body_data.get_data() - if data is None: + data = request.get_data() + if not data: return if preview.is_aes_encrypted: @@ -649,6 +625,4 @@ def _on_thumb_write_finished(_result: bool, preview.update_widget(data=pixbuf) def cancel_download(self, preview: Preview) -> None: - preview.reset_received_size() - session = self._get_session(preview.account) - session.cancel_message(preview.soup_message, Soup.Status.CANCELLED) + preview.request.cancel() ===================================== gajim/common/util/http.py ===================================== @@ -0,0 +1,48 @@ +# This file is part of Gajim. +# +# Gajim is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published +# by the Free Software Foundation; version 3 only. +# +# Gajim is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with Gajim. If not, see <http://www.gnu.org/licenses/>. + +from typing import Optional + +from nbxmpp.http import HTTPRequest +from nbxmpp.http import HTTPSession + +from gajim.common import app +from gajim.common.helpers import determine_proxy +from gajim.common.helpers import get_account_proxy + + +def create_http_session(account: Optional[str] = None, + sniffer: bool = False + ) -> HTTPSession: + + session = HTTPSession(user_agent=f'Gajim {app.version}', + sniffer=sniffer) + + if account is None: + proxy = determine_proxy() + else: + proxy = get_account_proxy(account) + + if proxy is not None: + session.set_proxy_resolver(proxy.get_resolver()) + + return session + + +def create_http_request(account: Optional[str] = None, + sniffer: bool = False + ) -> HTTPRequest: + + session = create_http_session(account, sniffer) + return session.create_request() ===================================== gajim/gtk/exception.py ===================================== @@ -20,11 +20,11 @@ from __future__ import annotations from typing import Any -from types import TracebackType import sys import json import traceback +from types import TracebackType import threading import webbrowser import pprint @@ -33,9 +33,9 @@ from gi.repository import Gdk from gi.repository import Gtk -from gi.repository import Soup import nbxmpp +from nbxmpp.http import HTTPRequest import gajim from gajim.common import app @@ -44,8 +44,8 @@ from gajim.common.helpers import get_os_name from gajim.common.helpers import get_os_version from gajim.common.helpers import determine_proxy -from gajim.common.helpers import make_http_request from gajim.common.i18n import _ +from gajim.common.util.http import create_http_request from .builder import get_builder from .util import get_gtk_version @@ -182,24 +182,17 @@ def _request_sentry_endpoint(self) -> None: self._ui.report_spinner.show() self._ui.report_spinner.start() - make_http_request('https://gajim.org/updates.json', - self._on_endpoint_received) + request = create_http_request() + request.get('https://gajim.org/updates.json', + callback=self._on_endpoint_received) - def _parse_endpoint(self, message: Soup.Message) -> str: - status = message.props.status_code - response_body = message.props.response_body - - if status != Soup.Status.OK: - error = message.props.reason_phrase + def _parse_endpoint(self, request: HTTPRequest) -> str: + if not request.is_complete(): raise ValueError('Failed to retrieve sentry endpoint: %s %s' % ( - status, error)) - - if response_body is None or not response_body.data: - raise ValueError('Failed to retrieve sentry endpoint, ' - 'no response body') + request.get_status(), request.get_error())) try: - data = json.loads(response_body.data) + data = json.loads(request.get_data()) except Exception as error: raise ValueError('Json parsing error: %s' % error) @@ -209,12 +202,9 @@ def _parse_endpoint(self, message: Soup.Message) -> str: return endpoint - def _on_endpoint_received(self, - _session: Soup.Session, - message: Soup.Message - ) -> None: + def _on_endpoint_received(self, request: HTTPRequest) -> None: try: - endpoint = self._parse_endpoint(message) + endpoint = self._parse_endpoint(request) except ValueError as error: print(error) self._report_with_browser() ===================================== gajim/plugins/repository.py ===================================== @@ -12,7 +12,7 @@ # You should have received a copy of the GNU General Public License # along with Gajim. If not, see <http://www.gnu.org/licenses/>. -from typing import Any +from typing import Any, cast from typing import Iterable from typing import Optional @@ -21,13 +21,13 @@ from io import BytesIO from zipfile import ZipFile -from gi.repository import Soup from gi.repository import GLib +from nbxmpp.http import HTTPRequest from gajim.common import app from gajim.common import configpaths from gajim.common.helpers import Observable -from gajim.common.helpers import make_http_request +from gajim.common.util.http import create_http_request from gajim.plugins.pluginmanager import PluginManifest @@ -60,28 +60,27 @@ def __init__(self) -> None: self._download_queue: set[PluginManifest] = set() if app.settings.get('plugins_repository_enabled'): - make_http_request('https://gajim.org/updates.json', - self._on_repository_received) + request = create_http_request() + request.get('https://gajim.org/updates.json', + callback=self._on_repository_received) @property def available(self): return bool(self._repository_url) - def _on_repository_received(self, - _session: Soup.Session, - message: Soup.Message) -> None: + def _on_repository_received(self, request: HTTPRequest) -> None: - if message.status_code != Soup.Status.OK: - log.warning('Repository retrieval failed') - log.warning(Soup.Status.get_phrase(message.status_code)) + if not request.is_complete(): + log.warning('Repository retrieval failed: %s', + request.get_error_string()) return - assert message.props.response_body_data is not None - data = message.props.response_body_data.get_data() - if data is None: + try: + updates = json.loads(request.get_data()) + except Exception as error: + log.warning('Unable to parse repository information: %s', error) return - updates = json.loads(data.decode()) repository_url = updates.get('plugin_repository') if repository_url is None: log.warning('No plugin repository url found') @@ -148,56 +147,49 @@ def _parse_package_json(self, def _refresh_plugin_index(self, callback: Optional[Any] = None) -> None: log.info('Refresh index') - make_http_request(self._repository_index_url, - self._on_index_received, - callback) - - def _on_index_received(self, - _session: Soup.Session, - message: Soup.Message, - callback: Optional[Any] = None) -> None: - - if message.status_code != Soup.Status.OK: - log.warning('Refresh failed: %s', self._repository_index_url) - log.warning(Soup.Status.get_phrase(message.status_code)) - return + request = create_http_request() + request.set_user_data(callback) + request.get(self._repository_index_url, + callback=self._on_index_received) - assert message.props.response_body_data is not None - data = message.props.response_body_data.get_data() - if data is None: + def _on_index_received(self, request: HTTPRequest) -> None: + + if not request.is_complete(): + log.warning('Refresh failed: %s %s', + self._repository_index_url, + request.get_error_string()) return - package_index = json.loads(data.decode()) + try: + package_index = json.loads(request.get_data()) + except Exception as error: + log.warning('Unable to parse repository index: %s', error) + return self._manifests = self._parse_package_json(package_index) image_path = package_index['metadata']['image_path'] - make_http_request(f'{self._repository_url}/{image_path}', - self._on_images_received) + callback = request.get_user_data() + + request = create_http_request() + request.get(f'{self._repository_url}/{image_path}', + callback=self._on_images_received) log.info('Refresh successful') if callback is not None: callback() - def _on_images_received(self, - _session: Soup.Session, - message: Soup.Message) -> None: + def _on_images_received(self, request: HTTPRequest) -> None: - if message.status_code != Soup.Status.OK: - log.warning('Image download failed') - log.warning(Soup.Status.get_phrase(message.status_code)) - return - - assert message.props.response_body_data is not None - data = message.props.response_body_data.get_data() - if data is None: + if not request.is_complete(): + log.warning('Image download failed: %s', request.get_error_string()) return path = configpaths.get('PLUGINS_IMAGES') try: - zipfile = ZipFile(BytesIO(data)) + zipfile = ZipFile(BytesIO(request.get_data())) zipfile.extractall(path) except Exception as error: log.warning('Failed to extract images: %s', error) @@ -245,27 +237,25 @@ def download_plugins(self, manifests: Iterable[PluginManifest]) -> None: def _download_plugin(self, manifest: PluginManifest) -> None: log.info('Download plugin %s', manifest.short_name) url = manifest.get_remote_url(self._repository_url) - make_http_request(url, self._on_download_plugin_finished, manifest) + request = create_http_request() + request.set_user_data(manifest) + request.get(url, + callback=self._on_download_plugin_finished) - def _on_download_plugin_finished(self, - _session: Soup.Session, - message: Soup.Message, - manifest: PluginManifest) -> None: + def _on_download_plugin_finished(self, request: HTTPRequest) -> None: + manifest = cast(PluginManifest, request.get_user_data()) self._download_queue.remove(manifest) - if message.status_code != Soup.Status.OK: - error = Soup.Status.get_phrase(message.status_code) - log.error('Download failed: %s', - manifest.get_remote_url(self._repository_url)) - log.error(error) + if not request.is_complete(): + error = request.get_error_string() + log.error('Download failed: %s %s', + manifest.get_remote_url(self._repository_url), + error) self.notify('download-failed', manifest, error) return - assert message.props.response_body_data is not None - data = message.props.response_body_data.get_data() - - with ZipFile(BytesIO(data)) as zip_file: + with ZipFile(BytesIO(request.get_data())) as zip_file: zip_file.extractall(self._download_path / manifest.short_name) log.info('Finished downloading %s', manifest.short_name) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/bcad2326dd453c6b8c08a9e6159b5a2b… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/bcad2326dd453c6b8c08a9e6159b5a2b… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][omemo_integration] 193 commits: imprv: Preferences: Improve preview settings
by Philipp Hörist (＠lovetox) 20 Dec '22

20 Dec '22

Philipp Hörist pushed to branch omemo_integration at gajim / gajim Commits: 2d6e4b5a by wurstsalat at 2022-11-08T14:27:57+01:00 imprv: Preferences: Improve preview settings - - - - - 35b754f6 by wurstsalat at 2022-11-08T16:02:10+01:00 cfix: Preferences: Revert preview file size units - - - - - 8e5bb40c by wurstsalat at 2022-11-09T20:32:44+01:00 fix: Preview: Stop further processing if decompression bomb detected Fixes #11280 - - - - - dfa950f3 by Philipp Hörist at 2022-11-11T19:07:12+01:00 perf: Control: Request history more efficiently - Limit how many events are requested - Merge events and messages and add them afterwards - - - - - 40770fa7 by wurstsalat at 2022-11-13T14:17:10+01:00 cq: Update pyright config - - - - - c549fff0 by wurstsalat at 2022-11-15T12:00:59+01:00 imprv: ChatList: Scroll to top when switching workspace - - - - - 096e6d69 by Daniel Brötzmann at 2022-11-15T12:15:17+00:00 chore: DOAP: Add XEP-0402 - - - - - 69553e56 by wurstsalat at 2022-11-16T12:32:53+01:00 fix: ConversationView: Fix scrollbar not being the right-most widget This makes it possible to easily 'find' the scrollbar while having Gajim in fullscreen mode. - - - - - 2cf08d52 by wurstsalat at 2022-11-16T12:44:11+01:00 cfix: SearchView: Add separate class for search view rows - - - - - 7b3971b6 by wurstsalat at 2022-11-16T16:50:52+01:00 fix: Preview: Respect MUC context for PMs Fixes #11289 - - - - - 7ccf4806 by wurstsalat at 2022-11-17T17:38:46+01:00 fix: MessageActionsBox: Reintroduce gui_extension_point This is necessary when activating plugins after launch - - - - - d7121d8e by wurstsalat at 2022-11-18T14:07:32+01:00 fix: GroupchatRoster: Set visibility when hiding Hides the roster completely, so that the chat scrollbar is the right-most widget. Caveat: Un-reveal animation is gone - - - - - 23f90923 by wurstsalat at 2022-11-24T16:57:55+01:00 other: Remove obsolete htmltextview test - - - - - a3d7d6a3 by mjk at 2022-11-24T19:43:00+00:00 imprv: Prettify display of geographical locations - - - - - 42adccad by wurstsalat at 2022-11-24T20:54:40+01:00 refactor: MoreMenuButton: Use Gio.Menu Fixes #11262 - - - - - 01fd1b72 by wurstsalat at 2022-11-24T22:08:22+01:00 fix: Chatstates: Switch to Chatstate.ACTIVE after timeout - - - - - a6037e25 by wurstsalat at 2022-11-24T22:23:04+00:00 change: Add FileTransferSelector as a central page for sending files Fixes #9511 - - - - - 53d01bd6 by wurstsalat at 2022-11-24T23:33:00+01:00 refactor: Remove obsolete FileTransferSend dialog - - - - - 45033e89 by wurstsalat at 2022-11-25T15:14:42+01:00 refactor: Preview: Use Gio.Menu and Actions - - - - - 66d9ad4d by wurstsalat at 2022-11-25T15:25:54+01:00 cfix: Preferences: Use correct preview actions - - - - - 26f68c7f by wurstsalat at 2022-11-25T15:26:17+01:00 cfix: Menus: Fix linting error - - - - - b02f54d3 by wurstsalat at 2022-11-25T15:26:40+01:00 cq: File Choosers: Fix typo - - - - - 027b2d47 by wurstsalat at 2022-11-25T15:27:57+01:00 cfix: FileTransferSelector: Improve file choosing - - - - - 88daed91 by wurstsalat at 2022-11-25T16:24:19+01:00 cq: Contacts: Add more log output - - - - - b8c09a65 by wurstsalat at 2022-11-25T17:38:12+01:00 fix: SearchView: Set chat type correctly for ResultRows Fixes #11087 - - - - - 8e0f472a by wurstsalat at 2022-11-25T18:30:44+01:00 fix: ChatFunctionPage: Don't close control on cancelling join error Fixes #11116 - - - - - 44eab3c1 by wurstsalat at 2022-11-25T19:00:31+01:00 refactor: AvatarStorage: Access some methods directly - - - - - be7f2621 by wurstsalat at 2022-11-25T21:03:37+01:00 cq: Settings: Improve type annotations - - - - - 3c312d13 by wurstsalat at 2022-11-26T12:09:58+00:00 change: Jingle: Remove XTLS support XTLS has never been standardized, see https://datatracker.ietf.org/doc/html/draft-meyer-xmpp-e2e-encryption Gajim used this for file transfers, but there probably was no other client supporting this now obsolete feature. Today, using XEP-0396: Jingle Encrypted Transports - OMEMO would be the preferred solution. Part of #11160 - - - - - 8aafb212 by wurstsalat at 2022-11-27T14:45:22+01:00 fix: SSLErrorDialog: Fix test, remove OpenSSL usage - - - - - df1b8a56 by wurstsalat at 2022-11-27T14:57:16+01:00 chore: Update pyright config - - - - - 1c327c75 by wurstsalat at 2022-11-27T15:02:17+01:00 cfix: Menus: Add ellipsis to Save as… preview menu item - - - - - bd8b229b by wurstsalat at 2022-11-27T16:45:56+01:00 fix: GUI tests: Adapt GUI tests to Gajim changes - - - - - 8da84be4 by wurstsalat at 2022-11-27T19:35:20+00:00 refactor: CertificateBox: Use cryptography module for certificate details - - - - - b2957213 by wurstsalat at 2022-11-27T19:35:20+00:00 change: Dependencies: Remove pyOpenSSL, add python-cryptography - - - - - bf75d672 by Philipp Hörist at 2022-11-27T23:43:04+01:00 ci: Add ruff configuration - - - - - fde324b2 by Philipp Hörist at 2022-11-27T23:50:02+01:00 ci: Debian: Add cryptography to build dependencies - - - - - d0032cd9 by wurstsalat at 2022-11-27T23:36:19+00:00 imprv: Settings: Unify timestamp settings Part of #10948 - - - - - 020230b5 by wurstsalat at 2022-11-28T10:29:41+01:00 imprv: Message selection: Use date_time_format instead of time_format - - - - - 4b6f68da by wurstsalat at 2022-11-28T18:10:11+01:00 chore: Update builder.pyi - - - - - d4c21af6 by wurstsalat at 2022-11-28T18:48:06+01:00 cq: AccountWizard: Improve type annotations - - - - - 806d4757 by wurstsalat at 2022-11-29T13:18:01+01:00 fix: MessageInputTextView: Reintroduce gui_extension_point This is necessary when activating plugins after launch - - - - - 2f8986b3 by wurstsalat at 2022-11-30T00:22:34+01:00 cq: Remove unnecessary pyright ignore comments - - - - - b84ef377 by mjk at 2022-11-30T21:05:07+00:00 imprv: Styling: Introduce URI scheme whitelisting Fixes #11266 Co-authored-by: Philipp Hörist <philipp(a)hoerist.com> - - - - - ec0008b7 by mjk at 2022-11-30T21:17:13+00:00 fix: Styling: Linkify URIs only if at the start of a word - - - - - 88989297 by mjk at 2022-11-30T21:19:03+00:00 refactor: Tests: Improve failure reports in test_styling - - - - - eebbe3e8 by wurstsalat at 2022-11-30T21:34:12+00:00 refactor: Remove old emoji code Fixes #10932 - - - - - d0fb8c5b by mjk at 2022-11-30T21:58:07+00:00 fix: Preview: Handle multiple simultaneous certificate verification errors - - - - - 58c59ec5 by Philipp Hörist at 2022-11-30T23:38:26+01:00 refactor: Move GstPbutils import into method app.detect_dependencies() needs to call gi.require() first, so import this inside the method - - - - - d3953b58 by Philipp Hörist at 2022-11-30T23:59:57+01:00 imprv: Features: Add entry for Audio Preview - - - - - 4ad531df by Philipp Hörist at 2022-12-01T00:14:02+01:00 refactor: Remove debian related package names - - - - - 8011ff31 by wurstsalat at 2022-12-01T21:31:30+01:00 imprv: Message selection: Improve styling - - - - - ace22758 by wurstsalat at 2022-12-01T22:46:29+01:00 imprv: Message selection: Imrpove wording for deselecting messages - - - - - 977a6f77 by wurstsalat at 2022-12-03T00:31:38+01:00 imprv: MUC: Add method for aborting join - - - - - a77decef by Philipp Hörist at 2022-12-03T09:42:30+01:00 cfix: AccountWizard: Don’t translate URL labels - - - - - 5c3c60fc by Weblate at 2022-12-03T09:55:58+01:00 chore: Update translations - - - - - d724c016 by Philipp Hörist at 2022-12-03T10:01:10+01:00 chore: Cleanup stale translations - - - - - 12b0a427 by wurstsalat at 2022-12-03T09:05:20+00:00 imprv: DataFormWidget: Set min width on right box Fixes #11222 - - - - - 4d501a60 by Philipp Hörist at 2022-12-03T10:20:01+01:00 release: 1.5.4 - - - - - 52816f7f by Philipp Hörist at 2022-12-03T21:10:11+01:00 ci: Automatically create Gitlab Release - - - - - 3becd516 by Philipp Hörist at 2022-12-03T21:46:07+01:00 cq: Remove newline - - - - - 0e53991c by Philipp Hörist at 2022-12-03T22:16:46+01:00 cq: Fix typing for cairo.Context - - - - - 2bbcd18b by Philipp Hörist at 2022-12-03T22:26:27+01:00 cq: Ignore flake8 unused-import errors - - - - - 3d5363d0 by Philipp Hörist at 2022-12-04T00:41:11+01:00 refactor: Scripts: Fix various issues - Use logging module everywhere - Fix boolean traps - replace exit() with sys.exit() - - - - - 576b1aa1 by Philipp Hörist at 2022-12-04T00:57:07+01:00 cq: Use builtin types for annotations - - - - - 89507a76 by Philipp Hörist at 2022-12-04T11:42:45+01:00 cfix: Use __future__ import for annotations Fixes #11314 - - - - - 38fd03ce by André Apitzsch at 2022-12-04T11:58:58+01:00 chore: Flatpak: Update dependencies - - - - - 48a1b1ff by Philipp Hörist at 2022-12-04T13:22:06+01:00 cq: Tests: Fix ruff linter errors - - - - - b69d7b2e by Philipp Hörist at 2022-12-04T19:33:59+01:00 cq: Fix typo in annotation - - - - - 156b23cf by Philipp Hörist at 2022-12-04T19:38:45+01:00 refactor: Raise AssertionError explicitly assert can be optimized out by python, as this is not a assert for helping the type checker it should be raised explicitly. - - - - - 9294172c by Philipp Hörist at 2022-12-04T20:19:38+01:00 refactor: Simplify sorted list insertion Handler lists are very small and are not changed very often - - - - - 5c874f20 by Philipp Hörist at 2022-12-04T20:46:57+01:00 cq: Settings: Mark loop var as not used - - - - - b48e6922 by Philipp Hörist at 2022-12-04T20:56:07+01:00 refactor: Replace lru_cache(maxsize=None) with shorthand - - - - - 16ce9f7e by Philipp Hörist at 2022-12-04T21:39:40+01:00 refactor: Use set literals - - - - - 5265a80c by wurstsalat at 2022-12-04T22:56:12+01:00 refactor: Translations: Use p_() method for translation context - - - - - fd47095e by Philipp Hörist at 2022-12-04T23:54:56+01:00 refactor: Remove unnecessary map() usage - - - - - 6c666114 by Philipp Hörist at 2022-12-04T23:54:56+01:00 refactor: Remove unnecessary method arguments - - - - - 532e2249 by Philipp Hörist at 2022-12-04T23:54:56+01:00 refactor: Use "not in" for inclusion check - - - - - f256b6ec by Philipp Hörist at 2022-12-05T00:00:21+01:00 refactor: Remove unnecessary variable assignment before return - - - - - 90cd87a2 by Philipp Hörist at 2022-12-05T00:00:21+01:00 refactor: Simplify import - - - - - c4068f05 by Philipp Hörist at 2022-12-05T00:00:21+01:00 cq: Reorder comparison - - - - - 012daf50 by Philipp Hörist at 2022-12-05T00:00:21+01:00 cq: Add noqa for false positive ruff checks - - - - - 53f96919 by Philipp Hörist at 2022-12-05T00:00:21+01:00 refactor: PluginManager: Simplify setting module attribute - - - - - 90a53769 by Philipp Hörist at 2022-12-05T00:00:21+01:00 refactor: Rename AppIndicator import - - - - - d14e1ee9 by Philipp Hörist at 2022-12-05T00:00:21+01:00 refactor: Follow CapWords convention for classes - - - - - b73700ee by Philipp Hörist at 2022-12-05T00:00:21+01:00 refactor: Assistant: Use dict literal - - - - - 93890f8d by Philipp Hörist at 2022-12-05T00:00:21+01:00 refactor: Remove unnecessary method cache This method is not expensive and only called a few times - - - - - 6440fd60 by Philipp Hörist at 2022-12-05T00:00:21+01:00 ci: Update ruff configuration - - - - - 9e9101a7 by Philipp Hörist at 2022-12-05T00:00:21+01:00 ci: Repace pylint/flake8 with ruff - - - - - f681bcee by mjk at 2022-12-07T17:03:40+03:00 feat: Resurrect URI-specific context menus - - - - - dfac89f7 by mjk at 2022-12-07T17:03:40+03:00 refactor: Make URI context menus more data-driven ...and cover missing URITypes, adding "coverage" tests. - - - - - 340e33d0 by mjk at 2022-12-08T11:00:12+00:00 refactor: Simplify the type of URI.data No casts/type assertions needed now. - - - - - e65badc7 by mjk at 2022-12-08T11:00:56+00:00 imprv: Use the unified Start/Join Chat flow for ?join links * Immediately switch to the chat if already open. * Don't "crash" if current account is offline. - - - - - 753e8345 by mjk at 2022-12-08T11:00:56+00:00 refactor: Make xmpp query type handling in open_uri more change-proof - - - - - def536da by mjk at 2022-12-08T11:00:56+00:00 imprv: Restore ability to manually disambiguate JID-like addresses ...by storing them in `href` attributes as internal-use `about:ambiguous-address?a@b.c` URIs. Storing raw `a(a)b.c` in `href` wouldn't make a lot of semantic sense, as that's a relative-path URI with the meaning of "the thing named 'a(a)b.c' in the same directory as the current document". Plus, it would either entail handling these addresses outside `parse_uri()`, or changing its purpose of parsing only absolute URIs. - - - - - 66e748fd by mjk at 2022-12-08T11:00:56+00:00 imprv: Add dedicated context menu for non-specific URI types - - - - - 278ea276 by Philipp Hörist at 2022-12-08T13:11:46+01:00 refactor: Harmonize groupchat-join/open-chat action We want the behavior of groupchat-join, but not only for group chats. This consolidates the code into the open-chat action. - - - - - ca5f6104 by mesonium at 2022-12-08T12:14:05+00:00 feat: Preview: Add audio preview controls and visualization * Remove the delay when starting a playback * Don't scrub during seek when dragging the slider * Don't open audio stream connections before playing * Determine the duration early to prevent missing duration info + Show total duration + Add option to display remaining play time + Add possibility to seek by clicking into the seekbar + Add possibility to seek by scrolling with the mouse wheel + Add fast forward and rewind buttons + Add buttons to change the playback speed + Add automatic restoration of the audio player settings in a session + Add automatic stop of other streams when starting to play + Add a visualization of the RMS peaks - - - - - 84ff274e by mjk at 2022-12-08T22:38:34+00:00 feat: Allow sending files by copy-pasting them from file managers - - - - - 2a595826 by mjk at 2022-12-08T22:55:46+00:00 fix: Preview: Don't treat multi-line message body as previewable URL - - - - - 2b5ab697 by Philipp Hörist at 2022-12-09T00:13:08+01:00 fix: Remember last folder correctly after sending file - - - - - 38ed7621 by Philipp Hörist at 2022-12-09T00:26:52+01:00 cfix: AudioPreview: Use symbolic icons - - - - - 6b9cb548 by wurstsalat at 2022-12-09T22:10:57+01:00 cq: Move remove_invalid_xml_chars method and add test - - - - - 83f23865 by wurstsalat at 2022-12-09T22:25:05+01:00 cq: Tests: Code formatting, simplifications - - - - - e726baf5 by wurstsalat at 2022-12-09T23:06:57+01:00 cq: Assistant: Add overloads for add_default_page - - - - - d409b47b by wurstsalat at 2022-12-09T23:34:18+01:00 cq: Assistant: Add overloads for get_page - - - - - 60cf91b8 by wurstsalat at 2022-12-09T23:36:17+01:00 cq: GUI tests: Code formatting and simplifications - - - - - 9337eeaa by wurstsalat at 2022-12-09T23:51:25+01:00 cq: Generate ui types without linting errors - - - - - a6550805 by wurstsalat at 2022-12-09T23:59:07+01:00 cq: Types: Remove obsolete types - - - - - 73db9f99 by wurstsalat at 2022-12-10T11:24:07+01:00 cq: Plugins: Improve type annotations - - - - - 7ee6b8b9 by wurstsalat at 2022-12-10T11:24:33+01:00 cq: Preferences: Ignore type error - - - - - a9894439 by wurstsalat at 2022-12-10T11:25:05+01:00 cq: Styling: Type annotations - - - - - ba5ef575 by wurstsalat at 2022-12-10T13:12:05+01:00 cq: SynchronizeAccounts: Use better ListStore set method - - - - - 8e7dbb69 by wurstsalat at 2022-12-10T13:12:19+01:00 cq: RosterItemExchange: Use better ListStore set method - - - - - a82b744d by wurstsalat at 2022-12-10T13:15:55+01:00 cq: FileChoosers: Improve type annotations - - - - - 5131ebf8 by wurstsalat at 2022-12-10T13:15:55+01:00 cq: Control: Fix indentation warning - - - - - 7272cc30 by wurstsalat at 2022-12-10T13:15:55+01:00 cq: ComponentSearch: Fix type annotations - - - - - 93e4ed5f by wurstsalat at 2022-12-10T13:15:55+01:00 cq: Assistant: Fix type annotations - - - - - 896be5ed by wurstsalat at 2022-12-10T13:15:55+01:00 cq: Update pyrightconfig - - - - - f187e303 by wurstsalat at 2022-12-10T17:41:38+01:00 cq: Add stubs for css_parser - - - - - 1945cf94 by wurstsalat at 2022-12-10T17:50:41+01:00 cq: Fix ruff errors - - - - - 40243c8e by wurstsalat at 2022-12-11T13:37:25+01:00 cq: Add /mac folder to pyrightconfig - - - - - 17076ced by Philipp Hörist at 2022-12-11T14:13:55+01:00 new: Settings: Allow to create Settings in memory - - - - - 1d2fa904 by Philipp Hörist at 2022-12-11T14:13:55+01:00 new: Settings: Add shutdown() method - - - - - c81ea41b by Grzegorz Szymaszek at 2022-12-11T21:37:16+01:00 cfix: Add missing and remove unneeded execute bits Remove the execute bit from files that most likely should not be executable in a Unix-like environment, like Markdown or Yaml. Set the execute bit on files that most likely should be executable: those having "#!/usr/bin/env ..." or similar solutions. - - - - - 7b64058e by wurstsalat at 2022-12-12T11:05:45+01:00 fix: Fonts: Fix emoji rendering on MacOS - - - - - 37c3cb3a by wurstsalat at 2022-12-12T18:24:13+01:00 imprv: AppPage: Show date for last update check - - - - - eeb456b4 by wurstsalat at 2022-12-12T19:31:06+01:00 imprv: Timestamps: Use date/time format preference in more places Fixes #10948 - - - - - 3742e9da by Philipp Hörist at 2022-12-12T20:25:46+01:00 other: Discover translations correctly - - - - - 1d239b90 by André Apitzsch at 2022-12-12T20:54:05+01:00 cfix: Re-add comments for translators to po files - - - - - ff048ff7 by André Apitzsch at 2022-12-12T20:54:05+01:00 other: Filetransfer: Add hint for translators - - - - - 689e324e by Philipp Hörist at 2022-12-12T21:35:44+01:00 cfix: VCard: Fix typo - - - - - 221097db by Philipp Hörist at 2022-12-13T19:38:09+01:00 fix: Menus: Don’t use GLib variant text format parsing All strings would need to be escaped, not using the text format is less error prone. Fixes #11331 - - - - - 0bdce8ac by Philipp Hörist at 2022-12-13T19:40:15+01:00 other: Scripts: Execute pyright last in pre-push-tests It takes the most time, so execute it last - - - - - e070a951 by Philipp Hörist at 2022-12-13T19:43:42+01:00 cfix: Menus: Remove obsolete string escaping - - - - - 0f3204b4 by Philipp Hörist at 2022-12-13T19:46:56+01:00 cfix: Menus: Don’t quote string value - - - - - dab9bf29 by Philipp Hörist at 2022-12-13T20:00:57+01:00 refactor: Menus: Don’t pass params with action name For consistency sake - - - - - 53bf4e2f by Philipp Hörist at 2022-12-13T20:17:29+01:00 refactor: Menus: Don’t pass action with Gio.MenuItem.new() The action gets feeded to parse_detail_name() which breaks when the action name has "(" in it. - - - - - d1f57886 by Philipp Hörist at 2022-12-13T20:29:56+01:00 refactor: Menus: Port component search menu to GajimMenu - - - - - 75104e75 by Philipp Hörist at 2022-12-13T20:47:11+01:00 refactor: Import MenuList type hints - - - - - fc4a56e2 by Philipp Hörist at 2022-12-13T22:38:08+01:00 cq: Typecheck more modules - - - - - e52f7b78 by wurstsalat at 2022-12-14T19:34:29+01:00 fix: AvatarSelector: Set default crop scale to 1.0 Fixes #11331 - - - - - 16cd4ebd by wurstsalat at 2022-12-14T19:44:56+01:00 imprv: BaseAvatarChooserDialog: Allow all image types Fixes #11328 - - - - - 26752631 by wurstsalat at 2022-12-14T20:13:22+01:00 fix: Notifications: Use correct nickname for /me messages Fixes #11334 - - - - - 2ba73b51 by mjk at 2022-12-15T00:07:16+03:00 cfix: File choosers: Fix type mismatches in accept callback Fixes the regression introduced in 84ff274e345da79e075589d48026ec767729eb8e - - - - - 834d4a31 by mjk at 2022-12-15T00:07:16+03:00 refactor: File choosers: Type-related changes * Simplify accept callback signature * Allow more type checker visibility - - - - - c08a2946 by Philipp Hörist at 2022-12-14T23:32:23+01:00 refactor: Move Singleton into util.classes - - - - - 5651884d by Philipp Hörist at 2022-12-14T23:36:31+01:00 refactor: Move text_helpers into util module - - - - - 6054a21b by Philipp Hörist at 2022-12-14T23:55:19+01:00 ci: Simplify pyright config - - - - - e741c8e3 by Philipp Hörist at 2022-12-15T00:02:45+01:00 cq: Events: Fix type annotation - - - - - f2ef6140 by Philipp Hörist at 2022-12-15T00:03:30+01:00 ci: Update pyright config - - - - - 782cafb2 by mjk at 2022-12-14T23:32:40+00:00 imprv: Highlight the file when opening containing folder - - - - - 2601e782 by Philipp Hörist at 2022-12-17T14:03:37+01:00 refactor: Simplify dict iteration - - - - - e00c67e5 by Philipp Hörist at 2022-12-17T14:03:37+01:00 ci: Update ruff config - - - - - 7416caa3 by Philipp Hörist at 2022-12-17T14:03:37+01:00 chore: Update .gitignore - - - - - 38d8c685 by Philipp Hörist at 2022-12-17T14:03:37+01:00 fix: Add missing PyGObject dependency to setup.cfg - - - - - 91373ccc by Philipp Hörist at 2022-12-17T14:03:37+01:00 new: Add optional dependencies to setup.py - - - - - 714203b7 by Philipp Hörist at 2022-12-17T14:03:37+01:00 new: Add script for creating a development environment - Update README.md - - - - - 6918456e by Philipp Hörist at 2022-12-17T22:11:46+01:00 new: Add PyGObject-stubs as optional dependency - - - - - 84bbda53 by Philipp Hörist at 2022-12-17T23:35:59+01:00 cfix: Define codespell dependency correctly - - - - - c14daba2 by Philipp Hörist at 2022-12-17T23:41:59+01:00 new: Add more optional dependencies for development - - - - - 57f18dc6 by Philipp Hörist at 2022-12-19T01:08:47+01:00 ci: Adapt to pygobject-stub changes Old libraries need to be specified at install time - - - - - 67ab4b10 by Philipp Hörist at 2022-12-19T16:25:33+01:00 cq: Use pyright specific ignore code - - - - - 91889803 by Philipp Hörist at 2022-12-19T19:17:55+01:00 ci: Update ruff config - - - - - 7a8a7d55 by wurstsalat at 2022-12-20T09:29:25+01:00 fix: Commands: Attempt to parse only if message can have a command Fixes #11341 - - - - - 9fa214eb by mesonium at 2022-12-20T09:37:40+00:00 fix: Audio Preview: Don't let seekbar handle jump to end on EOS when user is seeking - - - - - 5ade5537 by lovetox at 2022-12-20T19:11:33+01:00 Omemo Start - - - - - 2ed61fa7 by wurstsalat at 2022-12-20T19:11:33+01:00 cq: OMEMO: Add type annotations - - - - - f7723a86 by wurstsalat at 2022-12-20T19:11:33+01:00 cq: OMEMO: Fix linting errors - - - - - f2f8f827 by wurstsalat at 2022-12-20T19:11:33+01:00 cq: Add type stubs for python-qrcode - - - - - 8c8ce4d1 by wurstsalat at 2022-12-20T19:11:33+01:00 chore: Adapt dependencies for OMEMO - - - - - 82f2240a by wurstsalat at 2022-12-20T19:11:33+01:00 chore: OMEMO: Remove unused methods 'activate' has a replacement in the 'signled-in' event - - - - - 5632457e by wurstsalat at 2022-12-20T19:11:33+01:00 new: Add OMEMO_TEMP_DL to caps - - - - - 7449e2a7 by wurstsalat at 2022-12-20T19:12:45+01:00 new: Add OMEMOTrustManager - - - - - e5d9edb3 by wurstsalat at 2022-12-20T19:12:47+01:00 new: OMEMO: Add file encryption - - - - - 6804a352 by Philipp Hörist at 2022-12-20T21:06:57+01:00 chore: Update dependencies - - - - - 45ec072a by Philipp Hörist at 2022-12-20T21:06:58+01:00 new: Block omemo plugin - - - - - 1f43630d by wurstsalat at 2022-12-20T21:06:58+01:00 chore: OMEMO: Remove obsolete qrcode version check - - - - - 4f0ff102 by Philipp Hörist at 2022-12-20T21:06:58+01:00 refactor: Move omemo storage to storage module - - - - - 4f8ff13e by Philipp Hörist at 2022-12-20T21:06:58+01:00 refactor: Move omemo code into common - - - - - aef99cd7 by Philipp Hörist at 2022-12-20T21:06:58+01:00 cq: Fix linter errors - - - - - 8e6d677c by wurstsalat at 2022-12-20T21:06:58+01:00 new: OMEMO: Add handling of MucAdded signal - - - - - 28e963b9 by wurstsalat at 2022-12-20T21:08:06+01:00 new: OMEMO: Add EncryptionAnnouncementRow - - - - - cce73ae5 by Philipp Hörist at 2022-12-20T21:08:07+01:00 fix: check preconditions - - - - - afcc5e25 by Philipp Hörist at 2022-12-20T21:08:55+01:00 refactor: Rename methods - - - - - c5a20b3c by Philipp Hörist at 2022-12-20T21:10:03+01:00 cq: Remove blank line - - - - - 749e1ded by Philipp Hörist at 2022-12-20T21:10:04+01:00 refactor: Remove unused code - - - - - 693e00d9 by Philipp Hörist at 2022-12-20T21:10:04+01:00 refactor: Use send_stanza method - - - - - 73f2cd2a by Philipp Hörist at 2022-12-20T21:10:04+01:00 refactor: Remove devices module - - - - - da35fb00 by Philipp Hörist at 2022-12-20T21:10:04+01:00 cq: Remove unused imports - - - - - 7307f2a6 by Philipp Hörist at 2022-12-20T21:10:04+01:00 refactor: Switch to new library - - - - - b9aa0f01 by Philipp Hörist at 2022-12-20T21:10:04+01:00 cq: Fix storage annotations - - - - - 22b75d5a by Philipp Hörist at 2022-12-20T21:10:04+01:00 fix: Fix import - - - - - 30 changed files: - .chglog/CHANGELOG.tpl.md - .chglog/config.yml - .ci/appveyor_build.py - .ci/deploy.py - .ci/link-gtk.py - + .ci/make_release.py - − .ci/pylint.sh - .gitignore - .gitlab-ci.yml - .gitlab/issue_templates/Release.md - ChangeLog - README.md - data/gajim.doap - data/org.gajim.Gajim.appdata.xml.in - debian/control - flatpak/org.gajim.Gajim.Devel.yaml - flatpak/org.gajim.Gajim.yaml - flatpak/update_flatpak_repo.sh - gajim/__init__.py - gajim/common/app.py - gajim/common/application.py - gajim/common/client.py - gajim/common/configpaths.py - gajim/common/const.py - + gajim/common/dbus/file_manager.py - gajim/common/dbus/remote_control.py - gajim/common/events.py - gajim/common/ged.py - gajim/common/helpers.py - gajim/common/i18n.py The diff was not included because it is too large. View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/47e16420b173c2451d0f2df06f16e14… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/47e16420b173c2451d0f2df06f16e14… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix: Audio Preview: Follow-up to 9fa214eb: Fix visuals on EOS while seeking
by Daniel Brötzmann (＠wurstsalat) 20 Dec '22

20 Dec '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 3a383cb9 by mesonium at 2022-12-20T14:47:42+01:00 fix: Audio Preview: Follow-up to 9fa214eb: Fix visuals on EOS while seeking - - - - - 1 changed file: - gajim/gtk/preview_audio.py Changes: ===================================== gajim/gtk/preview_audio.py ===================================== @@ -444,7 +444,10 @@ def _on_bus_message(self, _bus: Gst.Bus, message: Gst.Message) -> None: self._set_pause(True) if not self._pause_seek: self._ui.seek_bar.set_value(self._state.duration) - self._audio_visualizer.draw_graph(1.0) + self._audio_visualizer.draw_graph(1.0) + else: + self._audio_visualizer.draw_graph( + self._state.position / self._state.duration) elif message.type == Gst.MessageType.STATE_CHANGED: is_paused = self._get_paused() View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/3a383cb9b7b67bf0cb200966fe7bfba7… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/3a383cb9b7b67bf0cb200966fe7bfba7… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix: Audio Preview: Don't let seekbar handle jump to end on EOS when user is seeking
by Daniel Brötzmann (＠wurstsalat) 20 Dec '22

20 Dec '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 9fa214eb by mesonium at 2022-12-20T09:37:40+00:00 fix: Audio Preview: Don't let seekbar handle jump to end on EOS when user is seeking - - - - - 1 changed file: - gajim/gtk/preview_audio.py Changes: ===================================== gajim/gtk/preview_audio.py ===================================== @@ -442,7 +442,8 @@ def _on_bus_message(self, _bus: Gst.Bus, message: Gst.Message) -> None: if message.type == Gst.MessageType.EOS: self._state.is_eos = True self._set_pause(True) - self._ui.seek_bar.set_value(self._state.duration) + if not self._pause_seek: + self._ui.seek_bar.set_value(self._state.duration) self._audio_visualizer.draw_graph(1.0) elif message.type == Gst.MessageType.STATE_CHANGED: View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/9fa214eb9fa5e21c95d12f30a072340a… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/9fa214eb9fa5e21c95d12f30a072340a… You're receiving this email because of your account on dev.gajim.org.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits