Daniel Brötzmann pushed to branch master at gajim / gajim
Commits: 750cc4b7 by wurstsalat at 2022-09-12T23:05:16+02:00 imprv: Preview: Show left click action tooltip on icon
Fixes #11138
- - - - -
2 changed files:
- gajim/gtk/preferences.py - gajim/gtk/preview.py
Changes:
===================================== gajim/gtk/preferences.py ===================================== @@ -48,6 +48,7 @@ from .settings import SettingsDialog from .sidebar_switcher import SideBarSwitcher from .video_preview import VideoPreview +from .preview import PREVIEW_CLICK_ACTIONS from .util import open_window from .util import get_app_window from .builder import get_builder @@ -413,14 +414,6 @@ def __init__(self, *args: Any) -> None: 10485760: '10 MiB', }
- actions = { - 'open': _('Open'), - 'save_as': _('Save As…'), - 'open_folder': _('Open Folder'), - 'copy_link_location': _('Copy Link Location'), - 'open_link_in_browser': _('Open Link in Browser'), - } - settings = [ Setting(SettingKind.SWITCH, _('File Preview'), @@ -465,7 +458,7 @@ def __init__(self, *args: Any) -> None: 'preview_leftclick_action', desc=_('Action when left-clicking a preview'), bind='enable_file_preview', - props={'entries': actions}), + props={'entries': PREVIEW_CLICK_ACTIONS}),
Setting(SettingKind.SWITCH, _('HTTPS Verification'),
===================================== gajim/gtk/preview.py ===================================== @@ -47,6 +47,14 @@
log = logging.getLogger('gajim.gui.preview')
+PREVIEW_CLICK_ACTIONS = { + 'open': _('Open'), + 'save_as': _('Save As…'), + 'open_folder': _('Open Folder'), + 'copy_link_location': _('Copy Link Location'), + 'open_link_in_browser': _('Open Link in Browser'), +} +
class PreviewWidget(Gtk.Box): def __init__(self, account: str) -> None: @@ -66,6 +74,12 @@ def __init__(self, account: str) -> None: self._ui.connect_signals(self) self.add(self._ui.preview_box)
+ leftclick_action = app.settings.get('preview_leftclick_action') + self._ui.icon_button.set_tooltip_text( + PREVIEW_CLICK_ACTIONS[leftclick_action]) + app.settings.connect_signal( + 'preview_leftclick_action', self._update_icon_button_tooltip) + self.connect('destroy', self._on_destroy)
self.show_all() @@ -73,6 +87,10 @@ def __init__(self, account: str) -> None: def _on_destroy(self, _widget: Gtk.Widget) -> None: self._destroyed = True
+ def _update_icon_button_tooltip(self, setting: str, *args: Any) -> None: + self._ui.icon_button.set_tooltip_text( + PREVIEW_CLICK_ACTIONS[setting]) + def get_text(self) -> str: if self._preview is None: return ''
View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/750cc4b7c0f072e835f915c2131d76af2...