Philipp Hörist pushed to branch master at gajim / gajim
Commits: 53714f8e by lovetox at 2022-08-13T12:31:48+02:00 fix: Fix switch-next-unread-tab action work
- - - - - c57682ce by lovetox at 2022-08-13T12:31:48+02:00 imprv: Chatstate: Don’t make too many assumptions
- active does not necessarily mean the user looks at the chat
- gone: In todays chat clients there is no difference between closing a chat and not looking at it or switching to another chat. In both cases the user gets notified if new messages arrive, its not clear how this informtation can be important for our users.
Further for communicating idle states there are more useful mechanisms like idle presence and presence show states.
- - - - -
2 changed files:
- gajim/common/helpers.py - gajim/gtk/main.py
Changes:
===================================== gajim/common/helpers.py ===================================== @@ -309,17 +309,12 @@ def get_uf_chatstate(chatstate: str) -> str: ''' Remove chatstate jargon and returns user friendly messages ''' - if chatstate == 'active': - return _('is paying attention to the conversation') - if chatstate == 'inactive': + if chatstate in ('inactive', 'gone'): return _('is doing something else') if chatstate == 'composing': return _('is composing a message…') if chatstate == 'paused': - # paused means he or she was composing but has stopped for a while return _('paused composing a message') - if chatstate == 'gone': - return _('has closed the chat window or tab') return ''
===================================== gajim/gtk/main.py ===================================== @@ -358,7 +358,7 @@ def _add_actions2(self) -> None: 'close-tab', 'switch-next-tab', 'switch-prev-tab', - 'switch-next-unread-tab' + 'switch-next-unread-tab', 'switch-prev-unread-tab', 'switch-tab-1', 'switch-tab-2',
View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/b8dfaf8e5c11d1e4aa1dafa1939f10ae...