Yann Leboulanger pushed to branch master at gajim / gajim
Commits:
d070d141 by Yann Leboulanger at 2017-08-21T21:59:47+02:00
fix scrolling to iter in groupchat when we receive a pm. Fixes #8635
- - - - -
1 changed file:
- gajim/groupchat_control.py
Changes:
=====================================
gajim/groupchat_control.py
=====================================
--- a/gajim/groupchat_control.py
+++ b/gajim/groupchat_control.py
@@ -1142,7 +1142,7 @@ class GroupchatControl(ChatControlBase):
else:
self._start_private_message(nick)
# Scroll to line
- path_ = path
+ path_ = path.copy()
path_.up()
self.list_treeview.expand_row(path_, False)
self.list_treeview.scroll_to_cell(path)
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/d070d141bb3cf4caf11cc94ba9233b134d…
---
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/d070d141bb3cf4caf11cc94ba9233b134d…
You're receiving this email because of your account on dev.gajim.org.
Yann Leboulanger pushed to branch master at gajim / gajim
Commits:
07ba85b4 by Yann Leboulanger at 2017-08-20T23:07:58+02:00
Ability to be notified on all message. Option is now perroom. Fixes #8646
- - - - -
6 changed files:
- data/gui/gc_control_popup_menu.ui
- gajim/chat_control_base.py
- gajim/common/config.py
- gajim/groupchat_control.py
- gajim/message_window.py
- gajim/notify.py
Changes:
=====================================
data/gui/gc_control_popup_menu.ui
=====================================
--- a/data/gui/gc_control_popup_menu.ui
+++ b/data/gui/gc_control_popup_menu.ui
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
-<!-- Generated with glade 3.18.3 -->
+<!-- Generated with glade 3.20.0 -->
<interface>
<requires lib="gtk+" version="3.12"/>
<object class="GtkMenu" id="gc_control_popup_menu">
@@ -66,6 +66,13 @@
</object>
</child>
<child>
+ <object class="GtkCheckMenuItem" id="notify_menuitem">
+ <property name="visible">True</property>
+ <property name="can_focus">False</property>
+ <property name="label" translatable="yes">Notify on all messages</property>
+ </object>
+ </child>
+ <child>
<object class="GtkSeparatorMenuItem" id="request_voice_separator">
<property name="can_focus">False</property>
<property name="no_show_all">True</property>
=====================================
gajim/chat_control_base.py
=====================================
--- a/gajim/chat_control_base.py
+++ b/gajim/chat_control_base.py
@@ -957,6 +957,7 @@ class ChatControlBase(MessageControl, ChatCommandProcessor, CommandTools):
if kind == 'incoming':
if not self.type_id == message_control.TYPE_GC or \
app.config.get('notify_on_all_muc_messages') or \
+ app.config.get_per('rooms', jid, 'notify_on_all_messages') or \
'marked' in other_tags_for_text:
# it's a normal message, or a muc message with want to be
# notified about if quitting just after
@@ -1141,6 +1142,10 @@ class ChatControlBase(MessageControl, ChatCommandProcessor, CommandTools):
app.config.set_per('accounts', self.account, 'non_minimized_gc',
' '.join(non_minimized_gc))
+ def on_notify_menuitem_toggled(self, widget):
+ app.config.set_per('rooms', self.contact.jid, 'notify_on_all_messages',
+ widget.get_active())
+
def set_control_active(self, state):
if state:
self.set_emoticon_popover()
=====================================
gajim/common/config.py
=====================================
--- a/gajim/common/config.py
+++ b/gajim/common/config.py
@@ -492,6 +492,7 @@ class Config:
'speller_language': [ opt_str, '', _('Language for which we want to check misspelled words')],
'muc_restore_lines': [opt_int, -2, _('How many lines to request from server when entering a groupchat. -1 means no limit, -2 means global value')],
'muc_restore_timeout': [opt_int, -2, _('Minutes of backlog to request when entering a groupchat. -1 means no limit, -2 means global value')],
+ 'notify_on_all_messages': [opt_bool, False, _('State whether we want a notification for every message in this room')],
}, {}),
'plugins': ({
'active': [opt_bool, False, _('State whether plugins should be activated on startup (this is saved on Gajim exit). This option SHOULD NOT be used to (de)activate plug-ins. Use GUI instead.')],
=====================================
gajim/groupchat_control.py
=====================================
--- a/gajim/groupchat_control.py
+++ b/gajim/groupchat_control.py
@@ -905,6 +905,7 @@ class GroupchatControl(ChatControlBase):
history_menuitem = xml.get_object('history_menuitem')
disconnect_menuitem = xml.get_object('disconnect_menuitem')
minimize_menuitem = xml.get_object('minimize_menuitem')
+ notify_menuitem = xml.get_object('notify_menuitem')
request_voice_menuitem = xml.get_object('request_voice_menuitem')
bookmark_separator = xml.get_object('bookmark_separator')
separatormenuitem2 = xml.get_object('separatormenuitem2')
@@ -943,6 +944,8 @@ class GroupchatControl(ChatControlBase):
if self.contact.jid not in app.config.get_per('accounts', self.account,
'non_minimized_gc').split(' '):
minimize_menuitem.set_active(True)
+ notify_menuitem.set_active(app.config.get_per('rooms', self.contact.jid,
+ 'notify_on_all_messages'))
conn = app.connections[self.account]
if not conn.private_storage_supported and (not conn.pubsub_supported or \
not conn.pubsub_publish_options_supported):
@@ -1009,6 +1012,10 @@ class GroupchatControl(ChatControlBase):
self.on_minimize_menuitem_toggled)
self.handlers[id_] = minimize_menuitem
+ id_ = notify_menuitem.connect('toggled',
+ self.on_notify_menuitem_toggled)
+ self.handlers[id_] = notify_menuitem
+
menu.connect('selection-done', self.destroy_menu,
change_nick_menuitem, change_subject_menuitem,
bookmark_room_menuitem, history_menuitem)
@@ -1245,7 +1252,8 @@ class GroupchatControl(ChatControlBase):
def get_nb_unread(self):
type_events = ['printed_marked_gc_msg']
- if app.config.get('notify_on_all_muc_messages'):
+ if app.config.get('notify_on_all_muc_messages') or \
+ app.config.get_per('rooms', self.room_jid, 'notify_on_all_messages'):
type_events.append('printed_gc_msg')
nb = len(app.events.get_events(self.account, self.room_jid,
type_events))
=====================================
gajim/message_window.py
=====================================
--- a/gajim/message_window.py
+++ b/gajim/message_window.py
@@ -501,7 +501,8 @@ class MessageWindow(object):
for ctrl in self.controls():
if ctrl.type_id == message_control.TYPE_GC and not \
app.config.get('notify_on_all_muc_messages') and not \
- ctrl.attention_flag:
+ app.config.get_per('rooms', ctrl.room_jid,
+ 'notify_on_all_messages') and not ctrl.attention_flag:
# count only pm messages
unread += ctrl.get_nb_unread_pm()
continue
@@ -518,7 +519,9 @@ class MessageWindow(object):
if control.type_id == message_control.TYPE_GC:
name = control.room_jid.split('@')[0]
urgent = control.attention_flag or \
- app.config.get('notify_on_all_muc_messages')
+ app.config.get('notify_on_all_muc_messages') or \
+ app.config.get_per('rooms', control.room_jid,
+ 'notify_on_all_messages')
else:
name = control.contact.get_shown_name()
if control.resource:
=====================================
gajim/notify.py
=====================================
--- a/gajim/notify.py
+++ b/gajim/notify.py
@@ -68,7 +68,8 @@ def get_show_in_systray(event, account, contact, type_=None):
Return True if this event must be shown in systray, else False
"""
if type_ == 'printed_gc_msg' and not app.config.get(
- 'notify_on_all_muc_messages'):
+ 'notify_on_all_muc_messages') and not app.config.get_per('rooms',
+ contact.jid, 'notify_on_all_messages'):
# it's not an highlighted message, don't show in systray
return False
return app.config.get('trayicon_notification_on_events')
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/07ba85b45675990f0a9de46b22ffd2df93…
---
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/07ba85b45675990f0a9de46b22ffd2df93…
You're receiving this email because of your account on dev.gajim.org.
Philipp Hörist pushed to branch master at gajim / gajim
Commits:
e8399dc2 by Philipp Hörist at 2017-08-19T22:32:50+02:00
Fix wrong call to Sleepy()
And place a log call so we can gather exceptions to lose the
general exception in the future.
- - - - -
1 changed file:
- gajim/common/connection_handlers.py
Changes:
=====================================
gajim/common/connection_handlers.py
=====================================
--- a/gajim/common/connection_handlers.py
+++ b/gajim/common/connection_handlers.py
@@ -1383,9 +1383,10 @@ ConnectionHandlersBase, ConnectionJingle, ConnectionIBBytestream):
self.privacy_default_list = None
try:
- self.sleeper = common.sleepy.Sleepy()
+ self.sleeper = sleepy.Sleepy()
HAS_IDLE = True
except Exception:
+ log.warning('Error while calling Sleepy()', exc_info=True)
HAS_IDLE = False
self.gmail_last_tid = None
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/e8399dc2ed5db2d6631590d44ca657b266…
---
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/e8399dc2ed5db2d6631590d44ca657b266…
You're receiving this email because of your account on dev.gajim.org.
Philipp Hörist pushed to branch master at gajim / gajim
Commits:
763eba0a by Philipp Hörist at 2017-08-19T02:29:07+02:00
Update README
- - - - -
1 changed file:
- README
Changes:
=====================================
README
=====================================
--- a/README
+++ b/README
@@ -30,7 +30,7 @@
<li>For zeroconf (bonjour), the "enable link-local messaging" checkbox, you need dbus-glib, python-avahi</li>
<li>dnsutils (or whatever package provides the nslookup binary) for SRV support</li>
<li>gir1.2-gtkspell3-3.0 and aspell-LANG where lang is your locale eg. en, fr etc</li>
-<li>gir1.2-secret-1 for GNOMEÂ Keyring or KDE support as password storage</li>
+<li>gir1.2-secret-1 for GNOME Keyring or KDE support as password storage</li>
<li>gir1.2-notify-0.7 to get cooler popups</li>
<li>D-Bus running to have gajim-remote working. Some distributions split dbus-x11, which is needed for dbus to work with Gajim. Version >= 0.80 is required.</li>
<li>python3-dbus bindings (>=1.2.0)</li>
@@ -67,10 +67,10 @@
<h2>Running Gajim</h2>
<p>Just do <em>gajim</em> or you can run Gajim from your GNOME/Xfce/KDE/whatever menus.<br/><br/>
-or if you use hg version and you didn't 'make install' you can also run from gajim folder with<em>./launch.sh</em></p>
+or if you use Git version and you didn't 'make install' you can also run from gajim folder with<em>./launch.py</em></p>
<hr />
-<h3>Note for hg users</h3>
-<p>You will need GNU autotools in order to install Gajim from svn. This includes:</p>
+<h3>Note for Git users</h3>
+<p>You will need GNU autotools in order to install Gajim from Git. This includes:</p>
<ul>
<li>automake >= 1.8 </li>
<li>autoconf >= 2.59 </li>
@@ -109,8 +109,8 @@ If you don't want to make this permanent, execute gajim with --verbose
everytime you want to have verbose output.</p>
<h3>FAQ/Wiki</h3>
-<p>FAQ can be found at <a href="http://trac.gajim.org/wiki/GajimFaq">http://trac.gajim.org/wiki/GajimFaq</a><br/>
-Wiki can be found at <a href="http://trac.gajim.org/wiki">http://trac.gajim.org/wiki</a></p>
+<p>FAQ can be found at <a href="https://dev.gajim.org/gajim/gajim/wikis/help/gajimfaq">https://dev.gajim.org/gajim/gajim/wikis/help/gajimfaq</a><br/>
+Wiki can be found at <a href="https://dev.gajim.org/gajim/gajim/wikis/home">https://dev.gajim.org/gajim/gajim/wikis/home</a></p>
<p>That is all, <strong>enjoy!</strong></p>
@@ -119,7 +119,7 @@ Wiki can be found at <a href="http://trac.gajim.org/wiki">http://trac.gajim.org/
<br/>
<br/>
<br/>
-(C) 2003-2015<br/>
+(C) 2003-2017<br/>
The Gajim Team<br/>
https://gajim.org<br/>
<br/>
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/763eba0acc1b49391703980f65c4d0fd96…
---
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/763eba0acc1b49391703980f65c4d0fd96…
You're receiving this email because of your account on dev.gajim.org.
Philipp Hörist pushed to branch master at gajim / gajim
Commits:
2198c2f4 by Philipp Hörist at 2017-08-19T02:20:00+02:00
Update README.md
- - - - -
1 changed file:
- win/README.md
Changes:
=====================================
win/README.md
=====================================
--- a/win/README.md
+++ b/win/README.md
@@ -16,7 +16,7 @@ Download [msys2](http://www.msys2.org/) (msys2-x86_64-xxx.exe) and follow the in
* Run ``cd gajim/win`` to end up where this README exists.
* Execute ``./dev_env.sh`` to install all the needed dependencies.
* Now go to the git root dir ``cd ..``
-* Launch Gajim ``./launch.sh``
+* Launch Gajim ``./launch.py``
### Build Gajim / Creating an Installer
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/2198c2f478598b2103e6ae002b9e65655f…
---
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/2198c2f478598b2103e6ae002b9e65655f…
You're receiving this email because of your account on dev.gajim.org.