Commits

commits@gajim.org

17632 discussions

[Git][gajim/gajim][master] Update old trac links
by Philipp Hörist 27 Aug '17

27 Aug '17

Philipp Hörist pushed to branch master at gajim / gajim Commits: 298fa4b9 by Philipp Hörist at 2017-08-27T22:32:33+02:00 Update old trac links - - - - - 3 changed files: - gajim/common/exceptions.py - gajim/common/rst_xhtml_generator.py - plugins/acronyms_expander/acronyms_expander.py Changes: ===================================== gajim/common/exceptions.py ===================================== --- a/gajim/common/exceptions.py +++ b/gajim/common/exceptions.py @@ -80,7 +80,7 @@ class SessionBusNotPresent(Exception): def __str__(self): return _('Session bus is not available.\nTry reading %(url)s') % \ - {'url': 'http://trac.gajim.org/wiki/GajimDBus'} + {'url': 'https://dev.gajim.org/gajim/gajim/wikis/help/GajimDBus'} class SystemBusNotPresent(Exception): """ @@ -92,7 +92,7 @@ class SystemBusNotPresent(Exception): def __str__(self): return _('System bus is not available.\nTry reading %(url)s') % \ - {'url': 'http://trac.gajim.org/wiki/GajimDBus'} + {'url': 'https://dev.gajim.org/gajim/gajim/wikis/help/GajimDBus'} class NegotiationError(Exception): """ ===================================== gajim/common/rst_xhtml_generator.py ===================================== --- a/gajim/common/rst_xhtml_generator.py +++ b/gajim/common/rst_xhtml_generator.py @@ -94,7 +94,7 @@ else: 'XEP #', 'http://www.xmpp.org/extensions/', 'xep-%04d.html', pos_int_validator) generate_uri_role('gajim-ticket-reference', ('ticket', 'gtrack'), - 'Gajim Ticket #', 'http://trac.gajim.org/ticket/', '%d', + 'Gajim Ticket #', 'https://dev.gajim.org/gajim/gajim/issues', '%d', pos_int_validator) class HTMLGenerator: ===================================== plugins/acronyms_expander/acronyms_expander.py ===================================== --- a/plugins/acronyms_expander/acronyms_expander.py +++ b/plugins/acronyms_expander/acronyms_expander.py @@ -51,9 +51,8 @@ class AcronymsExpanderPlugin(GajimPlugin): 'ACRONYMS': ({'/slap': '/me slaps', 'PS-': 'plug-in system', 'G-': 'Gajim', - 'GNT-': 'http://trac.gajim.org/newticket', - 'GW-': 'http://trac.gajim.org/', - 'GTS-': 'http://trac.gajim.org/report', + 'GNT-': 'https://dev.gajim.org/gajim/gajim/issues', + 'GW-': 'https://dev.gajim.org/gajim/gajim/wikis/home', }, ''), } View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/298fa4b96d61549745c951f2ff359b6ddd… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/298fa4b96d61549745c951f2ff359b6ddd… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Update ascii smilies
by Philipp Hörist 27 Aug '17

27 Aug '17

Philipp Hörist pushed to branch master at gajim / gajim Commits: 2e1c1062 by Philipp Hörist at 2017-08-27T22:29:02+02:00 Update ascii smilies - - - - - 1 changed file: - data/emoticons/noto-emoticons/emoticons_theme.py Changes: ===================================== data/emoticons/noto-emoticons/emoticons_theme.py ===================================== --- a/data/emoticons/noto-emoticons/emoticons_theme.py +++ b/data/emoticons/noto-emoticons/emoticons_theme.py @@ -12,14 +12,14 @@ emoticons = OrderedDict([ # subgroup: face-positive ('u1f600.png', [u'\U0001f600']), ('u1f601.png', [u'\U0001f601']), - ('u1f602.png', [u'\U0001f602', ':-D', ':D']), + ('u1f602.png', [u'\U0001f602', ':\'-)', ':\')']), ('u1f923.png', [u'\U0001f923']), - ('u1f603.png', [u'\U0001f603']), + ('u1f603.png', [u'\U0001f603', ':-D', ':D', '=D']), ('u1f604.png', [u'\U0001f604']), ('u1f605.png', [u'\U0001f605']), ('u1f606.png', [u'\U0001f606']), ('u1f609.png', [u'\U0001f609', ';-)', ';)']), - ('u1f60a.png', [u'\U0001f60a', ':-)', ':)']), + ('u1f60a.png', [u'\U0001f60a']), ('u1f60b.png', [u'\U0001f60b']), ('u1f60e.png', [u'\U0001f60e', '8-)', 'B-)']), ('u1f60d.png', [u'\U0001f60d', '<3']), @@ -27,7 +27,7 @@ emoticons = OrderedDict([ ('u1f617.png', [u'\U0001f617']), ('u1f619.png', [u'\U0001f619']), ('u1f61a.png', [u'\U0001f61a']), - ('u263a.png', [u'\u263a']), + ('u263a.png', [u'\u263a', ':-)', ':)', '=)', '=]', ':]']), ('u1f642.png', [u'\U0001f642']), ('u1f917.png', [u'\U0001f917']), View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/2e1c10620fe6356138b97c6abe103c16be… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/2e1c10620fe6356138b97c6abe103c16be… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: common.helpers: simplify get_os_info()
by Yann Leboulanger 27 Aug '17

27 Aug '17

Yann Leboulanger pushed to branch master at gajim / gajim Commits: 66b49c24 by André Apitzsch at 2017-08-26T00:19:32+02:00 common.helpers: simplify get_os_info() - - - - - d6a8a238 by Yann Leboulanger at 2017-08-27T22:22:02+02:00 Merge branch 'os_info' into 'master' common.helpers: simplify get_os_info() See merge request !122 - - - - - 1 changed file: - gajim/common/helpers.py Changes: ===================================== gajim/common/helpers.py ===================================== --- a/gajim/common/helpers.py +++ b/gajim/common/helpers.py @@ -581,18 +581,6 @@ def get_xmpp_show(show): return None return show -def get_output_of_command(command): - try: - child_stdin, child_stdout = os.popen2(command) - except ValueError: - return None - - output = child_stdout.readlines() - child_stdout.close() - child_stdin.close() - - return output - def sanitize_filename(filename): """ Make sure the filename we will write does contain only acceptable and latin @@ -1044,29 +1032,6 @@ def remove_invalid_xml_chars(string): string = re.sub(app.interface.invalid_XML_chars_re, '', string) return string -distro_info = { - 'Arch Linux': '/etc/arch-release', - 'Aurox Linux': '/etc/aurox-release', - 'Conectiva Linux': '/etc/conectiva-release', - 'CRUX': '/usr/bin/crux', - 'Debian GNU/Linux': '/etc/debian_version', - 'Fedora Linux': '/etc/fedora-release', - 'Gentoo Linux': '/etc/gentoo-release', - 'Linux from Scratch': '/etc/lfs-release', - 'Mandrake Linux': '/etc/mandrake-release', - 'Slackware Linux': '/etc/slackware-version', - 'Solaris/Sparc': '/etc/release', - 'Source Mage': '/etc/sourcemage_version', - 'SUSE Linux': '/etc/SuSE-release', - 'Sun JDS': '/etc/sun-release', - 'PLD Linux': '/etc/pld-release', - 'Yellow Dog Linux': '/etc/yellowdog-release', - 'AgiliaLinux': '/etc/agilialinux-version', - # many distros use the /etc/redhat-release for compatibility - # so Redhat is the last - 'Redhat Linux': '/etc/redhat-release' -} - def get_random_string_16(): """ Create random string of length 16 @@ -1080,84 +1045,18 @@ def get_random_string_16(): def get_os_info(): if app.os_info: return app.os_info - if os.name == 'nt': - # platform.release() seems to return the name of the windows - ver = sys.getwindowsversion() - ver_format = ver[3], ver[0], ver[1] - win_version = { - (1, 4, 0): '95', - (1, 4, 10): '98', - (1, 4, 90): 'ME', - (2, 4, 0): 'NT', - (2, 5, 0): '2000', - (2, 5, 1): 'XP', - (2, 5, 2): '2003', - (2, 6, 0): 'Vista', - (2, 6, 1): '7', - } - if ver_format in win_version: - os_info = 'Windows' + ' ' + win_version[ver_format] - else: - os_info = 'Windows' - app.os_info = os_info - return os_info + app.os_info = 'N/A' + if os.name == 'nt' or sys.platform == 'darwin': + import platform + app.os_info = platform.system() + " " + platform.release() elif os.name == 'posix': - executable = 'lsb_release' - params = ' --description --codename --release --short' - full_path_to_executable = is_in_path(executable, return_abs_path = True) - if full_path_to_executable: - command = executable + params - p = subprocess.Popen([command], shell=True, stdin=subprocess.PIPE, - stdout=subprocess.PIPE, close_fds=True) - p.wait() - output = temp_failure_retry(p.stdout.readline).strip() - # some distros put n/a in places, so remove those - output = output.decode('utf-8').replace('n/a', '').replace('N/A', '') - app.os_info = output - p.stdout.close() - p.stdin.close() - return output - - # lsb_release executable not available, so parse files - for distro_name in distro_info: - path_to_file = distro_info[distro_name] - if os.path.exists(path_to_file): - if os.access(path_to_file, os.X_OK): - # the file is executable (f.e. CRUX) - # yes, then run it and get the first line of output. - text = get_output_of_command(path_to_file)[0] - else: - fd = open(path_to_file) - text = fd.readline().strip() # get only first line - fd.close() - if path_to_file.endswith('version'): - # sourcemage_version and slackware-version files - # have all the info we need (name and version of distro) - if not os.path.basename(path_to_file).startswith( - 'sourcemage') or not\ - os.path.basename(path_to_file).startswith('slackware'): - text = distro_name + ' ' + text - elif path_to_file.endswith('aurox-release') or \ - path_to_file.endswith('arch-release'): - # file doesn't have version - text = distro_name - elif path_to_file.endswith('lfs-release'): - # file just has version - text = distro_name + ' ' + text - os_info = text.replace('\n', '') - app.os_info = os_info - return os_info - - # our last chance, ask uname and strip it - uname_output = get_output_of_command('uname -sr') - if uname_output is not None: - os_info = uname_output[0] # only first line - app.os_info = os_info - return os_info - os_info = 'N/A' - app.os_info = os_info - return os_info - + try: + import distro + app.os_info = distro.name(pretty=True) + except ImportError: + import platform + app.os_info = platform.system() + return app.os_info def allow_showing_notification(account, type_='notify_on_new_message', is_first_message=True): View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/c862ecd83d96c86977242adaba01bca9a… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/c862ecd83d96c86977242adaba01bca9a… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: add pylint run to CI
by Yann Leboulanger 27 Aug '17

27 Aug '17

Yann Leboulanger pushed to branch master at gajim / gajim Commits: 915ad152 by Yann Leboulanger at 2017-08-27T21:43:28+02:00 add pylint run to CI - - - - - c862ecd8 by Yann Leboulanger at 2017-08-27T22:12:04+02:00 Merge branch 'master' into 'master' add pylint run to CI See merge request !123 - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1,5 +1,5 @@ before_script: - - sudo apt-get update -qq && sudo apt-get install -y -qq libtool pkg-config python3-openssl gir1.2-gtk-3.0 python3-gi python3-nbxmpp-nightly + - sudo apt-get update -qq && sudo apt-get install -y -qq libtool pkg-config python3-openssl gir1.2-gtk-3.0 python3-gi python3-nbxmpp-nightly pylint3 - sudo apt-get build-dep -y -qq gajim-default-nightly stages: @@ -12,6 +12,11 @@ run-test: - ./autogen.sh - make test_nogui +run-pylint: + stage: test + script: + - pylint3 --additional-builtins=_ --disable=all --enable=E0001,E0011,E0012,E0100,E0101,E0102,E0103,E0104,E0105,E0106,E0107,E0108,E0202,E0221,E0222,E0235,E0501,E0502,E0503,E0602,E0603,E0604,E0701,E0702,E1001,E1002,E1003,E1004,E1111,E1120,E1121,E1122,E1123,E1124,E1125,E1200,E1201,E1205,E1206,E1300,E1301,E1302,E1303,E1304,E1305,E1306,E1310,E1700,E1701 gajim + run-build: stage: build script: View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/aa087c34ad1fd026b9961c0131353af70… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/aa087c34ad1fd026b9961c0131353af70… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: dataforms: Replace @nested_property with @property.
by Yann Leboulanger 27 Aug '17

27 Aug '17

Yann Leboulanger pushed to branch master at gajim / gajim Commits: 63947c42 by Emmanuel Gil Peyrot at 2017-08-27T20:57:35+01:00 dataforms: Replace @nested_property with @property. - - - - - aa087c34 by Yann Leboulanger at 2017-08-27T22:08:48+02:00 Merge branch 'dataforms' into 'master' Replace @nested_property with @property in dataforms See merge request !124 - - - - - 1 changed file: - gajim/common/dataforms.py Changes: ===================================== gajim/common/dataforms.py ===================================== --- a/gajim/common/dataforms.py +++ b/gajim/common/dataforms.py @@ -49,14 +49,6 @@ class ExtendedNode(nbxmpp.Node, object): extend.__class__ = cls return extend -# helper decorator to create properties in cleaner way -def nested_property(f): - ret = f() - p = {'doc': f.__doc__} - for v in ('fget', 'fset', 'fdel', 'doc'): - if v in ret.keys(): p[v]=ret[v] - return property(**p) - # helper to create fields from scratch def Field(typ, **attrs): ''' Helper function to create a field of given type. ''' @@ -131,123 +123,115 @@ class DataField(ExtendedNode): self.required = required self.options = options - @nested_property - def type_(): # pylint: disable=E0202 + @property + def type_(self): """ Type of field. Recognized values are: 'boolean', 'fixed', 'hidden', 'jid-multi', 'jid-single', 'list-multi', 'list-single', 'text-multi', 'text-private', 'text-single'. If you set this to something different, DataField will store given name, but treat all data as text-single """ - def fget(self): - t = self.getAttr('type') - if t is None: - return 'text-single' - return t - - def fset(self, value): - assert isinstance(value, str) - self.setAttr('type', value) + t = self.getAttr('type') + if t is None: + return 'text-single' + return t - return locals() + @type_.setter + def type_(self, value): + assert isinstance(value, str) + self.setAttr('type', value) - @nested_property - def var(): # pylint: disable=E0202 + @property + def var(self): """ Field identifier """ - def fget(self): - return self.getAttr('var') - - def fset(self, value): - assert isinstance(value, str) - self.setAttr('var', value) + return self.getAttr('var') - def fdel(self): - self.delAttr('var') + @var.setter + def var(self, value): + assert isinstance(value, str) + self.setAttr('var', value) - return locals() + @var.deleter + def var(self): + self.delAttr('var') - @nested_property - def label(): # pylint: disable=E0202 + @property + def label(self): """ Human-readable field name """ - def fget(self): - l = self.getAttr('label') - if not l: - l = self.var - return l - - def fset(self, value): - assert isinstance(value, str) - self.setAttr('label', value) + l = self.getAttr('label') + if not l: + l = self.var + return l - def fdel(self): - if self.getAttr('label'): - self.delAttr('label') + @label.setter + def label(self, value): + assert isinstance(value, str) + self.setAttr('label', value) - return locals() + @label.deleter + def label(self): + if self.getAttr('label'): + self.delAttr('label') - @nested_property - def description(): + @property + def description(self): """ Human-readable description of field meaning """ - def fget(self): - return self.getTagData('desc') or '' - - def fset(self, value): - assert isinstance(value, str) - if value == '': - fdel(self) - else: - self.setTagData('desc', value) + return self.getTagData('desc') or '' - def fdel(self): - t = self.getTag('desc') - if t is not None: - self.delChild(t) + @description.setter + def description(self, value): + assert isinstance(value, str) + if value == '': + del self.description + else: + self.setTagData('desc', value) - return locals() + @description.deleter + def description(self): + t = self.getTag('desc') + if t is not None: + self.delChild(t) - @nested_property - def required(): # pylint: disable=E0202 + @property + def required(self): """ Controls whether this field required to fill. Boolean """ - def fget(self): - return bool(self.getTag('required')) - - def fset(self, value): - t = self.getTag('required') - if t and not value: - self.delChild(t) - elif not t and value: - self.addChild('required') + return bool(self.getTag('required')) - return locals() + @required.setter + def required(self, value): + t = self.getTag('required') + if t and not value: + self.delChild(t) + elif not t and value: + self.addChild('required') - @nested_property - def media(): + @property + def media(self): """ Media data """ - def fget(self): - media = self.getTag('media', namespace=nbxmpp.NS_DATA_MEDIA) - if media: - return Media(media) + media = self.getTag('media', namespace=nbxmpp.NS_DATA_MEDIA) + if media: + return Media(media) - def fset(self, value): - fdel(self) - self.addChild(node=value) + @media.setter + def media(self, value): + del self.media + self.addChild(node=value) - def fdel(self): - t = self.getTag('media') - if t is not None: - self.delChild(t) - - return locals() + @media.deleter + def media(self): + t = self.getTag('media') + if t is not None: + self.delChild(t) def is_valid(self): return True @@ -256,146 +240,141 @@ class Uri(nbxmpp.Node): def __init__(self, uri_tag): nbxmpp.Node.__init__(self, node=uri_tag) - @nested_property - def type_(): + @property + def type_(self): """ uri type """ - def fget(self): - return self.getAttr('type') - - def fset(self, value): - self.setAttr('type', value) + return self.getAttr('type') - def fdel(self): - self.delAttr('type') + @type_.setter + def type_(self, value): + self.setAttr('type', value) - return locals() + @type_.deleter + def type_(self): + self.delAttr('type') - @nested_property - def uri_data(): + @property + def uri_data(self): """ uri data """ - def fget(self): - return self.getData() - - def fset(self, value): - self.setData(value) + return self.getData() - def fdel(self): - self.setData(None) + @uri_data.setter + def uri_data(self, value): + self.setData(value) - return locals() + @uri_data.deleter + def uri_data(self): + self.setData(None) class Media(nbxmpp.Node): def __init__(self, media_tag): nbxmpp.Node.__init__(self, node=media_tag) - @nested_property - def uris(): + @property + def uris(self): """ URIs of the media element. """ - def fget(self): - return map(Uri, self.getTags('uri')) + return map(Uri, self.getTags('uri')) - def fset(self, value): - fdel(self) - for uri in value: - self.addChild(node=uri) + @uris.setter + def uris(self, value): + del self.uris + for uri in value: + self.addChild(node=uri) - def fdel(self): - for element in self.getTags('uri'): - self.delChild(element) - - return locals() + @uris.deleter + def uris(self): + for element in self.getTags('uri'): + self.delChild(element) class BooleanField(DataField): - @nested_property - def value(): # pylint: disable=E0202 + @property + def value(self): """ Value of field. May contain True, False or None """ - def fget(self): - v = self.getTagData('value') - if v in ('0', 'false'): - return False - if v in ('1', 'true'): - return True - if v is None: - return False # default value is False - raise WrongFieldValue - - def fset(self, value): - self.setTagData('value', value and '1' or '0') + v = self.getTagData('value') + if v in ('0', 'false'): + return False + if v in ('1', 'true'): + return True + if v is None: + return False # default value is False + raise WrongFieldValue - def fdel(self, value): - t = self.getTag('value') - if t is not None: - self.delChild(t) + @value.setter + def value(self, value): + self.setTagData('value', value and '1' or '0') - return locals() + @value.deleter + def value(self): + t = self.getTag('value') + if t is not None: + self.delChild(t) class StringField(DataField): """ Covers fields of types: fixed, hidden, text-private, text-single """ - @nested_property - def value(): # pylint: disable=E0202 + @property + def value(self): """ Value of field. May be any string """ - def fget(self): - return self.getTagData('value') or '' - - def fset(self, value): - assert isinstance(value, str) - if value == '' and not self.required: - return fdel(self) - self.setTagData('value', value) + return self.getTagData('value') or '' - def fdel(self): - try: - self.delChild(self.getTag('value')) - except ValueError: # if there already were no value tag - pass + @value.setter + def value(self, value): + assert isinstance(value, str) + if value == '' and not self.required: + del self.value + return + self.setTagData('value', value) - return locals() + @value.deleter + def value(self): + try: + self.delChild(self.getTag('value')) + except ValueError: # if there already were no value tag + pass class ListField(DataField): """ Covers fields of types: jid-multi, jid-single, list-multi, list-single """ - @nested_property - def options(): # pylint: disable=E0202 + @property + def options(self): """ Options """ - def fget(self): - options = [] - for element in self.getTags('option'): - v = element.getTagData('value') - if v is None: - raise WrongFieldValue - l = element.getAttr('label') - if not l: - l = v - options.append((l, v)) - return options - - def fset(self, values): - fdel(self) - for value, label in values: - self.addChild('option', {'label': label}).setTagData('value', value) - - def fdel(self): - for element in self.getTags('option'): - self.delChild(element) - - return locals() + options = [] + for element in self.getTags('option'): + v = element.getTagData('value') + if v is None: + raise WrongFieldValue + l = element.getAttr('label') + if not l: + l = v + options.append((l, v)) + return options + + @options.setter + def options(self, values): + del self.options + for value, label in values: + self.addChild('option', {'label': label}).setTagData('value', value) + + @options.deleter + def options(self): + for element in self.getTags('option'): + self.delChild(element) def iter_options(self): for element in self.iterTags('option'): @@ -438,27 +417,26 @@ class ListMultiField(ListField): Covers list-multi fields """ - @nested_property - def values(): + @property + def values(self): """ Values held in field """ - def fget(self): - values = [] - for element in self.getTags('value'): - values.append(element.getData()) - return values - - def fset(self, values): - fdel(self) - for value in values: - self.addChild('value').setData(value) + values = [] + for element in self.getTags('value'): + values.append(element.getData()) + return values - def fdel(self): - for element in self.getTags('value'): - self.delChild(element) + @values.setter + def values(self, values): + del self.values + for value in values: + self.addChild('value').setData(value) - return locals() + @values.deleter + def values(self): + for element in self.getTags('value'): + self.delChild(element) def iter_values(self): for element in self.getTags('value'): @@ -488,29 +466,28 @@ class JidMultiField(ListMultiField): return True class TextMultiField(DataField): - @nested_property - def value(): # pylint: disable=E0202 + @property + def value(self): """ Value held in field """ - def fget(self): - value = '' - for element in self.iterTags('value'): - value += '\n' + element.getData() - return value[1:] - - def fset(self, value): - fdel(self) - if value == '': - return - for line in value.split('\n'): - self.addChild('value').setData(line) - - def fdel(self): - for element in self.getTags('value'): - self.delChild(element) - - return locals() + value = '' + for element in self.iterTags('value'): + value += '\n' + element.getData() + return value[1:] + + @value.setter + def value(self, value): + del self.value + if value == '': + return + for line in value.split('\n'): + self.addChild('value').setData(line) + + @value.deleter + def value(self): + for element in self.getTags('value'): + self.delChild(element) class DataRecord(ExtendedNode): """ @@ -539,26 +516,25 @@ class DataRecord(ExtendedNode): self.delChild(field) self.fields = fields - @nested_property - def fields(): # pylint: disable=E0202 + @property + def fields(self): """ List of fields in this record """ - def fget(self): - return self.getTags('field') - - def fset(self, fields): - fdel(self) - for field in fields: - if not isinstance(field, DataField): - ExtendField(field) - self.addChild(node=field) + return self.getTags('field') - def fdel(self): - for element in self.getTags('field'): - self.delChild(element) + @fields.setter + def fields(self, fields): + del self.fields + for field in fields: + if not isinstance(field, DataField): + ExtendField(field) + self.addChild(node=field) - return locals() + @fields.deleter + def fields(self): + for element in self.getTags('field'): + self.delChild(element) def iter_fields(self): """ @@ -597,68 +573,64 @@ class DataForm(ExtendedNode): if instructions is not None: self.instructions=instructions - @nested_property - def type_(): # pylint: disable=E0202 + @property + def type_(self): """ Type of the form. Must be one of: 'form', 'submit', 'cancel', 'result'. 'form' - this form is to be filled in; you will be able soon to do: filledform = DataForm(replyto=thisform) """ - def fget(self): - return self.getAttr('type') - - def fset(self, type_): - assert type_ in ('form', 'submit', 'cancel', 'result') - self.setAttr('type', type_) + return self.getAttr('type') - return locals() + @type_.setter + def type_(self, type_): + assert type_ in ('form', 'submit', 'cancel', 'result') + self.setAttr('type', type_) - @nested_property - def title(): # pylint: disable=E0202 + @property + def title(self): """ Title of the form Human-readable, should not contain any \\r\\n. """ - def fget(self): - return self.getTagData('title') + return self.getTagData('title') - def fset(self, title): - self.setTagData('title', title) + @title.setter + def title(self, title): + self.setTagData('title', title) - def fdel(self): - try: - self.delChild('title') - except ValueError: - pass - - return locals() + @title.deleter + def title(self): + try: + self.delChild('title') + except ValueError: + pass - @nested_property - def instructions(): # pylint: disable=E0202 + @property + def instructions(self): """ Instructions for this form Human-readable, may contain \\r\\n. """ # TODO: the same code is in TextMultiField. join them - def fget(self): - value = '' - for valuenode in self.getTags('instructions'): - value += '\n' + valuenode.getData() - return value[1:] - - def fset(self, value): - fdel(self) - if value == '': return - for line in value.split('\n'): - self.addChild('instructions').setData(line) - - def fdel(self): - for value in self.getTags('instructions'): - self.delChild(value) - - return locals() + value = '' + for valuenode in self.getTags('instructions'): + value += '\n' + valuenode.getData() + return value[1:] + + @instructions.setter + def instructions(self, value): + del self.instructions + if value == '': return + for line in value.split('\n'): + self.addChild('instructions').setData(line) + + @instructions.deleter + def instructions(self): + for value in self.getTags('instructions'): + self.delChild(value) class SimpleDataForm(DataForm, DataRecord): def __init__(self, type_=None, title=None, instructions=None, fields=None, \ @@ -711,44 +683,43 @@ class MultipleDataForm(DataForm): reported_tag = self.getTag('reported') self.reported = DataRecord(extend=reported_tag) - @nested_property - def items(): # pylint: disable=E0202 + @property + def items(self): """ A list of all records """ - def fget(self): - return list(self.iter_records()) - - def fset(self, records): - fdel(self) - for record in records: - if not isinstance(record, DataRecord): - DataRecord(extend=record) - self.addChild(node=record) + return list(self.iter_records()) - def fdel(self): - for record in self.getTags('item'): - self.delChild(record) + @items.setter + def items(self, records): + del self.items + for record in records: + if not isinstance(record, DataRecord): + DataRecord(extend=record) + self.addChild(node=record) - return locals() + @items.deleter + def items(self): + for record in self.getTags('item'): + self.delChild(record) def iter_records(self): for record in self.getTags('item'): yield record -# @nested_property -# def reported(): -# """ -# DataRecord that contains descriptions of fields in records -# """ -# def fget(self): -# return self.getTag('reported') -# def fset(self, record): -# try: -# self.delChild('reported') -# except: -# pass +# @property +# def reported(self): +# """ +# DataRecord that contains descriptions of fields in records +# """ +# return self.getTag('reported') +# +# @reported.setter +# def reported(self, record): +# try: +# self.delChild('reported') +# except: +# pass # -# record.setName('reported') -# self.addChild(node=record) -# return locals() +# record.setName('reported') +# self.addChild(node=record) View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/b4362a8a97ca44374535995c1b343ef01… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/b4362a8a97ca44374535995c1b343ef01… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] ignore some pylint errors
by Yann Leboulanger 27 Aug '17

27 Aug '17

Yann Leboulanger pushed to branch master at gajim / gajim Commits: b4362a8a by Yann Leboulanger at 2017-08-27T21:37:19+02:00 ignore some pylint errors - - - - - 1 changed file: - gajim/common/dataforms.py Changes: ===================================== gajim/common/dataforms.py ===================================== --- a/gajim/common/dataforms.py +++ b/gajim/common/dataforms.py @@ -132,7 +132,7 @@ class DataField(ExtendedNode): self.options = options @nested_property - def type_(): + def type_(): # pylint: disable=E0202 """ Type of field. Recognized values are: 'boolean', 'fixed', 'hidden', 'jid-multi', 'jid-single', 'list-multi', 'list-single', 'text-multi', @@ -152,7 +152,7 @@ class DataField(ExtendedNode): return locals() @nested_property - def var(): + def var(): # pylint: disable=E0202 """ Field identifier """ @@ -169,7 +169,7 @@ class DataField(ExtendedNode): return locals() @nested_property - def label(): + def label(): # pylint: disable=E0202 """ Human-readable field name """ @@ -212,7 +212,7 @@ class DataField(ExtendedNode): return locals() @nested_property - def required(): + def required(): # pylint: disable=E0202 """ Controls whether this field required to fill. Boolean """ @@ -313,7 +313,7 @@ class Media(nbxmpp.Node): class BooleanField(DataField): @nested_property - def value(): + def value(): # pylint: disable=E0202 """ Value of field. May contain True, False or None """ @@ -343,7 +343,7 @@ class StringField(DataField): """ @nested_property - def value(): + def value(): # pylint: disable=E0202 """ Value of field. May be any string """ @@ -370,7 +370,7 @@ class ListField(DataField): """ @nested_property - def options(): + def options(): # pylint: disable=E0202 """ Options """ @@ -489,7 +489,7 @@ class JidMultiField(ListMultiField): class TextMultiField(DataField): @nested_property - def value(): + def value(): # pylint: disable=E0202 """ Value held in field """ @@ -540,7 +540,7 @@ class DataRecord(ExtendedNode): self.fields = fields @nested_property - def fields(): + def fields(): # pylint: disable=E0202 """ List of fields in this record """ @@ -598,7 +598,7 @@ class DataForm(ExtendedNode): self.instructions=instructions @nested_property - def type_(): + def type_(): # pylint: disable=E0202 """ Type of the form. Must be one of: 'form', 'submit', 'cancel', 'result'. 'form' - this form is to be filled in; you will be able soon to do: @@ -614,7 +614,7 @@ class DataForm(ExtendedNode): return locals() @nested_property - def title(): + def title(): # pylint: disable=E0202 """ Title of the form @@ -635,7 +635,7 @@ class DataForm(ExtendedNode): return locals() @nested_property - def instructions(): + def instructions(): # pylint: disable=E0202 """ Instructions for this form @@ -712,7 +712,7 @@ class MultipleDataForm(DataForm): self.reported = DataRecord(extend=reported_tag) @nested_property - def items(): + def items(): # pylint: disable=E0202 """ A list of all records """ View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/b4362a8a97ca44374535995c1b343ef013… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/b4362a8a97ca44374535995c1b343ef013… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Make IPython 5 work
by Yann Leboulanger 27 Aug '17

27 Aug '17

Yann Leboulanger pushed to branch master at gajim / gajim Commits: 46c9e5c6 by Yann Leboulanger at 2017-08-27T21:21:48+02:00 Make IPython 5 work - - - - - 2 changed files: - gajim/gui_interface.py - gajim/ipython_view.py Changes: ===================================== gajim/gui_interface.py ===================================== --- a/gajim/gui_interface.py +++ b/gajim/gui_interface.py @@ -2556,7 +2556,7 @@ class Interface: @staticmethod def create_ipython_window(): try: - from ipython_view import IPythonView + from gajim.ipython_view import IPythonView except ImportError: print('ipython_view not found') return ===================================== gajim/ipython_view.py ===================================== --- a/gajim/ipython_view.py +++ b/gajim/ipython_view.py @@ -59,6 +59,24 @@ try: except ImportError: IPython = None +HAS_IPYTHON5 = True +try: + from pygments.token import Token + from IPython.core.displayhook import DisplayHook + from IPython.core.display_trap import DisplayTrap + + class MyPromptDisplayHook(DisplayHook): + def __init__(self, shell, view): + DisplayHook.__init__(self, shell=shell) + self.view = view + + def write_output_prompt(self): + tokens = self.shell.prompts.out_prompt_tokens() + self.view.write('\n') + self.view.write(tokens) +except Exception: + HAS_IPYTHON5 = False + class IterableIPShell: """ Create an IPython instance. Does not start a blocking event loop, @@ -114,7 +132,11 @@ class IterableIPShell: os.environ['TERM'] = 'dumb' excepthook = sys.excepthook - from IPython.config.loader import Config + if IPython.version_info[0] >= 5: + from traitlets.config.loader import Config + else: + from IPython.config.loader import Config + cfg = Config() cfg.InteractiveShell.colors = "Linux" @@ -125,7 +147,7 @@ class IterableIPShell: # InteractiveShell inherits from SingletonConfigurable so use instance() if IPython.version_info[0] >= 1: - self.IP = IPython.terminal.embed.InteractiveShellEmbed.instance(config=cfg, user_ns=user_ns) + self.IP = IPython.terminal.embed.InteractiveShellEmbed.instance(config=cfg, user_ns=user_ns, user_module=user_global_ns) else: self.IP = IPython.frontend.terminal.embed.InteractiveShellEmbed.instance(config=cfg, user_ns=user_ns) @@ -144,7 +166,7 @@ class IterableIPShell: self.complete_sep = re.compile('[\s\{\}\[\]\(\)]') self.updateNamespace({'exit':lambda:None}) self.updateNamespace({'quit':lambda:None}) - self.IP.readline_startup_hook(self.IP.pre_readline) + #self.IP.readline_startup_hook(self.IP.pre_readline) # Workaround for updating namespace with sys.modules # self.__update_namespace() @@ -206,6 +228,7 @@ class IterableIPShell: sys.stdout = orig_stdout sys.stdin = orig_stdin + def generatePrompt(self, is_continuation): ''' Generate prompt depending on is_continuation value @@ -217,17 +240,24 @@ class IterableIPShell: @rtype: string ''' - # Backwards compatibility with ipyton-0.11 # ver = IPython.__version__ if '0.11' in ver: prompt = self.IP.hooks.generate_prompt(is_continuation) else: - if is_continuation: - prompt = self.IP.prompt_manager.render('in2') - else: - prompt = self.IP.prompt_manager.render('in') + # Prompt for IPython >=5.0: + if hasattr(self.IP, 'prompts'): + if is_continuation: + prompt = self.IP.prompts.continuation_prompt_tokens(self.IP.prompts) + else: + prompt = self.IP.prompts.in_prompt_tokens(self.IP.prompts) + # Prompt for IPython < 5.0 + elif hasattr(self.IP, 'prompt_manager'): + if is_continuation: + prompt = self.IP.prompt_manager.render('in2') + else: + prompt = self.IP.prompt_manager.render('in') return prompt @@ -319,27 +349,6 @@ class IterableIPShell: return completed, possibilities[1] - def shell(self, cmd,verbose=0,debug=0,header=''): - """ - Replacement method to allow shell commands without them blocking - - @param cmd: Shell command to execute. - @type cmd: string - @param verbose: Verbosity - @type verbose: integer - @param debug: Debug level - @type debug: integer - @param header: Header to be printed before output - @type header: string - """ - if verbose or debug: print(header+cmd) - # flush stdout so we don't mangle python's buffering - if not debug: - input_, output = os.popen4(cmd) - print(output.read()) - output.close() - input_.close() - class ConsoleView(Gtk.TextView): """ Specialized text view for console-like workflow @@ -384,13 +393,47 @@ class ConsoleView(Gtk.TextView): self.text_buffer.create_tag('0') self.text_buffer.create_tag('notouch', editable=False) self.color_pat = re.compile('\x01?\x1b\[(.*?)m\x02?') + if HAS_IPYTHON5: + self.style_dict = { + Token.Prompt: '0;32', + Token.PromptNum: '1;32', + Token.OutPrompt: '0;31', + Token.OutPromptNum: '1;31', + } self.line_start = \ self.text_buffer.create_mark('line_start', self.text_buffer.get_end_iter(), True) self.connect('key-press-event', self.onKeyPress) def write(self, text, editable=False): - GLib.idle_add(self._write, text, editable) + if type(text) == str: + GLib.idle_add(self._write, text, editable) + elif IPython.version_info[0] >= 5: + GLib.idle_add(self._write5, text, editable) + + def _write5(self, text, editable=False): + """ + Write given text to buffer + + @param text: Text to append. + @type text: list of (token: string) + @param editable: If true, added text is editable. + @type editable: boolean + """ + start_mark = self.text_buffer.create_mark(None, + self.text_buffer.get_end_iter(), + True) + + for token, segment in text: + tag = self.style_dict[token] + self.text_buffer.insert_with_tags_by_name(self.text_buffer.get_end_iter(), + segment, tag) + if not editable: + self.text_buffer.apply_tag_by_name('notouch', + self.text_buffer.get_iter_at_mark(start_mark), + self.text_buffer.get_end_iter()) + self.text_buffer.delete_mark(start_mark) + self.scroll_mark_onscreen(self.mark) def _write(self, text, editable=False): """ @@ -401,6 +444,9 @@ class ConsoleView(Gtk.TextView): @param editable: If true, added text is editable. @type editable: boolean """ + if type(text) == list and IPython.version_info[0] >= 5: + self._write5(text, editable) + return segments = self.color_pat.split(text) segment = segments.pop(0) start_mark = self.text_buffer.create_mark(None, @@ -555,6 +601,10 @@ class IPythonView(ConsoleView, IterableIPShell): self.cout = StringIO() IterableIPShell.__init__(self, cout=self.cout, cerr=self.cout, input_func=self.raw_input) + if HAS_IPYTHON5: + displayhook = MyPromptDisplayHook(shell=self.IP, view=self) + self.IP.displayhook = displayhook + self.IP.display_trap = DisplayTrap(hook=displayhook) # self.connect('key_press_event', self.keyPress) self.interrupt = False self.execute() @@ -562,6 +612,10 @@ class IPythonView(ConsoleView, IterableIPShell): self.cout.truncate(0) self.showPrompt(self.prompt) + def prompt_for_code(self): + # IPython 5.0 calls prompt_for_code instead of raw_input + return self.raw_input(self) + def raw_input(self, prompt=''): """ Custom raw_input() replacement. Get's current line from console buffer View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/46c9e5c6794c6641467d2b716c8a30691b… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/46c9e5c6794c6641467d2b716c8a30691b… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Hide some pylint errors
by Yann Leboulanger 24 Aug '17

24 Aug '17

Yann Leboulanger pushed to branch master at gajim / gajim Commits: 134f72db by Yann Leboulanger at 2017-08-24T23:20:35+02:00 Hide some pylint errors - - - - - 3 changed files: - gajim/common/app.py - gajim/common/jingle_session.py - gajim/common/zeroconf/zeroconf.py Changes: ===================================== gajim/common/app.py ===================================== --- a/gajim/common/app.py +++ b/gajim/common/app.py @@ -42,7 +42,7 @@ from gajim.common.contacts import LegacyContactsAPI from gajim.common.events import Events interface = None # The actual interface (the gtk one for the moment) -thread_interface = None # Interface to run a thread and then a callback +thread_interface = lambda *args: None # Interface to run a thread and then a callback config = config.Config() version = config.get('version') connections = {} # 'account name': 'account (connection.Connection) instance' ===================================== gajim/common/jingle_session.py ===================================== --- a/gajim/common/jingle_session.py +++ b/gajim/common/jingle_session.py @@ -495,12 +495,12 @@ class JingleSession: parse_result = self.__parse_contents(jingle) contents = parse_result[0] rejected_contents = parse_result[1] - for name, creator in rejected_contents: +# for name, creator in rejected_contents: # TODO - content = JingleContent() - self.add_content(name, content, creator) - self.__content_reject(content) - self.contents[(content.creator, content.name)].destroy() +# content = JingleContent() +# self.add_content(name, content, creator) +# self.__content_reject(content) +# self.contents[(content.creator, content.name)].destroy() app.nec.push_incoming_event(JingleRequestReceivedEvent(None, conn=self.connection, jingle_session=self, ===================================== gajim/common/zeroconf/zeroconf.py ===================================== --- a/gajim/common/zeroconf/zeroconf.py +++ b/gajim/common/zeroconf/zeroconf.py @@ -48,7 +48,7 @@ def test_bonjour(): import pybonjour except ImportError: return False - except WindowsError: + except WindowsError: # pylint: disable=undefined-variable return False return True View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/134f72db173d1f1ef7e4061226dd0c150a… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/134f72db173d1f1ef7e4061226dd0c150a… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix some pylint errors
by Yann Leboulanger 24 Aug '17

24 Aug '17

Yann Leboulanger pushed to branch master at gajim / gajim Commits: 8d4e815f by Yann Leboulanger at 2017-08-24T23:01:06+02:00 fix some pylint errors - - - - - 7 changed files: - gajim/common/commands.py - gajim/common/dataforms.py - gajim/common/protocol/bytestream.py - gajim/common/socks5.py - gajim/common/zeroconf/client_zeroconf.py - gajim/gui_interface.py - gajim/plugins/pluginmanager.py Changes: ===================================== gajim/common/commands.py ===================================== --- a/gajim/common/commands.py +++ b/gajim/common/commands.py @@ -85,6 +85,10 @@ class ChangeStatusCommand(AdHocCommand): commandnode = 'change-status' commandname = _('Change status information') + def __init__(self, conn, jid, sessionid): + AdHocCommand.__init__(self, conn, jid, sessionid) + self.cb = self.first_step + @staticmethod def isVisibleFor(samejid): """ @@ -93,6 +97,9 @@ class ChangeStatusCommand(AdHocCommand): return samejid def execute(self, request): + return self.cb(request) + + def first_step(self, request): # first query... response, cmd = self.buildResponse(request, defaultaction = 'execute', actions = ['execute']) @@ -120,11 +127,11 @@ class ChangeStatusCommand(AdHocCommand): self.connection.connection.send(response) # for next invocation - self.execute = self.changestatus + self.cb = self.second_step return True # keep the session - def changestatus(self, request): + def second_step(self, request): # check if the data is correct try: form = dataforms.SimpleDataForm(extend = request.getTag('command').\ @@ -184,6 +191,10 @@ class LeaveGroupchatsCommand(AdHocCommand): commandnode = 'leave-groupchats' commandname = _('Leave Groupchats') + def __init__(self, conn, jid, sessionid): + AdHocCommand.__init__(self, conn, jid, sessionid) + self.cb = self.first_step + @staticmethod def isVisibleFor(samejid): """ @@ -192,6 +203,9 @@ class LeaveGroupchatsCommand(AdHocCommand): return samejid def execute(self, request): + return self.cb(request) + + def first_step(self, request): # first query... response, cmd = self.buildResponse(request, defaultaction = 'execute', actions=['execute']) @@ -220,11 +234,11 @@ class LeaveGroupchatsCommand(AdHocCommand): self.connection.connection.send(response) # for next invocation - self.execute = self.leavegroupchats + self.cb = self.second_step return True # keep the session - def leavegroupchats(self, request): + def second_step(self, request): # check if the data is correct try: form = dataforms.SimpleDataForm(extend = request.getTag('command').\ ===================================== gajim/common/dataforms.py ===================================== --- a/gajim/common/dataforms.py +++ b/gajim/common/dataforms.py @@ -305,7 +305,7 @@ class Media(nbxmpp.Node): for uri in value: self.addChild(node=uri) - def fdel(self, value): + def fdel(self): for element in self.getTags('uri'): self.delChild(element) ===================================== gajim/common/protocol/bytestream.py ===================================== --- a/gajim/common/protocol/bytestream.py +++ b/gajim/common/protocol/bytestream.py @@ -720,7 +720,7 @@ class ConnectionSocks5Bytestream(ConnectionBytestream): if file_props.stopped: self.remove_transfer(file_props) else: - app.socks5queue.send_file(file_props, self.name) + app.socks5queue.send_file(file_props, self.name, 'server') raise nbxmpp.NodeProcessed proxy = None ===================================== gajim/common/socks5.py ===================================== --- a/gajim/common/socks5.py +++ b/gajim/common/socks5.py @@ -730,7 +730,7 @@ class Socks5(object): try: fd = self.get_fd() except IOError: - self.disconnect(False) + self.disconnect() self.file_props.error = -6 # file system error return 0 fd.write(self.remaining_buff) @@ -751,7 +751,7 @@ class Socks5(object): try: fd = self.get_fd() except IOError: - self.disconnect(False) + self.disconnect() self.file_props.error = -6 # file system error return 0 try: ===================================== gajim/common/zeroconf/client_zeroconf.py ===================================== --- a/gajim/common/zeroconf/client_zeroconf.py +++ b/gajim/common/zeroconf/client_zeroconf.py @@ -375,7 +375,7 @@ class P2PConnection(IdleObject, PlugIn): self.ais = socket.getaddrinfo(address['host'], address['port'], socket.AF_UNSPEC, socket.SOCK_STREAM) except socket.gaierror as e: - log.info('Lookup failure for %s: %s[%s]', host, e[1], + log.info('Lookup failure for %s: %s[%s]', self.host, e[1], repr(e[0]), exc_info=True) if len(self.addresses_) > 0: return self.get_next_addrinfo() else: ===================================== gajim/gui_interface.py ===================================== --- a/gajim/gui_interface.py +++ b/gajim/gui_interface.py @@ -2582,7 +2582,7 @@ class Interface: win.hide() return True window.connect('delete_event', on_delete) - view.updateNamespace({'gajim': gajim}) + view.updateNamespace({'gajim': app}) app.ipython_window = window def run(self, application): ===================================== gajim/plugins/pluginmanager.py ===================================== --- a/gajim/plugins/pluginmanager.py +++ b/gajim/plugins/pluginmanager.py @@ -568,7 +568,7 @@ class PluginManager(metaclass=Singleton): for option in fields: if conf.get('info', option) is '': - raise configparser.NoOptionError('field empty') + raise configparser.NoOptionError(option, 'info') if option == 'description': setattr(module_attr, option, _(conf.get('info', option))) continue View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/8d4e815f3eff74c237cd8ef0ff22306c64… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/8d4e815f3eff74c237cd8ef0ff22306c64… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Nicer code
by Yann Leboulanger 24 Aug '17

24 Aug '17

Yann Leboulanger pushed to branch master at gajim / gajim Commits: e57817ad by Yann Leboulanger at 2017-08-24T15:41:39+02:00 Nicer code - - - - - 2 changed files: - gajim/adhoc_commands.py - gajim/dataforms_widget.py Changes: ===================================== gajim/adhoc_commands.py ===================================== --- a/gajim/adhoc_commands.py +++ b/gajim/adhoc_commands.py @@ -59,6 +59,13 @@ class CommandWindow: self.jid = jid self.commandnode = commandnode self.data_form_widget = None + self.stage_finish_cb = None + self.stage_back_button_cb = None + self.stage_forward_button_cb = None + self.stage_execute_button_cb = None + self.stage_close_button_cb = None + self.stage_restart_button_cb = None + self.stage_window_delete_cb = None # retrieving widgets from xml self.xml = gtkgui_helpers.get_gtk_builder('adhoc_commands_window.ui') @@ -109,54 +116,48 @@ class CommandWindow: # These functions are set up by appropriate stageX methods. def stage_finish(self, *anything): - pass - - def stage_back_button_clicked(self, *anything): - assert False - - def stage_forward_button_clicked(self, *anything): - assert False - - def stage_execute_button_clicked(self, *anything): - assert False - - def stage_close_button_clicked(self, *anything): - assert False - - def stage_restart_button_clicked(self, *anything): - assert False - - def stage_adhoc_commands_window_delete_event(self, *anything): - assert False - - def do_nothing(self, *anything): - return False + if self.stage_finish_cb: + self.stage_finish_cb(*anything) # Widget callbacks... def on_back_button_clicked(self, *anything): - return self.stage_back_button_clicked(*anything) + if self.stage_back_button_cb: + return self.stage_back_button_cb(*anything) + return False def on_forward_button_clicked(self, *anything): - return self.stage_forward_button_clicked(*anything) + if self.stage_forward_button_cb: + return self.stage_forward_button_cb(*anything) + return False def on_execute_button_clicked(self, *anything): - return self.stage_execute_button_clicked(*anything) + if self.stage_execute_button_cb: + return self.stage_execute_button_cb(*anything) + return False def on_finish_button_clicked(self, *anything): - return self.stage_finish_button_clicked(*anything) + if self.stage_finish_button_cb: + return self.stage_finish_button_cb(*anything) + return False def on_close_button_clicked(self, *anything): - return self.stage_close_button_clicked(*anything) + if self.stage_close_button_cb: + return self.stage_close_button_cb(*anything) + return False def on_restart_button_clicked(self, *anything): - return self.stage_restart_button_clicked(*anything) + if self.stage_restart_button_cb: + return self.stage_restart_button_cb(*anything) + return False def on_adhoc_commands_window_destroy(self, *anything): # TODO: do all actions that are needed to remove this object from memory self.remove_pulsing() def on_adhoc_commands_window_delete_event(self, *anything): - return self.stage_adhoc_commands_window_delete_event(self.window) + if self.stage_window_delete_cb: + return self.stage_window_delete_cb(self.window) + return False def __del__(self): print('Object has been deleted.') @@ -188,10 +189,10 @@ class CommandWindow: self.xml.get_object('retrieving_commands_progressbar')) # setup the callbacks - self.stage_finish = self.stage1_finish - self.stage_close_button_clicked = self.stage1_close_button_clicked - self.stage_restart_button_clicked = self.stage1_restart_button_clicked - self.stage_adhoc_commands_window_delete_event = \ + self.stage_finish_cb = self.stage1_finish + self.stage_close_button_cb = self.stage1_close_button_clicked + self.stage_restart_button_cb = self.stage1_restart_button_clicked + self.stage_window_delete_cb = \ self.stage1_adhoc_commands_window_delete_event def stage1_finish(self): @@ -245,11 +246,11 @@ class CommandWindow: self.command_list_vbox.pack_start(radio, False, True, 0) self.command_list_vbox.show_all() - self.stage_finish = self.stage2_finish - self.stage_close_button_clicked = self.stage2_close_button_clicked - self.stage_restart_button_clicked = self.stage2_restart_button_clicked - self.stage_forward_button_clicked = self.stage2_forward_button_clicked - self.stage_adhoc_commands_window_delete_event = self.do_nothing + self.stage_finish_cb = self.stage2_finish + self.stage_close_button_cb = self.stage2_close_button_clicked + self.stage_restart_button_cb = self.stage2_restart_button_clicked + self.stage_forward_button_cb = self.stage2_forward_button_clicked + self.stage_window_delete_cb = None def stage2_finish(self): """ @@ -296,18 +297,14 @@ class CommandWindow: self.stage3_submit_form() - self.stage_finish = self.stage3_finish - self.stage_back_button_clicked = self.stage3_back_button_clicked - self.stage_forward_button_clicked = self.stage3_forward_button_clicked - self.stage_execute_button_clicked = self.stage3_execute_button_clicked - self.stage_finish_button_clicked = self.stage3_finish_button_clicked - self.stage_close_button_clicked = self.stage3_close_button_clicked - self.stage_restart_button_clicked = self.stage3_restart_button_clicked - self.stage_adhoc_commands_window_delete_event = \ - self.stage3_close_button_clicked - - def stage3_finish(self): - pass + self.stage_finish_cb = None + self.stage_back_button_cb = self.stage3_back_button_clicked + self.stage_forward_button_cb = self.stage3_forward_button_clicked + self.stage_execute_button_cb = self.stage3_execute_button_clicked + self.stage_finish_button_cb = self.stage3_finish_button_clicked + self.stage_close_button_cb = self.stage3_close_button_clicked + self.stage_restart_button_cb = self.stage3_restart_button_clicked + self.stage_window_delete_cb = self.stage3_close_button_clicked def stage3_can_close(self, cb): if self.form_status == 'completed': @@ -447,8 +444,7 @@ class CommandWindow: self.execute_button.hide() self.finish_button.hide() self.close_button.show() - self.stage_adhoc_commands_window_delete_event = \ - self.stage3_close_button_clicked + self.stage_window_delete_cb = self.stage3_close_button_clicked note = command.getTag('note') if note: @@ -480,10 +476,10 @@ class CommandWindow: self.execute_button.set_sensitive(False) self.finish_button.set_sensitive(False) - self.stage_finish = self.do_nothing - self.stage_close_button_clicked = self.stage4_close_button_clicked - self.stage_restart_button_clicked = self.stage4_restart_button_clicked - self.stage_adhoc_commands_window_delete_event = self.do_nothing + self.stage_finish_cb = None + self.stage_close_button_cb = self.stage4_close_button_clicked + self.stage_restart_button_cb = self.stage4_restart_button_clicked + self.stage_window_delete_cb = None def stage4_close_button_clicked(self, widget): self.window.destroy() @@ -532,10 +528,10 @@ class CommandWindow: self.error_description_label.set_text(error) - self.stage_finish = self.do_nothing - self.stage_close_button_clicked = self.stage5_close_button_clicked - self.stage_restart_button_clicked = self.stage5_restart_button_clicked - self.stage_adhoc_commands_window_delete_event = self.do_nothing + self.stage_finish_cb = None + self.stage_close_button_cb = self.stage5_close_button_clicked + self.stage_restart_button_cb = self.stage5_restart_button_clicked + self.stage_window_delete_cb = None def stage5_close_button_clicked(self, widget): self.window.destroy() ===================================== gajim/dataforms_widget.py ===================================== --- a/gajim/dataforms_widget.py +++ b/gajim/dataforms_widget.py @@ -56,6 +56,7 @@ class DataFormWidget(Gtk.Alignment, object): self._data_form = None self.selectable = False + self.clean_cb = None self.xml = gtkgui_helpers.get_gtk_builder('data_form_window.ui', 'data_form_vbox') @@ -143,7 +144,8 @@ class DataFormWidget(Gtk.Alignment, object): rewritten by build_*_data_form, according to type of form which is actually displayed """ - pass + if self.clean_cb: + self.clean_cb() def build_single_data_form(self): '''Invoked when new single form is to be created.''' @@ -162,7 +164,7 @@ class DataFormWidget(Gtk.Alignment, object): self.data_form_types_notebook.page_num( self.single_form_scrolledwindow)) - self.clean_data_form = self.clean_single_data_form + self.clean_cb = self.clean_single_data_form def clean_single_data_form(self): """ @@ -170,7 +172,7 @@ class DataFormWidget(Gtk.Alignment, object): form from widget """ self.singleform.destroy() - self.clean_data_form = self.empty_method # we won't call it twice + self.clean_cb = None # we won't call it twice del self.singleform def build_multiple_data_form(self): @@ -216,7 +218,7 @@ class DataFormWidget(Gtk.Alignment, object): self.data_form_types_notebook.page_num( self.multiple_form_hbox)) - self.clean_data_form = self.clean_multiple_data_form + self.clean_cb = self.clean_multiple_data_form readwrite = self._data_form.type_ != 'result' if not readwrite: @@ -232,7 +234,7 @@ class DataFormWidget(Gtk.Alignment, object): Called as clean_data_form, read the docs of clean_data_form(). Remove form from widget """ - self.clean_data_form = self.empty_method # we won't call it twice + self.clean_cb = None # we won't call it twice del self.multiplemodel def refresh_multiple_buttons(self): View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/e57817addc344e7c06446e394abe5fd68f… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/e57817addc344e7c06446e394abe5fd68f… You're receiving this email because of your account on dev.gajim.org.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits