Commits May 2020

commits@gajim.org

1 participants
67 discussions

[Git][gajim/gajim][master] Fix codespell errors
by Philipp Hörist 21 May '20

21 May '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 00322c0c by lovetox at 2020-05-21T13:04:09+02:00 Fix codespell errors - - - - - 1 changed file: - gajim/common/client.py Changes: ===================================== gajim/common/client.py ===================================== @@ -532,10 +532,10 @@ class Client(ConnectionHandlers): def cleanup(self): self._destroyed = True if self._client is not None: - # cleanup() is called befor nbmxpp.Client has disconnected, + # cleanup() is called before nbmxpp.Client has disconnected, # when we disable the account. So we need to unregister # handlers here. - # TODO: cleanup() should not be called befor disconnect is finished + # TODO: cleanup() should not be called before disconnect is finished for handler in modules.get_handlers(self): self._client.unregister_handler(handler) modules.unregister_modules(self) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/00322c0c29bbfd50121ac38ac3e4f2fa… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/00322c0c29bbfd50121ac38ac3e4f2fa… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Client: Unregister handlers on cleanup()
by Philipp Hörist 21 May '20

21 May '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 0bfc1edd by lovetox at 2020-05-21T12:37:08+02:00 Client: Unregister handlers on cleanup() Fixes #10083 - - - - - 1 changed file: - gajim/common/client.py Changes: ===================================== gajim/common/client.py ===================================== @@ -283,6 +283,7 @@ class Client(ConnectionHandlers): if self._destroy_client: self._client.destroy() + self._client = None self._destroy_client = False self._create_client() @@ -519,6 +520,7 @@ class Client(ConnectionHandlers): if self._destroy_client: self._client.destroy() + self._client = None self._destroy_client = False self._create_client() @@ -529,6 +531,13 @@ class Client(ConnectionHandlers): def cleanup(self): self._destroyed = True + if self._client is not None: + # cleanup() is called befor nbmxpp.Client has disconnected, + # when we disable the account. So we need to unregister + # handlers here. + # TODO: cleanup() should not be called befor disconnect is finished + for handler in modules.get_handlers(self): + self._client.unregister_handler(handler) modules.unregister_modules(self) def quit(self, kill_core): View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/0bfc1eddc20e06c208707b548ffdf2c5… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/0bfc1eddc20e06c208707b548ffdf2c5… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][gajim_1.2] Fix config migration
by Philipp Hörist 20 May '20

20 May '20

Philipp Hörist pushed to branch gajim_1.2 at gajim / gajim Commits: c2c0828e by lovetox at 2020-05-21T00:00:28+02:00 Fix config migration - - - - - 1 changed file: - gajim/common/optparser.py Changes: ===================================== gajim/common/optparser.py ===================================== @@ -147,7 +147,7 @@ class OptionsParser: self.update_config_to_1194() if old < V('1.1.95'): self.update_config_to_1195() - if old < [1, 1, 99, 1] and new >= [1, 1, 99, 1]: + if old < V('1.1.99.1'): self.update_config_to_11991() app.config.set('version', new_version) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/c2c0828e55a2e48201e9032fcdd9c397… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/c2c0828e55a2e48201e9032fcdd9c397… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][gajim_1.2] 33 commits: Remove shttp:// from the protocol list
by Philipp Hörist 20 May '20

20 May '20

Philipp Hörist pushed to branch gajim_1.2 at gajim / gajim Commits: 1cc68e64 by Emmanuel Gil Peyrot at 2020-05-20T23:51:39+02:00 Remove shttp:// from the protocol list This protocol never took off as https is much more secure for basically no downside (aside from running on a different port). - - - - - ce381d4c by lovetox at 2020-05-20T23:51:39+02:00 App: Add get_client() - - - - - 5d21a389 by Daniel Brötzmann at 2020-05-20T23:51:39+02:00 Start Chat: Use Start Chat instead of Add Contact - - - - - 2bf4a7e0 by Daniel Brötzmann at 2020-05-20T23:51:39+02:00 Preferences: Reintroduce merge accounts setting - - - - - 389c6b66 by lovetox at 2020-05-20T23:51:39+02:00 Remove obsolete method - - - - - 005ecdd1 by lovetox at 2020-05-20T23:51:39+02:00 RosterTooltip: Show correct account status Fixes #10100 - - - - - 0b7e2d7f by André Apitzsch at 2020-05-20T23:51:39+02:00 Contacts: Don't delete list while reading it - - - - - cfa0bacd by Emmanuel Gil Peyrot at 2020-05-20T23:51:39+02:00 Add a codespell ignore list - - - - - 007ee5d7 by Emmanuel Gil Peyrot at 2020-05-20T23:51:39+02:00 Add a CI pass for codespell This avoids future typos. - - - - - ccee6877 by Emmanuel Gil Peyrot at 2020-05-20T23:51:39+02:00 Remove � characters from emoji data - - - - - d42defc0 by Emmanuel Gil Peyrot at 2020-05-20T23:51:39+02:00 Fix typos Thanks codespell! - - - - - cdfc4da9 by André Apitzsch at 2020-05-20T23:51:39+02:00 Remove legacy cairo code - - - - - 542eb383 by André Apitzsch at 2020-05-20T23:51:39+02:00 Add shortcut for shortcuts window Follow https://gitlab.gnome.org/GNOME/Initiatives/-/issues/14 - - - - - 0465de30 by André Apitzsch at 2020-05-20T23:51:39+02:00 IPython: Simplify code IPython 6.5 is the first version that is Python 3.7 compatible. https://ipython.readthedocs.io/en/stable/whatsnew/version6.html#ipython-6-5… - - - - - b1c5b875 by Daniel Brötzmann at 2020-05-20T23:51:39+02:00 Start Chat: Introduce account badges - - - - - 5796147f by Daniel Brötzmann at 2020-05-20T23:51:39+02:00 Groupchat Invite: Use account badge - - - - - 5c70dd16 by Daniel Brötzmann at 2020-05-20T23:51:39+02:00 ChatControl: Use account badge - - - - - e7a97348 by André Apitzsch at 2020-05-20T23:51:39+02:00 Use PEP-440 compatible version comparison https://www.python.org/dev/peps/pep-0440/ - - - - - 3a092238 by André Apitzsch at 2020-05-20T23:51:39+02:00 Optparser: Support PEP-440 versions - - - - - 29b79778 by André Apitzsch at 2020-05-20T23:51:39+02:00 PluginManager: Use packaging's Version() directly - - - - - 2a7958fb by André Apitzsch at 2020-05-20T23:51:39+02:00 Optparser: Remove unneeded comparison `new_version` passed to `update_config()` corresponds to the currently running version of Gajim, i.e. it's the latest version compared to the other versions mentioned in `update_config()`, that's why the conditions `V('...') <= new_version` are always true and can be removed. - - - - - 7d77e022 by lovetox at 2020-05-20T23:51:39+02:00 Client: Unregister modules when account is disabled - - - - - af40eae7 by lovetox at 2020-05-20T23:51:39+02:00 Client: Don't create nbxmpp.Client() after cleanup() - - - - - 924cb3dd by lovetox at 2020-05-20T23:51:39+02:00 PluginManager: Remove obsolete check on handler registration - - - - - 48891270 by lovetox at 2020-05-20T23:51:39+02:00 MUCData: Add propertys - - - - - f5eb9246 by lovetox at 2020-05-20T23:51:39+02:00 Add TaskManager Adds a queue for executing background tasks For example fetching avatars or disco info - - - - - 764c7323 by lovetox at 2020-05-20T23:51:39+02:00 Caps: Use TaskManager for requesting disco info - - - - - 2a36ddfa by lovetox at 2020-05-20T23:51:39+02:00 TaskManager: Fix mypy errors - - - - - 92fad3da by lovetox at 2020-05-20T23:51:39+02:00 Update mypy.ini - - - - - 9bc2601e by lovetox at 2020-05-20T23:51:39+02:00 Update gitlab-ci.yml - - - - - 42a23852 by lovetox at 2020-05-20T23:51:39+02:00 Roster: Remove reconnect menuitem on groupchats Fixes #10106 - - - - - 926cd0e8 by lovetox at 2020-05-20T23:51:39+02:00 Remove shortcut for Accounts window - - - - - ec050632 by André Apitzsch at 2020-05-20T23:51:39+02:00 Menu: Add access keys Fixes #10074 - - - - - 30 changed files: - .gitlab-ci.yml - + codespell.conf - flatpak/org.gajim.Gajim.yaml - gajim/application.py - gajim/chat_control.py - gajim/chat_control_base.py - gajim/common/app.py - gajim/common/client.py - gajim/common/config.py - gajim/common/const.py - gajim/common/contacts.py - gajim/common/exceptions.py - gajim/common/helpers.py - gajim/common/i18n.py - gajim/common/jingle_ft.py - gajim/common/jingle_ftstates.py - gajim/common/jingle_rtp.py - gajim/common/jingle_session.py - gajim/common/jingle_xtls.py - gajim/common/logger.py - gajim/common/logging_helpers.py - gajim/common/modules/adhoc_commands.py - gajim/common/modules/base.py - gajim/common/modules/bits_of_binary.py - gajim/common/modules/blocking.py - gajim/common/modules/bytestream.py - gajim/common/modules/caps.py - gajim/common/modules/chatstates.py - gajim/common/modules/entity_time.py - gajim/common/modules/httpupload.py The diff was not included because it is too large. View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/e415869f9fecc5586115388fe51e9f7… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/e415869f9fecc5586115388fe51e9f7… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][gajim_1.2] fix strings. Fixes #10114
by Yann Leboulanger 19 May '20

19 May '20

Yann Leboulanger pushed to branch gajim_1.2 at gajim / gajim Commits: e415869f by Yann Leboulanger at 2020-05-19T14:12:50+02:00 fix strings. Fixes #10114 - - - - - 2 changed files: - gajim/groupchat_control.py - gajim/gui_interface.py Changes: ===================================== gajim/groupchat_control.py ===================================== @@ -828,8 +828,8 @@ class GroupchatControl(ChatControlBase): NewConfirmationDialog( _('Voice Request'), _('Voice Request'), - _('<b>%(nick)s</b> from <b>%(room_name)s</b> requests voice') % ( - event.voice_request.nick, self.room_name), + _('<b>%(nick)s</b> from <b>%(room_name)s</b> requests voice') % { + 'nick': event.voice_request.nick, 'room_name': self.room_name}, [DialogButton.make('Cancel'), DialogButton.make('Accept', text=_('_Approve'), ===================================== gajim/gui_interface.py ===================================== @@ -352,7 +352,8 @@ class Interface: jid = contact.jid NewConfirmationDialog( _('Subscription Removed'), - _('%(name)s (%(jid)s) has removed subscription from you') % (name, jid), + _('%(name)s (%(jid)s) has removed subscription from you') % { + 'name': name, 'jid': jid}, _('You will always see this contact as offline.\n' 'Do you want to remove them from your contact list?'), [DialogButton.make('Cancel', View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/e415869f9fecc5586115388fe51e9f78… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/e415869f9fecc5586115388fe51e9f78… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix strings. Fixes #10114
by Yann Leboulanger 19 May '20

19 May '20

Yann Leboulanger pushed to branch master at gajim / gajim Commits: 50253f80 by Yann Leboulanger at 2020-05-19T14:11:03+02:00 fix strings. Fixes #10114 - - - - - 2 changed files: - gajim/groupchat_control.py - gajim/gui_interface.py Changes: ===================================== gajim/groupchat_control.py ===================================== @@ -828,8 +828,8 @@ class GroupchatControl(ChatControlBase): NewConfirmationDialog( _('Voice Request'), _('Voice Request'), - _('<b>%(nick)s</b> from <b>%(room_name)s</b> requests voice') % ( - event.voice_request.nick, self.room_name), + _('<b>%(nick)s</b> from <b>%(room_name)s</b> requests voice') % { + 'nick': event.voice_request.nick, 'room_name': self.room_name}, [DialogButton.make('Cancel'), DialogButton.make('Accept', text=_('_Approve'), ===================================== gajim/gui_interface.py ===================================== @@ -352,7 +352,8 @@ class Interface: jid = contact.jid NewConfirmationDialog( _('Subscription Removed'), - _('%(name)s (%(jid)s) has removed subscription from you') % (name, jid), + _('%(name)s (%(jid)s) has removed subscription from you') % { + 'name': name, 'jid': jid}, _('You will always see this contact as offline.\n' 'Do you want to remove them from your contact list?'), [DialogButton.make('Cancel', View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/50253f808ad10119538b8049d16a2576… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/50253f808ad10119538b8049d16a2576… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Menu: Add access keys
by Philipp Hörist 17 May '20

17 May '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 7ed48c0f by André Apitzsch at 2020-05-17T21:01:25+02:00 Menu: Add access keys Fixes #10074 - - - - - 1 changed file: - gajim/data/gui/application_menu.ui Changes: ===================================== gajim/data/gui/application_menu.ui ===================================== @@ -2,95 +2,95 @@ <interface> <menu id="menubar"> <submenu> - <attribute name="label">Gajim</attribute> + <attribute name="label">_Gajim</attribute> <section> <item> - <attribute name="label" translatable="yes">Start Chat…</attribute> + <attribute name="label" translatable="yes">_Start Chat…</attribute> <attribute name="action">app.start-chat</attribute> <attribute name="target"></attribute> </item> <item> - <attribute name="label" translatable="yes">Create Group Chat…</attribute> + <attribute name="label" translatable="yes">Create _Group Chat…</attribute> <attribute name="action">app.create-groupchat</attribute> <attribute name="target"></attribute> </item> <item> - <attribute name="label" translatable="yes">History Manager</attribute> + <attribute name="label" translatable="yes">_History Manager</attribute> <attribute name="action">app.history-manager</attribute> </item> <item> - <attribute name="label" translatable="yes">Plugins</attribute> + <attribute name="label" translatable="yes">Pl_ugins</attribute> <attribute name="action">app.plugins</attribute> </item> <item> - <attribute name="label" translatable="yes">Preferences</attribute> + <attribute name="label" translatable="yes">_Preferences</attribute> <attribute name="action">app.preferences</attribute> </item> <item> - <attribute name="label" translatable="yes">Quit</attribute> + <attribute name="label" translatable="yes">_Quit</attribute> <attribute name="action">app.quit</attribute> </item> </section> </submenu> <submenu> - <attribute name="label" translatable="yes">Accounts</attribute> + <attribute name="label" translatable="yes">_Accounts</attribute> </submenu> <submenu> - <attribute name="label" translatable="yes">View</attribute> + <attribute name="label" translatable="yes">_View</attribute> <section> <item> - <attribute name="label" translatable="yes">Show Contact List</attribute> + <attribute name="label" translatable="yes">Show _Contact List</attribute> <attribute name="action">win.show-roster</attribute> </item> <item> - <attribute name="label" translatable="yes">Show Offline Contacts</attribute> + <attribute name="label" translatable="yes">Show _Offline Contacts</attribute> <attribute name="action">win.show-offline</attribute> </item> <item> - <attribute name="label" translatable="yes">Show Active Contacts</attribute> + <attribute name="label" translatable="yes">Show _Active Contacts</attribute> <attribute name="action">win.show-active</attribute> </item> <item> - <attribute name="label" translatable="yes">Show Transports</attribute> + <attribute name="label" translatable="yes">Show _Transports</attribute> <attribute name="action">win.show-transports</attribute> </item> </section> <section> <item> - <attribute name="label" translatable="yes">XML Console</attribute> + <attribute name="label" translatable="yes">_XML Console</attribute> <attribute name="action">app.xml-console</attribute> </item> <item> - <attribute name="label" translatable="yes">File Transfer</attribute> + <attribute name="label" translatable="yes">_File Transfer</attribute> <attribute name="action">app.file-transfer</attribute> </item> <item> - <attribute name="label" translatable="yes">History</attribute> + <attribute name="label" translatable="yes">_History</attribute> <attribute name="action">app.history</attribute> </item> </section> </submenu> <submenu> - <attribute name="label" translatable="yes">Help</attribute> + <attribute name="label" translatable="yes">_Help</attribute> <section> <item> - <attribute name="label" translatable="yes">Wiki (Online)</attribute> + <attribute name="label" translatable="yes">_Wiki (Online)</attribute> <attribute name="action">app.content</attribute> </item> <item> - <attribute name="label" translatable="yes">FAQ (Online)</attribute> + <attribute name="label" translatable="yes">FA_Q (Online)</attribute> <attribute name="action">app.faq</attribute> </item> <item> - <attribute name="label" translatable="yes">Keyboard Shortcuts</attribute> + <attribute name="label" translatable="yes">_Keyboard Shortcuts</attribute> <attribute name="action">app.shortcuts</attribute> </item> <item> - <attribute name="label" translatable="yes">Features</attribute> + <attribute name="label" translatable="yes">_Features</attribute> <attribute name="action">app.features</attribute> </item> <item> - <attribute name="label" translatable="yes">About</attribute> + <attribute name="label" translatable="yes">_About</attribute> <attribute name="action">app.about</attribute> </item> </section> View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/7ed48c0f737f72006b6a19395dee0c3f… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/7ed48c0f737f72006b6a19395dee0c3f… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: Roster: Remove reconnect menuitem on groupchats
by Philipp Hörist 17 May '20

17 May '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: e722ac2b by lovetox at 2020-05-17T08:40:25+02:00 Roster: Remove reconnect menuitem on groupchats Fixes #10106 - - - - - 29f7b897 by lovetox at 2020-05-17T20:50:08+02:00 Remove shortcut for Accounts window - - - - - 3 changed files: - gajim/application.py - gajim/data/gui/shortcuts_window.ui - gajim/roster_window.py Changes: ===================================== gajim/application.py ===================================== @@ -554,7 +554,6 @@ class GajimApplication(Gtk.Application): 'app.file-transfer': ['<Primary>T'], 'app.ipython': ['<Primary><Alt>I'], 'app.start-chat::': ['<Primary>N'], - 'app.accounts::': ['<Alt>A'], 'app.create-groupchat::': ['<Primary>G'], 'win.show-roster': ['<Primary>R'], 'win.show-offline': ['<Primary>O'], ===================================== gajim/data/gui/shortcuts_window.ui ===================================== @@ -196,13 +196,6 @@ <property name="title" translatable="yes">Create new group chat</property> </object> </child> - <child> - <object class="GtkShortcutsShortcut"> - <property name="visible">1</property> - <property name="accelerator"><alt>a</property> - <property name="title" translatable="yes">Accounts</property> - </object> - </child> <child> <object class="GtkShortcutsShortcut"> <property name="visible">1</property> ===================================== gajim/roster_window.py ===================================== @@ -2973,15 +2973,6 @@ class RosterWindow: ctrl.leave() self.remove_groupchat(jid, account) - def on_reconnect(self, widget, jid, account): - """ - When reconnect menuitem is activated: join the room - """ - if jid in app.interface.minimized_controls[account]: - ctrl = app.interface.minimized_controls[account][jid] - app.interface.join_gc_room(account, jid, ctrl.nick, - app.gc_passwords.get(jid, '')) - def on_send_single_message_menuitem_activate(self, widget, account, contact=None): if contact is None: @@ -5121,12 +5112,6 @@ class RosterWindow: account) menu.append(rename_menuitem) - if not app.gc_connected[account].get(jid, False): - connect_menuitem = Gtk.MenuItem.new_with_mnemonic(_( - '_Reconnect')) - connect_menuitem.connect('activate', self.on_reconnect, jid, - account) - menu.append(connect_menuitem) disconnect_menuitem = Gtk.MenuItem.new_with_mnemonic(_( '_Leave')) disconnect_menuitem.connect('activate', self.on_disconnect, jid, View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/9b3497de13ba056dacbbbb18cc5a978… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/9b3497de13ba056dacbbbb18cc5a978… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Update gitlab-ci.yml
by Philipp Hörist 16 May '20

16 May '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 9b3497de by lovetox at 2020-05-16T23:16:51+02:00 Update gitlab-ci.yml - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -20,7 +20,7 @@ run-tests: - mypy gajim - scripts/dev/pylint-ci.sh --jobs=2 gajim - python3 -m unittest discover -s test/no_gui -v - - codespell -I codespell.conf gajim + - codespell -I codespell.conf --skip="*__pycache__*,gajim/data/icons,gajim/data/sounds,gajim/data/emoticons" gajim - deactivate - rm -rf civenv-master View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/9b3497de13ba056dacbbbb18cc5a978a… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/9b3497de13ba056dacbbbb18cc5a978a… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: TaskManager: Fix mypy errors
by Philipp Hörist 16 May '20

16 May '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 2ed2dad5 by lovetox at 2020-05-16T23:06:15+02:00 TaskManager: Fix mypy errors - - - - - fa92c548 by lovetox at 2020-05-16T23:06:22+02:00 Update mypy.ini - - - - - 2 changed files: - gajim/common/task_manager.py - mypy.ini Changes: ===================================== gajim/common/task_manager.py ===================================== @@ -30,10 +30,10 @@ class TaskManager: self._timeout = None self._queue = queue.PriorityQueue() - def _start_worker(self): + def _start_worker(self) -> None: self._timeout = GLib.timeout_add_seconds(2, self._process_queue) - def _process_queue(self): + def _process_queue(self) -> bool: log.info('%s tasks queued', self._queue.qsize()) requeue = [] while not self._queue.empty(): @@ -63,7 +63,7 @@ class TaskManager: self._timeout = None return False - def _requeue_tasks(self, tasks: List[Task]): + def _requeue_tasks(self, tasks: List[Task]) -> bool: if not tasks: return False @@ -72,7 +72,7 @@ class TaskManager: self._queue.put_nowait(task) return True - def add_task(self, task: Task): + def add_task(self, task: Task) -> None: log.info('Adding task: %r', task) self._queue.put_nowait(task) if self._timeout is None: @@ -85,20 +85,24 @@ class Task: self.priority = priority self._obsolete = False - def is_obsolete(self): + def is_obsolete(self) -> bool: return self._obsolete - def set_obsolete(self): + def set_obsolete(self) -> None: self._obsolete = True - def __lt__(self, task: Task): - return self.priority < task.priority + def __lt__(self, other: object) -> bool: + if not isinstance(other, Task): + raise NotImplementedError + return self.priority < other.priority - def __eq__(self, task: Task): - return task.priority == self.priority + def __eq__(self, other: object) -> bool: + if not isinstance(other, Task): + raise NotImplementedError + return other.priority == self.priority - def execute(self): + def execute(self) -> None: raise NotImplementedError - def preconditions_met(self): + def preconditions_met(self) -> bool: raise NotImplementedError ===================================== mypy.ini ===================================== @@ -69,3 +69,6 @@ ignore_missing_imports = True [mypy-cairo.*] ignore_missing_imports = True + +[mypy-packaging.version.*] +ignore_missing_imports = True View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/afef11e81c7e31359a05440d80d9893… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/afef11e81c7e31359a05440d80d9893… You're receiving this email because of your account on dev.gajim.org.

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits May 2020