Philipp Hörist pushed to branch master at gajim / gajim
Commits:
12d9b099 by André Apitzsch at 2020-05-25T21:58:22+02:00
Gspell: Use default language if requested one is missing
The default language cannot be `None` if `app.is_installed('GSPELL')` is `True`,
because to be `True` at least one language needs to be available.
If `app.is_installed('GSPELL')` is `False`, the modified code is not called.
- - - - -
5 changed files:
- gajim/chat_control_base.py
- gajim/dialogs.py
- gajim/gtk/dialogs.py
- gajim/gtk/preferences.py
- gajim/gtk/single_message.py
Changes:
=====================================
gajim/chat_control_base.py
=====================================
@@ -621,9 +621,6 @@ class ChatControlBase(ChatCommandProcessor, CommandTools, EventHelper):
return
gspell_lang = self.get_speller_language()
- if gspell_lang is None:
- return
-
spell_checker = Gspell.Checker.new(gspell_lang)
spell_buffer = Gspell.TextBuffer.get_from_gtk_text_buffer(
self.msg_textview.get_buffer())
=====================================
gajim/dialogs.py
=====================================
@@ -48,7 +48,6 @@ from gajim.gtk.dialogs import DialogButton
from gajim.gtk.dialogs import NewConfirmationDialog
from gajim.gtk.dialogs import ErrorDialog
from gajim.gtk.dialogs import InputDialog
-from gajim.gtk.dialogs import AspellDictError
from gajim.gtk.util import get_icon_name
from gajim.gtk.util import get_builder
from gajim.gtk.util import get_activity_icon_name
@@ -499,15 +498,14 @@ class ChangeStatusMessageDialog(TimeoutDialog):
lang = app.config.get('speller_language')
gspell_lang = Gspell.language_lookup(lang)
if gspell_lang is None:
- AspellDictError(lang)
- else:
- spell_buffer = Gspell.TextBuffer.get_from_gtk_text_buffer(
- self.message_buffer)
- spell_buffer.set_spell_checker(Gspell.Checker.new(gspell_lang))
- spell_view = Gspell.TextView.get_from_gtk_text_view(
- message_textview)
- spell_view.set_inline_spell_checking(True)
- spell_view.set_enable_language_menu(True)
+ gspell_lang = Gspell.language_get_default()
+ spell_buffer = Gspell.TextBuffer.get_from_gtk_text_buffer(
+ self.message_buffer)
+ spell_buffer.set_spell_checker(Gspell.Checker.new(gspell_lang))
+ spell_view = Gspell.TextView.get_from_gtk_text_view(
+ message_textview)
+ spell_view.set_inline_spell_checking(True)
+ spell_view.set_enable_language_menu(True)
self.message_buffer.connect('changed', self.on_message_buffer_changed)
if not msg:
=====================================
gajim/gtk/dialogs.py
=====================================
@@ -142,16 +142,6 @@ class HigDialog(Gtk.MessageDialog):
self.show_all()
-class AspellDictError:
- def __init__(self, lang):
- ErrorDialog(
- _('Dictionary for language "%s" not available') % lang,
- _('You have to install the dictionary "%s" to use spellchecking, '
- 'or choose another language by setting the speller_language '
- 'option.\n\n'
- 'Highlighting misspelled words feature will not be used') % lang)
-
-
class WarningDialog(HigDialog):
"""
HIG compliant warning dialog
=====================================
gajim/gtk/preferences.py
=====================================
@@ -44,7 +44,6 @@ from gajim.gtk.util import get_builder
from gajim.gtk.util import get_icon_name
from gajim.gtk.util import get_available_iconsets
from gajim.gtk.util import open_window
-from gajim.gtk.dialogs import AspellDictError
from gajim.gtk.sounds import ManageSounds
from gajim.gtk.const import ControlType
from gajim.gtk import gstreamer
@@ -638,13 +637,8 @@ class Preferences(Gtk.ApplicationWindow):
gspell_lang = Gspell.language_lookup(lang)
if gspell_lang is None:
gspell_lang = Gspell.language_get_default()
- if gspell_lang is None:
- AspellDictError(lang)
- app.config.set('use_speller', False)
- widget.set_active(False)
- else:
- app.config.set('speller_language', gspell_lang.get_code())
- self.apply_speller()
+ app.config.set('speller_language', gspell_lang.get_code())
+ self.apply_speller()
def apply_speller(self):
for ctrl in self._get_all_controls():
=====================================
gajim/gtk/single_message.py
=====================================
@@ -27,7 +27,6 @@ from gajim.common.structs import OutgoingMessage
from gajim.conversation_textview import ConversationTextview
from gajim.gtk.dialogs import ErrorDialog
-from gajim.gtk.dialogs import AspellDictError
from gajim.gtk.util import get_builder
from gajim.gtk.util import get_icon_name
from gajim.gtk.util import get_completion_liststore
@@ -86,15 +85,14 @@ class SingleMessageWindow(Gtk.ApplicationWindow):
lang = app.config.get('speller_language')
gspell_lang = Gspell.language_lookup(lang)
if gspell_lang is None:
- AspellDictError(lang)
- else:
- spell_buffer = Gspell.TextBuffer.get_from_gtk_text_buffer(
- self._ui.message_textview.get_buffer())
- spell_buffer.set_spell_checker(Gspell.Checker.new(gspell_lang))
- spell_view = Gspell.TextView.get_from_gtk_text_view(
- self._ui.message_textview)
- spell_view.set_inline_spell_checking(True)
- spell_view.set_enable_language_menu(True)
+ gspell_lang = Gspell.language_get_default()
+ spell_buffer = Gspell.TextBuffer.get_from_gtk_text_buffer(
+ self._ui.message_textview.get_buffer())
+ spell_buffer.set_spell_checker(Gspell.Checker.new(gspell_lang))
+ spell_view = Gspell.TextView.get_from_gtk_text_view(
+ self._ui.message_textview)
+ spell_view.set_inline_spell_checking(True)
+ spell_view.set_enable_language_menu(True)
self._prepare_widgets_for(self._action)
View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/12d9b099057ce56bd694eb8345c4e323…
--
View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/12d9b099057ce56bd694eb8345c4e323…
You're receiving this email because of your account on dev.gajim.org.
Philipp Hörist pushed to branch master at gajim / gajim
Commits:
7d953d61 by lovetox at 2020-05-21T22:39:13+02:00
Fix codespell errors
- - - - -
2 changed files:
- gajim/common/logger.py
- gajim/roster_window.py
Changes:
=====================================
gajim/common/logger.py
=====================================
@@ -1113,7 +1113,7 @@ class Logger:
roster is the new version.
"""
# First we must reset roster_version value to ensure that the server
- # sends back all the roster at the next connexion if the replacement
+ # sends back all the roster at the next connection if the replacement
# didn't work properly.
app.config.set_per('accounts', account_name, 'roster_version', '')
=====================================
gajim/roster_window.py
=====================================
@@ -5356,7 +5356,7 @@ class RosterWindow:
self.starting_filtering = False
# Number of renderers plugins added
self.nb_ext_renderers = 0
- # When we quit, rememver if we already saved config once
+ # When we quit, remember if we already saved config once
self.save_done = False
# [icon, name, type, jid, account, editable, mood_pixbuf,
View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/7d953d6102149da733ac8e0c48e73c02…
--
View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/7d953d6102149da733ac8e0c48e73c02…
You're receiving this email because of your account on dev.gajim.org.