Philipp Hörist pushed to branch master at gajim / gajim

Commits: 0dce40bb by Tomasz Miąsko at 2017-01-24T15:29:15+01:00 Fix history scrolling in gtk3 #8481.

* Delay scrolling using GLib.idle_add. According to the GTK documentation the scroll_to_mark should be doing this internally already, but it is not the case.

* Center highlighted message vertically.

- - - - - d2cfa9bb by Philipp Hörist at 2017-01-24T16:24:32+01:00 Merge branch 'history-scrolling' into 'master'

Fix history scrolling in gtk3 #8481.

See merge request !39 - - - - -

1 changed file:

- src/history_window.py

Changes:

===================================== src/history_window.py ===================================== --- a/src/history_window.py +++ b/src/history_window.py @@ -622,10 +622,9 @@ class HistoryWindow: match_end_iter.forward_line() # highlight all message not just time self.history_buffer.apply_tag_by_name('highlight', match_start_iter, match_end_iter) - - match_start_mark = self.history_buffer.create_mark('match_start', - match_start_iter, True) - self.history_textview.tv.scroll_to_mark(match_start_mark, 0, True) + mark = self.history_buffer.create_mark('match', match_start_iter, True) + GLib.idle_add(self.history_textview.tv.scroll_to_mark, mark, + 0, True, 0.0, 0.5)

def on_log_history_checkbutton_toggled(self, widget): # log conversation history?

View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/a779066a61b29e22a67139eab5bcf99969...