Philipp Hörist pushed to branch master at gajim / gajim

Commits: 76333ec7 by Philipp Hörist at 2018-09-17T20:51:42Z Use keys() iteration if we modify the dict

- - - - -

3 changed files:

- gajim/common/zeroconf/zeroconf_avahi.py - gajim/common/zeroconf/zeroconf_bonjour.py - gajim/message_window.py

Changes:

===================================== gajim/common/zeroconf/zeroconf_avahi.py ===================================== --- a/gajim/common/zeroconf/zeroconf_avahi.py +++ b/gajim/common/zeroconf/zeroconf_avahi.py @@ -89,7 +89,7 @@ class Zeroconf: if not self.connected: return if name != self.name: - for key in self.contacts: + for key in self.contacts.keys(): # pylint: disable=C0201 val = self.contacts[key] if val[Constant.BARE_NAME] == name: # try to reduce instead of delete first

===================================== gajim/common/zeroconf/zeroconf_bonjour.py ===================================== --- a/gajim/common/zeroconf/zeroconf_bonjour.py +++ b/gajim/common/zeroconf/zeroconf_bonjour.py @@ -98,7 +98,7 @@ class Zeroconf: if not self.connected: return if name != self.name: - for key in self.contacts: + for key in self.contacts.keys(): # pylint: disable=C0201 if self.contacts[key][Constant.NAME] == name: del self.contacts[key] self.remove_serviceCB(key)

===================================== gajim/message_window.py ===================================== --- a/gajim/message_window.py +++ b/gajim/message_window.py @@ -1107,7 +1107,7 @@ class MessageWindowMgr(GObject.GObject): return False

def _on_window_destroy(self, win): - for k in self._windows: + for k in self._windows.keys(): # pylint: disable=C0201 if self._windows[k].window == win: self.emit('window-delete', self._windows[k]) del self._windows[k]

View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/76333ec73a4453f6ce33d006e711f302d4b...