Daniel Brötzmann pushed to branch master at gajim / gajim

Commits: 26b53576 by wurstsalat at 2022-02-03T14:02:52+01:00 GroupchatDetails: Fix finalizing

- - - - - e9a56ab2 by wurstsalat at 2022-02-03T14:15:28+01:00 XMLConsole: Fix leak

- - - - -

2 changed files:

- gajim/gtk/groupchat_details.py - gajim/gtk/xml_console.py

Changes:

===================================== gajim/gtk/groupchat_details.py ===================================== @@ -174,4 +174,7 @@ def _on_key_press(self, self.destroy()

def _on_destroy(self, _widget: GroupchatDetails) -> None: + app.ged.remove_event_handler('muc-disco-update', + ged.GUI1, + self._on_muc_disco_update) app.check_finalize(self)

===================================== gajim/gtk/xml_console.py ===================================== @@ -99,6 +99,7 @@ def __init__(self) -> None: self.show_all()

self.connect('key_press_event', self._on_key_press) + self.connect('destroy', self._on_destroy) self._ui.connect_signals(self)

self.register_events([ @@ -107,6 +108,10 @@ def __init__(self) -> None: ('style-changed', ged.GUI1, self._on_style_changed) ])

+ def _on_destroy(self, *args: Any) -> None: + self._ui.popover.destroy() + app.check_finalize(self) + def _get_style_scheme(self) -> Optional[GtkSource.StyleScheme]: if app.css_config.prefer_dark: style_scheme = self._style_scheme_manager.get_scheme( @@ -227,7 +232,8 @@ def _on_send(self, *args: Any) -> None: # stream management node = nbxmpp.Protocol(node=stanza, attrs={'xmlns': 'jabber:client'}) - app.connections[self._selected_send_account].connection.send(node) + client = app.get_client(self._selected_send_account) + client.connection.send(node) self.last_stanza = stanza buffer_.set_text('')

View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/49b4a0673c4a9d5cf7f309d1786f9ffe...