Philipp Hörist pushed to branch master at gajim / gajim

Commits: dcf7c1a3 by Dexter Gaon-Shatford at 2022-06-12T19:24:12+00:00 fix: Groupchat: Show correct icon when toggling roster revealer

Fixes #10944

- - - - -

1 changed file:

- gajim/gtk/controls/groupchat.py

Changes:

===================================== gajim/gtk/controls/groupchat.py ===================================== @@ -126,14 +126,14 @@ def __init__(self, account: str, jid: JID) -> None:

show_roster = app.settings.get('hide_groupchat_occupants_list') self.xml.roster_revealer.set_reveal_child(show_roster) - icon = 'go-next-symbolic' if show_roster else 'go-previous-symbolic' - self.xml.toggle_roster_image.set_from_icon_name( - icon, Gtk.IconSize.BUTTON) - app.settings.bind_signal( 'hide_groupchat_occupants_list', self.xml.roster_revealer, 'set_reveal_child') + self._set_toggle_roster_button_icon(show_roster) + app.settings.connect_signal( + 'hide_groupchat_occupants_list', + self._set_toggle_roster_button_icon) self.roster.connect('row-activated', self._on_roster_row_activated)

self.add_actions() @@ -522,12 +522,17 @@ def _on_change_affiliation(self, self.room_jid, {jid: {'affiliation': affiliation}})

- def _show_roster(self, *args: Any) -> None: - show = not self.xml.roster_revealer.get_reveal_child() - icon = 'go-next-symbolic' if show else 'go-previous-symbolic' + def _set_toggle_roster_button_icon(self, + show_roster: bool, + *args: Any) -> None: + icon = 'go-next-symbolic' if show_roster else 'go-previous-symbolic' self.xml.toggle_roster_image.set_from_icon_name( icon, Gtk.IconSize.BUTTON)

+ def _show_roster(self, *args: Any) -> None: + show = not self.xml.roster_revealer.get_reveal_child() + self._set_toggle_roster_button_icon(show) + transition = Gtk.RevealerTransitionType.SLIDE_RIGHT if show: transition = Gtk.RevealerTransitionType.SLIDE_LEFT

View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/dcf7c1a317ef801d8139639bddaa2892c...