Commits

commits@gajim.org

17632 discussions

[Git][gajim/gajim][master] fix: Don’t fail when disabling accounts
by Philipp Hörist (＠lovetox) 09 Oct '22

09 Oct '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: f12cf65e by Philipp Hörist at 2022-10-09T13:38:51+02:00 fix: Don’t fail when disabling accounts Fixes #11199 - - - - - 1 changed file: - gajim/gui_interface.py Changes: ===================================== gajim/gui_interface.py ===================================== @@ -563,6 +563,9 @@ def disable_account(self, account: str) -> None: build_accounts_menu() app.app.update_app_actions_state() + # Code in account-disabled handlers may use app.get_client() + app.ged.raise_event(AccountDisabled(account=account)) + app.get_client(account).cleanup() del app.connections[account] del self.instances[account] @@ -570,8 +573,6 @@ def disable_account(self, account: str) -> None: del app.automatic_rooms[account] del app.to_be_removed[account] - app.ged.raise_event(AccountDisabled(account=account)) - def remove_account(self, account: str) -> None: if app.settings.get_account_setting(account, 'active'): self.disable_account(account) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/f12cf65e8c44105b3689d55195834751… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/f12cf65e8c44105b3689d55195834751… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: refactor: Remove usage of get_number_of_accounts()
by Philipp Hörist (＠lovetox) 09 Oct '22

09 Oct '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: bec58992 by Philipp Hörist at 2022-10-09T13:20:05+02:00 refactor: Remove usage of get_number_of_accounts() - - - - - 23d5b164 by Philipp Hörist at 2022-10-09T13:20:05+02:00 refactor: MAM: Use only timezone aware datetime objects - - - - - 4 changed files: - gajim/common/app.py - gajim/common/modules/mam.py - gajim/gtk/account_side_bar.py - gajim/gtk/chat_banner.py Changes: ===================================== gajim/common/app.py ===================================== @@ -341,13 +341,6 @@ def get_jid_without_resource(jid: str) -> str: return jid.split('/')[0] -def get_number_of_accounts() -> int: - ''' - Return the number of ALL accounts - ''' - return len(connections.keys()) - - def get_number_of_connected_accounts( accounts_list: Optional[list[str]] = None) -> int: ''' ===================================== gajim/common/modules/mam.py ===================================== @@ -22,6 +22,7 @@ import time from datetime import datetime from datetime import timedelta +from datetime import timezone import nbxmpp from nbxmpp.errors import StanzaError @@ -356,7 +357,7 @@ def _get_query_params(self) -> tuple[Optional[ſtr], Optional[datetime]]: else: # First Start, we request the last week - start_date = datetime.utcnow() - timedelta(days=7) + start_date = datetime.now(timezone.utc) - timedelta(days=7) self._log.info('Request archive: %s, after date %s', own_jid, start_date) return mam_id, start_date @@ -365,13 +366,15 @@ def _get_muc_query_params(self, jid: JID, threshold: SyncThreshold ) -> tuple[Optional[str], Optional[datetime]]: + archive = app.storage.archive.get_archive_infos(jid) mam_id = None start_date = None + now = datetime.now(timezone.utc) if archive is None or archive.last_mam_id is None: # First join - start_date = datetime.utcnow() - timedelta(days=1) + start_date = now - timedelta(days=1) self._log.info('Request archive: %s, after date %s', jid, start_date) @@ -390,10 +393,10 @@ def _get_muc_query_params(self, self._log.info('No last muc timestamp found: %s', jid) last_timestamp = 0 - last = datetime.utcfromtimestamp(float(last_timestamp)) - if datetime.utcnow() - last > timedelta(days=threshold): + last = datetime.fromtimestamp(float(last_timestamp), timezone.utc) + if now - last > timedelta(days=threshold): # To much time has elapsed since last join, apply threshold - start_date = datetime.utcnow() - timedelta(days=threshold) + start_date = now - timedelta(days=threshold) self._log.info('Too much time elapsed since last join, ' 'request archive: %s, after date %s, ' 'threshold: %s', jid, start_date, threshold) ===================================== gajim/gtk/account_side_bar.py ===================================== @@ -136,7 +136,7 @@ def set_unread_count(self, count: int) -> None: self._unread_label.set_visible(bool(count)) def _update_account_color_visibility(self, *args: Any) -> None: - visible = app.get_number_of_accounts() > 1 + visible = len(app.settings.get_active_accounts()) > 1 self._account_color_bar.set_visible(visible) ===================================== gajim/gtk/chat_banner.py ===================================== @@ -314,7 +314,7 @@ def _update_account_badge(self) -> None: self._account_badge.set_visible(False) return - visible = app.get_number_of_accounts() > 1 + visible = len(app.settings.get_active_accounts()) > 1 if visible: self._account_badge.set_account(self._contact.account) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/61fec3e4037536c42fa3e83e4ad19f3… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/61fec3e4037536c42fa3e83e4ad19f3… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] cfix: AccountPage: React to avatar changes
by Daniel Brötzmann (＠wurstsalat) 09 Oct '22

09 Oct '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 61fec3e4 by wurstsalat at 2022-10-09T12:11:48+02:00 cfix: AccountPage: React to avatar changes - - - - - 1 changed file: - gajim/gtk/account_page.py Changes: ===================================== gajim/gtk/account_page.py ===================================== @@ -14,6 +14,7 @@ from __future__ import annotations +from typing import Any from typing import Union from gi.repository import Gdk @@ -57,6 +58,7 @@ def __init__(self, account: str) -> None: self._jid = app.get_jid_from_account(account) client = app.get_client(account) self._contact = client.get_module('Contacts').get_contact(self._jid) + self._contact.connect('avatar-update', self._on_avatar_update) self._ui = get_builder('account_page.ui') self.add(self._ui.paned) @@ -104,6 +106,9 @@ def __init__(self, account: str) -> None: def _on_destroy(self, _widget: AccountPage) -> None: app.check_finalize(self) + def _on_avatar_update(self, *args: Any) -> None: + self.update() + def _on_edit_profile(self, _button: Gtk.Button) -> None: open_window('ProfileWindow', account=self._account) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/61fec3e4037536c42fa3e83e4ad19f3a… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/61fec3e4037536c42fa3e83e4ad19f3a… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] cfix: Preview: Try to create GdKPixbuf loader with fixed mime-type
by Daniel Brötzmann (＠wurstsalat) 09 Oct '22

09 Oct '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: c1e41f53 by wurstsalat at 2022-10-09T12:02:17+02:00 cfix: Preview: Try to create GdKPixbuf loader with fixed mime-type This fixes mime-type detection problems for HEIF images on some systems - - - - - 2 changed files: - gajim/common/preview.py - gajim/common/preview_helpers.py Changes: ===================================== gajim/common/preview.py ===================================== @@ -157,7 +157,7 @@ def orig_exists(self) -> bool: return self.orig_path.exists() def create_thumbnail(self, data: bytes) -> bool: - self.thumbnail = create_thumbnail(data, self.size) + self.thumbnail = create_thumbnail(data, self.size, self.mime_type) if self.thumbnail is None: self.info_message = _('Creating thumbnail failed') log.warning('Creating thumbnail failed for: %s', self.orig_path) ===================================== gajim/common/preview_helpers.py ===================================== @@ -147,15 +147,31 @@ def extract_and_resize_frames(image: Image.Image, return frames, result -def create_thumbnail(data: bytes, size: int) -> Optional[bytes]: +def create_thumbnail(data: bytes, + size: int, + mime_type: str + ) -> Optional[bytes]: + thumbnail = create_thumbnail_with_pil(data, size) if thumbnail is not None: return thumbnail - return create_thumbnail_with_pixbuf(data, size) + return create_thumbnail_with_pixbuf(data, size, mime_type) -def create_thumbnail_with_pixbuf(data: bytes, size: int) -> Optional[bytes]: - loader = GdkPixbuf.PixbufLoader() +def create_thumbnail_with_pixbuf(data: bytes, + size: int, + mime_type: str + ) -> Optional[bytes]: + + try: + # Try to create GdKPixbuf loader with fixed mime-type to + # fix mime-type detection for HEIF images on some systems + loader = GdkPixbuf.PixbufLoader.new_with_mime_type(mime_type) + except GLib.Error as error: + log.warning('Creating pixbuf loader with mime ' + 'type %s failed: %s', mime_type, error) + loader = GdkPixbuf.PixbufLoader() + try: loader.write(data) loader.close() View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/c1e41f53afce030e18c0fc6cdc3dc575… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/c1e41f53afce030e18c0fc6cdc3dc575… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] cfix: DND: Un-highlight rows correctly, transfer source workspace
by Daniel Brötzmann (＠wurstsalat) 09 Oct '22

09 Oct '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 167ea289 by wurstsalat at 2022-10-09T11:25:40+02:00 cfix: DND: Un-highlight rows correctly, transfer source workspace - - - - - 2 changed files: - gajim/gtk/chat_list_row.py - gajim/gtk/workspace_side_bar.py Changes: ===================================== gajim/gtk/chat_list_row.py ===================================== @@ -428,15 +428,16 @@ def _on_drag_end(self, app.window.highlight_dnd_targets(row, False) def _on_drag_data_get(self, - _widget: Gtk.Widget, + row: ChatListRow, _drag_context: Gdk.DragContext, selection_data: Gtk.SelectionData, _info: int, _time: int ) -> None: + app.window.highlight_dnd_targets(row, False) drop_type = Gdk.Atom.intern_static_string('CHAT_LIST_ITEM') - byte_data = pickle.dumps((self.account, self.jid)) + byte_data = pickle.dumps((self.account, self.jid, self.workspace_id)) selection_data.set(drop_type, 8, byte_data) def _connect_contact_signals(self) -> None: ===================================== gajim/gtk/workspace_side_bar.py ===================================== @@ -122,8 +122,9 @@ def _on_drag_data_received(self, if item_type == 'WORKSPACE_SIDEBAR_ITEM': self._process_workspace_drop(data.decode('utf-8')) elif item_type == 'CHAT_LIST_ITEM': - account, jid = pickle.loads(data) - self._process_chat_list_drop(account, jid, y_coord) + account, jid, source_workspace = pickle.loads(data) + self._process_chat_list_drop( + account, jid, source_workspace, y_coord) else: log.debug('Unknown item type dropped') @@ -151,6 +152,7 @@ def _process_workspace_drop(self, workspace_id: str) -> None: def _process_chat_list_drop(self, account: str, jid: JID, + source_workspace: str, y_coord: int) -> None: workspace_row = cast(Workspace, self.get_row_at_y(y_coord)) @@ -159,8 +161,6 @@ def _process_chat_list_drop(self, if workspace_row.workspace_id == 'add': workspace_id = '' - source_workspace = app.window.get_active_workspace() - assert source_workspace is not None params = ChatListEntryParam(workspace_id=workspace_id, source_workspace_id=source_workspace, account=account, View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/167ea2890c82b0b96a2c12c1d33876d4… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/167ea2890c82b0b96a2c12c1d33876d4… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim] Pushed new branch avatar-color-fix
by Daniel Brötzmann (＠wurstsalat) 08 Oct '22

08 Oct '22

Daniel Brötzmann pushed new branch avatar-color-fix at gajim / gajim -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/tree/avatar-color-fix You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim] Pushed new branch workspace-mark-as-read
by Daniel Brötzmann (＠wurstsalat) 08 Oct '22

08 Oct '22

Daniel Brötzmann pushed new branch workspace-mark-as-read at gajim / gajim -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/tree/workspace-mark-as-read You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim] Pushed new tag 1.5.2
by Philipp Hörist (＠lovetox) 08 Oct '22

08 Oct '22

Philipp Hörist pushed new tag 1.5.2 at gajim / gajim -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/tree/1.5.2 You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] release: 1.5.2
by Philipp Hörist (＠lovetox) 08 Oct '22

08 Oct '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: fe698091 by Philipp Hörist at 2022-10-08T16:54:07+02:00 release: 1.5.2 - - - - - 4 changed files: - ChangeLog - data/org.gajim.Gajim.appdata.xml.in - flatpak/org.gajim.Gajim.yaml - gajim/__init__.py Changes: ===================================== ChangeLog ===================================== @@ -1,3 +1,60 @@ +Gajim 1.5.2 (08 Oct 2022) + + New + + * PEPConfig: Add PEP item view + * Add shortcut to restore chats after closing (#11088) + * ServerInfo: Add TLS version and cipher suite + + Improvements + + * XMLConsole: Apply account filter to all visible stanzas (#11193) + * Features dialog: Simplify statements on Windows + * MessageRow: Set text direction for RTL text (#11148) + * AvatarSelector: Add border to mark drag and drop zone + * Drag and drop: Highlight target areas (#11173) + * GroupChatNickCompletion: Simplify suggestions (#11155) + * MUC: Add participant menu to avatar + * StartChat: Add timeout when requesting MUC disco info + * StartChat: Pass message body from XMPP URI (#11140) + * Windows: Ellipsize body text in notifications + * Emojis: Improve shortcode usability + * Avatars: Use PangoCairo for generate_avatar (#10960) + * Emojis: Extract codepoints for all emoji variants + + Change + + * Raise nbxmpp version + * Show account color bar only when multiple accounts are active + + Performance + + * Remove queue_resize leftover from MessageTextView + * SearchView: Update calendar only if widget is visible + * SearchView: Speed up clearing of search results (#11158) + * Styling: Parse emojis for Darwin only + + Bug Fixes + + * Control: Load events before messages (#11129) + * Fix disabling accounts while reconnecting (#11194) + * Use custom icon for 'Send Message' action + * MessageActionsBox: Don’t fail if no contact is set while updating file actions + * Scroll to end after sending message (#10871) + * Update chat actions when account state changes (#11184) + * StatusIcon: Reset unread state correctly when using Flatpak (#11069) + * Notifications: Show correct message sender for MUC notifications (#11177) + * Discovery: Don’t allow to join top level components (#11175) + * ChatList: Show context menu in correct position (#11165) + * Styling: Allow dots in local part of email addresses + * ChatList: Set message_id correctly (#11168) + * Notifications: React to incoming group chat messages (#11161) + * When removing a chat, clear view only if it's currently loaded (#11164) + * AccountPage: Disable Ad-Hoc Commands button when offline (#11167) + * CreateGroupchatWindow: Fix Create button state when switching MUC type (#11162) + * React correctly to UserAvatar updates (#11065) + * GajimRemote: Remove not needed shebang + Gajim 1.5.1 (19 Sep 2022) Bug Fixes ===================================== data/org.gajim.Gajim.appdata.xml.in ===================================== @@ -74,6 +74,7 @@ <control>pointing</control> </recommends> <releases> + <release version="1.5.2" date="2022-10-08" /> <release version="1.5.1" date="2022-09-19" /> <release version="1.5.0" date="2022-09-19" /> <release version="1.4.7" date="2022-07-24" /> ===================================== flatpak/org.gajim.Gajim.yaml ===================================== @@ -331,7 +331,7 @@ modules: sources: - type: git url: https://dev.gajim.org/gajim/gajim.git - tag: 1.5.1 + tag: 1.5.2 - type: file path: app-overrides.json post-install: ===================================== gajim/__init__.py ===================================== @@ -1,7 +1,7 @@ import sys from pathlib import Path -__version__ = '1.5.1' +__version__ = '1.5.2' IS_FLATPAK = Path('/app/share/run-as-flatpak').exists() View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/fe698091044ccc85ffbfd831622383b4… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/fe698091044ccc85ffbfd831622383b4… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] change: Raise nbxmpp version
by Philipp Hörist (＠lovetox) 08 Oct '22

08 Oct '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: a4c6aacf by Philipp Hörist at 2022-10-08T16:49:02+02:00 change: Raise nbxmpp version - - - - - 4 changed files: - README.md - flatpak/org.gajim.Gajim.yaml - gajim/gajim.py - setup.cfg Changes: ===================================== README.md ===================================== @@ -6,7 +6,7 @@ ### Runtime Requirements - [PyGObject](https://pypi.org/project/PyGObject/) (>=3.42.0) - [pycairo](https://pypi.org/project/pycairo/) - [cairo](https://gitlab.freedesktop.org/cairo/cairo) (>=1.16.0) -- [nbxmpp](https://pypi.org/project/nbxmpp/) (>=3.2.2) +- [nbxmpp](https://pypi.org/project/nbxmpp/) (>=3.2.4) - [pyOpenSSL](https://pypi.org/project/pyOpenSSL/) (>=16.2) - [css-parser](https://pypi.org/project/css-parser/) - [keyring](https://pypi.org/project/keyring/) ===================================== flatpak/org.gajim.Gajim.yaml ===================================== @@ -316,11 +316,11 @@ modules: - name: python3-nbxmpp buildsystem: simple build-commands: - - pip3 install nbxmpp-3.2.2-py3-none-any.whl + - pip3 install nbxmpp-3.2.4-py3-none-any.whl sources: - type: file - url: https://files.pythonhosted.org/packages/py3/n/nbxmpp/nbxmpp-3.2.2-py3-none-… - sha256: 5e519aa1a87d5ffac1acdc7ad4863847755acbed27ba678152a98f98bddc9011 + url: https://files.pythonhosted.org/packages/py3/n/nbxmpp/nbxmpp-3.2.4-py3-none-… + sha256: 46394624acdced9cd83c06a665a109d74132642cd3f8e427a197465aabcbf42e - name: gajim buildsystem: simple ===================================== gajim/gajim.py ===================================== @@ -30,7 +30,7 @@ import gajim.gui -_MIN_NBXMPP_VER = '3.2.2' +_MIN_NBXMPP_VER = '3.2.4' _MIN_GTK_VER = '3.24.30' _MIN_CAIRO_VER = '1.16.0' _MIN_PYGOBJECT_VER = '3.42.0' ===================================== setup.cfg ===================================== @@ -39,7 +39,7 @@ test_suite = test install_requires = css-parser keyring - nbxmpp>=3.2.2,<4.0.0 + nbxmpp>=3.2.4,<4.0.0 packaging pillow precis-i18n>=1.0.0 View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/a4c6aacfcbd42b7dc8b8403f7e8ab22d… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/a4c6aacfcbd42b7dc8b8403f7e8ab22d… You're receiving this email because of your account on dev.gajim.org.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits