Commits

commits@gajim.org

17632 discussions

[Git][gajim/gajim][master] fix: GUI tests: Adapt GUI tests to Gajim changes
by Daniel Brötzmann (＠wurstsalat) 27 Nov '22

27 Nov '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: bd8b229b by wurstsalat at 2022-11-27T16:45:56+01:00 fix: GUI tests: Adapt GUI tests to Gajim changes - - - - - 5 changed files: - README.md - test/gtk/change_password.py - test/gtk/dataform.py - test/gtk/fake_dataform.py - test/gtk/groupchat_info.py Changes: ===================================== README.md ===================================== @@ -47,7 +47,8 @@ ### Compile-time Requirements ### Running Tests -`python -m unittest discover -s test` +- `python -m unittest discover -s test` (no_gui directory) +- `python -m unittest ./test/gtk/gui_file.py` (gtk directory) ### Installation Procedure ===================================== test/gtk/change_password.py ===================================== @@ -1,3 +1,5 @@ +from unittest.mock import MagicMock + from functools import partial import gi @@ -12,11 +14,15 @@ from gajim import gui gui.init('gtk') +from gajim.common import app + from gajim.gui.change_password import ChangePassword from test.gtk import util util.load_style('gajim.css', CSSPriority.APPLICATION) +app.get_client = MagicMock() + fields = [ create_field(typ='text-single', label='Username', var='username'), create_field(typ='text-single', label='Old Password', var='old_password'), ===================================== test/gtk/dataform.py ===================================== @@ -1,6 +1,11 @@ +from unittest.mock import MagicMock + from base64 import b64decode +import gi +gi.require_version('Gtk', '3.0') from gi.repository import Gtk + import nbxmpp from nbxmpp.modules.dataforms import extend_form @@ -42,6 +47,8 @@ TEtMDRUMjM6NTA6NDQrMDE6MDBAxMf7AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDE4LTExLTA0VDIzOjUwOjQ0KzAxOjAwMZl/RwAAAABJRU5ErkJggg==''' app.bob_cache['sha1+8f35fef110ffc5df08d579a50083ff9308fb6242'] = b64decode(image) +app.css_config = MagicMock() +app.css_config.get_value = MagicMock(return_value='rgb(100, 100, 255)') FORM = ''' <x xmlns='jabber:x:data' type='form'> ===================================== test/gtk/fake_dataform.py ===================================== @@ -1,11 +1,14 @@ +import gi +gi.require_version('Gtk', '3.0') from gi.repository import Gtk from gajim import gui gui.init('gtk') -from gajim.gui.dataform import FakeDataFormWidget from gajim.common.const import CSSPriority +from gajim.gui.dataform import FakeDataFormWidget + from test.gtk import util util.load_style('gajim.css', CSSPriority.APPLICATION) @@ -45,6 +48,6 @@ def __init__(self): self.show() win = DataFormWindow() -win.connect("destroy", Gtk.main_quit) +win.connect('destroy', Gtk.main_quit) win.show_all() Gtk.main() ===================================== test/gtk/groupchat_info.py ===================================== @@ -1,3 +1,5 @@ +from unittest.mock import MagicMock + import time import gi @@ -8,6 +10,7 @@ from nbxmpp.modules.discovery import parse_disco_info from nbxmpp.structs import MucSubject +from gajim.common import app from gajim.common.const import CSSPriority from gajim import gui @@ -93,6 +96,9 @@ disco_info = parse_disco_info(stanza) +app.css_config = MagicMock() +app.css_config.get_value = MagicMock(return_value='rgb(100, 100, 255)') + class GroupchatInfo(Gtk.ApplicationWindow): def __init__(self): Gtk.ApplicationWindow.__init__(self) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/bd8b229b474adb038903b65a373c9108… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/bd8b229b474adb038903b65a373c9108… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] cfix: Menus: Add ellipsis to Save as… preview menu item
by Daniel Brötzmann (＠wurstsalat) 27 Nov '22

27 Nov '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 1c327c75 by wurstsalat at 2022-11-27T15:02:17+01:00 cfix: Menus: Add ellipsis to Save as… preview menu item - - - - - 1 changed file: - gajim/gtk/menus.py Changes: ===================================== gajim/gtk/menus.py ===================================== @@ -678,7 +678,7 @@ def get_preview_menu(preview: Preview) -> GajimMenu: download = (_('_Download'), 'win.preview-download', variant) open_file = (_('_Open'), 'win.preview-open', variant) - save_as = (_('_Save as'), 'win.preview-save-as', variant) + save_as = (_('_Save as…'), 'win.preview-save-as', variant) open_folder = (_('Open _Folder'), 'win.preview-open-folder', variant) copy_link = (_('_Copy Link'), 'win.preview-copy-link', variant) open_link = (_('Open Link in _Browser'), 'win.preview-open-link', variant) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/1c327c753922b730396ae8b2e36c7502… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/1c327c753922b730396ae8b2e36c7502… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][cert-convert-cryptography] 3 commits: chore: Update pyright config
by Daniel Brötzmann (＠wurstsalat) 27 Nov '22

27 Nov '22

Daniel Brötzmann pushed to branch cert-convert-cryptography at gajim / gajim Commits: df1b8a56 by wurstsalat at 2022-11-27T14:57:16+01:00 chore: Update pyright config - - - - - 7f0fda23 by wurstsalat at 2022-11-27T14:58:41+01:00 refactor: CertificateBox: Use cryptography module for certificate details - - - - - ec48f5d9 by wurstsalat at 2022-11-27T14:58:41+01:00 change: Dependencies: Remove pyOpenSSL, add python-cryptography - - - - - 12 changed files: - README.md - debian/control - flatpak/org.gajim.Gajim.Devel.yaml - flatpak/org.gajim.Gajim.yaml - gajim/common/helpers.py - gajim/gtk/certificate_dialog.py - pyproject.toml - setup.cfg - test/gtk/certificate_dialog.py - test/gtk/util.py - win/_base.sh - win/dev_env.sh Changes: ===================================== README.md ===================================== @@ -7,7 +7,7 @@ ### Runtime Requirements - [pycairo](https://pypi.org/project/pycairo/) - [cairo](https://gitlab.freedesktop.org/cairo/cairo) (>=1.16.0) - [nbxmpp](https://pypi.org/project/nbxmpp/) (>=3.2.5) -- [pyOpenSSL](https://pypi.org/project/pyOpenSSL/) (>=16.2) +- [cryptography](https://pypi.org/project/cryptography/) (>=3.4.8) - [css-parser](https://pypi.org/project/css-parser/) - [keyring](https://pypi.org/project/keyring/) - [precis_i18n](https://pypi.org/project/precis-i18n/) ===================================== debian/control ===================================== @@ -35,7 +35,7 @@ Depends: python3-gi-cairo (>= 1.14.0~), python3-idna, python3-nbxmpp-nightly (>=20221027), - python3-openssl (>= 0.19), + python3-cryptography (>= 3.4.8), python3-precis-i18n, python3-keyring, python3-packaging, ===================================== flatpak/org.gajim.Gajim.Devel.yaml ===================================== @@ -137,15 +137,6 @@ modules: url: https://files.pythonhosted.org/packages/cp36/c/cryptography/cryptography-38… sha256: ca9f6784ea96b55ff41708b92c3f6aeaebde4c560308e5fbbd3173fbc466e94e - - name: python3-pyopenssl - buildsystem: simple - build-commands: - - pip3 install pyOpenSSL-22.0.0-py2.py3-none-any.whl - sources: - - type: file - url: https://files.pythonhosted.org/packages/py2.py3/p/pyOpenSSL/pyOpenSSL-22.0.… - sha256: ea252b38c87425b64116f808355e8da644ef9b07e429398bfece610f893ee2e0 - - name: python3-dbus-python build-options: env: ===================================== flatpak/org.gajim.Gajim.yaml ===================================== @@ -130,15 +130,6 @@ modules: url: https://files.pythonhosted.org/packages/cp36/c/cryptography/cryptography-38… sha256: ca9f6784ea96b55ff41708b92c3f6aeaebde4c560308e5fbbd3173fbc466e94e - - name: python3-pyopenssl - buildsystem: simple - build-commands: - - pip3 install pyOpenSSL-22.0.0-py2.py3-none-any.whl - sources: - - type: file - url: https://files.pythonhosted.org/packages/py2.py3/p/pyOpenSSL/pyOpenSSL-22.0.… - sha256: ea252b38c87425b64116f808355e8da644ef9b07e429398bfece610f893ee2e0 - - name: python3-dbus-python build-options: env: ===================================== gajim/common/helpers.py ===================================== @@ -62,6 +62,9 @@ from packaging.version import Version as V import unicodedata +from cryptography import x509 +from cryptography.hazmat.backends import default_backend + from nbxmpp.namespaces import Namespace from nbxmpp.const import Role from nbxmpp.const import Chatstate @@ -75,9 +78,6 @@ from nbxmpp.protocol import InvalidJid from nbxmpp.protocol import Iq -from OpenSSL.crypto import X509, load_certificate -from OpenSSL.crypto import FILETYPE_PEM - from gi.repository import Gio from gi.repository import GLib from gi.repository import GObject @@ -1429,8 +1429,10 @@ def _on_load_finished(file: Gio.File, file.load_contents_async(None, _on_load_finished) -def convert_gio_to_openssl_cert(cert: Gio.TlsCertificate) -> X509: - return load_certificate(FILETYPE_PEM, cert.props.certificate_pem.encode()) +def get_x509_cert_from_gio_cert(cert: Gio.TlsCertificate) -> x509.Certificate: + glib_bytes = GLib.ByteArray.free_to_bytes(cert.props.certificate) + return x509.load_der_x509_certificate( + glib_bytes.get_data(), default_backend()) def get_custom_host(account: str) -> Optional[tuple[str, ===================================== gajim/gtk/certificate_dialog.py ===================================== @@ -12,14 +12,14 @@ # You should have received a copy of the GNU General Public License # along with Gajim. If not, see <http://www.gnu.org/licenses/>. -from datetime import datetime +from cryptography.hazmat.primitives import hashes from gi.repository import Gdk from gi.repository import Gio from gi.repository import Gtk from gajim.common import app -from gajim.common.helpers import convert_gio_to_openssl_cert +from gajim.common.helpers import get_x509_cert_from_gio_cert from gajim.common.i18n import _ from .builder import get_builder @@ -55,47 +55,55 @@ def _on_key_press(self, _widget: Gtk.Widget, event: Gdk.EventKey) -> None: class CertificateBox(Gtk.Box): - def __init__(self, account: str, cert: Gio.TlsCertificate) -> None: + def __init__(self, account: str, certificate: Gio.TlsCertificate) -> None: Gtk.Box.__init__(self) self._ui = get_builder('certificate.ui') - - certificate = convert_gio_to_openssl_cert(cert) - - issuer = certificate.get_issuer() - subject = certificate.get_subject() - self._headline = _('Certificate for \n%s') % account - self._it_common_name = subject.commonName or '' - self._it_organization = subject.organizationName or '' - self._it_org_unit = subject.organizationalUnitName or '' - it_serial_no = str(certificate.get_serial_number()) + + cert = get_x509_cert_from_gio_cert(certificate) + + self._it_common_name = '' + self._it_organization = '' + self._it_org_unit = '' + for attribute in cert.subject: + # See https://datatracker.ietf.org/doc/html/rfc4514.html + dotted_string = attribute.oid.dotted_string + if dotted_string == '2.5.4.3': + self._ib_common_name = str(attribute.value) + if dotted_string == '2.5.4.10': + self._ib_organization = str(attribute.value) + if dotted_string == '2.5.4.11': + self._ib_org_unit = str(attribute.value) + + it_serial_no = str(cert.serial_number) it_serial_no_half = int(len(it_serial_no) / 2) self._it_serial_number = '%s\n%s' % ( it_serial_no[:it_serial_no_half], it_serial_no[it_serial_no_half:]) - self._ib_common_name = issuer.commonName or '' - self._ib_organization = issuer.organizationName or '' - self._ib_org_unit = issuer.organizationalUnitName or '' - - before = certificate.get_notBefore() - if before is None: - self._issued = '' - else: - issued = datetime.strptime(before.decode('ascii'), '%Y%m%d%H%M%SZ') - self._issued = issued.strftime('%c %Z') - - after = certificate.get_notAfter() - if after is None: - self._expires = '' - else: - expires = datetime.strptime(after.decode('ascii'), '%Y%m%d%H%M%SZ') - self._expires = expires.strftime('%c %Z') - - sha1 = certificate.digest('sha1').decode('utf-8') + + self._ib_common_name = '' + self._ib_organization = '' + self._ib_org_unit = '' + for attribute in cert.issuer: + # See https://datatracker.ietf.org/doc/html/rfc4514.html + dotted_string = attribute.oid.dotted_string + if dotted_string == '2.5.4.3': + self._ib_common_name = str(attribute.value) + if dotted_string == '2.5.4.10': + self._ib_organization = str(attribute.value) + if dotted_string == '2.5.4.11': + self._ib_org_unit = str(attribute.value) + + self._issued = cert.not_valid_before.strftime('%c %Z') + self._expires = cert.not_valid_after.strftime('%c %Z') + + sha1_bytes = cert.fingerprint(hashes.SHA1()) + sha1 = ':'.join(f'{b:02X}' for b in sha1_bytes) self._sha1 = '%s\n%s' % (sha1[:29], sha1[30:]) - sha256 = certificate.digest('sha256').decode('utf-8') + sha256_bytes = cert.fingerprint(hashes.SHA256()) + sha256 = ':'.join(f'{b:02X}' for b in sha256_bytes) self._sha256 = '%s\n%s\n%s\n%s' % ( sha256[:23], sha256[24:47], sha256[48:71], sha256[72:]) ===================================== pyproject.toml ===================================== @@ -93,7 +93,7 @@ include = [ "gajim/gtk/emoji_data_gtk.py", "gajim/gtk/exception.py", "gajim/gtk/features.py", - "gajim/gtk/file_transfer_send.py", + "gajim/gtk/file_transfer_selector.py", "gajim/gtk/groupchat_affiliation.py", "gajim/gtk/groupchat_config.py", "gajim/gtk/groupchat_creation.py", ===================================== setup.cfg ===================================== @@ -44,7 +44,7 @@ install_requires = packaging pillow precis-i18n>=1.0.0 - pyOpenSSL>=16.2 + cryptography>=3.4.8 pycairo>=1.16.0 [options.package_data] ===================================== test/gtk/certificate_dialog.py ===================================== @@ -1,15 +1,15 @@ import gi +gi.require_version('Gio', '2.0') gi.require_version('Gtk', '3.0') +from gi.repository import Gio from gi.repository import Gtk -import OpenSSL - from gajim import gui gui.init('gtk') from test.gtk import util from gajim.common.const import CSSPriority -from gajim.gui.dialogs import CertificateDialog +from gajim.gui.certificate_dialog import CertificateDialog util.load_style('gajim.css', CSSPriority.APPLICATION) @@ -47,8 +47,8 @@ 8xSTlUlCBTCozjzscZVeVDIojmejWclT -----END CERTIFICATE-----''' -cert = OpenSSL.crypto.load_certificate(OpenSSL.crypto.FILETYPE_PEM, cert) -win = CertificateDialog(None, 'testacc', cert) -win.connect("destroy", Gtk.main_quit) +gio_cert = Gio.TlsCertificate.new_from_pem(cert, -1) +win = CertificateDialog(None, 'testacc', gio_cert) +win.connect('destroy', Gtk.main_quit) win.show_all() Gtk.main() ===================================== test/gtk/util.py ===================================== @@ -3,12 +3,15 @@ from gi.repository import Gdk from gi.repository import Gtk +from gajim.common.const import CSSPriority -def get_gajim_dir(): + +def get_gajim_dir() -> Path: gajim_path = Path(__file__) / '..' / '..' / '..' / 'gajim' return gajim_path.resolve() -def load_style(filename, priority): + +def load_style(filename: str, priority: CSSPriority) -> None: path = get_gajim_dir() / 'data' / 'style' / filename try: with open(str(path), 'r', encoding='utf8') as file: @@ -18,6 +21,8 @@ def load_style(filename, priority): return provider = Gtk.CssProvider() provider.load_from_data(bytes(css.encode('utf-8'))) - Gtk.StyleContext.add_provider_for_screen(Gdk.Screen.get_default(), + screen = Gdk.Screen.get_default() + assert screen is not None + Gtk.StyleContext.add_provider_for_screen(screen, provider, priority) ===================================== win/_base.sh ===================================== @@ -98,7 +98,7 @@ function install_deps { mingw-w64-"${ARCH}"-python-setuptools \ mingw-w64-"${ARCH}"-python-pillow \ mingw-w64-"${ARCH}"-python-setuptools-scm \ - mingw-w64-"${ARCH}"-python-pyopenssl \ + mingw-w64-"${ARCH}"-python-cryptography \ mingw-w64-"${ARCH}"-python-certifi \ mingw-w64-"${ARCH}"-python-six \ mingw-w64-"${ARCH}"-python-pygments \ ===================================== win/dev_env.sh ===================================== @@ -15,7 +15,6 @@ function main { mingw-w64-x86_64-python-setuptools-scm \ mingw-w64-x86_64-python-cryptography \ mingw-w64-x86_64-python-certifi \ - mingw-w64-x86_64-python-pyopenssl \ mingw-w64-x86_64-python-pillow \ mingw-w64-x86_64-python-six \ mingw-w64-x86_64-python-pygments \ View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/e499e26f75d71d9e57473849128e98d… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/e499e26f75d71d9e57473849128e98d… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] chore: Update pyright config
by Daniel Brötzmann (＠wurstsalat) 27 Nov '22

27 Nov '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: df1b8a56 by wurstsalat at 2022-11-27T14:57:16+01:00 chore: Update pyright config - - - - - 1 changed file: - pyproject.toml Changes: ===================================== pyproject.toml ===================================== @@ -93,7 +93,7 @@ include = [ "gajim/gtk/emoji_data_gtk.py", "gajim/gtk/exception.py", "gajim/gtk/features.py", - "gajim/gtk/file_transfer_send.py", + "gajim/gtk/file_transfer_selector.py", "gajim/gtk/groupchat_affiliation.py", "gajim/gtk/groupchat_config.py", "gajim/gtk/groupchat_creation.py", View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/df1b8a560cf2386a17a3bc6f6d6200b1… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/df1b8a560cf2386a17a3bc6f6d6200b1… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][cert-convert-cryptography] 29 commits: perf: Control: Request history more efficiently
by Daniel Brötzmann (＠wurstsalat) 27 Nov '22

27 Nov '22

Daniel Brötzmann pushed to branch cert-convert-cryptography at gajim / gajim Commits: dfa950f3 by Philipp Hörist at 2022-11-11T19:07:12+01:00 perf: Control: Request history more efficiently - Limit how many events are requested - Merge events and messages and add them afterwards - - - - - 40770fa7 by wurstsalat at 2022-11-13T14:17:10+01:00 cq: Update pyright config - - - - - c549fff0 by wurstsalat at 2022-11-15T12:00:59+01:00 imprv: ChatList: Scroll to top when switching workspace - - - - - 096e6d69 by Daniel Brötzmann at 2022-11-15T12:15:17+00:00 chore: DOAP: Add XEP-0402 - - - - - 69553e56 by wurstsalat at 2022-11-16T12:32:53+01:00 fix: ConversationView: Fix scrollbar not being the right-most widget This makes it possible to easily 'find' the scrollbar while having Gajim in fullscreen mode. - - - - - 2cf08d52 by wurstsalat at 2022-11-16T12:44:11+01:00 cfix: SearchView: Add separate class for search view rows - - - - - 7b3971b6 by wurstsalat at 2022-11-16T16:50:52+01:00 fix: Preview: Respect MUC context for PMs Fixes #11289 - - - - - 7ccf4806 by wurstsalat at 2022-11-17T17:38:46+01:00 fix: MessageActionsBox: Reintroduce gui_extension_point This is necessary when activating plugins after launch - - - - - d7121d8e by wurstsalat at 2022-11-18T14:07:32+01:00 fix: GroupchatRoster: Set visibility when hiding Hides the roster completely, so that the chat scrollbar is the right-most widget. Caveat: Un-reveal animation is gone - - - - - 23f90923 by wurstsalat at 2022-11-24T16:57:55+01:00 other: Remove obsolete htmltextview test - - - - - a3d7d6a3 by mjk at 2022-11-24T19:43:00+00:00 imprv: Prettify display of geographical locations - - - - - 42adccad by wurstsalat at 2022-11-24T20:54:40+01:00 refactor: MoreMenuButton: Use Gio.Menu Fixes #11262 - - - - - 01fd1b72 by wurstsalat at 2022-11-24T22:08:22+01:00 fix: Chatstates: Switch to Chatstate.ACTIVE after timeout - - - - - a6037e25 by wurstsalat at 2022-11-24T22:23:04+00:00 change: Add FileTransferSelector as a central page for sending files Fixes #9511 - - - - - 53d01bd6 by wurstsalat at 2022-11-24T23:33:00+01:00 refactor: Remove obsolete FileTransferSend dialog - - - - - 45033e89 by wurstsalat at 2022-11-25T15:14:42+01:00 refactor: Preview: Use Gio.Menu and Actions - - - - - 66d9ad4d by wurstsalat at 2022-11-25T15:25:54+01:00 cfix: Preferences: Use correct preview actions - - - - - 26f68c7f by wurstsalat at 2022-11-25T15:26:17+01:00 cfix: Menus: Fix linting error - - - - - b02f54d3 by wurstsalat at 2022-11-25T15:26:40+01:00 cq: File Choosers: Fix typo - - - - - 027b2d47 by wurstsalat at 2022-11-25T15:27:57+01:00 cfix: FileTransferSelector: Improve file choosing - - - - - 88daed91 by wurstsalat at 2022-11-25T16:24:19+01:00 cq: Contacts: Add more log output - - - - - b8c09a65 by wurstsalat at 2022-11-25T17:38:12+01:00 fix: SearchView: Set chat type correctly for ResultRows Fixes #11087 - - - - - 8e0f472a by wurstsalat at 2022-11-25T18:30:44+01:00 fix: ChatFunctionPage: Don't close control on cancelling join error Fixes #11116 - - - - - 44eab3c1 by wurstsalat at 2022-11-25T19:00:31+01:00 refactor: AvatarStorage: Access some methods directly - - - - - be7f2621 by wurstsalat at 2022-11-25T21:03:37+01:00 cq: Settings: Improve type annotations - - - - - 3c312d13 by wurstsalat at 2022-11-26T12:09:58+00:00 change: Jingle: Remove XTLS support XTLS has never been standardized, see https://datatracker.ietf.org/doc/html/draft-meyer-xmpp-e2e-encryption Gajim used this for file transfers, but there probably was no other client supporting this now obsolete feature. Today, using XEP-0396: Jingle Encrypted Transports - OMEMO would be the preferred solution. Part of #11160 - - - - - 8aafb212 by wurstsalat at 2022-11-27T14:45:22+01:00 fix: SSLErrorDialog: Fix test, remove OpenSSL usage - - - - - 99c79002 by wurstsalat at 2022-11-27T14:45:47+01:00 refactor: CertificateBox: Use cryptography module for certificate details - - - - - e499e26f by wurstsalat at 2022-11-27T14:45:47+01:00 change: Dependencies: Remove pyOpenSSL, add python-cryptography - - - - - 30 changed files: - README.md - data/gajim.doap - debian/control - flatpak/org.gajim.Gajim.Devel.yaml - flatpak/org.gajim.Gajim.yaml - gajim/common/configpaths.py - gajim/common/const.py - gajim/common/events.py - gajim/common/helpers.py - gajim/common/jingle_content.py - gajim/common/jingle_ft.py - gajim/common/jingle_ftstates.py - − gajim/common/jingle_xtls.py - gajim/common/modules/bytestream.py - gajim/common/modules/chatstates.py - gajim/common/modules/contacts.py - gajim/common/modules/discovery.py - gajim/common/modules/httpupload.py - gajim/common/modules/jingle.py - gajim/common/modules/user_avatar.py - gajim/common/modules/vcard_avatars.py - gajim/common/preview.py - gajim/common/preview_helpers.py - gajim/common/settings.py - gajim/common/socks5.py - gajim/common/storage/events.py - gajim/data/gui/chat_control.ui - gajim/data/gui/file_transfer_send.ui → gajim/data/gui/file_transfer_selector.ui - gajim/data/gui/message_actions_box.ui - − gajim/data/gui/preview_context_menu.ui The diff was not included because it is too large. View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/52d471d6d6bc256b2a3bbc777fad37a… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/52d471d6d6bc256b2a3bbc777fad37a… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix: SSLErrorDialog: Fix test, remove OpenSSL usage
by Daniel Brötzmann (＠wurstsalat) 27 Nov '22

27 Nov '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 8aafb212 by wurstsalat at 2022-11-27T14:45:22+01:00 fix: SSLErrorDialog: Fix test, remove OpenSSL usage - - - - - 1 changed file: - test/gtk/ssl_error_dialog.py Changes: ===================================== test/gtk/ssl_error_dialog.py ===================================== @@ -1,13 +1,17 @@ +from unittest.mock import MagicMock + import gi +gi.require_version('Gio', '2.0') gi.require_version('Gtk', '3.0') +from gi.repository import Gio from gi.repository import Gtk -import OpenSSL - from gajim import gui gui.init('gtk') from test.gtk import util + +from gajim.common import app from gajim.common.const import CSSPriority from gajim.gui.ssl_error_dialog import SSLErrorDialog @@ -47,9 +51,14 @@ 8xSTlUlCBTCozjzscZVeVDIojmejWclT -----END CERTIFICATE-----''' -cert = OpenSSL.crypto.load_certificate(OpenSSL.crypto.FILETYPE_PEM, cert) + +app.settings = MagicMock() +app.settings.get_account_setting = MagicMock( + return_value=['myhost(a)example.tld']) + +gio_cert = Gio.TlsCertificate.new_from_pem(cert, -1) ssl_error_num = 10 -win = SSLErrorDialog('testacc', None, cert, ssl_error_num) +win = SSLErrorDialog('testacc', None, gio_cert, ssl_error_num) win.connect('destroy', Gtk.main_quit) win.show_all() Gtk.main() View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/8aafb21297c5966acab857d5c777c66f… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/8aafb21297c5966acab857d5c777c66f… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] change: Jingle: Remove XTLS support
by Philipp Hörist (＠lovetox) 26 Nov '22

26 Nov '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: 3c312d13 by wurstsalat at 2022-11-26T12:09:58+00:00 change: Jingle: Remove XTLS support XTLS has never been standardized, see https://datatracker.ietf.org/doc/html/draft-meyer-xmpp-e2e-encryption Gajim used this for file transfers, but there probably was no other client supporting this now obsolete feature. Today, using XEP-0396: Jingle Encrypted Transports - OMEMO would be the preferred solution. Part of #11160 - - - - - 10 changed files: - gajim/common/configpaths.py - gajim/common/const.py - gajim/common/jingle_content.py - gajim/common/jingle_ft.py - gajim/common/jingle_ftstates.py - − gajim/common/jingle_xtls.py - gajim/common/modules/bytestream.py - gajim/common/modules/jingle.py - gajim/common/socks5.py - − gajim/data/other/dh4096.pem Changes: ===================================== gajim/common/configpaths.py ===================================== @@ -189,7 +189,6 @@ def init(self): unique_profile_paths = [ # Data paths ('SECRETS_FILE', 'secrets', PathLocation.DATA, PathType.FILE), - ('MY_PEER_CERTS', 'certs', PathLocation.DATA, PathType.FOLDER), ('CERT_STORE', 'cert_store', PathLocation.DATA, PathType.FOLDER), ('DEBUG', 'debug', PathLocation.DATA, PathType.FOLDER), ('PLUGINS_DATA', 'plugins_data', @@ -200,7 +199,6 @@ def init(self): ('CONFIG_FILE', 'config', PathLocation.CONFIG, PathType.FILE), ('PLUGINS_CONFIG_DIR', 'pluginsconfig', PathLocation.CONFIG, PathType.FOLDER), - ('MY_CERT', 'localcerts', PathLocation.CONFIG, PathType.FOLDER), ('MY_SHORTCUTS', 'shortcuts.json', PathLocation.CONFIG, PathType.FILE), ] ===================================== gajim/common/const.py ===================================== @@ -903,7 +903,6 @@ def is_active(self): Namespace.HASHES_BLAKE2B_512, Namespace.JINGLE, Namespace.JINGLE_FILE_TRANSFER_5, - Namespace.JINGLE_XTLS, Namespace.JINGLE_BYTESTREAM, Namespace.JINGLE_IBB, Namespace.AVATAR_METADATA + '+notify', ===================================== gajim/common/jingle_content.py ===================================== @@ -26,10 +26,7 @@ from nbxmpp.namespaces import Namespace from gajim.common import app -from gajim.common import configpaths from gajim.common.file_props import FileProp -from gajim.common.jingle_xtls import SELF_SIGNED_CERTIFICATE -from gajim.common.jingle_xtls import load_cert_file if TYPE_CHECKING: from gajim.common.jingle_transport import JingleTransport @@ -84,7 +81,6 @@ def __init__(self, # These were found by the Politie self.file_props: Optional[FileProp] = None - self.use_security: Optional[bool] = None self.callbacks: dict[str, list[Callable[ [nbxmpp.Node, nbxmpp.Node, Optional[nbxmpp.Node], str], @@ -267,22 +263,6 @@ def _fill_content(self, content: nbxmpp.Node) -> None: desc = file_tag.setTag('desc') if self.file_props.desc: desc.setData(self.file_props.desc) - if self.use_security: - security = nbxmpp.simplexml.Node( - tag=Namespace.JINGLE_XTLS + ' security') - certpath = configpaths.get('MY_CERT') - certpath = certpath / f'{SELF_SIGNED_CERTIFICATE}.cert' - cert = load_cert_file(certpath) - if cert: - digest_algo = (cert.get_signature_algorithm() - .decode('utf-8').split('With')[0]) - security.addChild('fingerprint').addData(cert.digest( - digest_algo).decode('utf-8')) - for m in ('x509', ): # supported authentication methods - method = nbxmpp.simplexml.Node(tag='method') - method.setAttr('name', m) - security.addChild(node=method) - content.addChild(node=security) content.addChild(node=description_node) def destroy(self) -> None: ===================================== gajim/common/jingle_ft.py ===================================== @@ -33,8 +33,6 @@ from nbxmpp.namespaces import Namespace from gajim.common import app -from gajim.common import configpaths -from gajim.common import jingle_xtls from gajim.common import helpers from gajim.common.const import KindConstant from gajim.common.helpers import AdditionalDataDict @@ -80,7 +78,6 @@ def __init__(self, session: JingleSession, file_props: FileProp, transport: Optional[JingleTransport] = None, - use_security: bool = False, senders: Optional[str] = None ) -> None: @@ -102,8 +99,6 @@ def __init__(self, self.callbacks['transport-info'] += [self.__on_transport_info] self.callbacks['iq-result'] += [self.__on_iq_result] - self.use_security = use_security - self.x509_fingerprint: Optional[str] = None self.file_props = file_props self.weinitiate = self.session.weinitiate self.werequest = self.session.werequest @@ -139,12 +134,6 @@ def __init__(self, State.CAND_SENT_AND_RECEIVED: StateCandSentAndRecv(self) } - cert_name = (configpaths.get('MY_CERT') / - jingle_xtls.SELF_SIGNED_CERTIFICATE) - if not (cert_name.with_suffix('.cert').exists() and - cert_name.with_suffix('.pkey').exists()): - jingle_xtls.make_certs(cert_name, 'gajim') - def __state_changed(self, nextstate: State, args: Optional[dict[str, Any]] = None @@ -200,13 +189,6 @@ def _raise_event(self, if not content: return - secu = content.getTag('security') - self.use_security = bool(secu) - if secu: - fingerprint = secu.getTag('fingerprint') - if fingerprint: - self.x509_fingerprint = fingerprint.getData() - if not self.transport: self.transport = JingleTransportSocks5() self.transport.set_our_jid(self.session.ourjid) @@ -333,26 +315,6 @@ def __on_session_accept(self, action: str ) -> None: log.info('__on_session_accept') - con = self.session.connection - security = content.getTag('security') - if not security: # responder can not verify our fingerprint - self.use_security = False - else: - fingerprint = security.getTag('fingerprint') - if fingerprint: - fingerprint = fingerprint.getData() - self.x509_fingerprint = fingerprint - if not jingle_xtls.check_cert(app.get_jid_without_resource( - self.session.responder), fingerprint): - id_ = jingle_xtls.send_cert_request(con, - self.session.responder) - jingle_xtls.key_exchange_pend(id_, - self.continue_session_accept, - [stanza]) - raise nbxmpp.NodeProcessed - self.continue_session_accept(stanza) - - def continue_session_accept(self, stanza: nbxmpp.Node) -> None: if self.state == State.TRANSPORT_REPLACE: # If we are requesting we don't have the file if self.session.werequest: @@ -371,16 +333,12 @@ def continue_session_accept(self, stanza: nbxmpp.Node) -> None: host['initiator'] = self.session.initiator host['target'] = self.session.responder host['sid'] = self.file_props.sid - fingerprint = None - if self.use_security: - fingerprint = 'client' if self.transport.type_ == TransportType.SOCKS5: sid = self.file_props.transport_sid app.socks5queue.connect_to_hosts(self.session.connection.name, sid, self.on_connect, self._on_connect_error, - fingerprint=fingerprint, receiving=False) raise nbxmpp.NodeProcessed self.__state_changed(State.TRANSFERRING) @@ -550,15 +508,11 @@ def _listen_host(self) -> None: receiver) self.file_props.sha_str = sha_str port = app.settings.get('file_transfers_port') - fingerprint = None - if self.use_security: - fingerprint = 'server' listener = app.socks5queue.start_listener( port, sha_str, self._store_socks5_sid, self.file_props, - fingerprint=fingerprint, typ='sender' if self.weinitiate else 'receiver') if not listener: # send error message, notify the user ===================================== gajim/common/jingle_ftstates.py ===================================== @@ -61,14 +61,11 @@ def action(self, args: Optional[dict[str, Any]] = None) -> None: self.jft._listen_host() # Listen on configured port for file transfer else: - fingerprint = None - if self.jft.use_security: - fingerprint = 'client' # Connect to the candidate host, on success call on_connect method app.socks5queue.connect_to_hosts( self.jft.session.connection.name, self.jft.file_props.transport_sid, self.jft.on_connect, - self.jft._on_connect_error, fingerprint=fingerprint) + self.jft._on_connect_error) class StateCandSent(JingleFileTransferStates): @@ -211,13 +208,13 @@ def _start_sock5_transfer(self) -> None: app.socks5queue, _sock=None, host=str(streamhost_used['host']), port=int(streamhost_used['port']), - fingerprint=None, connected=False, + connected=False, file_props=self.jft.file_props) else: sockobj = Socks5ReceiverClient( app.idlequeue, streamhost_used, transport_sid=self.jft.file_props.transport_sid, - file_props=self.jft.file_props, fingerprint=None) + file_props=self.jft.file_props) sockobj.proxy = True sockobj.streamhost = streamhost_used app.socks5queue.add_sockobj(self.jft.session.connection.name, ===================================== gajim/common/jingle_xtls.py deleted ===================================== @@ -1,300 +0,0 @@ -# This file is part of Gajim. -# -# Gajim is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published -# by the Free Software Foundation; version 3 only. -# -# Gajim is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with Gajim. If not, see <http://www.gnu.org/licenses/>. - -import logging -from pathlib import Path - -from OpenSSL import SSL, crypto - -import nbxmpp -from nbxmpp.namespaces import Namespace -from nbxmpp.util import generate_id -from gajim.common import app -from gajim.common import configpaths - -log = logging.getLogger('gajim.c.jingle_xtls') - -# key-exchange id -> [callback, args] -# accept that session once key-exchange completes -pending_contents = {} - - -def key_exchange_pend(id_, cb, args): - # args is a list - pending_contents[id_] = [cb, args] - - -def approve_pending_content(id_): - cb = pending_contents[id_][0] - args = pending_contents[id_][1] - cb(*args) - - -TYPE_RSA = crypto.TYPE_RSA -TYPE_DSA = crypto.TYPE_DSA - -SELF_SIGNED_CERTIFICATE = 'localcert' -DH_PARAMS = 'dh_params.pem' -DEFAULT_DH_PARAMS = 'dh4096.pem' - - -def default_callback(connection, certificate, error_num, depth, return_code): - log.info('certificate: %s', certificate) - return return_code - - -def load_cert_file(cert_path, cert_store=None): - ''' - This is almost identical to the one in nbxmpp.tls_nb - ''' - if not cert_path.is_file(): - return None - try: - f = open(cert_path, 'r', encoding='utf8') - except IOError as e: - log.warning('Unable to open certificate file %s: %s', cert_path, - str(e)) - return None - lines = f.readlines() - i = 0 - begin = -1 - for line in lines: - if 'BEGIN CERTIFICATE' in line: - begin = i - elif 'END CERTIFICATE' in line and begin > -1: - cert = ''.join(lines[begin:i + 2]) - try: - x509cert = crypto.load_certificate(crypto.FILETYPE_PEM, cert) - if cert_store: - cert_store.add_cert(x509cert) - f.close() - return x509cert - except crypto.Error as exception_obj: - log.warning('Unable to load a certificate from file %s: %s', - cert_path, exception_obj.args[0][0][2]) - except Exception: - log.warning('Unknown error while loading certificate from file ' - '%s', cert_path) - begin = -1 - i += 1 - f.close() - - -def get_context(fingerprint, verify_cb=None, remote_jid=None): - ''' - constructs and returns the context objects - ''' - ctx = SSL.Context(SSL.SSLv23_METHOD) - flags = (SSL.OP_NO_SSLv2 | SSL.OP_NO_SSLv3 | SSL.OP_SINGLE_DH_USE | - SSL.OP_NO_TICKET) - ctx.set_options(flags) - ctx.set_cipher_list(b'HIGH:!aNULL:!3DES') - - if fingerprint == 'server': # for testing purposes only - ctx.set_verify(SSL.VERIFY_NONE | SSL.VERIFY_FAIL_IF_NO_PEER_CERT, - verify_cb or default_callback) - elif fingerprint == 'client': - ctx.set_verify(SSL.VERIFY_PEER, verify_cb or default_callback) - - cert_name = configpaths.get('MY_CERT') / SELF_SIGNED_CERTIFICATE - ctx.use_privatekey_file(str(cert_name.with_suffix('.pkey')).encode('utf-8')) - ctx.use_certificate_file( - str(cert_name.with_suffix('.cert')).encode('utf-8')) - - # Try to load Diffie-Hellman parameters. - # First try user DH parameters, if this fails load the default DH parameters - dh_params_name = configpaths.get('MY_CERT') / DH_PARAMS - try: - with open(dh_params_name, 'r', encoding='utf8'): - ctx.load_tmp_dh(dh_params_name.encode('utf-8')) - except FileNotFoundError: - default_dh_params_name = (configpaths.get('DATA') / 'other' / - DEFAULT_DH_PARAMS) - try: - with open(default_dh_params_name, 'r', encoding='utf8'): - ctx.load_tmp_dh(str(default_dh_params_name).encode('utf-8')) - except FileNotFoundError as err: - log.error('Unable to load default DH parameter file: %s, %s', - default_dh_params_name, err) - raise - - if remote_jid: - store = ctx.get_cert_store() - path = configpaths.get('MY_PEER_CERTS').expanduser() - path = path / f'{remote_jid}.cert' - if path.exists(): - load_cert_file(path, cert_store=store) - log.debug('certificate file %s loaded fingerprint %s', - path, fingerprint) - return ctx - - -def read_cert(certpath): - certificate = '' - with open(certpath, 'r', encoding='utf8') as certfile: - for line in certfile.readlines(): - if not line.startswith('-'): - certificate += line - return certificate - - -def send_cert(con, jid_from, sid): - certpath = configpaths.get('MY_CERT') / f'{SELF_SIGNED_CERTIFICATE}.cert' - certificate = read_cert(certpath) - iq = nbxmpp.Iq('result', to=jid_from) - iq.setAttr('id', sid) - - pubkey = iq.setTag('pubkeys') - pubkey.setNamespace(Namespace.PUBKEY_PUBKEY) - - keyinfo = pubkey.setTag('keyinfo') - name = keyinfo.setTag('name') - name.setData('CertificateHash') - cert = keyinfo.setTag('x509cert') - cert.setData(certificate) - - con.send(iq) - - -def handle_new_cert(con, obj, jid_from): - jid = app.get_jid_without_resource(jid_from) - certpath = configpaths.get('MY_PEER_CERTS').expanduser() / (jid + '.cert') - - id_ = obj.getAttr('id') - - x509cert = obj.getTag('pubkeys').getTag('keyinfo').getTag('x509cert') - - cert = x509cert.getData() - - f = open(certpath, 'w', encoding='utf8') - f.write('-----BEGIN CERTIFICATE-----\n') - f.write(cert) - f.write('-----END CERTIFICATE-----\n') - f.close() - - approve_pending_content(id_) - - -def check_cert(jid, fingerprint): - certpath = configpaths.get('MY_PEER_CERTS').expanduser() / (jid + '.cert') - if certpath.exists(): - cert = load_cert_file(certpath) - if cert: - digest_algo = cert.get_signature_algorithm() - digest_algo = digest_algo.decode('utf-8').split('With')[0] - if cert.digest(digest_algo) == fingerprint: - return True - return False - - -def send_cert_request(con, to_jid): - iq = nbxmpp.Iq('get', to=to_jid) - id_ = generate_id() - iq.setAttr('id', id_) - pubkey = iq.setTag('pubkeys') - pubkey.setNamespace(Namespace.PUBKEY_PUBKEY) - con.connection.send(iq) - return str(id_) - -# the following code is partly due to pyopenssl examples - - -def createKeyPair(type_, bits): - ''' - Create a public/private key pair. - - Arguments: type_ - Key type, must be one of TYPE_RSA and TYPE_DSA - bits - Number of bits to use in the key - Returns: The public/private key pair in a PKey object - ''' - pkey = crypto.PKey() - pkey.generate_key(type_, bits) - return pkey - - -def createCertRequest(pkey, digest='sha256', **name): - ''' - Create a certificate request. - - Arguments: pkey - The key to associate with the request - digest - Digestion method to use for signing, default is sha256 - **name - The name of the subject of the request, possible - arguments are: - C - Country name - ST - State or province name - L - Locality name - O - Organization name - OU - Organizational unit name - CN - Common name - emailAddress - E-mail address - Returns: The certificate request in an X509Req object - ''' - req = crypto.X509Req() - subj = req.get_subject() - - for (key, value) in name.items(): - setattr(subj, key, value) - - req.set_pubkey(pkey) - req.sign(pkey, digest) - return req - - -def createCertificate(req, issuerCert, issuerKey, serial, notBefore, notAfter, - digest='sha256'): - ''' - Generate a certificate given a certificate request. - - Arguments: req - Certificate request to use - issuerCert - The certificate of the issuer - issuerKey - The private key of the issuer - serial - Serial number for the certificate - notBefore - Timestamp (relative to now) when the certificate - starts being valid - notAfter - Timestamp (relative to now) when the certificate - stops being valid - digest - Digest method to use for signing, default is sha256 - Returns: The signed certificate in an X509 object - ''' - cert = crypto.X509() - cert.set_serial_number(serial) - cert.gmtime_adj_notBefore(notBefore) - cert.gmtime_adj_notAfter(notAfter) - cert.set_issuer(issuerCert.get_subject()) - cert.set_subject(req.get_subject()) - cert.set_pubkey(req.get_pubkey()) - cert.sign(issuerKey, digest) - return cert - - -def make_certs(filepath, CN): - ''' - make self signed certificates - filepath : absolute path of certificate file, will be appended the '.pkey' - and '.cert' extensions - CN : common name - ''' - key = createKeyPair(TYPE_RSA, 4096) - req = createCertRequest(key, CN=CN) - # five years - cert = createCertificate(req, req, key, 0, 0, 60 * 60 * 24 * 365 * 5) - with open(filepath.with_suffix('.pkey'), 'wb') as f: - filepath.with_suffix('.pkey').chmod(0o600) - f.write(crypto.dump_privatekey(crypto.FILETYPE_PEM, key)) - with open(filepath.with_suffix('.cert'), 'wb') as f: - f.write(crypto.dump_certificate(crypto.FILETYPE_PEM, cert)) - - -if __name__ == '__main__': - make_certs(Path('selfcert'), 'gajim') ===================================== gajim/common/modules/bytestream.py ===================================== @@ -43,7 +43,6 @@ from gajim.common import app from gajim.common import helpers -from gajim.common import jingle_xtls from gajim.common import types from gajim.common.events import FileRequestError from gajim.common.file_props import FileProp @@ -165,16 +164,6 @@ def send_file_approval(self, file_props: FileProp) -> None: if not session.accepted: content = session.get_content('file', content.name) - if content.use_security: - fingerprint = content.x509_fingerprint - if not jingle_xtls.check_cert( - app.get_jid_without_resource(file_props.sender), - fingerprint): - id_ = jingle_xtls.send_cert_request( - self._con, file_props.sender) - jingle_xtls.key_exchange_pend(id_, - content.on_cert_received, []) - return session.approve_session() session.approve_content('file', content.name) @@ -747,7 +736,6 @@ def _on_bytestream_result(self, _sock=None, host=str(proxy['host']), port=int(proxy['port']), - fingerprint=None, connected=False, file_props=file_props) sender.streamhost = proxy ===================================== gajim/common/modules/jingle.py ===================================== @@ -42,7 +42,6 @@ from nbxmpp.structs import IqProperties from gajim.common import helpers -from gajim.common import jingle_xtls from gajim.common import types from gajim.common.file_props import FileProp from gajim.common.modules.base import BaseModule @@ -71,14 +70,6 @@ def __init__(self, con: types.Client) -> None: typ='set', ns=Namespace.JINGLE, callback=self._on_jingle_iq), - StanzaHandler(name='iq', - typ='get', - ns=Namespace.PUBKEY_PUBKEY, - callback=self._on_pubkey_request), - StanzaHandler(name='iq', - typ='result', - ns=Namespace.PUBKEY_PUBKEY, - callback=self._pubkey_result_received), ] # dictionary: sessionid => JingleSession object @@ -100,26 +91,6 @@ def delete_jingle_session(self, sid: str) -> None: self._sessions[sid].callbacks = [] del self._sessions[sid] - def _on_pubkey_request(self, - con: types.xmppClient, - stanza: Iq, - _properties: IqProperties - ) -> None: - jid_from = helpers.get_full_jid_from_iq(stanza) - self._log.info('Pubkey request from %s', jid_from) - sid = stanza.getAttr('id') - jingle_xtls.send_cert(con, jid_from, sid) - raise nbxmpp.NodeProcessed - - def _pubkey_result_received(self, - con: types.xmppClient, - stanza: Iq, - _properties: IqProperties - ) -> None: - jid_from = helpers.get_full_jid_from_iq(stanza) - self._log.info('Pubkey result from %s', jid_from) - jingle_xtls.handle_new_cert(con, stanza, jid_from) - def _on_jingle_iq(self, _con: types.xmppClient, stanza: Iq, @@ -236,7 +207,6 @@ def start_file_transfer(self, ) -> Optional[str]: logger.info('start file transfer with file: %s', file_props) contact = self._con.get_module('Contacts').get_contact(jid) - use_security = contact.supports(Namespace.JINGLE_XTLS) jingle = JingleSession(self._con, weinitiate=True, jid=jid, @@ -261,7 +231,6 @@ def start_file_transfer(self, transfer = JingleFileTransfer(jingle, transport=transport, file_props=file_props, - use_security=use_security, senders=senders) file_props.transport_sid = transport.sid file_props.algo = self.__hash_support(contact) ===================================== gajim/common/socks5.py ===================================== @@ -33,11 +33,9 @@ from errno import EAFNOSUPPORT from nbxmpp.idlequeue import IdleObject -import OpenSSL from gajim.common.file_props import FilesProp from gajim.common import app -from gajim.common import jingle_xtls log = logging.getLogger('gajim.c.socks5') MAX_BUFF_LEN = 65536 @@ -77,7 +75,7 @@ def __init__(self, idlequeue, complete_transfer_cb=None, self.on_failure = {} # {id: cb} def start_listener(self, port, sha_str, sha_handler, file_props, - fingerprint=None, typ='sender'): + typ='sender'): """ Start waiting for incoming connections on (host, port) and do a socks5 authentication using sid for generated SHA @@ -86,8 +84,7 @@ def start_listener(self, port, sha_str, sha_handler, file_props, sid = file_props.sid self.sha_handlers[sha_str] = (sha_handler, sid) if self.listener is None or not self.listener.connections: - self.listener = Socks5Listener(self.idlequeue, port, file_props, - fingerprint=fingerprint) + self.listener = Socks5Listener(self.idlequeue, port, file_props) self.listener.queue = self self.listener.bind() else: @@ -113,7 +110,7 @@ def send_success_reply(self, file_props, streamhost): return 1 def connect_to_hosts(self, account, transport_sid, on_success=None, - on_failure=None, fingerprint=None, receiving=True): + on_failure=None, receiving=True): self.on_success[transport_sid] = on_success self.on_failure[transport_sid] = on_failure file_props = FilesProp.getFilePropByTransportSid(account, transport_sid) @@ -128,10 +125,6 @@ def connect_to_hosts(self, account, transport_sid, on_success=None, on_failure(file_props.transport_sid) # add streamhosts to the queue for streamhost in streamhosts_to_test: - if 'type' in streamhost and streamhost['type'] == 'proxy': - fp = None - else: - fp = fingerprint if receiving: if 'candidate_id' in streamhost: log.debug('Trying to connect as receiver to cid %s', @@ -141,7 +134,7 @@ def connect_to_hosts(self, account, transport_sid, on_success=None, streamhost['jid']) file_props.type_ = 'r' socks5obj = Socks5ReceiverClient(self.idlequeue, streamhost, - transport_sid, file_props, fingerprint=fp) + transport_sid, file_props) self.add_sockobj(account, socks5obj) else: if 'candidate_id' in streamhost: @@ -162,7 +155,7 @@ def connect_to_hosts(self, account, transport_sid, on_success=None, file_props.proxy_receiver = streamhost['initiator'] socks5obj = Socks5SenderClient(self.idlequeue, idx, self, _sock=None, host=str(streamhost['host']), - port=int(streamhost['port']), fingerprint=fp, + port=int(streamhost['port']), connected=False, file_props=file_props, initiator=streamhost['initiator'], target=streamhost['target']) @@ -345,7 +338,7 @@ def on_connection_accepted(self, sock, listener): if listener.file_props.type_ == 's' and \ not self.isHashInSockObjs(self.senders, sock_hash): sockobj = Socks5SenderServer(self.idlequeue, sock_hash, self, - sock[0], sock[1][0], sock[1][1], fingerprint=None, + sock[0], sock[1][0], sock[1][1], file_props=listener.file_props) self._add(sockobj, self.senders, listener.file_props, sock_hash) # Start waiting for data @@ -360,7 +353,7 @@ def on_connection_accepted(self, sock, listener): sh['target'] = None sockobj = Socks5ReceiverServer(idlequeue=self.idlequeue, streamhost=sh, transport_sid=None, - file_props=listener.file_props, fingerprint=None) + file_props=listener.file_props) self._add(sockobj, self.readers, listener.file_props, sock_hash) sockobj.set_sock(sock[0]) @@ -477,20 +470,12 @@ def __init__(self, idlequeue, host, port, initiator, target, sid): self.file = None self.connected = False self.mode = '' - self.ssl_cert = None - self.ssl_errnum = 0 def _is_connected(self): if self.state < 5: return False return True - def ssl_verify_cb(self, ssl_conn, cert, error_num, depth, return_code): - if depth == 0: - self.ssl_cert = cert - self.ssl_errnum = error_num - return True - def connect(self): """ Create the socket and plug it to the idlequeue @@ -500,17 +485,6 @@ def connect(self): for ai in self.ais: try: self._sock = socket.socket(*ai[:3]) - if self.fingerprint is not None: - if self.file_props.type_ == 's': - remote_jid = app.get_jid_without_resource( - self.file_props.receiver) - else: - remote_jid = app.get_jid_without_resource( - self.file_props.sender) - self._sock = OpenSSL.SSL.Connection( - jingle_xtls.get_context('client', - verify_cb=self.ssl_verify_cb, remote_jid=remote_jid), - self._sock) # this will not block the GUI self._sock.setblocking(False) self._server = ai[4] @@ -532,8 +506,6 @@ def do_connect(self): self._sock.connect(self._server) self._send = self._sock.send self._recv = self._sock.recv - except (OpenSSL.SSL.WantReadError, OpenSSL.SSL.WantWriteError): - pass except Exception as ee: errnum = ee.errno self.connect_timeout += 1 @@ -642,10 +614,6 @@ def receive(self): received = b'' try: add = self._recv(64) - except (OpenSSL.SSL.WantReadError, OpenSSL.SSL.WantWriteError, - OpenSSL.SSL.WantX509LookupError) as e: - log.info('SSL rehandshake request: %s', repr(e)) - raise e except Exception: add = b'' received += add @@ -659,10 +627,6 @@ def send_raw(self, raw_data): """ try: self._send(raw_data) - except (OpenSSL.SSL.WantReadError, OpenSSL.SSL.WantWriteError, - OpenSSL.SSL.WantX509LookupError) as e: - log.info('SSL rehandshake request: %s', repr(e)) - raise e except Exception: self.disconnect() return len(raw_data) @@ -683,13 +647,6 @@ def write_next(self): lenn = 0 try: lenn = self._send(buff) - except (OpenSSL.SSL.WantReadError, - OpenSSL.SSL.WantWriteError, - OpenSSL.SSL.WantX509LookupError) as err: - log.info('SSL rehandshake request: %s', repr(err)) - raise err - except OpenSSL.SSL.SysCallError: - return self._on_send_exception() except socket.error as err: if err.errno not in (EINTR, ENOBUFS, EWOULDBLOCK): return self._on_send_exception() @@ -767,10 +724,6 @@ def get_file_contents(self, timeout): return 0 try: buff = self._recv(MAX_BUFF_LEN) - except (OpenSSL.SSL.WantReadError, OpenSSL.SSL.WantWriteError, - OpenSSL.SSL.WantX509LookupError) as e: - log.info('SSL rehandshake request: %s', repr(e)) - raise e except Exception: buff = b'' current_time = time.time() @@ -825,10 +778,7 @@ def disconnect(self, *args, **kwargs): if self.queue.listener.connections == []: self.queue.listener.disconnect() try: - if isinstance(self._sock, OpenSSL.SSL.Connection): - self._sock.shutdown() - else: - self._sock.shutdown(socket.SHUT_RDWR) + self._sock.shutdown(socket.SHUT_RDWR) self._sock.close() except Exception: # socket is already closed @@ -905,12 +855,7 @@ def read_connect(self): """ Connect response: version, auth method """ - try: - buff = self._recv().decode('utf-8') - except (OpenSSL.SSL.WantReadError, OpenSSL.SSL.WantWriteError, - OpenSSL.SSL.WantX509LookupError) as e: - log.info("SSL rehandshake request: %s", repr(e)) - raise e + buff = self._recv().decode('utf-8') try: version, method = struct.unpack('!BB', buff) except Exception: @@ -943,21 +888,15 @@ class Socks5Sender(IdleObject): Class for sending file to socket over socks5 """ def __init__(self, idlequeue, sock_hash, parent, _sock, host=None, - port=None, fingerprint=None, connected=True, file_props=None): + port=None, connected=True, file_props=None): IdleObject.__init__(self) - self.fingerprint = fingerprint self.queue_idx = sock_hash self.queue = parent self.file_props = file_props self.proxy = False self._sock = _sock if _sock is not None: - if self.fingerprint is not None and not isinstance(self._sock, - OpenSSL.SSL.Connection): - self._sock = OpenSSL.SSL.Connection( - jingle_xtls.get_context('server'), _sock) - else: - self._sock.setblocking(False) + self._sock.setblocking(False) self.fd = _sock.fileno() self._recv = _sock.recv self._send = _sock.send @@ -985,11 +924,7 @@ def start_transfer(self): def set_connection_sock(self, _sock): self._sock = _sock - if self.fingerprint is not None: - self._sock = OpenSSL.SSL.Connection( - jingle_xtls.get_context('client'), _sock) - else: - self._sock.setblocking(False) + self._sock.setblocking(False) self.fd = _sock.fileno() self._recv = _sock.recv self._send = _sock.send @@ -1023,17 +958,11 @@ def disconnect(self, cb=True): class Socks5Receiver(IdleObject): - def __init__(self, idlequeue, streamhost, sid, file_props=None, - fingerprint=None): - """ - fingerprint: fingerprint of certificates we shall use, set to None if - TLS connection not desired - """ + def __init__(self, idlequeue, streamhost, sid, file_props=None): IdleObject.__init__(self) self.queue_idx = -1 self.streamhost = streamhost self.queue = None - self.fingerprint = fingerprint self.connect_timeout = 0 self.connected = False self.pauses = 0 @@ -1129,36 +1058,31 @@ def main(self): def pollin(self): self.idlequeue.remove_timeout(self.fd) if self.connected: - try: - if self.state < 5: - result = self.main() - if self.state == 4: - self.queue.result_sha(self.sha_msg, self.queue_idx) - if result == -1: - self.disconnect() - elif self.state == 5: - self.state = 7 - if self.file_props.type_ == 's': - # We wait for the end of the negotiation to - # send the file - self.idlequeue.plug_idle(self, False, False) - else: - # We plug for reading - self.idlequeue.plug_idle(self, False, True) - return - elif self.state == 7: - if self.file_props.paused: - self.file_props.continue_cb = \ - self.continue_paused_transfer - self.idlequeue.plug_idle(self, False, False) - return - self.idlequeue.set_read_timeout(self.fd, STALLED_TIMEOUT) - result = self.start_transfer() # send - self.queue.process_result(result, self) - except (OpenSSL.SSL.WantReadError, - OpenSSL.SSL.WantWriteError, - OpenSSL.SSL.WantX509LookupError): - log.info('caught SSL exception, ignored') + if self.state < 5: + result = self.main() + if self.state == 4: + self.queue.result_sha(self.sha_msg, self.queue_idx) + if result == -1: + self.disconnect() + elif self.state == 5: + self.state = 7 + if self.file_props.type_ == 's': + # We wait for the end of the negotiation to + # send the file + self.idlequeue.plug_idle(self, False, False) + else: + # We plug for reading + self.idlequeue.plug_idle(self, False, True) + return + elif self.state == 7: + if self.file_props.paused: + self.file_props.continue_cb = \ + self.continue_paused_transfer + self.idlequeue.plug_idle(self, False, False) + return + self.idlequeue.set_read_timeout(self.fd, STALLED_TIMEOUT) + result = self.start_transfer() # send + self.queue.process_result(result, self) else: self.disconnect() @@ -1173,32 +1097,26 @@ def pollout(self): self.disconnect() return self.idlequeue.remove_timeout(self.fd) - try: - if self.state == 2: # send reply with desired auth type - self.send_raw(self._get_auth_response()) - elif self.state == 4: # send positive response to the 'connect' - self.send_raw(self._get_request_buff(self.sha_msg, 0x00)) - elif self.state == 7: - if self.file_props.paused: - self.file_props.continue_cb = self.continue_paused_transfer - self.idlequeue.plug_idle(self, False, False) - return - result = self.start_transfer() # send - self.queue.process_result(result, self) - if result is None or result <= 0: - self.disconnect() - return - self.idlequeue.set_read_timeout(self.fd, STALLED_TIMEOUT) - elif self.state == 8: - self.disconnect() + if self.state == 2: # send reply with desired auth type + self.send_raw(self._get_auth_response()) + elif self.state == 4: # send positive response to the 'connect' + self.send_raw(self._get_request_buff(self.sha_msg, 0x00)) + elif self.state == 7: + if self.file_props.paused: + self.file_props.continue_cb = self.continue_paused_transfer + self.idlequeue.plug_idle(self, False, False) return - else: + result = self.start_transfer() # send + self.queue.process_result(result, self) + if result is None or result <= 0: self.disconnect() - except (OpenSSL.SSL.WantReadError, - OpenSSL.SSL.WantWriteError, - OpenSSL.SSL.WantX509LookupError): - log.info('caught SSL exception, ignored') + return + self.idlequeue.set_read_timeout(self.fd, STALLED_TIMEOUT) + elif self.state == 8: + self.disconnect() return + else: + self.disconnect() if self.state < 5: self.state += 1 # unplug and plug this time for reading @@ -1286,61 +1204,41 @@ def main(self, timeout=0): self.state += 1 return None - def send_file(self): - if self.ssl_errnum > 0: - log.error('remote certificate does not match the announced one.' - '\nSSL Error: %d\nCancelling file transfer', - self.ssl_errnum) - self.file_props.error = -12 - return -1 - return super(Socks5Client, self).send_file() - def pollin(self): self.idlequeue.remove_timeout(self.fd) if self.connected: - try: - if self.file_props.paused: - self.idlequeue.plug_idle(self, False, False) - return - if self.state < 5: - self.idlequeue.set_read_timeout(self.fd, CONNECT_TIMEOUT) - self.main(0) - elif self.state == 5: # wait for proxy reply - pass - elif self.file_props.type_ == 'r': - self.idlequeue.set_read_timeout(self.fd, STALLED_TIMEOUT) - result = self.start_transfer() # receive - self.queue.process_result(result, self) - except (OpenSSL.SSL.WantReadError, - OpenSSL.SSL.WantWriteError, - OpenSSL.SSL.WantX509LookupError): - log.info('caught SSL exception, ignored') + if self.file_props.paused: + self.idlequeue.plug_idle(self, False, False) return + if self.state < 5: + self.idlequeue.set_read_timeout(self.fd, CONNECT_TIMEOUT) + self.main(0) + elif self.state == 5: # wait for proxy reply + pass + elif self.file_props.type_ == 'r': + self.idlequeue.set_read_timeout(self.fd, STALLED_TIMEOUT) + result = self.start_transfer() # receive + self.queue.process_result(result, self) else: self.disconnect() def pollout(self): self.idlequeue.remove_timeout(self.fd) - try: - if self.state == 0: - self.do_connect() - return - if self.state == 1: # send initially: version and auth types - self.send_raw(self._get_auth_buff()) - elif self.state == 3: # send 'connect' request - self.send_raw(self._get_request_buff(self._get_sha1_auth())) - elif self.file_props.type_ != 'r': - if self.file_props.paused: - self.idlequeue.plug_idle(self, False, False) - return - result = self.start_transfer() # send - self.queue.process_result(result, self) + if self.state == 0: + self.do_connect() + return + if self.state == 1: # send initially: version and auth types + self.send_raw(self._get_auth_buff()) + elif self.state == 3: # send 'connect' request + self.send_raw(self._get_request_buff(self._get_sha1_auth())) + elif self.file_props.type_ != 'r': + if self.file_props.paused: + self.idlequeue.plug_idle(self, False, False) return - except (OpenSSL.SSL.WantReadError, - OpenSSL.SSL.WantWriteError, - OpenSSL.SSL.WantX509LookupError): - log.info('caught SSL exception, ignored') + result = self.start_transfer() # send + self.queue.process_result(result, self) return + self.state += 1 # unplug and plug for reading self.idlequeue.plug_idle(self, False, True) @@ -1359,55 +1257,50 @@ def pollend(self): class Socks5SenderClient(Socks5Client, Socks5Sender): def __init__(self, idlequeue, sock_hash, parent, _sock, host=None, - port=None, fingerprint=None, connected=True, file_props=None, + port=None, connected=True, file_props=None, initiator=None, target=None): Socks5Client.__init__(self, idlequeue, host, port, initiator, target, file_props.transport_sid) Socks5Sender.__init__(self, idlequeue, sock_hash, parent, _sock, - host, port, fingerprint, connected, file_props) + host, port, connected, file_props) class Socks5SenderServer(Socks5Server, Socks5Sender): def __init__(self, idlequeue, sock_hash, parent, _sock, host=None, - port=None, fingerprint=None, connected=True, file_props=None): + port=None, connected=True, file_props=None): Socks5Server.__init__(self, idlequeue, host, port, None, None, file_props.transport_sid) Socks5Sender.__init__(self, idlequeue, sock_hash, parent, _sock, - host, port, fingerprint, connected, file_props) + host, port, connected, file_props) class Socks5ReceiverClient(Socks5Client, Socks5Receiver): - def __init__(self, idlequeue, streamhost, transport_sid, file_props=None, - fingerprint=None): + def __init__(self, idlequeue, streamhost, transport_sid, file_props=None): Socks5Client.__init__(self, idlequeue, streamhost['host'], int(streamhost['port']), streamhost['initiator'], streamhost['target'], transport_sid) Socks5Receiver.__init__(self, idlequeue, streamhost, transport_sid, - file_props, fingerprint) + file_props) class Socks5ReceiverServer(Socks5Server, Socks5Receiver): - def __init__(self, idlequeue, streamhost, transport_sid, file_props=None, - fingerprint=None): + def __init__(self, idlequeue, streamhost, transport_sid, file_props=None): Socks5Server.__init__(self, idlequeue, streamhost['host'], int(streamhost['port']), streamhost['initiator'], streamhost['target'], transport_sid) Socks5Receiver.__init__(self, idlequeue, streamhost, transport_sid, - file_props, fingerprint) + file_props) class Socks5Listener(IdleObject): - def __init__(self, idlequeue, port, fp, fingerprint=None): + def __init__(self, idlequeue, port, fp): """ Handle all incoming connections on (0.0.0.0, port) This class implements IdleObject, but we will expect only pollin events though - - fingerprint: fingerprint of certificates we shall use, set to None if - TLS connection not desired """ IdleObject.__init__(self) self.port = port @@ -1420,7 +1313,6 @@ def __init__(self, idlequeue, port, fp, fingerprint=None): self.started = False self._sock = None self.fd = -1 - self.fingerprint = fingerprint self.file_props = fp self.connections = [] @@ -1429,9 +1321,6 @@ def bind(self): # try the different possibilities (ipv6, ipv4, etc.) try: self._serv = socket.socket(*ai[:3]) - if self.fingerprint is not None: - self._serv = OpenSSL.SSL.Connection( - jingle_xtls.get_context('server'), self._serv) except socket.error as e: if e.errno == EAFNOSUPPORT: self.ai = None ===================================== gajim/data/other/dh4096.pem deleted ===================================== @@ -1,21 +0,0 @@ ------BEGIN DH PARAMETERS----- -MIICCAKCAgEA///////////JD9qiIWjCNMTGYouA3BzRKQJOCIpnzHQCC76mOxOb -IlFKCHmONATd75UZs806QxswKwpt8l8UN0/hNW1tUcJF5IW1dmJefsb0TELppjft -awv/XLb0Brft7jhr+1qJn6WunyQRfEsf5kkoZlHs5Fs9wgB8uKFjvwWY2kg2HFXT -mmkWP6j9JM9fg2VdI9yjrZYcYvNWIIVSu57VKQdwlpZtZww1Tkq8mATxdGwIyhgh -fDKQXkYuNs474553LBgOhgObJ4Oi7Aeij7XFXfBvTFLJ3ivL9pVYFxg5lUl86pVq -5RXSJhiY+gUQFXKOWoqqxC2tMxcNBFB6M6hVIavfHLpk7PuFBFjb7wqK6nFXXQYM -fbOXD4Wm4eTHq/WujNsJM9cejJTgSiVhnc7j0iYa0u5r8S/6BtmKCGTYdgJzPshq -ZFIfKxgXeyAMu+EXV3phXWx3CYjAutlG4gjiT6B05asxQ9tb/OD9EI5LgtEgqSEI -ARpyPBKnh+bXiHGaEL26WyaZwycYavTiPBqUaDS2FQvaJYPpyirUTOjbu8LbBN6O -+S6O/BQfvsqmKHxZR05rwF2ZspZPoJDDoiM7oYZRW+ftH2EpcM7i16+4G912IXBI -HNAGkSfVsFqpk7TqmI2P3cGG/7fckKbAj030Nck0BjGZ//////////8CAQI= ------END DH PARAMETERS----- - -"4096-bit MODP Group" from RFC3526, Section 5. - -The prime is: 2^4096 - 2^4032 - 1 + 2^64 * { [2^3966 pi] + 240904 } - -RFC3526 specifies a generator of 2. - -The generation of the group is described in RFC 2412. View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/3c312d1334e8fdb1f09dddce144d0cbd… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/3c312d1334e8fdb1f09dddce144d0cbd… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim] Deleted branch remove-jingle-xtls
by Daniel Brötzmann (＠wurstsalat) 26 Nov '22

26 Nov '22

Daniel Brötzmann deleted branch remove-jingle-xtls at gajim / gajim -- You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][remove-jingle-xtls] 25 commits: cq: Update pyright config
by Philipp Hörist (＠lovetox) 26 Nov '22

26 Nov '22

Philipp Hörist pushed to branch remove-jingle-xtls at gajim / gajim Commits: 40770fa7 by wurstsalat at 2022-11-13T14:17:10+01:00 cq: Update pyright config - - - - - c549fff0 by wurstsalat at 2022-11-15T12:00:59+01:00 imprv: ChatList: Scroll to top when switching workspace - - - - - 096e6d69 by Daniel Brötzmann at 2022-11-15T12:15:17+00:00 chore: DOAP: Add XEP-0402 - - - - - 69553e56 by wurstsalat at 2022-11-16T12:32:53+01:00 fix: ConversationView: Fix scrollbar not being the right-most widget This makes it possible to easily 'find' the scrollbar while having Gajim in fullscreen mode. - - - - - 2cf08d52 by wurstsalat at 2022-11-16T12:44:11+01:00 cfix: SearchView: Add separate class for search view rows - - - - - 7b3971b6 by wurstsalat at 2022-11-16T16:50:52+01:00 fix: Preview: Respect MUC context for PMs Fixes #11289 - - - - - 7ccf4806 by wurstsalat at 2022-11-17T17:38:46+01:00 fix: MessageActionsBox: Reintroduce gui_extension_point This is necessary when activating plugins after launch - - - - - d7121d8e by wurstsalat at 2022-11-18T14:07:32+01:00 fix: GroupchatRoster: Set visibility when hiding Hides the roster completely, so that the chat scrollbar is the right-most widget. Caveat: Un-reveal animation is gone - - - - - 23f90923 by wurstsalat at 2022-11-24T16:57:55+01:00 other: Remove obsolete htmltextview test - - - - - a3d7d6a3 by mjk at 2022-11-24T19:43:00+00:00 imprv: Prettify display of geographical locations - - - - - 42adccad by wurstsalat at 2022-11-24T20:54:40+01:00 refactor: MoreMenuButton: Use Gio.Menu Fixes #11262 - - - - - 01fd1b72 by wurstsalat at 2022-11-24T22:08:22+01:00 fix: Chatstates: Switch to Chatstate.ACTIVE after timeout - - - - - a6037e25 by wurstsalat at 2022-11-24T22:23:04+00:00 change: Add FileTransferSelector as a central page for sending files Fixes #9511 - - - - - 53d01bd6 by wurstsalat at 2022-11-24T23:33:00+01:00 refactor: Remove obsolete FileTransferSend dialog - - - - - 45033e89 by wurstsalat at 2022-11-25T15:14:42+01:00 refactor: Preview: Use Gio.Menu and Actions - - - - - 66d9ad4d by wurstsalat at 2022-11-25T15:25:54+01:00 cfix: Preferences: Use correct preview actions - - - - - 26f68c7f by wurstsalat at 2022-11-25T15:26:17+01:00 cfix: Menus: Fix linting error - - - - - b02f54d3 by wurstsalat at 2022-11-25T15:26:40+01:00 cq: File Choosers: Fix typo - - - - - 027b2d47 by wurstsalat at 2022-11-25T15:27:57+01:00 cfix: FileTransferSelector: Improve file choosing - - - - - 88daed91 by wurstsalat at 2022-11-25T16:24:19+01:00 cq: Contacts: Add more log output - - - - - b8c09a65 by wurstsalat at 2022-11-25T17:38:12+01:00 fix: SearchView: Set chat type correctly for ResultRows Fixes #11087 - - - - - 8e0f472a by wurstsalat at 2022-11-25T18:30:44+01:00 fix: ChatFunctionPage: Don't close control on cancelling join error Fixes #11116 - - - - - 44eab3c1 by wurstsalat at 2022-11-25T19:00:31+01:00 refactor: AvatarStorage: Access some methods directly - - - - - be7f2621 by wurstsalat at 2022-11-25T21:03:37+01:00 cq: Settings: Improve type annotations - - - - - 3c312d13 by wurstsalat at 2022-11-26T12:09:58+00:00 change: Jingle: Remove XTLS support XTLS has never been standardized, see https://datatracker.ietf.org/doc/html/draft-meyer-xmpp-e2e-encryption Gajim used this for file transfers, but there probably was no other client supporting this now obsolete feature. Today, using XEP-0396: Jingle Encrypted Transports - OMEMO would be the preferred solution. Part of #11160 - - - - - 30 changed files: - data/gajim.doap - gajim/common/configpaths.py - gajim/common/const.py - gajim/common/events.py - gajim/common/jingle_content.py - gajim/common/jingle_ft.py - gajim/common/jingle_ftstates.py - − gajim/common/jingle_xtls.py - gajim/common/modules/bytestream.py - gajim/common/modules/chatstates.py - gajim/common/modules/contacts.py - gajim/common/modules/discovery.py - gajim/common/modules/httpupload.py - gajim/common/modules/jingle.py - gajim/common/modules/user_avatar.py - gajim/common/modules/vcard_avatars.py - gajim/common/preview.py - gajim/common/preview_helpers.py - gajim/common/settings.py - gajim/common/socks5.py - gajim/data/gui/chat_control.ui - gajim/data/gui/file_transfer_send.ui → gajim/data/gui/file_transfer_selector.ui - gajim/data/gui/message_actions_box.ui - − gajim/data/gui/preview_context_menu.ui - − gajim/data/other/dh4096.pem - gajim/data/style/gajim.css - gajim/gtk/avatar.py - gajim/gtk/builder.pyi - gajim/gtk/chat_function_page.py - gajim/gtk/chat_list_row.py The diff was not included because it is too large. View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/90b70731c0b0f30a0579c733b74d772… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/90b70731c0b0f30a0579c733b74d772… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] cq: Settings: Improve type annotations
by Daniel Brötzmann (＠wurstsalat) 25 Nov '22

25 Nov '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: be7f2621 by wurstsalat at 2022-11-25T21:03:37+01:00 cq: Settings: Improve type annotations - - - - - 1 changed file: - gajim/common/settings.py Changes: ===================================== gajim/common/settings.py ===================================== @@ -17,11 +17,10 @@ from typing import Literal from typing import NamedTuple from typing import Optional -from typing import Dict -from typing import List from typing import Union from typing import overload from typing import cast +from typing import TypedDict import sys import json @@ -43,6 +42,7 @@ from gajim.common import optparser from gajim.common.storage.base import Encoder from gajim.common.storage.base import json_decoder +from gajim.common.setting_values import WorkspaceSettings from gajim.common.setting_values import APP_SETTINGS from gajim.common.setting_values import AllContactSettings from gajim.common.setting_values import AllContactSettingsT @@ -113,9 +113,19 @@ list[weakref.WeakMethod[_SignalCallable]]] if app.is_flatpak(): - OVERRIDES_PATH = Path('/app/app-overrides.json') + app_overrides = '/app/app-overrides.json' else: - OVERRIDES_PATH = Path('/etc/gajim/app-overrides.json') + app_overrides = '/etc/gajim/app-overrides.json' +OVERRIDES_PATH = Path(app_overrides) + + +class SettingsDictT(TypedDict): + app: dict[str, Any] + plugins: dict[str, dict[str, Any]] + workspaces: dict[str, dict[str, WorkspaceSettings]] + soundevents: dict[str, dict[str, Any]] + status_presets: dict[str, dict[str, str]] + proxies: dict[str, dict[str, Any]] class Settings: @@ -123,9 +133,10 @@ def __init__(self): self._con = cast(sqlite3.Connection, None) self._commit_scheduled = None - self._settings = {} + self._settings: SettingsDictT = {} self._app_overrides: dict[str, AllSettingsT] = {} - self._account_settings = {} + self._account_settings: dict[ + str, Union[Any, dict[str, dict[Union[JID, str], Any]]]] = {} self._callbacks: _CallbackDict = defaultdict(list) @@ -326,7 +337,7 @@ def _migrate(self) -> None: if version < 2: # Migrate open chats to new key and format for workspace in self._settings['workspaces'].values(): - open_chats = [] + open_chats: list[dict[str, Any]] = [] for open_chat in workspace.get('open_chats', []): account, jid, type_, pinned = open_chat open_chats.append({'account': account, @@ -433,6 +444,7 @@ def _migrate_encryption_settings(self) -> None: if account is None: continue + assert jid is not None encryption = settings.get('encryption') if not encryption: continue @@ -665,7 +677,7 @@ def get_plugin_setting(self, plugin: str, setting: str) -> SETTING_TYPE: except KeyError: return PLUGIN_SETTINGS[setting] - def get_plugins(self) -> List[str]: + def get_plugins(self) -> list[str]: return list(self._settings['plugins'].keys()) def set_plugin_setting(self, @@ -714,11 +726,11 @@ def remove_account(self, account: str) -> None: (account,)) self._commit() - def get_accounts(self) -> List[str]: + def get_accounts(self) -> list[str]: return list(self._account_settings.keys()) - def get_active_accounts(self) -> List[str]: - active = [] + def get_active_accounts(self) -> list[str]: + active: list[str] = [] for account in self._account_settings: if self.get_account_setting(account, 'active'): active.append(account) @@ -1102,7 +1114,9 @@ def set_soundevent_setting(self, self._commit_settings('soundevents') def get_soundevent_settings(self, - event_name: str) -> Dict[str, SETTING_TYPE]: + event_name: str + ) -> dict[str, SETTING_TYPE]: + if event_name not in DEFAULT_SOUNDEVENT_SETTINGS: raise ValueError(f'Invalid soundevent: {event_name}') @@ -1131,7 +1145,7 @@ def set_status_preset_setting(self, self._commit_settings('status_presets') - def get_status_preset_settings(self, status_preset: str) -> Dict[str, str]: + def get_status_preset_settings(self, status_preset: str) -> dict[str, str]: if status_preset not in self._settings['status_presets']: raise ValueError(f'Invalid status preset name: {status_preset}') @@ -1140,7 +1154,7 @@ def get_status_preset_settings(self, status_preset: str) -> Dict[str, str]: settings.update(user_settings) return settings - def get_status_presets(self) -> List[str]: + def get_status_presets(self) -> list[str]: return list(self._settings['status_presets'].keys()) def remove_status_preset(self, status_preset: str) -> None: @@ -1170,7 +1184,7 @@ def set_proxy_setting(self, self._commit_settings('proxies') - def get_proxy_settings(self, proxy_name: str) -> Dict[str, SETTING_TYPE]: + def get_proxy_settings(self, proxy_name: str) -> dict[str, SETTING_TYPE]: if proxy_name not in self._settings['proxies']: raise ValueError(f'Unknown proxy: {proxy_name}') @@ -1179,7 +1193,7 @@ def get_proxy_settings(self, proxy_name: str) -> Dict[str, SETTING_TYPE]: settings.update(user_settings) return settings - def get_proxies(self) -> List[str]: + def get_proxies(self) -> list[str]: return list(self._settings['proxies'].keys()) def add_proxy(self, proxy_name: str) -> None: @@ -1272,10 +1286,10 @@ def get_workspace_setting(self, def get_workspace_count(self) -> int: return len(self._settings['workspaces'].keys()) - def get_workspaces(self) -> List[str]: + def get_workspaces(self) -> list[str]: workspace_order = app.settings.get_app_setting('workspace_order') - def sort_workspaces(workspace_id): + def sort_workspaces(workspace_id: str) -> int: try: return workspace_order.index(workspace_id) except ValueError: View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/be7f2621924b2eaff12675888ccabb06… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/be7f2621924b2eaff12675888ccabb06… You're receiving this email because of your account on dev.gajim.org.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits