Commits

commits@gajim.org

17632 discussions

[Git][gajim/gajim][gajim_0.16] run tests with pyopenssl
by Yann Leboulanger 09 Aug '17

09 Aug '17

Yann Leboulanger pushed to branch gajim_0.16 at gajim / gajim Commits: 6ff534b0 by Yann Leboulanger at 2017-08-09T22:27:36+02:00 run tests with pyopenssl - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1,5 +1,5 @@ before_script: - - sudo apt-get update -qq && sudo apt-get install -y -qq libtool pkg-config libglib2.0-dev $(apt-cache depends gajim-nightly | grep Depends | sed "s/.*ends:\ //" | tr '\n' ' ') + - sudo apt-get update -qq && sudo apt-get install -y -qq libtool pkg-config libglib2.0-dev python-openssl $(apt-cache depends gajim-nightly | grep Depends | sed "s/.*ends:\ //" | tr '\n' ' ') - sudo apt-get build-dep -y -qq gajim-nightly stages: View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/6ff534b061f8c85444715d7a4910f2fb05… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/6ff534b061f8c85444715d7a4910f2fb05… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 5 commits: Fix running tests
by Yann Leboulanger 09 Aug '17

09 Aug '17

Yann Leboulanger pushed to branch master at gajim / gajim Commits: b5c3b15c by Yann Leboulanger at 2017-08-09T21:05:45+02:00 Fix running tests - - - - - 9ec14d35 by Yann Leboulanger at 2017-08-09T22:04:47+02:00 add .gitlab-ci.yml - - - - - 44a29e7a by Yann Leboulanger at 2017-08-09T22:09:01+02:00 make tests run without gui - - - - - c66669cc by Yann Leboulanger at 2017-08-09T22:21:48+02:00 clean download folder - - - - - fa993335 by Yann Leboulanger at 2017-08-09T22:24:36+02:00 Merge branch 'master' into 'master' run tests in gitlab-ci on every commits See merge request !114 - - - - - 10 changed files: - + .gitlab-ci.yml - Makefile.am - gajim/gajim.py - test/integration/test_resolver.py - test/integration/test_roster.py - test/lib/__init__.py - test/lib/gajim_mocks.py - test/runtests.py - test/unit/test_gui_interface.py - test/unit/test_sessions.py Changes: ===================================== .gitlab-ci.yml ===================================== --- /dev/null +++ b/.gitlab-ci.yml @@ -0,0 +1,42 @@ +before_script: + - sudo apt-get update -qq && sudo apt-get install -y -qq libtool pkg-config $(apt-cache depends gajim-default-nightly | grep Depends | sed "s/.*ends:\ //" | tr '\n' ' ') + - sudo apt-get build-dep -y -qq gajim-default-nightly + +stages: + - test + - build + +run-test: + stage: test + script: + - ./autogen.sh + - make test_nogui + +run-build: + stage: build + script: + - ./autogen.sh + - make dist + - export FN="gajim-default-"$(date +%F)".tar" + - mv gajim-*.tar.gz $FN.gz + - mkdir tmp_add_plugins + - mv $FN.gz tmp_add_plugins/ + - cd tmp_add_plugins/ + - tar xzf $FN.gz + - rm $FN.gz + - export GF=$(find . -maxdepth 1 -type d -name 'gajim-*') + - cd $GF/plugins/ + - curl -O https://ftp.gajim.org/plugins_1/plugin_installer.zip + - unzip plugin_installer.zip + - rm plugin_installer.zip + - cd ../.. + - tar czf ../$FN.gz gajim-* + - cd .. + - rm -rf tmp_add_plugins + - scp $FN.gz panoramix:/var/www/gajim/downloads/snap/ci/gajim-default-$CI_COMMIT_SHA.tar.gz + + artifacts: + name: "gajim-default-$CI_COMMIT_REF_NAME-$CI_COMMIT_SHA" + expire_in: 1 week + paths: + - gajim-default-2???-??-??.tar.gz ===================================== Makefile.am ===================================== --- a/Makefile.am +++ b/Makefile.am @@ -52,6 +52,10 @@ test: ${PYTHON} test/runtests.py .PHONY: test +test_nogui: + ${PYTHON} test/runtests.py -n +.PHONY: test_nogui + doc: epydoc --config=doc/epydoc.conf .PHONY: doc ===================================== gajim/gajim.py ===================================== --- a/gajim/gajim.py +++ b/gajim/gajim.py @@ -105,7 +105,8 @@ class GajimApplication(Gtk.Application): self.rng_seed = None GLib.set_prgname('gajim') - GLib.set_application_name('Gajim') + if GLib.get_application_name() != 'Gajim': + GLib.set_application_name('Gajim') def do_startup(self): Gtk.Application.do_startup(self) @@ -400,5 +401,6 @@ class GajimApplication(Gtk.Application): self.lookup_action(account + action_name).set_enabled(True) -app = GajimApplication() -app.run(sys.argv) +if __name__ == '__main__': + app = GajimApplication() + app.run(sys.argv) ===================================== test/integration/test_resolver.py ===================================== --- a/test/integration/test_resolver.py +++ b/test/integration/test_resolver.py @@ -5,6 +5,8 @@ import time import lib lib.setup_env() +from gi.repository import GLib + from common import resolver from mock import Mock, expectParams @@ -28,41 +30,38 @@ class TestResolver(unittest.TestCase): def setUp(self): self.idlequeue_thread = IdleQueueThread() self.idlequeue_thread.start() + self.main_context = GLib.MainContext() + self.main_context.push_thread_default() + self.main_loop = GLib.MainLoop(self.main_context) self.iq = self.idlequeue_thread.iq self._reset() self.resolver = None def tearDown(self): + self.main_context.pop_thread_default() self.idlequeue_thread.stop_thread() self.idlequeue_thread.join() def _reset(self): - self.flag = False self.expect_results = False - self.nslookup = False self.resolver = None - def testLibAsyncNSResolver(self): + def testGioResolver(self): self._reset() - if not resolver.USE_LIBASYNCNS: - print('testLibAsyncResolver: libasyncns-python not installed') - return - self.resolver = resolver.LibAsyncNSResolver() + self.resolver = resolver.GioResolver() - for name, type, expect_results in TEST_LIST: + for name, type_, expect_results in TEST_LIST: self.expect_results = expect_results - self._runLANSR(name, type) - self.flag = False + self._runGR(name, type_) - def _runLANSR(self, name, type): + def _runGR(self, name, type_): self.resolver.resolve( host = name, - type = type, + type_ = type_, on_ready = self._myonready) - while not self.flag: - time.sleep(1) - self.resolver.process() + + self.main_loop.run() def _myonready(self, name, result_set): if __name__ == '__main__': @@ -73,28 +72,11 @@ class TestResolver(unittest.TestCase): pprint('res.resolved_hosts: %s' % self.resolver.resolved_hosts) pprint('') if self.expect_results: - self.assert_(len(result_set) > 0) + self.assertTrue(len(result_set) > 0) else: - self.assert_(result_set == []) - self.flag = True - if self.nslookup: - self._testNSLR() + self.assertTrue(result_set == []) + self.main_loop.quit() - def testNSLookupResolver(self): - self._reset() - self.nslookup = True - self.resolver = resolver.NSLookupResolver(self.iq) - self.test_list = TEST_LIST - self._testNSLR() - - def _testNSLR(self): - if self.test_list == []: - return - name, type, self.expect_results = self.test_list.pop() - self.resolver.resolve( - host = name, - type = type, - on_ready = self._myonready) if __name__ == '__main__': unittest.main() ===================================== test/integration/test_roster.py ===================================== --- a/test/integration/test_roster.py +++ b/test/integration/test_roster.py @@ -20,16 +20,16 @@ class TestRosterWindow(unittest.TestCase): def setUp(self): gajim.interface = MockInterface() - self.C_NAME = roster_window.C_NAME - self.C_TYPE = roster_window.C_TYPE - self.C_JID = roster_window.C_JID - self.C_ACCOUNT = roster_window.C_ACCOUNT + self.C_NAME = roster_window.Column.NAME + self.C_TYPE = roster_window.Column.TYPE + self.C_JID = roster_window.Column.JID + self.C_ACCOUNT = roster_window.Column.ACCOUNT # Add after creating RosterWindow # We want to test the filling explicitly gajim.contacts = contacts_module.LegacyContactsAPI() gajim.connections = {} - self.roster = roster_window.RosterWindow() + self.roster = roster_window.RosterWindow(gajim.app) for acc in contacts: gajim.connections[acc] = MockConnection(acc) ===================================== test/lib/__init__.py ===================================== --- a/test/lib/__init__.py +++ b/test/lib/__init__.py @@ -50,3 +50,5 @@ def setup_env(): if use_x: import gtkgui_helpers gtkgui_helpers.GUI_DIR = gajim_root + '/data/gui' + from gajim import GajimApplication + gajim.app = GajimApplication() ===================================== test/lib/gajim_mocks.py ===================================== --- a/test/lib/gajim_mocks.py +++ b/test/lib/gajim_mocks.py @@ -107,6 +107,8 @@ class MockInterface(Mock): self.msg_win_mgr = Mock() self.roster = Mock() gajim.ged = ged.GlobalEventsDispatcher() + import plugins + gajim.plugin_manager = plugins.PluginManager() self.remote_ctrl = None self.instances = {} @@ -126,7 +128,8 @@ class MockInterface(Mock): class MockLogger(Mock): def __init__(self): - Mock.__init__(self, {'write': None, 'get_transports_type': {}}) + Mock.__init__(self, {'insert_into_logs': None, + 'get_transports_type': {}}) self.cur = Mock() ===================================== test/runtests.py ===================================== --- a/test/runtests.py +++ b/test/runtests.py @@ -39,7 +39,6 @@ modules = ( 'unit.test_protocol_caps', 'unit.test_caps_cache', 'unit.test_contacts', 'unit.test_account', - 'unit.test_gui_interface', ) if use_x: @@ -47,6 +46,7 @@ if use_x: #'integration.test_gui_event_integration', 'integration.test_roster', 'integration.test_resolver', + 'unit.test_gui_interface', ) nb_errors = 0 ===================================== test/unit/test_gui_interface.py ===================================== --- a/test/unit/test_gui_interface.py +++ b/test/unit/test_gui_interface.py @@ -20,8 +20,7 @@ class TestInterface(unittest.TestCase): def test_instantiation(self): ''' Test that we can proper initialize and do not fail on globals ''' - interface = Interface() - interface.run() + gajim.app.run() def test_links_regexp_entire(self): sut = Interface() ===================================== test/unit/test_sessions.py ===================================== --- a/test/unit/test_sessions.py +++ b/test/unit/test_sessions.py @@ -153,7 +153,7 @@ class TestChatControlSession(unittest.TestCase): sess = self.conn.sessions[jid]['123'] # message was logged - calls = gajim.logger.mockGetNamedCalls('write') + calls = gajim.logger.mockGetNamedCalls('insert_into_logs') self.assertEqual(1, len(calls)) # no ChatControl was open and autopopup was off @@ -171,7 +171,7 @@ class TestChatControlSession(unittest.TestCase): jid = 'bct(a)necronomicorp.com' fjid = 'bct(a)necronomicorp.com/Gajim' msgtxt = 'testing two' - roster = RosterWindow() + roster = RosterWindow(gajim.app) sess = self.conn.sessions[jid]['123'] sess.control = MockChatControl(fjid, account_name) @@ -179,7 +179,7 @@ class TestChatControlSession(unittest.TestCase): self.receive_chat_msg(fjid, msgtxt) # message was logged - calls = gajim.logger.mockGetNamedCalls('write') + calls = gajim.logger.mockGetNamedCalls('insert_into_logs') self.assertEqual(2, len(calls)) # the message does not go into the event queue @@ -207,7 +207,7 @@ class TestChatControlSession(unittest.TestCase): #self.receive_chat_msg(fjid, msgtxt) ## message was logged - #calls = gajim.logger.mockGetNamedCalls('write') + #calls = gajim.logger.mockGetNamedCalls('insert_into_logs') #self.assertEqual(1, len(calls)) ## the message does not go into the event queue View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/c57af6dade707439d6c87ddbf1502b89c… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/c57af6dade707439d6c87ddbf1502b89c… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][gajim_0.16] clean download folder
by Yann Leboulanger 09 Aug '17

09 Aug '17

Yann Leboulanger pushed to branch gajim_0.16 at gajim / gajim Commits: ea8d7a54 by Yann Leboulanger at 2017-08-09T22:21:05+02:00 clean download folder - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -33,7 +33,7 @@ run-build: - tar czf ../$FN.gz gajim-* - cd .. - rm -rf tmp_add_plugins - - scp $FN.gz panoramix:/var/www/gajim/downloads/snap/gajim-$CI_COMMIT_SHA.tar.gz + - scp $FN.gz panoramix:/var/www/gajim/downloads/snap/ci/gajim-$CI_COMMIT_SHA.tar.gz artifacts: name: "gajim-$CI_COMMIT_REF_NAME-$CI_COMMIT_SHA" View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/ea8d7a545ef174481756667013e2ceae68… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/ea8d7a545ef174481756667013e2ceae68… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][gajim_0.16] ability to run tests without gui
by Yann Leboulanger 09 Aug '17

09 Aug '17

Yann Leboulanger pushed to branch gajim_0.16 at gajim / gajim Commits: 0a28e0f0 by Yann Leboulanger at 2017-08-09T21:54:48+02:00 ability to run tests without gui - - - - - 6 changed files: - .gitlab-ci.yml - Makefile.am - src/common/connection_handlers_events.py - src/gtkgui_helpers.py - src/notify.py - test/runtests.py Changes: ===================================== .gitlab-ci.yml ===================================== --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -9,7 +9,8 @@ stages: run-test: stage: test script: - - make test + - ./autogen.sh + - make test_nogui run-build: stage: build ===================================== Makefile.am ===================================== --- a/Makefile.am +++ b/Makefile.am @@ -53,6 +53,10 @@ test: python test/runtests.py .PHONY: test +test_nogui: + python test/runtests.py -n +.PHONY: test_nogui + doc: epydoc --config=doc/epydoc.conf .PHONY: doc ===================================== src/common/connection_handlers_events.py ===================================== --- a/src/common/connection_handlers_events.py +++ b/src/common/connection_handlers_events.py @@ -41,8 +41,6 @@ from nbxmpp.protocol import NS_CHATSTATES from common.jingle_transport import JingleTransportSocks5 from common.file_props import FilesProp -import gtkgui_helpers - if gajim.HAVE_PYOPENSSL: import OpenSSL.crypto @@ -2484,8 +2482,6 @@ class NotificationEvent(nec.NetworkIncomingEvent): self.popup_title = _('New Message from %(nickname)s') % \ {'nickname': nick} - self.popup_image = gtkgui_helpers.get_icon_path(self.popup_image, 48) - if not gajim.config.get('notify_on_new_message') or \ not self.first_unread: self.do_popup = False @@ -2541,6 +2537,29 @@ class NotificationEvent(nec.NetworkIncomingEvent): self.do_popup = False + def get_path_to_generic_or_avatar(generic, jid=None, suffix=None): + """ + Choose between avatar image and default image + + Returns full path to the avatar image if it exists, otherwise returns + full path to the image. generic must be with extension and suffix + without + """ + if jid: + # we want an avatar + puny_jid = helpers.sanitize_filename(jid) + path_to_file = os.path.join(gajim.AVATAR_PATH, puny_jid) + suffix + path_to_local_file = path_to_file + '_local' + for extension in ('.png', '.jpeg'): + path_to_local_file_full = path_to_local_file + extension + if os.path.exists(path_to_local_file_full): + return path_to_local_file_full + for extension in ('.png', '.jpeg'): + path_to_file_full = path_to_file + extension + if os.path.exists(path_to_file_full): + return path_to_file_full + return os.path.abspath(generic) + def handle_incoming_pres_event(self, pres_obj): if gajim.jid_is_transport(pres_obj.jid): return True @@ -2619,8 +2638,8 @@ class NotificationEvent(nec.NetworkIncomingEvent): iconset = gajim.config.get('iconset') img_path = os.path.join(helpers.get_iconset_path(iconset), '48x48', show_image) - self.popup_image = gtkgui_helpers.get_path_to_generic_or_avatar( - img_path, jid=self.jid, suffix=suffix) + self.popup_image_path = self.get_path_to_generic_or_avatar(img_path, + jid=self.jid, suffix=suffix) self.popup_timeout = gajim.config.get('notification_timeout') @@ -2666,6 +2685,7 @@ class NotificationEvent(nec.NetworkIncomingEvent): self.popup_event_type = '' self.popup_msg_type = '' self.popup_image = '' + self.popup_image_path = '' self.popup_timeout = -1 self.do_command = False ===================================== src/gtkgui_helpers.py ===================================== --- a/src/gtkgui_helpers.py +++ b/src/gtkgui_helpers.py @@ -642,28 +642,6 @@ def make_pixbuf_grayscale(pixbuf): pixbuf.saturate_and_pixelate(pixbuf2, 0.0, False) return pixbuf2 -def get_path_to_generic_or_avatar(generic, jid = None, suffix = None): - """ - Choose between avatar image and default image - - Returns full path to the avatar image if it exists, otherwise returns full - path to the image. generic must be with extension and suffix without - """ - if jid: - # we want an avatar - puny_jid = helpers.sanitize_filename(jid) - path_to_file = os.path.join(gajim.AVATAR_PATH, puny_jid) + suffix - path_to_local_file = path_to_file + '_local' - for extension in ('.png', '.jpeg'): - path_to_local_file_full = path_to_local_file + extension - if os.path.exists(path_to_local_file_full): - return path_to_local_file_full - for extension in ('.png', '.jpeg'): - path_to_file_full = path_to_file + extension - if os.path.exists(path_to_file_full): - return path_to_file_full - return os.path.abspath(generic) - def decode_filechooser_file_paths(file_paths): """ Decode as UTF-8 under Windows and ask sys.getfilesystemencoding() in POSIX ===================================== src/notify.py ===================================== --- a/src/notify.py +++ b/src/notify.py @@ -155,8 +155,16 @@ class Notification: def _nec_notification(self, obj): if obj.do_popup: + if obj.popup_image: + icon_path = gtkgui_helpers.get_icon_path(obj.popup_image, 48) + if icon_path: + image_path = icon_path + elif obj.popup_image_path: + image_path = obj.popup_image_path + else: + image_path = '' popup(obj.popup_event_type, obj.jid, obj.conn.name, - obj.popup_msg_type, path_to_image=obj.popup_image, + obj.popup_msg_type, path_to_image=image_path, title=obj.popup_title, text=obj.popup_text, timeout=obj.popup_timeout) ===================================== test/runtests.py ===================================== --- a/test/runtests.py +++ b/test/runtests.py @@ -39,7 +39,6 @@ modules = ( 'unit.test_protocol_caps', 'unit.test_caps_cache', 'unit.test_contacts', 'unit.test_account', - 'unit.test_gui_interface', ) if use_x: @@ -47,6 +46,7 @@ if use_x: #'integration.test_gui_event_integration', 'integration.test_roster', 'integration.test_resolver', + 'unit.test_gui_interface', ) nb_errors = 0 View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/0a28e0f0665378263381d29a55d5d563ec… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/0a28e0f0665378263381d29a55d5d563ec… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][gajim_0.16] 2 commits: Add .gitlab-ci.yml
by Yann Leboulanger 08 Aug '17

08 Aug '17

Yann Leboulanger pushed to branch gajim_0.16 at gajim / gajim Commits: 200d58fe by Yann Leboulanger at 2017-08-08T21:20:05+02:00 Add .gitlab-ci.yml - - - - - 4612ba98 by Yann Leboulanger at 2017-08-08T21:43:04+02:00 Merge branch 'gajim_0.16' into 'gajim_0.16' Add .gitlab-ci.yml See merge request !113 - - - - - 1 changed file: - + .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== --- /dev/null +++ b/.gitlab-ci.yml @@ -0,0 +1,41 @@ +before_script: + - sudo apt-get update -qq && sudo apt-get install -y -qq libtool pkg-config libglib2.0-dev $(apt-cache depends gajim-nightly | grep Depends | sed "s/.*ends:\ //" | tr '\n' ' ') + - sudo apt-get build-dep -y -qq gajim-nightly + +stages: + - test + - build + +run-test: + stage: test + script: + - make test + +run-build: + stage: build + script: + - ./autogen.sh + - make dist + - export FN="gajim-"$(date +%F)".tar" + - mv gajim-*.tar.gz $FN.gz + - mkdir tmp_add_plugins + - mv $FN.gz tmp_add_plugins/ + - cd tmp_add_plugins/ + - tar xzf $FN.gz + - rm $FN.gz + - export GF=$(find . -maxdepth 1 -type d -name 'gajim-*') + - cd $GF/plugins/ + - curl -O https://ftp.gajim.org/plugins_0.16_zip/plugin_installer.zip + - unzip plugin_installer.zip + - rm plugin_installer.zip + - cd ../.. + - tar czf ../$FN.gz gajim-* + - cd .. + - rm -rf tmp_add_plugins + - scp $FN.gz panoramix:/var/www/gajim/downloads/snap/gajim-$CI_COMMIT_SHA.tar.gz + + artifacts: + name: "gajim-$CI_COMMIT_REF_NAME-$CI_COMMIT_SHA" + expire_in: 1 week + paths: + - gajim-2???-??-??.tar.gz View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/74dea79668973d3c4e00fe776c0ba7122… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/74dea79668973d3c4e00fe776c0ba7122… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Retract nickname from pubsub correctly
by Philipp Hörist 08 Aug '17

08 Aug '17

Philipp Hörist pushed to branch master at gajim / gajim Commits: c57af6da by Philipp Hörist at 2017-08-08T19:58:20+02:00 Retract nickname from pubsub correctly - - - - - 2 changed files: - gajim/common/connection_handlers.py - gajim/profile_window.py Changes: ===================================== gajim/common/connection_handlers.py ===================================== --- a/gajim/common/connection_handlers.py +++ b/gajim/common/connection_handlers.py @@ -836,8 +836,7 @@ class ConnectionPEP(object): def retract_nickname(self): if not self.pep_supported: return - self.send_nickname(None) - # not all client support new XEP, so we still retract + self._pubsub_connection.send_pb_retract('', nbxmpp.NS_NICK, '0') def send_location(self, info): ===================================== gajim/profile_window.py ===================================== --- a/gajim/profile_window.py +++ b/gajim/profile_window.py @@ -382,6 +382,7 @@ class ProfileWindow: nick = vcard_['NICKNAME'] gajim.connections[self.account].send_nickname(nick) if nick == '': + gajim.connections[self.account].retract_nickname() nick = gajim.config.get_per('accounts', self.account, 'name') gajim.nicks[self.account] = nick gajim.connections[self.account].send_vcard(vcard_) View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/c57af6dade707439d6c87ddbf1502b89c3… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/c57af6dade707439d6c87ddbf1502b89c3… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 7 commits: Use new DB API for logging status and errors
by Philipp Hörist 08 Aug '17

08 Aug '17

Philipp Hörist pushed to branch master at gajim / gajim Commits: 608655de by Philipp Hörist at 2017-08-08T14:41:55+02:00 Use new DB API for logging status and errors - - - - - 8c920b35 by Philipp Hörist at 2017-08-08T15:24:41+02:00 Move logging GC messages into connection_handlers - It should be where all other message received handlers are - Port to new DB API - - - - - 25a764a6 by Philipp Hörist at 2017-08-08T18:22:23+02:00 Port logging incoming messages to new DB API - - - - - f88e8d83 by Philipp Hörist at 2017-08-08T18:22:29+02:00 Remove old DB methods - - - - - c53e2b1b by Philipp Hörist at 2017-08-08T18:22:29+02:00 Dont try to insert if JID is already in DB - This is added because even an ignored INSERT raises the autoincrement value of the table. This means the jid id gets high really fast. - - - - - 10b08652 by Philipp Hörist at 2017-08-08T18:22:29+02:00 Refactor set_room_last_message_time() - Dont depend on get_jid_id(), this saves roundtrips - - - - - f3bdb596 by Philipp Hörist at 2017-08-08T18:53:25+02:00 Refactor remove_roster() - Execute as script to save roundtrips - - - - - 4 changed files: - gajim/common/connection_handlers.py - gajim/common/connection_handlers_events.py - gajim/common/logger.py - gajim/session.py Changes: ===================================== gajim/common/connection_handlers.py ===================================== --- a/gajim/common/connection_handlers.py +++ b/gajim/common/connection_handlers.py @@ -897,6 +897,8 @@ class ConnectionHandlersBase: self._nec_message_received) gajim.ged.register_event_handler('decrypted-message-received', ged.CORE, self._nec_decrypted_message_received) + gajim.ged.register_event_handler('gc-message-received', ged.CORE, + self._nec_gc_message_received) def cleanup(self): gajim.ged.remove_event_handler('iq-error-received', ged.CORE, @@ -911,6 +913,8 @@ class ConnectionHandlersBase: self._nec_message_received) gajim.ged.remove_event_handler('decrypted-message-received', ged.CORE, self._nec_decrypted_message_received) + gajim.ged.remove_event_handler('gc-message-received', ged.CORE, + self._nec_gc_message_received) def _nec_iq_error_received(self, obj): if obj.conn.name != self.name: @@ -1059,7 +1063,13 @@ class ConnectionHandlersBase: if gajim.config.get('log_contact_status_changes') and \ gajim.config.should_log(self.name, obj.jid): - gajim.logger.write('status', obj.jid, obj.status, obj.show) + show = gajim.logger.convert_show_values_to_db_api_values(obj.show) + if show is not None: + gajim.logger.insert_into_logs(nbxmpp.JID(obj.jid).getStripped(), + time_time(), + KindConstant.STATUS, + message=obj.status, + show=show) def _nec_gc_presence_received(self, obj): if obj.conn.name != self.name: @@ -1151,6 +1161,24 @@ class ConnectionHandlersBase: conn=self, msg_obj=obj)) return True + def _nec_gc_message_received(self, obj): + if gajim.config.should_log(obj.conn.name, obj.jid) and not \ + obj.timestamp < obj.conn.last_history_time[obj.jid] and obj.msgtxt and \ + obj.nick: + # if not obj.nick, it means message comes from room itself + # usually it hold description and can be send at each connection + # so don't store it in logs + gajim.logger.insert_into_logs(obj.jid, + obj.timestamp, + KindConstant.GC_MSG, + message=obj.msgtxt, + contact_name=obj.nick, + additional_data=obj.additional_data) + # store in memory time of last message logged. + # this will also be saved in rooms_last_message_time table + # when we quit this muc + obj.conn.last_history_time[obj.jid] = obj.timestamp + # process and dispatch an error message def dispatch_error_message(self, msg, msgtxt, session, frm, tim): error_msg = msg.getErrorMsg() @@ -1162,8 +1190,12 @@ class ConnectionHandlersBase: subject = msg.getSubject() if session.is_loggable(): - gajim.logger.write('error', frm, error_msg, tim=tim, - subject=subject) + gajim.logger.insert_into_logs(nbxmpp.JID(frm).getStripped(), + tim, + KindConstant.ERROR, + message=error_msg, + subject=subject) + gajim.nec.push_incoming_event(MessageErrorEvent(None, conn=self, fjid=frm, error_code=msg.getErrorCode(), error_msg=error_msg, msg=msgtxt, time_=tim, session=session, stanza=msg)) ===================================== gajim/common/connection_handlers_events.py ===================================== --- a/gajim/common/connection_handlers_events.py +++ b/gajim/common/connection_handlers_events.py @@ -932,7 +932,15 @@ class GcPresenceReceivedEvent(nec.NetworkIncomingEvent, HelperEvent): if jid: # we know real jid, save it in db st += ' (%s)' % jid - gajim.logger.write('gcstatus', self.fjid, st, self.show) + show = gajim.logger.convert_show_values_to_db_api_values(self.show) + if show is not None: + fjid = nbxmpp.JID(self.fjid) + gajim.logger.insert_into_logs(fjid.getStripped(), + time_time(), + KindConstant.GCSTATUS, + contact_name=fjid.getResource(), + message=st, + show=show) if self.avatar_sha == '': # contact has no avatar puny_nick = helpers.sanitize_filename(self.nick) @@ -1137,7 +1145,7 @@ class MessageReceivedEvent(nec.NetworkIncomingEvent, HelperEvent): base_network_events = ['raw-message-received'] def init(self): - self.additional_data = {} + self.additional_data = None def generate(self): self.conn = self.base_event.conn ===================================== gajim/common/logger.py ===================================== --- a/gajim/common/logger.py +++ b/gajim/common/logger.py @@ -122,8 +122,6 @@ class Logger: # db will be created in src/common/checks_paths.py return self.attach_cache_database() - gajim.ged.register_event_handler('gc-message-received', - ged.POSTCORE, self._nec_gc_message_received) @staticmethod def namedtuple_factory(cursor, row): @@ -328,7 +326,7 @@ class Logger: self.jids_already_in.append(jid) return jid_id - def convert_human_values_to_db_api_values(self, kind, show): + def convert_kind_values_to_db_api_values(self, kind): """ Convert from string style to constant ints for db """ @@ -349,25 +347,30 @@ class Logger: elif kind == 'error': kind_col = KindConstant.ERROR + return kind_col + + def convert_show_values_to_db_api_values(self, show): + """ + Convert from string style to constant ints for db + """ + if show == 'online': - show_col = ShowConstant.ONLINE + return ShowConstant.ONLINE elif show == 'chat': - show_col = ShowConstant.CHAT + return ShowConstant.CHAT elif show == 'away': - show_col = ShowConstant.AWAY + return ShowConstant.AWAY elif show == 'xa': - show_col = ShowConstant.XA + return ShowConstant.XA elif show == 'dnd': - show_col = ShowConstant.DND + return ShowConstant.DND elif show == 'offline': - show_col = ShowConstant.OFFLINE + return ShowConstant.OFFLINE elif show is None: - show_col = None + return ShowConstant.ONLINE else: # invisible in GC when someone goes invisible # it's a RFC violation .... but we should not crash - show_col = 'UNKNOWN' - - return kind_col, show_col + return None def convert_human_transport_type_to_db_api_values(self, type_): """ @@ -466,28 +469,6 @@ class Logger: if sub == SubscriptionConstant.BOTH: return 'both' - def commit_to_db(self, values, write_unread=False): - sql = '''INSERT INTO logs (jid_id, contact_name, time, kind, show, - message, subject, additional_data) VALUES (?, ?, ?, ?, ?, ?, ?, ?)''' - try: - self.cur.execute(sql, values) - except sqlite.OperationalError as e: - raise exceptions.PysqliteOperationalError(str(e)) - except sqlite.DatabaseError: - raise exceptions.DatabaseMalformed(LOG_DB_PATH) - message_id = None - if write_unread: - try: - self.con.commit() - message_id = self.cur.lastrowid - except sqlite.OperationalError as e: - print(str(e), file=sys.stderr) - else: - self._timeout_commit() - if message_id: - self.insert_unread_events(message_id, values[0]) - return message_id - def insert_unread_events(self, message_id, jid_id): """ Add unread message with id: message_id @@ -552,89 +533,6 @@ class Logger: all_messages.append((results, shown)) return all_messages - def write(self, kind, jid, message=None, show=None, tim=None, subject=None, - additional_data=None, mam_query=False): - """ - Write a row (status, gcstatus, message etc) to logs database - - kind can be status, gcstatus, gc_msg, (we only recv for those 3), - single_msg_recv, chat_msg_recv, chat_msg_sent, single_msg_sent we cannot - know if it is pm or normal chat message, we try to guess see - jid_is_from_pm() - - We analyze jid and store it as follows: - jids.jid text column will hold JID if TC-related, room_jid if GC-related, - ROOM_JID/nick if pm-related. - """ - - if additional_data is None: - additional_data = {} - if self.jids_already_in == []: # only happens if we just created the db - self.open_db() - - contact_name_col = None # holds nickname for kinds gcstatus, gc_msg - # message holds the message unless kind is status or gcstatus, - # then it holds status message - message_col = message - subject_col = subject - additional_data_col = json.dumps(additional_data) - if tim: - time_col = float(tim) - else: - time_col = float(time.time()) - - kind_col, show_col = self.convert_human_values_to_db_api_values(kind, - show) - - write_unread = False - try: - # now we may have need to do extra care for some values in columns - if kind == 'status': # we store (not None) time, jid, show, msg - # status for roster items - jid_id = self.get_jid_id(jid) - if show is None: # show is None (xmpp), but we say that 'online' - show_col = ShowConstant.ONLINE - - elif kind == 'gcstatus': - # status in ROOM (for pm status see status) - if show is None: # show is None (xmpp), but we say that 'online' - show_col = ShowConstant.ONLINE - jid, nick = jid.split('/', 1) - - # re-get jid_id for the new jid - jid_id = self.get_jid_id(jid, 'ROOM') - contact_name_col = nick - - elif kind == 'gc_msg': - if jid.find('/') != -1: # if it has a / - jid, nick = jid.split('/', 1) - else: - # it's server message f.e. error message - # when user tries to ban someone but he's not allowed to - nick = None - - # re-get jid_id for the new jid - jid_id = self.get_jid_id(jid, 'ROOM') - - contact_name_col = nick - else: - jid_id = self.get_jid_id(jid) - if kind == 'chat_msg_recv': - if not self.jid_is_from_pm(jid) and not mam_query: - # Save in unread table only if it's not a pm - write_unread = True - - if show_col == 'UNKNOWN': # unknown show, do not log - return - - values = (jid_id, contact_name_col, time_col, kind_col, show_col, - message_col, subject_col, additional_data_col) - return self.commit_to_db(values, write_unread) - - except (exceptions.DatabaseMalformed, - exceptions.PysqliteOperationalError) as error: - self.dispatch('DB_ERROR', error) - def get_last_conversation_lines(self, account, jid, pending): """ Get recent messages @@ -854,16 +752,21 @@ class Logger: return self.get_last_date_that_has_logs(account, jid) return row.time - def set_room_last_message_time(self, jid, time): + def set_room_last_message_time(self, jid, timestamp): """ - Set last time (in seconds since EPOCH) for which we had logs for that - room in rooms_last_message_time table + Set the timestamp of the last message we received in a room. + + :param jid: The jid + + :param timestamp: The timestamp in epoch """ - jid_id = self.get_jid_id(jid, 'ROOM') - # jid_id is unique in this table, create or update : - sql = 'REPLACE INTO rooms_last_message_time VALUES (%d, %d)' % \ - (jid_id, time) - self.simple_commit(sql) + self.insert_jid(jid, type_=JIDConstant.ROOM_TYPE) + + sql = '''REPLACE INTO rooms_last_message_time + VALUES ((SELECT jid_id FROM jids WHERE jid = ?), ?)''' + + self.con.execute(sql, (jid, timestamp)) + self._timeout_commit() def save_transport_type(self, jid, type_): """ @@ -1130,14 +1033,19 @@ class Logger: def remove_roster(self, account_jid): """ - Remove all entry from account_jid roster + Remove the roster of an account + + :param account_jid: The jid of the account """ - account_jid_id = self.get_jid_id(account_jid) - self.cur.execute('DELETE FROM roster_entry WHERE account_jid_id=?', - (account_jid_id,)) - self.cur.execute('DELETE FROM roster_group WHERE account_jid_id=?', - (account_jid_id,)) + jid_id = self.get_jid_id(account_jid) + + sql = ''' + DELETE FROM roster_entry WHERE account_jid_id = {jid_id}; + DELETE FROM roster_group WHERE account_jid_id = {jid_id}; + '''.format(jid_id=jid_id) + + self.con.executescript(sql) self._timeout_commit() def search_for_duplicate(self, jid, timestamp, msg): @@ -1181,10 +1089,13 @@ class Logger: :param type_: A JIDConstant """ - if kind == KindConstant.GC_MSG: + if jid in self.jids_already_in: + return + if kind in (KindConstant.GC_MSG, KindConstant.GCSTATUS): type_ = JIDConstant.ROOM_TYPE sql = 'INSERT OR IGNORE INTO jids (jid, type) VALUES (?, ?)' self.con.execute(sql, (jid, type_)) + self.jids_already_in.append(jid) self._timeout_commit() def insert_into_logs(self, jid, time_, kind, unread=True, **kwargs): @@ -1221,18 +1132,3 @@ class Logger: self._timeout_commit() return lastrowid - - def _nec_gc_message_received(self, obj): - tim_f = float(obj.timestamp) - tim_int = int(tim_f) - if gajim.config.should_log(obj.conn.name, obj.jid) and not \ - tim_int < obj.conn.last_history_time[obj.jid] and obj.msgtxt and \ - obj.nick: - # if not obj.nick, it means message comes from room itself - # usually it hold description and can be send at each connection - # so don't store it in logs - self.write('gc_msg', obj.fjid, obj.msgtxt, tim=obj.timestamp, additional_data=obj.additional_data) - # store in memory time of last message logged. - # this will also be saved in rooms_last_message_time table - # when we quit this muc - obj.conn.last_history_time[obj.jid] = tim_f ===================================== gajim/session.py ===================================== --- a/gajim/session.py +++ b/gajim/session.py @@ -21,6 +21,8 @@ ## along with Gajim. If not, see <http://www.gnu.org/licenses/>. ## +import nbxmpp + from common import helpers from common import events @@ -31,6 +33,7 @@ from common import contacts from common import ged from common.connection_handlers_events import ChatstateReceivedEvent, \ InformationEvent +from common.logger import KindConstant import message_control @@ -86,21 +89,13 @@ class ChatControlSession(stanza_session.EncryptedStanzaSession): if not obj.msgtxt and obj.chatstate is None: return - log_type = 'chat_msg' + log_type = KindConstant.CHAT_MSG_RECV + if obj.forwarded and obj.sent: + log_type = KindConstant.CHAT_MSG_SENT else: - log_type = 'single_msg' - end = '_recv' - if obj.forwarded and obj.sent: - end = '_sent' - log_type += end - - if self.is_loggable() and obj.msgtxt: - if obj.xhtml and gajim.config.get('log_xhtml_messages'): - msg_to_log = obj.xhtml - else: - msg_to_log = obj.msgtxt - obj.msg_log_id = gajim.logger.write(log_type, obj.fjid, - msg_to_log, tim=obj.timestamp, subject=obj.subject, additional_data=obj.additional_data) + log_type = KindConstant.SINGLE_MSG_RECV + if obj.forwarded and obj.sent: + log_type = KindConstant.SINGLE_MSG_SENT treat_as = gajim.config.get('treat_incoming_messages') if treat_as: @@ -111,6 +106,22 @@ class ChatControlSession(stanza_session.EncryptedStanzaSession): pm = True obj.mtype = 'pm' + if self.is_loggable() and obj.msgtxt: + if obj.xhtml and gajim.config.get('log_xhtml_messages'): + msg_to_log = obj.xhtml + else: + msg_to_log = obj.msgtxt + + jid = obj.fjid + if not pm: + jid = obj.jid + + obj.msg_log_id = gajim.logger.insert_into_logs( + jid, obj.timestamp, log_type, + message=msg_to_log, + subject=obj.subject, + additional_data=obj.additional_data) + # Handle chat states if contact and (not obj.forwarded or not obj.sent): if self.control and self.control.type_id == \ View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/635ce52856d4a71f4b2f9928e30bbe89d… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/635ce52856d4a71f4b2f9928e30bbe89d… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: PluginManager: remove plugin path from sys.path
by Philipp Hörist 07 Aug '17

07 Aug '17

Philipp Hörist pushed to branch master at gajim / gajim Commits: 7e0e4cce by Philipp Hörist at 2017-08-07T19:28:54+02:00 PluginManager: remove plugin path from sys.path Remove plugin path from sys.path after importing. If we scan multiple plugin dirs and never remove the path from sys.path, it is hard to predict from which path python will import a package. The chance that the same plugin package is in multiple plugin paths is high. - - - - - 635ce528 by Philipp Hörist at 2017-08-07T20:02:03+02:00 PluginManager: prefer plugins in user path As we always load plugins from the user path first, we should not reload them later from Gajims plugin base dir - - - - - 1 changed file: - gajim/plugins/pluginmanager.py Changes: ===================================== gajim/plugins/pluginmanager.py ===================================== --- a/gajim/plugins/pluginmanager.py +++ b/gajim/plugins/pluginmanager.py @@ -531,6 +531,11 @@ class PluginManager(metaclass=Singleton): try: if module_name in sys.modules: + if path == gajim.PLUGINS_DIRS[0]: + # Only reload plugins from Gajim base dir when they + # dont exist. This means plugins in the user path are + # always preferred. + continue from imp import reload log.info('Reloading %s', module_name) module = reload(sys.modules[module_name]) @@ -589,6 +594,7 @@ class PluginManager(metaclass=Singleton): log.debug('%s : %s' % (module_attr_name, 'wrong manifest file. section are required!')) + sys.path.remove(path) return plugins_found def install_from_zip(self, zip_filename, owerwrite=None): View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/413c7f52d7123248cbb9b2cce1f4ec99a… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/413c7f52d7123248cbb9b2cce1f4ec99a… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Add senders attr to Jingle FT
by Philipp Hörist 07 Aug '17

07 Aug '17

Philipp Hörist pushed to branch master at gajim / gajim Commits: 413c7f52 by Philipp Hörist at 2017-08-07T17:41:32+02:00 Add senders attr to Jingle FT This is a MUST see https://xmpp.org/extensions/xep-0234.html Fixes #8662 - - - - - 5 changed files: - gajim/common/jingle.py - gajim/common/jingle_content.py - gajim/common/jingle_ft.py - gajim/common/jingle_session.py - gajim/gui_interface.py Changes: ===================================== gajim/common/jingle.py ===================================== --- a/gajim/common/jingle.py +++ b/gajim/common/jingle.py @@ -163,9 +163,14 @@ class ConnectionJingle(object): transport = JingleTransportSocks5() elif contact.supports(nbxmpp.NS_JINGLE_IBB): transport = JingleTransportIBB() + + senders = 'initiator' + if request: + senders = 'responder' c = JingleFileTransfer(jingle, transport=transport, file_props=file_props, - use_security=use_security) + use_security=use_security, + senders=senders) file_props.algo = self.__hash_support(contact) jingle.add_content('file' + helpers.get_random_string_16(), c) jingle.start_session() ===================================== gajim/common/jingle_content.py ===================================== --- a/gajim/common/jingle_content.py +++ b/gajim/common/jingle_content.py @@ -42,7 +42,7 @@ class JingleContent: An abstraction of content in Jingle sessions """ - def __init__(self, session, transport): + def __init__(self, session, transport, senders): self.session = session self.transport = transport # will be filled by JingleSession.add_content() @@ -56,7 +56,10 @@ class JingleContent: self.media = None - self.senders = 'both' #FIXME + self.senders = senders + if self.senders is None: + self.senders = 'both' + self.allow_sending = True # Used for stream direction, attribute 'senders' # These were found by the Politie @@ -138,7 +141,9 @@ class JingleContent: if payload is None: payload = [] return nbxmpp.Node('content', - attrs={'name': self.name, 'creator': self.creator}, + attrs={'name': self.name, + 'creator': self.creator, + 'senders': self.senders}, payload=payload) def send_candidate(self, candidate): ===================================== gajim/common/jingle_ft.py ===================================== --- a/gajim/common/jingle_ft.py +++ b/gajim/common/jingle_ft.py @@ -58,8 +58,8 @@ class State(IntEnum): class JingleFileTransfer(JingleContent): def __init__(self, session, transport=None, file_props=None, - use_security=False): - JingleContent.__init__(self, session, transport) + use_security=False, senders=None): + JingleContent.__init__(self, session, transport, senders) log.info("transport value: %s", transport) # events we might be interested in self.callbacks['session-initiate'] += [self.__on_session_initiate] ===================================== gajim/common/jingle_session.py ===================================== --- a/gajim/common/jingle_session.py +++ b/gajim/common/jingle_session.py @@ -526,7 +526,7 @@ class JingleSession: contents, contents_rejected, reason_txt = self.__parse_contents(jingle) # If we are not receivin a file # Check if there's already a session with this user: - if contents[0][0] != 'file': + if contents[0].media != 'file': for session in self.connection.iter_jingle_sessions(self.peerjid): if session is not self: reason = nbxmpp.Node('reason') @@ -538,8 +538,7 @@ class JingleSession: else: # Stop if we don't have the requested file or the peer is not # allowed to request the file - request = \ - jingle.getTag('content').getTag('description').getTag('request') + request = contents[0].senders == 'responder' if request: self.request = True hash_tag = request.getTag('file').getTag('hash') @@ -568,7 +567,7 @@ class JingleSession: gajim.nec.push_incoming_event(JingleRequestReceivedEvent(None, conn=self.connection, jingle_session=self, - contents=contents)) + contents=contents[0])) def __broadcast(self, stanza, jingle, error, action): """ @@ -624,6 +623,7 @@ class JingleSession: contents_rejected = [] reasons = set() for element in jingle.iterTags('content'): + senders = element.getAttr('senders') transport = get_jingle_transport(element.getTag('transport')) if transport: transport.ourjid = self.ourjid @@ -631,10 +631,11 @@ class JingleSession: if content_type: try: if transport: - content = content_type(self, transport) + content = content_type( + self, transport=transport, senders=senders) self.add_content(element['name'], content, 'peer') - contents.append((content.media,)) + contents.append(content) else: reasons.add('unsupported-transports') contents_rejected.append((element['name'], 'peer')) @@ -711,12 +712,12 @@ class JingleSession: @staticmethod def __append_content(jingle, content): """ - Append <content/> element to <jingle/> element, with (full=True) or - without (full=False) <content/> children + Append <content/> element to <jingle/> element """ jingle.addChild('content', attrs={'name': content.name, - 'creator': content.creator}) + 'creator': content.creator, + 'senders': content.senders}) def __append_contents(self, jingle): """ ===================================== gajim/gui_interface.py ===================================== --- a/gajim/gui_interface.py +++ b/gajim/gui_interface.py @@ -1225,7 +1225,7 @@ class Interface: # TODO: conditional blocking if peer is not in roster account = obj.conn.name - content_types = set(c[0] for c in obj.contents) + content_types = obj.contents.media # check type of jingle session if 'audio' in content_types or 'video' in content_types: View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/413c7f52d7123248cbb9b2cce1f4ec99a1… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/413c7f52d7123248cbb9b2cce1f4ec99a1… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][gajim_0.16] fix running make test
by Yann Leboulanger 07 Aug '17

07 Aug '17

Yann Leboulanger pushed to branch gajim_0.16 at gajim / gajim Commits: 74dea796 by Yann Leboulanger at 2017-08-07T14:55:19+02:00 fix running make test - - - - - 1 changed file: - test/lib/gajim_mocks.py Changes: ===================================== test/lib/gajim_mocks.py ===================================== --- a/test/lib/gajim_mocks.py +++ b/test/lib/gajim_mocks.py @@ -25,6 +25,7 @@ class MockConnection(Mock, ConnectionHandlers): self.sessions = {} self.nested_group_delimiter = '::' self.received_message_hashes = [] + self.server_resource = 'Gajim' gajim.interface.instances[account] = {'infos': {}, 'disco': {}, 'gc_config': {}, 'search': {}, 'sub_request': {}} View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/74dea79668973d3c4e00fe776c0ba71226… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/74dea79668973d3c4e00fe776c0ba71226… You're receiving this email because of your account on dev.gajim.org.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits