Commits

commits@gajim.org

17632 discussions

[Git][gajim/gajim][gajim_1.1] update appveyor build script for version number
by Yann Leboulanger 15 Jan '19

15 Jan '19

Yann Leboulanger pushed to branch gajim_1.1 at gajim / gajim Commits: 8c0776e5 by Yann Leboulanger at 2019-01-15T20:48:29Z update appveyor build script for version number - - - - - 1 changed file: - appveyor.yml Changes: ===================================== appveyor.yml ===================================== @@ -32,8 +32,8 @@ build_script: bash "git clone C:/projects/gajim C:/msys64/home/appveyor/gajim" bash "C:/msys64/home/appveyor/gajim/win/build.sh $($env:MSYS_ARCH)" - Push-AppveyorArtifact "$($env:BUILDROOT)/Gajim.exe" -FileName "Gajim-1.1.1-$($env:ARCH)-$($env:TIME_STRING).exe" - Push-AppveyorArtifact "$($env:BUILDROOT)/Gajim-Portable.exe" -FileName "Gajim-Portable-1.1.1-$($env:ARCH)-$($env:TIME_STRING).exe" + Push-AppveyorArtifact "$($env:BUILDROOT)/Gajim.exe" -FileName "Gajim-1.1.2-$($env:ARCH)-$($env:TIME_STRING).exe" + Push-AppveyorArtifact "$($env:BUILDROOT)/Gajim-Portable.exe" -FileName "Gajim-Portable-1.1.2-$($env:ARCH)-$($env:TIME_STRING).exe" # on_finish: # - ps: $blockRdp = $true; iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/ci/master/scripts/enable-rdp.ps1')) View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/8c0776e53e31d4a7fb4169f54b86598edb… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/8c0776e53e31d4a7fb4169f54b86598edb… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim] Pushed new tag gajim-1.1.2
by Yann Leboulanger 15 Jan '19

15 Jan '19

Yann Leboulanger pushed new tag gajim-1.1.2 at gajim / gajim -- View it on GitLab: https://dev.gajim.org/gajim/gajim/tree/gajim-1.1.2 You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][gajim_1.1] prepare 1.1.2 release
by Yann Leboulanger 15 Jan '19

15 Jan '19

Yann Leboulanger pushed to branch gajim_1.1 at gajim / gajim Commits: 89276eee by Yann Leboulanger at 2019-01-15T20:18:31Z prepare 1.1.2 release - - - - - 3 changed files: - ChangeLog - data/org.gajim.Gajim.appdata.xml.in - gajim/__init__.py Changes: ===================================== ChangeLog ===================================== @@ -1,4 +1,4 @@ -Gajim 1.1.2 (11 January 2019) +Gajim 1.1.2 (15 January 2019) Bug fixes ===================================== data/org.gajim.Gajim.appdata.xml.in ===================================== @@ -101,6 +101,7 @@ <content_attribute id="money-gambling">none</content_attribute> </content_rating> <releases> + <release version="1.1.2" date="2019-01-15" /> <release version="1.1.1" date="2018-12-23" /> <release version="1.1.0" date="2018-11-06" /> <release version="1.0.3" date="2018-05-20" /> ===================================== gajim/__init__.py ===================================== @@ -1,7 +1,7 @@ import os import subprocess -__version__ = "1.1.1" +__version__ = "1.1.2" IS_FLATPAK = False if os.path.exists('/app/share/run-as-flatpak'): View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/89276eeeb32bec4012208a27a9e9184f11… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/89276eeeb32bec4012208a27a9e9184f11… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][gajim_1.1] update translations
by Yann Leboulanger 12 Jan '19

12 Jan '19

Yann Leboulanger pushed to branch gajim_1.1 at gajim / gajim Commits: 9c2a6390 by Yann Leboulanger at 2019-01-12T22:26:49Z update translations - - - - - 17 changed files: - po/be.po - po/be(a)latin.po - po/bg.po - po/br.po - po/ca.po - po/cs.po - po/da.po - po/de.po - po/el.po - po/en_GB.po - po/eo.po - po/es.po - po/eu.po - po/fr.po - po/gl.po - po/he.po - po/hr.po The diff was not included because it is too large. View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/9c2a63907e978335159dc212e942d71604… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/9c2a63907e978335159dc212e942d71604… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Jingle Audio: Add more log output
by Philipp Hörist 11 Jan '19

11 Jan '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: 72be14a0 by Philipp Hörist at 2019-01-11T20:53:34Z Jingle Audio: Add more log output - - - - - 1 changed file: - gajim/common/jingle_rtp.py Changes: ===================================== gajim/common/jingle_rtp.py ===================================== @@ -224,12 +224,15 @@ class JingleRTPContent(JingleContent): # TODO: Fix it to fallback to videotestsrc anytime an error occur, # or raise an error, Jingle way # or maybe one-sided stream? + gerror_msg = message.get_structure().get_value('gerror') + debug_msg = message.get_structure().get_value('debug') + log.error(gerror_msg) + log.error(debug_msg) if not self.stream_failed_once: app.nec.push_incoming_event( InformationEvent( None, dialog_name='gstreamer-error', - kwargs={'error': message.get_structure().get_value('gerror'), - 'debug': message.get_structure().get_value('debug')})) + kwargs={'error': gerror_msg, 'debug': debug_msg})) sink_pad = self.p2psession.get_property('sink-pad') View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/72be14a04d3eca7f191dc857f60233df35… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/72be14a04d3eca7f191dc857f60233df35… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Propagate presences further
by Philipp Hörist 11 Jan '19

11 Jan '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: b22f1bac by Philipp Hörist at 2019-01-11T19:45:11Z Propagate presences further Other modules like avatars and entity caps come after the base presence handlers - - - - - 4 changed files: - gajim/common/modules/caps.py - gajim/common/modules/muc.py - gajim/common/modules/presence.py - gajim/common/modules/vcard_avatars.py Changes: ===================================== gajim/common/modules/caps.py ===================================== @@ -38,7 +38,7 @@ class Caps: StanzaHandler(name='presence', callback=self._entity_caps, ns=nbxmpp.NS_CAPS, - priority=45), + priority=51), ] self._capscache = caps_cache.capscache ===================================== gajim/common/modules/muc.py ===================================== @@ -163,7 +163,7 @@ class MUC: def _on_muc_presence(self, _con, _stanza, properties): if properties.type == PresenceType.ERROR: self._raise_muc_event('muc-presence-error', properties) - raise nbxmpp.NodeProcessed + return def _on_muc_user_presence(self, _con, _stanza, properties): if properties.type == PresenceType.ERROR: @@ -175,7 +175,7 @@ class MUC: contact.presence = PresenceType.UNAVAILABLE log.info('MUC destroyed: %s', properties.jid.getBare()) self._raise_muc_event('muc-destroyed', properties) - raise nbxmpp.NodeProcessed + return contact = app.contacts.get_gc_contact(self._account, properties.jid.getBare(), @@ -189,7 +189,7 @@ class MUC: properties.jid, properties.muc_user.nick) self._raise_muc_event('muc-nickname-changed', properties) - raise nbxmpp.NodeProcessed + return if contact is None and properties.type.is_available: self._add_new_muc_contact(properties) @@ -199,16 +199,16 @@ class MUC: else: log.info('User joined: %s', properties.jid) self._raise_muc_event('muc-user-joined', properties) - raise nbxmpp.NodeProcessed + return if properties.is_muc_self_presence and properties.is_kicked: self._raise_muc_event('muc-self-kicked', properties) - raise nbxmpp.NodeProcessed + return if properties.is_muc_self_presence and properties.type.is_unavailable: # Its not a kick, so this is the reflection of our own # unavailable presence, because we left the MUC - raise nbxmpp.NodeProcessed + return if properties.type.is_unavailable: for _event in app.events.get_events(self._account, @@ -237,7 +237,7 @@ class MUC: app.contacts.remove_gc_contact(self._account, contact) log.info('User %s left', properties.jid) self._raise_muc_event('muc-user-left', properties) - raise nbxmpp.NodeProcessed + return if contact.affiliation != properties.affiliation: contact.affiliation = properties.affiliation @@ -263,8 +263,6 @@ class MUC: properties.show) self._raise_muc_event('muc-user-status-show-changed', properties) - raise nbxmpp.NodeProcessed - def _raise_muc_event(self, event_name, properties): app.nec.push_incoming_event( NetworkEvent(event_name, ===================================== gajim/common/modules/presence.py ===================================== @@ -65,25 +65,29 @@ class Presence: self.jids_for_auto_auth = [] def _presence_received(self, _con, stanza, properties): + if properties.from_muc: + # Already handled in MUC module + return + log.info('Received from %s', properties.jid) if properties.type == PresenceType.ERROR: log.info('Error: %s %s', properties.jid, properties.error) - raise nbxmpp.NodeProcessed + return if self._account == 'Local': app.nec.push_incoming_event( NetworkEvent('raw-pres-received', conn=self._con, stanza=stanza)) - raise nbxmpp.NodeProcessed + return if properties.is_self_presence: app.nec.push_incoming_event( NetworkEvent('our-show', conn=self._con, show=properties.show.value)) - raise nbxmpp.NodeProcessed + return contacts = app.contacts.get_jid_list(self._account) if properties.jid.getBare() not in contacts and not properties.is_self_bare: @@ -133,8 +137,6 @@ class Presence: app.nec.push_incoming_event(event_) - raise nbxmpp.NodeProcessed - def _update_contact(self, event, properties): # Note: A similar method also exists in connection_zeroconf jid = properties.jid.getBare() ===================================== gajim/common/modules/vcard_avatars.py ===================================== @@ -56,6 +56,9 @@ class VCardAvatars: app.config.set_per('accounts', self._account, 'avatar_sha', '') def _presence_received(self, _con, _stanza, properties): + if not properties.type.is_available: + return + if properties.avatar_state in (AvatarState.IGNORE, AvatarState.NOT_READY): return View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/b22f1baca5fb2cc664b80937d64ccfce67… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/b22f1baca5fb2cc664b80937d64ccfce67… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] DiscoveryWindow: Fix bookmarking a group chat
by Philipp Hörist 10 Jan '19

10 Jan '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: 4f2f2195 by Philipp Hörist at 2019-01-10T22:40:08Z DiscoveryWindow: Fix bookmarking a group chat Fixes #9537 - - - - - 1 changed file: - gajim/gtk/discovery.py Changes: ===================================== gajim/gtk/discovery.py ===================================== @@ -1717,7 +1717,7 @@ class MucBrowser(AgentBrowser): con.get_module('Bookmarks').add_bookmark(room_jid.split('@')[0], room_jid, False, - '' + '', '') InformationDialog( View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/4f2f2195aa50e0bf9ad429e7e5ef44c62f… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/4f2f2195aa50e0bf9ad429e7e5ef44c62f… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][gajim_1.1] 2 commits: DiscoveryWindow: Fix bookmarking a group chat
by Philipp Hörist 10 Jan '19

10 Jan '19

Philipp Hörist pushed to branch gajim_1.1 at gajim / gajim Commits: c6d0dd3d by Philipp Hörist at 2019-01-10T22:37:36Z DiscoveryWindow: Fix bookmarking a group chat Fixes #9537 - - - - - de088564 by Philipp Hörist at 2019-01-10T22:38:30Z Update ChangeLog - - - - - 2 changed files: - ChangeLog - gajim/disco.py Changes: ===================================== ChangeLog ===================================== @@ -6,6 +6,7 @@ Gajim 1.1.2 (11 January 2019) * #9522 Windows: Switching keyboard layouts leads to a crash * #9525 Windows/Mac: Links are not clickable in the About dialog * #9535 Jingle Audio: Update codecs + * #9537 DiscoveryWindow: Fix bookmarking a group chat * DBus: Correctly raise NewMessage signal * Clicking on tray notifications does not open the chat ===================================== gajim/disco.py ===================================== @@ -1727,7 +1727,7 @@ class MucBrowser(AgentBrowser): room_jid, False, False, - '' + '', '') InformationDialog( View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/48f1df0bfbe78b388ece192965b8b6cda… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/48f1df0bfbe78b388ece192965b8b6cda… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][gajim_1.1] 3 commits: DBus: Correctly raise NewMessage signal
by Philipp Hörist 10 Jan '19

10 Jan '19

Philipp Hörist pushed to branch gajim_1.1 at gajim / gajim Commits: 3841ed51 by Philipp Hörist at 2019-01-10T21:34:08Z DBus: Correctly raise NewMessage signal - - - - - caf95ead by streaps at 2019-01-10T21:34:08Z Jingle Audio: Update codecs Fixes #9535 - - - - - 48f1df0b by Philipp Hörist at 2019-01-10T21:38:29Z Update ChangeLog - - - - - 4 changed files: - ChangeLog - gajim/common/jingle_rtp.py - gajim/remote_control.py - gajim/session.py Changes: ===================================== ChangeLog ===================================== @@ -1,20 +1,31 @@ +Gajim 1.1.2 (11 January 2019) + + Bug fixes + + * #9518 Windows: Pressing "^" yields "^^" + * #9522 Windows: Switching keyboard layouts leads to a crash + * #9525 Windows/Mac: Links are not clickable in the About dialog + * #9535 Jingle Audio: Update codecs + * DBus: Correctly raise NewMessage signal + * Clicking on tray notifications does not open the chat + Gajim 1.1.1 (23 December 2018) Bug fixes - * 8362 DBus: Incorrect unread message count - * 9427 Placeholder not cleared if pasting text into message input - * 9444 Determine the delay timestamp correctly when using mam:1 - * 9453 Fix opening links inside the group chat subject (MacOS/Windows) - * 9465 Allow the full range of possible nicknames in group chats - * 9067 Gajim crashes when receiving xhtml messages - * 9096 Error when clicking on a subscription notification - * 9446 Chatstate error in MUC conversation - * 9471 Conversation Textview: Error on key press - * 9472 Handle presences without from attr correctly - * 9473 Error when creating a new group chat - * 9491 Identify group chat subject changes correctly - * 9496 Error on MUC roster selection change + * #8362 DBus: Incorrect unread message count + * #9427 Placeholder not cleared if pasting text into message input + * #9444 Determine the delay timestamp correctly when using mam:1 + * #9453 Fix opening links inside the group chat subject (MacOS/Windows) + * #9465 Allow the full range of possible nicknames in group chats + * #9067 Gajim crashes when receiving xhtml messages + * #9096 Error when clicking on a subscription notification + * #9446 Chatstate error in MUC conversation + * #9471 Conversation Textview: Error on key press + * #9472 Handle presences without from attr correctly + * #9473 Error when creating a new group chat + * #9491 Identify group chat subject changes correctly + * #9496 Error on MUC roster selection change * Determine soundplayer correctly on unix systems * In some circumstances plugins could not be deleted * Show correct contact status on tabs @@ -36,13 +47,13 @@ Gajim 1.1.0 (06 November 2018) Bug fixes - * 8968 Windows: Gajim loads DLLs from wrong location - * 9322 Error when adding contact - * 9357 Acquire sleep inhibtor correctly after sleep - * 9385 Ignore invalid bookmarks - * 9386 Discovery: Browsing nodes without identity - * 9393 Error when parsing invalid timestamps - * 9398 Error on jingle file transfer + * #8968 Windows: Gajim loads DLLs from wrong location + * #9322 Error when adding contact + * #9357 Acquire sleep inhibtor correctly after sleep + * #9385 Ignore invalid bookmarks + * #9386 Discovery: Browsing nodes without identity + * #9393 Error when parsing invalid timestamps + * #9398 Error on jingle file transfer Gajim 1.0.99.1 (07 October 2018) @@ -59,17 +70,17 @@ Gajim 1.0.99.1 (07 October 2018) Bug fixes - * 9198 Creating new MUCs with captial letters is not possible - * 9210 Error when clicking on new message indicator - * 9280 Inviting users to a MUC causes error - * 9301 Error when opening service discovery window - * 9309 Error when clicking on a groupchat invite notification - * 9311 Error when requesting server info - * 9117 Windows UAC changes status not available - * 9324 No menus/dialogs on Win7 - * 9326 IPV6 Connection problem on Win10 - * 9334 Joining big MUCs takes very long - * 9339 Error caused by remote_control + * #9198 Creating new MUCs with captial letters is not possible + * #9210 Error when clicking on new message indicator + * #9280 Inviting users to a MUC causes error + * #9301 Error when opening service discovery window + * #9309 Error when clicking on a groupchat invite notification + * #9311 Error when requesting server info + * #9117 Windows UAC changes status not available + * #9324 No menus/dialogs on Win7 + * #9326 IPV6 Connection problem on Win10 + * #9334 Joining big MUCs takes very long + * #9339 Error caused by remote_control Gajim 1.0.99 (19 August 2018) @@ -92,16 +103,16 @@ Gajim 1.0.99 (19 August 2018) Bug fixes - * 8658 Translation doesnt work on Windows - * 8750 Increase time frame for duplicate search in MUCs - * 9138 Translation in Flatpak does not work - * 9140 Error when clicking on the notification of an incoming message - * 9159 Wrong form type when responding to a voice request - * 9069 Send cancel IQ if muc configuration is aborted - * 9167 Flatpak fails to determine locale settings - * 9171 Gajim requests vcard multiple times - * 9198 Creating new MUCs with capital letters is not possible - * 9211 Punycode and Unicode with Internationalized Domain Names + * #8658 Translation doesnt work on Windows + * #8750 Increase time frame for duplicate search in MUCs + * #9138 Translation in Flatpak does not work + * #9140 Error when clicking on the notification of an incoming message + * #9159 Wrong form type when responding to a voice request + * #9069 Send cancel IQ if muc configuration is aborted + * #9167 Flatpak fails to determine locale settings + * #9171 Gajim requests vcard multiple times + * #9198 Creating new MUCs with capital letters is not possible + * #9211 Punycode and Unicode with Internationalized Domain Names Other changes @@ -123,9 +134,9 @@ Gajim 1.0.3 (20 May 2018) Bugs fixed: - * 8296 Fix errors on roster updates after stream management resume - * 9106 Convert font weight from pango to css values - * 9124 Bring ChatControl to front when notification is clicked + * #8296 Fix errors on roster updates after stream management resume + * #9106 Convert font weight from pango to css values + * #9124 Bring ChatControl to front when notification is clicked * Set no-store hint on groupchat chatstates * Dont show OOB uri if message body is the same @@ -139,26 +150,26 @@ Gajim 1.0.2 (30 April 2018) Bugs fixed: - * 7879 Server name is rejected for group chat bookmarks - * 8964 setup.py install misses some files if used with "--skip-build" - * 9017 Password was sometimes stored in plaintext - * 9022 Dont show error when receiving invalid avatars - * 9031 Windows: Always hide roster window on X - * 9038 No License in About dialog - * 9039 Encode filenames before sending - * 9044 Catch invalid IQ stanzas and log them - * 9049 XMPP logo in "Add New Contact" window instead Gajim logo - * 9050 Mark some strings as translatable - * 9054 Error on file send completion - * 9055 Removing a bookmark causes error - * 9057 Avatar is deleted when updating vCard - * 9065 Account label isn't change in tooltip of notification area icon - * 9066 Placeholder text does't disappear - * 9068 Missing pulseaudio in Flatpak image - * 9070 Fix History Manager search - * 9074 Proxy comobobox in accounts/connections doesn't get update after ManageProxies - * 9094 problem receiving file - * 9101 Notification never autohides in gnome + * #7879 Server name is rejected for group chat bookmarks + * #8964 setup.py install misses some files if used with "--skip-build" + * #9017 Password was sometimes stored in plaintext + * #9022 Dont show error when receiving invalid avatars + * #9031 Windows: Always hide roster window on X + * #9038 No License in About dialog + * #9039 Encode filenames before sending + * #9044 Catch invalid IQ stanzas and log them + * #9049 XMPP logo in "Add New Contact" window instead Gajim logo + * #9050 Mark some strings as translatable + * #9054 Error on file send completion + * #9055 Removing a bookmark causes error + * #9057 Avatar is deleted when updating vCard + * #9065 Account label isn't change in tooltip of notification area icon + * #9066 Placeholder text does't disappear + * #9068 Missing pulseaudio in Flatpak image + * #9070 Fix History Manager search + * #9074 Proxy comobobox in accounts/connections doesn't get update after ManageProxies + * #9094 problem receiving file + * #9101 Notification never autohides in gnome * Correctly reload Plugins * Save history export with utf8 encoding ===================================== gajim/common/jingle_rtp.py ===================================== @@ -301,8 +301,9 @@ class JingleRTPContent(JingleContent): attrs = { 'name': codec.encoding_name, 'id': codec.id, - 'channels': codec.channels } + if codec.channels > 0: + attrs['channels'] = codec.channels if codec.clock_rate: attrs['clockrate'] = codec.clock_rate if codec.optional_params: @@ -350,18 +351,35 @@ class JingleAudio(JingleRTPContent): def setup_stream(self): JingleRTPContent.setup_stream(self, self._on_src_pad_added) - # Configure SPEEX - # Workaround for psi (not needed since rev - # 147aedcea39b43402fe64c533d1866a25449888a): - # place 16kHz before 8kHz, as buggy psi versions will take in - # account only the first codec - - codecs = [ + # list of codecs that are explicitly allowed + allow_codecs = [ + Farstream.Codec.new(Farstream.CODEC_ID_ANY, 'OPUS', + Farstream.MediaType.AUDIO, 48000), + Farstream.Codec.new(Farstream.CODEC_ID_ANY, 'SPEEX', + Farstream.MediaType.AUDIO, 32000), Farstream.Codec.new(Farstream.CODEC_ID_ANY, 'SPEEX', Farstream.MediaType.AUDIO, 16000), + Farstream.Codec.new(Farstream.CODEC_ID_ANY, 'G722', + Farstream.MediaType.AUDIO, 8000), Farstream.Codec.new(Farstream.CODEC_ID_ANY, 'SPEEX', + Farstream.MediaType.AUDIO, 8000), + Farstream.Codec.new(Farstream.CODEC_ID_ANY, 'PCMA', + Farstream.MediaType.AUDIO, 8000), + Farstream.Codec.new(Farstream.CODEC_ID_ANY, 'PCMU', Farstream.MediaType.AUDIO, 8000)] - self.p2psession.set_codec_preferences(codecs) + + # disable all other codecs + disable_codecs = [] + codecs_without_config = self.p2psession.props.codecs_without_config + allowed_encoding_names = [c.encoding_name for c in allow_codecs] + ['telephone-event'] + for codec in codecs_without_config: + if codec.encoding_name not in allowed_encoding_names: + disable_codecs.append(Farstream.Codec.new(Farstream.CODEC_ID_DISABLE, + codec.encoding_name, + Farstream.MediaType.AUDIO, + codec.clock_rate)) + + self.p2psession.set_codec_preferences(allow_codecs + disable_codecs) # the local parts # TODO: Add queues? ===================================== gajim/remote_control.py ===================================== @@ -312,6 +312,8 @@ class GajimRemote(Server): ged.POSTGUI, self.on_unsubscribed_presence_received) app.ged.register_event_handler('gc-message-received', ged.POSTGUI, self.on_gc_message_received) + app.ged.register_event_handler('decrypted-message-received', + ged.POSTGUI, self._nec_decrypted_message_received) app.ged.register_event_handler('our-show', ged.POSTGUI, self.on_our_status) app.ged.register_event_handler('account-created', ged.POSTGUI, @@ -388,6 +390,12 @@ class GajimRemote(Server): obj.timestamp, obj.delayed, obj.xhtml_msgtxt, obj.status_code, obj.displaymarking, obj.captcha_form, obj.needs_highlight])) + def _nec_decrypted_message_received(self, obj): + self.raise_signal('NewMessage', ( + obj.conn.name, [obj.fjid, obj.msgtxt, obj.timestamp, + obj.encrypted, obj.mtype, obj.subject, + obj.msg_log_id, obj.user_nick, obj.xhtml, obj.form_node])) + def on_our_status(self, obj): self.raise_signal('AccountPresence', (obj.show, obj.conn.name)) ===================================== gajim/session.py ===================================== @@ -166,12 +166,6 @@ class ChatControlSession: if not pm: self.roster_message2(obj) - if app.interface.remote_ctrl: - app.interface.remote_ctrl.raise_signal('NewMessage', ( - self.conn.name, [obj.fjid, obj.msgtxt, obj.timestamp, - obj.encrypted, obj.mtype, obj.subject, - obj.msg_log_id, obj.user_nick, obj.xhtml, obj.form_node])) - def roster_message2(self, obj): """ Display the message or show notification in the roster View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/60f8c52c3acf6836efa7a30caec14e89e… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/60f8c52c3acf6836efa7a30caec14e89e… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Jingle Audio: Update codecs
by Philipp Hörist 10 Jan '19

10 Jan '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: 88439091 by streaps at 2019-01-10T21:28:00Z Jingle Audio: Update codecs Fixes #9535 - - - - - 1 changed file: - gajim/common/jingle_rtp.py Changes: ===================================== gajim/common/jingle_rtp.py ===================================== @@ -301,8 +301,9 @@ class JingleRTPContent(JingleContent): attrs = { 'name': codec.encoding_name, 'id': codec.id, - 'channels': codec.channels } + if codec.channels > 0: + attrs['channels'] = codec.channels if codec.clock_rate: attrs['clockrate'] = codec.clock_rate if codec.optional_params: @@ -350,18 +351,35 @@ class JingleAudio(JingleRTPContent): def setup_stream(self): JingleRTPContent.setup_stream(self, self._on_src_pad_added) - # Configure SPEEX - # Workaround for psi (not needed since rev - # 147aedcea39b43402fe64c533d1866a25449888a): - # place 16kHz before 8kHz, as buggy psi versions will take in - # account only the first codec - - codecs = [ + # list of codecs that are explicitly allowed + allow_codecs = [ + Farstream.Codec.new(Farstream.CODEC_ID_ANY, 'OPUS', + Farstream.MediaType.AUDIO, 48000), + Farstream.Codec.new(Farstream.CODEC_ID_ANY, 'SPEEX', + Farstream.MediaType.AUDIO, 32000), Farstream.Codec.new(Farstream.CODEC_ID_ANY, 'SPEEX', Farstream.MediaType.AUDIO, 16000), + Farstream.Codec.new(Farstream.CODEC_ID_ANY, 'G722', + Farstream.MediaType.AUDIO, 8000), Farstream.Codec.new(Farstream.CODEC_ID_ANY, 'SPEEX', + Farstream.MediaType.AUDIO, 8000), + Farstream.Codec.new(Farstream.CODEC_ID_ANY, 'PCMA', + Farstream.MediaType.AUDIO, 8000), + Farstream.Codec.new(Farstream.CODEC_ID_ANY, 'PCMU', Farstream.MediaType.AUDIO, 8000)] - self.p2psession.set_codec_preferences(codecs) + + # disable all other codecs + disable_codecs = [] + codecs_without_config = self.p2psession.props.codecs_without_config + allowed_encoding_names = [c.encoding_name for c in allow_codecs] + ['telephone-event'] + for codec in codecs_without_config: + if codec.encoding_name not in allowed_encoding_names: + disable_codecs.append(Farstream.Codec.new(Farstream.CODEC_ID_DISABLE, + codec.encoding_name, + Farstream.MediaType.AUDIO, + codec.clock_rate)) + + self.p2psession.set_codec_preferences(allow_codecs + disable_codecs) # the local parts # TODO: Add queues? View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/88439091b0a6a0b342d34f7c7fc6fc90d1… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/88439091b0a6a0b342d34f7c7fc6fc90d1… You're receiving this email because of your account on dev.gajim.org.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits