Commits

commits@gajim.org

17632 discussions

[Git][gajim/gajim][master] Fix invalid JID
by Philipp Hörist 03 Jul '19

03 Jul '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: fa5c3525 by Philipp Hörist at 2019-07-03T18:22:55Z Fix invalid JID Fixes #9752 - - - - - 1 changed file: - gajim/session.py Changes: ===================================== gajim/session.py ===================================== @@ -71,8 +71,10 @@ class ChatControlSession: self.jid.getStripped()) def get_to(self): - to = str(self.jid) - return app.get_jid_without_resource(to) + '/' + self.resource + bare_jid = self.jid.getBare() + if not self.resource: + return bare_jid + return bare_jid + '/' + self.resource def _nec_decrypted_message_received(self, obj): """ View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/fa5c352518bb9a8d341a375e23707e9212… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/fa5c352518bb9a8d341a375e23707e9212… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: update translations
by Yann Leboulanger 03 Jul '19

03 Jul '19

Yann Leboulanger pushed to branch master at gajim / gajim Commits: 4a979948 by Yann Leboulanger at 2019-07-03T15:32:57Z update translations - - - - - d4b9b496 by Yann Leboulanger at 2019-07-03T15:34:20Z Merge branch 'master' of dev.gajim.org:gajim/gajim - - - - - 30 changed files: - po/be.po - po/be(a)latin.po - po/bg.po - po/br.po - po/ca.po - po/cs.po - po/da.po - po/de.po - po/el.po - po/en_GB.po - po/eo.po - po/es.po - po/eu.po - po/fr.po - po/gl.po - po/he.po - po/hr.po - po/hu.po - po/it.po - po/ja.po - po/kk.po - po/lt.po - po/nb_NO.po - po/nl.po - po/pl.po - po/pt.po - po/pt_BR.po - po/ru.po - po/sk.po - po/sr.po The diff was not included because it is too large. View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/b0697272d5d4cbba97a1bd567c608ac73… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/b0697272d5d4cbba97a1bd567c608ac73… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Get identity category and type correctly
by Philipp Hörist 03 Jul '19

03 Jul '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: b0697272 by Daniel Brötzmann at 2019-07-03T13:09:53Z Get identity category and type correctly - - - - - 1 changed file: - gajim/common/caps_cache.py Changes: ===================================== gajim/common/caps_cache.py ===================================== @@ -80,8 +80,8 @@ def get_client_identity(client_caps): cache_item = lookup_item(capscache) for identity in cache_item.identities: - if identity.get('category') == 'client': - return identity.get('type') + if identity.category == 'client': + return identity.type def create_suitable_client_caps(node, caps_hash, hash_method, fjid=None): """ View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/b0697272d5d4cbba97a1bd567c608ac73f… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/b0697272d5d4cbba97a1bd567c608ac73f… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] MUC: Add possibility to override default config
by Philipp Hörist 02 Jul '19

02 Jul '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: 7ee22d83 by Philipp Hörist at 2019-07-02T19:53:32Z MUC: Add possibility to override default config - - - - - 3 changed files: - gajim/common/modules/muc.py - gajim/common/structs.py - gajim/gui_interface.py Changes: ===================================== gajim/common/modules/muc.py ===================================== @@ -130,11 +130,12 @@ class MUC(BaseModule): def get_mucs_with_state(self, states): return [muc for muc in self._muc_data.values() if muc.state in states] - def join(self, room_jid, nick, password, rejoin=False): + def join(self, room_jid, nick, password, rejoin=False, config=None): if not app.account_is_connected(self._account): return - self._muc_data[room_jid] = MUCData(room_jid, nick, password, rejoin) + self._muc_data[room_jid] = MUCData(room_jid, nick, + password, rejoin, config) self._con.get_module('Discovery').disco_muc( room_jid, partial(self._join, room_jid)) @@ -182,16 +183,19 @@ class MUC(BaseModule): return self._log.info('Configure room: %s', result.jid) - self._apply_config(result.form) + + muc = self._get_muc_data(result.jid) + self._apply_config(result.form, muc.config) self.set_config(result.jid, result.form, callback=self._on_config_result) @staticmethod def _apply_config(form, config=None): - if config is None: - config = get_default_muc_config() - for var, value in config.items(): + default_config = get_default_muc_config() + if config is not None: + default_config.update(config) + for var, value in default_config.items(): try: field = form[var] except KeyError: ===================================== gajim/common/structs.py ===================================== @@ -24,11 +24,12 @@ CapsIdentity = namedtuple('CapsIdentity', 'category type name lang') class MUCData: - def __init__(self, room_jid, nick, password, rejoin): + def __init__(self, room_jid, nick, password, rejoin, config=None): self._room_jid = room_jid self._nick = nick self._password = password self._rejoin = rejoin + self._config = config self._state = MUCJoinedState.NOT_JOINED @property @@ -62,3 +63,7 @@ class MUCData: @rejoin.setter def rejoin(self, value): self._rejoin = value + + @property + def config(self): + return self._config ===================================== gajim/gui_interface.py ===================================== @@ -1568,7 +1568,7 @@ class Interface: ################################################################################ def join_gc_room(self, account, room_jid, nick, password, minimize=False, - is_continued=False): + is_continued=False, config=None): """ Join the room immediately """ @@ -1628,7 +1628,7 @@ class Interface: # Connect app.connections[account].get_module('MUC').join( - room_jid, nick, password) + room_jid, nick, password, config=config) if password: app.gc_passwords[room_jid] = password View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/7ee22d832e73d71ff41d75f8a26881101b… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/7ee22d832e73d71ff41d75f8a26881101b… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: Remove usage of convert_bytes
by Philipp Hörist 01 Jul '19

01 Jul '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: 5e20799d by Daniel Brötzmann at 2019-07-01T20:42:08Z Remove usage of convert_bytes - - - - - 6f8f3e81 by Daniel Brötzmann at 2019-07-01T20:42:08Z Remove convert_bytes method - - - - - 4 changed files: - gajim/chat_control.py - gajim/common/helpers.py - gajim/gtk/filetransfer.py - gajim/gtk/tooltips.py Changes: ===================================== gajim/chat_control.py ===================================== @@ -1468,11 +1468,17 @@ class ChatControl(ChatControlBase): """ Show an InfoBar on top of control """ + if app.config.get('use_kib_mib'): + units = GLib.FormatSizeFlags.IEC_UNITS + else: + units = GLib.FormatSizeFlags.DEFAULT + markup = '<b>%s</b>\n%s' % (_('File Transfer'), file_props.name) if file_props.desc: markup += '\n(%s)' % file_props.desc - markup += '\n%s: %s' % (_('Size'), helpers.convert_bytes( - file_props.size)) + markup += '\n%s: %s' % ( + _('Size'), + GLib.format_size_full(file_props.size, units)) b1 = Gtk.Button.new_with_mnemonic(_('_Accept')) b1.connect('clicked', self._on_accept_file_request, file_props) b2 = Gtk.Button.new_with_mnemonic(_('_Decline')) ===================================== gajim/common/helpers.py ===================================== @@ -576,44 +576,6 @@ def datetime_tuple(timestamp): tim = tim.timetuple() return tim -def convert_bytes(string_): - suffix = '' - # IEC standard says KiB = 1024 bytes KB = 1000 bytes - # but do we use the standard? - use_kib_mib = app.config.get('use_kib_mib') - align = 1024. - bytes_ = float(string_) - if bytes_ >= align: - bytes_ = round(bytes_/align, 1) - if bytes_ >= align: - bytes_ = round(bytes_/align, 1) - if bytes_ >= align: - bytes_ = round(bytes_/align, 1) - if use_kib_mib: - #GiB means gibibyte - suffix = _('%s GiB') - else: - #GB means gigabyte - suffix = _('%s GB') - else: - if use_kib_mib: - #MiB means mibibyte - suffix = _('%s MiB') - else: - #MB means megabyte - suffix = _('%s MB') - else: - if use_kib_mib: - #KiB means kibibyte - suffix = _('%s KiB') - else: - #KB means kilo bytes - suffix = _('%s KB') - else: - #B means bytes - suffix = _('%s B') - return suffix % str(bytes_) - def get_contact_dict_for_account(account): """ Create a dict of jid, nick -> contact with all contacts of account. ===================================== gajim/gtk/filetransfer.py ===================================== @@ -70,8 +70,8 @@ class FileTransfersWindow: def __init__(self): self.files_props = {'r': {}, 's': {}} self.height_diff = 0 - self._ui = get_builder('filetransfers.ui') + self._ui = get_builder('filetransfers.ui') self.window = self._ui.file_transfers_window show_notification = app.config.get('notify_on_file_complete') self._ui.notify_ft_complete.set_active(show_notification) @@ -142,6 +142,11 @@ class FileTransfersWindow: 'hash_error': 'network-error-symbolic', } + if app.config.get('use_kib_mib'): + self.units = GLib.FormatSizeFlags.IEC_UNITS + else: + self.units = GLib.FormatSizeFlags.DEFAULT + self._ui.transfers_list.get_selection().set_mode( Gtk.SelectionMode.SINGLE) self._ui.transfers_list.get_selection().connect( @@ -221,8 +226,8 @@ class FileTransfersWindow: else: file_name = file_props.name sectext = _('File name: %s') % GLib.markup_escape_text(file_name) - sectext += '\n' + _('Size: %s') % helpers.convert_bytes( - file_props.size) + sectext += '\n' + _('Size: %s') % GLib.format_size_full( + file_props.size, self.units) if file_props.type_ == 'r': jid = file_props.sender.split('/')[0] sender_name = app.contacts.get_first_contact_from_jid( @@ -456,8 +461,8 @@ class FileTransfersWindow: sectext = _('File: %s') % GLib.markup_escape_text( file_props.name) if file_props.size: - sectext += '\n' + _('Size: %s') % helpers.convert_bytes( - file_props.size) + sectext += '\n' + _('Size: %s') % GLib.format_size_full( + file_props.size, self.units) if file_props.mime_type: sectext += '\n' + _('Type: %s') % file_props.mime_type if file_props.desc: @@ -493,19 +498,19 @@ class FileTransfersWindow: elif status == 'ok': file_props.completed = True text = self._format_percent(100) - received_size = int(file_props.received_len) - full_size = file_props.size - text += helpers.convert_bytes(received_size) + '/' + \ - helpers.convert_bytes(full_size) + received_size = GLib.format_size_full( + int(file_props.received_len), self.units) + full_size = GLib.format_size_full(file_props.size, self.units) + text += received_size + '/' + full_size self.model.set(iter_, Column.PROGRESS, text) self.model.set(iter_, Column.PULSE, GLib.MAXINT32) elif status == 'computing': self.model.set(iter_, Column.PULSE, 1) text = _('Checking file…') + '\n' - received_size = int(file_props.received_len) - full_size = file_props.size - text += helpers.convert_bytes(received_size) + '/' + \ - helpers.convert_bytes(full_size) + received_size = GLib.format_size_full( + int(file_props.received_len), self.units) + full_size = GLib.format_size_full(file_props.size, self.units) + text += received_size + '/' + full_size self.model.set(iter_, Column.PROGRESS, text) def pulse(): @@ -517,10 +522,10 @@ class FileTransfersWindow: GLib.timeout_add(100, pulse) elif status == 'hash_error': text = _('File error') + '\n' - received_size = int(file_props.received_len) - full_size = file_props.size - text += helpers.convert_bytes(received_size) + '/' + \ - helpers.convert_bytes(full_size) + received_size = GLib.format_size_full( + int(file_props.received_len), self.units) + full_size = GLib.format_size_full(file_props.size, self.units) + text += received_size + '/' + full_size self.model.set(iter_, Column.PROGRESS, text) self.model.set(iter_, Column.PULSE, GLib.MAXINT32) self.model.set(iter_, Column.IMAGE, self.icons[status]) @@ -626,8 +631,8 @@ class FileTransfersWindow: if transfered_size == 0: text += '0' else: - text += helpers.convert_bytes(transfered_size) - text += '/' + helpers.convert_bytes(full_size) + text += GLib.format_size_full(transfered_size, self.units) + text += '/' + GLib.format_size_full(full_size, self.units) # Kb/s # remaining time @@ -647,11 +652,11 @@ class FileTransfersWindow: self.model.set(iter_, Column.PERCENT, int(percent)) text = self._format_time(eta) text += '\n' - # This should make the string Kb/s, - # where 'Kb' part is taken from %s. + # This should make the string KB/s, + # where 'KB' part is taken from %s. # Only the 's' after / (which means second) should be translated. text += _('(%(filesize_unit)s/s)') % { - 'filesize_unit': helpers.convert_bytes(speed)} + 'filesize_unit': GLib.format_size_full(speed, self.units)} self.model.set(iter_, Column.TIME, text) # try to guess what should be the status image ===================================== gajim/gtk/tooltips.py ===================================== @@ -535,6 +535,10 @@ class FileTransfersTooltip(): def __init__(self): self.sid = None self.widget = None + if app.config.get('use_kib_mib'): + self.units = GLib.FormatSizeFlags.IEC_UNITS + else: + self.units = GLib.FormatSizeFlags.DEFAULT def clear_tooltip(self): self.sid = None @@ -583,7 +587,7 @@ class FileTransfersTooltip(): if not transfered_len: transfered_len = 0 properties.append((Q_('?transfer status:Transferred: '), - helpers.convert_bytes(transfered_len))) + GLib.format_size_full(transfered_len, self.units))) status = self._get_current_status(file_props) properties.append((Q_('?transfer status:Status: '), status)) file_desc = file_props.desc or '' View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/5ba5bc179bf9bbb25c10addedc6be12e3… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/5ba5bc179bf9bbb25c10addedc6be12e3… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Adapt to nbxmpp changes
by Philipp Hörist 30 Jun '19

30 Jun '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: 5ba5bc17 by Philipp Hörist at 2019-06-30T20:14:46Z Adapt to nbxmpp changes nbxmpp returns now in more places JID objects - - - - - 5 changed files: - gajim/common/modules/bookmarks.py - gajim/gtk/bookmarks.py - gajim/gtk/groupchat_config.py - gajim/gui_menu_builder.py - gajim/roster_window.py Changes: ===================================== gajim/common/modules/bookmarks.py ===================================== @@ -203,7 +203,7 @@ class Bookmarks(BaseModule): minimize = app.config.get_per('rooms', bookmark.jid, 'minimize_on_autojoin', True) app.interface.join_gc_room( - self._account, bookmark.jid, bookmark.nick, + self._account, str(bookmark.jid), bookmark.nick, bookmark.password, minimize=minimize) def add_bookmark(self, name, jid, autojoin, password, nick): ===================================== gajim/gtk/bookmarks.py ===================================== @@ -61,7 +61,7 @@ class ManageBookmarksWindow: for bookmark in bookmarks: self.treestore.append(iter_, [account, bookmark.name, - bookmark.jid, + str(bookmark.jid), bookmark.autojoin, bookmark.password, bookmark.nick, ===================================== gajim/gtk/groupchat_config.py ===================================== @@ -368,7 +368,7 @@ class GroupchatConfig(Gtk.ApplicationWindow): if affiliation == 'outcast': reason = attrs.get('reason') self._ui.outcast_store.append( - [jid, + [str(jid), reason, None, affiliation, @@ -381,7 +381,7 @@ class GroupchatConfig(Gtk.ApplicationWindow): nick = attrs.get('nick') role = attrs.get('role') self._ui.affiliation_store.append( - [jid, + [str(jid), nick, role, affiliation, ===================================== gajim/gui_menu_builder.py ===================================== @@ -182,10 +182,10 @@ show_bookmarked=False, force_resource=False): item = Gtk.SeparatorMenuItem.new() # separator invite_to_submenu.append(item) for (room_jid, account) in rooms2: - menuitem = Gtk.MenuItem.new_with_label(room_jid.split('@')[0]) + menuitem = Gtk.MenuItem.new_with_label(room_jid.getNode()) if len(contact_list) > 1: # several resources menuitem.set_submenu(build_resources_submenu( - contact_list, account, roster.on_invite_to_room, room_jid, + contact_list, account, roster.on_invite_to_room, str(room_jid), account)) else: # use resource if it's self contact @@ -194,7 +194,7 @@ show_bookmarked=False, force_resource=False): else: resource = None menuitem.connect('activate', roster.on_invite_to_room, list_, - room_jid, account, resource) + str(room_jid), account, resource) invite_to_submenu.append(menuitem) def get_contact_menu(contact, account, use_multiple_contacts=True, @@ -719,7 +719,7 @@ def get_bookmarks_menu(account, rebuild=False): # Create Variant Dict dict_ = {'account': GLib.Variant('s', account), - 'jid': GLib.Variant('s', bookmark.jid)} + 'jid': GLib.Variant('s', str(bookmark.jid))} if bookmark.nick: dict_['nick'] = GLib.Variant('s', bookmark.nick) if bookmark.password: ===================================== gajim/roster_window.py ===================================== @@ -2687,7 +2687,7 @@ class RosterWindow: def on_bookmark_menuitem_activate(self, widget, account, bookmark): app.interface.join_gc_room( - account, bookmark.jid, bookmark.nick, bookmark.password) + account, str(bookmark.jid), bookmark.nick, bookmark.password) def on_info(self, widget, contact, account): """ View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/5ba5bc179bf9bbb25c10addedc6be12e36… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/5ba5bc179bf9bbb25c10addedc6be12e36… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/python-nbxmpp][master] 2 commits: Refactor validating JIDs
by Philipp Hörist 30 Jun '19

30 Jun '19

Philipp Hörist pushed to branch master at gajim / python-nbxmpp Commits: c7597a9e by Philipp Hörist at 2019-06-30T19:55:09Z Refactor validating JIDs - Validate while parsing into JID - Add dedicated methods for the different JID parts - Follow RTC7622 exactly - Add unit tests - - - - - 3946f35b by Philipp Hörist at 2019-06-30T20:09:11Z Remove old JID validation code - - - - - 7 changed files: - nbxmpp/modules/annotations.py - nbxmpp/modules/bookmarks.py - nbxmpp/modules/dataforms.py - nbxmpp/modules/muc.py - nbxmpp/protocol.py - nbxmpp/util.py - + test/unit/test_jid_parsing.py Changes: ===================================== nbxmpp/modules/annotations.py ===================================== @@ -22,10 +22,10 @@ from nbxmpp.protocol import NS_ROSTERNOTES from nbxmpp.protocol import Iq from nbxmpp.protocol import Node from nbxmpp.protocol import isResultNode +from nbxmpp.protocol import JID from nbxmpp.structs import AnnotationNote from nbxmpp.structs import CommonResult from nbxmpp.modules.date_and_time import parse_datetime -from nbxmpp.util import validate_jid from nbxmpp.util import call_on_response from nbxmpp.util import callback from nbxmpp.util import raise_error @@ -66,10 +66,10 @@ class Annotations: notes = [] for note in nodes: try: - jid = validate_jid(note.getAttr('jid')) - except Exception: - log.warning('Invalid JID: %s, ignoring it', - note.getAttr('jid')) + jid = JID(note.getAttr('jid')) + except Exception as error: + log.warning('Invalid JID: %s, %s', + note.getAttr('jid'), error) continue cdate = note.getAttr('cdate') ===================================== nbxmpp/modules/bookmarks.py ===================================== @@ -23,12 +23,12 @@ from nbxmpp.protocol import NS_PRIVATE from nbxmpp.protocol import isResultNode from nbxmpp.protocol import Node from nbxmpp.protocol import Iq +from nbxmpp.protocol import JID from nbxmpp.structs import StanzaHandler from nbxmpp.structs import BookmarkData from nbxmpp.const import BookmarkStoreType from nbxmpp.util import from_xs_boolean from nbxmpp.util import to_xs_boolean -from nbxmpp.util import validate_jid from nbxmpp.util import call_on_response from nbxmpp.util import callback from nbxmpp.util import raise_error @@ -87,10 +87,10 @@ class Bookmarks: autojoin = False try: - jid = validate_jid(conf.getAttr('jid')) - except Exception: - log.warning('Invalid JID: %s, ignoring it', - conf.getAttr('jid')) + jid = JID(conf.getAttr('jid')) + except Exception as error: + log.warning('Invalid JID: %s, %s', + conf.getAttr('jid'), error) continue bookmark = BookmarkData( ===================================== nbxmpp/modules/dataforms.py ===================================== @@ -21,8 +21,8 @@ from nbxmpp.protocol import NS_DATA from nbxmpp.protocol import NS_DATA_MEDIA +from nbxmpp.protocol import JID from nbxmpp.simplexml import Node -from nbxmpp.util import validate_jid # exceptions used in this module @@ -426,7 +426,7 @@ class JidSingleField(ListSingleField): def is_valid(self): if self.value: try: - validate_jid(self.value) + JID(self.value) return True, '' except Exception as error: return False, error @@ -481,7 +481,7 @@ class JidMultiField(ListMultiField): if self.values: for value in self.values: try: - validate_jid(value) + JID(value) except Exception as error: return False, error return True, '' ===================================== nbxmpp/modules/muc.py ===================================== @@ -32,7 +32,6 @@ from nbxmpp.protocol import Message from nbxmpp.protocol import DataForm from nbxmpp.protocol import DataField from nbxmpp.protocol import isResultNode -from nbxmpp.protocol import InvalidJid from nbxmpp.simplexml import Node from nbxmpp.structs import StanzaHandler from nbxmpp.const import InviteType @@ -48,7 +47,6 @@ from nbxmpp.structs import CommonResult from nbxmpp.structs import MucConfigResult from nbxmpp.structs import MucUserData from nbxmpp.structs import MucDestroyed -from nbxmpp.util import validate_jid from nbxmpp.util import call_on_response from nbxmpp.util import callback from nbxmpp.util import raise_error @@ -112,9 +110,9 @@ class MUC: alternate = destroy.getAttr('jid') if alternate is not None: try: - alternate = JID(validate_jid(alternate)) - except InvalidJid: - log.warning('Invalid alternate JID provided') + alternate = JID(alternate) + except Exception as error: + log.warning('Invalid alternate JID provided: %s', error) log.warning(stanza) alternate = None properties.muc_destroyed = MucDestroyed( @@ -312,9 +310,10 @@ class MUC: users_dict = {} for item in items: try: - jid = validate_jid(item.getAttr('jid')) - except InvalidJid as error: - log.exception(error) + jid = JID(item.getAttr('jid')) + except Exception as error: + log.warning('Invalid JID: %s, %s', + item.getAttr('jid'), error) continue users_dict[jid] = {} ===================================== nbxmpp/protocol.py ===================================== @@ -20,9 +20,13 @@ sub- stanzas) handling routines import time import hashlib +import socket from base64 import b64encode -from .simplexml import Node, NodeBuilder +from precis_i18n import get_profile +from nbxmpp.stringprepare import nameprep +from nbxmpp.simplexml import Node +from nbxmpp.simplexml import NodeBuilder def ascii_upper(s): return s.upper() @@ -503,6 +507,8 @@ _status_conditions = { 'removed-shutdown': 332, } +_localpart_disallowed_chars = set('"&\'/:<>@') + STREAM_NOT_AUTHORIZED = 'urn:ietf:params:xml:ns:xmpp-streams not-authorized' STREAM_REMOTE_CONNECTION_FAILED = 'urn:ietf:params:xml:ns:xmpp-streams remote-connection-failed' @@ -661,6 +667,30 @@ class InvalidStanza(Exception): class InvalidJid(Exception): pass +class LocalpartByteLimit(InvalidJid): + def __init__(self): + InvalidJid.__init__(self, 'Localpart must be between 1 and 1023 bytes') + +class LocalpartNotAllowedChar(InvalidJid): + def __init__(self): + InvalidJid.__init__(self, 'Not allowed character in localpart') + +class ResourcepartByteLimit(InvalidJid): + def __init__(self): + InvalidJid.__init__(self, 'Resourcepart must be between 1 and 1023 bytes') + +class ResourcepartNotAllowedChar(InvalidJid): + def __init__(self): + InvalidJid.__init__(self, 'Not allowed character in resourcepart') + +class DomainpartByteLimit(InvalidJid): + def __init__(self): + InvalidJid.__init__(self, 'Domainpart must be between 1 and 1023 bytes') + +class DomainpartNotAllowedChar(InvalidJid): + def __init__(self): + InvalidJid.__init__(self, 'Not allowed character in domainpart') + class StanzaMalformed(Exception): pass @@ -693,6 +723,84 @@ stream_exceptions = {'bad-format': BadFormat, 'xml-not-well-formed': XMLNotWellFormed} +def parse_jid(jid): + # https://tools.ietf.org/html/rfc7622#section-3.2 + + # Remove any portion from the first '/' character to the end of the + # string (if there is a '/' character present). + + # Remove any portion from the beginning of the string to the first + # '@' character (if there is an '@' character present). + + if jid.find('/') != -1: + rest, resourcepart = jid.split('/', 1) + resourcepart = validate_resourcepart(resourcepart) + else: + rest, resourcepart = jid, '' + + if rest.find('@') != -1: + localpart, domainpart = rest.split('@', 1) + localpart = validate_localpart(localpart) + else: + localpart, domainpart = '', rest + + domainpart = validate_domainpart(domainpart) + return localpart, domainpart, resourcepart + + +def validate_localpart(localpart): + if not localpart or len(localpart.encode()) > 1023: + raise LocalpartByteLimit + + if _localpart_disallowed_chars & set(localpart): + raise LocalpartNotAllowedChar + + try: + username = get_profile('UsernameCaseMapped') + return username.enforce(localpart) + except Exception: + raise LocalpartNotAllowedChar + + +def validate_resourcepart(resourcepart): + if not resourcepart or len(resourcepart.encode()) > 1023: + raise ResourcepartByteLimit + + try: + opaque = get_profile('OpaqueString') + return opaque.enforce(resourcepart) + except Exception: + raise ResourcepartNotAllowedChar + + +def validate_domainpart(domainpart): + # Check if this is a IPV4 address + try: + socket.inet_aton(domainpart) + return domainpart + except Exception: + pass + + # Check if this is a IPV6 address + if domainpart.startswith('[') and domainpart.endswith(']'): + try: + socket.inet_pton(socket.AF_INET6, domainpart.strip('[]')) + return domainpart + except Exception: + pass + + if not domainpart or len(domainpart.encode()) > 1023: + raise DomainpartByteLimit + + if domainpart.endswith('.'): # RFC7622, 3.2 + domainpart = domainpart[:-1] + + try: + return nameprep.prepare(domainpart) + except Exception: + raise DomainpartNotAllowedChar + + class JID: """ JID can be built from string, modified, compared, serialised into string @@ -714,14 +822,7 @@ class JID: elif domain: self.node, self.domain, self.resource = node, domain, resource else: - if jid.find('@') + 1: - self.node, jid = jid.split('@', 1) - else: - self.node = '' - if jid.find('/')+1: - self.domain, self.resource = jid.split('/', 1) - else: - self.domain, self.resource = jid, '' + self.node, self.domain, self.resource = parse_jid(jid) def getNode(self): """ ===================================== nbxmpp/util.py ===================================== @@ -71,77 +71,6 @@ def get_properties_struct(name): return Properties() -def validate_jid(jid_string): - jid = JID(jid_string) - return prep(jid.getNode() or None, - jid.getDomain() or None, - jid.getResource() or None) - - -def prep(user, server, resource): - """ - Perform stringprep on all JID fragments and return the full jid - """ - - ip_address = False - - try: - socket.inet_aton(server) - ip_address = True - except socket.error: - pass - - if not ip_address and hasattr(socket, 'inet_pton'): - try: - socket.inet_pton(socket.AF_INET6, server.strip('[]')) - server = '[%s]' % server.strip('[]') - ip_address = True - except (socket.error, ValueError): - pass - - if not ip_address: - if server is not None: - if server.endswith('.'): # RFC7622, 3.2 - server = server[:-1] - if not server or len(server.encode('utf-8')) > 1023: - raise InvalidJid('Server must be between 1 and 1023 bytes') - try: - server = nameprep.prepare(server) - except UnicodeError: - raise InvalidJid('Invalid character in hostname') - else: - raise InvalidJid('Server address required') - - if user is not None: - if not user or len(user.encode('utf-8')) > 1023: - raise InvalidJid('Username must be between 1 and 1023 bytes') - try: - user = user.encode('UsernameCaseMapped').decode('utf-8') - except UnicodeError: - raise InvalidJid('Invalid character in username') - else: - user = None - - if resource is not None: - if not resource or len(resource.encode('utf-8')) > 1023: - raise InvalidJid('Resource must be between 1 and 1023 bytes') - try: - resource = resource.encode('OpaqueString').decode('utf-8') - except UnicodeError: - raise InvalidJid('Invalid character in resource') - else: - resource = None - - if user: - if resource: - return '%s@%s/%s' % (user, server, resource) - return '%s@%s' % (user, server) - - if resource: - return '%s/%s' % (server, resource) - return server - - def call_on_response(cb): def response_decorator(func): @wraps(func) ===================================== test/unit/test_jid_parsing.py ===================================== @@ -0,0 +1,60 @@ +import unittest + +from nbxmpp.protocol import LocalpartByteLimit +from nbxmpp.protocol import LocalpartNotAllowedChar +from nbxmpp.protocol import ResourcepartByteLimit +from nbxmpp.protocol import ResourcepartNotAllowedChar +from nbxmpp.protocol import DomainpartByteLimit +from nbxmpp.protocol import DomainpartNotAllowedChar +from nbxmpp.protocol import JID + +class JIDParsing(unittest.TestCase): + + def test_valid_jids(self): + tests = [ + 'juliet(a)example.com', + 'juliet(a)example.com/foo', + 'juliet(a)example.com/foo bar', + 'juliet@example.com/foo@bar', + 'foo\\20bar(a)example.com', + 'fussball(a)example.com', + 'fu\U000000DFball(a)example.com', + '\U000003C0(a)example.com', + '\U000003A3(a)example.com/foo', + '\U000003C3(a)example.com/foo', + '\U000003C2(a)example.com/foo', + 'king(a)example.com/\U0000265A', + 'example.com', + 'example.com/foobar', + 'a.example.com/b@example.net', + ] + + for jid in tests: + JID(jid) + + def test_invalid_jids(self): + tests = [ + ('"juliet"@example.com', LocalpartNotAllowedChar), + ('foo bar(a)example.com', LocalpartNotAllowedChar), + ('henry\U00002163(a)example.com', LocalpartNotAllowedChar), + ('@example.com', LocalpartByteLimit), + ('user(a)example.com/', ResourcepartByteLimit), + ('user(a)example.com/\U00000001', ResourcepartNotAllowedChar), + ('\U0000265A(a)example.com', LocalpartNotAllowedChar), + ('user@host@example.com', DomainpartNotAllowedChar), + ('juliet@', DomainpartByteLimit), + ('/foobar', DomainpartByteLimit), + ] + + for jid, exception in tests: + with self.assertRaises(exception): + JID(jid) + + def test_ip_literals(self): + tests = [ + ('juliet@[2002:4559:1FE2::4559:1FE2]/res'), + ('juliet(a)123.123.123.123/res'), + ] + + for jid in tests: + JID(jid) View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/compare/54d8fea2057e5b301ef4ed167… -- View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/compare/54d8fea2057e5b301ef4ed167… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] HTTPUpload: Use units depending on size and speed
by Philipp Hörist 30 Jun '19

30 Jun '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: 3f0ebda2 by Daniel Brötzmann at 2019-06-30T14:50:18Z HTTPUpload: Use units depending on size and speed - - - - - 2 changed files: - gajim/data/gui/httpupload_progress_dialog.ui - gajim/gtk/http_upload_progress.py Changes: ===================================== gajim/data/gui/httpupload_progress_dialog.ui ===================================== @@ -43,6 +43,8 @@ <property name="visible">True</property> <property name="can_focus">False</property> <property name="label"><file name></property> + <property name="ellipsize">end</property> + <property name="max_width_chars">40</property> </object> <packing> <property name="expand">False</property> @@ -172,7 +174,7 @@ <property name="can_focus">True</property> <property name="receives_default">True</property> <property name="halign">center</property> - <property name="margin_top">6</property> + <property name="margin_top">12</property> <property name="use_underline">True</property> <signal name="clicked" handler="_on_cancel_upload_button_clicked" swapped="no"/> <style> ===================================== gajim/gtk/http_upload_progress.py ===================================== @@ -36,11 +36,17 @@ class HTTPUploadProgressWindow(Gtk.ApplicationWindow): self.event = file.event self.file = file - self._ui = get_builder('httpupload_progress_dialog.ui') + + if app.config.get('use_kib_mib'): + self.units = GLib.FormatSizeFlags.IEC_UNITS + else: + self.units = GLib.FormatSizeFlags.DEFAULT file_name = os.path.basename(file.path) - self._ui.file_name_label.set_text(file_name) + self._start_time = time.time() + self._ui = get_builder('httpupload_progress_dialog.ui') + self._ui.file_name_label.set_text(file_name) self.add(self._ui.box) self.pulse = GLib.timeout_add(100, self._pulse_progressbar) @@ -48,6 +54,7 @@ class HTTPUploadProgressWindow(Gtk.ApplicationWindow): self.connect('destroy', self._on_destroy) self._ui.connect_signals(self) + app.ged.register_event_handler('httpupload-progress', ged.CORE, self._on_httpupload_progress) @@ -87,23 +94,27 @@ class HTTPUploadProgressWindow(Gtk.ApplicationWindow): GLib.source_remove(self.pulse) self.pulse = None - size_total = round(total / (1024 * 1024), 1) - size_progress = round(seen / (1024 * 1024), 1) - time_now = time.time() - mbytes_sec = round(size_progress / (time_now - self._start_time), 1) - eta = self._format_eta( - round((size_total - size_progress) / mbytes_sec)) + bytes_sec = round(seen / (time_now - self._start_time), 1) - self._ui.progressbar.set_fraction(float(seen) / total) + size_progress = GLib.format_size_full(seen, self.units) + size_total = GLib.format_size_full(total, self.units) + speed = '%s/s' % GLib.format_size_full(bytes_sec, self.units) + + if bytes_sec == 0: + eta = '∞' + else: + eta = self._format_eta( + round((total - seen) / bytes_sec)) self._ui.progress_label.set_text( - _('%(progress)s of %(total)s MiB') % { - 'progress': str(size_progress), - 'total': str(size_total)}) + _('%(progress)s of %(total)s') % { + 'progress': size_progress, + 'total': size_total}) - self._ui.speed_label.set_text(_('%s MiB/s') % str(mbytes_sec)) - self._ui.eta_label.set_text(str(eta)) + self._ui.speed_label.set_text(speed) + self._ui.eta_label.set_text(eta) + self._ui.progressbar.set_fraction(float(seen) / total) def _format_eta(self, time_): times = {'minutes': 0, 'seconds': 0} @@ -111,6 +122,6 @@ class HTTPUploadProgressWindow(Gtk.ApplicationWindow): times['seconds'] = time_ % 60 if time_ >= 60: time_ /= 60 - times['minutes'] = time_ % 60 + times['minutes'] = round(time_ % 60) return _('%(minutes)s min %(seconds)s sec') % times View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/3f0ebda2237e59e8bf32713e739105a641… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/3f0ebda2237e59e8bf32713e739105a641… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Fix caps cache tests
by Philipp Hörist 29 Jun '19

29 Jun '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: d57b4b26 by Philipp Hörist at 2019-06-29T21:22:36Z Fix caps cache tests - - - - - 1 changed file: - test/no_gui/unit/test_caps_cache.py Changes: ===================================== test/no_gui/unit/test_caps_cache.py ===================================== @@ -6,7 +6,9 @@ from unittest.mock import MagicMock, Mock from nbxmpp import NS_MUC, NS_PING, NS_XHTML_IM from nbxmpp.structs import DiscoIdentity +from nbxmpp.structs import DiscoInfo from gajim.common import caps_cache as caps +from gajim.common.structs import CapsData class CommonCapsTest(unittest.TestCase): @@ -25,11 +27,13 @@ class CommonCapsTest(unittest.TestCase): self.features = [NS_MUC, NS_XHTML_IM] # Simulate a filled db - db_caps_cache = [ - (self.caps_method, self.caps_hash, self.identities, self.features), - ('old', self.node + '#' + self.caps_hash, self.identities, self.features)] + db_caps_cache = { + (self.caps_method, self.caps_hash): CapsData(self.identities, self.features, []), + ('old', self.node + '#' + self.caps_hash): CapsData(self.identities, self.features, []) + } + self.logger = Mock() - self.logger.iter_caps_data = Mock(return_value=db_caps_cache) + self.logger.load_caps_data = Mock(return_value=db_caps_cache) self.cc = caps.CapsCache(self.logger) caps.capscache = self.cc @@ -57,13 +61,14 @@ class TestCapsCache(CommonCapsTest): def test_set_and_store(self): ''' Test client_caps update gets logged into db ''' + disco_info = DiscoInfo(None, None, self.identities, self.features, []) + item = self.cc[self.client_caps] - item.set_and_store(self.identities, self.features) + item.set_and_store(disco_info) self.logger.add_caps_entry.assert_called_once_with(self.caps_method, self.caps_hash, - self.identities, - self.features) + disco_info) def test_initialize_from_db(self): ''' Read cashed dummy data from db ''' View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/d57b4b260cfb65cef5a3b9f3c084f5586f… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/d57b4b260cfb65cef5a3b9f3c084f5586f… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Refactor entity caps storage
by Philipp Hörist 29 Jun '19

29 Jun '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: 0c7f6072 by Philipp Hörist at 2019-06-29T21:14:20Z Refactor entity caps storage - Use json as storage format - Add JsonEncoder and Decoder for DiscoInfo objects - Add support for storing dataforms - - - - - 4 changed files: - gajim/common/caps_cache.py - gajim/common/logger.py - gajim/common/modules/caps.py - gajim/common/structs.py Changes: ===================================== gajim/common/caps_cache.py ===================================== @@ -261,12 +261,11 @@ class CapsCache: identities = property(_get_identities, _set_identities) - def set_and_store(self, identities, features): - self.identities = identities - self.features = features + def set_and_store(self, info): + self.identities = info.identities + self.features = info.features if self.hash_method != 'no': - self._logger.add_caps_entry(self.hash_method, self.hash, - identities, features) + self._logger.add_caps_entry(self.hash_method, self.hash, info) self.status = CACHED def update_last_seen(self): @@ -288,11 +287,11 @@ class CapsCache: def initialize_from_db(self): self._remove_outdated_caps() - for hash_method, hash_, identities, features in \ - self.logger.iter_caps_data(): - x = self[(hash_method, hash_)] - x.identities = identities - x.features = features + data = self.logger.load_caps_data() + for key, item in data.items(): + x = self[key] + x.identities = item.identities + x.features = item.features x.status = CACHED def _remove_outdated_caps(self): ===================================== gajim/common/logger.py ===================================== @@ -34,11 +34,12 @@ import json import logging import sqlite3 as sqlite from collections import namedtuple -from gzip import GzipFile -from io import BytesIO + from gi.repository import GLib -from nbxmpp.structs import DiscoIdentity +from nbxmpp.protocol import Node +from nbxmpp.structs import DiscoInfo +from nbxmpp.modules.dataforms import extend_form from gajim.common import exceptions from gajim.common import app @@ -48,6 +49,8 @@ from gajim.common.i18n import _ from gajim.common.const import ( JIDConstant, KindConstant, ShowConstant, TypeConstant, SubscriptionConstant) +from gajim.common.structs import CapsData +from gajim.common.structs import CapsIdentity LOGS_SQL_STATEMENT = ''' @@ -99,7 +102,7 @@ CACHE_SQL_STATEMENT = ''' CREATE TABLE caps_cache ( hash_method TEXT, hash TEXT, - data BLOB, + data TEXT, last_seen INTEGER); CREATE TABLE rooms_last_message_time( jid_id INTEGER PRIMARY KEY UNIQUE, @@ -120,12 +123,56 @@ CACHE_SQL_STATEMENT = ''' group_name TEXT, PRIMARY KEY (account_jid_id, jid_id, group_name) ); - PRAGMA user_version=1; + PRAGMA user_version=2; ''' log = logging.getLogger('gajim.c.logger') + +class CapsEncoder(json.JSONEncoder): + def encode(self, obj): + if isinstance(obj, DiscoInfo): + identities = [] + for identity in obj.identities: + identities.append( + {'category': identity.category, + 'type': identity.type, + 'name': identity.name, + 'lang': identity.lang}) + + dataforms = [] + for dataform in obj.dataforms: + # Filter out invalid forms according to XEP-0115 + form_type = dataform.vars.get('FORM_TYPE') + if form_type is None or form_type.type_ != 'hidden': + continue + dataforms.append(str(dataform)) + + obj = {'identities': identities, + 'features': obj.features, + 'dataforms': dataforms} + return json.JSONEncoder.encode(self, obj) + + +def caps_decoder(dict_): + if 'identities' not in dict_: + return dict_ + + identities = [] + for identity in dict_['identities']: + identities.append(CapsIdentity(**identity)) + + features = dict_['features'] + + dataforms = [] + for dataform in dict_['dataforms']: + dataforms.append(extend_form(node=Node(node=dataform))) + return CapsData(identities=identities, + features=features, + dataforms=dataforms) + + class Logger: def __init__(self): self._jid_ids = {} @@ -248,7 +295,12 @@ class Logger: self._execute_multiple(con, statements) if self._get_user_version(con) < 2: - pass + statements = [ + 'DROP TABLE IF EXISTS caps_cache', + 'CREATE TABLE caps_cache (hash_method TEXT, hash TEXT, data TEXT, last_seen INTEGER)', + 'PRAGMA user_version=2' + ] + self._execute_multiple(con, statements) @staticmethod def _execute_multiple(con, statements): @@ -983,108 +1035,45 @@ class Logger: result.type) return answer - # A longer note here: - # The database contains a blob field. Pysqlite seems to need special care for - # such fields. - # When storing, we need to convert string into buffer object (1). - # When retrieving, we need to convert it back to a string to decompress it. - # (2) - # GzipFile needs a file-like object, StringIO emulates file for plain strings - def iter_caps_data(self): - """ - Iterate over caps cache data stored in the database - - The iterator values are pairs of (node, ver, ext, identities, features): - identities == {'category':'foo', 'type':'bar', 'name':'boo'}, - features being a list of feature namespaces. - """ - # get data from table - # the data field contains binary object (gzipped data), this is a hack - # to get that data without trying to convert it to unicode - try: - rows = self._con.execute('SELECT hash_method, hash, data FROM caps_cache;') - except sqlite.OperationalError: - # might happen when there's no caps_cache table yet - # -- there's no data to read anyway then - return + def load_caps_data(self): + ''' + Load caps cache data + ''' + rows = self._con.execute( + 'SELECT hash_method, hash, data FROM caps_cache') - # list of corrupted entries that will be removed - to_be_removed = [] + cache = {} for row in rows: - # for each row: unpack the data field - # (format: (category, type, name, category, type, name, ... - # ..., 'FEAT', feature1, feature2, ...).join(' ')) - # NOTE: if there's a need to do more gzip, put that to a function try: - data = GzipFile(fileobj=BytesIO(row.data)).read().decode('utf-8').split('\0') - except IOError: - # This data is corrupted. It probably contains non-ascii chars - to_be_removed.append((row.hash_method, row.hash)) + data = json.loads(row.data, object_hook=caps_decoder) + except Exception: + log.exception('') continue - i = 0 - identities = list() - features = list() - while i < (len(data) - 3) and data[i] != 'FEAT': - category = data[i] - type_ = data[i + 1] - lang = data[i + 2] - name = data[i + 3] - identities.append(DiscoIdentity(category=category, - type=type_, - lang=lang, - name=name)) - i += 4 - i += 1 - while i < len(data): - features.append(data[i]) - i += 1 - - # yield the row - yield row.hash_method, row.hash, identities, features - for hash_method, hash_ in to_be_removed: - sql = '''DELETE FROM caps_cache WHERE hash_method = "%s" AND - hash = "%s"''' % (hash_method, hash_) - self.simple_commit(sql) + cache[(row.hash_method, row.hash)] = data + return cache - def add_caps_entry(self, hash_method, hash_, identities, features): - data = [] - for identity in identities: - # there is no FEAT category - if identity.category == 'FEAT': - return - data.extend((identity.category, - identity.type, - identity.lang or '', - identity.name or '')) - data.append('FEAT') - data.extend(features) - data = '\0'.join(data) - # if there's a need to do more gzip, put that to a function - string = BytesIO() - gzip = GzipFile(fileobj=string, mode='w') - gzip.write(data.encode('utf-8')) - gzip.close() - data = string.getvalue() + def add_caps_entry(self, hash_method, hash_, caps_data): + serialized = json.dumps(caps_data, cls=CapsEncoder) self._con.execute(''' - INSERT INTO caps_cache ( hash_method, hash, data, last_seen ) - VALUES (?, ?, ?, ?); - ''', (hash_method, hash_, memoryview(data), int(time.time()))) - # (1) -- note above + INSERT INTO caps_cache (hash_method, hash, data, last_seen) + VALUES (?, ?, ?, ?) + ''', (hash_method, hash_, serialized, int(time.time()))) self._timeout_commit() def update_caps_time(self, method, hash_): - sql = '''UPDATE caps_cache SET last_seen = %d - WHERE hash_method = "%s" and hash = "%s"''' % \ - (int(time.time()), method, hash_) - self.simple_commit(sql) + sql = '''UPDATE caps_cache SET last_seen = ? + WHERE hash_method = ? and hash = ?''' + self._con.execute(sql, (int(time.time()), method, hash_)) + self._timeout_commit() def clean_caps_table(self): """ Remove caps which was not seen for 3 months """ - sql = '''DELETE FROM caps_cache WHERE last_seen < %d''' % \ - int(time.time() - 3*30*24*3600) - self.simple_commit(sql) + timestamp = int(time.time()) - 3 * 30 * 24 * 3600 + self._con.execute('DELETE FROM caps_cache WHERE last_seen < ?', + (timestamp,)) + self._timeout_commit() def replace_roster(self, account_name, roster_version, roster): """ ===================================== gajim/common/modules/caps.py ===================================== @@ -126,12 +126,11 @@ class Caps(BaseModule): except Exception as error: self._log.warning('Disco info malformed: %s %s', contact.get_full_jid(), error) - self._log.warning(info) node = caps_hash = hash_method = None contact.client_caps = self._create_suitable_client_caps( node, caps_hash, hash_method) else: - cache_item.set_and_store(info.identities, info.features) + cache_item.set_and_store(info) app.nec.push_incoming_event( NetworkEvent('caps-update', ===================================== gajim/common/structs.py ===================================== @@ -19,6 +19,9 @@ from gajim.common.const import MUCJoinedState URI = namedtuple('URI', 'type action data') URI.__new__.__defaults__ = (None, None) # type: ignore +CapsData = namedtuple('CapsData', 'identities features dataforms') +CapsIdentity = namedtuple('CapsIdentity', 'category type name lang') + class MUCData: def __init__(self, room_jid, nick, password, rejoin): View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/0c7f607223c5acb13474b990945026b72c… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/0c7f607223c5acb13474b990945026b72c… You're receiving this email because of your account on dev.gajim.org.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits