Commits

commits@gajim.org

17632 discussions

[Git][gajim/gajim][master] Screensaver: Switch to property signal for portal support
by Philipp Hörist 12 Nov '19

12 Nov '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: b6fa2f6c by André at 2019-11-12T05:00:06Z Screensaver: Switch to property signal for portal support - Move functionality to application.py - - - - - 4 changed files: - flatpak/org.gajim.Gajim.yaml - gajim/application.py - − gajim/common/dbus/screensaver.py - gajim/gui_interface.py Changes: ===================================== flatpak/org.gajim.Gajim.yaml ===================================== @@ -14,7 +14,6 @@ finish-args: - --socket=pulseaudio - --system-talk-name=org.freedesktop.GeoClue2 - --system-talk-name=org.freedesktop.login1 - - --talk-name=org.gnome.ScreenSaver - --talk-name=org.mpris.MediaPlayer2.* - --talk-name=org.freedesktop.portal.Fcitx # Automatic status ===================================== gajim/application.py ===================================== @@ -67,6 +67,9 @@ class GajimApplication(Gtk.Application): application_id='org.gajim.Gajim', flags=flags) + # required to track screensaver state + self.props.register_session = True + self.add_main_option( 'version', ord('V'), @@ -168,6 +171,8 @@ class GajimApplication(Gtk.Application): self.connect('command-line', self._handle_remote_options) self.connect('startup', self._startup) self.connect('activate', self._activate) + if sys.platform not in ('win32', 'darwin'): + self.connect("notify::screensaver-active", self._screensaver_active) self.interface = None @@ -566,3 +571,46 @@ class GajimApplication(Gtk.Application): elif event.feature == nbxmpp.NS_BLOCKING: action = '%s-blocking' % event.account self.lookup_action(action).set_enabled(True) + + def _screensaver_active(self, application, param): + '''Signal handler for screensaver active change''' + + active = self.get_property('screensaver-active') + + roster = app.interface.roster + + if not active: + for account in app.connections: + if app.account_is_connected(account) and \ + app.sleeper_state[account] == 'autoaway-forced': + # We came back online after screensaver autoaway + roster.send_status(account, 'online', + app.status_before_autoaway[account]) + app.status_before_autoaway[account] = '' + app.sleeper_state[account] = 'online' + return + if not app.config.get('autoaway'): + # Don't go auto away if user disabled the option + return + for account in app.connections: + if (account not in app.sleeper_state or + not app.sleeper_state[account]): + continue + if app.sleeper_state[account] == 'online': + if not app.account_is_connected(account): + continue + # we save our online status + app.status_before_autoaway[account] = \ + app.connections[account].status + # we go away (no auto status) [we pass True to auto param] + auto_message = app.config.get('autoaway_message') + if not auto_message: + auto_message = app.connections[account].status + else: + auto_message = auto_message.replace('$S', '%(status)s') + auto_message = auto_message.replace('$T', '%(time)s') + auto_message = auto_message % { + 'status': app.status_before_autoaway[account], + 'time': app.config.get('autoxatime')} + roster.send_status(account, 'away', auto_message, auto=True) + app.sleeper_state[account] = 'autoaway-forced' ===================================== gajim/common/dbus/screensaver.py deleted ===================================== @@ -1,104 +0,0 @@ -# Copyright (C) 2018 André Apitzsch <git AT apitzsch.eu> -# -# This file is part of Gajim. -# -# Gajim is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published -# by the Free Software Foundation; version 3 only. -# -# Gajim is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with Gajim. If not, see <http://www.gnu.org/licenses/>. - -import logging - -from gi.repository import Gio - -from gajim.common import app - -log = logging.getLogger('gajim.c.dbus.screensaver') - - -class ScreensaverListener: - _instance = None - - @classmethod - def get(cls): - if cls._instance is None: - cls._instance = cls() - return cls._instance - - def __init__(self): - Gio.bus_watch_name( - Gio.BusType.SESSION, - 'org.gnome.ScreenSaver', - Gio.BusNameWatcherFlags.NONE, - self._appeared, - None) - - @staticmethod - def _signal_received(_connection, _sender_name, _object_path, - interface_name, _signal_name, parameters, *_user_data): - '''Signal handler for screensaver active change''' - - log.info('Signal received: %s - %s', interface_name, parameters) - - roster = app.interface.roster - - if not parameters[0]: - for account in app.connections: - if app.account_is_connected(account) and \ - app.sleeper_state[account] == 'autoaway-forced': - # We came back online after screensaver - # autoaway - roster.send_status(account, 'online', - app.status_before_autoaway[account]) - app.status_before_autoaway[account] = '' - app.sleeper_state[account] = 'online' - return - if not app.config.get('autoaway'): - # Don't go auto away if user disabled the option - return - for account in app.connections: - if (account not in app.sleeper_state or - not app.sleeper_state[account]): - continue - if app.sleeper_state[account] == 'online': - if not app.account_is_connected(account): - continue - # we save our online status - app.status_before_autoaway[account] = \ - app.connections[account].status - # we go away (no auto status) [we pass True to auto param] - auto_message = app.config.get('autoaway_message') - if not auto_message: - auto_message = app.connections[account].status - else: - auto_message = auto_message.replace('$S', '%(status)s') - auto_message = auto_message.replace('$T', '%(time)s') - auto_message = auto_message % { - 'status': app.status_before_autoaway[account], - 'time': app.config.get('autoxatime')} - roster.send_status(account, 'away', auto_message, auto=True) - app.sleeper_state[account] = 'autoaway-forced' - - def _appeared(self, connection, name, _name_owner, *_user_data): - '''Set up a listener for screensaver signals''' - log.info('%s appeared', name) - connection.signal_subscribe( - 'org.gnome.ScreenSaver', - 'org.gnome.ScreenSaver', - 'ActiveChanged', - '/org/gnome/ScreenSaver', - None, - Gio.DBusSignalFlags.NONE, - self._signal_received, - None) - - -def enable(): - ScreensaverListener.get() ===================================== gajim/gui_interface.py ===================================== @@ -49,7 +49,6 @@ from nbxmpp.structs import TuneData from gajim.common import app from gajim.common import events -from gajim.common.dbus import screensaver from gajim.common.dbus import location from gajim.common.dbus import music_track from gajim.common.dbus import logind @@ -2158,10 +2157,8 @@ class Interface: app.gajim_optional_features[a] = [] app.caps_hash[a] = '' - # Handle screensaver if sys.platform not in ('win32', 'darwin'): logind.enable() - screensaver.enable() self.show_vcard_when_connect = [] View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/b6fa2f6cda1a9b4c72523adc90762526b2… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/b6fa2f6cda1a9b4c72523adc90762526b2… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 4 commits: MessageTextView: Fix pylint errors
by Philipp Hörist 11 Nov '19

11 Nov '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: 610218ec by Philipp Hörist at 2019-11-11T21:51:16Z MessageTextView: Fix pylint errors - - - - - 19e5a686 by Philipp Hörist at 2019-11-11T21:51:16Z MessageTextView: Remove unused method - - - - - 84aa231e by Philipp Hörist at 2019-11-11T21:51:16Z Rename MessageTextView to MessageInputTextView To make it more obvious what this class is for - - - - - 628e675b by Philipp Hörist at 2019-11-11T21:51:16Z Move message_input module to gtk folder - - - - - 2 changed files: - gajim/chat_control_base.py - gajim/message_textview.py → gajim/gtk/message_input.py Changes: ===================================== gajim/chat_control_base.py ===================================== @@ -49,11 +49,12 @@ from gajim import message_control from gajim.message_control import MessageControl from gajim.conversation_textview import ConversationTextview -from gajim.message_textview import MessageTextView + from gajim.gtk.dialogs import DialogButton from gajim.gtk.dialogs import NewConfirmationDialog from gajim.gtk.dialogs import NewConfirmationCheckDialog +from gajim.gtk.message_input import MessageInputTextView from gajim.gtk import util from gajim.gtk.util import at_the_end from gajim.gtk.util import get_show_in_roster @@ -80,7 +81,7 @@ if app.is_installed('GSPELL'): ################################################################################ class ChatControlBase(MessageControl, ChatCommandProcessor, CommandTools): """ - A base class containing a banner, ConversationTextview, MessageTextView + A base class containing a banner, ConversationTextview, MessageInputTextView """ # This is needed so copying text from the conversation textview @@ -289,8 +290,8 @@ class ChatControlBase(MessageControl, ChatCommandProcessor, CommandTools): self.correcting = False self.last_sent_msg = None - # add MessageTextView to UI and connect signals - self.msg_textview = MessageTextView() + # add MessageInputTextView to UI and connect signals + self.msg_textview = MessageInputTextView() self.msg_scrolledwindow = ScrolledWindow() self.msg_scrolledwindow.add(self.msg_textview) @@ -547,7 +548,7 @@ class ChatControlBase(MessageControl, ChatCommandProcessor, CommandTools): def _on_html_textview_grab_focus(self, textview): # Abort signal so the textview does not get focused - # Focus the MessageTextView instead + # Focus the MessageInputTextView instead GObject.signal_stop_emission_by_name(textview, 'grab-focus') self.msg_textview.grab_focus() return Gdk.EVENT_STOP ===================================== gajim/message_textview.py → gajim/gtk/message_input.py ===================================== @@ -34,7 +34,7 @@ if app.is_installed('GSPELL'): from gi.repository import Gspell # pylint: disable=ungrouped-imports -class MessageTextView(Gtk.TextView): +class MessageInputTextView(Gtk.TextView): """ Class for the message textview (where user writes new messages) for chat/groupchat windows @@ -90,12 +90,15 @@ class MessageTextView(Gtk.TextView): self.begin_tags['italic'] = '' self.end_tags['italic'] = '' self.other_tags['underline'] = buffer_.create_tag('underline') - self.other_tags['underline'].set_property('underline', Pango.Underline.SINGLE) - self.begin_tags['underline'] = '' + self.other_tags['underline'].set_property('underline', + Pango.Underline.SINGLE) + underline = '' + self.begin_tags['underline'] = underline self.end_tags['underline'] = '' self.other_tags['strike'] = buffer_.create_tag('strike') self.other_tags['strike'].set_property('strikethrough', True) - self.begin_tags['strike'] = '' + strike = '' + self.begin_tags['strike'] = strike self.end_tags['strike'] = '' self.connect('paste-clipboard', self._paste_clipboard) @@ -240,13 +243,15 @@ class MessageTextView(Gtk.TextView): _buffer = self.get_buffer() # Create #aabbcc color string from rgba color color_string = '#%02X%02X%02X' % (round(color.red*255), - round(color.green*255), round(color.blue*255)) + round(color.green*255), + round(color.blue*255)) tag_name = 'color' + color_string if not tag_name in self.color_tags: - tagColor = _buffer.create_tag(tag_name) - tagColor.set_property('foreground', color_string) - self.begin_tags[tag_name] = '' % color_string + tag_color = _buffer.create_tag(tag_name) + tag_color.set_property('foreground', color_string) + begin = '' % color_string + self.begin_tags[tag_name] = begin self.end_tags[tag_name] = '' self.color_tags.append(tag_name) @@ -276,8 +281,8 @@ class MessageTextView(Gtk.TextView): tag_name = 'font' + font if not tag_name in self.fonts_tags: - tagFont = _buffer.create_tag(tag_name) - tagFont.set_property('font', family + ' ' + str(size)) + tag_font = _buffer.create_tag(tag_name) + tag_font.set_property('font', family + ' ' + str(size)) self.begin_tags[tag_name] = \ '' @@ -335,7 +340,8 @@ class MessageTextView(Gtk.TextView): for tag in iter_.get_tags(): tag_name = tag.get_property('name') - if tag_name not in self.begin_tags or tag_name not in self.end_tags: + if (tag_name not in self.begin_tags or + tag_name not in self.end_tags): continue if tag_name not in new_tags: old_tags.append(tag_name) @@ -355,7 +361,8 @@ class MessageTextView(Gtk.TextView): for tag in old_tags: text += self.begin_tags[tag] - text += xhtml_special(_buffer.get_text(old, _buffer.get_end_iter(), True)) + buffer_text = _buffer.get_text(old, _buffer.get_end_iter(), True) + text += xhtml_special(buffer_text) for tag in iter_.get_toggled_tags(False): tag_name = tag.get_property('name') if tag_name not in self.end_tags: @@ -363,7 +370,8 @@ class MessageTextView(Gtk.TextView): text += self.end_tags[tag_name] if modified: - return build_xhtml_body('%s' % self.make_clickable_urls(text)) + wrapped_text = '%s' % self.make_clickable_urls(text) + return build_xhtml_body(wrapped_text) return None def replace_emojis(self): @@ -413,7 +421,7 @@ class MessageTextView(Gtk.TextView): self.add_child_at_anchor(image, anchor) buffer_.insert_at_cursor(' ') - def clear(self, widget=None): + def clear(self, _widget=None): """ Clear text in the textview """ @@ -427,7 +435,7 @@ class MessageTextView(Gtk.TextView): del self.undo_list[0] self.undo_pressed = False - def undo(self, widget=None): + def undo(self, _widget=None): """ Undo text in the textview """ @@ -435,10 +443,3 @@ class MessageTextView(Gtk.TextView): if self.undo_list: _buffer.set_text(self.undo_list.pop()) self.undo_pressed = True - - def get_sensitive(self): - # get sensitive is not in GTK < 2.18 - try: - return super(MessageTextView, self).get_sensitive() - except AttributeError: - return self.get_property('sensitive') View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/f95c1f0240325c503d63b1c482f252dfe… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/f95c1f0240325c503d63b1c482f252dfe… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Fix PyGI import warning
by Philipp Hörist 11 Nov '19

11 Nov '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: f95c1f02 by André Apitzsch at 2019-11-11T19:35:39Z Fix PyGI import warning Fixes #9874 - - - - - 1 changed file: - gajim/common/multimedia_helpers.py Changes: ===================================== gajim/common/multimedia_helpers.py ===================================== @@ -16,9 +16,11 @@ import logging -from gi.repository import Gst +import gi +gi.require_version('Gst', '1.0') +from gi.repository import Gst # pylint: disable=wrong-import-position -from gajim.common.i18n import _ +from gajim.common.i18n import _ # pylint: disable=wrong-import-position log = logging.getLogger('gajim.c.multimedia_helpers') View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/f95c1f0240325c503d63b1c482f252dfed… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/f95c1f0240325c503d63b1c482f252dfed… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 5 commits: MAM: Remove some attributes of mam-decrypted-message-received event
by Philipp Hörist 10 Nov '19

10 Nov '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: fe8eba08 by Philipp Hörist at 2019-11-10T21:10:43Z MAM: Remove some attributes of mam-decrypted-message-received event - Remove the with_ attribute - Remove the groupchat attribute Both are available via properties attribute - - - - - 83af0aa2 by Philipp Hörist at 2019-11-10T21:15:52Z MAM: Remove unused namespace attribute from mam-decrypted-message-received event - - - - - 2ea0125a by Philipp Hörist at 2019-11-10T21:27:36Z MAM: Pass attributes to event directly - - - - - f8d76392 by Philipp Hörist at 2019-11-10T21:46:28Z MAM: Remove conn attribute from mam-decrypted-message-received event - - - - - 2698e995 by Philipp Hörist at 2019-11-10T21:54:34Z MAM: Remove unused attributes from mam-decrypted-message-received event - - - - - 3 changed files: - gajim/chat_control.py - gajim/common/modules/mam.py - gajim/groupchat_control.py Changes: ===================================== gajim/chat_control.py ===================================== @@ -786,18 +786,16 @@ class ChatControl(ChatControlBase): fixed.set_no_show_all(True) self.close_jingle_content(jingle_type) + @event_filter(['account']) def _nec_mam_decrypted_message_received(self, obj): - if obj.conn.name != self.account: - return - if obj.properties.type.is_groupchat: return if obj.properties.is_muc_pm: - if not obj.with_ == self.contact.get_full_jid(): + if not obj.properties.jid == self.contact.get_full_jid(): return else: - if not obj.with_.bareMatch(self.contact.jid): + if not obj.properties.jid.bareMatch(self.contact.jid): return kind = '' # incoming ===================================== gajim/common/modules/mam.py ===================================== @@ -167,14 +167,14 @@ class MAM(BaseModule): self._log.debug(stanza) raise nbxmpp.NodeProcessed - event_attrs = {} - - groupchat = properties.type.is_groupchat - - if groupchat: - event_attrs.update(self._parse_gc_attrs(properties)) + is_groupchat = properties.type.is_groupchat + if is_groupchat: + kind = KindConstant.GC_MSG else: - event_attrs.update(self._parse_chat_attrs(properties)) + if properties.from_.bareMatch(self._con.get_own_jid()): + kind = KindConstant.CHAT_MSG_SENT + else: + kind = KindConstant.CHAT_MSG_RECV stanza_id, message_id = self._get_unique_id(properties) @@ -184,7 +184,7 @@ class MAM(BaseModule): str(properties.mam.archive), stanza_id, message_id, - groupchat=groupchat): + groupchat=is_groupchat): self._log.info('Found duplicate with stanza-id: %s, ' 'message-id: %s', stanza_id, message_id) raise nbxmpp.NodeProcessed @@ -228,26 +228,10 @@ class MAM(BaseModule): self._log.info('Found duplicate with fallback for mam:1') return - event_attrs.update( - {'conn': self._con, - 'account': self._account, - 'additional_data': additional_data, - 'groupchat': groupchat, - 'stanza_id': stanza_id, - 'origin_id': message_id, - 'correct_id': parse_correction(properties), - 'archive_jid': properties.mam.archive, - 'msgtxt': properties.body, - 'message': stanza, - 'stanza': stanza, - 'namespace': properties.mam.namespace, - 'properties': properties, - }) - app.logger.insert_into_logs(self._account, with_, properties.mam.timestamp, - event_attrs['kind'], + kind, unread=False, message=msgtxt, contact_name=properties.muc_nickname, @@ -256,21 +240,16 @@ class MAM(BaseModule): message_id=properties.id) app.nec.push_incoming_event( - NetworkEvent('mam-decrypted-message-received', **event_attrs)) - - @staticmethod - def _parse_gc_attrs(properties): - return {'with_': properties.jid, - 'kind': KindConstant.GC_MSG} - - def _parse_chat_attrs(self, properties): - if properties.from_.bareMatch(self._con.get_own_jid()): - kind = KindConstant.CHAT_MSG_SENT - else: - kind = KindConstant.CHAT_MSG_RECV - - return {'with_': properties.jid, - 'kind': kind} + NetworkEvent('mam-decrypted-message-received', + account=self._account, + additional_data=additional_data, + correct_id=parse_correction(properties), + archive_jid=properties.mam.archive, + msgtxt=properties.body, + properties=properties, + kind=kind, + ) + ) def _is_valid_request(self, properties): valid_id = self._mam_query_ids.get(str(properties.mam.archive), None) ===================================== gajim/groupchat_control.py ===================================== @@ -815,7 +815,7 @@ class GroupchatControl(ChatControlBase): @event_filter(['account']) def _nec_mam_decrypted_message_received(self, obj): - if not obj.groupchat: + if not obj.properties.type.is_groupchat: return if obj.archive_jid != self.room_jid: return View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/85a59711fd1feac1fde1aeb55d25315ef… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/85a59711fd1feac1fde1aeb55d25315ef… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: Fix open-link action
by Philipp Hörist 10 Nov '19

10 Nov '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: dfa65e9e by Philipp Hörist at 2019-11-10T19:36:26Z Fix open-link action param is a string array - - - - - 85a59711 by Philipp Hörist at 2019-11-10T19:38:20Z Presence: Correctly detect presences from contacts not in the roster - - - - - 2 changed files: - gajim/app_actions.py - gajim/common/modules/presence.py Changes: ===================================== gajim/app_actions.py ===================================== @@ -356,7 +356,7 @@ def open_mail(_action, param): def open_link(_action, param): - account, uri = param.get_string() + account, uri = param.get_strv() helpers.open_uri(uri, account=account) ===================================== gajim/common/modules/presence.py ===================================== @@ -63,7 +63,13 @@ class Presence(BaseModule): def _presence_received(self, _con, stanza, properties): if properties.from_muc: - # Already handled in MUC module + # MUC occupant presences are already handled in MUC module + return + + muc = self._con.get_module('MUC').get_manager().get(properties.jid) + if muc is not None: + # Presence from the MUC itself, used for MUC avatar + # handled in VCardAvatars module return self._log.info('Received from %s', properties.jid) @@ -86,9 +92,9 @@ class Presence(BaseModule): show=properties.show.value)) return - contacts = app.contacts.get_jid_list(self._account) - if (properties.jid.getBare() not in contacts and - not properties.is_self_bare): + jid = properties.jid.getBare() + roster_item = self._con.get_module('Roster').get_item(jid) + if not properties.is_self_bare and roster_item is None: # Handle only presence from roster contacts self._log.warning('Unknown presence received') self._log.warning(stanza) View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/8f299caa387aa6d6420e7b75cd99cccaf… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/8f299caa387aa6d6420e7b75cd99cccaf… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][chat_markers] 96 commits: HistoryWindow: Remove not used string
by Philipp Hörist 10 Nov '19

10 Nov '19

Philipp Hörist pushed to branch chat_markers at gajim / gajim Commits: b60b725a by Philipp Hörist at 2019-10-06T14:03:29Z HistoryWindow: Remove not used string - - - - - 22cb839e by Philipp Hörist at 2019-10-09T20:50:44Z Autoscroll correctly to the end after sending a message On some systems when an encrypted message was written and the lock icon was displayed, the textview did not scroll to the end. Fixes #9443 - - - - - c703dcf3 by Philipp Hörist at 2019-10-10T18:17:59Z Windows: Disable CSD by default - - - - - 3de7d8f6 by Philipp Hörist at 2019-10-10T19:11:03Z Groupchat: Show subject timestamp in preferred format %c uses the preferred format on the current system - - - - - bafd729c by Philipp Hörist at 2019-10-12T13:50:00Z Receipts: Always request receipt - - - - - d62d5ba6 by Philipp Hörist at 2019-10-12T13:52:23Z Receipts: Always announce support for receipts - - - - - 54d02088 by Philipp Hörist at 2019-10-12T21:17:03Z Receipts: Refactor module Adapt to nbxmpp changes - - - - - bcb3f8ac by Philipp Hörist at 2019-10-13T09:17:05Z XMLConsole: Move UI code into glade file - - - - - 03ea193e by Philipp Hörist at 2019-10-13T09:18:19Z XMLConsole: Fix pylint errors - - - - - 5b220281 by Philipp Hörist at 2019-10-13T09:21:33Z Settings: Don't act on ComboSetting row click - - - - - cdf111c5 by Philipp Hörist at 2019-10-13T09:49:07Z XMLConsole: Add account selector for sending xml - - - - - 1ec850cd by Philipp Hörist at 2019-10-13T16:46:21Z Refactor parsing oob data Adapt to nbxmpp changes - - - - - b443a39f by Philipp Hörist at 2019-10-13T18:02:18Z Refactor parsing correction data Adapt to nbxmpp changes - - - - - 5ea40d75 by Philipp Hörist at 2019-10-13T18:22:48Z Refactor parsing attention Adapt to nbxmpp changes - - - - - 9225b79d by Philipp Hörist at 2019-10-13T20:10:52Z SingleMessage: Remove displaying forms - - - - - 3ffa37f2 by Philipp Hörist at 2019-10-14T15:31:43Z Refactor parsing xhtml Adapt to nbxmpp changes - - - - - 61873094 by Philipp Hörist at 2019-10-14T15:57:22Z Refactor parsing nickname - - - - - 1af5612d by Philipp Hörist at 2019-10-14T20:09:43Z Refactor parsing subject - - - - - 7b9278ae by Philipp Hörist at 2019-10-14T20:34:50Z Chatstate: Use StanzaHandler instead of delegate() - - - - - 7599a37d by Philipp Hörist at 2019-10-16T17:07:02Z Check for required pygobject version - - - - - 8c6e8ea9 by Philipp Hörist at 2019-10-16T17:26:57Z Refactor dependency checks - - - - - c54c1097 by Philipp Hörist at 2019-10-16T17:29:28Z Use single quotes - - - - - 39df77a6 by Philipp Hörist at 2019-10-16T17:30:37Z Use sys.platform instead of os.name - - - - - b2330c57 by Philipp Hörist at 2019-10-16T17:31:29Z Remove tooltip bug workaround for Gtk 3.24.1 Newer Gtk versions are available for Windows and Mac - - - - - 44630205 by Philipp Hörist at 2019-10-16T19:03:07Z Remove unused import - - - - - a4945d26 by Philipp Hörist at 2019-10-17T19:10:25Z Refactor message handlers - Remove 'decrypt' extension point, its not needed anymore - Remove decryption finished methods - Remove MessageReceived Events, DecryptedMessageReceived servs the same purpose now Plugins decrypt messages before we execute this handler - - - - - 0acfc4c8 by Philipp Hörist at 2019-10-18T21:01:28Z MAM: Correctly detect if we sent a message properties.jid always yields the remote JID now after nbxmpp changes - - - - - 0d7316be by Philipp Hörist at 2019-10-18T21:34:09Z AccountCreation: Register plugin modules after successful registration Fixes #9856 - - - - - 06700c96 by Philipp Hörist at 2019-10-19T13:24:28Z ConversationTextview: Refactor showing message icons - Add a dedicated MessageLine class which holds all informations about a message line and is easily expandable. - Add a MessageIcons Widget which holds all icons and is easily expandable later - - - - - 172725d1 by Philipp Hörist at 2019-10-19T13:51:20Z Passwords: Improve log message in case of deletion error Fixes #9865 - - - - - 9c431173 by Philipp Hörist at 2019-10-20T07:23:40Z ConversationTextview: Reduce line height - - - - - e1c684c6 by Philipp Hörist at 2019-10-20T14:46:28Z Database: Save message-id for sent messages - - - - - e5ac5e9b by Philipp Hörist at 2019-10-20T17:21:33Z Rework message error handling - Database: Save error in the corresponding message datarow - ConversationTextview: Show error icon with error message as tooltip - - - - - 39b4b8fc by Philipp Hörist at 2019-10-20T17:34:45Z Remove Fuzzy Clock I consider this feature bloat - - - - - 19b2911b by Philipp Hörist at 2019-10-20T17:37:33Z Rename method show_receipt_icon() -> show_receipt() - - - - - 8b6a1d1c by Philipp Hörist at 2019-10-20T19:54:36Z Receipts: Simplify event code - - - - - fddcd2b3 by Philipp Hörist at 2019-10-20T19:55:43Z Receipts: use build_receipt() - - - - - cd9885c0 by Daniel Brötzmann at 2019-10-23T14:25:45Z HistoryWindow: Close search results first This checks if the search results scrolled window is visible when pressing Esc. It will first hide the scrolled window, and only then close the history window. - - - - - e7bc06ca by Philipp Hörist at 2019-10-23T20:05:48Z Receipts: Save/Load receipts to/from database - - - - - 23448095 by Philipp Hörist at 2019-10-23T20:05:48Z ConversationTextview: Rename methods show_receipt_icon() -> set_receipt() show_error_icon() -> set_error() show_correction_icon() -> set_correction() - - - - - a298bf1c by Philipp Hörist at 2019-10-23T20:09:50Z Receipts: Don't request receipt in groupchat - - - - - bfc49cbf by Philipp Hörist at 2019-10-24T20:56:15Z Don't stop processing messages after receiving non-active chatstate Some client implement not recommended behavior and send other chatstates than active including a <body> - - - - - d7af6eb2 by Philipp Hörist at 2019-10-26T06:50:50Z Chatstates: Never stop message processing inside that module Clients adding chatstates should not disrupt Gajim - - - - - be2f3053 by Philipp Hörist at 2019-10-26T12:25:08Z Refactor blocking non-roster messages - - - - - cf55edfc by Philipp Hörist at 2019-10-27T20:20:23Z Windows: Upgrade build to python 3.8 - - - - - df7fd262 by Philipp Hörist at 2019-10-28T21:46:47Z Use nbxmpp properties attributes - - - - - 493d00bc by Philipp Hörist at 2019-10-28T21:53:02Z Remove unused method - - - - - ff9bc4f9 by Philipp Hörist at 2019-10-28T22:35:35Z Treat type normal messages as chat - - - - - 55cded2e by Philipp Hörist at 2019-10-28T22:43:20Z Remove unused code Code was not working for years, seems nobody missed it - - - - - 31f34991 by Philipp Hörist at 2019-10-29T20:25:23Z Zeroconf: Fix name conflict Pass kDNSServiceFlagsNoAutoRename to pybonjour so we dont end up with invalid names like `user@machine (2)` Refactor alternativ name suggestion into own method - - - - - 7101378b by Philipp Hörist at 2019-10-29T21:05:13Z Zeroconf: Don't show self contact Fixes #9090 - - - - - 21dafc3c by Sebastiaan Lokhorst at 2019-10-30T19:52:48Z MacOS: Use PyInstaller to build app - - - - - 1f5d81d1 by Sebastiaan Lokhorst at 2019-10-30T23:10:59Z MacOS: remove debug line from makebundle.py - - - - - 5aff9fb0 by Philipp Hörist at 2019-10-31T05:04:00Z MAM: Add nbxmpp properties to event Fixes #9876 - - - - - 96f9fbc2 by Philipp Hörist at 2019-11-01T09:14:07Z Database: Add index on the message_id column - - - - - 3d094aff by Philipp Hörist at 2019-11-01T18:15:32Z Zeroconf: Fix message handler - Fix checking wrong attribute - Add nbxmpp properties to event - - - - - fd75817f by Philipp Hörist at 2019-11-01T20:19:44Z ChatControl: Set message_id on restored conversation lines Fixes #9879 - - - - - 56aa7baa by Philipp Hörist at 2019-11-01T21:43:34Z Zeroconf: Fix pylint errors - Rename vars - Make vars/methods private - - - - - 14d6074f by Philipp Hörist at 2019-11-02T15:19:57Z Remove unused encrypted attribute Encryption information is saved in additional_data attribute - - - - - 6b723a89 by Philipp Hörist at 2019-11-02T15:25:23Z Copy JID before modifying - - - - - 02999050 by Philipp Hörist at 2019-11-02T15:31:59Z Remove unused attributes - - - - - 700747e0 by Philipp Hörist at 2019-11-02T18:23:38Z Remove subject attribute from decrypted-message event It's available via properties attribute - - - - - 2f8058b2 by Philipp Hörist at 2019-11-02T18:30:12Z Remove thread_id attribute from decrypted-message event It's available via properties attribute - - - - - fc8930aa by Philipp Hörist at 2019-11-02T18:36:16Z Remove attention attribute from decrypted-message event It's available via properties attribute - - - - - 05f9bd0b by Philipp Hörist at 2019-11-02T18:42:43Z Remove user_nick attribute from decrypted-message event It's available via properties attribute - - - - - 056279ed by Philipp Hörist at 2019-11-02T19:03:23Z Remove timestamp attribute from decrypted-message event It's available via properties attribute - - - - - caf48a40 by Philipp Hörist at 2019-11-02T19:14:23Z Remove message_id attribute from decrypted-message event It's available via properties attribute - - - - - e8eb3e3d by Philipp Hörist at 2019-11-02T20:42:21Z Remove sent attribute from decrypted-message event It's available via properties attribute - - - - - 55e1299d by Philipp Hörist at 2019-11-02T20:43:26Z Remove unused forwarded attribute from decrypted-message event - - - - - 83bff1b8 by Philipp Hörist at 2019-11-02T21:22:09Z Remove ReStructured text -> XHTML conversion This can be easily added back as a plugin if there is demand - - - - - ff8a1f28 by Philipp Hörist at 2019-11-03T21:02:03Z Refactor XHTML event code - Move xhtml data into additional_data - Remove xhtml event attribute - Allows now to store both message and xhtml data in the database - Always store xhtml data - - - - - 0e13ea76 by Philipp Hörist at 2019-11-04T20:06:21Z Add execution time debug info for all database querys Print a warning message for all database querys > 50 ms - - - - - 7931d111 by André Apitzsch at 2019-11-04T21:59:05Z Flatpak: Update dependencies - - - - - b4797d25 by Daniel Brötzmann at 2019-11-05T09:34:34Z XMLConsole: Add search functionality - - - - - 2e266601 by Philipp Hörist at 2019-11-05T18:14:20Z Remove nick and nickname attribute from gc-message-received event It's available via properties attribute - - - - - 74ac7653 by Philipp Hörist at 2019-11-05T18:14:21Z Remove nick attribute from mam-decrypted-message-received event It's available via properties attribute - - - - - b8d83eb5 by Philipp Hörist at 2019-11-05T18:14:25Z Remove unused real_jid attribute from mam-decrypted-message-received event - - - - - 8566d036 by Philipp Hörist at 2019-11-05T20:48:21Z DialogButton: Use better defaults for response - - - - - 491dad09 by Philipp Hörist at 2019-11-05T21:41:06Z Correctly open email links - - - - - b3f938e2 by Philipp Hörist at 2019-11-05T22:07:19Z Remove custom `open with` application settings Feature bloat. There is no good use case why the system defaults should not be sufficient. - - - - - 1fa8533c by Daniel Brötzmann at 2019-11-06T10:22:58Z Preferences: Add Open Folder for debug logs - - - - - 1f845aa3 by Daniel Brötzmann at 2019-11-06T20:34:14Z XMLConsole: Start search at beginning when changing search term - - - - - 3162d799 by André Apitzsch at 2019-11-06T21:11:36Z Fix opening URIs from sandbox - - - - - 7137b37e by Philipp Hörist at 2019-11-06T21:11:36Z Stay compatible with python 3.5 time.monotonic_ns() is only available in python 3.7+ - - - - - 1ac852f0 by Philipp Hörist at 2019-11-06T21:27:09Z Logger: Improve speed of find_stanza_id() The SQLite Query Planner does not use the best index - - - - - 96d6d5d5 by Philipp Hörist at 2019-11-07T15:24:39Z Revert "Fix opening URIs from sandbox" This reverts commit 3162d7990dcef528e307beca24cf5ea9ee6ba653 - - - - - 3898f165 by André Apitzsch at 2019-11-07T21:18:41Z Appdata: Fix image location because of new website - - - - - 6c0c4b22 by André Apitzsch at 2019-11-08T07:39:49Z Fix opening URIs from sandbox - - - - - 235f2a80 by Philipp Hörist at 2019-11-09T09:46:51Z Refactor opening files - Rename method - Catch and log all exceptions - - - - - f87f56ed by Philipp Hörist at 2019-11-09T14:44:57Z GroupchatControl: Dont handle PM's if a control is open The PrivateChatControl handles messages on its own - - - - - 0639bc03 by Philipp Hörist at 2019-11-09T15:04:23Z ChatControl: Don't handle MAM groupchat messages Fixes #9488 - - - - - a4806046 by Philipp Hörist at 2019-11-09T19:28:01Z Fix typo - - - - - 3594badf by André Apitzsch at 2019-11-10T12:04:11Z Flatpak: Support automatic status - - - - - 8f299caa by André Apitzsch at 2019-11-10T12:08:49Z Flatpak: Let portal handle notifications - - - - - 57249864 by Yann Leboulanger at 2019-11-10T13:35:49Z start implementing XEP-0333, chat markers - - - - - 772c2ea3 by Philipp Hörist at 2019-11-10T14:17:36Z Show display markers - - - - - 30 changed files: - data/org.gajim.Gajim.appdata.xml.in - flatpak/org.gajim.Gajim.yaml - gajim/app_actions.py - gajim/application.py - gajim/chat_control.py - gajim/chat_control_base.py - gajim/common/app.py - gajim/common/caps_cache.py - gajim/common/config.py - gajim/common/connection.py - gajim/common/connection_handlers.py - gajim/common/connection_handlers_events.py - gajim/common/events.py - − gajim/common/fuzzyclock.py - gajim/common/helpers.py - gajim/common/logger.py - gajim/common/modules/__init__.py - + gajim/common/modules/chat_markers.py - gajim/common/modules/chatstates.py - gajim/common/modules/mam.py - gajim/common/modules/message.py - gajim/common/modules/misc.py - gajim/common/modules/receipts.py - gajim/common/modules/user_nickname.py - gajim/common/passwords.py - − gajim/common/rst_xhtml_generator.py - gajim/common/zeroconf/client_zeroconf.py - gajim/common/zeroconf/connection_handlers_zeroconf.py - gajim/common/zeroconf/connection_zeroconf.py - gajim/common/zeroconf/roster_zeroconf.py The diff was not included because it is too large. View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/1f927251de6b137c46a7e215d0e30af0a… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/1f927251de6b137c46a7e215d0e30af0a… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Flatpak: Let portal handle notifications
by Philipp Hörist 10 Nov '19

10 Nov '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: 8f299caa by André Apitzsch at 2019-11-10T12:08:49Z Flatpak: Let portal handle notifications - - - - - 2 changed files: - flatpak/org.gajim.Gajim.yaml - gajim/gtk/notification.py Changes: ===================================== flatpak/org.gajim.Gajim.yaml ===================================== @@ -14,7 +14,6 @@ finish-args: - --socket=pulseaudio - --system-talk-name=org.freedesktop.GeoClue2 - --system-talk-name=org.freedesktop.login1 - - --talk-name=org.freedesktop.Notifications - --talk-name=org.gnome.ScreenSaver - --talk-name=org.mpris.MediaPlayer2.* - --talk-name=org.freedesktop.portal.Fcitx ===================================== gajim/gtk/notification.py ===================================== @@ -67,6 +67,10 @@ class Notification: if sys.platform in ('win32', 'darwin'): return + if app.is_flatpak(): + self._dbus_available = True + return + def on_proxy_ready(_source, res, _data=None): try: proxy = Gio.DBusProxy.new_finish(res) View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/8f299caa387aa6d6420e7b75cd99cccaf3… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/8f299caa387aa6d6420e7b75cd99cccaf3… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Flatpak: Support automatic status
by André 10 Nov '19

10 Nov '19

André pushed to branch master at gajim / gajim Commits: 3594badf by André Apitzsch at 2019-11-10T12:04:11Z Flatpak: Support automatic status - - - - - 1 changed file: - flatpak/org.gajim.Gajim.yaml Changes: ===================================== flatpak/org.gajim.Gajim.yaml ===================================== @@ -18,6 +18,8 @@ finish-args: - --talk-name=org.gnome.ScreenSaver - --talk-name=org.mpris.MediaPlayer2.* - --talk-name=org.freedesktop.portal.Fcitx + # Automatic status + - --talk-name=org.gnome.Mutter.IdleMonitor # Keyring - --talk-name=org.freedesktop.secrets # GnuPG View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/3594badf77205c28e2b9195f8839708c7d… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/3594badf77205c28e2b9195f8839708c7d… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Fix typo
by Philipp Hörist 09 Nov '19

09 Nov '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: a4806046 by Philipp Hörist at 2019-11-09T19:28:01Z Fix typo - - - - - 1 changed file: - gajim/common/helpers.py Changes: ===================================== gajim/common/helpers.py ===================================== @@ -1464,7 +1464,7 @@ def event_filter(filter_): return event_filter_decorator -def catch_execptions(func): +def catch_exceptions(func): @wraps(func) def func_wrapper(self, *args, **kwargs): try: @@ -1532,7 +1532,7 @@ def parse_uri(uri): return URI(type=URIType.WEB, data=uri) -@catch_execptions +@catch_exceptions def open_uri(uri, account=None): if not isinstance(uri, URI): uri = parse_uri(uri) @@ -1575,7 +1575,7 @@ def open_uri(uri, account=None): log.warning('Cant open URI: %s', uri) -@catch_execptions +@catch_exceptions def open_file(path): if os.name == 'nt': os.startfile(path) View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/a480604666674a1f87dd74cd797bedc4b2… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/a480604666674a1f87dd74cd797bedc4b2… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] ChatControl: Don't handle MAM groupchat messages
by Philipp Hörist 09 Nov '19

09 Nov '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: 0639bc03 by Philipp Hörist at 2019-11-09T15:04:23Z ChatControl: Don't handle MAM groupchat messages Fixes #9488 - - - - - 1 changed file: - gajim/chat_control.py Changes: ===================================== gajim/chat_control.py ===================================== @@ -790,6 +790,9 @@ class ChatControl(ChatControlBase): if obj.conn.name != self.account: return + if obj.properties.type.is_groupchat: + return + if obj.properties.is_muc_pm: if not obj.with_ == self.contact.get_full_jid(): return View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/0639bc034fcd1a557fff0bd77774c86650… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/0639bc034fcd1a557fff0bd77774c86650… You're receiving this email because of your account on dev.gajim.org.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits