Commits

commits@gajim.org

17632 discussions

[Git][gajim/gajim][master] Register: Use nbxmpp methods
by Philipp Hörist 22 Mar '20

22 Mar '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 86164a02 by lovetox at 2020-03-22T16:19:44+01:00 Register: Use nbxmpp methods - - - - - 2 changed files: - gajim/common/modules/register.py - gajim/gtk/change_password.py Changes: ===================================== gajim/common/modules/register.py ===================================== @@ -28,6 +28,8 @@ class Register(BaseModule): _nbxmpp_extends = 'Register' _nbxmpp_methods = [ 'unregister', + 'change_password', + 'change_password_with_form', ] def __init__(self, con): @@ -35,35 +37,6 @@ class Register(BaseModule): self.agent_registrations = {} - def change_password(self, password, success_cb, error_cb): - if not app.account_is_connected(self._account): - return - hostname = app.config.get_per('accounts', self._account, 'hostname') - username = app.config.get_per('accounts', self._account, 'name') - iq = nbxmpp.Iq(typ='set', to=hostname) - query = iq.setTag(nbxmpp.NS_REGISTER + ' query') - query.setTagData('username', username) - query.setTagData('password', password) - - weak_success_cb = weakref.WeakMethod(success_cb) - weak_error_cb = weakref.WeakMethod(error_cb) - self._log.info('Send password change') - self._con.connection.SendAndCallForResponse( - iq, self._change_password_response, {'success_cb': weak_success_cb, - 'error_cb': weak_error_cb}) - - def _change_password_response(self, _nbxmpp_client, stanza, - success_cb, error_cb): - if not nbxmpp.isResultNode(stanza): - error = stanza.getErrorMsg() - self._log.info('Error: %s', error) - if error_cb() is not None: - error_cb()(error) - else: - self._log.info('Password changed') - if success_cb() is not None: - success_cb()() - def register_agent(self, agent, form, is_form, success_cb, error_cb): if not app.account_is_connected(self._account): return ===================================== gajim/gtk/change_password.py ===================================== @@ -110,15 +110,14 @@ class ChangePassword(Assistant): self.set_default_button('back') def _on_apply(self, next_stage=False): - register = self._con.connection.get_module('Register') if next_stage: form = self.get_page('next_stage').get_submit_form() - register.change_password_with_form( + self._con.get_module('Register').change_password_with_form( form, callback=self._on_change_password) else: password = self.get_page('password').get_password() - register.change_password(password, - callback=self._on_change_password) + self._con.get_module('Register').change_password( + password, callback=self._on_change_password) @ensure_not_destroyed def _on_change_password(self, result): View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/86164a02969b50c660cf1299ec274870… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/86164a02969b50c660cf1299ec274870… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 6 commits: AccountWizard: Pass None for jid argument
by Philipp Hörist 22 Mar '20

22 Mar '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 48b849d9 by lovetox at 2020-03-22T11:40:20+01:00 AccountWizard: Pass None for jid argument - - - - - 26a09b83 by lovetox at 2020-03-22T13:30:45+01:00 Client: Remove some attributes - - - - - 78bc04ae by lovetox at 2020-03-22T13:30:50+01:00 Client: Add account-connected signal - - - - - 1f013461 by lovetox at 2020-03-22T14:23:53+01:00 Register: Extend nbxmpp module - - - - - fff671be by lovetox at 2020-03-22T15:45:13+01:00 AccountWizard: Ignore stream error if we know we succeeded - - - - - 5ac5439d by lovetox at 2020-03-22T15:55:06+01:00 Make account removal work again - - - - - 4 changed files: - gajim/common/client.py - gajim/common/modules/register.py - gajim/gtk/account_wizard.py - gajim/gtk/remove_account.py Changes: ===================================== gajim/common/client.py ===================================== @@ -59,8 +59,6 @@ class Client(ConnectionHandlers): self.password = None self.priority = 0 - self.server_resource = None - self.registered_name = None self.handlers_registered = False self._connect_machine_calls = 0 self.avatar_conversion = False @@ -77,6 +75,7 @@ class Client(ConnectionHandlers): self._reconnect = True self._reconnect_timer_source = None self._destroy_client = False + self._remove_account = False self._ssl_errors = set() @@ -113,6 +112,12 @@ class Client(ConnectionHandlers): def features(self): return self._client.features + def set_remove_account(self, value): + # Used by the RemoveAccount Assistant to make the Client + # not react to any stream errors that happen while the + # account is removed by the server and the connection is killed + self._remove_account = value + def _create_client(self): log.info('Create new nbxmpp client') self._client = NBXMPPClient(log_context=self._account) @@ -180,6 +185,9 @@ class Client(ConnectionHandlers): def _on_resume_successful(self, _client, _signal_name): self._set_state(ClientState.CONNECTED) + app.nec.push_incoming_event(NetworkEvent('account-connected', + account=self._account)) + app.nec.push_incoming_event( OurShowEvent(None, conn=self, show=self._status)) @@ -200,7 +208,12 @@ class Client(ConnectionHandlers): self._set_state(ClientState.DISCONNECTED) domain, error, text = self._client.get_error() - if domain == StreamError.BAD_CERTIFICATE: + + if self._remove_account: + # Account was removed via RemoveAccount Assistant. + self._reconnect = False + + elif domain == StreamError.BAD_CERTIFICATE: self._ssl_errors = self._client.peer_certificate[1] self.get_module('Chatstate').enabled = False self._reconnect = False @@ -269,10 +282,8 @@ class Client(ConnectionHandlers): def _on_connected(self, client, _signal_name): self._set_state(ClientState.CONNECTED) - self.server_resource = 'test' - self.registered_name = client.get_bound_jid() - log.info('Bound JID: %s', self.registered_name) - + app.nec.push_incoming_event(NetworkEvent('account-connected', + account=self._account)) self.get_module('Discovery').discover_server_info() self.get_module('Discovery').discover_account_info() self.get_module('Discovery').discover_server_items() @@ -288,17 +299,16 @@ class Client(ConnectionHandlers): app.nec.push_incoming_event(NetworkEvent('stanza-received', account=self._account, stanza=stanza)) - def get_own_jid(self, warn=False): + def get_own_jid(self): """ Return the last full JID we received on a bind event. In case we were never connected it returns the bare JID from config. """ - if self.registered_name: - # This returns the full jid we received on the bind event - return self.registered_name + if self._client is not None: + jid = self._client.get_bound_jid() + if jid is not None: + return jid - if warn: - log.warning('only bare JID available') # This returns the bare jid return nbxmpp.JID(app.get_jid_from_account(self._account)) @@ -319,7 +329,6 @@ class Client(ConnectionHandlers): if show == 'offline': return - self.server_resource = helpers.get_resource(self._account) self.connect() return ===================================== gajim/common/modules/register.py ===================================== @@ -24,6 +24,12 @@ from gajim.common.modules.bits_of_binary import parse_bob_data class Register(BaseModule): + + _nbxmpp_extends = 'Register' + _nbxmpp_methods = [ + 'unregister', + ] + def __init__(self, con): BaseModule.__init__(self, con) ===================================== gajim/gtk/account_wizard.py ===================================== @@ -312,7 +312,13 @@ class AccountWizard(Assistant): _('This server does not allow signup.')) elif domain == StreamError.STREAM: - self._show_error_page(_('Error'), _('Error'), error) + # The credential test often ends with a stream error, because + # after auth there should be a stream restart but nbxmpp ends + # the stream with </stream> which is considered not-well-formed + # by the server. This ignores all stream errors if we already + # know that we succeeded. + if self.get_current_page() != 'success': + self._show_error_page(_('Error'), _('Error'), error) self.get_page('form').remove_form() self._client.destroy() @@ -380,7 +386,9 @@ class AccountWizard(Assistant): form = self.get_page('form').get_submit_form() self._client.get_module('Register').submit_register_form( - form, callback=self._on_register_result) + None, + form, + callback=self._on_register_result) @ensure_not_destroyed def _on_register_result(self, result): ===================================== gajim/gtk/remove_account.py ===================================== @@ -19,8 +19,10 @@ from gi.repository import Gtk from nbxmpp.util import is_error_result from gajim.common import app +from gajim.common import ged from gajim.common.i18n import _ from gajim.common.helpers import to_user_string +from gajim.common.helpers import event_filter from gajim.gtk.assistant import Assistant from gajim.gtk.assistant import Page @@ -36,6 +38,7 @@ class RemoveAccount(Assistant): self.account = account self._con = app.connections.get(account) self._destroyed = False + self._account_removed = False self.add_button('remove', _('Remove'), 'destructive-action') self.add_button('close', _('Close')) @@ -63,8 +66,32 @@ class RemoveAccount(Assistant): self.connect('page-changed', self._on_page_changed) self.connect('destroy', self._on_destroy) + self.register_events([ + ('account-connected', ged.GUI1, self._on_account_connected), + ('account-disconnected', ged.GUI1, self._on_account_disconnected), + ]) + + self._set_remove_from_server_checkbox() + self.show_all() + @event_filter(['account']) + def _on_account_connected(self, event): + self._con = app.connections.get(self.account) + self._set_remove_from_server_checkbox() + + @event_filter(['account']) + def _on_account_disconnected(self, event): + self._set_remove_from_server_checkbox() + + if self._account_removed: + self.show_page('success') + app.interface.remove_account(self.account) + + def _set_remove_from_server_checkbox(self): + enabled = self._con is not None and self._con.state.is_connected + self.get_page('remove_choice').set_remove_from_server(enabled) + @staticmethod def _visible_func(_assistant, page_name): if page_name == 'remove_choice': @@ -108,24 +135,31 @@ class RemoveAccount(Assistant): self.set_default_button('back') def _on_remove(self, *args): - if self.get_page('remove_choice').is_remove_from_server(): - self._con.unregister_account(self._on_remove_response) - else: - if app.account_is_connected(self.account): - self._con.change_status('offline', 'offline') + if self.get_page('remove_choice').remove_from_server: + self._con.set_remove_account(True) + self._con.get_module('Register').unregister( + callback=self._on_remove_response) + return + + if self._con is None or self._con.state.is_disconnected: app.interface.remove_account(self.account) - self.destroy() + self.show_page('success') + return + + self._con.disconnect(gracefully=True, reconnect=False) + self._account_removed = True @ensure_not_destroyed def _on_remove_response(self, result): if is_error_result(result): - self._con.removing_account = False + self._con.set_remove_account(False) + error_text = to_user_string(result) self.get_page('error').set_text(error_text) self.show_page('error') - else: - app.interface.remove_account(self.account) - self.show_page('success') + return + + self._account_removed = True def _on_destroy(self, *args): self._destroyed = True @@ -170,5 +204,14 @@ class RemoveChoice(Page): self.pack_start(self._server, False, True, 0) self.show_all() - def is_remove_from_server(self): + @property + def remove_from_server(self): return self._server.get_active() + + def set_remove_from_server(self, enabled): + self._server.set_sensitive(enabled) + if enabled: + self._server.set_tooltip_text('') + else: + self._server.set_active(False) + self._server.set_tooltip_text(_('Account has to be connected')) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/29c6f0ba89e39f910f91390040dfcda… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/29c6f0ba89e39f910f91390040dfcda… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/python-nbxmpp][master] Register: Allow to set jid on some methods
by Philipp Hörist 22 Mar '20

22 Mar '20

Philipp Hörist pushed to branch master at gajim / python-nbxmpp Commits: c1c5d310 by lovetox at 2020-03-22T11:39:05+01:00 Register: Allow to set jid on some methods - - - - - 1 changed file: - nbxmpp/modules/register.py Changes: ===================================== nbxmpp/modules/register.py ===================================== @@ -44,9 +44,8 @@ class Register(BaseModule): self.handlers = [] @call_on_response('_default_response') - def unregister(self): - domain = self._client.get_bound_jid().getDomain() - iq = Iq('set', to=domain) + def unregister(self, jid=None): + iq = Iq('set', to=jid) query = iq.setQuery() query.setNamespace(NS_REGISTER) query.addChild('remove') @@ -77,8 +76,11 @@ class Register(BaseModule): return data @call_on_response('_on_submit_result') - def submit_register_form(self, form): - iq = Iq('set', NS_REGISTER, to=self._client.domain) + def submit_register_form(self, jid, form): + if jid is None: + jid = self._client.domain + + iq = Iq('set', NS_REGISTER, to=jid) if form.is_fake_form(): query = iq.getTag('query') View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/c1c5d310732d60a3efdb2d2d… -- View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/c1c5d310732d60a3efdb2d2d… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 3 commits: Client: Raise notification on SASL errors
by Philipp Hörist 22 Mar '20

22 Mar '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: ad53f214 by lovetox at 2020-03-22T09:26:37+01:00 Client: Raise notification on SASL errors - - - - - d64b578c by lovetox at 2020-03-22T09:49:07+01:00 Client: Never allow Client.status to be 'offline' status should be used to track our presence show value only All code should depend on ClientState to determine if we are offline - - - - - 29c6f0ba by lovetox at 2020-03-22T10:01:18+01:00 AccountWizard: Fix method call - - - - - 4 changed files: - gajim/common/cert_store.py - gajim/common/client.py - gajim/gtk/account_wizard.py - gajim/gtk/notification.py Changes: ===================================== gajim/common/cert_store.py ===================================== @@ -61,6 +61,7 @@ class CertificateStore: return list(self._certs) def add_certificate(self, certificate): + log.info('Add certificate to trust store') pem = certificate.props.certificate_pem path = self._get_random_path() write_file_async(path, ===================================== gajim/common/client.py ===================================== @@ -36,6 +36,7 @@ from gajim.common.helpers import get_custom_host from gajim.common.helpers import get_user_proxy from gajim.common.helpers import warn_about_plain_connection from gajim.common.helpers import get_resource +from gajim.common.i18n import _ from gajim.common.connection_handlers import ConnectionHandlers from gajim.common.connection_handlers_events import OurShowEvent @@ -70,7 +71,7 @@ class Client(ConnectionHandlers): self.roster_supported = True self._state = ClientState.DISCONNECTED - self._status = 'offline' + self._status = 'online' self._status_message = '' self._reconnect = True @@ -198,7 +199,7 @@ class Client(ConnectionHandlers): log.info('Disconnect %s', self._account) self._set_state(ClientState.DISCONNECTED) - domain, error, _text = self._client.get_error() + domain, error, text = self._client.get_error() if domain == StreamError.BAD_CERTIFICATE: self._ssl_errors = self._client.peer_certificate[1] self.get_module('Chatstate').enabled = False @@ -226,6 +227,13 @@ class Client(ConnectionHandlers): app.nec.push_incoming_event(NetworkEvent( 'password-required', conn=self, on_password=_on_password)) + app.nec.push_incoming_event( + NetworkEvent('simple-notification', + account=self._account, + type_='connection-failed', + title=_('Authentication failed'), + text=text or error)) + if self._reconnect: self._after_disconnect() self._schedule_reconnect() @@ -233,7 +241,6 @@ class Client(ConnectionHandlers): OurShowEvent(None, conn=self, show='error')) else: - self._status = 'offline' self.get_module('Chatstate').enabled = False app.nec.push_incoming_event(OurShowEvent( None, conn=self, show='offline')) @@ -299,7 +306,8 @@ class Client(ConnectionHandlers): if not msg: msg = '' - self._status = show + if show != 'offline': + self._status = show self._status_message = msg if self._state.is_disconnecting: ===================================== gajim/gtk/account_wizard.py ===================================== @@ -121,7 +121,7 @@ class AccountWizard(Assistant): self._test_credentials() elif page == 'security-warning': - if self.get_page('security-warning').is_add_to_trusted: + if self.get_page('security-warning').trust_certificate: app.cert_store.add_certificate( self.get_page('security-warning').cert) self._test_credentials(ignore_all_errors=True) @@ -141,7 +141,7 @@ class AccountWizard(Assistant): self._register_with_server() elif page == 'security-warning': - if self.get_page('security-warning').is_add_to_trusted: + if self.get_page('security-warning').trust_certificate: app.cert_store.add_certificate( self.get_page('security-warning').cert) self._register_with_server(ignore_all_errors=True) @@ -727,7 +727,8 @@ class SecurityWarning(Page): transient_for=self.get_toplevel(), cert=self._cert) - def is_add_to_trusted(self): + @property + def trust_certificate(self): return self._ui.trust_cert_checkbutton.get_active() ===================================== gajim/gtk/notification.py ===================================== @@ -61,6 +61,7 @@ class Notification(EventHelper): self.register_events([ ('notification', ged.GUI2, self._nec_notification), + ('simple-notification', ged.GUI2, self._on_notification), ('our-show', ged.GUI2, self._nec_our_status), ]) @@ -114,6 +115,13 @@ class Notification(EventHelper): except Exception: pass + def _on_notification(self, event): + self.popup(event.type_, + None, + event.account, + title=event.title, + text=event.text) + def _on_event_removed(self, event_list): for event in event_list: if event.type_ == 'gc-invitation': View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/25494124cdfcb68e205a5d85cc96e84… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/25494124cdfcb68e205a5d85cc96e84… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Client: Set client state before our-show event
by Philipp Hörist 22 Mar '20

22 Mar '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 25494124 by lovetox at 2020-03-22T07:31:10+01:00 Client: Set client state before our-show event - - - - - 1 changed file: - gajim/common/client.py Changes: ===================================== gajim/common/client.py ===================================== @@ -196,6 +196,7 @@ class Client(ConnectionHandlers): def _on_disconnected(self, _client, _signal_name): log.info('Disconnect %s', self._account) + self._set_state(ClientState.DISCONNECTED) domain, error, _text = self._client.get_error() if domain == StreamError.BAD_CERTIFICATE: @@ -232,14 +233,13 @@ class Client(ConnectionHandlers): OurShowEvent(None, conn=self, show='error')) else: + self._status = 'offline' self.get_module('Chatstate').enabled = False app.nec.push_incoming_event(OurShowEvent( None, conn=self, show='offline')) self._after_disconnect() def _after_disconnect(self): - log.info('Set state disconnected') - self._set_state(ClientState.DISCONNECTED) self._disable_reconnect_timer() app.interface.music_track_changed(None, None, self._account) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/25494124cdfcb68e205a5d85cc96e847… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/25494124cdfcb68e205a5d85cc96e847… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Interface: Check mandatory values on account creation
by Philipp Hörist 21 Mar '20

21 Mar '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: dea91b16 by lovetox at 2020-03-21T23:53:43+01:00 Interface: Check mandatory values on account creation Missing one of these values leads to broken accounts - - - - - 1 changed file: - gajim/gui_interface.py Changes: ===================================== gajim/gui_interface.py ===================================== @@ -1648,13 +1648,19 @@ class Interface: app.sleeper_state[account] = 'autoxa' return True # renew timeout (loop for ever) - def create_account(self, - account, + @staticmethod + def create_account(account, username, domain, password, anonymous=False): + if not account or not username or not domain: + log.error('Creating account failed: ' + 'account: %s, username: %s, domain: %s', + account, username, domain) + return + config = {} config['active'] = False config['name'] = username View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/dea91b1640590298308b80014bde4d00… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/dea91b1640590298308b80014bde4d00… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] AccountWizard: Use @ensure_not_destroyed for callbacks
by Philipp Hörist 21 Mar '20

21 Mar '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 1bd6bcfc by lovetox at 2020-03-21T23:08:21+01:00 AccountWizard: Use @ensure_not_destroyed for callbacks - - - - - 1 changed file: - gajim/gtk/account_wizard.py Changes: ===================================== gajim/gtk/account_wizard.py ===================================== @@ -43,6 +43,8 @@ from gajim.gtk.assistant import Page from gajim.gtk.dataform import DataFormWidget from gajim.gtk.util import get_builder from gajim.gtk.util import open_window +from gajim.gtk.util import ensure_not_destroyed + log = logging.getLogger('gajim.gtk.account_wizard') @@ -343,6 +345,7 @@ class AccountWizard(Assistant): i += 1 return domain + @ensure_not_destroyed def _on_register_form(self, result): if is_error_result(result): self._show_error_page(_('Error'), @@ -379,6 +382,7 @@ class AccountWizard(Assistant): self._client.get_module('Register').submit_register_form( form, callback=self._on_register_result) + @ensure_not_destroyed def _on_register_result(self, result): if is_error_result(result): self._on_register_error(result) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/1bd6bcfc32131a1903942de473527964… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/1bd6bcfc32131a1903942de473527964… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/python-nbxmpp][master] 3 commits: Dataforms: Set vars if form is not build from node
by Philipp Hörist 21 Mar '20

21 Mar '20

Philipp Hörist pushed to branch master at gajim / python-nbxmpp Commits: ecb882e0 by lovetox at 2020-03-21T22:57:49+01:00 Dataforms: Set vars if form is not build from node - - - - - 8bc83974 by lovetox at 2020-03-21T22:58:09+01:00 Dataforms: Add is_fake_form() method - - - - - 410fa7d5 by lovetox at 2020-03-21T22:58:55+01:00 Register: Convert fake form to register fields on submit - - - - - 2 changed files: - nbxmpp/modules/dataforms.py - nbxmpp/modules/register.py Changes: ===================================== nbxmpp/modules/dataforms.py ===================================== @@ -544,8 +544,6 @@ class DataRecord(ExtendedNode): extend_field(field) self.vars[field.var] = field else: - for field in self.getTags('field'): - self.delChild(field) self.fields = fields @property @@ -562,11 +560,13 @@ class DataRecord(ExtendedNode): if not isinstance(field, DataField): extend_field(field) self.addChild(node=field) + self.vars[field.var] = field @fields.deleter def fields(self): for element in self.getTags('field'): self.delChild(element) + self.vars.clear() def iter_fields(self): """ @@ -592,6 +592,9 @@ class DataRecord(ExtendedNode): return False return True + def is_fake_form(self): + return bool(self.vars.get('fakeform', False)) + class DataForm(ExtendedNode): def __init__(self, type_=None, title=None, instructions=None, extend=None): ===================================== nbxmpp/modules/register.py ===================================== @@ -79,6 +79,15 @@ class Register(BaseModule): @call_on_response('_on_submit_result') def submit_register_form(self, form): iq = Iq('set', NS_REGISTER, to=self._client.domain) + + if form.is_fake_form(): + query = iq.getTag('query') + for field in form.iter_fields(): + if field.var == 'fakeform': + continue + query.addChild(field.var, payload=[field.value]) + return iq + iq.setQueryPayload(form) return iq View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/compare/d4c2e5c72e6cd03f893f0f5… -- View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/compare/d4c2e5c72e6cd03f893f0f5… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] AccountWizard: Fix typo in method call
by Philipp Hörist 21 Mar '20

21 Mar '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 1509414b by lovetox at 2020-03-21T21:58:32+01:00 AccountWizard: Fix typo in method call - - - - - 1 changed file: - gajim/gtk/account_wizard.py Changes: ===================================== gajim/gtk/account_wizard.py ===================================== @@ -401,7 +401,7 @@ class AccountWizard(Assistant): _('Error'), result.get_text()) - register_data = result.get_date() + register_data = result.get_data() if register_data is None: # IQ error did not have the payload included self.get_page('form').remove_form() View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/1509414b4c687a1ef02bd5bbe867ce27… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/1509414b4c687a1ef02bd5bbe867ce27… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/python-nbxmpp][master] Register: Add missing instructions to form
by Philipp Hörist 21 Mar '20

21 Mar '20

Philipp Hörist pushed to branch master at gajim / python-nbxmpp Commits: d4c2e5c7 by lovetox at 2020-03-21T21:39:07+01:00 Register: Add missing instructions to form - - - - - 1 changed file: - nbxmpp/modules/register.py Changes: ===================================== nbxmpp/modules/register.py ===================================== @@ -151,7 +151,9 @@ class Register(BaseModule): return None fields.append(create_field(typ='hidden', var='fakeform')) - return SimpleDataForm(type_='form', fields=fields) + return SimpleDataForm(type_='form', + instructions=query.getTagData('instructions'), + fields=fields) @call_on_response('_on_password_change') def change_password(self, password): View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/d4c2e5c72e6cd03f893f0f58… -- View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/d4c2e5c72e6cd03f893f0f58… You're receiving this email because of your account on dev.gajim.org.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits