Commits

commits@gajim.org

17632 discussions

[Git][gajim/gajim][master] App: Add get_client()
by Philipp Hörist 11 May '20

11 May '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 2c0ff8ee by lovetox at 2020-05-11T21:52:14+02:00 App: Add get_client() - - - - - 1 changed file: - gajim/common/app.py Changes: ===================================== gajim/common/app.py ===================================== @@ -157,6 +157,10 @@ _dependencies = { } +def get_client(account): + return connections[account] + + def is_installed(dependency): if dependency == 'ZEROCONF': # Alias for checking zeroconf libs View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/2c0ff8ee892505651cefac31a1d030c2… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/2c0ff8ee892505651cefac31a1d030c2… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Remove shttp:// from the protocol list
by Philipp Hörist 10 May '20

10 May '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 685fc6c4 by Emmanuel Gil Peyrot at 2020-05-10T22:21:00+02:00 Remove shttp:// from the protocol list This protocol never took off as https is much more secure for basically no downside (aside from running on a different port). - - - - - 1 changed file: - gajim/common/config.py Changes: ===================================== gajim/common/config.py ===================================== @@ -214,7 +214,7 @@ class Config: 'change_status_window_timeout': [opt_int, 15, _('Time of inactivity needed before the change status window closes down.')], 'max_conversation_lines': [opt_int, 500, _('Maximum number of lines that are printed in conversations. Oldest lines are cleared.')], 'check_idle_every_foo_seconds': [opt_int, 2, _('Choose interval between 2 checks of idleness.')], - 'uri_schemes': [opt_str, 'aaa:// aaas:// acap:// cap:// cid: crid:// data: dav: dict:// dns: fax: file:/ ftp:// geo: go: gopher:// h323: http:// https:// iax: icap:// im: imap:// info: ipp:// iris: iris.beep: iris.xpc: iris.xpcs: iris.lwz: ldap:// mid: modem: msrp:// msrps:// mtqp:// mupdate:// news: nfs:// nntp:// opaquelocktoken: pop:// pres: prospero:// rtsp:// service: shttp:// sip: sips: sms: snmp:// soap.beep:// soap.beeps:// tag: tel: telnet:// tftp:// thismessage:/ tip:// tv: urn:// vemmi:// xmlrpc.beep:// xmlrpc.beeps:// z39.50r:// z39.50s:// about: apt: cvs:// daap:// ed2k:// feed: fish:// git:// iax2: irc:// ircs:// ldaps:// magnet: mms:// rsync:// ssh:// svn:// sftp:// smb:// webcal:// aesgcm://', _('Valid URI schemes. Only schemes in this list will be accepted as \'real\' URI (mailto and xmpp are handled separately).'), True], + 'uri_schemes': [opt_str, 'aaa:// aaas:// acap:// cap:// cid: crid:// data: dav: dict:// dns: fax: file:/ ftp:// geo: go: gopher:// h323: http:// https:// iax: icap:// im: imap:// info: ipp:// iris: iris.beep: iris.xpc: iris.xpcs: iris.lwz: ldap:// mid: modem: msrp:// msrps:// mtqp:// mupdate:// news: nfs:// nntp:// opaquelocktoken: pop:// pres: prospero:// rtsp:// service: sip: sips: sms: snmp:// soap.beep:// soap.beeps:// tag: tel: telnet:// tftp:// thismessage:/ tip:// tv: urn:// vemmi:// xmlrpc.beep:// xmlrpc.beeps:// z39.50r:// z39.50s:// about: apt: cvs:// daap:// ed2k:// feed: fish:// git:// iax2: irc:// ircs:// ldaps:// magnet: mms:// rsync:// ssh:// svn:// sftp:// smb:// webcal:// aesgcm://', _('Valid URI schemes. Only schemes in this list will be accepted as \'real\' URI (mailto and xmpp are handled separately).'), True], 'shell_like_completion': [opt_bool, False, _('If enabled, completion in group chats will be like a shell auto-completion.')], 'audio_input_device': [opt_str, 'autoaudiosrc ! volume name=gajim_vol'], 'audio_output_device': [opt_str, 'autoaudiosink'], View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/685fc6c474df3ee5366b260f4c0a0779… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/685fc6c474df3ee5366b260f4c0a0779… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][gajim_1.2] 7 commits: Remove unused code
by Philipp Hörist 10 May '20

10 May '20

Philipp Hörist pushed to branch gajim_1.2 at gajim / gajim Commits: 2b615560 by lovetox at 2020-05-10T19:44:31+02:00 Remove unused code - - - - - 95e3267a by André Apitzsch at 2020-05-10T19:44:31+02:00 Read categories from desktop file See https://github.com/flathub/flathub/wiki/AppData-Guidelines#icons-and-catego… - - - - - 78b919db by André Apitzsch at 2020-05-10T19:44:31+02:00 MUC: Replace /me in notification - - - - - bd29d3fb by lovetox at 2020-05-10T19:44:31+02:00 XMLConsole: Show stanza generated by the AccountWizard - - - - - 23541db9 by lovetox at 2020-05-10T19:44:31+02:00 AccountWizard: Add fallback error message - - - - - d8eb304c by André Apitzsch at 2020-05-10T19:44:31+02:00 GUI: Replace deprecated properties + raise min version - - - - - 03412e7e by Daniel Brötzmann at 2020-05-10T19:44:44+02:00 Update ChangeLog - - - - - 14 changed files: - ChangeLog - data/org.gajim.Gajim.appdata.xml.in - gajim/common/connection_handlers_events.py - gajim/data/gui/add_new_contact_window.ui - gajim/data/gui/contact_context_menu.ui - gajim/data/gui/filetransfers_send_file_dialog.ui - gajim/data/gui/preferences_window.ui - gajim/data/gui/roster_window.ui - gajim/data/gui/server_info.ui - gajim/data/gui/tooltip_roster_contact.ui - gajim/data/gui/xml_console.ui - gajim/gtk/account_wizard.py - gajim/gtk/xml_console.py - gajim/plugins/pluginmanager.py Changes: ===================================== ChangeLog ===================================== @@ -1,4 +1,101 @@ -Gajim 1.1.0 (TBA) +Gajim 1.2.0-beta1 / 1.1.99.1 (01 May 2020) + + New + + * Rewritten network code + * Support for WebSocket (RFC 7395) + * Improved proxy handling + * Group chat pages (invite, information, nickname, subject, etc.) + * Group chat creation window + * Updated account creation assistant + * Updated assistants for password changing and account removal + * Updated server info window (connection details) + * Updated theme manager + * Default avatars (XEP-0392) + * Paste images from clipboard + * Contrast and color improvements for both light and dark themes + * Removed 'Invisible' status + * Removed FuzzyClock feature + + Bug fixes + + * List of fixed issues https://dev.gajim.org/gajim/gajim/-/issues?scope=all&utf8=%E2%9C%93&state=c… + +Gajim 1.1.3-1 (15 January 2020) + + * Flatpak build update + +Gajim 1.1.3 (23 April 2019) + + New + + * Add a mobile phone indicator to the chat window + * Rework HTTPUpload dialog + * Add a "paste as quote" option to the message input + + Bug fixes + + * #8822 Fix memory leak when using spell checker + * #9514 Fix jingle filetransfers not working in some circumstances + * #9573 Dont leak DNS query when connecting over proxy + * #9578 Determine Windows version more reliably + * #9622 Fix an error while quitting Gajim + * #9633 Fix an error while sending a file + * #9637 Restore window size correctly on wayland + * #9660 GPG Agent setting is ignored + * #9645 Make zeroconf IPV6 compatible + * Improve dark theme colors + * Fix access to GnuPG keys + * Use UUID4 item ids for pubsub posts + * Dont send invalid show values + * Windows: Dont override format region settings + * Various smaller improvements + +Gajim 1.1.2 (15 January 2019) + + New + + * Remove support for XEP-0091 + + Bug fixes + + * #9322 Error when adding contact + * #9385 Ignore invalid bookmarks + * #9386 Discovery: Browsing nodes without identity + * #9393 Error when parsing invalid timestamps + * #9398 Error on jingle file transfer + +Gajim 1.1.1 (24 December 2018) + + Bug fixes + + * #8362 DBus: Incorrect unread message count + * #9427 Placeholder not cleared if pasting text into message input + * #9444 Determine the delay timestamp correctly when using mam:1 + * #9453 Fix opening links inside the group chat subject (MacOS/Windows) + * #9465 Allow the full range of possible nicknames in group chats + * #9067 Gajim crashes when receiving xhtml messages + * #9096 Error when clicking on a subscription notification + * #9446 Chatstate error in MUC conversation + * #9471 Conversation Textview: Error on key press + * #9472 Handle presences without from attr correctly + * #9473 Error when creating a new group chat + * #9491 Identify group chat subject changes correctly + * #9496 Error on MUC roster selection change + * Determine soundplayer correctly on unix systems + * In some circumstances plugins could not be deleted + * Show correct contact status on tabs + * Dont answer group chat receipt requests + * Fix receipts for private messages + * Pressing the back button in the Accounts window leads to an error + * Better handle not available keyring backends + * Dont show incorrect contact on private messages + * Join group chat menu is disabled when there are no bookmarks + * Error on start chat menu action + * Error when opening sign-in/out notification + * Copying text does not work with different keyboard layouts + +Gajim 1.1.0 (06 May 2018) New @@ -6,13 +103,13 @@ Gajim 1.1.0 (TBA) Bug fixes - * 9322 Error when adding contact - * 9385 Ignore invalid bookmarks - * 9386 Discovery: Browsing nodes without identity - * 9393 Error when parsing invalid timestamps - * 9398 Error on jingle file transfer + * #9322 Error when adding contact + * #9385 Ignore invalid bookmarks + * #9386 Discovery: Browsing nodes without identity + * #9393 Error when parsing invalid timestamps + * #9398 Error on jingle file transfer -Gajim 1.0.99.1 (07 October 2018) +Gajim 1.1.0-beta2 / 1.0.99.1 (13 October 2018) New @@ -27,19 +124,19 @@ Gajim 1.0.99.1 (07 October 2018) Bug fixes - * 9198 Creating new MUCs with captial letters is not possible - * 9210 Error when clicking on new message indicator - * 9280 Inviting users to a MUC causes error - * 9301 Error when opening service discovery window - * 9309 Error when clicking on a groupchat invite notification - * 9311 Error when requesting server info - * 9117 Windows UAC changes status not available - * 9324 No menus/dialogs on Win7 - * 9326 IPV6 Connection problem on Win10 - * 9334 Joining big MUCs takes very long - * 9339 Error caused by remote_control + * #9198 Creating new MUCs with captial letters is not possible + * #9210 Error when clicking on new message indicator + * #9280 Inviting users to a MUC causes error + * #9301 Error when opening service discovery window + * #9309 Error when clicking on a groupchat invite notification + * #9311 Error when requesting server info + * #9117 Windows UAC changes status not available + * #9324 No menus/dialogs on Win7 + * #9326 IPV6 Connection problem on Win10 + * #9334 Joining big MUCs takes very long + * #9339 Error caused by remote_control -Gajim 1.0.99 (19 August 2018) +Gajim 1.1.0-beta1 / 1.0.99 (19 August 2018) New @@ -60,16 +157,16 @@ Gajim 1.0.99 (19 August 2018) Bug fixes - * 8658 Translation doesnt work on Windows - * 8750 Increase time frame for duplicate search in MUCs - * 9138 Translation in Flatpak does not work - * 9140 Error when clicking on the notification of an incoming message - * 9159 Wrong form type when responding to a voice request - * 9069 Send cancel IQ if muc configuration is aborted - * 9167 Flatpak fails to determine locale settings - * 9171 Gajim requests vcard multiple times - * 9198 Creating new MUCs with capital letters is not possible - * 9211 Punycode and Unicode with Internationalized Domain Names + * #8658 Translation doesnt work on Windows + * #8750 Increase time frame for duplicate search in MUCs + * #9138 Translation in Flatpak does not work + * #9140 Error when clicking on the notification of an incoming message + * #9159 Wrong form type when responding to a voice request + * #9069 Send cancel IQ if muc configuration is aborted + * #9167 Flatpak fails to determine locale settings + * #9171 Gajim requests vcard multiple times + * #9198 Creating new MUCs with capital letters is not possible + * #9211 Punycode and Unicode with Internationalized Domain Names Other changes @@ -91,9 +188,9 @@ Gajim 1.0.3 (20 May 2018) Bugs fixed: - * 8296 Fix errors on roster updates after stream management resume - * 9106 Convert font weight from pango to css values - * 9124 Bring ChatControl to front when notification is clicked + * #8296 Fix errors on roster updates after stream management resume + * #9106 Convert font weight from pango to css values + * #9124 Bring ChatControl to front when notification is clicked * Set no-store hint on groupchat chatstates * Dont show OOB uri if message body is the same @@ -107,26 +204,26 @@ Gajim 1.0.2 (30 April 2018) Bugs fixed: - * 7879 Server name is rejected for group chat bookmarks - * 8964 setup.py install misses some files if used with "--skip-build" - * 9017 Password was sometimes stored in plaintext - * 9022 Dont show error when receiving invalid avatars - * 9031 Windows: Always hide roster window on X - * 9038 No License in About dialog - * 9039 Encode filenames before sending - * 9044 Catch invalid IQ stanzas and log them - * 9049 XMPP logo in "Add New Contact" window instead Gajim logo - * 9050 Mark some strings as translatable - * 9054 Error on file send completion - * 9055 Removing a bookmark causes error - * 9057 Avatar is deleted when updating vCard - * 9065 Account label isn't change in tooltip of notification area icon - * 9066 Placeholder text does't disappear - * 9068 Missing pulseaudio in Flatpak image - * 9070 Fix History Manager search - * 9074 Proxy comobobox in accounts/connections doesn't get update after ManageProxies - * 9094 problem receiving file - * 9101 Notification never autohides in gnome + * #7879 Server name is rejected for group chat bookmarks + * #8964 setup.py install misses some files if used with "--skip-build" + * #9017 Password was sometimes stored in plaintext + * #9022 Dont show error when receiving invalid avatars + * #9031 Windows: Always hide roster window on X + * #9038 No License in About dialog + * #9039 Encode filenames before sending + * #9044 Catch invalid IQ stanzas and log them + * #9049 XMPP logo in "Add New Contact" window instead Gajim logo + * #9050 Mark some strings as translatable + * #9054 Error on file send completion + * #9055 Removing a bookmark causes error + * #9057 Avatar is deleted when updating vCard + * #9065 Account label isn't change in tooltip of notification area icon + * #9066 Placeholder text does't disappear + * #9068 Missing pulseaudio in Flatpak image + * #9070 Fix History Manager search + * #9074 Proxy comobobox in accounts/connections doesn't get update after ManageProxies + * #9094 problem receiving file + * #9101 Notification never autohides in gnome * Correctly reload Plugins * Save history export with utf8 encoding ===================================== data/org.gajim.Gajim.appdata.xml.in ===================================== @@ -38,11 +38,6 @@ <li>Even more features via plugins</li> </ul> </description> - <categories> - <category>GTK</category> - <category>InstantMessaging</category> - <category>Network</category> - </categories> <screenshots> <screenshot type="default"> <image>https://gajim.org/img/screenshots/single-window-mode.png</image> ===================================== gajim/common/connection_handlers_events.py ===================================== @@ -325,7 +325,9 @@ class NotificationEvent(nec.NetworkIncomingEvent): sound = msg_obj.gc_control.highlighting_for_message( msg_obj.msgtxt, msg_obj.properties.timestamp)[1] - if msg_obj.properties.muc_nickname != msg_obj.gc_control.nick: + nick = msg_obj.properties.muc_nickname + + if nick != msg_obj.gc_control.nick: self.do_sound = True if sound == 'received': self.sound_event = 'muc_message_received' @@ -364,6 +366,9 @@ class NotificationEvent(nec.NetworkIncomingEvent): if app.config.get('notification_preview_message'): self.popup_text = msg_obj.msgtxt + if self.popup_text and (self.popup_text.startswith('/me ') or + self.popup_text.startswith('/me\n')): + self.popup_text = '* ' + nick + self.popup_text[3:] type_events = ['printed_marked_gc_msg', 'printed_gc_msg'] count = len(app.events.get_events(self.account, self.jid, type_events)) @@ -373,7 +378,7 @@ class NotificationEvent(nec.NetworkIncomingEvent): self.popup_title = i18n.ngettext( 'New message from %(nickname)s', '%(n_msgs)i unread messages in %(groupchat_name)s', - count) % {'nickname': msg_obj.properties.muc_nickname, + count) % {'nickname': nick, 'n_msgs': count, 'groupchat_name': contact.get_shown_name()} ===================================== gajim/data/gui/add_new_contact_window.ui ===================================== @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?> - + <interface> - <requires lib="gtk+" version="3.20"/> + <requires lib="gtk+" version="3.22"/> <object class="GtkListStore" id="account_liststore"> <columns>  @@ -45,8 +45,8 @@ <property name="width_request">400</property> <property name="visible">True</property> <property name="can_focus">False</property> - <property name="margin_left">18</property> - <property name="margin_right">18</property> + <property name="margin_start">18</property> + <property name="margin_end">18</property> <property name="margin_bottom">18</property> <property name="orientation">vertical</property> <property name="spacing">6</property> @@ -450,12 +450,12 @@ to add a contact from this protocol.</property> <property name="layout_style">end</property> <child> <object class="GtkButton" id="cancel_button"> - <property name="label">gtk-cancel</property> + <property name="label">_Cancel</property> <property name="visible">True</property> <property name="can_focus">True</property> <property name="can_default">True</property> <property name="receives_default">False</property> - <property name="use_stock">True</property> + <property name="use_underline">True</property> <signal name="clicked" handler="on_cancel_button_clicked" swapped="no"/> </object> <packing> @@ -466,12 +466,12 @@ to add a contact from this protocol.</property> </child> <child> <object class="GtkButton" id="add_button"> - <property name="label">gtk-add</property> + <property name="label">_Add</property> <property name="visible">True</property> <property name="can_focus">True</property> <property name="can_default">True</property> <property name="receives_default">False</property> - <property name="use_stock">True</property> + <property name="use_underline">True</property> <signal name="clicked" handler="on_add_button_clicked" swapped="no"/> <style> <class name="suggested-action"/> ===================================== gajim/data/gui/contact_context_menu.ui ===================================== @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?> - + <interface> - <requires lib="gtk+" version="3.12"/> + <requires lib="gtk+" version="3.22"/> <object class="GtkAccelGroup" id="accelgroup1"/> <object class="GtkMenu" id="contact_context_menu"> <property name="can_focus">False</property> ===================================== gajim/data/gui/filetransfers_send_file_dialog.ui ===================================== @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?> - + <interface> - <requires lib="gtk+" version="3.20"/> + <requires lib="gtk+" version="3.22"/> <object class="GtkGrid" id="send_file_grid"> <property name="visible">True</property> <property name="can_focus">False</property> ===================================== gajim/data/gui/preferences_window.ui ===================================== @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?> - + <interface> - <requires lib="gtk+" version="3.20"/> + <requires lib="gtk+" version="3.22"/> <object class="GtkAdjustment" id="adjustment_status_auto_away"> <property name="lower">1</property> <property name="upper">720</property> @@ -361,9 +361,6 @@ <child> <placeholder/> </child> - <child> - <placeholder/> - </child> </object> </child> <child type="label"> @@ -1690,13 +1687,18 @@ $T will be replaced by auto-not-available timeout.</property> <property name="layout_style">start</property> <child> <object class="GtkButton" id="new_msg_button"> - <property name="label">gtk-new</property> <property name="visible">True</property> <property name="can_focus">True</property> <property name="can_default">True</property> <property name="receives_default">False</property> - <property name="use_stock">True</property> <signal name="clicked" handler="on_new_msg_button_clicked" swapped="no"/> + <child> + <object class="GtkImage" id="status-message-add"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="icon_name">list-add-symbolic</property> + </object> + </child> </object> <packing> <property name="expand">False</property> @@ -1706,13 +1708,18 @@ $T will be replaced by auto-not-available timeout.</property> </child> <child> <object class="GtkButton" id="delete_msg_button"> - <property name="label">gtk-delete</property> <property name="visible">True</property> <property name="can_focus">True</property> <property name="can_default">True</property> <property name="receives_default">False</property> - <property name="use_stock">True</property> <signal name="clicked" handler="on_delete_msg_button_clicked" swapped="no"/> + <child> + <object class="GtkImage" id="status-message-remove"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="icon_name">list-remove-symbolic</property> + </object> + </child> </object> <packing> <property name="expand">False</property> ===================================== gajim/data/gui/roster_window.ui ===================================== @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?> - + <interface> - <requires lib="gtk+" version="3.12"/> + <requires lib="gtk+" version="3.22"/> <object class="GtkAccelGroup" id="accelgroup1"/> <object class="GtkListStore" id="status_liststore"> <columns> @@ -113,8 +113,8 @@ <property name="can_focus">True</property> <property name="no_show_all">True</property> <property name="editable">False</property> - <signal name="search-changed" handler="on_rfilter_entry_changed" swapped="no"/> <signal name="icon-press" handler="on_rfilter_entry_icon_press" swapped="no"/> + <signal name="search-changed" handler="on_rfilter_entry_changed" swapped="no"/> </object> <packing> <property name="expand">False</property> ===================================== gajim/data/gui/server_info.ui ===================================== @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?> - + <interface> - <requires lib="gtk+" version="3.20"/> + <requires lib="gtk+" version="3.22"/> <object class="GtkNotebook" id="server_info_notebook"> <property name="visible">True</property> <property name="can_focus">True</property> ===================================== gajim/data/gui/tooltip_roster_contact.ui ===================================== @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?> - + <interface> - <requires lib="gtk+" version="3.20"/> + <requires lib="gtk+" version="3.22"/> <object class="GtkGrid" id="tooltip_grid"> <property name="visible">True</property> <property name="can_focus">False</property> @@ -268,7 +268,7 @@ <property name="can_focus">False</property> <property name="halign">start</property> <property name="valign">start</property> - <property name="stock">gtk-missing-image</property> + <property name="icon_name">image-missing</property> </object> <packing> <property name="left_attach">0</property> ===================================== gajim/data/gui/xml_console.ui ===================================== @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?> - + <interface> - <requires lib="gtk+" version="3.20"/> + <requires lib="gtk+" version="3.22"/> <object class="GtkHeaderBar" id="headerbar"> <property name="visible">True</property> <property name="can_focus">False</property> @@ -19,7 +19,7 @@ <property name="visible">True</property> <property name="can_focus">True</property> <property name="receives_default">True</property> - <property name="margin_left">6</property> + <property name="margin_start">6</property> <signal name="toggled" handler="_on_search_toggled" swapped="no"/> <child> <object class="GtkImage"> @@ -120,7 +120,7 @@ <object class="GtkToolItem"> <property name="visible">True</property> <property name="can_focus">False</property> - <property name="margin_right">6</property> + <property name="margin_end">6</property> <child> <object class="GtkSearchEntry" id="search_entry"> <property name="visible">True</property> ===================================== gajim/gtk/account_wizard.py ===================================== @@ -31,6 +31,7 @@ from nbxmpp.util import is_error_result from gajim.common import app from gajim.common import configpaths from gajim.common import helpers +from gajim.common.nec import NetworkEvent from gajim.common.helpers import open_uri from gajim.common.helpers import validate_jid from gajim.common.helpers import get_proxy @@ -236,6 +237,8 @@ class AccountWizard(Assistant): client.subscribe('disconnected', self._on_disconnected) client.subscribe('connection-failed', self._on_connection_failed) + client.subscribe('stanza-sent', self._on_stanza_sent) + client.subscribe('stanza-received', self._on_stanza_received) return client def _disconnect(self): @@ -245,6 +248,18 @@ class AccountWizard(Assistant): self._client.disconnect() self._client = None + @staticmethod + def _on_stanza_sent(_client, _signal_name, stanza): + app.nec.push_incoming_event(NetworkEvent('stanza-sent', + account='AccountWizard', + stanza=stanza)) + + @staticmethod + def _on_stanza_received(_client, _signal_name, stanza): + app.nec.push_incoming_event(NetworkEvent('stanza-received', + account='AccountWizard', + stanza=stanza)) + def _test_credentials(self, ignore_all_errors=False): self._show_progress_page(_('Connecting...'), _('Connecting to server...')) @@ -424,9 +439,11 @@ class AccountWizard(Assistant): self._disconnect() def _on_register_error(self, result): - self._show_error_page(_('Error'), - _('Error'), - result.get_text()) + error_text = result.get_text() + if not error_text: + error_text = _('The server rejected the registration ' + 'without an error message') + self._show_error_page(_('Error'), _('Error'), error_text) register_data = result.get_data() if register_data is None: ===================================== gajim/gtk/xml_console.py ===================================== @@ -267,6 +267,7 @@ class XMLConsoleWindow(Gtk.ApplicationWindow, EventHelper): for account in accounts: label = app.get_account_label(account) combo_accounts.append((account, label)) + combo_accounts.append(('AccountWizard', 'Account Wizard')) return combo_accounts def _on_filter_options(self, *args): ===================================== gajim/plugins/pluginmanager.py ===================================== @@ -426,8 +426,6 @@ class PluginManager(metaclass=Singleton): # So just unregister the plugin handlers if con.handlers_registered: for handler in instance.handlers: - if len(handler) > 4: - handler = handler[:4] con.connection.unregister_handler(handler) def activate_plugin(self, plugin): View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/3a3e37680a6c629b2d592c5aa38ebf7… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/3a3e37680a6c629b2d592c5aa38ebf7… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Update ChangeLog
by Philipp Hörist 10 May '20

10 May '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 8fbdce21 by Daniel Brötzmann at 2020-05-10T13:36:00+02:00 Update ChangeLog - - - - - 1 changed file: - ChangeLog Changes: ===================================== ChangeLog ===================================== @@ -1,4 +1,101 @@ -Gajim 1.1.0 (TBA) +Gajim 1.2.0-beta1 / 1.1.99.1 (01 May 2020) + + New + + * Rewritten network code + * Support for WebSocket (RFC 7395) + * Improved proxy handling + * Group chat pages (invite, information, nickname, subject, etc.) + * Group chat creation window + * Updated account creation assistant + * Updated assistants for password changing and account removal + * Updated server info window (connection details) + * Updated theme manager + * Default avatars (XEP-0392) + * Paste images from clipboard + * Contrast and color improvements for both light and dark themes + * Removed 'Invisible' status + * Removed FuzzyClock feature + + Bug fixes + + * List of fixed issues https://dev.gajim.org/gajim/gajim/-/issues?scope=all&utf8=%E2%9C%93&state=c… + +Gajim 1.1.3-1 (15 January 2020) + + * Flatpak build update + +Gajim 1.1.3 (23 April 2019) + + New + + * Add a mobile phone indicator to the chat window + * Rework HTTPUpload dialog + * Add a "paste as quote" option to the message input + + Bug fixes + + * #8822 Fix memory leak when using spell checker + * #9514 Fix jingle filetransfers not working in some circumstances + * #9573 Dont leak DNS query when connecting over proxy + * #9578 Determine Windows version more reliably + * #9622 Fix an error while quitting Gajim + * #9633 Fix an error while sending a file + * #9637 Restore window size correctly on wayland + * #9660 GPG Agent setting is ignored + * #9645 Make zeroconf IPV6 compatible + * Improve dark theme colors + * Fix access to GnuPG keys + * Use UUID4 item ids for pubsub posts + * Dont send invalid show values + * Windows: Dont override format region settings + * Various smaller improvements + +Gajim 1.1.2 (15 January 2019) + + New + + * Remove support for XEP-0091 + + Bug fixes + + * #9322 Error when adding contact + * #9385 Ignore invalid bookmarks + * #9386 Discovery: Browsing nodes without identity + * #9393 Error when parsing invalid timestamps + * #9398 Error on jingle file transfer + +Gajim 1.1.1 (24 December 2018) + + Bug fixes + + * #8362 DBus: Incorrect unread message count + * #9427 Placeholder not cleared if pasting text into message input + * #9444 Determine the delay timestamp correctly when using mam:1 + * #9453 Fix opening links inside the group chat subject (MacOS/Windows) + * #9465 Allow the full range of possible nicknames in group chats + * #9067 Gajim crashes when receiving xhtml messages + * #9096 Error when clicking on a subscription notification + * #9446 Chatstate error in MUC conversation + * #9471 Conversation Textview: Error on key press + * #9472 Handle presences without from attr correctly + * #9473 Error when creating a new group chat + * #9491 Identify group chat subject changes correctly + * #9496 Error on MUC roster selection change + * Determine soundplayer correctly on unix systems + * In some circumstances plugins could not be deleted + * Show correct contact status on tabs + * Dont answer group chat receipt requests + * Fix receipts for private messages + * Pressing the back button in the Accounts window leads to an error + * Better handle not available keyring backends + * Dont show incorrect contact on private messages + * Join group chat menu is disabled when there are no bookmarks + * Error on start chat menu action + * Error when opening sign-in/out notification + * Copying text does not work with different keyboard layouts + +Gajim 1.1.0 (06 May 2018) New @@ -6,13 +103,13 @@ Gajim 1.1.0 (TBA) Bug fixes - * 9322 Error when adding contact - * 9385 Ignore invalid bookmarks - * 9386 Discovery: Browsing nodes without identity - * 9393 Error when parsing invalid timestamps - * 9398 Error on jingle file transfer + * #9322 Error when adding contact + * #9385 Ignore invalid bookmarks + * #9386 Discovery: Browsing nodes without identity + * #9393 Error when parsing invalid timestamps + * #9398 Error on jingle file transfer -Gajim 1.0.99.1 (07 October 2018) +Gajim 1.1.0-beta2 / 1.0.99.1 (13 October 2018) New @@ -27,19 +124,19 @@ Gajim 1.0.99.1 (07 October 2018) Bug fixes - * 9198 Creating new MUCs with captial letters is not possible - * 9210 Error when clicking on new message indicator - * 9280 Inviting users to a MUC causes error - * 9301 Error when opening service discovery window - * 9309 Error when clicking on a groupchat invite notification - * 9311 Error when requesting server info - * 9117 Windows UAC changes status not available - * 9324 No menus/dialogs on Win7 - * 9326 IPV6 Connection problem on Win10 - * 9334 Joining big MUCs takes very long - * 9339 Error caused by remote_control + * #9198 Creating new MUCs with captial letters is not possible + * #9210 Error when clicking on new message indicator + * #9280 Inviting users to a MUC causes error + * #9301 Error when opening service discovery window + * #9309 Error when clicking on a groupchat invite notification + * #9311 Error when requesting server info + * #9117 Windows UAC changes status not available + * #9324 No menus/dialogs on Win7 + * #9326 IPV6 Connection problem on Win10 + * #9334 Joining big MUCs takes very long + * #9339 Error caused by remote_control -Gajim 1.0.99 (19 August 2018) +Gajim 1.1.0-beta1 / 1.0.99 (19 August 2018) New @@ -60,16 +157,16 @@ Gajim 1.0.99 (19 August 2018) Bug fixes - * 8658 Translation doesnt work on Windows - * 8750 Increase time frame for duplicate search in MUCs - * 9138 Translation in Flatpak does not work - * 9140 Error when clicking on the notification of an incoming message - * 9159 Wrong form type when responding to a voice request - * 9069 Send cancel IQ if muc configuration is aborted - * 9167 Flatpak fails to determine locale settings - * 9171 Gajim requests vcard multiple times - * 9198 Creating new MUCs with capital letters is not possible - * 9211 Punycode and Unicode with Internationalized Domain Names + * #8658 Translation doesnt work on Windows + * #8750 Increase time frame for duplicate search in MUCs + * #9138 Translation in Flatpak does not work + * #9140 Error when clicking on the notification of an incoming message + * #9159 Wrong form type when responding to a voice request + * #9069 Send cancel IQ if muc configuration is aborted + * #9167 Flatpak fails to determine locale settings + * #9171 Gajim requests vcard multiple times + * #9198 Creating new MUCs with capital letters is not possible + * #9211 Punycode and Unicode with Internationalized Domain Names Other changes @@ -91,9 +188,9 @@ Gajim 1.0.3 (20 May 2018) Bugs fixed: - * 8296 Fix errors on roster updates after stream management resume - * 9106 Convert font weight from pango to css values - * 9124 Bring ChatControl to front when notification is clicked + * #8296 Fix errors on roster updates after stream management resume + * #9106 Convert font weight from pango to css values + * #9124 Bring ChatControl to front when notification is clicked * Set no-store hint on groupchat chatstates * Dont show OOB uri if message body is the same @@ -107,26 +204,26 @@ Gajim 1.0.2 (30 April 2018) Bugs fixed: - * 7879 Server name is rejected for group chat bookmarks - * 8964 setup.py install misses some files if used with "--skip-build" - * 9017 Password was sometimes stored in plaintext - * 9022 Dont show error when receiving invalid avatars - * 9031 Windows: Always hide roster window on X - * 9038 No License in About dialog - * 9039 Encode filenames before sending - * 9044 Catch invalid IQ stanzas and log them - * 9049 XMPP logo in "Add New Contact" window instead Gajim logo - * 9050 Mark some strings as translatable - * 9054 Error on file send completion - * 9055 Removing a bookmark causes error - * 9057 Avatar is deleted when updating vCard - * 9065 Account label isn't change in tooltip of notification area icon - * 9066 Placeholder text does't disappear - * 9068 Missing pulseaudio in Flatpak image - * 9070 Fix History Manager search - * 9074 Proxy comobobox in accounts/connections doesn't get update after ManageProxies - * 9094 problem receiving file - * 9101 Notification never autohides in gnome + * #7879 Server name is rejected for group chat bookmarks + * #8964 setup.py install misses some files if used with "--skip-build" + * #9017 Password was sometimes stored in plaintext + * #9022 Dont show error when receiving invalid avatars + * #9031 Windows: Always hide roster window on X + * #9038 No License in About dialog + * #9039 Encode filenames before sending + * #9044 Catch invalid IQ stanzas and log them + * #9049 XMPP logo in "Add New Contact" window instead Gajim logo + * #9050 Mark some strings as translatable + * #9054 Error on file send completion + * #9055 Removing a bookmark causes error + * #9057 Avatar is deleted when updating vCard + * #9065 Account label isn't change in tooltip of notification area icon + * #9066 Placeholder text does't disappear + * #9068 Missing pulseaudio in Flatpak image + * #9070 Fix History Manager search + * #9074 Proxy comobobox in accounts/connections doesn't get update after ManageProxies + * #9094 problem receiving file + * #9101 Notification never autohides in gnome * Correctly reload Plugins * Save history export with utf8 encoding View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/8fbdce21eecf6c23b60e2e00c2f6e30e… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/8fbdce21eecf6c23b60e2e00c2f6e30e… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][gajim_1.2] fix strings for translators
by Yann Leboulanger 09 May '20

09 May '20

Yann Leboulanger pushed to branch gajim_1.2 at gajim / gajim Commits: 3a3e3768 by Yann Leboulanger at 2020-05-09T23:22:39+02:00 fix strings for translators - - - - - 2 changed files: - gajim/groupchat_control.py - gajim/gui_interface.py Changes: ===================================== gajim/groupchat_control.py ===================================== @@ -828,7 +828,7 @@ class GroupchatControl(ChatControlBase): NewConfirmationDialog( _('Voice Request'), _('Voice Request'), - _('%s from %s requests voice') % ( + _('%(nick)s from %(room_name)s requests voice') % ( event.voice_request.nick, self.room_name), [DialogButton.make('Cancel'), DialogButton.make('Accept', ===================================== gajim/gui_interface.py ===================================== @@ -352,7 +352,7 @@ class Interface: jid = contact.jid NewConfirmationDialog( _('Subscription Removed'), - _('%s (%s) has removed subscription from you') % (name, jid), + _('%(name)s (%(jid)s) has removed subscription from you') % (name, jid), _('You will always see this contact as offline.\n' 'Do you want to remove them from your contact list?'), [DialogButton.make('Cancel', View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/3a3e37680a6c629b2d592c5aa38ebf7d… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/3a3e37680a6c629b2d592c5aa38ebf7d… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix strings for translators
by Yann Leboulanger 09 May '20

09 May '20

Yann Leboulanger pushed to branch master at gajim / gajim Commits: a7ae4778 by Yann Leboulanger at 2020-05-09T23:22:01+02:00 fix strings for translators - - - - - 2 changed files: - gajim/groupchat_control.py - gajim/gui_interface.py Changes: ===================================== gajim/groupchat_control.py ===================================== @@ -828,7 +828,7 @@ class GroupchatControl(ChatControlBase): NewConfirmationDialog( _('Voice Request'), _('Voice Request'), - _('%s from %s requests voice') % ( + _('%(nick)s from %(room_name)s requests voice') % ( event.voice_request.nick, self.room_name), [DialogButton.make('Cancel'), DialogButton.make('Accept', ===================================== gajim/gui_interface.py ===================================== @@ -352,7 +352,7 @@ class Interface: jid = contact.jid NewConfirmationDialog( _('Subscription Removed'), - _('%s (%s) has removed subscription from you') % (name, jid), + _('%(name)s (%(jid)s) has removed subscription from you') % (name, jid), _('You will always see this contact as offline.\n' 'Do you want to remove them from your contact list?'), [DialogButton.make('Cancel', View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/a7ae4778ed9f9717c5d44741c6004005… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/a7ae4778ed9f9717c5d44741c6004005… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] GUI: Replace deprecated properties + raise min version
by Philipp Hörist 07 May '20

07 May '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: b331da8a by André Apitzsch at 2020-05-07T20:23:11+02:00 GUI: Replace deprecated properties + raise min version - - - - - 8 changed files: - gajim/data/gui/add_new_contact_window.ui - gajim/data/gui/contact_context_menu.ui - gajim/data/gui/filetransfers_send_file_dialog.ui - gajim/data/gui/preferences_window.ui - gajim/data/gui/roster_window.ui - gajim/data/gui/server_info.ui - gajim/data/gui/tooltip_roster_contact.ui - gajim/data/gui/xml_console.ui Changes: ===================================== gajim/data/gui/add_new_contact_window.ui ===================================== @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?> - + <interface> - <requires lib="gtk+" version="3.20"/> + <requires lib="gtk+" version="3.22"/> <object class="GtkListStore" id="account_liststore"> <columns>  @@ -45,8 +45,8 @@ <property name="width_request">400</property> <property name="visible">True</property> <property name="can_focus">False</property> - <property name="margin_left">18</property> - <property name="margin_right">18</property> + <property name="margin_start">18</property> + <property name="margin_end">18</property> <property name="margin_bottom">18</property> <property name="orientation">vertical</property> <property name="spacing">6</property> @@ -450,12 +450,12 @@ to add a contact from this protocol.</property> <property name="layout_style">end</property> <child> <object class="GtkButton" id="cancel_button"> - <property name="label">gtk-cancel</property> + <property name="label">_Cancel</property> <property name="visible">True</property> <property name="can_focus">True</property> <property name="can_default">True</property> <property name="receives_default">False</property> - <property name="use_stock">True</property> + <property name="use_underline">True</property> <signal name="clicked" handler="on_cancel_button_clicked" swapped="no"/> </object> <packing> @@ -466,12 +466,12 @@ to add a contact from this protocol.</property> </child> <child> <object class="GtkButton" id="add_button"> - <property name="label">gtk-add</property> + <property name="label">_Add</property> <property name="visible">True</property> <property name="can_focus">True</property> <property name="can_default">True</property> <property name="receives_default">False</property> - <property name="use_stock">True</property> + <property name="use_underline">True</property> <signal name="clicked" handler="on_add_button_clicked" swapped="no"/> <style> <class name="suggested-action"/> ===================================== gajim/data/gui/contact_context_menu.ui ===================================== @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?> - + <interface> - <requires lib="gtk+" version="3.12"/> + <requires lib="gtk+" version="3.22"/> <object class="GtkAccelGroup" id="accelgroup1"/> <object class="GtkMenu" id="contact_context_menu"> <property name="can_focus">False</property> ===================================== gajim/data/gui/filetransfers_send_file_dialog.ui ===================================== @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?> - + <interface> - <requires lib="gtk+" version="3.20"/> + <requires lib="gtk+" version="3.22"/> <object class="GtkGrid" id="send_file_grid"> <property name="visible">True</property> <property name="can_focus">False</property> ===================================== gajim/data/gui/preferences_window.ui ===================================== @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?> - + <interface> - <requires lib="gtk+" version="3.20"/> + <requires lib="gtk+" version="3.22"/> <object class="GtkAdjustment" id="adjustment_status_auto_away"> <property name="lower">1</property> <property name="upper">720</property> @@ -361,9 +361,6 @@ <child> <placeholder/> </child> - <child> - <placeholder/> - </child> </object> </child> <child type="label"> @@ -1690,13 +1687,18 @@ $T will be replaced by auto-not-available timeout.</property> <property name="layout_style">start</property> <child> <object class="GtkButton" id="new_msg_button"> - <property name="label">gtk-new</property> <property name="visible">True</property> <property name="can_focus">True</property> <property name="can_default">True</property> <property name="receives_default">False</property> - <property name="use_stock">True</property> <signal name="clicked" handler="on_new_msg_button_clicked" swapped="no"/> + <child> + <object class="GtkImage" id="status-message-add"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="icon_name">list-add-symbolic</property> + </object> + </child> </object> <packing> <property name="expand">False</property> @@ -1706,13 +1708,18 @@ $T will be replaced by auto-not-available timeout.</property> </child> <child> <object class="GtkButton" id="delete_msg_button"> - <property name="label">gtk-delete</property> <property name="visible">True</property> <property name="can_focus">True</property> <property name="can_default">True</property> <property name="receives_default">False</property> - <property name="use_stock">True</property> <signal name="clicked" handler="on_delete_msg_button_clicked" swapped="no"/> + <child> + <object class="GtkImage" id="status-message-remove"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="icon_name">list-remove-symbolic</property> + </object> + </child> </object> <packing> <property name="expand">False</property> ===================================== gajim/data/gui/roster_window.ui ===================================== @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?> - + <interface> - <requires lib="gtk+" version="3.12"/> + <requires lib="gtk+" version="3.22"/> <object class="GtkAccelGroup" id="accelgroup1"/> <object class="GtkListStore" id="status_liststore"> <columns> @@ -113,8 +113,8 @@ <property name="can_focus">True</property> <property name="no_show_all">True</property> <property name="editable">False</property> - <signal name="search-changed" handler="on_rfilter_entry_changed" swapped="no"/> <signal name="icon-press" handler="on_rfilter_entry_icon_press" swapped="no"/> + <signal name="search-changed" handler="on_rfilter_entry_changed" swapped="no"/> </object> <packing> <property name="expand">False</property> ===================================== gajim/data/gui/server_info.ui ===================================== @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?> - + <interface> - <requires lib="gtk+" version="3.20"/> + <requires lib="gtk+" version="3.22"/> <object class="GtkNotebook" id="server_info_notebook"> <property name="visible">True</property> <property name="can_focus">True</property> ===================================== gajim/data/gui/tooltip_roster_contact.ui ===================================== @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?> - + <interface> - <requires lib="gtk+" version="3.20"/> + <requires lib="gtk+" version="3.22"/> <object class="GtkGrid" id="tooltip_grid"> <property name="visible">True</property> <property name="can_focus">False</property> @@ -268,7 +268,7 @@ <property name="can_focus">False</property> <property name="halign">start</property> <property name="valign">start</property> - <property name="stock">gtk-missing-image</property> + <property name="icon_name">image-missing</property> </object> <packing> <property name="left_attach">0</property> ===================================== gajim/data/gui/xml_console.ui ===================================== @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?> - + <interface> - <requires lib="gtk+" version="3.20"/> + <requires lib="gtk+" version="3.22"/> <object class="GtkHeaderBar" id="headerbar"> <property name="visible">True</property> <property name="can_focus">False</property> @@ -19,7 +19,7 @@ <property name="visible">True</property> <property name="can_focus">True</property> <property name="receives_default">True</property> - <property name="margin_left">6</property> + <property name="margin_start">6</property> <signal name="toggled" handler="_on_search_toggled" swapped="no"/> <child> <object class="GtkImage"> @@ -120,7 +120,7 @@ <object class="GtkToolItem"> <property name="visible">True</property> <property name="can_focus">False</property> - <property name="margin_right">6</property> + <property name="margin_end">6</property> <child> <object class="GtkSearchEntry" id="search_entry"> <property name="visible">True</property> View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/b331da8ad1c7b1702b3fc6be81b2236a… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/b331da8ad1c7b1702b3fc6be81b2236a… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/python-nbxmpp][master] Fix example client
by Philipp Hörist 07 May '20

07 May '20

Philipp Hörist pushed to branch master at gajim / python-nbxmpp Commits: 3eced77c by lovetox at 2020-05-07T17:53:55+02:00 Fix example client - - - - - 1 changed file: - nbxmpp/examples/client.py Changes: ===================================== nbxmpp/examples/client.py ===================================== @@ -15,6 +15,7 @@ import nbxmpp from nbxmpp.protocol import JID from nbxmpp.client import Client from nbxmpp.structs import ProxyData +from nbxmpp.structs import StanzaHandler from nbxmpp.addresses import ServerAddress from nbxmpp.const import ConnectionType from nbxmpp.const import ConnectionProtocol @@ -108,7 +109,7 @@ class TestClient(Gtk.Window): self._client.subscribe('stanza-sent', self._on_stanza_sent) self._client.subscribe('stanza-received', self._on_stanza_received) - self._client.register_handler('message', self._on_message) + self._client.register_handler(StanzaHandler('message', self._on_message)) @property def password(self): View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/3eced77ce4d04d15109f98f2… -- View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/3eced77ce4d04d15109f98f2… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] AccountWizard: Add fallback error message
by Philipp Hörist 06 May '20

06 May '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 118be135 by lovetox at 2020-05-06T20:23:31+02:00 AccountWizard: Add fallback error message - - - - - 1 changed file: - gajim/gtk/account_wizard.py Changes: ===================================== gajim/gtk/account_wizard.py ===================================== @@ -439,9 +439,11 @@ class AccountWizard(Assistant): self._disconnect() def _on_register_error(self, result): - self._show_error_page(_('Error'), - _('Error'), - result.get_text()) + error_text = result.get_text() + if not error_text: + error_text = _('The server rejected the registration ' + 'without an error message') + self._show_error_page(_('Error'), _('Error'), error_text) register_data = result.get_data() if register_data is None: View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/118be135cfbfa2c6f3a598b479954ba6… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/118be135cfbfa2c6f3a598b479954ba6… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] XMLConsole: Show stanza generated by the AccountWizard
by Philipp Hörist 06 May '20

06 May '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 507a3cf1 by lovetox at 2020-05-06T17:42:56+02:00 XMLConsole: Show stanza generated by the AccountWizard - - - - - 2 changed files: - gajim/gtk/account_wizard.py - gajim/gtk/xml_console.py Changes: ===================================== gajim/gtk/account_wizard.py ===================================== @@ -31,6 +31,7 @@ from nbxmpp.util import is_error_result from gajim.common import app from gajim.common import configpaths from gajim.common import helpers +from gajim.common.nec import NetworkEvent from gajim.common.helpers import open_uri from gajim.common.helpers import validate_jid from gajim.common.helpers import get_proxy @@ -236,6 +237,8 @@ class AccountWizard(Assistant): client.subscribe('disconnected', self._on_disconnected) client.subscribe('connection-failed', self._on_connection_failed) + client.subscribe('stanza-sent', self._on_stanza_sent) + client.subscribe('stanza-received', self._on_stanza_received) return client def _disconnect(self): @@ -245,6 +248,18 @@ class AccountWizard(Assistant): self._client.disconnect() self._client = None + @staticmethod + def _on_stanza_sent(_client, _signal_name, stanza): + app.nec.push_incoming_event(NetworkEvent('stanza-sent', + account='AccountWizard', + stanza=stanza)) + + @staticmethod + def _on_stanza_received(_client, _signal_name, stanza): + app.nec.push_incoming_event(NetworkEvent('stanza-received', + account='AccountWizard', + stanza=stanza)) + def _test_credentials(self, ignore_all_errors=False): self._show_progress_page(_('Connecting...'), _('Connecting to server...')) ===================================== gajim/gtk/xml_console.py ===================================== @@ -267,6 +267,7 @@ class XMLConsoleWindow(Gtk.ApplicationWindow, EventHelper): for account in accounts: label = app.get_account_label(account) combo_accounts.append((account, label)) + combo_accounts.append(('AccountWizard', 'Account Wizard')) return combo_accounts def _on_filter_options(self, *args): View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/507a3cf11a04b37c596c80b70e7a79d0… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/507a3cf11a04b37c596c80b70e7a79d0… You're receiving this email because of your account on dev.gajim.org.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits