Commits

commits@gajim.org

17632 discussions

[Git][gajim/gajim][mainwindow] Improve conversation scrolling and jump to end button
by Daniel Brötzmann (＠wurstsalat) 04 Jul '21

04 Jul '21

Daniel Brötzmann pushed to branch mainwindow at gajim / gajim Commits: 6276f2cd by wurstsalat at 2021-07-04T18:22:22+02:00 Improve conversation scrolling and jump to end button - - - - - 5 changed files: - gajim/data/gui/chat_control.ui - gajim/data/gui/groupchat_control.ui - gajim/gtk/controls/base.py - + gajim/gtk/conversation/jump_to_end_button.py - gajim/gtk/conversation/scrolled.py Changes: ===================================== gajim/data/gui/chat_control.ui ===================================== @@ -1231,26 +1231,4 @@ audio-volume-high-symbolic</property> </packing> </child> </object> - <object class="GtkButton" id="jump_to_end_button"> - <property name="can-focus">True</property> - <property name="receives-default">False</property> - <property name="no-show-all">True</property> - <property name="halign">end</property> - <property name="valign">end</property> - <property name="margin-end">6</property> - <property name="margin-bottom">12</property> - <signal name="clicked" handler="_on_jump_to_end" swapped="no"/> - <child> - <object class="GtkImage"> - <property name="visible">True</property> - <property name="can-focus">False</property> - <property name="margin-start">4</property> - <property name="margin-end">4</property> - <property name="icon-name">go-bottom-symbolic</property> - </object> - </child> - <style> - <class name="circular"/> - </style> - </object> </interface> ===================================== gajim/data/gui/groupchat_control.ui ===================================== @@ -2302,26 +2302,4 @@ </packing> </child> </object> - <object class="GtkButton" id="jump_to_end_button"> - <property name="can-focus">True</property> - <property name="receives-default">False</property> - <property name="no-show-all">True</property> - <property name="halign">end</property> - <property name="valign">end</property> - <property name="margin-end">6</property> - <property name="margin-bottom">12</property> - <signal name="clicked" handler="_on_jump_to_end" swapped="no"/> - <child> - <object class="GtkImage"> - <property name="visible">True</property> - <property name="can-focus">False</property> - <property name="margin-start">4</property> - <property name="margin-end">4</property> - <property name="icon-name">go-bottom-symbolic</property> - </object> - </child> - <style> - <class name="circular"/> - </style> - </object> </interface> ===================================== gajim/gtk/controls/base.py ===================================== @@ -50,6 +50,7 @@ from gajim.gui.conversation.view import ConversationView from gajim.gui.conversation.scrolled import ScrolledView +from gajim.gui.conversation.jump_to_end_button import JumpToEndButton from gajim.gui.dialogs import DialogButton from gajim.gui.dialogs import ConfirmationDialog from gajim.gui.dialogs import PastePreviewDialog @@ -171,7 +172,10 @@ def __init__(self, widget_name, account, jid): self._scrolled_view.set_focus_vadjustment(Gtk.Adjustment()) self.xml.conv_view_overlay.add(self._scrolled_view) - self.xml.conv_view_overlay.add_overlay(self.xml.jump_to_end_button) + + self._jump_to_end_button = JumpToEndButton() + self._jump_to_end_button.connect('clicked', self._on_jump_to_end) + self.xml.conv_view_overlay.add_overlay(self._jump_to_end_button) self._scrolled_view.connect('autoscroll-changed', self._on_autoscroll_changed) @@ -912,10 +916,11 @@ def _on_message_textview_key_press_event(self, textview, event): return False def _on_autoscroll_changed(self, _widget, autoscroll): - self.xml.jump_to_end_button.set_visible(not autoscroll) + self._jump_to_end_button.toggle(not autoscroll) def _on_jump_to_end(self, _button): self.scroll_to_end(force=True) + self._jump_to_end_button.reset_unread_count() def _on_drag_data_received(self, widget, context, x, y, selection, target_type, timestamp): @@ -1085,16 +1090,22 @@ def add_message(self, if additional_data is None: additional_data = AdditionalDataDict() - self.conversation_view.add_message( - text, - kind, - name, - tim, - display_marking=displaymarking, - message_id=message_id, - correct_id=correct_id, - log_line_id=msg_log_id, - additional_data=additional_data) + if self._scrolled_view.get_lower_complete(): + self.conversation_view.add_message( + text, + kind, + name, + tim, + display_marking=displaymarking, + message_id=message_id, + correct_id=correct_id, + log_line_id=msg_log_id, + additional_data=additional_data) + + if not self._scrolled_view.get_autoscroll() and kind != 'outgoing': + self._jump_to_end_button.add_unread_count() + else: + self._jump_to_end_button.add_unread_count() if message_id: if self._type.is_groupchat: @@ -1268,13 +1279,10 @@ def set_control_active(self, state): self.contact, Chatstate.INACTIVE) def scroll_to_end(self, force=False): - if self._scrolled_view.get_lower_complete(): - self.conversation_view.scroll_to_end(force) - else: - # Clear view and reload conversation - self.conversation_view.clear() - self._scrolled_view.reset() - self.conversation_view.scroll_to_end(force) + # Clear view and reload conversation + self.conversation_view.clear() + self._scrolled_view.reset() + self.conversation_view.scroll_to_end(force) def scroll_to_message(self, log_line_id, timestamp): row = self.conversation_view.get_row_by_log_line_id(log_line_id) @@ -1328,8 +1336,10 @@ def fetch_n_lines_history(self, _scrolled, before, n_lines): return self.add_messages(messages) - if self.conversation_view.reduce_message_count(not before): - self._scrolled_view.set_history_complete(not before, False) + + if self._scrolled_view.get_autoscroll(): + if self.conversation_view.reduce_message_count(before): + self._scrolled_view.set_history_complete(before, False) self.conversation_view.unlock() ===================================== gajim/gtk/conversation/jump_to_end_button.py ===================================== @@ -0,0 +1,81 @@ +# This file is part of Gajim. +# +# Gajim is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published +# by the Free Software Foundation; version 3 only. +# +# Gajim is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with Gajim. If not, see <http://www.gnu.org/licenses/>. + +from gi.repository import GObject +from gi.repository import Gtk + + +class JumpToEndButton(Gtk.Overlay): + + __gsignals__ = { + 'clicked': ( + GObject.SignalFlags.RUN_LAST, + None, + ()), + } + + def __init__(self): + Gtk.Overlay.__init__(self) + + self.set_halign(Gtk.Align.END) + self.set_valign(Gtk.Align.END) + self.set_margin_end(6) + self.set_margin_bottom(12) + + icon = Gtk.Image.new_from_icon_name( + 'go-bottom-symbolic', Gtk.IconSize.BUTTON) + icon.set_margin_start(4) + icon.set_margin_end(4) + + button = Gtk.Button() + button.set_margin_top(6) + button.set_margin_end(6) + button.get_style_context().add_class('circular') + button.add(icon) + button.connect('clicked', self._on_jump_clicked) + self.add(button) + + self._unread_label = Gtk.Label() + self._unread_label.get_style_context().add_class( + 'unread-counter') + self._unread_label.set_no_show_all(True) + self._unread_label.set_halign(Gtk.Align.END) + self._unread_label.set_valign(Gtk.Align.START) + self.add_overlay(self._unread_label) + + self.show_all() + + self._count = 0 + + def _on_jump_clicked(self, _button): + self.emit('clicked') + + def toggle(self, visible): + if visible: + self.show_all() + else: + self.hide() + self.reset_unread_count() + + def reset_unread_count(self): + self._count = 0 + self._unread_label.hide() + + def add_unread_count(self): + self._count += 1 + if self._count > 0: + self._unread_label.set_text(str(self._count)) + self._unread_label.show() + else: + self._unread_label.hide() ===================================== gajim/gtk/conversation/scrolled.py ===================================== @@ -131,7 +131,7 @@ def _on_adj_value_changed(self, adj, *args): self._request_history_at_upper = None - distance = adj.get_page_size() + distance = adj.get_page_size() * 2 if adj.get_value() < distance: # Load messages when we are near the top if self._upper_complete: View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/6276f2cd11691f078b30930bebabd909… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/6276f2cd11691f078b30930bebabd909… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Profile: Don’t fail when adding a note property
by Philipp Hörist (＠lovetox) 02 Jul '21

02 Jul '21

Philipp Hörist pushed to branch master at gajim / gajim Commits: d28358d1 by lovetox at 2021-07-02T22:27:54+02:00 Profile: Don’t fail when adding a note property Fixes #10598 - - - - - 1 changed file: - gajim/gtk/vcard_grid.py Changes: ===================================== gajim/gtk/vcard_grid.py ===================================== @@ -79,7 +79,7 @@ 'role': {'value': ''}, 'url': {'value': ''}, 'key': {'value': '', 'value_type': 'text'}, - 'note': {'value': '', 'value_type': 'text'}, + 'note': {'value': ''}, } View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/d28358d197ef10a3872dffa3b678156b… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/d28358d197ef10a3872dffa3b678156b… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] HTTPUpload: Raise FileError if path is not accessible
by Daniel Brötzmann (＠wurstsalat) 30 Jun '21

30 Jun '21

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 1f2131e8 by wurstsalat at 2021-06-30T16:06:03+02:00 HTTPUpload: Raise FileError if path is not accessible Fixes #10560 - - - - - 1 changed file: - gajim/common/modules/httpupload.py Changes: ===================================== gajim/common/modules/httpupload.py ===================================== @@ -88,7 +88,7 @@ def pass_disco(self, info): def make_transfer(self, path, encryption, contact, groupchat=False): if not path or not os.path.exists(path): - return None + raise FileError(_('Could not access file')) invalid_file = False stat = os.stat(path) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/1f2131e8d85bc63580e4b2a146683d02… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/1f2131e8d85bc63580e4b2a146683d02… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Servers: Remove blabber.im
by Daniel Brötzmann (＠wurstsalat) 26 Jun '21

26 Jun '21

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: c4d4b013 by wurstsalat at 2021-06-26T17:14:18+02:00 Servers: Remove blabber.im Service is gone - - - - - 1 changed file: - gajim/data/other/servers.json Changes: ===================================== gajim/data/other/servers.json ===================================== @@ -1,6 +1,5 @@ [ "0nl1ne.at", - "blabber.im", "creep.im", "deshalbfrei.org", "draugr.de", View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/c4d4b0134202b9fe3b3c11a28fa1be25… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/c4d4b0134202b9fe3b3c11a28fa1be25… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][mainwindow] Preview: Mute logging for netloc discovery
by Daniel Brötzmann (＠wurstsalat) 12 Jun '21

12 Jun '21

Daniel Brötzmann pushed to branch mainwindow at gajim / gajim Commits: 49655930 by wurstsalat at 2021-06-12T11:30:02+02:00 Preview: Mute logging for netloc discovery - - - - - 1 changed file: - gajim/common/preview.py Changes: ===================================== gajim/common/preview.py ===================================== @@ -167,7 +167,6 @@ def _accept_uri(urlparts, uri, additional_data): return True if not urlparts.netloc: - log.info('No netloc found in URL: %s', uri) return False # aesgcm View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/49655930ff2aeaca5e78d0938bd86a0c… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/49655930ff2aeaca5e78d0938bd86a0c… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Fix spell checking
by Daniel Brötzmann (＠wurstsalat) 10 Jun '21

10 Jun '21

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: b395ca61 by André Apitzsch at 2021-06-10T19:59:55+02:00 Fix spell checking Disable spell checking only if there is no text, so it doesn't crash on correction. - - - - - 1 changed file: - gajim/gtk/message_input.py Changes: ===================================== gajim/gtk/message_input.py ===================================== @@ -114,9 +114,10 @@ def _on_focus_in(self, _widget, _event): return False def _on_focus_out(self, _widget, _event): - self.toggle_speller(False) scrolled = self.get_parent() scrolled.get_style_context().remove_class('message-input-focus') + if not self.has_text(): + self.toggle_speller(False) return False def insert_text(self, text): View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/b395ca61083f3dc6e02237c86cc3187b… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/b395ca61083f3dc6e02237c86cc3187b… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][mainwindow] Preview: Consider public/private MUCs
by Daniel Brötzmann (＠wurstsalat) 08 Jun '21

08 Jun '21

Daniel Brötzmann pushed to branch mainwindow at gajim / gajim Commits: cc8d56cf by wurstsalat at 2021-06-08T19:38:03+02:00 Preview: Consider public/private MUCs - - - - - 3 changed files: - gajim/common/preview.py - gajim/gtk/conversation/rows/message.py - gajim/gtk/preferences.py Changes: ===================================== gajim/common/preview.py ===================================== @@ -212,7 +212,7 @@ def get_previewable(self, text, additional_data): return True - def create_preview(self, uri, widget): + def create_preview(self, uri, widget, context): if uri.startswith('geo:'): preview = Preview(uri, None, None, None, 96, widget) preview.update_widget() @@ -221,6 +221,12 @@ def create_preview(self, uri, widget): preview = self._process_web_uri(uri, widget) if not preview.orig_exists(): + if context is not None: + allow_in_public = app.settings.get('preview_anonymous_muc') + if context == 'public' and not allow_in_public: + preview.update_widget() + return + self.download_content(preview) elif not preview.thumb_exists(): ===================================== gajim/gtk/conversation/rows/message.py ===================================== @@ -22,6 +22,7 @@ from gajim.common import app from gajim.common.const import AvatarSize from gajim.common.const import TRUST_SYMBOL_DATA +from gajim.common.helpers import get_muc_context from gajim.common.helpers import reduce_chars_newlines from gajim.common.helpers import to_user_string from gajim.common.styling import process @@ -75,9 +76,12 @@ def __init__(self, is_previewable = app.interface.preview_manager.get_previewable( text, additional_data) if is_previewable: + context = None + if self._is_groupchat: + context = get_muc_context(self._contact.jid) self._message_widget = PreviewWidget(account) app.interface.preview_manager.create_preview( - text, self._message_widget) + text, self._message_widget, context) else: result = process(text) self._message_widget = MessageWidget(account) ===================================== gajim/gtk/preferences.py ===================================== @@ -504,6 +504,13 @@ def __init__(self, *args): desc=_('Maximum file size for preview generation'), props={'entries': sizes}), + Setting(SettingKind.SWITCH, + _('Preview in Public Group Chats'), + SettingType.CONFIG, + 'preview_anonymous_muc', + desc=_('Generate preview automatically in public ' + 'group chats (may disclose your data)')), + Setting(SettingKind.SWITCH, _('Preview all Image URLs'), SettingType.CONFIG, View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/cc8d56cf32e32da15623f9289ce734a2… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/cc8d56cf32e32da15623f9289ce734a2… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][mainwindow] Contacts: Add get_disco()
by Philipp Hörist (＠lovetox) 08 Jun '21

08 Jun '21

Philipp Hörist pushed to branch mainwindow at gajim / gajim Commits: a9d92037 by lovetox at 2021-06-08T18:16:13+02:00 Contacts: Add get_disco() - - - - - 1 changed file: - gajim/common/modules/contacts.py Changes: ===================================== gajim/common/modules/contacts.py ===================================== @@ -438,6 +438,9 @@ def get_user_nicknames(self): client = app.get_client(self._account) return client.get_module('MUC').get_joined_users(self._jid) + def get_disco(self, max_age=0): + return app.storage.cache.get_last_disco_info(self.jid, max_age=max_age) + class GroupchatParticipant(CommonContact): def __init__(self, logger, jid, account): View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/a9d920374220bbb93a4163d2291647cd… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/a9d920374220bbb93a4163d2291647cd… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Fix spell checking
by Daniel Brötzmann 07 Jun '21

07 Jun '21

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 303f36b9 by André Apitzsch at 2021-06-07T21:59:04+02:00 Fix spell checking Fixes #10558. - - - - - 1 changed file: - gajim/gtk/message_input.py Changes: ===================================== gajim/gtk/message_input.py ===================================== @@ -108,11 +108,13 @@ def _on_destroy(self, *args): Gdk.DragAction.DEFAULT) def _on_focus_in(self, _widget, _event): + self.toggle_speller(True) scrolled = self.get_parent() scrolled.get_style_context().add_class('message-input-focus') return False def _on_focus_out(self, _widget, _event): + self.toggle_speller(False) scrolled = self.get_parent() scrolled.get_style_context().remove_class('message-input-focus') return False View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/303f36b9afd39ed781b57a945dd7555e… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/303f36b9afd39ed781b57a945dd7555e… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][mainwindow] AudioWidget: Display minutes and seconds correctly
by Daniel Brötzmann 07 Jun '21

07 Jun '21

Daniel Brötzmann pushed to branch mainwindow at gajim / gajim Commits: f86fefe1 by wurstsalat at 2021-06-07T21:11:38+02:00 AudioWidget: Display minutes and seconds correctly - - - - - 1 changed file: - gajim/gtk/preview_audio.py Changes: ===================================== gajim/gtk/preview_audio.py ===================================== @@ -143,8 +143,8 @@ def _format_audio_timestamp(_widget, ns): minutes = seconds / 60 hours = minutes / 60 - i_seconds = int(seconds) - i_minutes = int(minutes) + i_seconds = int(seconds) % 60 + i_minutes = int(minutes) % 60 i_hours = int(hours) if i_hours > 0: View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/f86fefe1afdaae0eadbe612a3c5ee8bc… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/f86fefe1afdaae0eadbe612a3c5ee8bc… You're receiving this email because of your account on dev.gajim.org.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits