Commits

commits@gajim.org

17632 discussions

[Git][gajim/gajim][master] 5 commits: Observable: Remove unused code
by Philipp Hörist (＠lovetox) 06 Dec '21

06 Dec '21

Philipp Hörist pushed to branch master at gajim / gajim Commits: 54d38514 by lovetox at 2021-12-06T23:51:45+01:00 Observable: Remove unused code - - - - - 7c26d70f by lovetox at 2021-12-06T23:51:46+01:00 Observable: Add type annotations - - - - - 8f4e2de2 by lovetox at 2021-12-06T23:51:46+01:00 App: Add type annotations - - - - - 2925fee0 by lovetox at 2021-12-06T23:51:46+01:00 Remove unused code - - - - - 8d8bfc98 by lovetox at 2021-12-06T23:55:53+01:00 BaseModule: Add type annotations - - - - - 6 changed files: - gajim/common/app.py - gajim/common/helpers.py - gajim/common/modules/base.py - gajim/common/modules/muc.py - gajim/common/types.py - gajim/gui_interface.py Changes: ===================================== gajim/common/app.py ===================================== @@ -26,10 +26,10 @@ from __future__ import annotations -from typing import Any # pylint: disable=unused-import -from typing import Dict # pylint: disable=unused-import -from typing import List # pylint: disable=unused-import -from typing import Optional # pylint: disable=unused-import +from typing import Any +from typing import NamedTuple +from typing import Union +from typing import Optional from typing import cast import gc @@ -38,42 +38,37 @@ import logging import weakref import pprint -from collections import namedtuple from collections import defaultdict import nbxmpp from nbxmpp.idlequeue import IdleQueue from gi.repository import Gdk from gi.repository import GLib +from nbxmpp.protocol import JID import gajim +from gajim.common import types from gajim.common import config as c_config from gajim.common import configpaths from gajim.common import ged as ged_module from gajim.common.i18n import LANG from gajim.common.const import Display -from gajim.common.types import NetworkEventsControllerT # pylint: disable=unused-import -from gajim.common.types import InterfaceT # pylint: disable=unused-import -from gajim.common.types import ConnectionT # pylint: disable=unused-import -from gajim.common.types import LegacyContactsAPIT # pylint: disable=unused-import -from gajim.common.types import SettingsT # pylint: disable=unused-import -from gajim.common.types import CSSConfigT # pylint: disable=unused-import -interface = cast(InterfaceT, None) +interface = cast(types.InterfaceT, None) thread_interface = lambda *args: None # Interface to run a thread and then a callback config = c_config.Config() -settings = cast(SettingsT, None) +settings = cast(types.SettingsT, None) version = gajim.__version__ -connections = {} # type: Dict[str, ConnectionT] -avatar_cache = {} # type: Dict[str, Dict[str, Any]] -bob_cache = {} # type: Dict[str, bytes] +connections: dict[str, types.Client] = {} +avatar_cache: dict[str, dict[str, Any]] = {} +bob_cache: dict[str, bytes] = {} ipython_window = None app = None # Gtk.Application window = None # MainWindow ged = ged_module.GlobalEventsDispatcher() # Global Events Dispatcher -nec = cast(NetworkEventsControllerT, None) +nec = cast(types.NetworkEventsControllerT, None) plugin_manager = None # Plugins Manager class Storage: @@ -83,41 +78,32 @@ def __init__(self): storage = Storage() -css_config = cast(CSSConfigT, None) +css_config = cast(types.CSSConfigT, None) -transport_type = {} # type: Dict[str, str] - -contacts = cast(LegacyContactsAPIT, None) - -# tell if we are connected to the room or not -# {acct: {room_jid: True}} -gc_connected = {} # type: Dict[str, Dict[str, bool]] +transport_type: dict[str, str] = {} # dict of rooms that must be automatically configured # and for which we have a list of invities # {account: {room_jid: {'invities': []}}} -automatic_rooms = {} # type: Dict[str, Dict[str, Dict[str, List[str]]]] - - # dict of groups, holds if they are expanded or not -groups = {} # type: Dict[str, Dict[str, Dict[str, bool]]] +automatic_rooms: dict[str, dict[str, dict[str, list[str]]]] = {} # list of contacts that has just signed in -newly_added = {} # type: Dict[str, List[str]] +newly_added: dict[str, list[str]] = {} # list of contacts that has just signed out -to_be_removed = {} # type: Dict[str, List[str]] +to_be_removed: dict[str, list[str]] = {} notification = None # list of our nick names in each account -nicks = {} # type: Dict[str, str] +nicks: dict[str, str] = {} # should we block 'contact signed in' notifications for this account? # this is only for the first 30 seconds after we change our show # to something else than offline # can also contain account/transport_jid to block notifications for contacts # from this transport -block_signed_in_notifications = {} # type: Dict[str, bool] +block_signed_in_notifications: dict[str, bool] = {} proxy65_manager = None @@ -151,32 +137,39 @@ def __init__(self): 'AYATANA_APPINDICATOR': False, } -_tasks = defaultdict(list) # type: Dict[int, List[Any]] +_tasks: dict[int, list[Any]] = defaultdict(list) + + +class RecentGroupchat(NamedTuple): + room: str + server: str + nickname: str -def print_version(): + +def print_version() -> None: log('gajim').info('Gajim Version: %s', gajim.__version__) -def get_client(account): +def get_client(account: str) -> types.Client: return connections[account] -def is_installed(dependency): +def is_installed(dependency: str) -> bool: if dependency == 'ZEROCONF': # Alias for checking zeroconf libs return _dependencies['AVAHI'] or _dependencies['PYBONJOUR'] return _dependencies[dependency] -def is_flatpak(): +def is_flatpak() -> bool: return gajim.IS_FLATPAK -def is_portable(): +def is_portable() -> bool: return gajim.IS_PORTABLE -def is_display(display): +def is_display(display: Display) -> bool: # XWayland reports as Display X11, so try with env var is_wayland = os.environ.get('XDG_SESSION_TYPE') == 'wayland' if is_wayland and display == Display.WAYLAND: @@ -188,10 +181,12 @@ def is_display(display): return False return default.__class__.__name__ == display.value -def disable_dependency(dependency): + +def disable_dependency(dependency: str) -> None: _dependencies[dependency] = False -def detect_dependencies(): + +def detect_dependencies() -> None: import gi # ZEROCONF @@ -310,7 +305,8 @@ def detect_dependencies(): log('gajim').info('Used language: %s', LANG) -def detect_desktop_env(): + +def detect_desktop_env() -> Optional[str]: if sys.platform in ('win32', 'darwin'): return sys.platform @@ -325,12 +321,12 @@ def detect_desktop_env(): desktop_env = detect_desktop_env() -def get_server_from_jid(jid): +def get_server_from_jid(jid: str) -> str: pos = jid.find('@') + 1 # after @ return jid[pos:] -def get_room_and_nick_from_fjid(jid): +def get_room_and_nick_from_fjid(jid: str) -> list[str]: # fake jid is the jid for a contact in a room # gaim(a)conference.jabber.no/nick/nick-continued # return ('gaim(a)conference.jabber.no', 'nick/nick-continued') @@ -339,19 +335,22 @@ def get_room_and_nick_from_fjid(jid): l.append('') return l -def get_jid_without_resource(jid): + +def get_jid_without_resource(jid: str) -> str: return jid.split('/')[0] -def get_number_of_accounts(): +def get_number_of_accounts() -> int: """ Return the number of ALL accounts """ return len(connections.keys()) -def get_number_of_connected_accounts(accounts_list=None): + +def get_number_of_connected_accounts( + accounts_list: Optional[list[str]] = None) -> int: """ - Returns the number of CONNECTED accounts. Uou can optionally pass an + Returns the number of connected accounts. You can optionally pass an accounts_list and if you do those will be checked, else all will be checked """ connected_accounts = 0 @@ -364,18 +363,20 @@ def get_number_of_connected_accounts(accounts_list=None): connected_accounts = connected_accounts + 1 return connected_accounts -def get_available_clients(): - clients = [] + +def get_available_clients() -> list[types.Client]: + clients: list[types.Client] = [] for client in connections.values(): if client.state.is_available: clients.append(client) return clients -def get_connected_accounts(exclude_local=False): + +def get_connected_accounts(exclude_local: bool = False) -> list[str]: """ Returns a list of CONNECTED accounts """ - account_list = [] + account_list: list[str] = [] for account in connections: if account == 'Local' and exclude_local: continue @@ -383,7 +384,8 @@ def get_connected_accounts(exclude_local=False): account_list.append(account) return account_list -def get_accounts_sorted(): + +def get_accounts_sorted() -> list[str]: ''' Get all accounts alphabetically sorted with Local first ''' @@ -394,13 +396,16 @@ def get_accounts_sorted(): account_list.insert(0, 'Local') return account_list -def get_enabled_accounts_with_labels(exclude_local=True, connected_only=False, - private_storage_only=False): + +def get_enabled_accounts_with_labels( + exclude_local: bool = True, + connected_only: bool = False, + private_storage_only: bool = False) -> list[str]: """ Returns a list with [account, account_label] entries. Order by account_label """ - accounts = [] + accounts: list[str] = [] for acc in connections: if exclude_local and account_is_zeroconf(acc): continue @@ -414,42 +419,47 @@ def get_enabled_accounts_with_labels(exclude_local=True, connected_only=False, accounts.sort(key=lambda xs: str.lower(xs[1])) return accounts -def get_account_label(account): + +def get_account_label(account: str) -> str: return settings.get_account_setting(account, 'account_label') or account -def account_is_zeroconf(account): + +def account_is_zeroconf(account: str) -> bool: return connections[account].is_zeroconf -def account_supports_private_storage(account): + +def account_supports_private_storage(account: str) -> bool: # If Delimiter module is not available we can assume # Private Storage is not available return connections[account].get_module('Delimiter').available -def account_is_connected(account): + +def account_is_connected(account: str) -> bool: if account not in connections: return False return (connections[account].state.is_connected or connections[account].state.is_available) -def account_is_available(account): + +def account_is_available(account: str) -> bool: if account not in connections: return False return connections[account].state.is_available -def account_is_disconnected(account): + +def account_is_disconnected(account: str) -> bool: return not account_is_connected(account) -def zeroconf_is_connected(): + +def zeroconf_is_connected() -> bool: return account_is_connected(ZEROCONF_ACC_NAME) and \ settings.get_account_setting(ZEROCONF_ACC_NAME, 'is_zeroconf') -def in_groupchat(account, room_jid): - room_jid = str(room_jid) - if room_jid not in gc_connected[account]: - return False - return gc_connected[account][room_jid] -def get_transport_name_from_jid(jid, use_config_setting=True): +def get_transport_name_from_jid( + jid: str, + use_config_setting: bool = True) -> Optional[str]: + """ Returns 'gg', 'irc' etc @@ -483,13 +493,14 @@ def get_transport_name_from_jid(jid, use_config_setting=True): return 'facebook' return None -def jid_is_transport(jid): +def jid_is_transport(jid: str) -> bool: # if not '@' or '@' starts the jid then it is transport if jid.find('@') <= 0: return True return False -def get_jid_from_account(account_name): + +def get_jid_from_account(account_name: str) -> str: """ Return the jid we use in the given account """ @@ -498,12 +509,14 @@ def get_jid_from_account(account_name): jid = name + '@' + hostname return jid -def get_account_from_jid(jid): + +def get_account_from_jid(jid: str) -> Optional[str]: for account in settings.get_accounts(): if jid == get_jid_from_account(account): return account -def get_hostname_from_account(account_name, use_srv=False): + +def get_hostname_from_account(account_name: str, use_srv: bool = False) -> str: """ Returns hostname (if custom hostname is used, that is returned) """ @@ -513,33 +526,32 @@ def get_hostname_from_account(account_name, use_srv=False): return settings.get_account_setting(account_name, 'custom_host') return settings.get_account_setting(account_name, 'hostname') -def get_notification_image_prefix(jid): + +def get_notification_image_prefix(jid: str) -> str: """ Returns the prefix for the notification images """ transport_name = get_transport_name_from_jid(jid) - if transport_name in ('icq', 'facebook'): + if transport_name in ['icq', 'facebook']: prefix = transport_name else: prefix = 'jabber' return prefix -def get_recent_groupchats(account): +def get_recent_groupchats(account: str) -> list[RecentGroupchat]: recent_groupchats = settings.get_account_setting( account, 'recent_groupchats').split() - RecentGroupchat = namedtuple('RecentGroupchat', - ['room', 'server', 'nickname']) - - recent_list = [] + recent_list: list[RecentGroupchat] = [] for groupchat in recent_groupchats: jid = nbxmpp.JID.from_string(groupchat) recent = RecentGroupchat(jid.localpart, jid.domain, jid.resource) recent_list.append(recent) return recent_list -def add_recent_groupchat(account, room_jid, nickname): + +def add_recent_groupchat(account: str, room_jid: str, nickname: str) -> None: recent = settings.get_account_setting( account, 'recent_groupchats').split() full_jid = room_jid + '/' + nickname @@ -551,7 +563,8 @@ def add_recent_groupchat(account, room_jid, nickname): config_value = ' '.join(recent) settings.set_account_setting(account, 'recent_groupchats', config_value) -def get_priority(account, show): + +def get_priority(account: str, show: str) -> int: """ Return the priority an account must have """ @@ -569,23 +582,27 @@ def get_priority(account, show): prio = 127 return prio -def log(domain): + +def log(domain: str) -> logging.Logger: if domain != 'gajim': domain = 'gajim.%s' % domain return logging.getLogger(domain) -def prefers_app_menu(): + +def prefers_app_menu() -> bool: if sys.platform == 'darwin': return True if sys.platform == 'win32': return False return app.prefers_app_menu() -def load_css_config(): + +def load_css_config() -> None: global css_config from gajim.gui.css_config import CSSConfig css_config = CSSConfig() + def set_debug_mode(enable: bool) -> None: debug_folder = configpaths.get('DEBUG') debug_enabled = debug_folder / 'debug-enabled' @@ -595,11 +612,13 @@ def set_debug_mode(enable: bool) -> None: if debug_enabled.exists(): debug_enabled.unlink() + def get_debug_mode() -> bool: debug_folder = configpaths.get('DEBUG') debug_enabled = debug_folder / 'debug-enabled' return debug_enabled.exists() + def get_stored_bob_data(algo_hash: str) -> Optional[bytes]: try: return bob_cache[algo_hash] @@ -616,7 +635,7 @@ def register_task(self, task): _tasks[id(self)].append(task) -def remove_task(task, id_): +def remove_task(task, id_) -> None: try: _tasks[id_].remove(task) except Exception: @@ -626,7 +645,7 @@ def remove_task(task, id_): del _tasks[id_] -def cancel_tasks(obj): +def cancel_tasks(obj: Any) -> None: id_ = id(obj) if id_ not in _tasks: return @@ -636,9 +655,10 @@ def cancel_tasks(obj): task.cancel() -def check_finalize(obj): +def check_finalize(obj: Any) -> None: if 'GAJIM_LEAK' not in os.environ: return + name = obj.__class__.__name__ logger = logging.getLogger('gajim.leak') finalizer = weakref.finalize(obj, logger.info, f'{name} has been finalized') ===================================== gajim/common/helpers.py ===================================== @@ -25,8 +25,10 @@ # You should have received a copy of the GNU General Public License # along with Gajim. If not, see <http://www.gnu.org/licenses/>. -from typing import Any # pylint: disable=unused-import -from typing import Dict # pylint: disable=unused-import +from __future__ import annotations + +from typing import Any +from typing import Dict from typing import Optional from typing import List from typing import Tuple @@ -91,6 +93,7 @@ from gajim.common.regex import INVALID_XML_CHARS_REGEX from gajim.common.regex import STH_AT_STH_DOT_STH_REGEX from gajim.common.structs import URI +from gajim.common import types HAS_PYWIN32 = False if os.name == 'nt': @@ -1221,53 +1224,56 @@ def get_tls_error_phrase(tls_error: Gio.TlsCertificateFlags) -> str: class Observable: - def __init__(self, log_=None): + def __init__(self, log_: Optional[logging.Logger] = None): self._log = log_ - self._callbacks = defaultdict(lambda: defaultdict(list)) + self._callbacks: types.ObservableCbDict = defaultdict(list) - def disconnect_signals(self): - self._callbacks = defaultdict(lambda: defaultdict(list)) + def disconnect_signals(self) -> None: + self._callbacks = defaultdict(list) - def disconnect_all_from_obj(self, object_): - for qualifiers in self._callbacks.values(): - for handlers in qualifiers.values(): - for handler in list(handlers): - func = handler() - if func is None or func.__self__ is object_: - handlers.remove(handler) + def disconnect_all_from_obj(self, obj: Any) -> None: + for handlers in self._callbacks.values(): + for handler in list(handlers): + func = handler() + if func is None or func.__self__ is obj: + handlers.remove(handler) - def disconnect(self, *args): - self.disconnect_all_from_obj(*args) + def disconnect(self, obj: Any) -> None: + self.disconnect_all_from_obj(obj) - def connect_signal(self, signal_name, func, qualifiers=None): + def connect_signal(self, + signal_name: str, + func: types.AnyCallableT) -> None: if not inspect.ismethod(func): raise ValueError('Only bound methods allowed') weak_func = weakref.WeakMethod(func) - self._callbacks[signal_name][qualifiers].append(weak_func) + self._callbacks[signal_name].append(weak_func) - def connect(self, *args, **kwargs): - self.connect_signal(*args, **kwargs) + def connect(self, + signal_name: str, + func: types.AnyCallableT) -> None: + self.connect_signal(signal_name, func) - def multi_connect(self, signal_dict): + def multi_connect(self, signal_dict: dict[str, types.AnyCallableT]): for signal_name, func in signal_dict.items(): self.connect_signal(signal_name, func) - def notify(self, signal_name, *args, qualifiers=None, **kwargs): + def notify(self, signal_name: str, *args: Any, **kwargs: Any): signal_callbacks = self._callbacks.get(signal_name) - if signal_callbacks is None: + if not signal_callbacks: return if self._log is not None: self._log.info('Signal: %s', signal_name) - callbacks = signal_callbacks.get(qualifiers, []) - for func in list(callbacks): - if func() is None: - self._callbacks[signal_name][qualifiers].remove(func) + for weak_method in list(signal_callbacks): + func = weak_method() + if func is None: + self._callbacks[signal_name].remove(weak_method) continue - func()(self, signal_name, *args, **kwargs) + func(self, signal_name, *args, **kwargs) def write_file_async(path, data, callback, user_data=None): ===================================== gajim/common/modules/base.py ===================================== @@ -12,9 +12,10 @@ # You should have received a copy of the GNU General Public License # along with Gajim. If not, see <http://www.gnu.org/licenses/>. +from __future__ import annotations + from typing import Any -from typing import Dict -from typing import List +from typing import Optional import logging from functools import partial @@ -23,6 +24,7 @@ from nbxmpp.namespaces import Namespace from nbxmpp.structs import StanzaHandler +from gajim.common import types from gajim.common import app from gajim.common.nec import EventHelper from gajim.common.modules.util import LogAdapter @@ -31,18 +33,23 @@ class BaseModule(EventHelper): _nbxmpp_extends = '' - _nbxmpp_methods = [] # type: List[str] + _nbxmpp_methods: list[str] = [] + + def __init__(self, + con: types.Client, + *args: Any, + plugin: bool = False, + **kwargs: Any): - def __init__(self, con, *args, plugin=False, **kwargs): EventHelper.__init__(self) self._con = con - self._account = con.name + self._account = con.account self._log = self._set_logger(plugin) - self._nbxmpp_callbacks: Dict[str, Any] = {} - self._stored_publish = None # type: Callable - self.handlers: List[StanzaHandler] = [] + self._nbxmpp_callbacks: dict[str, Any] = {} + self._stored_publish: Optional[types.AnyCallableT] = None + self.handlers: list[StanzaHandler] = [] - def _set_logger(self, plugin): + def _set_logger(self, plugin: bool) -> LogAdapter: logger_name = 'gajim.c.m.%s' if plugin: logger_name = 'gajim.p.%s' @@ -50,7 +57,7 @@ def _set_logger(self, plugin): logger = logging.getLogger(logger_name) return LogAdapter(logger, {'account': self._account}) - def __getattr__(self, key): + def __getattr__(self, key: str) -> Any: if key not in self._nbxmpp_methods: raise AttributeError( "attribute '%s' is neither part of object '%s' " @@ -68,7 +75,7 @@ def __getattr__(self, key): return getattr(module, key) return partial(getattr(module, key), callback=callback) - def _nbxmpp(self, module_name=None): + def _nbxmpp(self, module_name: Optional[str] = None): if not app.account_is_connected(self._account): self._log.warning('Account not connected, can’t use nbxmpp method') return Mock() @@ -80,22 +87,22 @@ def _nbxmpp(self, module_name=None): def _register_callback(self, method, callback): self._nbxmpp_callbacks[method] = callback - def _register_pubsub_handler(self, callback): + def _register_pubsub_handler(self, callback: types.AnyCallableT): handler = StanzaHandler(name='message', callback=callback, ns=Namespace.PUBSUB_EVENT, priority=49) self.handlers.append(handler) - def send_stored_publish(self): + def send_stored_publish(self) -> None: if self._stored_publish is None: return self._log.info('Send stored publish') self._stored_publish() # pylint: disable=not-callable - def _get_contact(self, jid, groupchat=False): + def _get_contact(self, jid, groupchat: bool = False): return self._con.get_module('Contacts').get_contact( jid, groupchat=groupchat) - def cleanup(self): + def cleanup(self) -> None: self.unregister_events() ===================================== gajim/common/modules/muc.py ===================================== @@ -814,7 +814,8 @@ def _on_invite_or_decline(self, _con, _stanza, properties): self._log.info('Invite from: %s, to: %s', data.from_, data.muc) - if app.in_groupchat(self._account, data.muc): + contact = self._get_contact(data.muc, groupchat=True) + if contact.is_joined: # We are already in groupchat. Ignore invitation self._log.info('We are already in this room') raise nbxmpp.NodeProcessed ===================================== gajim/common/types.py ===================================== @@ -14,6 +14,7 @@ # Types for typechecking +from typing import Any from typing import Callable from typing import Dict from typing import List @@ -23,6 +24,7 @@ from typing import TYPE_CHECKING from pathlib import Path +import weakref from gi.repository import GdkPixbuf @@ -53,7 +55,6 @@ ConnectionT = Union['Client', 'ConnectionZeroconf'] ContactsT = Union['Contact', 'GC_Contact'] ContactT = Union['Contact'] -LegacyContactsAPIT = Union['LegacyContactsAPI'] CSSConfigT = Union['CSSConfig'] # PEP @@ -75,3 +76,6 @@ BookmarksDict = Dict[JID, BookmarkData] GdkPixbufType = Union[GdkPixbuf.Pixbuf, GdkPixbuf.PixbufAnimation] + +AnyCallableT = Callable[..., Any] +ObservableCbDict = dict[str, list[weakref.WeakMethod[AnyCallableT]]] ===================================== gajim/gui_interface.py ===================================== @@ -159,8 +159,6 @@ def __init__(self): 'infos': {}, 'disco': {} } - app.groups[acc] = {} - app.gc_connected[acc] = {} app.automatic_rooms[acc] = {} app.newly_added[acc] = [] app.to_be_removed[acc] = [] @@ -781,8 +779,6 @@ def enable_account(self, account: str) -> None: 'disco': {} } - app.groups[account] = {} - app.gc_connected[account] = {} app.automatic_rooms[account] = {} app.newly_added[account] = [] app.to_be_removed[account] = [] @@ -830,8 +826,6 @@ def disable_account(self, account: str) -> None: del self.instances[account] del app.nicks[account] del app.block_signed_in_notifications[account] - del app.groups[account] - del app.gc_connected[account] del app.automatic_rooms[account] del app.to_be_removed[account] del app.newly_added[account] View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/89558698af668d17da1889076a10a54… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/89558698af668d17da1889076a10a54… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: ChatPlaceholderBox: Add button for Start Chat
by Daniel Brötzmann (＠wurstsalat) 06 Dec '21

06 Dec '21

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 15d763e0 by wurstsalat at 2021-12-06T23:00:57+01:00 ChatPlaceholderBox: Add button for Start Chat - - - - - 89558698 by wurstsalat at 2021-12-06T23:22:02+01:00 ChatList: Add 'Mark as read' menu item - - - - - 5 changed files: - gajim/gtk/chat_list.py - gajim/gtk/chat_list_stack.py - gajim/gtk/chat_stack.py - gajim/gtk/main.py - gajim/gui_menu_builder.py Changes: ===================================== gajim/gtk/chat_list.py ===================================== @@ -90,9 +90,15 @@ def workspace_id(self) -> str: def get_unread_count(self) -> int: return sum([chats.unread_count for chats in self._chats.values()]) - def get_chat_unread_count(self, account: str, jid: JID) -> Optional[int]: + def get_chat_unread_count(self, + account: str, + jid: JID, + include_silent: bool = False + ) -> Optional[int]: chat = self._chats.get((account, jid)) if chat is not None: + if include_silent: + return chat.get_real_unread_count() return chat.unread_count return None @@ -656,6 +662,9 @@ def _on_chatstate_update(self, contact, _signal_name): def _on_nickname_update(self, _contact, _signal_name): self.update_name() + def get_real_unread_count(self) -> int: + return self._unread_count + @property def unread_count(self) -> int: if self.contact.is_groupchat and not self.contact.can_notify(): ===================================== gajim/gtk/chat_list_stack.py ===================================== @@ -81,6 +81,7 @@ def _add_actions(self): actions = [ ('toggle-chat-pinned', 'as', self._toggle_chat_pinned), ('move-chat-to-workspace', 'as', self._move_chat_to_workspace), + ('mark-as-read', 'as', self._mark_as_read), ] for action in actions: @@ -208,6 +209,10 @@ def _move_chat_to_workspace(self, _action, param): self.store_open_chats(current_chatlist.workspace_id) self.store_open_chats(new_workspace_id) + def _mark_as_read(self, _action, param): + _workspace_id, account, jid = param.unpack() + self.mark_as_read(account, JID.from_string(jid)) + def remove_chat(self, workspace_id: str, account: str, jid: JID) -> None: chat_list = self._chat_lists[workspace_id] type_ = chat_list.get_chat_type(account, jid) @@ -243,9 +248,14 @@ def get_total_unread_count(self) -> int: count += chat_list.get_unread_count() return count - def get_chat_unread_count(self, account: str, jid: JID) -> Optional[int]: + def get_chat_unread_count(self, + account: str, + jid: JID, + include_silent: bool = False + ) -> Optional[int]: for chat_list in self._chat_lists.values(): - count = chat_list.get_chat_unread_count(account, jid) + count = chat_list.get_chat_unread_count( + account, jid, include_silent) if count is not None: return count return None ===================================== gajim/gtk/chat_stack.py ===================================== @@ -24,6 +24,7 @@ from nbxmpp import JID +from gajim.common import app from gajim.common import ged from gajim.common.i18n import _ @@ -150,6 +151,10 @@ def __init__(self): image.get_style_context().add_class('dim-label') self.add(image) - label = Gtk.Label(label=_('Start a Chat')) - label.get_style_context().add_class('dim-label') - self.add(label) + button = Gtk.Button(label=_('Start Chatting…')) + button.set_halign(Gtk.Align.CENTER) + button.connect('clicked', self._on_start_chatting) + self.add(button) + + def _on_start_chatting(self, _button): + app.app.activate_action('start-chat', GLib.Variant('s', '')) ===================================== gajim/gtk/main.py ===================================== @@ -509,9 +509,14 @@ def get_total_unread_count(self) -> int: chat_list_stack = self._chat_page.get_chat_list_stack() return chat_list_stack.get_total_unread_count() - def get_chat_unread_count(self, account: str, jid: JID) -> int: + def get_chat_unread_count(self, + account: str, + jid: JID, + include_silent: bool = False + ) -> int: chat_list_stack = self._chat_page.get_chat_list_stack() - count = chat_list_stack.get_chat_unread_count(account, jid) + count = chat_list_stack.get_chat_unread_count( + account, jid, include_silent) return count or 0 def mark_as_read(self, account: str, jid: JID, ===================================== gajim/gui_menu_builder.py ===================================== @@ -521,6 +521,11 @@ def get_chat_list_row_menu(workspace_id: str, account: str, else: menu_items.append(('add-to-roster', _('Add to Contact List…'))) + unread_count = app.window.get_chat_unread_count( + account, jid, include_silent=True) + if unread_count is not None and unread_count > 0: + menu_items.append(('mark-as-read', _('Mark as read'))) + menu = Gio.Menu() for item in menu_items: if isinstance(item[1], str): View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/3d10db13f68bae934527169be566168… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/3d10db13f68bae934527169be566168… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] AccountSidebar: Try to separate accounts from workspaces
by Daniel Brötzmann (＠wurstsalat) 06 Dec '21

06 Dec '21

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 3d10db13 by wurstsalat at 2021-12-06T22:05:20+01:00 AccountSidebar: Try to separate accounts from workspaces - - - - - 3 changed files: - gajim/data/gui/main.ui - gajim/data/style/gajim.css - gajim/gtk/account_side_bar.py Changes: ===================================== gajim/data/gui/main.ui ===================================== @@ -22,7 +22,7 @@ <property name="can-focus">False</property> <property name="valign">end</property> <property name="orientation">vertical</property> - <property name="spacing">12</property> + <property name="spacing">6</property> <child> <object class="GtkSeparator"> <property name="visible">True</property> ===================================== gajim/data/style/gajim.css ===================================== @@ -280,9 +280,11 @@ .account-sidebar-item .account-identifier-bar { padding: 0 3px; margin: 3px 0; } +.account-box { + background-color: mix(@theme_base_color, @theme_fg_color, 0.15); +} .account-box > separator { background-color: darker(@theme_bg_color); - margin: 0px 12px 0px 12px; } /* Account Page */ ===================================== gajim/gtk/account_side_bar.py ===================================== @@ -121,7 +121,7 @@ def _on_avatar_update(self, _contact, _signal_name): def _update_image(self) -> None: surface = self._contact.get_avatar(AvatarSize.ACCOUNT_SIDE_BAR, self.get_scale_factor(), - style='round-corners') + style='circle') self.set_from_surface(surface) def _on_destroy(self, *args): View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/3d10db13f68bae934527169be5661681… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/3d10db13f68bae934527169be5661681… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: Roster: Remove all actions on destroy
by Daniel Brötzmann (＠wurstsalat) 06 Dec '21

06 Dec '21

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: feb5b792 by wurstsalat at 2021-12-06T21:37:07+01:00 Roster: Remove all actions on destroy - - - - - 636f2b86 by wurstsalat at 2021-12-06T21:45:23+01:00 Add check_finalize to some dialogs - - - - - 4 changed files: - gajim/gtk/account_page.py - gajim/gtk/add_contact.py - gajim/gtk/profile.py - gajim/gtk/roster.py Changes: ===================================== gajim/gtk/account_page.py ===================================== @@ -82,6 +82,10 @@ def __init__(self, account: str) -> None: self.update() self.show_all() + self.connect('destroy', self._on_destroy) + + def _on_destroy(self, *args): + app.check_finalize(self) def _on_edit_profile(self, _button): open_window('ProfileWindow', account=self._account) ===================================== gajim/gtk/add_contact.py ===================================== @@ -76,6 +76,10 @@ def __init__(self, self.connect('button-clicked', self._on_button_clicked) self.show_all() + self.connect('destroy', self._on_destroy) + + def _on_destroy(self, *args): + app.check_finalize(self) def _on_button_clicked(self, _assistant, button_name): page = self.get_current_page() ===================================== gajim/gtk/profile.py ===================================== @@ -117,6 +117,11 @@ def __init__(self, account, *args): self._ui.connect_signals(self) self.connect('key-press-event', self._on_key_press_event) + self.connect('destroy', self._on_destroy) + + def _on_destroy(self, *args): + app.check_finalize(self) + def _on_access_model_received(self, task): namespace = task.get_user_data() ===================================== gajim/gtk/roster.py ===================================== @@ -167,6 +167,7 @@ def _remove_actions(self): 'block-contact', 'remove-contact', 'show-offline', + 'sort-by-show', ] for action in actions: app.window.remove_action(f'{action}-{self._account}') View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/ab24173c3b07fb45c061f608eed03fa… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/ab24173c3b07fb45c061f608eed03fa… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: ConversationView: Remove reference to filter_func on destroy
by Daniel Brötzmann (＠wurstsalat) 06 Dec '21

06 Dec '21

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 5182407c by wurstsalat at 2021-12-06T20:28:18+01:00 ConversationView: Remove reference to filter_func on destroy - - - - - ab24173c by wurstsalat at 2021-12-06T21:17:26+01:00 ContactInfo: Simplify code - - - - - 2 changed files: - gajim/gtk/contact_info.py - gajim/gtk/conversation/view.py Changes: ===================================== gajim/gtk/contact_info.py ===================================== @@ -123,8 +123,6 @@ def __init__(self, account, contact, page=None): if contact.real_jid is not None: self._devices_grid = DevicesGrid(self._ui.devices_grid) self._query_devices() - self._update_timeout_id = GLib.timeout_add( - 100, self._update_timer) self._ui.contact_jid_label.set_text( str(contact.real_jid.bare)) @@ -144,9 +142,7 @@ def __init__(self, account, contact, page=None): if contact.is_in_roster: self._devices_grid = DevicesGrid(self._ui.devices_grid) self._query_devices() - self._update_timeout_id = GLib.timeout_add(100, self._update_timer) - if contact.is_in_roster: note = self._client.get_module('Annotations').get_note(contact.jid) if note is not None: self._ui.textview_annotation.get_buffer().set_text(note.data) @@ -234,6 +230,8 @@ def _load_avatar(self): self._ui.header_image.set_from_surface(surface_2) def _query_devices(self): + self._update_timeout_id = GLib.timeout_add(100, self._update_timer) + if self.contact.is_pm_contact: self._query_device(self.contact) else: ===================================== gajim/gtk/conversation/view.py ===================================== @@ -123,6 +123,11 @@ def __init__(self, account, contact): self._scroll_hint_row = ScrollHintRow(self._account) self.add(self._scroll_hint_row) + self.connect('destroy', self._on_destroy) + + def _on_destroy(self, *args): + self.set_filter_func(None) + app.check_finalize(self) def lock(self) -> None: self.locked = True View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/46f7b5eaf79a62da3aeccd55ab3b385… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/46f7b5eaf79a62da3aeccd55ab3b385… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] ContactInfo: Device page improvements
by Daniel Brötzmann (＠wurstsalat) 06 Dec '21

06 Dec '21

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 46f7b5ea by wurstsalat at 2021-12-06T20:11:47+01:00 ContactInfo: Device page improvements Fixes #10695 - - - - - 1 changed file: - gajim/gtk/contact_info.py Changes: ===================================== gajim/gtk/contact_info.py ===================================== @@ -88,7 +88,10 @@ def __init__(self, account, contact, page=None): side_bar_switcher.hide_row('settings') side_bar_switcher.hide_row('groups') side_bar_switcher.hide_row('notes') - if not contact.is_pm_contact: + if contact.is_pm_contact: + if contact.real_jid is None: + side_bar_switcher.hide_row('devices') + else: side_bar_switcher.hide_row('devices') if page is not None: @@ -110,8 +113,19 @@ def __init__(self, account, contact, page=None): self._ui.contact_jid_label.set_text(str(contact.jid)) self._ui.contact_jid_label.set_tooltip_text(str(contact.jid)) + self._update_timeout_id = None + self._time = 0 + self._devices = {} + self._received_devices = set() + self._received_times = set() + if contact.is_pm_contact: if contact.real_jid is not None: + self._devices_grid = DevicesGrid(self._ui.devices_grid) + self._query_devices() + self._update_timeout_id = GLib.timeout_add( + 100, self._update_timer) + self._ui.contact_jid_label.set_text( str(contact.real_jid.bare)) self._ui.contact_jid_label.set_tooltip_text( @@ -127,15 +141,9 @@ def __init__(self, account, contact, page=None): jid=contact.jid, callback=self._on_vcard_received) - self._update_timeout_id = None if contact.is_in_roster: - self._devices = {} - self._received_devices = set() - self._received_times = set() self._devices_grid = DevicesGrid(self._ui.devices_grid) self._query_devices() - - self._time = 0 self._update_timeout_id = GLib.timeout_add(100, self._update_timer) if contact.is_in_roster: @@ -239,12 +247,16 @@ def _query_device(self, contact): } self._rebuild_devices_grid() + jid = contact.jid + if contact.is_pm_contact and contact.real_jid is not None: + jid = contact.real_jid + task = self._client.get_module('SoftwareVersion').request_software_version( - contact.jid, callback=self._set_os_info, user_data=contact) + jid, callback=self._set_os_info, user_data=contact) self._tasks.append(task) task = self._client.get_module('EntityTime').request_entity_time( - contact.jid, callback=self._set_entity_time, user_data=contact) + jid, callback=self._set_entity_time, user_data=contact) self._tasks.append(task) def _set_os_info(self, task): View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/46f7b5eaf79a62da3aeccd55ab3b385e… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/46f7b5eaf79a62da3aeccd55ab3b385e… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Use lazy logging for check_finalize
by Daniel Brötzmann (＠wurstsalat) 06 Dec '21

06 Dec '21

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 09359428 by wurstsalat at 2021-12-06T19:27:17+01:00 Use lazy logging for check_finalize - - - - - 1 changed file: - gajim/common/app.py Changes: ===================================== gajim/common/app.py ===================================== @@ -661,7 +661,7 @@ def check_finalized(): if is_finalizer_ref(ref): continue if isinstance(ref, dict): - logger.warning('\n' + pprint.pformat(ref)) + logger.warning('\n%s', pprint.pformat(ref)) else: logger.warning(ref) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/0935942880cb9a8cd5c2531698b4bca9… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/0935942880cb9a8cd5c2531698b4bca9… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] ChatPage: Unset reference to currently loaded control on close
by Daniel Brötzmann (＠wurstsalat) 06 Dec '21

06 Dec '21

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 7cc82703 by wurstsalat at 2021-12-06T19:21:14+01:00 ChatPage: Unset reference to currently loaded control on close - - - - - 1 changed file: - gajim/gtk/chat_page.py Changes: ===================================== gajim/gtk/chat_page.py ===================================== @@ -263,6 +263,7 @@ def remove_chat(self, account: str, jid: JID) -> None: def _on_chat_removed(self, _chat_list: ChatList, account: str, jid: JID, type_: str) -> None: self._chat_stack.remove_chat(account, jid) + self._currently_loaded_control = None if type_ == 'groupchat': client = app.get_client(account) client.get_module('MUC').leave(jid) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/7cc82703d773387296438376f6123522… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/7cc82703d773387296438376f6123522… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: Make logging leak warnings pretty
by Philipp Hörist (＠lovetox) 06 Dec '21

06 Dec '21

Philipp Hörist pushed to branch master at gajim / gajim Commits: b48dacae by lovetox at 2021-12-06T17:43:45+01:00 Make logging leak warnings pretty - - - - - 7cf7f413 by lovetox at 2021-12-06T18:17:58+01:00 Groupchat: Remove all actions on shutdown - - - - - 2 changed files: - gajim/common/app.py - gajim/gtk/controls/groupchat.py Changes: ===================================== gajim/common/app.py ===================================== @@ -37,6 +37,7 @@ import sys import logging import weakref +import pprint from collections import namedtuple from collections import defaultdict @@ -659,6 +660,9 @@ def check_finalized(): for ref in gc.get_referrers(tup[0]): if is_finalizer_ref(ref): continue - logger.warning(ref) + if isinstance(ref, dict): + logger.warning('\n' + pprint.pformat(ref)) + else: + logger.warning(ref) GLib.timeout_add_seconds(2, check_finalized) ===================================== gajim/gtk/controls/groupchat.py ===================================== @@ -397,7 +397,8 @@ def remove_actions(self) -> None: 'groupchat-manage-', 'rename-groupchat-', 'change-nickname-', - 'disconnect-', + 'destroy-', + 'configure-', 'request-voice-', 'information-', 'invite-', View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/ad16a7305388b076133bedd26db4a7e… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/ad16a7305388b076133bedd26db4a7e… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 3 commits: Rename shortcut action
by Philipp Hörist (＠lovetox) 05 Dec '21

05 Dec '21

Philipp Hörist pushed to branch master at gajim / gajim Commits: e188ec5e by lovetox at 2021-12-05T23:59:29+01:00 Rename shortcut action right/left makes no sense anymore after the GUI rework - - - - - 7f8ff51f by lovetox at 2021-12-06T00:18:45+01:00 Main: Add type annotations - - - - - ad16a730 by lovetox at 2021-12-06T00:27:17+01:00 Main simplify action handler - - - - - 2 changed files: - gajim/application.py - gajim/gtk/main.py Changes: ===================================== gajim/application.py ===================================== @@ -492,8 +492,8 @@ def _set_shortcuts(self): 'win.close-tab': ['<Primary>W'], 'win.switch-next-tab': ['<Primary>Page_Down'], 'win.switch-prev-tab': ['<Primary>Page_Up'], - 'win.switch-next-unread-tab-right': ['<Primary>Tab'], - 'win.switch-next-unread-tab-left': ['<Primary>ISO_Left_Tab'], + 'win.switch-next-unread-tab': ['<Primary>Tab'], + 'win.switch-prev-unread-tab': ['<Primary>ISO_Left_Tab'], 'win.switch-tab-1': ['<Alt>1', '<Alt>KP_1'], 'win.switch-tab-2': ['<Alt>2', '<Alt>KP_2'], 'win.switch-tab-3': ['<Alt>3', '<Alt>KP_3'], ===================================== gajim/gtk/main.py ===================================== @@ -12,6 +12,8 @@ # You should have received a copy of the GNU General Public License # along with Gajim. If not, see <http://www.gnu.org/licenses/>. +from __future__ import annotations + from typing import Optional from typing import Generator @@ -203,8 +205,8 @@ def _add_actions2(self): 'close-tab', 'switch-next-tab', 'switch-prev-tab', - 'switch-next-unread-tab-right' - 'switch-next-unread-tab-left', + 'switch-next-unread-tab' + 'switch-prev-unread-tab', 'switch-tab-1', 'switch-tab-2', 'switch-tab-3', @@ -231,51 +233,49 @@ def _add_actions2(self): act.connect('activate', self._on_action) self.add_action(act) - def _on_action(self, action, _param): + def _on_action(self, + action: Gio.SimpleAction, + _param: Optional[GLib.Variant]) -> None: + control = self.get_active_control() if control is None: return None log.info('Activate action: %s, active control: %s', action.get_name(), control.contact.jid) - action = action.get_name() + action_name = action.get_name() res = control.delegate_action(action) if res != Gdk.EVENT_PROPAGATE: return res - if action == 'escape': + if action_name == 'escape': if self._chat_page.hide_search(): return None - if action == 'escape' and app.settings.get('escape_key_closes'): - self._chat_page.remove_chat(control.account, control.contact.jid) - return None + if app.settings.get('escape_key_closes'): + self._chat_page.remove_chat(control.account, + control.contact.jid) + return None - if action == 'close-tab': + elif action_name == 'close-tab': self._chat_page.remove_chat(control.account, control.contact.jid) - return None - if action == 'switch-next-tab': + elif action_name == 'switch-next-tab': self.select_next_chat(Direction.NEXT) - return None - if action == 'switch-prev-tab': + elif action_name == 'switch-prev-tab': self.select_next_chat(Direction.PREV) - return None - if action == 'switch-next-unread-tab-right': + elif action_name == 'switch-next-unread-tab': self.select_next_chat(Direction.NEXT, unread_first=True) - return None - if action == 'switch-next-unread-tab-left': + elif action_name == 'switch-prev-unread-tab': self.select_next_chat(Direction.PREV, unread_first=True) - return None - if action.startswith('switch-tab-'): - number = int(action[-1]) - 1 + elif action_name.startswith('switch-tab-'): + number = int(action_name[-1]) - 1 self.select_chat_number(number) - return None return None @@ -339,7 +339,10 @@ def is_chat_active(self, account: str, jid: JID) -> bool: return False return self._chat_page.is_chat_active(account, jid) - def _add_workspace(self, _action, param): + def _add_workspace(self, + _action: Gio.SimpleAction, + param: Optional[GLib.Variant]) -> None: + workspace_id = param.get_string() if workspace_id is not None: self.add_workspace(workspace_id) @@ -352,12 +355,18 @@ def add_workspace(self, workspace_id: str) -> None: self.activate_workspace(workspace_id) self._workspace_side_bar.store_workspace_order() - def _edit_workspace(self, _action, _param): + def _edit_workspace(self, + _action: Gio.SimpleAction, + _param: Optional[GLib.Variant]) -> None: + workspace_id = self.get_active_workspace() if workspace_id is not None: open_window('WorkspaceDialog', workspace_id=workspace_id) - def _remove_workspace(self, _action, _param): + def _remove_workspace(self, + _action: Gio.SimpleAction, + _param: Optional[GLib.Variant]) -> None: + workspace_id = self.get_active_workspace() if workspace_id is not None: self.remove_workspace(workspace_id) @@ -376,7 +385,10 @@ def remove_workspace(self, workspace_id: str) -> None: self._chat_page.remove_chat_list(workspace_id) app.settings.remove_workspace(workspace_id) - def _activate_workspace(self, _action, param): + def _activate_workspace(self, + _action: Gio.SimpleAction, + param: Optional[GLib.Variant]) -> None: + workspace_id = param.get_string() if workspace_id is not None: self.activate_workspace(workspace_id) @@ -395,7 +407,10 @@ def get_chat_list(self, workspace_id: str) -> ChatList: chat_list_stack = self._chat_page.get_chat_list_stack() return chat_list_stack.get_chatlist(workspace_id) - def _add_group_chat(self, _action, param): + def _add_group_chat(self, + _action: Gio.SimpleAction, + param: Optional[GLib.Variant]) -> None: + account, jid, select = param.unpack() self.add_group_chat(account, JID.from_string(jid), select) @@ -410,7 +425,10 @@ def add_group_chat(self, account: str, jid: JID, 'groupchat', select=select) - def _add_chat(self, _action, param): + def _add_chat(self, + _action: Gio.SimpleAction, + param: Optional[GLib.Variant]) -> None: + account, jid, type_, select = param.unpack() self.add_chat(account, JID.from_string(jid), type_, select) @@ -456,7 +474,9 @@ def select_chat_number(self, number: int) -> None: chat_list.select_chat_number(number) @staticmethod - def _add_to_roster(_action, param): + def _add_to_roster(_action: Gio.SimpleAction, + param: Optional[GLib.Variant]) -> None: + _workspace, account, jid = param.unpack() open_window('AddContact', account=account, jid=JID.from_string(jid)) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/0da42301b371f186871ed14e1b02c05… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/0da42301b371f186871ed14e1b02c05… You're receiving this email because of your account on dev.gajim.org.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits