Commits

commits@gajim.org

17632 discussions

[Git][gajim/gajim][master] Flatpak: Update dependencies
by André (＠andre) 12 Feb '22

12 Feb '22

André pushed to branch master at gajim / gajim Commits: 4f662bb0 by André Apitzsch at 2022-02-12T10:52:13+01:00 Flatpak: Update dependencies - - - - - 1 changed file: - flatpak/org.gajim.Gajim.yaml Changes: ===================================== flatpak/org.gajim.Gajim.yaml ===================================== @@ -61,11 +61,11 @@ modules: - name: python3-pyparsing buildsystem: simple build-commands: - - pip3 install pyparsing-2.4.7-py2.py3-none-any.whl + - pip3 install pyparsing-3.0.7-py3-none-any.whl sources: - type: file - url: https://files.pythonhosted.org/packages/py2.py3/p/pyparsing/pyparsing-2.4.7… - sha256: ef9d7589ef3c200abe66653d3f1ab1033c3c419ae9b9bdb1240a85b024efc88b + url: https://files.pythonhosted.org/packages/py3/p/pyparsing/pyparsing-3.0.7-py3… + sha256: a6c06a88f252e6c322f65faf8f418b16213b51bdfaece0524c1c1bc30c63c484 - name: python3-packaging buildsystem: simple @@ -117,31 +117,31 @@ modules: only-arches: - aarch64 build-commands: - - pip3 install cryptography-36.0.0-cp36-abi3-manylinux_2_17_aarch64.manylinux2014_aarch64.whl + - pip3 install cryptography-36.0.1-cp36-abi3-manylinux_2_17_aarch64.manylinux2014_aarch64.whl sources: - type: file - url: https://files.pythonhosted.org/packages/cp36/c/cryptography/cryptography-36… - sha256: 4c702855cd3174666ef0d2d13dcc879090aa9c6c38f5578896407a7028f75b9f + url: https://files.pythonhosted.org/packages/cp36/c/cryptography/cryptography-36… + sha256: 5d59a9d55027a8b88fd9fd2826c4392bd487d74bf628bb9d39beecc62a644c12 - name: python3-cryptography buildsystem: simple only-arches: - x86_64 build-commands: - - pip3 install cryptography-36.0.0-cp36-abi3-manylinux_2_17_x86_64.manylinux2014_x86_64.whl + - pip3 install cryptography-36.0.1-cp36-abi3-manylinux_2_17_x86_64.manylinux2014_x86_64.whl sources: - type: file - url: https://files.pythonhosted.org/packages/cp36/c/cryptography/cryptography-36… - sha256: d91bc9f535599bed58f6d2e21a2724cb0c3895bf41c6403fe881391d29096f1d + url: https://files.pythonhosted.org/packages/cp36/c/cryptography/cryptography-36… + sha256: 0a817b961b46894c5ca8a66b599c745b9a3d9f822725221f0e0fe49dc043a3a3 - name: python3-pyopenssl buildsystem: simple build-commands: - - pip3 install pyOpenSSL-21.0.0-py2.py3-none-any.whl + - pip3 install pyOpenSSL-22.0.0-py2.py3-none-any.whl sources: - type: file - url: https://files.pythonhosted.org/packages/py2.py3/p/pyOpenSSL/pyOpenSSL-21.0.… - sha256: 8935bd4920ab9abfebb07c41a4f58296407ed77f04bd1a92914044b848ba1ed6 + url: https://files.pythonhosted.org/packages/py2.py3/p/pyOpenSSL/pyOpenSSL-22.0.… + sha256: ea252b38c87425b64116f808355e8da644ef9b07e429398bfece610f893ee2e0 - name: python3-dbus-python build-options: @@ -173,62 +173,62 @@ modules: - name: python3-zipp buildsystem: simple build-commands: - - pip3 install zipp-3.6.0-py3-none-any.whl + - pip3 install zipp-3.7.0-py3-none-any.whl sources: - type: file - url: https://files.pythonhosted.org/packages/py3/z/zipp/zipp-3.6.0-py3-none-any.… - sha256: 9fe5ea21568a0a70e50f273397638d39b03353731e6cbbb3fd8502a33fec40bc + url: https://files.pythonhosted.org/packages/py3/z/zipp/zipp-3.7.0-py3-none-any.… + sha256: b47250dd24f92b7dd6a0a8fc5244da14608f3ca90a5efcd37a3b1642fac9a375 # keyring dependency - name: python3-importlib-metadata buildsystem: simple build-commands: - - pip3 install importlib_metadata-4.8.2-py3-none-any.whl + - pip3 install importlib_metadata-4.11.0-py3-none-any.whl cleanup: - /bin sources: - type: file - url: https://files.pythonhosted.org/packages/py3/i/importlib_metadata/importlib_… - sha256: 53ccfd5c134223e497627b9815d5030edf77d2ed573922f7a0b8f8bb81a1c100 + url: https://files.pythonhosted.org/packages/py3/i/importlib_metadata/importlib_… + sha256: 6affcdb3aec542dd98df8211e730bba6c5f2bec8288d47bacacde898f548c9ad - name: python3-keyring buildsystem: simple build-commands: - - pip3 install keyring-23.4.0-py3-none-any.whl + - pip3 install keyring-23.5.0-py3-none-any.whl cleanup: - /bin sources: - type: file - url: https://files.pythonhosted.org/packages/py3/k/keyring/keyring-23.4.0-py3-no… - sha256: 3dc0f66062a4f8f6f2ce30d6a516e6e623e6c3c2e76864204ceaf64695408f07 + url: https://files.pythonhosted.org/packages/py3/k/keyring/keyring-23.5.0-py3-no… + sha256: b0d28928ac3ec8e42ef4cc227822647a19f1d544f21f96457965dc01cf555261 - name: python3-css-parser buildsystem: simple build-commands: - - pip3 install css_parser-1.0.6-py2.py3-none-any.whl + - pip3 install css_parser-1.0.7-py2.py3-none-any.whl sources: - type: file - url: https://files.pythonhosted.org/packages/py2.py3/c/css_parser/css_parser-1.0… - sha256: 6fc4f8f0a4b62c77f043765e375cc64971c54ff9a0502fec7e8f1fb28bb96082 + url: https://files.pythonhosted.org/packages/py2.py3/c/css_parser/css_parser-1.0… + sha256: de7018ec9d3f20f7d692973c37f22ae9a22123c60c77b11849363f47ef6f3387 - name: python3-precis_i18n buildsystem: simple build-commands: - - pip3 install precis_i18n-1.0.3-py3-none-any.whl + - pip3 install precis_i18n-1.0.4-py3-none-any.whl sources: - type: file - url: https://files.pythonhosted.org/packages/py3/p/precis_i18n/precis_i18n-1.0.3… - sha256: b9a4ff1f2f8c4a762393cb1b80bf4cadfbe861ec299f752068cc42f281322d45 + url: https://files.pythonhosted.org/packages/py3/p/precis_i18n/precis_i18n-1.0.4… + sha256: 8b4f6100c2f5e44db61081d53c9c07ff92e50d0a7b36eedd2f4fb7d40c48576d # gssapi dependency - name: python3-decorator buildsystem: simple build-commands: - - pip3 install decorator-5.1.0-py3-none-any.whl + - pip3 install decorator-5.1.1-py3-none-any.whl sources: - type: file - url: https://files.pythonhosted.org/packages/py3/d/decorator/decorator-5.1.0-py3… - sha256: 7b12e7c3c6ab203a29e157335e9122cb03de9ab7264b137594103fd4a683b374 + url: https://files.pythonhosted.org/packages/py3/d/decorator/decorator-5.1.1-py3… + sha256: b8c3f85900b9dc423225913c5aace94729fe1fa9763b38939a95226f02d37186 - name: python3-gssapi buildsystem: simple @@ -280,8 +280,8 @@ modules: - pip3 install . sources: - type: archive - url: https://files.pythonhosted.org/packages/source/p/pillow/Pillow-8.4.0.tar.gz - sha256: b8e2f83c56e141920c39464b852de3719dfbfb6e3c99a2d8da0edf4fb33176ed + url: https://files.pythonhosted.org/packages/source/p/pillow/Pillow-9.0.1.tar.gz + sha256: 6c8bc8238a7dfdaf7a75f5ec5a663f4173f8c367e5a39f87e720495e1eed75fa - name: python3-nbxmpp buildsystem: simple View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/4f662bb0611a2178c2b41955e237bdab… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/4f662bb0611a2178c2b41955e237bdab… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Fix default value for dev_use_message_label
by Philipp Hörist (＠lovetox) 06 Feb '22

06 Feb '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: adbd80e1 by lovetox at 2022-02-06T21:34:55+01:00 Fix default value for dev_use_message_label - - - - - 1 changed file: - gajim/common/setting_values.py Changes: ===================================== gajim/common/setting_values.py ===================================== @@ -261,7 +261,7 @@ class _ACCOUNT_DEFAULT: 'groupchat_roster_width': 210, 'dev_force_bookmark_2': False, 'developer_modus': False, - 'dev_use_message_label': False, + 'dev_use_message_label': True, 'use_libappindicator': True, 'show_help_start_chat': True, 'gc_notify_on_all_messages_private_default': True, View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/adbd80e1fe88cb92eb904addb410fcc9… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/adbd80e1fe88cb92eb904addb410fcc9… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: Remove unused import
by Philipp Hörist (＠lovetox) 06 Feb '22

06 Feb '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: ec7827c6 by lovetox at 2022-02-05T12:58:29+01:00 Remove unused import - - - - - cd40d79f by lovetox at 2022-02-05T13:21:26+01:00 Contacts: Add is_jingle_available property - - - - - 3 changed files: - gajim/common/modules/contacts.py - gajim/gtk/controls/chat.py - gajim/gtk/controls/groupchat.py Changes: ===================================== gajim/common/modules/contacts.py ===================================== @@ -26,6 +26,7 @@ import cairo from nbxmpp.const import Affiliation from nbxmpp.const import Role +from nbxmpp.namespaces import Namespace from nbxmpp.protocol import JID from nbxmpp.structs import DiscoInfo from nbxmpp.structs import LocationData @@ -415,6 +416,12 @@ def set_blocked(self) -> None: def set_unblocked(self) -> None: self.notify('blocking-update') + @property + def is_jingle_available(self) -> bool: + if not self.supports(Namespace.JINGLE_FILE_TRANSFER_5): + return False + return self.is_available + class ResourceContact(CommonContact): def __init__(self, logger: logging.Logger, jid: JID, account: str) -> None: ===================================== gajim/gtk/controls/chat.py ===================================== @@ -215,12 +215,8 @@ def update_actions(self) -> None: self._client.get_module('HTTPUpload').available) # Send file (Jingle) - jingle_support = self.contact.supports(Namespace.JINGLE_FILE_TRANSFER_5) - jingle_conditions = bool(jingle_support and - self.contact.is_available and - not self.contact.is_pm_contact) jingle = self._get_action('send-file-jingle-') - jingle.set_enabled(online and jingle_conditions) + jingle.set_enabled(online and self.contact.is_jingle_available) # Send file self._get_action('send-file-').set_enabled(jingle.get_enabled() or ===================================== gajim/gtk/controls/groupchat.py ===================================== @@ -49,7 +49,6 @@ from gajim.common import ged from gajim.common import helpers from gajim.common.client import Client -from gajim.common.config import Option from gajim.common.const import AvatarSize from gajim.common.const import SimpleClientState from gajim.common.helpers import AdditionalDataDict View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/c81f009d76dbea13abe17c26a4a4012… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/c81f009d76dbea13abe17c26a4a4012… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: ChatPage: Move set_control_active() to ChatStack
by Philipp Hörist (＠lovetox) 05 Feb '22

05 Feb '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: e7444431 by lovetox at 2022-02-05T12:41:44+01:00 ChatPage: Move set_control_active() to ChatStack - - - - - c81f009d by lovetox at 2022-02-05T12:43:00+01:00 ChatStack: Add type annotations - - - - - 4 changed files: - gajim/gtk/chat_page.py - gajim/gtk/chat_stack.py - gajim/gtk/controls/groupchat.py - pyrightconfig.json Changes: ===================================== gajim/gtk/chat_page.py ===================================== @@ -96,7 +96,6 @@ def __init__(self): self._ui.paned.set_position(app.settings.get('chat_handle_position')) self._ui.paned.connect('button-release-event', self._on_button_release) - self._last_control: Optional[ControlT] = None self._startup_finished: bool = False self._add_actions() @@ -183,16 +182,6 @@ def _on_chat_selected(self, self.emit('chat-selected', workspace_id, account, jid) self._reset_chat_idle_time(account, jid) - control = self.get_control(account, jid) - if control is None: - return - - if control != self._last_control: - if self._last_control is not None: - self._last_control.set_control_active(False) - control.set_control_active(True) - self._last_control = control - def _on_chat_unselected(self, _chat_list_stack: ChatListStack) -> None: self._chat_stack.clear() self._search_view.set_context(None, None) @@ -321,7 +310,6 @@ def remove_chat(self, account: str, jid: JID) -> None: def _on_chat_removed(self, _chat_list: ChatList, account: str, jid: JID, type_: str) -> None: self._chat_stack.remove_chat(account, jid) - self._last_control = None if type_ == 'groupchat': client = app.get_client(account) client.get_module('MUC').leave(jid) ===================================== gajim/gtk/chat_stack.py ===================================== @@ -26,7 +26,6 @@ from gajim.common import app from gajim.common import ged from gajim.common.i18n import _ -from gajim.common.events import ApplicationEvent from .controls.chat import ChatControl from .controls.groupchat import GroupchatControl @@ -55,6 +54,7 @@ def __init__(self): self.show_all() self._controls: dict[tuple[str, JID], ControlT] = {} + self._current_control = None def get_control(self, account: str, jid: JID) -> Optional[ControlT]: try: @@ -104,12 +104,24 @@ def remove_chat(self, account: str, jid: JID) -> None: control.shutdown() def show_chat(self, account: str, jid: JID) -> None: - self.set_visible_child_name(f'{account}:{jid}') + new_name = f'{account}:{jid}' + current_name = self.get_visible_child_name() + assert current_name is not None + + if current_name == new_name: + return + control = self.get_control(account, jid) if control is None: log.warning('No Control found for %s, %s', account, jid) return + if self._current_control is not None: + self._current_control.set_control_active(False) + control.set_control_active(True) + self._current_control = control + + self.set_visible_child_name(new_name) GLib.idle_add(control.focus) def is_chat_loaded(self, account: str, jid: JID) -> bool: @@ -126,9 +138,12 @@ def unload_chat(self, account: str, jid: JID) -> None: def clear(self) -> None: self.set_visible_child_name('empty') + self._current_control = None - def process_event(self, event: ApplicationEvent) -> None: + def process_event(self, event: Any) -> None: control = self.get_control(event.account, event.jid) + if control is None: + return control.process_event(event) def remove_chats_for_account(self, account: str) -> None: ===================================== gajim/gtk/controls/groupchat.py ===================================== @@ -49,6 +49,7 @@ from gajim.common import ged from gajim.common import helpers from gajim.common.client import Client +from gajim.common.config import Option from gajim.common.const import AvatarSize from gajim.common.const import SimpleClientState from gajim.common.helpers import AdditionalDataDict @@ -1160,7 +1161,7 @@ def send_message(self, def _on_message_error(self, event: events.MessageError) -> None: self.conversation_view.show_error(event.message_id, event.error) - def shutdown(self, reason=None): + def shutdown(self, reason: Optional[str] = None) -> None: app.settings.disconnect_signals(self) self.contact.disconnect(self) ===================================== pyrightconfig.json ===================================== @@ -36,6 +36,7 @@ "gajim/gtk/chat_filter.py", "gajim/gtk/chat_list_stack.py", "gajim/gtk/chat_page.py", + "gajim/gtk/chat_stack.py", "gajim/gtk/const.py", "gajim/gtk/contact_info.py", "gajim/gtk/contacts_flowbox.py", View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/023b5e8371c8933215591eae4f1e666… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/023b5e8371c8933215591eae4f1e666… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] ContactInfo: Access model values correctly
by Philipp Hörist (＠lovetox) 04 Feb '22

04 Feb '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: 023b5e83 by lovetox at 2022-02-04T18:12:53+01:00 ContactInfo: Access model values correctly get_value() does not return GObject.Value Fixes #10767 - - - - - 1 changed file: - gajim/gtk/contact_info.py Changes: ===================================== gajim/gtk/contact_info.py ===================================== @@ -385,7 +385,7 @@ def _on_group_name_edited(self, # Check if group already exists iter_ = model.get_iter_first() while iter_: - group_name = model.get_value(iter_, Column.GROUP_NAME).get_string() + group_name = model.get_value(iter_, Column.GROUP_NAME) if group_name == new_name: return iter_ = model.iter_next(iter_) @@ -425,8 +425,7 @@ def _on_group_toggled(self, iter_ = model.get_iter_first() while iter_: if model.get_value(iter_, Column.IN_GROUP): - group_name = model.get_value( - iter_, Column.GROUP_NAME).get_string() + group_name = model.get_value(iter_, Column.GROUP_NAME) groups.add(group_name) iter_ = model.iter_next(iter_) @@ -441,7 +440,7 @@ def _on_group_add_button_clicked(self, _widget: Gtk.Button) -> None: # Check if default_name group already exists iter_ = model.get_iter_first() while iter_: - group_name = model.get_value(iter_, Column.GROUP_NAME).get_string() + group_name = model.get_value(iter_, Column.GROUP_NAME) if group_name == default_name: default_name += '_' iter_ = model.iter_next(iter_) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/023b5e8371c8933215591eae4f1e6661… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/023b5e8371c8933215591eae4f1e6661… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] CI: Don’t ignore installed packages
by Philipp Hörist (＠lovetox) 03 Feb '22

03 Feb '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: ec4efc90 by lovetox at 2022-02-03T20:45:59+01:00 CI: Don’t ignore installed packages - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -8,8 +8,8 @@ include: pyright: stage: test script: - - pip3 install -I git+https://dev.gajim.org/gajim/python-nbxmpp.git@$NBXMPP_BRANCH - - pip3 install -I git+https://github.com/pygobject/pygobject-stubs.git + - pip3 install git+https://dev.gajim.org/gajim/python-nbxmpp.git@$NBXMPP_BRANCH + - pip3 install git+https://github.com/pygobject/pygobject-stubs.git - npm install pyright - python3 -V - python3 scripts/ci/link-gtk.py View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/ec4efc902e8264ced04718624c78c430… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/ec4efc902e8264ced04718624c78c430… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Docker: Update requirements.txt
by Philipp Hörist (＠lovetox) 03 Feb '22

03 Feb '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: 5211ad57 by lovetox at 2022-02-03T20:35:53+01:00 Docker: Update requirements.txt - - - - - 1 changed file: - docker/requirements.txt Changes: ===================================== docker/requirements.txt ===================================== @@ -2,6 +2,7 @@ PyGObject pycairo>=1.20 mypy pylint==2.12.2 +pillow codespell coverage css-parser View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/5211ad579d46e7d50298de08939132f2… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/5211ad579d46e7d50298de08939132f2… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Remove unused import
by Philipp Hörist (＠lovetox) 03 Feb '22

03 Feb '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: ab9541eb by lovetox at 2022-02-03T20:30:27+01:00 Remove unused import - - - - - 1 changed file: - gajim/gtk/conversation/plain_widget.py Changes: ===================================== gajim/gtk/conversation/plain_widget.py ===================================== @@ -17,7 +17,6 @@ from typing import Any import logging -import os from gi.repository import Gtk from gi.repository import Pango View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/ab9541eba01082544b0094c97f619f5e… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/ab9541eba01082544b0094c97f619f5e… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Add Setting to switch PlainWidget implementation
by Philipp Hörist (＠lovetox) 03 Feb '22

03 Feb '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: ced3738c by lovetox at 2022-02-03T20:20:41+01:00 Add Setting to switch PlainWidget implementation - - - - - 3 changed files: - gajim/common/setting_values.py - gajim/common/settings.py - gajim/gtk/conversation/plain_widget.py Changes: ===================================== gajim/common/setting_values.py ===================================== @@ -39,6 +39,7 @@ class _ACCOUNT_DEFAULT: 'confirm_paste_image', 'dev_force_bookmark_2', 'developer_modus', + 'dev_use_message_label', 'enable_negative_priority', 'escape_key_closes', 'gc_notify_on_all_messages_private_default', @@ -260,6 +261,7 @@ class _ACCOUNT_DEFAULT: 'groupchat_roster_width': 210, 'dev_force_bookmark_2': False, 'developer_modus': False, + 'dev_use_message_label': False, 'use_libappindicator': True, 'show_help_start_chat': True, 'gc_notify_on_all_messages_private_default': True, @@ -644,10 +646,11 @@ class WorkspaceSettings(TypedDict): 'muclumbus_api_pref': _('API Preferences. Possible values: \'http\', \'iq\''), 'command_system_execute': _('If enabled, Gajim will execute commands (/show, /sh, /execute, /exec).'), 'groupchat_roster_width': _('Width of group chat roster in pixel'), - 'dev_force_bookmark_2': _('Force Bookmark 2 usage'), 'gc_notify_on_all_messages_private_default': '', 'gc_notify_on_all_messages_public_default': '', 'developer_modus': '', + 'dev_force_bookmark_2': _('Force Bookmark 2 usage'), + 'dev_use_message_label': '', 'use_libappindicator': _('Enables libappindicator, an alternative tray icon provider'), 'log_contact_status_changes': '', }, ===================================== gajim/common/settings.py ===================================== @@ -212,6 +212,9 @@ def _setup_installation_defaults() -> None: if IS_PORTABLE: APP_SETTINGS['use_keyring'] = False + if sys.platform == 'win32': + APP_SETTINGS['dev_use_message_label'] = False + @staticmethod def _namedtuple_factory(cursor: sqlite3.Cursor, row: tuple[Any, ...]) -> NamedTuple: ===================================== gajim/gtk/conversation/plain_widget.py ===================================== @@ -55,10 +55,10 @@ def __init__(self, account: str, selectable: bool) -> None: # We use a Gtk.Textview on Windows, since there is no support for # rendering color fonts (Emojis) on Windows yet, see: # https://gitlab.freedesktop.org/cairo/cairo/-/merge_requests/244 - if os.name == 'nt': - self._text_widget = MessageTextview(self._account) - else: + if app.settings.get('dev_use_message_label'): self._text_widget = MessageLabel(self._account, selectable) + else: + self._text_widget = MessageTextview(self._account) self.add(self._text_widget) def add_content(self, block: PlainBlock) -> None: View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/ced3738c2729c01b1b031df255fb8770… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/ced3738c2729c01b1b031df255fb8770… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] StartChat: Fix leak
by Daniel Brötzmann (＠wurstsalat) 03 Feb '22

03 Feb '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 13c44d70 by wurstsalat at 2022-02-03T15:22:01+01:00 StartChat: Fix leak - - - - - 1 changed file: - gajim/gtk/start_chat.py Changes: ===================================== gajim/gtk/start_chat.py ===================================== @@ -134,7 +134,7 @@ def __init__(self) -> None: self._ui.filter_bar_revealer.add(self._chat_filter) self.connect('key-press-event', self._on_key_press) - self.connect('destroy', self._destroy) + self.connect('destroy', self._on_destroy) self.select_first_row() self._ui.connect_signals(self) @@ -738,11 +738,14 @@ def _process_search_result(self, for item in result.items: self._global_search_listbox.add(ResultRow(item)) - def _destroy(self, *args: Any) -> None: + def _on_destroy(self, *args: Any) -> None: + self._ui.listbox.set_filter_func(None) + self._ui.listbox.destroy() if self._source_id is not None: GLib.source_remove(self._source_id) self._destroyed = True app.cancel_tasks(self) + app.check_finalize(self) class ContactRow(Gtk.ListBoxRow): View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/13c44d703709de73b1908b7b25cf1699… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/13c44d703709de73b1908b7b25cf1699… You're receiving this email because of your account on dev.gajim.org.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits