Commits

commits@gajim.org

17632 discussions

[Git][gajim/gajim][master] imprv: AccountPage: Add button for Ad-Hoc commands
by Daniel Brötzmann (＠wurstsalat) 15 Aug '22

15 Aug '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: ba2f930b by wurstsalat at 2022-08-15T17:00:53+02:00 imprv: AccountPage: Add button for Ad-Hoc commands - - - - - 2 changed files: - gajim/data/gui/account_page.ui - gajim/gtk/account_page.py Changes: ===================================== gajim/data/gui/account_page.ui ===================================== @@ -1,5 +1,5 @@ <?xml version="1.0" encoding="UTF-8"?> - + <interface> <requires lib="gtk+" version="3.24"/> <object class="GtkPaned" id="paned"> @@ -207,7 +207,7 @@ <property name="halign">center</property> <property name="spacing">12</property> <child> - <object class="GtkButton" id="account_settings"> + <object class="GtkButton"> <property name="visible">True</property> <property name="can-focus">True</property> <property name="receives-default">True</property> @@ -228,6 +228,27 @@ <property name="position">0</property> </packing> </child> + <child> + <object class="GtkButton"> + <property name="visible">True</property> + <property name="can-focus">True</property> + <property name="receives-default">True</property> + <property name="tooltip-text" translatable="yes">Ad-Hoc Commands…</property> + <signal name="clicked" handler="_on_adhoc_commands" swapped="no"/> + <child> + <object class="GtkImage"> + <property name="visible">True</property> + <property name="can-focus">False</property> + <property name="icon-name">utilities-terminal-symbolic</property> + </object> + </child> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">1</property> + </packing> + </child> <child> <placeholder/> </child> ===================================== gajim/gtk/account_page.py ===================================== @@ -18,6 +18,8 @@ from gi.repository import Gio from gi.repository import Gtk +from nbxmpp.protocol import JID + from gajim.common import app from gajim.common import ged from gajim.common.const import AvatarSize @@ -103,6 +105,10 @@ def _on_account_settings(self, _button: Gtk.Button) -> None: window = open_window('AccountsWindow') window.select_account(self._account) + def _on_adhoc_commands(self, _button: Gtk.Button) -> None: + server_jid = JID.from_string(self._jid).domain + open_window('AdHocCommands', account=self._account, jid=server_jid) + def _on_search_changed(self, widget: Gtk.SearchEntry) -> None: text = widget.get_text().lower() self._roster.set_search_string(text) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/ba2f930b9c241b265fb24bc68ad692e0… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/ba2f930b9c241b265fb24bc68ad692e0… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] cfix: ChatBanner: Remove unnecessary code from clear method
by Daniel Brötzmann (＠wurstsalat) 15 Aug '22

15 Aug '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: d6b10432 by wurstsalat at 2022-08-15T11:31:41+02:00 cfix: ChatBanner: Remove unnecessary code from clear method - - - - - 1 changed file: - gajim/gtk/chat_banner.py Changes: ===================================== gajim/gtk/chat_banner.py ===================================== @@ -78,9 +78,6 @@ def clear(self) -> None: self.unregister_events() - self._contact = None - self._client = None - def switch_contact(self, contact: types.ChatContactT) -> None: self._update_account_badge(contact.account) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/d6b1043204ed9ac44708d83f2855ac0f… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/d6b1043204ed9ac44708d83f2855ac0f… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix: BlockingList: Don’t fail with placeholder address
by Daniel Brötzmann (＠wurstsalat) 15 Aug '22

15 Aug '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 95317a4e by wurstsalat at 2022-08-15T11:03:39+02:00 fix: BlockingList: Don’t fail with placeholder address Fixes #11084 - - - - - 1 changed file: - gajim/gtk/blocking.py Changes: ===================================== gajim/gtk/blocking.py ===================================== @@ -127,6 +127,9 @@ def _on_save(self, _button: Gtk.Button) -> None: blocked_jids: set[JID] = set() for item in self._ui.blocking_store: + if not item[0]: + # No address/placeholder + continue blocked_jids.add(JID.from_string(item[0].lower())) unblock_jids = self._prev_blocked_jids - blocked_jids View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/95317a4e3580298bf040ee6ae84fc664… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/95317a4e3580298bf040ee6ae84fc664… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: cfix: MUC: muc_data for group chat nick is only available if joined
by Daniel Brötzmann (＠wurstsalat) 15 Aug '22

15 Aug '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 39f20787 by wurstsalat at 2022-08-15T10:57:20+02:00 cfix: MUC: muc_data for group chat nick is only available if joined - - - - - cbc05e1b by wurstsalat at 2022-08-15T10:57:59+02:00 cfix: ConversationView: Don’t remove ReadmarkerRow Fixes #11085 - - - - - 2 changed files: - gajim/gtk/control.py - gajim/gtk/conversation/view.py Changes: ===================================== gajim/gtk/control.py ===================================== @@ -499,7 +499,8 @@ def get_our_nick(self) -> str: if isinstance(self.contact, GroupchatParticipant): muc_data = self.client.get_module('MUC').get_muc_data( self.contact.jid.bare) - return muc_data.nick + if muc_data is not None: + return muc_data.nick return app.nicks[self.contact.account] ===================================== gajim/gtk/conversation/view.py ===================================== @@ -130,10 +130,11 @@ def get_row_at_index(self, index: int) -> BaseRow: def reset(self) -> None: for row in self.get_children()[2:]: + if isinstance(row, ReadMarkerRow): + continue row.destroy() self._row_count = 0 - self._read_marker_row = None self._active_date_rows = set() self._message_id_row_map = {} View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/b6e481ce71f9bf29510ce9cbbb85e10… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/b6e481ce71f9bf29510ce9cbbb85e10… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][new-chat-commands] 53 commits: fix: ChatBanner: Display account badge again
by Philipp Hörist (＠lovetox) 14 Aug '22

14 Aug '22

Philipp Hörist pushed to branch new-chat-commands at gajim / gajim Commits: 1be6e94e by wurstsalat at 2022-08-12T10:03:26+02:00 fix: ChatBanner: Display account badge again - - - - - 1eff8558 by wurstsalat at 2022-08-12T10:06:37+02:00 chore: ChatBanner: Remove unused import - - - - - dcd120eb by lovetox at 2022-08-12T15:40:37+02:00 fix: Don’t handle message-sent even for groupchats Otherwise the message would be added twice to the view. - - - - - cd21fb0e by wurstsalat at 2022-08-12T16:38:05+02:00 fix: ChatBanner: Don’t show phone icon for group chats - - - - - 8aed5d2d by lovetox at 2022-08-12T17:54:53+02:00 refactor: Simplify showing current encryption state - - - - - 5ed1791e by wurstsalat at 2022-08-12T18:03:52+02:00 refactor: Move notification logic from Control to ChatStack - - - - - 35d8a2fb by wurstsalat at 2022-08-12T18:15:17+02:00 chore: Events: Add 'MessageReceived' to 'MainEventT' - - - - - 74755fb5 by wurstsalat at 2022-08-12T18:27:01+02:00 chore: ChatStack: Allow Any for event processing - - - - - c7139cf4 by wurstsalat at 2022-08-12T18:27:11+02:00 chore: Update pyrightconfig - - - - - b24d9286 by lovetox at 2022-08-12T18:44:25+02:00 refactor: MessageRow: Simplify code kind can only be 'incoming' or 'outgoing' - - - - - 04b7998d by wurstsalat at 2022-08-12T20:32:23+02:00 fix: FileTransferRow: Don’t cancel transfer when switching chat - - - - - 61889089 by wurstsalat at 2022-08-12T20:32:23+02:00 imprv: Store and restore running HTTP File Transfer uploads - - - - - 4965174b by lovetox at 2022-08-12T21:15:11+02:00 refactor: AccountPage: Remove boilerplate code for event handling No actual events are currently handled - - - - - eb6ce2dc by lovetox at 2022-08-12T21:16:24+02:00 refactor: ChatControl: Register events Register events directly in the widget instead of depending on process_events(). This is better for clarity and readability. - - - - - 13b61fe8 by lovetox at 2022-08-12T21:28:46+02:00 refactor: MessageActionsBox: Register events - - - - - 3aa0c042 by lovetox at 2022-08-12T21:42:15+02:00 refactor: ChatStack: Register events - - - - - c29838b7 by lovetox at 2022-08-12T22:06:28+02:00 refactor: ChatPage: Remove unused method - - - - - 10ee7c7b by lovetox at 2022-08-12T22:28:23+02:00 refactor: ChatListStack: Register events - - - - - 84d86503 by lovetox at 2022-08-12T22:44:06+02:00 refactor: HTTPUpload: Simplify dict access - - - - - c8cf5511 by lovetox at 2022-08-12T23:00:23+02:00 cq: Remove not needed ignore comments - - - - - e0cb3e4a by lovetox at 2022-08-12T23:12:21+02:00 cq: Update pyrightconfig.json - - - - - 2ac83815 by lovetox at 2022-08-12T23:21:46+02:00 refactor: Use Path objects for gettext calls Seems python 3.9 does support this now - - - - - c327dbfe by lovetox at 2022-08-12T23:48:21+02:00 refactor: ChatControl: Remove dead encryption code - - - - - d9ac569c by lovetox at 2022-08-13T00:03:04+02:00 imprv: ChatControl: Show error if encryption plugin is missing - - - - - c08ccb30 by wurstsalat at 2022-08-13T10:28:37+02:00 imprv: CSS: Use relative sizes for fonts - - - - - 0da402a7 by wurstsalat at 2022-08-13T10:30:25+02:00 imprv: Windows: Increase default font size - - - - - d06ef306 by wurstsalat at 2022-08-13T10:39:11+02:00 cq: CSSConfig: Remove whitespace from blank line - - - - - b8dfaf8e by wurstsalat at 2022-08-13T12:30:25+02:00 fix: ChatBanner: Use correct scaling for chatstates - - - - - 53714f8e by lovetox at 2022-08-13T12:31:48+02:00 fix: Fix switch-next-unread-tab action work - - - - - c57682ce by lovetox at 2022-08-13T12:31:48+02:00 imprv: Chatstate: Don’t make too many assumptions - active does not necessarily mean the user looks at the chat - gone: In todays chat clients there is no difference between closing a chat and not looking at it or switching to another chat. In both cases the user gets notified if new messages arrive, its not clear how this informtation can be important for our users. Further for communicating idle states there are more useful mechanisms like idle presence and presence show states. - - - - - 0835a886 by wurstsalat at 2022-08-13T12:49:44+02:00 fix: Roster: Add missing contact-info action - - - - - 843b6f1d by lovetox at 2022-08-13T17:19:01+02:00 fix: GroupChat: Handle nickname changes correctly - - - - - c90c3353 by lovetox at 2022-08-13T17:48:22+02:00 refactor: GED: Prevent registering events multiple times - - - - - de8cb97b by lovetox at 2022-08-13T17:48:22+02:00 refactor: ChatBanner: Simplify phone image logic - - - - - ba7e88c2 by lovetox at 2022-08-13T18:06:43+02:00 refactor: ChatBanner: Register events only once - - - - - d172b074 by lovetox at 2022-08-13T18:13:07+02:00 cq: Fix typo - - - - - c30369ac by lovetox at 2022-08-13T19:12:28+02:00 fix: ChatList: Update avatar for all chats correctly - - - - - 3ae324ed by lovetox at 2022-08-13T19:22:31+02:00 cq: ChatList: Help type checker narrowing the type - - - - - 8c1722e1 by lovetox at 2022-08-13T21:14:28+02:00 refactor: Storage: Allow CacheStorage to be created in memory This is useful for tests - - - - - 83f9ed16 by lovetox at 2022-08-13T21:15:33+02:00 refactor: Contacts: Make contacts a hashable object - - - - - f1e8841f by lovetox at 2022-08-13T21:44:36+02:00 refactor: ChatBanner: Preserve phone indicator state on contact switch - - - - - d8dfff44 by lovetox at 2022-08-13T21:53:02+02:00 other: Tests: Add contact object tests - - - - - 0c95e7c5 by lovetox at 2022-08-13T23:00:30+02:00 imprv: Don’t disco MUC participants on presence - - - - - 996c4346 by lovetox at 2022-08-14T08:42:17+02:00 chore: Add new commit prefixes - - - - - f7f8b8b0 by lovetox at 2022-08-14T13:26:11+02:00 cfix: Contacts: Fix logic error when calling add_private_contact() - - - - - a706dfc6 by lovetox at 2022-08-14T13:28:35+02:00 perf: Use Task Queue to request avatars on MUC join Previously we requested all avatars at once. On bigger MUCs this can lead to other network tasks, like joining other MUCs, executing more slowly. - - - - - 33d27496 by lovetox at 2022-08-14T13:28:58+02:00 cq: TaskManager: Add comment - - - - - 92b80c88 by Weblate at 2022-08-14T13:37:18+02:00 chore: Update translations - - - - - 587c3bb7 by lovetox at 2022-08-14T13:40:08+02:00 cq: Remove redundant elif - - - - - 8de0c5d2 by lovetox at 2022-08-14T14:12:27+02:00 new: Contacts: Add convenience method to access disco fields - - - - - 2e4be3bb by lovetox at 2022-08-14T14:25:30+02:00 imprv: Don’t try to query avatars in MUCs which don’t allow it Fixes #10937 - - - - - b80315b8 by lovetox at 2022-08-14T17:10:52+02:00 fix: ChatList: Update status for private chats correctly The status was not updated when the corresponding MUC was left. - - - - - a8fa42d2 by lovetox at 2022-08-15T00:27:06+02:00 Initial commit - - - - - 30 changed files: - .githooks/update - CONTRIBUTING.md - gajim/common/app.py - gajim/common/application.py - + gajim/common/commands.py - gajim/common/const.py - gajim/common/events.py - gajim/common/ged.py - gajim/common/helpers.py - gajim/common/i18n.py - gajim/common/idle.py - gajim/common/modules/caps.py - gajim/common/modules/contacts.py - gajim/common/modules/httpupload.py - gajim/common/modules/muc.py - gajim/common/modules/vcard_avatars.py - gajim/common/storage/base.py - gajim/common/storage/cache.py - gajim/common/task_manager.py - gajim/data/gui/chat_banner.ui - gajim/data/style/gajim.css - gajim/gtk/account_page.py - gajim/gtk/app_page.py - gajim/gtk/certificate_dialog.py - gajim/gtk/chat_action_processor.py - gajim/gtk/chat_banner.py - gajim/gtk/chat_list.py - gajim/gtk/chat_list_stack.py - gajim/gtk/chat_page.py - gajim/gtk/chat_stack.py The diff was not included because it is too large. View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/7a3d168fbc87586b3b01cbb4536b601… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/7a3d168fbc87586b3b01cbb4536b601… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: cfix: Control: Use deque for storing info messages
by Daniel Brötzmann (＠wurstsalat) 14 Aug '22

14 Aug '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: f21ec271 by wurstsalat at 2022-08-14T22:57:47+02:00 cfix: Control: Use deque for storing info messages - - - - - b6e481ce by wurstsalat at 2022-08-14T23:18:22+02:00 new: Control: Store muc subject per contact - - - - - 3 changed files: - gajim/gtk/control.py - gajim/gtk/conversation/rows/muc_subject.py - gajim/gtk/conversation/view.py Changes: ===================================== gajim/gtk/control.py ===================================== @@ -20,6 +20,8 @@ from typing import cast from collections import defaultdict +from collections import deque +from functools import partial import os import logging import time @@ -62,8 +64,6 @@ log = logging.getLogger('gajim.gui.control') -INFO_MESSAGES_COUNT = 100 - class ChatControl(EventHelper): def __init__(self) -> None: @@ -102,10 +102,14 @@ def __init__(self) -> None: # XEP-0333 Chat Markers self.last_msg_id: Optional[str] = None - self._subject_text_cache: dict[JID, str] = {} + self._muc_subjects: dict[ + types.ChatContactT, tuple[float, MucSubject]] = {} + # Store 100 info messages per contact on a FIFO basis self._info_messages: dict[ - types.ChatContactT, list[tuple[float, str]]] = defaultdict(list) + types.ChatContactT, + deque[tuple[float, str]]] = defaultdict( + partial(deque, maxlen=100)) # pyright: ignore self.widget = cast(Gtk.Box, self._ui.get_object('control_box')) self.widget.show_all() @@ -211,6 +215,14 @@ def switch_contact(self, contact: Union[BareContact, for timestamp, message in self._info_messages[contact]: self.add_info_message(message, timestamp) + if isinstance(contact, GroupchatContact): + if (app.settings.get('show_subject_on_join') or + not contact.is_joining): + timestamp, subject = self._muc_subjects.get( + contact, (None, None)) + if subject is not None: + self.conversation_view.add_muc_subject(subject, timestamp) + def _register_events(self) -> None: if self.has_events_registered(): return @@ -502,9 +514,6 @@ def add_info_message(self, if timestamp is None: assert self._contact is not None self._info_messages[self._contact].append((time.time(), text)) - info_messages = self._info_messages[self._contact] - if len(info_messages) > INFO_MESSAGES_COUNT: - info_messages.pop(0) self.conversation_view.add_info_message(text, timestamp) @@ -834,11 +843,12 @@ def _on_room_subject(self, if subject is None: return - if self._subject_text_cache.get(contact.jid) == subject.text: + _timestamp, old_subject = self._muc_subjects.get(contact, (None, None)) + if old_subject is not None and old_subject.text == subject.text: # Probably a rejoin, we already showed that subject return - self._subject_text_cache[contact.jid] = subject.text + self._muc_subjects[contact] = (time.time(), subject) if (app.settings.get('show_subject_on_join') or not contact.is_joining): ===================================== gajim/gtk/conversation/rows/muc_subject.py ===================================== @@ -12,6 +12,10 @@ # You should have received a copy of the GNU General Public License # along with Gajim. If not, see <http://www.gnu.org/licenses/>. +from __future__ import annotations + +from typing import Optional + import time from datetime import datetime @@ -29,12 +33,17 @@ class MUCSubject(BaseRow): type = 'muc-subject' - def __init__(self, account: str, subject: MucSubject) -> None: + def __init__(self, + account: str, + subject: MucSubject, + timestamp: Optional[float] = None + ) -> None: + BaseRow.__init__(self, account) - timestamp = time.time() - self.timestamp = datetime.fromtimestamp(timestamp) - self.db_timestamp = timestamp + current_timestamp = timestamp or time.time() + self.timestamp = datetime.fromtimestamp(current_timestamp) + self.db_timestamp = current_timestamp self.grid.set_halign(Gtk.Align.START) ===================================== gajim/gtk/conversation/view.py ===================================== @@ -162,8 +162,12 @@ def _sort_func(row1: BaseRow, row2: BaseRow) -> int: return 0 return -1 if row1.timestamp < row2.timestamp else 1 - def add_muc_subject(self, subject: MucSubject) -> None: - muc_subject = MUCSubject(self.contact.account, subject) + def add_muc_subject(self, + subject: MucSubject, + timestamp: Optional[float] = None + ) -> None: + + muc_subject = MUCSubject(self.contact.account, subject, timestamp) self._insert_message(muc_subject) def add_muc_user_left(self, View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/6fd1b99da4ca1731926aa92e6c219b7… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/6fd1b99da4ca1731926aa92e6c219b7… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] new: Control: Store info messages per contact
by Daniel Brötzmann (＠wurstsalat) 14 Aug '22

14 Aug '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 6fd1b99d by wurstsalat at 2022-08-14T20:35:02+02:00 new: Control: Store info messages per contact - - - - - 3 changed files: - gajim/gtk/control.py - gajim/gtk/conversation/rows/info.py - gajim/gtk/conversation/view.py Changes: ===================================== gajim/gtk/control.py ===================================== @@ -19,6 +19,7 @@ from typing import Union from typing import cast +from collections import defaultdict import os import logging import time @@ -61,6 +62,8 @@ log = logging.getLogger('gajim.gui.control') +INFO_MESSAGES_COUNT = 100 + class ChatControl(EventHelper): def __init__(self) -> None: @@ -101,6 +104,9 @@ def __init__(self) -> None: self._subject_text_cache: dict[JID, str] = {} + self._info_messages: dict[ + types.ChatContactT, list[tuple[float, str]]] = defaultdict(list) + self.widget = cast(Gtk.Box, self._ui.get_object('control_box')) self.widget.show_all() @@ -202,6 +208,9 @@ def switch_contact(self, contact: Union[BareContact, for transfer in transfers: self.add_file_transfer(transfer) + for timestamp, message in self._info_messages[contact]: + self.add_info_message(message, timestamp) + def _register_events(self) -> None: if self.has_events_registered(): return @@ -485,8 +494,19 @@ def get_our_nick(self) -> str: def _allow_add_message(self) -> bool: return self._scrolled_view.get_lower_complete() - def add_info_message(self, text: str) -> None: - self.conversation_view.add_info_message(text) + def add_info_message(self, + text: str, + timestamp: Optional[float] = None + ) -> None: + + if timestamp is None: + assert self._contact is not None + self._info_messages[self._contact].append((time.time(), text)) + info_messages = self._info_messages[self._contact] + if len(info_messages) > INFO_MESSAGES_COUNT: + info_messages.pop(0) + + self.conversation_view.add_info_message(text, timestamp) def add_file_transfer(self, transfer: HTTPFileTransfer) -> None: self.conversation_view.add_file_transfer(transfer) ===================================== gajim/gtk/conversation/rows/info.py ===================================== @@ -12,6 +12,10 @@ # You should have received a copy of the GNU General Public License # along with Gajim. If not, see <http://www.gnu.org/licenses/>. +from __future__ import annotations + +from typing import Optional + import time from datetime import datetime @@ -25,13 +29,18 @@ class InfoMessage(BaseRow): - def __init__(self, account: str, text: str) -> None: + def __init__(self, + account: str, + text: str, + timestamp: Optional[float] + ) -> None: + BaseRow.__init__(self, account) self.type = 'info' - timestamp = time.time() - self.timestamp = datetime.fromtimestamp(timestamp) - self.db_timestamp = timestamp + current_timestamp = timestamp or time.time() + self.timestamp = datetime.fromtimestamp(current_timestamp) + self.db_timestamp = current_timestamp text = GLib.markup_escape_text(text) ===================================== gajim/gtk/conversation/view.py ===================================== @@ -193,8 +193,12 @@ def add_user_status(self, name: str, show: str, status: str) -> None: user_status = UserStatus(self.contact.account, name, show, status) self._insert_message(user_status) - def add_info_message(self, text: str) -> None: - message = InfoMessage(self.contact.account, text) + def add_info_message(self, + text: str, + timestamp: Optional[float] = None + ) -> None: + + message = InfoMessage(self.contact.account, text, timestamp) self._insert_message(message) def add_file_transfer(self, transfer: HTTPFileTransfer) -> None: View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/6fd1b99da4ca1731926aa92e6c219b7c… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/6fd1b99da4ca1731926aa92e6c219b7c… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] cfix: ConversationView: Make sure ReadMarkerRow can be finalized
by Daniel Brötzmann (＠wurstsalat) 14 Aug '22

14 Aug '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: ef3683f3 by wurstsalat at 2022-08-14T19:49:20+02:00 cfix: ConversationView: Make sure ReadMarkerRow can be finalized - - - - - 1 changed file: - gajim/gtk/conversation/view.py Changes: ===================================== gajim/gtk/conversation/view.py ===================================== @@ -133,6 +133,7 @@ def reset(self) -> None: row.destroy() self._row_count = 0 + self._read_marker_row = None self._active_date_rows = set() self._message_id_row_map = {} View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/ef3683f3aa11738e6d0489ea28db08a7… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/ef3683f3aa11738e6d0489ea28db08a7… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] change: Shortcuts: Use Ctrl+F for opening the search bar
by Daniel Brötzmann (＠wurstsalat) 14 Aug '22

14 Aug '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 5c3af508 by wurstsalat at 2022-08-14T19:18:43+02:00 change: Shortcuts: Use Ctrl+F for opening the search bar Fixes #11073 NOTES: Ctrl+H for opening the search bar has been removed, please use the commonly used Ctrl+F (find). The shortcut for starting a file transfer has been dropped. - - - - - 1 changed file: - gajim/data/other/shortcuts.json Changes: ===================================== gajim/data/other/shortcuts.json ===================================== @@ -11,7 +11,7 @@ "win.change-nickname": ["<Primary><Shift>N"], "win.change-subject": ["<Primary><Shift>S"], "win.escape": ["Escape"], - "win.send-file": ["<Primary>F"], + "win.search-history": ["<Primary>F"], "win.show-contact-info": ["<Primary>I"], "win.show-emoji-chooser": ["<Primary><Shift>M"], "win.input-clear": ["<Primary>U"], @@ -29,6 +29,5 @@ "win.switch-tab-7": ["<Alt>7", "<Alt>KP_7"], "win.switch-tab-8": ["<Alt>8", "<Alt>KP_8"], "win.switch-tab-9": ["<Alt>9", "<Alt>KP_9"], - "win.search-history": ["<Primary>H"], "win.toggle-chat-list": ["<Primary>R"] } View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/5c3af508047a18d7609b990cc2b94fb3… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/5c3af508047a18d7609b990cc2b94fb3… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix: ChatList: Update status for private chats correctly
by Philipp Hörist (＠lovetox) 14 Aug '22

14 Aug '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: b80315b8 by lovetox at 2022-08-14T17:10:52+02:00 fix: ChatList: Update status for private chats correctly The status was not updated when the corresponding MUC was left. - - - - - 1 changed file: - gajim/gtk/chat_list.py Changes: ===================================== gajim/gtk/chat_list.py ===================================== @@ -570,6 +570,10 @@ def __init__(self, workspace_id: str, account: str, jid: JID, type_: str, self.contact.connect('user-status-show-changed', self._on_muc_user_update) + self.contact.room.connect('room-left', self._on_muc_update) + self.contact.room.connect('room-destroyed', self._on_muc_update) + self.contact.room.connect('room-kicked', self._on_muc_update) + self.contact_name: str = self.contact.name self.timestamp: float = 0 self.stanza_id: Optional[str] = None @@ -777,6 +781,13 @@ def _on_muc_user_update(self, ) -> None: self.update_avatar() + def _on_muc_update(self, + _contact: GroupchatContact, + _signal_name: str, + *args: Any + ) -> None: + self.update_avatar() + def update_avatar(self) -> None: scale = self.get_scale_factor() surface = self.contact.get_avatar(AvatarSize.ROSTER, scale) @@ -908,6 +919,9 @@ def _on_state_flags_changed(self, def _on_destroy(self, _row: ChatRow) -> None: self.contact.disconnect_all_from_obj(self) + if isinstance(self.contact, GroupchatParticipant): + self.contact.room.disconnect_all_from_obj(self) + app.check_finalize(self) def _on_close_button_clicked(self, _button: Gtk.Button) -> None: View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/b80315b8c7b8417043f1e69757610f31… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/b80315b8c7b8417043f1e69757610f31… You're receiving this email because of your account on dev.gajim.org.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits