Commits March 2023

commits@gajim.org

1 participants
44 discussions

[Git][gajim/gajim][master] other: Update release issue template
by Philipp Hörist (＠lovetox) 12 Mar '23

12 Mar '23

Philipp Hörist pushed to branch master at gajim / gajim Commits: ab6c80fe by Philipp Hörist at 2023-03-12T12:48:03+01:00 other: Update release issue template - - - - - 1 changed file: - .gitlab/issue_templates/Release.md Changes: ===================================== .gitlab/issue_templates/Release.md ===================================== @@ -3,6 +3,7 @@ ## Build * [ ] Merge translations from Weblate * [ ] Update IANA data with `./scripts/get_iana_data.py gajim/common/iana.py` +* [ ] Run `./scripts/update_flatpak_manifest.py` * [ ] Run `./scripts/bump_version.py x.x.x` * [ ] Push release tag `x.x.x` View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/ab6c80fe87d8c662a4ee39df06ae19bf… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/ab6c80fe87d8c662a4ee39df06ae19bf… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim] Pushed new tag 1.7.2
by Philipp Hörist (＠lovetox) 11 Mar '23

11 Mar '23

Philipp Hörist pushed new tag 1.7.2 at gajim / gajim -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/tree/1.7.2 You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] release: 1.7.2
by Philipp Hörist (＠lovetox) 11 Mar '23

11 Mar '23

Philipp Hörist pushed to branch master at gajim / gajim Commits: 2b0a1423 by Philipp Hörist at 2023-03-11T20:29:35+01:00 release: 1.7.2 - - - - - 4 changed files: - ChangeLog - data/org.gajim.Gajim.appdata.xml.in - flatpak/org.gajim.Gajim.yaml - gajim/__init__.py Changes: ===================================== ChangeLog ===================================== @@ -1,3 +1,38 @@ +Gajim 1.7.2 (09 Mar 2023) + + Improvements + + * Declare that the installer is DPI-aware + * Windows installer: Add Polish language + * Add message menu entry for deleting messages locally + * Proxies: Add 'Tor (Browser)' default proxy setting + * Windows: Add direct download for Gajim Portable updates + * Windows: Offer direct download of Gajim setup when update is available + * Select group chat after creating it (#11304) + * Don’t color log timestamps + * PEPConfig: Ask for confirmation when deleting nodes + * Improve get_recent_muc_nicks query + * Improve check for message highlight and add tests + * Tests: Use in-memory settings database + * Add audio/x-wav to default mime types + * Audio preview: Allow skipping by clicking the visualization (#11392) + + Bug Fixes + + * Migration: Don’t fail on color setting migration (#11426) + * HTTPUpload: Respect infinite file size limit (#11436) + * Chatstates: Remove composing timeout correctly + * Show chat notifications when chat page is not visible (#11416) + * Don't fail if contact name for MUC message is None (#11417) + * Notifications: Honor notification_preview_message setting + * Fix nickname highlight in group chats (#11413) + * Profile: Don't allow saving profile when not connected (#11401) + * GetRelativeTimeTest: Fix comparison of translated strings and off-by timezone errors + * Don't highlight message if it's an URI containing our nick (#11387) + * Nickname completion: Make sure recent nicknames list does not contain None (#11394) + * Plugins: Don't fail hard on uninstall errors (#11389) + * Start Chat: Fix wrong JID type in _start_new_chat (#11398) + Gajim 1.7.1 (08 Feb 2023) New ===================================== data/org.gajim.Gajim.appdata.xml.in ===================================== @@ -74,6 +74,7 @@ <control>pointing</control> </recommends> <releases> + <release version="1.7.2" date="2023-03-11" /> <release version="1.7.1" date="2023-02-08" /> <release version="1.7.0" date="2023-02-03" /> <release version="1.6.1" date="2023-01-14" /> ===================================== flatpak/org.gajim.Gajim.yaml ===================================== @@ -333,7 +333,7 @@ modules: sources: - type: git url: https://dev.gajim.org/gajim/gajim.git - tag: 1.7.1 + tag: 1.7.2 - type: file path: app-overrides.json post-install: ===================================== gajim/__init__.py ===================================== @@ -1,7 +1,7 @@ import sys from pathlib import Path -__version__ = '1.7.1' +__version__ = '1.7.2' IS_FLATPAK = Path('/app/share/run-as-flatpak').exists() View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/2b0a1423f8a98647a78b9393719a0543… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/2b0a1423f8a98647a78b9393719a0543… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] chore: Update translations
by Philipp Hörist (＠lovetox) 11 Mar '23

11 Mar '23

Philipp Hörist pushed to branch master at gajim / gajim Commits: 7d8e24a6 by Weblate at 2023-03-11T20:25:41+01:00 chore: Update translations - - - - - 27 changed files: - po/be.po - po/be(a)latin.po - po/bg.po - po/br.po - po/ca.po - po/cs.po - po/da.po - po/de.po - po/el.po - po/en_GB.po - po/eo.po - po/es.po - po/eu.po - po/fr.po - po/gajim.pot - po/gl.po - po/he.po - po/hr.po - po/hu.po - po/it.po - po/ja.po - po/kk.po - po/ko.po - po/lt.po - po/nb_NO.po - po/nl.po - po/pl.po The diff was not included because it is too large. View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/7d8e24a618fa9bbe3ab18c8ef82f9de9… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/7d8e24a618fa9bbe3ab18c8ef82f9de9… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix: Migration: Don’t fail on color setting migration
by Philipp Hörist (＠lovetox) 11 Mar '23

11 Mar '23

Philipp Hörist pushed to branch master at gajim / gajim Commits: 44cbd2ff by Philipp Hörist at 2023-03-11T19:55:05+01:00 fix: Migration: Don’t fail on color setting migration Fixes #11426 - - - - - 1 changed file: - gajim/common/optparser.py Changes: ===================================== gajim/common/optparser.py ===================================== @@ -219,7 +219,7 @@ def update_config_to_1195(self): account_string = '%s@%s' % (username, domain) # We cannot get the preferred theme at this point background = (1, 1, 1) - col_r, col_g, col_b = text_to_color(account_string, background) + col_r, col_g, col_b = text_to_color(account_string, 100, 40) rgba = Gdk.RGBA(red=col_r, green=col_g, blue=col_b) color = rgba.to_string() app.config.set_per('accounts', account, 'account_color', color) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/44cbd2ffa469f9f3c2ba0b51fc4aa5c4… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/44cbd2ffa469f9f3c2ba0b51fc4aa5c4… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix: HTTPUpload: Respect infinite file size limit
by Philipp Hörist (＠lovetox) 11 Mar '23

11 Mar '23

Philipp Hörist pushed to branch master at gajim / gajim Commits: f9058e21 by Philipp Hörist at 2023-03-11T19:48:30+01:00 fix: HTTPUpload: Respect infinite file size limit Fixes #11436 - - - - - 1 changed file: - gajim/gtk/file_transfer_selector.py Changes: ===================================== gajim/gtk/file_transfer_selector.py ===================================== @@ -66,7 +66,7 @@ def __init__(self, self._method = method or app.window.get_preferred_ft_method(contact) client = app.get_client(contact.account) - self._max_file_size = client.get_module('HTTPUpload').max_file_size or 0 + self._max_http_file_size = client.get_module('HTTPUpload').max_file_size self._ui = get_builder('file_transfer_selector.ui') self.add(self._ui.stack) @@ -104,6 +104,11 @@ def __init__(self, self.show_all() + def _is_over_max_http_file_size(self, path: Path) -> bool: + if self._max_http_file_size is None: + return False + return path.stat().st_size > self._max_http_file_size + def transfer_resource_required(self) -> bool: if not isinstance(self._contact, BareContact): # No jingle file transfer for group chats @@ -116,7 +121,7 @@ def transfer_resource_required(self) -> bool: current_page = self._ui.stack.get_visible_child_name() if self._method == 'httpupload': for path in self._get_file_paths(): - if path.stat().st_size > self._max_file_size: + if self._is_over_max_http_file_size(path): if current_page == 'resource-selection': return False @@ -139,7 +144,7 @@ def get_catalog(self) -> list[tuple[Path, str, JID]]: file_paths = self._get_file_paths() for path in file_paths: if (self._method == 'jingle' or - path.stat().st_size > self._max_file_size): + self._is_over_max_http_file_size(path)): assert self._resource_selector is not None item = (path, 'jingle', self._resource_selector.get_jid()) elif self._method == 'httpupload': @@ -162,7 +167,7 @@ def add_files(self, uris: list[str]) -> None: continue size_warning = bool(self._method == 'httpupload' and - path.stat().st_size > self._max_file_size) + self._is_over_max_http_file_size(path)) jingle_warning = bool(self._method == 'jingle') row = FileRow(path, size_warning, jingle_warning) @@ -208,7 +213,7 @@ def _on_files_changed(self, _listbox: Gtk.ListBox, _row: FileRow) -> None: if self._method == 'httpupload' and self._contact.is_groupchat: # Enforce HTTPUpload file size limit for group chats for path in file_paths: - if path.stat().st_size > self._max_file_size: + if self._is_over_max_http_file_size(path): self.emit('changed', False) return View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/f9058e21a2c79ac202cc770b754bbfe8… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/f9058e21a2c79ac202cc770b754bbfe8… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix: Chatstates: Remove composing timeout correctly
by Philipp Hörist (＠lovetox) 11 Mar '23

11 Mar '23

Philipp Hörist pushed to branch master at gajim / gajim Commits: 67443ab9 by Nicoco at 2023-03-11T18:33:40+00:00 fix: Chatstates: Remove composing timeout correctly - - - - - 1 changed file: - gajim/common/modules/chatstates.py Changes: ===================================== gajim/common/modules/chatstates.py ===================================== @@ -196,7 +196,8 @@ def _on_remote_composing_timeout(self, contact: types.ContactT): contact.notify('chatstate-update') def _remove_remote_composing_timeout(self, contact: types.ContactT): - source_id = self._delay_timeout_ids.pop(contact.jid, None) + source_id = self._remote_chatstate_composing_timeouts.pop( + contact.jid, None) if source_id is not None: self._log.debug('Removing remote composing timeout of %s', contact) GLib.source_remove(source_id) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/67443ab934b47961e0f0ea876a2d1720… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/67443ab934b47961e0f0ea876a2d1720… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] cfix: Update links to GNOME Gtk and GLib repo
by Daniel Brötzmann (＠wurstsalat) 10 Mar '23

10 Mar '23

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 73e3ee88 by mesonium at 2023-03-09T15:03:07-05:00 cfix: Update links to GNOME Gtk and GLib repo - - - - - 1 changed file: - README.md Changes: ===================================== README.md ===================================== @@ -16,8 +16,8 @@ ### Runtime Requirements - [packaging](https://pypi.org/project/packaging/) - [Pillow](https://pypi.org/project/Pillow/) - [setuptools](https://pypi.org/project/setuptools/) (>=65.0.0) -- [Gtk3](https://gitlab.com/gnome/gtk) (>=3.24.30) -- [GLib](https://gitlab.com/gnome/glib) (>=2.60.0) +- [Gtk3](https://gitlab.gnome.org/GNOME/gtk) (>=3.24.30) +- [GLib](https://gitlab.gnome.org/GNOME/glib) (>=2.60.0) - [GtkSourceView](https://gitlab.gnome.org/GNOME/gtksourceview) - [Pango](https://gitlab.gnome.org/GNOME/pango) (>=1.50.0) - [sqlite](https://www.sqlite.org/) (>=3.33.0) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/73e3ee8818c8c24249a2760eb0440d39… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/73e3ee8818c8c24249a2760eb0440d39… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix: Show chat notifications when chat page is not visible
by Philipp Hörist (＠lovetox) 09 Mar '23

09 Mar '23

Philipp Hörist pushed to branch master at gajim / gajim Commits: 526782cc by wurstsalat at 2023-03-09T19:07:36+00:00 fix: Show chat notifications when chat page is not visible Fixes #11416 - - - - - 2 changed files: - gajim/gtk/main.py - gajim/gtk/main_stack.py Changes: ===================================== gajim/gtk/main.py ===================================== @@ -761,6 +761,8 @@ def get_active_workspace(self) -> Optional[str]: def is_chat_active(self, account: str, jid: JID) -> bool: if not self.has_toplevel_focus(): return False + if self._main_stack.get_visible_page_name() != 'chats': + return False return self._chat_page.is_chat_selected(account, jid) def highlight_dnd_targets(self, drag_row: Any, highlight: bool) -> None: ===================================== gajim/gtk/main_stack.py ===================================== @@ -14,6 +14,7 @@ from __future__ import annotations +from typing import Optional from typing import Union from gi.repository import Gtk @@ -56,6 +57,9 @@ def remove_account_page(self, account: str) -> None: def remove_chats_for_account(self, account: str) -> None: self._chat_page.remove_chats_for_account(account) + def get_visible_page_name(self) -> Optional[str]: + return self.get_visible_child_name() + def show_app_page(self) -> None: self.set_visible_child_name('app') View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/526782cc05c7e946afa3a6ee36add654… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/526782cc05c7e946afa3a6ee36add654… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix: Don't fail if contact name for MUC message is None
by Philipp Hörist (＠lovetox) 09 Mar '23

09 Mar '23

Philipp Hörist pushed to branch master at gajim / gajim Commits: bc14c535 by wurstsalat at 2023-03-09T18:59:28+00:00 fix: Don't fail if contact name for MUC message is None Fixes #11417 - - - - - 2 changed files: - gajim/common/storage/archive.py - gajim/gtk/control.py Changes: ===================================== gajim/common/storage/archive.py ===================================== @@ -100,7 +100,7 @@ class JidsTableRow(NamedTuple): class ConversationRow(NamedTuple): - contact_name: str + contact_name: str | None time: float kind: int show: int ===================================== gajim/gtk/control.py ===================================== @@ -730,6 +730,10 @@ def add_messages(self, messages: list[ConversationRow]): contact_name = self.contact.name elif msg.kind == KindConstant.GC_MSG: kind = 'incoming' + if contact_name is None: + # Fall back to MUC name if contact name is None + # (may be the case for service messages from the MUC) + contact_name = self.contact.name elif msg.kind in ( KindConstant.SINGLE_MSG_SENT, KindConstant.CHAT_MSG_SENT): kind = 'outgoing' @@ -738,6 +742,8 @@ def add_messages(self, messages: list[ConversationRow]): log.warning('kind attribute could not be processed' 'while adding message') + assert contact_name is not None + if msg.additional_data is not None: retracted_by = msg.additional_data.get_value('retracted', 'by') if retracted_by is not None: View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/bc14c535134510e0bd382314188b0b9c… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/bc14c535134510e0bd382314188b0b9c… You're receiving this email because of your account on dev.gajim.org.

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits March 2023