Commits October 2022

commits@gajim.org

1 participants
208 discussions

[Git][gajim/gajim][master] 3 commits: chore: Add pyproject.toml
by Philipp Hörist (＠lovetox) 28 Oct '22

28 Oct '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: 2ba08b7f by Philipp Hörist at 2022-10-28T13:32:05+02:00 chore: Add pyproject.toml - - - - - 0642e9ec by Philipp Hörist at 2022-10-28T13:54:00+02:00 cq: Fix typos - - - - - 2a4a9924 by Philipp Hörist at 2022-10-28T13:54:50+02:00 ci: Move codespell config into pyproject.toml - - - - - 8 changed files: - .gitlab-ci.yml - − codespell.conf - gajim/common/file_props.py - gajim/common/jingle_ft.py - gajim/gtk/conversation/rows/file_transfer_jingle.py - gajim/gtk/filetransfer.py - gajim/gtk/tooltips.py - + pyproject.toml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -14,7 +14,7 @@ stages: test-other: stage: test script: - - codespell -I codespell.conf --skip="*__pycache__*,gajim/data/icons,gajim/data/sounds,gajim/data/emoticons" gajim + - codespell gajim - python3 setup.py build - appstream-util validate build/data/org.gajim.Gajim.appdata.xml interruptible: true ===================================== codespell.conf deleted ===================================== @@ -1,9 +0,0 @@ -claus -files' -pres -ser -tim -transfered -wanna -wth -trough ===================================== gajim/common/file_props.py ===================================== @@ -112,7 +112,7 @@ def __init__(self, account: str, sid: str) -> None: # Do not instantiate this class directly! # Call FilesProp.getNeFileProp instead self.streamhosts = [] - self.transfered_size: list[tuple[float, int]] = [] + self.transferred_size: list[tuple[float, int]] = [] self.started: bool = False self.completed: bool = False self.paused: bool = False ===================================== gajim/common/jingle_ft.py ===================================== @@ -123,7 +123,7 @@ def __init__(self, self.file_props.receiver = self.session.peerjid self.file_props.session_type = 'jingle' self.file_props.sid = session.sid - self.file_props.transfered_size = [] + self.file_props.transferred_size = [] self.file_props.transport_sid = self.transport.sid self.session = session @@ -262,7 +262,7 @@ def _raise_event(self, file_desc_tag = file_tag.getTag('desc') if file_desc_tag is not None: file_props.desc = file_desc_tag.getData() - file_props.transfered_size = [] + file_props.transferred_size = [] app.ged.raise_event(FileRequestReceivedEvent( conn=con, ===================================== gajim/gtk/conversation/rows/file_transfer_jingle.py ===================================== @@ -284,9 +284,9 @@ def _update_progress(self, file_props: FileProp) -> None: if self._start_time == 0: self._start_time = time_now return - if not file_props.transfered_size: + if not file_props.transferred_size: return - transferred_size = file_props.transfered_size[-1][1] + transferred_size = file_props.transferred_size[-1][1] else: # We're receiving a file transferred_size = file_props.received_len ===================================== gajim/gtk/filetransfer.py ===================================== @@ -571,27 +571,27 @@ def _format_percent(self, percent): _str += str(percent) + '% \n' return _str - def _get_eta_and_speed(self, full_size, transfered_size, file_props): - if not file_props.transfered_size: + def _get_eta_and_speed(self, full_size, transferred_size, file_props): + if not file_props.transferred_size: return 0., 0. if file_props.elapsed_time == 0: return 0., 0. - if len(file_props.transfered_size) == 1: - speed = round(float(transfered_size) / file_props.elapsed_time) + if len(file_props.transferred_size) == 1: + speed = round(float(transferred_size) / file_props.elapsed_time) else: - # first and last are (time, transfered_size) - first = file_props.transfered_size[0] - last = file_props.transfered_size[-1] - transfered = last[1] - first[1] + # first and last are (time, transferred_size) + first = file_props.transferred_size[0] + last = file_props.transferred_size[-1] + transferred = last[1] - first[1] tim = last[0] - first[0] if tim == 0: return 0., 0. - speed = round(float(transfered) / tim) + speed = round(float(transferred) / tim) if speed == 0.: return 0., 0. - remaining_size = full_size - transfered_size + remaining_size = full_size - transferred_size eta = remaining_size / speed return eta, speed @@ -616,9 +616,9 @@ def _file_progress(self, event): event.file_props.sid, event.file_props.received_len) - def set_progress(self, typ, sid, transfered_size, iter_=None): + def set_progress(self, typ, sid, transferred_size, iter_=None): ''' - Change the progress of a transfer with new transfered size + Change the progress of a transfer with new transferred size ''' if time.time() - self._last_progress_update < 0.5: # Update window every 500ms only @@ -633,7 +633,7 @@ def set_progress(self, typ, sid, transfered_size, iter_=None): if full_size == 0: percent = 0 else: - percent = round(float(transfered_size) / full_size * 100, 1) + percent = round(float(transferred_size) / full_size * 100, 1) if iter_ is None: iter_ = self.get_iter_by_sid(typ, sid) if iter_ is not None: @@ -641,24 +641,24 @@ def set_progress(self, typ, sid, transfered_size, iter_=None): if self.model[iter_][Column.PERCENT] == 0 and int(percent > 0): just_began = True text = self._format_percent(percent) - if transfered_size == 0: + if transferred_size == 0: text += '0' else: - text += GLib.format_size_full(transfered_size, self.units) + text += GLib.format_size_full(transferred_size, self.units) text += '/' + GLib.format_size_full(full_size, self.units) # Kb/s # remaining time if file_props.offset: - transfered_size -= file_props.offset + transferred_size -= file_props.offset full_size -= file_props.offset if file_props.elapsed_time > 0: - file_props.transfered_size.append((file_props.last_time, - transfered_size)) - if len(file_props.transfered_size) > 6: - file_props.transfered_size.pop(0) - eta, speed = self._get_eta_and_speed(full_size, transfered_size, + file_props.transferred_size.append((file_props.last_time, + transferred_size)) + if len(file_props.transferred_size) > 6: + file_props.transferred_size.pop(0) + eta, speed = self._get_eta_and_speed(full_size, transferred_size, file_props) self.model.set(iter_, Column.PROGRESS, text) @@ -684,7 +684,7 @@ def set_progress(self, typ, sid, transfered_size, iter_=None): if file_props.connected is False: status = 'stop' self.model.set(iter_, 0, self.icons[status]) - if transfered_size == full_size: + if transferred_size == full_size: # If we are receiver and this is a jingle session if (file_props.type_ == 'r' and file_props.session_type == 'jingle' and @@ -923,7 +923,7 @@ def _on_pause_resume_button_clicked(self, widget): file_props.paused = True self.set_status(file_props, 'pause') # Reset that to compute speed only when we resume - file_props.transfered_size = [] + file_props.transferred_size = [] self._toggle_pause_continue(False) def _on_cancel_button_clicked(self, widget): ===================================== gajim/gtk/tooltips.py ===================================== @@ -329,11 +329,11 @@ def _create_tooltip(self, file_prop: FileProp, _sid: str) -> Gtk.Grid: properties.append((Q_('?transfer type:Type: '), type_)) properties.append((actor, GLib.markup_escape_text(name))) - transfered_len = file_prop.received_len - if not transfered_len: - transfered_len = 0 + transferred_len = file_prop.received_len + if not transferred_len: + transferred_len = 0 properties.append((Q_('?transfer status:Transferred: '), - GLib.format_size_full(transfered_len, self.units))) + GLib.format_size_full(transferred_len, self.units))) status = self._get_current_status(file_prop) properties.append((Q_('?transfer status:Status: '), status)) file_desc = file_prop.desc or '' ===================================== pyproject.toml ===================================== @@ -0,0 +1,10 @@ +[build-system] +requires = [ + "setuptools >= 43.0.0", +] +build-backend = "setuptools.build_meta" + + +[tool.codespell] +skip = "*__pycache__*,gajim/gui,gajim/data/icons,gajim/data/sounds,gajim/data/emoticons" +ignore-words-list = "claus,pres,ser,trough" View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/362bd0e97ef106afdc4eeca1338b5de… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/362bd0e97ef106afdc4eeca1338b5de… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] cq: Fix typo
by Philipp Hörist (＠lovetox) 28 Oct '22

28 Oct '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: 362bd0e9 by Philipp Hörist at 2022-10-28T13:22:46+02:00 cq: Fix typo - - - - - 1 changed file: - gajim/common/const.py Changes: ===================================== gajim/common/const.py ===================================== @@ -768,7 +768,7 @@ class CallType(Enum): 'uz-UZ': 'Uzbek (Latin) (Uzbekistan)', 'uz-Cyrl-UZ': 'Uzbek (Cyrillic) (Uzbekistan)', 'vi': 'Vietnamese', - 'vi-VN': 'Vietnamese (Viet Nam)', + 'vi-VN': 'Vietnamese (Vietnam)', 'xh': 'Xhosa', 'xh-ZA': 'Xhosa (South Africa)', 'zh': 'Chinese', View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/362bd0e97ef106afdc4eeca1338b5ded… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/362bd0e97ef106afdc4eeca1338b5ded… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] imprv: Preferences: Add send_on_ctrl_enter setting
by Daniel Brötzmann (＠wurstsalat) 27 Oct '22

27 Oct '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 9b63a7b5 by wurstsalat at 2022-10-27T23:31:18+02:00 imprv: Preferences: Add send_on_ctrl_enter setting Since this setting is opaque now, automatically setting it when changing show_send_message_button should not be necessary anymore. Fixes #11242 - - - - - 1 changed file: - gajim/gtk/preferences.py Changes: ===================================== gajim/gtk/preferences.py ===================================== @@ -277,8 +277,12 @@ def __init__(self, *args: Any) -> None: Setting(SettingKind.SWITCH, _('Show Send Message Button'), SettingType.CONFIG, - 'show_send_message_button', - callback=self._on_show_send_message_button), + 'show_send_message_button'), + + Setting(SettingKind.SWITCH, + _('Send Messages with Control+Enter'), + SettingType.CONFIG, + 'send_on_ctrl_enter'), Setting(SettingKind.SWITCH, _('Spell Checking'), @@ -300,12 +304,6 @@ def __init__(self, *args: Any) -> None: def _speller_available() -> bool: return app.is_installed('GSPELL') - @staticmethod - def _on_show_send_message_button(show_button: bool, *args: Any) -> None: - # Bind to send_on_ctrl_enter to make this setting user-friendly - # This way, users can press Enter to insert a new line, then click Send - app.settings.set('send_on_ctrl_enter', show_button) - class Chats(PreferenceBox): def __init__(self, *args: Any) -> None: View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/9b63a7b5720b60f32956aa317fcd2cce… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/9b63a7b5720b60f32956aa317fcd2cce… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix: Fix quoting /me messages
by Daniel Brötzmann (＠wurstsalat) 27 Oct '22

27 Oct '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: ff41271a by wurstsalat at 2022-10-27T23:18:52+02:00 fix: Fix quoting /me messages Fixes #11224 - - - - - 1 changed file: - gajim/gtk/conversation/message_widget.py Changes: ===================================== gajim/gtk/conversation/message_widget.py ===================================== @@ -41,12 +41,15 @@ def __init__(self, account: str, selectable: bool = True) -> None: self._selectable = selectable self._content = cast(ContentT, None) + self._action_phrase_text = '' def get_content(self) -> ContentT: return self._content def get_text(self) -> str: - return self._content.text + if self._content is not None: + return self._content.text + return self._action_phrase_text def add_with_styling(self, text: str, @@ -66,6 +69,8 @@ def _add_action_phrase(self, text: str, nickname: str): widget.show_all() self.add(widget) + self._action_phrase_text = text.replace('/me', f'* {nickname}', 1) + def add_content(self, content: ContentT) -> None: self.clear() self._content = content View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/ff41271a771b16ce39ae68b7bbac56bc… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/ff41271a771b16ce39ae68b7bbac56bc… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix: StartChat: Don’t use jid argument for global dialog
by Philipp Hörist (＠lovetox) 27 Oct '22

27 Oct '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: a3d17c6d by Philipp Hörist at 2022-10-27T22:40:32+02:00 fix: StartChat: Don’t use jid argument for global dialog The jid attribute indicates that this is a dialog which can be opened per jid, which we dont want here. - - - - - 2 changed files: - gajim/gtk/application.py - gajim/gtk/start_chat.py Changes: ===================================== gajim/gtk/application.py ===================================== @@ -630,7 +630,7 @@ def _on_new_chat_action(_action: Gio.SimpleAction, jid, initial_message = param.get_strv() open_window('StartChatDialog', - jid=jid or None, + initial_jid=jid or None, initial_message=initial_message or None) @staticmethod @@ -740,7 +740,7 @@ def _on_join_support_chat(_action: Gio.SimpleAction, app.interface.show_add_join_groupchat( accounts[0], GAJIM_SUPPORT_JID) return - open_window('StartChatDialog', jid=GAJIM_SUPPORT_JID) + open_window('StartChatDialog', initial_jid=GAJIM_SUPPORT_JID) @staticmethod def _on_faq_action(_action: Gio.SimpleAction, ===================================== gajim/gtk/start_chat.py ===================================== @@ -69,7 +69,7 @@ class Search(IntEnum): class StartChatDialog(Gtk.ApplicationWindow): def __init__(self, - jid: Optional[str] = None, + initial_jid: Optional[str] = None, initial_message: Optional[str] = None ) -> None: @@ -143,9 +143,9 @@ def __init__(self, self._load_contacts(rows) self._initial_message: dict[str, Optional[str]] = {} - if jid is not None: - self._initial_message[jid] = initial_message - self._ui.search_entry.set_text(jid) + if initial_jid is not None: + self._initial_message[initial_jid] = initial_message + self._ui.search_entry.set_text(initial_jid) self.select_first_row() self._ui.connect_signals(self) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/a3d17c6d23b936aed077ce9a63350115… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/a3d17c6d23b936aed077ce9a63350115… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] imprv: Add actions menu to Start Chat button
by Daniel Brötzmann (＠wurstsalat) 27 Oct '22

27 Oct '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: 8e9e7be7 by wurstsalat at 2022-10-27T22:15:58+02:00 imprv: Add actions menu to Start Chat button This allows for quick access of - Start Chat - Create Group Chat - Add Contact Fixes #11241 - - - - - 3 changed files: - gajim/data/gui/chat_paned.ui - gajim/gtk/builder.pyi - gajim/gtk/chat_page.py Changes: ===================================== gajim/data/gui/chat_paned.ui ===================================== @@ -1,5 +1,5 @@ <?xml version="1.0" encoding="UTF-8"?> - + <interface> <requires lib="gtk+" version="3.24"/> <object class="GtkPaned" id="paned"> @@ -129,11 +129,12 @@ </packing> </child> <child> - <object class="GtkButton" id="start_chat_button"> + <object class="GtkMenuButton" id="start_chat_menu_button"> <property name="visible">True</property> <property name="can-focus">True</property> + <property name="focus-on-click">False</property> <property name="receives-default">True</property> - <property name="tooltip-text" translatable="yes">Start Chat</property> + <property name="tooltip-text" translatable="yes">Start Chat…</property> <child> <object class="GtkImage"> <property name="visible">True</property> @@ -141,11 +142,14 @@ <property name="icon-name">list-add-symbolic</property> </object> </child> + <style> + <class name="suggested-action"/> + </style> </object> <packing> <property name="expand">False</property> <property name="fill">True</property> - <property name="position">1</property> + <property name="position">2</property> </packing> </child> </object> ===================================== gajim/gtk/builder.pyi ===================================== @@ -238,7 +238,7 @@ class ChatPanedBuilder(Builder): workspace_label: Gtk.Label filter_bar_toggle: Gtk.ToggleButton search_entry: Gtk.SearchEntry - start_chat_button: Gtk.Button + start_chat_menu_button: Gtk.MenuButton filter_bar_revealer: Gtk.Revealer filter_bar: Gtk.Box chat_list_scrolled: Gtk.ScrolledWindow ===================================== gajim/gtk/chat_page.py ===================================== @@ -30,6 +30,7 @@ from nbxmpp import JID from gajim.common import app +from gajim.common.i18n import _ from .builder import get_builder from .chat_filter import ChatFilter @@ -41,9 +42,14 @@ if TYPE_CHECKING: from .control import ChatControl - log = logging.getLogger('gajim.gui.chat_page') +START_CHAT_MENU_DICT = { + 'start-chat(["", ""])': _('Start Chat…'), + 'create-groupchat::': _('Create Group Chat…'), + 'add-contact::': _('Add Contact…'), +} + class ChatPage(Gtk.Box): @@ -91,8 +97,10 @@ def __init__(self): self._on_chat_list_changed) self._ui.chat_list_scrolled.add(self._chat_list_stack) - self._ui.start_chat_button.connect('clicked', - self._on_start_chat_clicked) + start_chat_menu = Gio.Menu() + for action, label in START_CHAT_MENU_DICT.items(): + start_chat_menu.append(label, f'app.{action}') + self._ui.start_chat_menu_button.set_menu_model(start_chat_menu) self._ui.paned.set_position(app.settings.get('chat_handle_position')) self._ui.paned.connect('button-release-event', self._on_button_release) @@ -127,10 +135,6 @@ def get_chat_list_stack(self) -> ChatListStack: def get_chat_stack(self) -> ChatStack: return self._chat_stack - @staticmethod - def _on_start_chat_clicked(_button: Gtk.Button) -> None: - app.app.activate_action('start-chat', GLib.Variant('as', ['', ''])) - @staticmethod def _on_button_release(paned: Gtk.Paned, event: Gdk.EventButton) -> None: if event.window != paned.get_handle_window(): View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/8e9e7be7c22e0a8f884a32736cb57551… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/8e9e7be7c22e0a8f884a32736cb57551… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix: Try leaving group chat only if account is online
by Daniel Brötzmann (＠wurstsalat) 27 Oct '22

27 Oct '22

Daniel Brötzmann pushed to branch master at gajim / gajim Commits: c5eafea2 by wurstsalat at 2022-10-27T20:24:53+02:00 fix: Try leaving group chat only if account is online Fixes #11247 - - - - - 1 changed file: - gajim/gtk/chat_page.py Changes: ===================================== gajim/gtk/chat_page.py ===================================== @@ -317,7 +317,7 @@ def _on_chat_removed(self, if self._chat_control.is_loaded(account, jid): self._chat_control.clear() - if type_ == 'groupchat': + if type_ == 'groupchat' and app.account_is_connected(account): client = app.get_client(account) client.get_module('MUC').leave(jid) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/c5eafea2c3cb3068d522919ee87d20a2… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/c5eafea2c3cb3068d522919ee87d20a2… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix: AccountPage: Disable profile button when not connected
by Philipp Hörist (＠lovetox) 27 Oct '22

27 Oct '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: ed4c9823 by Philipp Hörist at 2022-10-27T19:58:47+02:00 fix: AccountPage: Disable profile button when not connected Fixes #11249 - - - - - 3 changed files: - gajim/data/gui/account_page.ui - gajim/gtk/account_page.py - gajim/gtk/builder.pyi Changes: ===================================== gajim/data/gui/account_page.ui ===================================== @@ -154,14 +154,13 @@ </packing> </child> <child type="overlay"> - <object class="GtkButton"> + <object class="GtkButton" id='edit_profile_button'> <property name="visible">True</property> <property name="can-focus">True</property> <property name="receives-default">True</property> <property name="tooltip-text" translatable="yes">Edit Profile…</property> <property name="halign">end</property> <property name="valign">start</property> - <signal name="clicked" handler="_on_edit_profile" swapped="no"/> <child> <object class="GtkImage"> <property name="visible">True</property> ===================================== gajim/gtk/account_page.py ===================================== @@ -19,6 +19,7 @@ from gi.repository import Gdk from gi.repository import Gio +from gi.repository import GLib from gi.repository import Gtk from nbxmpp.protocol import JID @@ -85,6 +86,11 @@ def __init__(self, account: str) -> None: roster_menu.append(label, f'win.{action}') self._ui.roster_menu_button.set_menu_model(roster_menu) + self._ui.edit_profile_button.set_action_name( + f'app.{self._account}-profile') + self._ui.edit_profile_button.set_action_target_value( + GLib.Variant('s', self._account)) + self._ui.connect_signals(self) app.settings.connect_signal( @@ -117,9 +123,6 @@ def _on_account_label_changed(self, value: str, *args: Any) -> None: def _on_avatar_update(self, *args: Any) -> None: self.update() - def _on_edit_profile(self, _button: Gtk.Button) -> None: - open_window('ProfileWindow', account=self._account) - def _on_account_settings(self, _button: Gtk.Button) -> None: window = open_window('AccountsWindow') window.select_account(self._account) ===================================== gajim/gtk/builder.pyi ===================================== @@ -16,6 +16,7 @@ class AccountPageBuilder(Builder): roster_search_entry: Gtk.SearchEntry account_box: Gtk.Box avatar_image: Gtk.Image + edit_profile_button: Gtk.Button account_label: Gtk.Label account_action_box: Gtk.Box adhoc_commands_button: Gtk.Button View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/ed4c9823085b209efbad9ebc4fd68951… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/ed4c9823085b209efbad9ebc4fd68951… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] cq: Remove unused import
by Philipp Hörist (＠lovetox) 26 Oct '22

26 Oct '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: 3720fff8 by Philipp Hörist at 2022-10-26T21:37:38+02:00 cq: Remove unused import - - - - - 1 changed file: - gajim/gtk/groupchat_manage.py Changes: ===================================== gajim/gtk/groupchat_manage.py ===================================== @@ -12,7 +12,6 @@ # along with Gajim. If not, see <http://www.gnu.org/licenses/>. from typing import Any -from typing import Optional import logging View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/3720fff826acbc0d4c7cf8dee54048b5… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/3720fff826acbc0d4c7cf8dee54048b5… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] imprv: ExceptionDialog: Close dialog with ESC
by Philipp Hörist (＠lovetox) 26 Oct '22

26 Oct '22

Philipp Hörist pushed to branch master at gajim / gajim Commits: 241206c5 by Philipp Hörist at 2022-10-26T21:36:20+02:00 imprv: ExceptionDialog: Close dialog with ESC - - - - - 1 changed file: - gajim/gtk/exception.py Changes: ===================================== gajim/gtk/exception.py ===================================== @@ -126,12 +126,17 @@ def __init__(self, buffer_ = self._ui.exception_view.get_buffer() buffer_.set_text(self._issue_text) + self.connect('key-press-event', self._on_key_press) self._ui.connect_signals(self) self.show_all() if self._sentry_available: self._ui.user_feedback_entry.grab_focus() + def _on_key_press(self, _widget: Gtk.Widget, event: Gdk.EventKey) -> None: + if event.keyval == Gdk.KEY_Escape: + self.destroy() + def _on_report_clicked(self, _button: Gtk.Button) -> None: if self._sentry_available and determine_proxy() is not None: # sentry-sdk supports a http-proxy arg but for now only use View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/241206c5a0effbe5065dc0acb26adb30… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/241206c5a0effbe5065dc0acb26adb30… You're receiving this email because of your account on dev.gajim.org.

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
21
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits October 2022