Commits March 2020

commits@gajim.org

1 participants
104 discussions

[Git][gajim/gajim][master] Jingle: Only log to file if DEBUG is enabled
by Philipp Hörist 17 Mar '20

17 Mar '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 68520fe2 by lovetox at 2020-03-17T20:20:28+01:00 Jingle: Only log to file if DEBUG is enabled - - - - - 1 changed file: - gajim/common/jingle_rtp.py Changes: ===================================== gajim/common/jingle_rtp.py ===================================== @@ -448,7 +448,9 @@ class JingleVideo(JingleRTPContent): # The following is needed for farstream to process ICE requests: self.pipeline.set_state(Gst.State.PLAYING) - Gst.debug_bin_to_dot_file(self.pipeline, Gst.DebugGraphDetails.ALL, 'video-graph') + + if log.getEffectiveLevel() == logging.DEBUG: + Gst.debug_bin_to_dot_file(self.pipeline, Gst.DebugGraphDetails.ALL, 'video-graph') def get_fallback_src(self): # TODO: Use avatar? View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/68520fe2728fee26207ee2cf62e02f56… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/68520fe2728fee26207ee2cf62e02f56… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: ChatControl: Remove all getattr() and setattr()
by Philipp Hörist 17 Mar '20

17 Mar '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 5777b429 by Emmanuel Gil Peyrot at 2020-03-17T19:32:39+01:00 ChatControl: Remove all getattr() and setattr() These were due to Jingle properties existing for both audio and video, replace them with the obvious dict solution. - - - - - 3c85325c by Emmanuel Gil Peyrot at 2020-03-17T19:33:00+01:00 Jingle video: Replace X11 specifics with GTK+ This uses the same mechanism originally added for preferences, so that video display is handled by a GTK+ widget instead of some X11 dark magic. This makes the self video display properly (!) during a Jingle call, but still with random freezes and no remote video being displayed, those fixes will be for a latter commit. - - - - - 8 changed files: - gajim/chat_control.py - gajim/common/jingle_rtp.py - gajim/common/modules/jingle.py - gajim/data/gui/chat_control.ui - gajim/dialogs.py - + gajim/gtk/gstreamer.py - gajim/gtk/preferences.py - gajim/gui_interface.py Changes: ===================================== gajim/chat_control.py ===================================== @@ -79,6 +79,20 @@ from gajim.command_system.implementation.hosts import ChatCommands from gajim.command_system.framework import CommandHost # pylint: disable=unused-import from gajim.chat_control_base import ChatControlBase + +class JingleState: + __slots__ = ('sid', 'state', 'available', 'banner_image', 'action', 'set_state', 'update') + + def __init__(self, state, banner_image, set_state, update): + self.sid = None + self.state = state + self.available = False + self.banner_image = banner_image + self.action = None + self.set_state = set_state + self.update = update + + ################################################################################ class ChatControl(ChatControlBase): """ @@ -126,12 +140,10 @@ class ChatControl(ChatControlBase): # Settings menu self.xml.settings_menu.set_menu_model(self.control_menu) - self.audio_sid = None - self.audio_state = self.JINGLE_STATE_NULL - self.audio_available = False - self.video_sid = None - self.video_state = self.JINGLE_STATE_NULL - self.video_available = False + self.jingle = { + 'audio': JingleState(self.JINGLE_STATE_NULL, self.xml.audio_banner_image, self.set_audio_state, self.update_audio), + 'video': JingleState(self.JINGLE_STATE_NULL, self.xml.video_banner_image, self.set_video_state, self.update_video), + } self.update_toolbar() self.update_all_pep_types() @@ -254,17 +266,19 @@ class ChatControl(ChatControlBase): act.connect("activate", func) self.parent_win.window.add_action(act) - self.audio_action = Gio.SimpleAction.new_stateful( + audio = self.jingle['audio'] + audio.action = Gio.SimpleAction.new_stateful( 'toggle-audio-' + self.control_id, None, GLib.Variant.new_boolean(False)) - self.audio_action.connect('change-state', self._on_audio) - self.parent_win.window.add_action(self.audio_action) + audio.action.connect('change-state', self._on_audio) + self.parent_win.window.add_action(audio.action) - self.video_action = Gio.SimpleAction.new_stateful( + video = self.jingle['video'] + video.action = Gio.SimpleAction.new_stateful( 'toggle-video-' + self.control_id, None, GLib.Variant.new_boolean(False)) - self.video_action.connect('change-state', self._on_video) - self.parent_win.window.add_action(self.video_action) + video.action.connect('change-state', self._on_video) + self.parent_win.window.add_action(video.action) default_chatstate = app.config.get('send_chatstate_default') chatstate = app.config.get_per( @@ -294,11 +308,11 @@ class ChatControl(ChatControlBase): # Audio win.lookup_action('toggle-audio-' + self.control_id).set_enabled( - online and self.audio_available) + online and self.jingle['audio'].available) # Video win.lookup_action('toggle-video-' + self.control_id).set_enabled( - online and self.video_available) + online and self.jingle['video'].available) # Send file (HTTP File Upload) httpupload = win.lookup_action( @@ -419,15 +433,17 @@ class ChatControl(ChatControlBase): _('This contact does not support HTML')) # Jingle detection + jingle_audio = self.jingle['audio'] + jingle_video = self.jingle['video'] if self.contact.supports(NS_JINGLE_ICE_UDP) and \ app.is_installed('FARSTREAM') and self.contact.resource: - self.audio_available = self.contact.supports(NS_JINGLE_RTP_AUDIO) - self.video_available = self.contact.supports(NS_JINGLE_RTP_VIDEO) + jingle_audio.available = self.contact.supports(NS_JINGLE_RTP_AUDIO) + jingle_video.available = self.contact.supports(NS_JINGLE_RTP_VIDEO) else: - if self.video_available or self.audio_available: + if jingle_video.available or jingle_audio.available: self.stop_jingle() - self.video_available = False - self.audio_available = False + jingle_video.available = False + jingle_audio.available = False def update_all_pep_types(self): self._update_pep(PEPEventType.LOCATION) @@ -630,11 +646,10 @@ class ChatControl(ChatControlBase): elif event.name == 'ping-error': self.add_info_message(_('Error.')) - def _update_jingle(self, jingle_type): - if jingle_type not in ('audio', 'video'): - return - banner_image = getattr(self, '_' + jingle_type + '_banner_image') - state = getattr(self, jingle_type + '_state') + def _update_jingle(self, jingle_type: str) -> None: + jingle = self.jingle[jingle_type] + banner_image = jingle.banner_image + state = jingle.state if state == self.JINGLE_STATE_NULL: banner_image.hide() else: @@ -656,7 +671,7 @@ class ChatControl(ChatControlBase): def update_audio(self): self._update_jingle('audio') hbox = self.xml.audio_buttons_hbox - if self.audio_state == self.JINGLE_STATE_CONNECTED: + if self.jingle['audio'].state == self.JINGLE_STATE_CONNECTED: # Set volume from config input_vol = app.config.get('audio_input_volume') output_vol = app.config.get('audio_output_volume') @@ -667,7 +682,7 @@ class ChatControl(ChatControlBase): # Show vbox hbox.set_no_show_all(False) hbox.show_all() - elif not self.audio_sid: + elif not self.jingle['audio'].sid: hbox.set_no_show_all(True) hbox.hide() @@ -687,15 +702,17 @@ class ChatControl(ChatControlBase): # update MessageWindow._controls self.parent_win.change_jid(self.account, old_full_jid, new_full_jid) - def stop_jingle(self, sid=None, _reason=None): - if self.audio_sid and sid in (self.audio_sid, None): + def stop_jingle(self, sid=None, reason=None): + audio_sid = self.jingle['audio'].sid + video_sid = self.jingle['video'].sid + if audio_sid and sid in (audio_sid, None): self.close_jingle_content('audio') - if self.video_sid and sid in (self.video_sid, None): + if video_sid and sid in (video_sid, None): self.close_jingle_content('video') - def _set_jingle_state(self, jingle_type, state, sid=None, reason=None): - if jingle_type not in ('audio', 'video'): - return + def _set_jingle_state(self, jingle_type: str, state: str, sid: str = None, + reason: str = None) -> None: + jingle = self.jingle[jingle_type] if state in ('connecting', 'connected', 'stop', 'error') and reason: info = _('%(type)s state : %(state)s, reason: %(reason)s') % { 'type': jingle_type.capitalize(), @@ -710,25 +727,25 @@ class ChatControl(ChatControlBase): 'error': self.JINGLE_STATE_ERROR} jingle_state = states[state] - if (getattr(self, jingle_type + '_state') == jingle_state or - state == 'error'): + if jingle.state == jingle_state or state == 'error': return - if (state == 'stop' and - getattr(self, jingle_type + '_sid') not in (None, sid)): + if (state == 'stop' and jingle.sid not in (None, sid)): return - setattr(self, jingle_type + '_state', jingle_state) - + new_sid = None if jingle_state == self.JINGLE_STATE_NULL: - setattr(self, jingle_type + '_sid', None) + new_sid = None if state in ('connection_received', 'connecting'): - setattr(self, jingle_type + '_sid', sid) + new_sid = sid + + jingle.state = jingle_state + jingle.sid = new_sid var = GLib.Variant.new_boolean(jingle_state != self.JINGLE_STATE_NULL) - getattr(self, jingle_type + '_action').change_state(var) + jingle.action.change_state(var) - getattr(self, 'update_' + jingle_type)() + jingle.update() def set_audio_state(self, state, sid=None, reason=None): self._set_jingle_state('audio', state, sid=sid, reason=reason) @@ -739,7 +756,7 @@ class ChatControl(ChatControlBase): def _get_audio_content(self): con = app.connections[self.account] session = con.get_module('Jingle').get_jingle_session( - self.contact.get_full_jid(), self.audio_sid) + self.contact.get_full_jid(), self.jingle['audio'].sid) return session.get_content('audio') def on_num_button_pressed(self, _widget, num): @@ -864,28 +881,31 @@ class ChatControl(ChatControlBase): self.xml.banner_name_label.set_markup(label_text) self.xml.banner_name_label.set_tooltip_text(label_tooltip) - def close_jingle_content(self, jingle_type): - sid = getattr(self, jingle_type + '_sid') - if not sid: + def close_jingle_content(self, jingle_type: str) -> None: + jingle = self.jingle[jingle_type] + if not jingle.sid: return - setattr(self, jingle_type + '_sid', None) - setattr(self, jingle_type + '_state', self.JINGLE_STATE_NULL) + + jingle.sid = None + jingle.state = self.JINGLE_STATE_NULL + con = app.connections[self.account] session = con.get_module('Jingle').get_jingle_session( - self.contact.get_full_jid(), sid) + self.contact.get_full_jid(), jingle.sid) if session: content = session.get_content(jingle_type) if content: session.remove_content(content.creator, content.name) var = GLib.Variant.new_boolean(False) - getattr(self, jingle_type + '_action').change_state(var) - getattr(self, 'update_' + jingle_type)() + + jingle.action.change_state(var) + jingle.update() def on_jingle_button_toggled(self, state, jingle_type): con = app.connections[self.account] if state: - if getattr(self, jingle_type + '_state') == \ - self.JINGLE_STATE_NULL: + if self.jingle[jingle_type].state == self.JINGLE_STATE_NULL: + con = app.connections[self.account] if jingle_type == 'video': video_hbox = self.xml.video_hbox video_hbox.set_no_show_all(False) @@ -893,26 +913,15 @@ class ChatControl(ChatControlBase): fixed = self.xml.outgoing_fixed fixed.set_no_show_all(False) video_hbox.show_all() - out_da = self.xml.outgoing_drawingarea - out_da.realize() - if os.name == 'nt': - out_xid = out_da.get_window().handle - else: - out_xid = out_da.get_window().get_xid() - else: - out_xid = None video_hbox.show_all() - in_da = self.xml.incoming_drawingarea - in_da.realize() - in_xid = in_da.get_window().get_xid() sid = con.get_module('Jingle').start_video( - self.contact.get_full_jid(), in_xid, out_xid) + self.contact.get_full_jid()) else: sid = con.get_module('Jingle').start_audio( self.contact.get_full_jid()) - getattr(self, 'set_' + jingle_type + '_state')('connecting', sid) + self.jingle[jingle_type].set_state('connecting', sid) else: video_hbox = self.xml.video_hbox video_hbox.set_no_show_all(True) ===================================== gajim/common/jingle_rtp.py ===================================== @@ -412,11 +412,8 @@ class JingleAudio(JingleRTPContent): class JingleVideo(JingleRTPContent): - def __init__(self, session, transport=None, in_xid=0, out_xid=0): + def __init__(self, session, transport=None): JingleRTPContent.__init__(self, session, 'video', transport) - self.in_xid = in_xid - self.out_xid = out_xid - self.out_xid_set = False self.setup_stream() def setup_stream(self): @@ -426,42 +423,24 @@ class JingleVideo(JingleRTPContent): JingleRTPContent.setup_stream(self, self._on_src_pad_added) bus = self.pipeline.get_bus() bus.enable_sync_message_emission() - bus.connect('sync-message::element', self._on_sync_message) - # the local parts - if app.config.get('video_framerate'): - framerate = 'videorate ! video/x-raw,framerate=%s ! ' % \ - app.config.get('video_framerate') - else: - framerate = '' - try: - w, h = app.config.get('video_size').split('x') - except Exception: - w = h = None - if w and h: - video_size = 'video/x-raw,width=%s,height=%s ! ' % (w, h) - else: - video_size = '' + def do_setup(self, self_display_sink, other_sink): if app.config.get('video_see_self'): - tee = '! tee name=t ! queue ! videoscale ! ' + \ - 'video/x-raw,width=160,height=120 ! videoconvert ! ' + \ - '%s t. ! queue ' % app.config.get( - 'video_output_device') + tee = '! tee name=split ! queue name=self-display-queue split. ! queue name=network-queue' else: tee = '' self.src_bin = self.make_bin_from_config('video_input_device', - '%%s %s! %svideoscale ! %svideoconvert' % - (tee, framerate, video_size), + '%%s %s' % tee, _("video input")) - self.pipeline.add(self.src_bin) + if app.config.get('video_see_self'): + self.pipeline.add(self_display_sink) + self_display_queue = self.src_bin.get_by_name('self-display-queue') + self_display_queue.get_static_pad('src').link_maybe_ghosting(self_display_sink.get_static_pad('sink')) self.pipeline.set_state(Gst.State.PLAYING) - self.sink = self.make_bin_from_config('video_output_device', - 'videoscale ! videoconvert ! %s', - _("video output")) - + self.sink = other_sink self.pipeline.add(self.sink) self.src_bin.get_static_pad('src').link(self.p2psession.get_property( @@ -469,28 +448,13 @@ class JingleVideo(JingleRTPContent): # The following is needed for farstream to process ICE requests: self.pipeline.set_state(Gst.State.PLAYING) - - def _on_sync_message(self, bus, message): - if message.get_structure() is None: - return False - if message.get_structure().get_name() == 'prepare-window-handle': - message.src.set_property('force-aspect-ratio', True) - imagesink = message.src - if app.config.get('video_see_self') and not self.out_xid_set: - imagesink.set_window_handle(self.out_xid) - self.out_xid_set = True - else: - imagesink.set_window_handle(self.in_xid) + Gst.debug_bin_to_dot_file(self.pipeline, Gst.DebugGraphDetails.ALL, 'video-graph') def get_fallback_src(self): # TODO: Use avatar? pipeline = 'videotestsrc is-live=true ! video/x-raw,framerate=10/1 ! videoconvert' return Gst.parse_bin_from_description(pipeline, True) - def destroy(self): - JingleRTPContent.destroy(self) - self.pipeline.get_bus().disconnect_by_func(self._on_sync_message) - def get_content(desc): if desc['media'] == 'audio': return JingleAudio ===================================== gajim/common/modules/jingle.py ===================================== @@ -165,18 +165,18 @@ class Jingle(BaseModule): jingle.start_session() return jingle.sid - def start_video(self, jid, in_xid, out_xid): + def start_video(self, jid): if self.get_jingle_session(jid, media='video'): return self.get_jingle_session(jid, media='video').sid jingle = self.get_jingle_session(jid, media='audio') if jingle: - jingle.add_content('video', JingleVideo(jingle, in_xid=in_xid, - out_xid=out_xid)) + video = JingleVideo(jingle) + jingle.add_content('video', video) else: jingle = JingleSession(self._con, weinitiate=True, jid=jid) self._sessions[jingle.sid] = jingle - jingle.add_content('video', JingleVideo(jingle, in_xid=in_xid, - out_xid=out_xid)) + video = JingleVideo(jingle) + jingle.add_content('video', video) jingle.start_session() return jingle.sid ===================================== gajim/data/gui/chat_control.ui ===================================== @@ -942,16 +942,13 @@ microphone-sensitivity-high-symbolic</property> <property name="can_focus">False</property> <property name="no_show_all">True</property> <child> - <object class="GtkViewport" id="viewport1"> + <object class="GtkViewport" id="outgoing_viewport"> <property name="width_request">160</property> <property name="height_request">120</property> <property name="visible">True</property> <property name="can_focus">False</property> <child> - <object class="GtkDrawingArea" id="outgoing_drawingarea"> - <property name="visible">True</property> - <property name="can_focus">False</property> - </object> + <placeholder/> </child> </object> </child> @@ -968,16 +965,11 @@ microphone-sensitivity-high-symbolic</property> <property name="can_focus">False</property> <property name="orientation">vertical</property> <child> - <object class="GtkViewport" id="viewport2"> + <object class="GtkViewport" id="incoming_viewport"> <property name="visible">True</property> <property name="can_focus">False</property> <child> - <object class="GtkDrawingArea" id="incoming_drawingarea"> - <property name="width_request">320</property> - <property name="height_request">240</property> - <property name="visible">True</property> - <property name="can_focus">False</property> - </object> + <placeholder/> </child> </object> <packing> ===================================== gajim/dialogs.py ===================================== @@ -29,7 +29,6 @@ from typing import Dict # pylint: disable=unused-import from typing import List # pylint: disable=unused-import from typing import Tuple # pylint: disable=unused-import -import os import uuid import logging @@ -54,6 +53,7 @@ from gajim.gtk.util import get_icon_name from gajim.gtk.util import get_builder from gajim.gtk.util import get_activity_icon_name from gajim.gtk.util import get_app_window +from gajim.gtk import gstreamer if app.is_installed('GSPELL'): from gi.repository import Gspell # pylint: disable=ungrouped-imports @@ -1100,34 +1100,12 @@ class VoIPCallReceivedDialog: fixed = ctrl.xml.get_object('outgoing_fixed') fixed.set_no_show_all(False) video_hbox.show_all() - ctrl.xml.get_object('incoming_drawingarea').realize() - if os.name == 'nt': - in_xid = ctrl.xml.get_object('incoming_drawingarea').\ - get_window().handle - else: - in_xid = ctrl.xml.get_object('incoming_drawingarea').\ - get_property('window').get_xid() content = session.get_content('video') - # move outgoing stream to chat window - if app.config.get('video_see_self'): - ctrl.xml.get_object('outgoing_drawingarea').realize() - if os.name == 'nt': - out_xid = ctrl.xml.get_object('outgoing_drawingarea').\ - get_window().handle - else: - out_xid = ctrl.xml.get_object('outgoing_drawingarea').\ - get_property('window').get_xid() - b = content.src_bin - for e in b.children: - if not e.get_name().startswith('autovideosink'): - continue - for f in e.children: - if f.get_name().startswith('autovideosink'): - f.set_window_handle(out_xid) - content.out_xid = out_xid - break - break - content.in_xid = in_xid + sink_other, widget_other, _ = gstreamer.create_gtk_widget() + sink_self, widget_self, _ = gstreamer.create_gtk_widget() + ctrl.xml.incoming_viewport.add(widget_other) + ctrl.xml.outgoing_viewport.add(widget_self) + content.do_setup(sink_self, sink_other) ctrl.set_video_state('connecting', self.sid) # Now, accept the content/sessions. # This should be done after the chat control is running ===================================== gajim/gtk/gstreamer.py ===================================== @@ -0,0 +1,24 @@ +from typing import Tuple, Optional + +from gi.repository import Gst +from gi.repository import Gtk + +def create_gtk_widget() -> Tuple[Optional[Gst.Element], Optional[Gtk.Widget], Optional[str]]: + gtkglsink = Gst.ElementFactory.make('gtkglsink', None) + if gtkglsink is not None: + glsinkbin = Gst.ElementFactory.make('glsinkbin', None) + if glsinkbin is None: + return None, None, None + glsinkbin.set_property('sink', gtkglsink) + sink = glsinkbin + widget = gtkglsink.get_property('widget') + name = 'gtkglsink' + else: + sink = Gst.ElementFactory.make('gtksink', None) + if sink is None: + return None, None, None + widget = sink.get_property('widget') + name = 'gtksink' + widget.set_visible(True) + widget.set_property('expand', True) + return sink, widget, name ===================================== gajim/gtk/preferences.py ===================================== @@ -38,6 +38,7 @@ from gajim.gtk.util import open_window from gajim.gtk.dialogs import AspellDictError from gajim.gtk.sounds import ManageSounds from gajim.gtk.const import ControlType +from gajim.gtk import gstreamer try: from gajim.common.multimedia_helpers import AudioInputManager, AudioOutputManager @@ -384,7 +385,7 @@ class Preferences(Gtk.ApplicationWindow): def on_av_map(tab): label = self._ui.selected_video_output - sink, widget, name = self.setup_video_output() + sink, widget, name = gstreamer.create_gtk_widget() if sink is None: log.error('Failed to obtain a working Gstreamer GTK+ sink, ' 'video support will be disabled') @@ -508,27 +509,6 @@ class Preferences(Gtk.ApplicationWindow): if event.keyval == Gdk.KEY_Escape: self.destroy() - @staticmethod - def setup_video_output(): - gtkglsink = Gst.ElementFactory.make('gtkglsink', None) - if gtkglsink is not None: - glsinkbin = Gst.ElementFactory.make('glsinkbin', None) - if glsinkbin is None: - return None, None, None - glsinkbin.set_property('sink', gtkglsink) - sink = glsinkbin - widget = gtkglsink.get_property('widget') - name = 'gtkglsink' - else: - sink = Gst.ElementFactory.make('gtksink', None) - if sink is None: - return None, None, None - widget = sink.get_property('widget') - name = 'gtksink' - widget.set_visible(True) - widget.set_property('expand', True) - return sink, widget, name - def get_per_account_option(self, opt): """ Return the value of the option opt if it's the same in all accounts else ===================================== gajim/gui_interface.py ===================================== @@ -1024,7 +1024,7 @@ class Interface: account = obj.conn.name ctrl = (self.msg_win_mgr.get_control(obj.fjid, account) or self.msg_win_mgr.get_control(obj.jid, account)) - if ctrl and obj.sid == ctrl.audio_sid: + if ctrl and obj.sid == ctrl.jingle['audio'].sid: ctrl.set_audio_state('error', reason=obj.reason) @staticmethod View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/7e6a3e30397c4f9cdf53da2c790786f… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/7e6a3e30397c4f9cdf53da2c790786f… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] ChatControl: Fix start_audio() call
by Philipp Hörist 17 Mar '20

17 Mar '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 7e6a3e30 by lovetox at 2020-03-17T19:21:50+01:00 ChatControl: Fix start_audio() call - - - - - 1 changed file: - gajim/chat_control.py Changes: ===================================== gajim/chat_control.py ===================================== @@ -882,6 +882,7 @@ class ChatControl(ChatControlBase): getattr(self, 'update_' + jingle_type)() def on_jingle_button_toggled(self, state, jingle_type): + con = app.connections[self.account] if state: if getattr(self, jingle_type + '_state') == \ self.JINGLE_STATE_NULL: @@ -904,12 +905,13 @@ class ChatControl(ChatControlBase): in_da = self.xml.incoming_drawingarea in_da.realize() in_xid = in_da.get_window().get_xid() - con = app.connections[self.account] sid = con.get_module('Jingle').start_video( self.contact.get_full_jid(), in_xid, out_xid) + else: - sid = getattr(app.connections[self.account], - 'start_' + jingle_type)(self.contact.get_full_jid()) + sid = con.get_module('Jingle').start_audio( + self.contact.get_full_jid()) + getattr(self, 'set_' + jingle_type + '_state')('connecting', sid) else: video_hbox = self.xml.video_hbox View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/7e6a3e30397c4f9cdf53da2c790786f2… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/7e6a3e30397c4f9cdf53da2c790786f2… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/python-nbxmpp][master] TCP: Set timeout when connecting
by Philipp Hörist 17 Mar '20

17 Mar '20

Philipp Hörist pushed to branch master at gajim / python-nbxmpp Commits: 57a3f73f by lovetox at 2020-03-17T16:47:32+01:00 TCP: Set timeout when connecting Timeout is set to 7 seconds and reset to 0 after connecting was successful - - - - - 1 changed file: - nbxmpp/tcp.py Changes: ===================================== nbxmpp/tcp.py ===================================== @@ -38,6 +38,7 @@ class TCPConnection(Connection): Connection.__init__(self, *args, **kwargs) self._client = Gio.SocketClient.new() + self._client.set_timeout(7) if self._address.proxy is not None: self._proxy_resolver = self._address.proxy.get_resolver() @@ -121,6 +122,8 @@ class TCPConnection(Connection): self._finalize('connection-failed') return + # We use the timeout only for connecting + self._con.get_socket().set_timeout(0) self._con.set_graceful_disconnect(True) self._con.get_socket().set_keepalive(True) View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/57a3f73f6c0d71d73f2efafb… -- View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/57a3f73f6c0d71d73f2efafb… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] AccountCreation: Fix typos
by Philipp Hörist 17 Mar '20

17 Mar '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 0f1124cb by Daniel Brötzmann at 2020-03-17T08:58:45+01:00 AccountCreation: Fix typos - - - - - 2 changed files: - gajim/data/gui/account_wizard.ui - gajim/gtk/account_wizard.py Changes: ===================================== gajim/data/gui/account_wizard.ui ===================================== @@ -1,5 +1,5 @@ <?xml version="1.0" encoding="UTF-8"?> - + <interface> <requires lib="gtk+" version="3.20"/> <object class="GtkGrid" id="advanced_grid"> @@ -30,7 +30,7 @@ <property name="visible">True</property> <property name="can_focus">True</property> <property name="width_chars">6</property> - <property name="placeholder_text" translatable="yes">5222</property> + <property name="placeholder_text">5222</property> <property name="input_purpose">number</property> </object> <packing> @@ -145,9 +145,9 @@ <property name="can_focus">False</property> <property name="active">0</property> <items> - <item translatable="yes">START TLS</item> - <item translatable="yes">DIRECT TLS</item> - <item translatable="yes">PLAIN</item> + <item>START TLS</item> + <item>DIRECT TLS</item> + <item>PLAIN</item> </items> </object> <packing> @@ -462,7 +462,7 @@ <object class="GtkLabel"> <property name="visible">True</property> <property name="can_focus">False</property> - <property name="label" translatable="yes">There are plenty of servers to choose from. + <property name="label" translatable="yes">There are plenty of servers to choose from. Creating an account on one server allows you to communicate with contacts from other servers as well.</property> <property name="wrap">True</property> <property name="max_width_chars">40</property> ===================================== gajim/gtk/account_wizard.py ===================================== @@ -289,7 +289,7 @@ class AccountWizard(Assistant): if error == 'register-not-supported': self._show_error_page(_('Signup not allowed'), _('Signup not allowed'), - _('This server does not all signup')) + _('This server does not allow signup.')) self._client.destroy() self._client = None @@ -298,7 +298,7 @@ class AccountWizard(Assistant): self._show_error_page(_('Connection failed'), _('Connection failed'), _('Gajim was not able to reach the server. ' - 'Make sure your XMPP address is correct')) + 'Make sure your XMPP address is correct.')) self._client.destroy() self._client = None View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/0f1124cb9d489b24fc3c504aeafa0e2c… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/0f1124cb9d489b24fc3c504aeafa0e2c… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/python-nbxmpp][master] Revert "TCP: Set timeout when connecting"
by Philipp Hörist 17 Mar '20

17 Mar '20

Philipp Hörist pushed to branch master at gajim / python-nbxmpp Commits: 27c4844c by Philipp Hörist at 2020-03-17T06:14:12+01:00 Revert "TCP: Set timeout when connecting" This reverts commit 384b50b087c4e7eb0fbb1ca63ab1537760afbd64 - - - - - 1 changed file: - nbxmpp/tcp.py Changes: ===================================== nbxmpp/tcp.py ===================================== @@ -38,7 +38,6 @@ class TCPConnection(Connection): Connection.__init__(self, *args, **kwargs) self._client = Gio.SocketClient.new() - self._client.set_timeout(10) if self._address.proxy is not None: self._proxy_resolver = self._address.proxy.get_resolver() View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/27c4844c72868ca83cb77498… -- View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/27c4844c72868ca83cb77498… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: AccountCreationWizard: Complete rework
by Philipp Hörist 16 Mar '20

16 Mar '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 7b2a6e19 by Daniel Brötzmann at 2020-03-16T22:43:29+01:00 AccountCreationWizard: Complete rework - - - - - b7a974a7 by lovetox at 2020-03-16T22:44:23+01:00 Dataform: Hide fallback fields ejabberd uses fallback fields for captchas. Don't show them because we support captchas. - - - - - 12 changed files: - gajim/app_actions.py - gajim/common/const.py - gajim/common/helpers.py - − gajim/data/gui/account_creation_wizard_window.ui - + gajim/data/gui/account_wizard.ui - gajim/data/style/gajim.css - gajim/gtk/account_wizard.py - gajim/gtk/const.py - gajim/gtk/dataform.py - gajim/gtk/proxies.py - gajim/gui_interface.py - gajim/roster_window.py Changes: ===================================== gajim/app_actions.py ===================================== @@ -28,7 +28,6 @@ from gajim.gtk.single_message import SingleMessageWindow from gajim.gtk.about import AboutDialog from gajim.gtk.privacy_list import PrivacyListsWindow from gajim.gtk.features import FeaturesDialog -from gajim.gtk.account_wizard import AccountCreationWizard from gajim.gtk.history import HistoryWindow from gajim.gtk.discovery import ServiceDiscoveryWindow from gajim.gtk.util import open_window @@ -136,12 +135,8 @@ def on_merge_accounts(action, param): app.interface.roster.setup_and_draw_roster() -def on_add_account(_action, _param): - if 'account_creation_wizard' in app.interface.instances: - app.interface.instances['account_creation_wizard'].window.present() - else: - app.interface.instances['account_creation_wizard'] = \ - AccountCreationWizard() +def on_add_account(action, _param): + open_window('AccountWizard') def on_import_contacts(_action, param): ===================================== gajim/common/const.py ===================================== @@ -895,3 +895,18 @@ class FTState(Enum): @property def is_error(self): return self == FTState.ERROR + + +SASL_ERRORS = { + 'aborted': _('Authentication aborted'), + 'account-disabled': _('Account disabled'), + 'credentials-expired': _('Credentials expired'), + 'encryption-required': _('Encryption required'), + 'incorrect-encoding': _('Authentication failed'), + 'invalid-authzid': _('Authentication failed'), + 'malformed-request': _('Authentication failed'), + 'invalid-mechanism': _('Authentication mechanism not supported'), + 'mechanism-too-weak': _('Authentication mechanism too weak'), + 'not-authorized': _('Authentication failed'), + 'temporary-auth-failure': _('Authentication currently not possible'), +} ===================================== gajim/common/helpers.py ===================================== @@ -1115,7 +1115,9 @@ def get_user_proxy(account): proxy_name = app.config.get_per('accounts', account, 'proxy') if not proxy_name: return None + return get_proxy(proxy_name) +def get_proxy(proxy_name): proxy = app.config.get_per('proxies', proxy_name) if proxy is None: return None ===================================== gajim/data/gui/account_creation_wizard_window.ui deleted ===================================== @@ -1,926 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> - -<interface> - <requires lib="gtk+" version="3.12"/> - <object class="GtkImage" id="image2"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="stock">gtk-preferences</property> - </object> - <object class="GtkImage" id="image3"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="stock">gtk-apply</property> - </object> - <object class="GtkListStore" id="liststore1"> - <columns> -  - <column type="gchararray"/> - </columns> - <data> - <row> - <col id="0" translatable="yes">None</col> - </row> - </data> - </object> - <object class="GtkListStore" id="server_liststore"> - <columns> -  - <column type="gchararray"/> - </columns> - </object> - <object class="GtkEntryCompletion" id="server_entrycompletion"> - <property name="model">server_liststore</property> - <property name="text_column">0</property> - </object> - <object class="GtkEntryCompletion" id="server_entrycompletion1"> - <property name="model">server_liststore</property> - <property name="text_column">0</property> - </object> - <object class="GtkWindow" id="account_creation_wizard_window"> - <property name="can_focus">False</property> - <property name="border_width">12</property> - <property name="title" translatable="yes">Gajim: Account Creation Wizard</property> - <property name="resizable">False</property> - <property name="type_hint">dialog</property> - <signal name="destroy" handler="on_wizard_window_destroy" swapped="no"/> - <child> - <object class="GtkBox" id="box1"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="orientation">vertical</property> - <property name="spacing">6</property> - <child> - <object class="GtkNotebook" id="notebook"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="show_tabs">False</property> - <property name="show_border">False</property> - <child> - <object class="GtkBox" id="vbox78"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="orientation">vertical</property> - <property name="spacing">12</property> - <child> - <object class="GtkLabel" id="label256"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="xalign">0</property> - <property name="label" translatable="yes">You need to have an account in order to connect -to the XMPP network.</property> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">False</property> - <property name="position">0</property> - </packing> - </child> - <child> - <object class="GtkFrame" id="frame33"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="label_xalign">0</property> - <property name="shadow_type">none</property> - <child> - <object class="GtkBox" id="vbox83"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="margin_left">12</property> - <property name="border_width">6</property> - <property name="orientation">vertical</property> - <property name="spacing">6</property> - <child> - <object class="GtkRadioButton" id="use_existing_account_radiobutton"> - <property name="label" translatable="yes">I already have an account I want to _use</property> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="receives_default">False</property> - <property name="use_underline">True</property> - <property name="xalign">0</property> - <property name="active">True</property> - <property name="draw_indicator">True</property> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">False</property> - <property name="position">0</property> - </packing> - </child> - <child> - <object class="GtkRadioButton" id="register_new_account_radiobutton"> - <property name="label" translatable="yes">I want to _register for a new account</property> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="receives_default">False</property> - <property name="use_underline">True</property> - <property name="xalign">0</property> - <property name="draw_indicator">True</property> - <property name="group">use_existing_account_radiobutton</property> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">False</property> - <property name="position">1</property> - </packing> - </child> - </object> - </child> - <child type="label"> - <object class="GtkLabel" id="label269"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="label" translatable="yes"><b>Please choose one of the options below:</b></property> - <property name="use_markup">True</property> - </object> - </child> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">False</property> - <property name="position">1</property> - </packing> - </child> - </object> - </child> - <child type="tab"> - <object class="GtkLabel" id="label259"> - <property name="visible">True</property> - <property name="can_focus">False</property> - </object> - <packing> - <property name="tab_fill">False</property> - </packing> - </child> - <child> - <object class="GtkBox" id="register_vbox"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="border_width">6</property> - <property name="orientation">vertical</property> - <property name="spacing">12</property> - <child> - <object class="GtkLabel" id="label270"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="xalign">0</property> - <property name="label" translatable="yes"><b>Please fill in the data for your existing account</b></property> - <property name="use_markup">True</property> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">False</property> - <property name="position">0</property> - </packing> - </child> - <child> - <object class="GtkGrid" id="grid1"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="row_spacing">6</property> - <property name="column_spacing">6</property> - <child> - <object class="GtkLabel" id="label262"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="xalign">0</property> - <property name="label" translatable="yes">_XMPP Address:</property> - <property name="use_underline">True</property> - <property name="mnemonic_widget">username_entry</property> - </object> - <packing> - <property name="left_attach">0</property> - <property name="top_attach">0</property> - </packing> - </child> - <child> - <object class="GtkEntry" id="username_entry"> - <property name="visible">True</property> - <property name="can_focus">True</property> - <signal name="key-press-event" handler="on_username_entry_key_press_event" swapped="no"/> - </object> - <packing> - <property name="left_attach">1</property> - <property name="top_attach">0</property> - </packing> - </child> - <child> - <object class="GtkLabel" id="label1"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="xalign">0</property> - <property name="label">@</property> - </object> - <packing> - <property name="left_attach">2</property> - <property name="top_attach">0</property> - </packing> - </child> - <child> - <object class="GtkComboBoxText" id="server_comboboxtext"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="hexpand">True</property> - <property name="has_entry">True</property> - <child internal-child="entry"> - <object class="GtkEntry" id="server_comboboxtext_entry"> - <property name="can_focus">True</property> - <property name="completion">server_entrycompletion</property> - </object> - </child> - </object> - <packing> - <property name="left_attach">3</property> - <property name="top_attach">0</property> - </packing> - </child> - <child> - <object class="GtkCheckButton" id="anonymous_checkbutton1"> - <property name="label" translatable="yes">Anon_ymous authentication</property> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="receives_default">False</property> - <property name="use_underline">True</property> - <property name="xalign">0</property> - <property name="draw_indicator">True</property> - <signal name="toggled" handler="on_anonymous_checkbutton1_toggled" swapped="no"/> - </object> - <packing> - <property name="left_attach">1</property> - <property name="top_attach">1</property> - <property name="width">3</property> - </packing> - </child> - <child> - <object class="GtkLabel" id="label263"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="xalign">0</property> - <property name="label" translatable="yes">_Password:</property> - <property name="use_underline">True</property> - </object> - <packing> - <property name="left_attach">0</property> - <property name="top_attach">2</property> - </packing> - </child> - <child> - <object class="GtkEntry" id="password_entry"> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="visibility">False</property> - <property name="activates_default">True</property> - </object> - <packing> - <property name="left_attach">1</property> - <property name="top_attach">2</property> - </packing> - </child> - <child> - <object class="GtkCheckButton" id="save_password_checkbutton"> - <property name="label" translatable="yes">Save pass_word</property> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="receives_default">False</property> - <property name="tooltip_text" translatable="yes">If checked, Gajim will remember the password for this account</property> - <property name="use_underline">True</property> - <property name="focus_on_click">False</property> - <property name="xalign">0</property> - <property name="active">True</property> - <property name="draw_indicator">True</property> - <signal name="toggled" handler="on_save_password_checkbutton_toggled" swapped="no"/> - </object> - <packing> - <property name="left_attach">2</property> - <property name="top_attach">2</property> - <property name="width">2</property> - </packing> - </child> - <child> - <placeholder/> - </child> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">True</property> - <property name="position">1</property> - </packing> - </child> - <child> - <placeholder/> - </child> - </object> - <packing> - <property name="position">1</property> - </packing> - </child> - <child type="tab"> - <object class="GtkLabel" id="label261"> - <property name="visible">True</property> - <property name="can_focus">False</property> - </object> - <packing> - <property name="position">1</property> - <property name="tab_fill">False</property> - </packing> - </child> - <child> - <object class="GtkBox" id="vbox105"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="border_width">6</property> - <property name="orientation">vertical</property> - <property name="spacing">12</property> - <child> - <object class="GtkLabel" id="label368"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="xalign">0</property> - <property name="label" translatable="yes"><b>Please select a server</b></property> - <property name="use_markup">True</property> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">False</property> - <property name="position">0</property> - </packing> - </child> - <child> - <object class="GtkBox" id="box2"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="spacing">6</property> - <child> - <object class="GtkLabel" id="label369"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="xalign">0</property> - <property name="label" translatable="yes">_Server:</property> - <property name="use_underline">True</property> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">False</property> - <property name="position">0</property> - </packing> - </child> - <child> - <object class="GtkComboBoxText" id="server_comboboxtext1"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="has_entry">True</property> - <child internal-child="entry"> - <object class="GtkEntry" id="server_comboboxtext_entry1"> - <property name="can_focus">True</property> - <property name="completion">server_entrycompletion1</property> - </object> - </child> - </object> - <packing> - <property name="expand">True</property> - <property name="fill">True</property> - <property name="position">1</property> - </packing> - </child> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">True</property> - <property name="position">1</property> - </packing> - </child> - <child> - <object class="GtkCheckButton" id="anonymous_checkbutton2"> - <property name="label" translatable="yes">Anon_ymous authentication</property> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="receives_default">False</property> - <property name="use_underline">True</property> - <property name="xalign">0</property> - <property name="draw_indicator">True</property> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">True</property> - <property name="position">2</property> - </packing> - </child> - <child> - <object class="GtkExpander" id="expander1"> - <property name="visible">True</property> - <property name="can_focus">True</property> - <child> - <object class="GtkGrid" id="grid2"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="row_spacing">6</property> - <property name="column_spacing">6</property> - <child> - <object class="GtkLabel" id="label381"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="xalign">0</property> - <property name="label" translatable="yes">Prox_y:</property> - <property name="use_underline">True</property> - </object> - <packing> - <property name="left_attach">0</property> - <property name="top_attach">0</property> - </packing> - </child> - <child> - <object class="GtkComboBox" id="proxies_combobox"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="model">liststore1</property> - <child> - <object class="GtkCellRendererText" id="cellrenderertext1"/> - <attributes> - <attribute name="text">0</attribute> - </attributes> - </child> - </object> - <packing> - <property name="left_attach">1</property> - <property name="top_attach">0</property> - </packing> - </child> - <child> - <object class="GtkButton" id="manage_proxies_button"> - <property name="label" translatable="yes">Manage...</property> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="receives_default">False</property> - <property name="halign">start</property> - <property name="use_underline">True</property> - <signal name="clicked" handler="on_manage_proxies_button_clicked" swapped="no"/> - </object> - <packing> - <property name="left_attach">2</property> - <property name="top_attach">0</property> - </packing> - </child> - <child> - <object class="GtkCheckButton" id="custom_host_port_checkbutton"> - <property name="label" translatable="yes">Use custom hostname/port</property> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="receives_default">False</property> - <property name="use_underline">True</property> - <property name="xalign">0</property> - <property name="draw_indicator">True</property> - <signal name="toggled" handler="on_custom_host_port_checkbutton_toggled" swapped="no"/> - </object> - <packing> - <property name="left_attach">0</property> - <property name="top_attach">1</property> - <property name="width">3</property> - </packing> - </child> - <child> - <object class="GtkBox" id="custom_host_hbox"> - <property name="visible">True</property> - <property name="sensitive">False</property> - <property name="can_focus">False</property> - <property name="spacing">6</property> - <child> - <object class="GtkLabel" id="label380"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="xalign">0</property> - <property name="label" translatable="yes">_Hostname:</property> - <property name="use_underline">True</property> - <property name="mnemonic_widget">custom_host_entry</property> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">False</property> - <property name="position">0</property> - </packing> - </child> - <child> - <object class="GtkEntry" id="custom_host_entry"> - <property name="visible">True</property> - <property name="can_focus">True</property> - </object> - <packing> - <property name="expand">True</property> - <property name="fill">True</property> - <property name="position">1</property> - </packing> - </child> - <child> - <object class="GtkLabel" id="label379"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="xalign">0</property> - <property name="label" translatable="yes">_Port:</property> - <property name="use_underline">True</property> - <property name="mnemonic_widget">custom_port_entry</property> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">False</property> - <property name="position">2</property> - </packing> - </child> - <child> - <object class="GtkEntry" id="custom_port_entry"> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="width_chars">6</property> - <property name="text">5222</property> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">True</property> - <property name="position">3</property> - </packing> - </child> - </object> - <packing> - <property name="left_attach">0</property> - <property name="top_attach">2</property> - <property name="width">3</property> - </packing> - </child> - </object> - </child> - <child type="label"> - <object class="GtkLabel" id="label378"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="label" translatable="yes">_Advanced</property> - <property name="use_underline">True</property> - </object> - </child> - </object> - <packing> - <property name="expand">True</property> - <property name="fill">True</property> - <property name="position">3</property> - </packing> - </child> - </object> - <packing> - <property name="position">2</property> - </packing> - </child> - <child type="tab"> - <object class="GtkLabel" id="label367"> - <property name="visible">True</property> - <property name="can_focus">False</property> - </object> - <packing> - <property name="position">2</property> - <property name="tab_fill">False</property> - </packing> - </child> - <child> - <object class="GtkBox" id="ssl_vbox"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="orientation">vertical</property> - <child> - <object class="GtkBox" id="hbox1"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="events">GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK</property> - <child> - <object class="GtkImage" id="image1"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="events">GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK</property> - <property name="stock">gtk-dialog-warning</property> - <property name="icon_size">5</property> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">True</property> - <property name="position">0</property> - </packing> - </child> - <child> - <object class="GtkLabel" id="ssl_label"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="events">GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK</property> - </object> - <packing> - <property name="expand">True</property> - <property name="fill">True</property> - <property name="position">1</property> - </packing> - </child> - </object> - <packing> - <property name="expand">True</property> - <property name="fill">False</property> - <property name="position">0</property> - </packing> - </child> - <child> - <object class="GtkCheckButton" id="ssl_checkbutton"> - <property name="label" translatable="yes">Add this certificate to the list of trusted certificates. -SHA1 fingerprint of the certificate: -</property> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="receives_default">False</property> - <property name="events">GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK</property> - <property name="xalign">0</property> - <property name="draw_indicator">True</property> - </object> - <packing> - <property name="expand">True</property> - <property name="fill">False</property> - <property name="position">1</property> - </packing> - </child> - </object> - <packing> - <property name="position">3</property> - </packing> - </child> - <child type="tab"> - <object class="GtkLabel" id="label482"> - <property name="visible">True</property> - <property name="can_focus">False</property> - </object> - <packing> - <property name="position">3</property> - <property name="tab_fill">False</property> - </packing> - </child> - <child> - <object class="GtkBox" id="form_vbox"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="orientation">vertical</property> - <child> - <placeholder/> - </child> - </object> - <packing> - <property name="position">4</property> - </packing> - </child> - <child type="tab"> - <object class="GtkLabel" id="label382"> - <property name="visible">True</property> - <property name="can_focus">False</property> - </object> - <packing> - <property name="position">4</property> - <property name="tab_fill">False</property> - </packing> - </child> - <child> - <object class="GtkBox" id="vbox104"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="orientation">vertical</property> - <child> - <object class="GtkLabel" id="progressbar_label"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="label" translatable="yes"><b>Connecting to server</b> - -Please wait...</property> - <property name="use_markup">True</property> - <property name="justify">center</property> - </object> - <packing> - <property name="expand">True</property> - <property name="fill">False</property> - <property name="position">0</property> - </packing> - </child> - <child> - <object class="GtkProgressBar" id="progressbar"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="pulse_step">0.10000000149</property> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">False</property> - <property name="position">1</property> - </packing> - </child> - </object> - <packing> - <property name="position">5</property> - </packing> - </child> - <child type="tab"> - <object class="GtkLabel" id="label365"> - <property name="visible">True</property> - <property name="can_focus">False</property> - </object> - <packing> - <property name="position">5</property> - <property name="tab_fill">False</property> - </packing> - </child> - <child> - <object class="GtkBox" id="vbox103"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="orientation">vertical</property> - <child> - <object class="GtkBox" id="hbox2986"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="spacing">12</property> - <child> - <object class="GtkImage" id="finish_image"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="stock">gtk-missing-image</property> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">False</property> - <property name="position">0</property> - </packing> - </child> - <child> - <object class="GtkLabel" id="finish_label"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="xalign">0.10000000149011612</property> - <property name="use_markup">True</property> - <property name="wrap">True</property> - <property name="max_width_chars">100</property> - </object> - <packing> - <property name="expand">True</property> - <property name="fill">True</property> - <property name="position">1</property> - </packing> - </child> - </object> - <packing> - <property name="expand">True</property> - <property name="fill">True</property> - <property name="position">0</property> - </packing> - </child> - <child> - <object class="GtkCheckButton" id="go_online_checkbutton"> - <property name="label" translatable="yes">Connect when I press Finish</property> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="receives_default">False</property> - <property name="use_underline">True</property> - <property name="xalign">0</property> - <property name="active">True</property> - <property name="draw_indicator">True</property> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">False</property> - <property name="position">1</property> - </packing> - </child> - <child> - <object class="GtkCheckButton" id="show_vcard_checkbutton"> - <property name="label" translatable="yes">Set my profile when I connect</property> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="receives_default">False</property> - <property name="use_underline">True</property> - <property name="xalign">0</property> - <property name="active">True</property> - <property name="draw_indicator">True</property> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">False</property> - <property name="position">2</property> - </packing> - </child> - </object> - <packing> - <property name="position">6</property> - </packing> - </child> - <child type="tab"> - <object class="GtkLabel" id="label286"> - <property name="visible">True</property> - <property name="can_focus">False</property> - </object> - <packing> - <property name="position">6</property> - <property name="tab_fill">False</property> - </packing> - </child> - </object> - <packing> - <property name="expand">True</property> - <property name="fill">True</property> - <property name="position">0</property> - </packing> - </child> - <child> - <object class="GtkButtonBox" id="buttonbox1"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="spacing">12</property> - <property name="layout_style">end</property> - <child> - <object class="GtkButton" id="cancel_button"> - <property name="label">gtk-cancel</property> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="can_default">True</property> - <property name="receives_default">False</property> - <property name="use_stock">True</property> - <signal name="clicked" handler="on_cancel_button_clicked" swapped="no"/> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">False</property> - <property name="position">0</property> - </packing> - </child> - <child> - <object class="GtkButton" id="back_button"> - <property name="label">gtk-go-back</property> - <property name="visible">True</property> - <property name="sensitive">False</property> - <property name="can_focus">True</property> - <property name="can_default">True</property> - <property name="receives_default">False</property> - <property name="use_stock">True</property> - <signal name="clicked" handler="on_back_button_clicked" swapped="no"/> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">False</property> - <property name="position">1</property> - </packing> - </child> - <child> - <object class="GtkButton" id="forward_button"> - <property name="label">gtk-go-forward</property> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="can_default">True</property> - <property name="has_default">True</property> - <property name="receives_default">False</property> - <property name="use_stock">True</property> - <signal name="clicked" handler="on_forward_button_clicked" swapped="no"/> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">False</property> - <property name="position">2</property> - </packing> - </child> - <child> - <object class="GtkButton" id="advanced_button"> - <property name="label" translatable="yes">_Advanced</property> - <property name="can_focus">True</property> - <property name="can_default">True</property> - <property name="receives_default">False</property> - <property name="no_show_all">True</property> - <property name="image">image2</property> - <property name="use_underline">True</property> - <signal name="clicked" handler="on_advanced_button_clicked" swapped="no"/> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">False</property> - <property name="position">3</property> - </packing> - </child> - <child> - <object class="GtkButton" id="finish_button"> - <property name="label" translatable="yes">_Finish</property> - <property name="can_focus">True</property> - <property name="can_default">True</property> - <property name="receives_default">False</property> - <property name="no_show_all">True</property> - <property name="image">image3</property> - <property name="use_underline">True</property> - <signal name="clicked" handler="on_finish_button_clicked" swapped="no"/> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">False</property> - <property name="position">4</property> - </packing> - </child> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">True</property> - <property name="position">1</property> - </packing> - </child> - </object> - </child> - </object> -</interface> ===================================== gajim/data/gui/account_wizard.ui ===================================== @@ -0,0 +1,684 @@ +<?xml version="1.0" encoding="UTF-8"?> + +<interface> + <requires lib="gtk+" version="3.20"/> + <object class="GtkGrid" id="advanced_grid"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="halign">center</property> + <property name="row_spacing">6</property> + <property name="column_spacing">12</property> + <child> + <object class="GtkLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="halign">end</property> + <property name="label" translatable="yes">_Port</property> + <property name="use_underline">True</property> + <property name="mnemonic_widget">custom_port_entry</property> + <style> + <class name="dim-label"/> + </style> + </object> + <packing> + <property name="left_attach">0</property> + <property name="top_attach">3</property> + </packing> + </child> + <child> + <object class="GtkEntry" id="custom_port_entry"> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="width_chars">6</property> + <property name="placeholder_text" translatable="yes">5222</property> + <property name="input_purpose">number</property> + </object> + <packing> + <property name="left_attach">1</property> + <property name="top_attach">3</property> + </packing> + </child> + <child> + <object class="GtkLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="halign">end</property> + <property name="label" translatable="yes">_Hostname</property> + <property name="use_underline">True</property> + <property name="mnemonic_widget">custom_host_entry</property> + <style> + <class name="dim-label"/> + </style> + </object> + <packing> + <property name="left_attach">0</property> + <property name="top_attach">2</property> + </packing> + </child> + <child> + <object class="GtkEntry" id="custom_host_entry"> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="placeholder_text" translatable="yes">example.org</property> + </object> + <packing> + <property name="left_attach">1</property> + <property name="top_attach">2</property> + </packing> + </child> + <child> + <object class="GtkLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="halign">end</property> + <property name="margin_bottom">18</property> + <property name="label" translatable="yes">Prox_y</property> + <property name="use_underline">True</property> + <property name="mnemonic_widget">proxies_combobox</property> + <style> + <class name="dim-label"/> + </style> + </object> + <packing> + <property name="left_attach">0</property> + <property name="top_attach">1</property> + </packing> + </child> + <child> + <object class="GtkComboBox" id="proxies_combobox"> + <property name="width_request">250</property> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="margin_bottom">18</property> + <child> + <object class="GtkCellRendererText"/> + <attributes> + <attribute name="text">0</attribute> + </attributes> + </child> + </object> + <packing> + <property name="left_attach">1</property> + <property name="top_attach">1</property> + </packing> + </child> + <child> + <object class="GtkButton" id="manage_proxies_button"> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="receives_default">False</property> + <property name="tooltip_text" translatable="yes">Manage Proxies...</property> + <property name="halign">start</property> + <property name="valign">start</property> + <child> + <object class="GtkImage"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="icon_name">preferences-system-symbolic</property> + </object> + </child> + </object> + <packing> + <property name="left_attach">2</property> + <property name="top_attach">1</property> + </packing> + </child> + <child> + <object class="GtkLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="margin_bottom">12</property> + <property name="label" translatable="yes">Advanced Settings</property> + <style> + <class name="large-header"/> + </style> + </object> + <packing> + <property name="left_attach">0</property> + <property name="top_attach">0</property> + <property name="width">3</property> + </packing> + </child> + <child> + <object class="GtkComboBoxText" id="con_type_combo"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="active">0</property> + <items> + <item translatable="yes">START TLS</item> + <item translatable="yes">DIRECT TLS</item> + <item translatable="yes">PLAIN</item> + </items> + </object> + <packing> + <property name="left_attach">1</property> + <property name="top_attach">4</property> + </packing> + </child> + <child> + <object class="GtkLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="halign">end</property> + <property name="label" translatable="yes">_Type</property> + <property name="use_underline">True</property> + <property name="mnemonic_widget">con_type_combo</property> + <style> + <class name="dim-label"/> + </style> + </object> + <packing> + <property name="left_attach">0</property> + <property name="top_attach">4</property> + </packing> + </child> + <child> + <placeholder/> + </child> + <child> + <placeholder/> + </child> + <child> + <placeholder/> + </child> + </object> + <object class="GtkEntryCompletion" id="entrycompletion1"> + <property name="text_column">0</property> + <property name="inline_completion">True</property> + <property name="popup_completion">False</property> + <property name="popup_single_match">False</property> + </object> + <object class="GtkBox" id="login_box"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="halign">center</property> + <property name="valign">center</property> + <property name="orientation">vertical</property> + <property name="spacing">6</property> + <child> + <object class="GtkLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="margin_bottom">12</property> + <property name="label" translatable="yes">Welcome</property> + <style> + <class name="large-header"/> + </style> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">0</property> + </packing> + </child> + <child> + <object class="GtkLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="halign">center</property> + <property name="label" translatable="yes">Please enter your credentials or Sign Up</property> + <property name="wrap">True</property> + <property name="max_width_chars">40</property> + <style> + <class name="dim-label"/> + </style> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">1</property> + </packing> + </child> + <child> + <object class="GtkEntry" id="log_in_address_entry"> + <property name="width_request">300</property> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="tooltip_text" translatable="yes">Your XMPP address (e.g. user(a)example.org)</property> + <property name="activates_default">True</property> + <property name="placeholder_text" translatable="yes">user(a)example.org</property> + <property name="completion">entrycompletion1</property> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">2</property> + </packing> + </child> + <child> + <object class="GtkEntry" id="log_in_password_entry"> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="tooltip_text" translatable="yes">Your password</property> + <property name="visibility">False</property> + <property name="activates_default">True</property> + <property name="placeholder_text" translatable="yes">Password</property> + <property name="input_purpose">password</property> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">3</property> + </packing> + </child> + <child> + <object class="GtkCheckButton" id="login_advanced_checkbutton"> + <property name="label" translatable="yes">_Advanced Settings</property> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="receives_default">False</property> + <property name="tooltip_text" translatable="yes">Proxy, custom hostname and port</property> + <property name="halign">start</property> + <property name="use_underline">True</property> + <property name="draw_indicator">True</property> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">4</property> + </packing> + </child> + <child> + <object class="GtkButton" id="log_in_button"> + <property name="label" translatable="yes">_Log In</property> + <property name="visible">True</property> + <property name="sensitive">False</property> + <property name="can_focus">True</property> + <property name="receives_default">False</property> + <property name="tooltip_text" translatable="yes">Log in with your credentials</property> + <property name="use_underline">True</property> + <style> + <class name="suggested-action"/> + </style> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">5</property> + </packing> + </child> + <child> + <object class="GtkLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="label" translatable="yes">or</property> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">6</property> + </packing> + </child> + <child> + <object class="GtkButton" id="sign_up_button"> + <property name="label" translatable="yes">_Sign Up</property> + <property name="visible">True</property> + <property name="sensitive">False</property> + <property name="can_focus">True</property> + <property name="receives_default">True</property> + <property name="tooltip_text" translatable="yes">Sign up for a new account on a server of your choice</property> + <property name="use_underline">True</property> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">7</property> + </packing> + </child> + </object> + <object class="GtkEntryCompletion" id="entrycompletion2"> + <property name="text_column">0</property> + <property name="inline_completion">True</property> + <property name="popup_completion">False</property> + <property name="popup_single_match">False</property> + </object> + <object class="GtkBox" id="security_warning_box"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="orientation">vertical</property> + <property name="spacing">18</property> + <child> + <object class="GtkImage"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="halign">center</property> + <property name="icon_name">application-certificate-symbolic</property> + <property name="icon_size">6</property> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">0</property> + </packing> + </child> + <child> + <object class="GtkLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="halign">center</property> + <property name="label" translatable="yes">Certificate Verification Failed</property> + <property name="wrap">True</property> + <property name="xalign">0</property> + <style> + <class name="large-header"/> + </style> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">1</property> + </packing> + </child> + <child> + <object class="GtkLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="halign">center</property> + <property name="label" translatable="yes">The following warnings came up while trying to verify the server's certificate</property> + <property name="wrap">True</property> + <property name="max_width_chars">42</property> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">2</property> + </packing> + </child> + <child> + <object class="GtkListBox" id="error_list"> + <property name="width_request">300</property> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="halign">center</property> + <property name="selection_mode">none</property> + <style> + <class name="tls-error-list"/> + </style> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">3</property> + </packing> + </child> + <child> + <object class="GtkButton" id="view_cert_button"> + <property name="label" translatable="yes">_Show Certificate</property> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="receives_default">True</property> + <property name="halign">center</property> + <property name="use_underline">True</property> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">4</property> + </packing> + </child> + <child> + <object class="GtkCheckButton" id="trust_cert_checkbutton"> + <property name="label" translatable="yes">_Add to Trusted Certificates</property> + <property name="can_focus">True</property> + <property name="receives_default">False</property> + <property name="no_show_all">True</property> + <property name="halign">center</property> + <property name="use_underline">True</property> + <property name="draw_indicator">True</property> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">5</property> + </packing> + </child> + </object> + <object class="GtkPopover" id="server_recommendations"> + <property name="width_request">350</property> + <property name="can_focus">False</property> + <child> + <object class="GtkBox"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="border_width">12</property> + <property name="orientation">vertical</property> + <property name="spacing">6</property> + <child> + <object class="GtkLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="label" translatable="yes">Which server should I choose?</property> + <style> + <class name="bold"/> + </style> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">0</property> + </packing> + </child> + <child> + <object class="GtkLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="label" translatable="yes">There are plenty of servers to choose from. +Creating an account on one server allows you to communicate with contacts from other servers as well.</property> + <property name="wrap">True</property> + <property name="max_width_chars">40</property> + <property name="xalign">0</property> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">1</property> + </packing> + </child> + <child> + <object class="GtkButton" id="visit_server_button"> + <property name="label" translatable="yes">Visit Server's Website</property> + <property name="can_focus">True</property> + <property name="receives_default">True</property> + <property name="no_show_all">True</property> + <property name="halign">center</property> + <style> + <class name="suggested-action"/> + </style> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">2</property> + </packing> + </child> + <child> + <object class="GtkLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="margin_top">3</property> + <property name="label" translatable="yes">Listing of Servers</property> + <property name="wrap">True</property> + <property name="max_width_chars">40</property> + <property name="xalign">0</property> + <style> + <class name="bold"/> + </style> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">3</property> + </packing> + </child> + <child> + <object class="GtkLabel" id="recommendation_link1"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="label" translatable="yes"><a href='https://xmpp.org/getting-started/'>xmpp.org/getting-started</a></property> + <property name="use_markup">True</property> + <property name="wrap">True</property> + <property name="wrap_mode">word-char</property> + <property name="max_width_chars">40</property> + <property name="xalign">0</property> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">4</property> + </packing> + </child> + <child> + <object class="GtkLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="margin_top">3</property> + <property name="label" translatable="yes">A Feature Comparison of Various Servers</property> + <property name="wrap">True</property> + <property name="max_width_chars">40</property> + <property name="xalign">0</property> + <style> + <class name="bold"/> + </style> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">5</property> + </packing> + </child> + <child> + <object class="GtkLabel" id="recommendation_link2"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="label" translatable="yes"><a href='https://conversations.im/compliance/'>conversations.im/compliance</a></property> + <property name="use_markup">True</property> + <property name="wrap">True</property> + <property name="wrap_mode">word-char</property> + <property name="max_width_chars">40</property> + <property name="xalign">0</property> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">6</property> + </packing> + </child> + </object> + </child> + </object> + <object class="GtkGrid" id="signup_grid"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="halign">center</property> + <property name="row_spacing">6</property> + <property name="column_spacing">12</property> + <child> + <object class="GtkLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="margin_bottom">12</property> + <property name="label" translatable="yes">Sign Up</property> + <style> + <class name="large-header"/> + </style> + </object> + <packing> + <property name="left_attach">0</property> + <property name="top_attach">0</property> + <property name="width">2</property> + </packing> + </child> + <child> + <object class="GtkLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="label" translatable="yes">_Please choose a server</property> + <property name="use_markup">True</property> + <property name="use_underline">True</property> + <style> + <class name="dim-label"/> + </style> + </object> + <packing> + <property name="left_attach">0</property> + <property name="top_attach">1</property> + <property name="width">2</property> + </packing> + </child> + <child> + <object class="GtkMenuButton"> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="receives_default">True</property> + <property name="tooltip_text" translatable="yes">Which server should I choose?</property> + <property name="popover">server_recommendations</property> + <child> + <object class="GtkImage"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="icon_name">dialog-information-symbolic</property> + </object> + </child> + </object> + <packing> + <property name="left_attach">1</property> + <property name="top_attach">2</property> + </packing> + </child> + <child> + <object class="GtkComboBoxText" id="server_comboboxtext_sign_up"> + <property name="width_request">300</property> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="has_entry">True</property> + <child internal-child="entry"> + <object class="GtkEntry" id="server_comboboxtext_sign_up_entry"> + <property name="can_focus">True</property> + <property name="activates_default">True</property> + <property name="placeholder_text" translatable="yes">example.org</property> + <property name="completion">entrycompletion2</property> + <property name="input_purpose">url</property> + </object> + </child> + </object> + <packing> + <property name="left_attach">0</property> + <property name="top_attach">2</property> + </packing> + </child> + <child> + <object class="GtkCheckButton" id="sign_up_anonymously"> + <property name="label" translatable="yes">Sign up Anonymously</property> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="receives_default">False</property> + <property name="tooltip_text" translatable="yes">Note: Anonymous accounts are not possible on all servers</property> + <property name="halign">start</property> + <property name="valign">start</property> + <property name="draw_indicator">True</property> + </object> + <packing> + <property name="left_attach">0</property> + <property name="top_attach">3</property> + <property name="width">2</property> + </packing> + </child> + <child> + <object class="GtkCheckButton" id="sign_up_advanced_checkbutton"> + <property name="label" translatable="yes">_Advanced Settings</property> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="receives_default">False</property> + <property name="tooltip_text" translatable="yes">Proxy, custom hostname and port</property> + <property name="halign">start</property> + <property name="use_underline">True</property> + <property name="draw_indicator">True</property> + </object> + <packing> + <property name="left_attach">0</property> + <property name="top_attach">4</property> + <property name="width">2</property> + </packing> + </child> + </object> +</interface> ===================================== gajim/data/style/gajim.css ===================================== @@ -118,6 +118,18 @@ list.settings > row > box { font-weight: bold; color: @insensitive_fg_color;} +/* Account Creation */ +.tls-error-list { + border: 1px solid; border-color: @borders; +} +.tls-error-list > row { + border-bottom: 1px solid; border-color: @theme_unfocused_bg_color; + padding: 6px; +} +.tls-error-list > row:last-child { + border-bottom: 0px +} + /* Start Chat Accounts Treeview */ .start-chat-treeview { padding: 5px; } .start-chat-treeview:focus {outline: none; } ===================================== gajim/gtk/account_wizard.py ===================================== @@ -13,570 +13,704 @@ # along with Gajim. If not, see <http://www.gnu.org/licenses/>. import os +import logging -from gi.repository import Gtk from gi.repository import Gdk from gi.repository import GLib +from gi.repository import Gtk +from gi.repository import Gio -from nbxmpp.modules import dataforms +from nbxmpp.client import Client +from nbxmpp.protocol import JID +from nbxmpp.const import Mode +from nbxmpp.const import StreamError +from nbxmpp.const import ConnectionProtocol +from nbxmpp.const import ConnectionType from gajim.common import app -from gajim.common import ged from gajim.common import configpaths from gajim.common import helpers -from gajim.common import connection +from gajim.common.helpers import open_uri +from gajim.common.helpers import validate_jid +from gajim.common.helpers import get_proxy from gajim.common.i18n import _ -from gajim.common.nec import EventHelper - -from gajim import dataforms_widget -from gajim import gui_menu_builder +from gajim.common.const import SASL_ERRORS +from gajim.common.const import GIO_TLS_ERRORS +from gajim.gtk.assistant import Assistant +from gajim.gtk.assistant import Page +from gajim.gtk.dataform import DataFormWidget from gajim.gtk.util import get_builder -from gajim.gtk.util import get_app_window -from gajim.gtk.dialogs import ErrorDialog -from gajim.gtk.dataform import FakeDataFormWidget +from gajim.gtk.util import open_window +log = logging.getLogger('gajim.gtk.account_wizard') -class AccountCreationWizard(EventHelper): + +class AccountWizard(Assistant): def __init__(self): - EventHelper.__init__(self) - self.xml = get_builder('account_creation_wizard_window.ui') - self.window = self.xml.get_object('account_creation_wizard_window') - active_window = app.app.get_active_window() - self.window.set_transient_for(active_window) + Assistant.__init__(self) + + self._destroyed = False + + self.add_button('signup', _('Sign Up'), complete=True, + css_class='suggested-action') + self.add_button('connect', _('Connect'), css_class='suggested-action') + self.add_button('next', _('Next'), css_class='suggested-action') + self.add_button('login', _('Log In')) + self.add_button('back', _('Back')) - # Connect events from comboboxtext_entry - server_comboboxtext = self.xml.get_object('server_comboboxtext') - entry = self.xml.get_object('server_comboboxtext_entry') - entry.connect('key_press_event', - self.on_entry_key_press_event, server_comboboxtext) + self.add_pages({'login': Login(self._on_button_clicked), + 'signup': Signup(), + 'form': Form(), + 'advanced': AdvancedSettings(), + 'security-warning': SecurityWarning(), + 'success': Success(), + }) - server_comboboxtext1 = self.xml.get_object('server_comboboxtext1') + self._progress = self.add_default_page('progress') + self._error = self.add_default_page('error') + self._error.set_heading(_('An error occurred during account creation')) + + self.set_button_visible_func(self._visible_func) + + self.connect('button-clicked', self._on_button_clicked) + self.connect('page-changed', self._on_page_changed) + self.connect('destroy', self._on_destroy) + + self.show_all() self.update_proxy_list() - # parse servers.json + self._client = None + self._method = 'login' + + def _visible_func(self, _assistant, page_name): + if page_name in ('signup', 'form'): + return ['back', 'signup'] + + if page_name in ('security-warning', 'advanced'): + return ['back', self._method] + + if page_name in ('login', 'progress'): + return None + + if page_name == 'error': + return ['back'] + + if page_name == 'success': + return ['connect'] + + raise ValueError('page %s unknown' % page_name) + + def _on_button_clicked(self, _assistant, button_name): + page = self.get_current_page() + + if button_name == 'login': + if page == 'login': + if self.get_page('login').is_advanced(): + self.show_page('advanced', + Gtk.StackTransitionType.SLIDE_LEFT) + else: + self._test_credentials() + + elif page == 'advanced': + self._test_credentials() + + elif page == 'security-warning': + if self.get_page('security-warning').is_add_to_trusted: + app.cert_store.add_certificate( + self.get_page('security-warning').cert) + self._test_credentials(ignore_all_errors=True) + + elif button_name == 'signup': + if page == 'login': + self.show_page('signup', Gtk.StackTransitionType.SLIDE_LEFT) + + elif page == 'signup': + if self.get_page('signup').is_advanced(): + self.show_page('advanced', + Gtk.StackTransitionType.SLIDE_LEFT) + else: + self._register_with_server() + + elif page == 'advanced': + self._register_with_server() + + elif page == 'security-warning': + if self.get_page('security-warning').is_add_to_trusted: + app.cert_store.add_certificate( + self.get_page('security-warning').cert) + self._register_with_server(ignore_all_errors=True) + + elif page == 'form': + self._show_progress_page(_('Creating Account...'), + _('Trying to create account...')) + self._submit_form() + + elif button_name == 'connect': + if page == 'success': + # if self.get_page('success').is_update(): + # app.interface.show_vcard_when_connect.append(self.account) + app.interface.enable_account(self.get_page('success').account) + self.destroy() + + elif button_name == 'back': + if page == 'signup': + self.show_page('login', Gtk.StackTransitionType.SLIDE_RIGHT) + + elif page in ('advanced', 'error', 'security-warning'): + self.show_page(self._method, + Gtk.StackTransitionType.SLIDE_RIGHT) + + elif page == 'form': + # TODO: Disconnect + self.get_page('form').remove_form() + self.show_page('signup', Gtk.StackTransitionType.SLIDE_RIGHT) + + def _on_page_changed(self, _assistant, page_name): + if page_name == 'signup': + self._method = page_name + self.set_default_button('signup') + + elif page_name == 'login': + self._method = page_name + self.get_page('login').focus() + + elif page_name == 'security-warning': + self.set_default_button('back') + + elif page_name == 'advanced': + self.set_default_button(self._method) + + elif page_name == 'success': + self.set_default_button('connect') + + elif page_name == 'error': + self.set_default_button('back') + + def update_proxy_list(self): + self.get_page('advanced').update_proxy_list() + + def _on_destroy(self, *args): + self._destroyed = True + + def _get_base_client(self, + domain, + username, + mode, + advanced, + ignore_all_errors): + + client = Client() + client.set_domain(domain) + client.set_username(username) + client.set_mode(Mode.LOGIN_TEST) + client.set_ignore_tls_errors(ignore_all_errors) + client.set_accepted_certificates( + app.cert_store.get_certificates()) + + if advanced: + custom_host = self.get_page('advanced').get_custom_host() + if custom_host is not None: + client.set_custom_host(*custom_host) + + proxy_name = self.get_page('advanced').get_proxy() + proxy_data = get_proxy(proxy_name) + if proxy_data is not None: + client.set_proxy(proxy_data) + + client.subscribe('disconnected', self._on_disconnected) + client.subscribe('connection-failed', self._on_connection_failed) + return client + + def _test_credentials(self, ignore_all_errors=False): + self._show_progress_page(_('Connecting...'), + _('Connecting to server...')) + address, password = self.get_page('login').get_data() + jid = JID(address) + advanced = self.get_page('login').is_advanced() + + self._client = self._get_base_client( + jid.getDomain(), + jid.getNode(), + Mode.LOGIN_TEST, + advanced, + ignore_all_errors) + + self._client.set_password(password) + self._client.subscribe('login-successful', self._on_login_successful) + + self._client.connect() + + def _register_with_server(self, ignore_all_errors=False): + self._show_progress_page(_('Connecting...'), + _('Connecting to server...')) + domain = self.get_page('signup').get_server() + advanced = self.get_page('signup').is_advanced() + + self._client = self._get_base_client( + domain, + None, + Mode.REGISTER, + advanced, + ignore_all_errors) + + self._client.subscribe('connected', self._on_connected) + + self._client.connect() + + def _on_login_successful(self, client, _signal_name): + account = self._generate_account_name(client.domain) + app.interface.create_account(account, + client.username, + client.domain, + client.password) + self.get_page('success').set_account(account) + self.show_page('success', Gtk.StackTransitionType.SLIDE_LEFT) + + def _on_connected(self, client, _signal_name): + client.get_module('Register').request_register_form( + callback=self._on_register_form) + + def _on_disconnected(self, client, _signal_name): + domain, error, text = client.get_error() + if domain == StreamError.SASL: + self._show_error_page(_('Authentication failed'), + SASL_ERRORS.get(error), + text or '') + + elif domain == StreamError.BAD_CERTIFICATE: + self.get_page('security-warning').set_warning( + self._client.domain, *self._client.peer_certificate) + self.show_page('security-warning', + Gtk.StackTransitionType.SLIDE_LEFT) + + elif domain == StreamError.REGISTER: + if error == 'register-not-supported': + self._show_error_page(_('Signup not allowed'), + _('Signup not allowed'), + _('This server does not all signup')) + + self._client.destroy() + self._client = None + + def _on_connection_failed(self, _client, _signal_name): + self._show_error_page(_('Connection failed'), + _('Connection failed'), + _('Gajim was not able to reach the server. ' + 'Make sure your XMPP address is correct')) + self._client.destroy() + self._client = None + + def _show_error_page(self, title, heading, text): + self.get_page('error').set_title(title) + self.get_page('error').set_heading(heading) + self.get_page('error').set_text(text or '') + self.show_page('error', Gtk.StackTransitionType.SLIDE_LEFT) + + def _show_progress_page(self, title, text): + self._progress.set_title(title) + self._progress.set_text(text) + self.show_page('progress', Gtk.StackTransitionType.SLIDE_LEFT) + + @staticmethod + def _generate_account_name(domain): + i = 1 + while domain in app.config.get_per('accounts'): + domain = domain + str(i) + i += 1 + return domain + + def _on_register_form(self, result): + if result.form is None: + # Invalid form + return + + if result.bob_data is not None: + algo_hash = result.bob_data.cid.split('@')[0] + app.bob_cache[algo_hash] = result.bob_data.data + self.get_page('form').add_form(result.form) + self.show_page('form', Gtk.StackTransitionType.SLIDE_LEFT) + + def _submit_form(self): + pass + # if self.is_form: + # form = self.get_page('form').get_data_form() + # else: + # form = self.get_page('form').get_submit_form() + # app.connections[self.account].send_new_account_infos( + # form, self.is_form) + # self.get_page('progress').set_text(_('Account is being created')) + # self.show_page('progress', Gtk.StackTransitionType.SLIDE_LEFT) + # self.get_page('form').remove_form() + + +class Login(Page): + def __init__(self, button_callback): + Page.__init__(self) + self.title = _('Add Account') + self._button_callback = button_callback + + self._ui = get_builder('account_wizard.ui') + self._ui.log_in_address_entry.connect( + 'activate', self._on_address_entry_activate) + self._ui.log_in_address_entry.connect( + 'changed', self._on_address_changed) + self._ui.log_in_password_entry.connect( + 'changed', self._set_complete) + self._ui.log_in_password_entry.connect( + 'activate', self._on_password_entry_activate) + self._create_server_completion() + + self._ui.log_in_button.connect('clicked', self._on_login) + self._ui.sign_up_button.connect('clicked', self._on_signup) + + self.pack_start(self._ui.login_box, True, True, 0) + self.show_all() + + def focus(self): + self._ui.log_in_address_entry.grab_focus() + + def _on_login(self, *args): + self._button_callback(self.get_toplevel(), 'login') + + def _on_signup(self, *args): + self._button_callback(self.get_toplevel(), 'signup') + + def _create_server_completion(self): + # Parse servers.json server_file_path = os.path.join( configpaths.get('DATA'), 'other', 'servers.json') - servers = helpers.load_json(server_file_path, 'servers', []) + self._servers = helpers.load_json(server_file_path, 'servers', []) + + # Create a separate model for the address entry, because it will + # be updated with our localpart@ + address_model = Gtk.ListStore(str) + for server in self._servers: + address_model.append((server,)) + self._ui.log_in_address_entry.get_completion().set_model(address_model) + + def _on_address_changed(self, entry): + self._update_completion(entry) + self._set_complete() + + def _update_completion(self, entry): + text = entry.get_text() + if '@' not in text: + self._show_icon(False) + return + text = text.split('@', 1)[0] + + model = entry.get_completion().get_model() + model.clear() + + for server in self._servers: + model.append(['%s@%s' % (text, server)]) + + def _show_icon(self, show): + icon = 'dialog-warning-symbolic' if show else None + self._ui.log_in_address_entry.set_icon_from_icon_name( + Gtk.EntryIconPosition.SECONDARY, icon) + + def _on_address_entry_activate(self, _widget): + GLib.idle_add(self._ui.log_in_password_entry.grab_focus) - servers_model = self.xml.get_object('server_liststore') - for server in servers: + def _on_password_entry_activate(self, _widget): + if self._ui.log_in_button.get_sensitive(): + self._ui.log_in_button.activate() + + def _validate_jid(self, address): + if not address: + self._show_icon(False) + return False + + try: + jid = validate_jid(address, type_='bare') + if jid.getResource(): + raise ValueError + except ValueError: + self._show_icon(True) + self._ui.log_in_address_entry.set_icon_tooltip_text( + Gtk.EntryIconPosition.SECONDARY, _('Invalid Address')) + return False + + self._show_icon(False) + return True + + def _set_complete(self, *args): + address = self._validate_jid(self._ui.log_in_address_entry.get_text()) + password = self._ui.log_in_password_entry.get_text() + self._ui.log_in_button.set_sensitive(address and password) + + def is_advanced(self): + return self._ui.login_advanced_checkbutton.get_active() + + def get_data(self): + data = (self._ui.log_in_address_entry.get_text(), + self._ui.log_in_password_entry.get_text()) + return data + + +class Signup(Page): + def __init__(self): + Page.__init__(self) + self.complete = False + self.title = _('Create New Account') + + # Parse servers.json + server_file_path = os.path.join( + configpaths.get('DATA'), 'other', 'servers.json') + self._servers = helpers.load_json(server_file_path, 'servers', []) + + self._ui = get_builder('account_wizard.ui') + self._ui.server_comboboxtext_sign_up_entry.set_activates_default(True) + self._create_server_completion() + + self._ui.recommendation_link1.connect( + 'activate-link', self._on_activate_link) + self._ui.recommendation_link2.connect( + 'activate-link', self._on_activate_link) + self._ui.visit_server_button.connect('clicked', + self._on_visit_server) + self._ui.server_comboboxtext_sign_up_entry.connect( + 'changed', self._set_complete) + + self.pack_start(self._ui.signup_grid, True, True, 0) + + self.show_all() + + def _create_server_completion(self): + # Parse servers.json + server_file_path = os.path.join( + configpaths.get('DATA'), 'other', 'servers.json') + self._servers = helpers.load_json(server_file_path, 'servers', []) + + # Create servers_model for comboboxes and entries + servers_model = Gtk.ListStore(str) + for server in self._servers: servers_model.append((server,)) - server_comboboxtext.set_model(servers_model) - server_comboboxtext1.set_model(servers_model) - - # Generic widgets - self.notebook = self.xml.get_object('notebook') - self.cancel_button = self.xml.get_object('cancel_button') - self.back_button = self.xml.get_object('back_button') - self.forward_button = self.xml.get_object('forward_button') - self.finish_button = self.xml.get_object('finish_button') - self.advanced_button = self.xml.get_object('advanced_button') - self.finish_label = self.xml.get_object('finish_label') - self.go_online_checkbutton = self.xml.get_object( - 'go_online_checkbutton') - self.show_vcard_checkbutton = self.xml.get_object( - 'show_vcard_checkbutton') - self.progressbar = self.xml.get_object('progressbar') - - # some vars - self.update_progressbar_timeout_id = None - - self.notebook.set_current_page(0) - self.xml.connect_signals(self) - self.window.show_all() - - self.register_events([ - ('new-account-connected', ged.GUI1, self._nec_new_acc_connected), - ('new-account-not-connected', ged.GUI1, self._nec_new_acc_not_connected), - ('account-created', ged.GUI1, self._nec_acc_is_ok), - ('account-not-created', ged.GUI1, self._nec_acc_is_not_ok), - ]) - - def on_wizard_window_destroy(self, widget): - page = self.notebook.get_current_page() - if page in (4, 5) and self.account in app.connections: - # connection instance is saved in app.connections and we canceled - # the addition of the account - del app.connections[self.account] - if self.account in app.config.get_per('accounts'): - app.config.del_per('accounts', self.account) - self.unregister_events() - del app.interface.instances['account_creation_wizard'] - - def on_save_password_checkbutton_toggled(self, widget): - self.xml.get_object('password_entry').grab_focus() - - def on_cancel_button_clicked(self, widget): - self.window.destroy() - - def on_back_button_clicked(self, widget): - cur_page = self.notebook.get_current_page() - self.forward_button.set_sensitive(True) - if cur_page in (1, 2): - self.notebook.set_current_page(0) - self.back_button.set_sensitive(False) - elif cur_page == 3: - self.xml.get_object('form_vbox').remove(self.data_form_widget) - self.notebook.set_current_page(2) # show server page - elif cur_page == 4: - if self.account in app.connections: - del app.connections[self.account] - if self.account in app.config.get_per('accounts'): - app.config.del_per('accounts', self.account) - self.notebook.set_current_page(2) - self.xml.get_object('form_vbox').remove(self.data_form_widget) - elif cur_page == 6: # finish page - self.forward_button.show() - if self.modify: - self.notebook.set_current_page(1) # Go to parameters page - else: - self.notebook.set_current_page(2) # Go to server page - - def on_anonymous_checkbutton1_toggled(self, widget): - active = widget.get_active() - self.xml.get_object('username_entry').set_sensitive(not active) - self.xml.get_object('password_entry').set_sensitive(not active) - self.xml.get_object('save_password_checkbutton').set_sensitive( - not active) - - def show_finish_page(self): - self.cancel_button.hide() - self.back_button.hide() - self.forward_button.hide() - if self.modify: - finish_text = '<big><b>%s</b></big>\n\n%s' % ( - _('Account has been added successfully'), - _('You can set advanced account options by pressing the ' - 'Advanced button, or later by choosing the Accounts menu item ' - 'under the Edit menu from the main window.')) - else: - finish_text = '<big><b>%s</b></big>\n\n%s' % ( - _('Your new account has been created successfully'), - _('You can set advanced account options by pressing the ' - 'Advanced button, or later by choosing the Accounts menu item ' - 'under the Edit menu from the main window.')) - self.finish_label.set_markup(finish_text) - self.finish_button.show() - self.finish_button.set_property('has-default', True) - self.advanced_button.show() - self.go_online_checkbutton.show() - img = self.xml.get_object('finish_image') - if self.modify: - img.set_from_icon_name('emblem-ok-symbolic', Gtk.IconSize.DIALOG) - img.get_style_context().add_class('success-color') - else: - img.set_from_icon_name('org.gajim.Gajim', Gtk.IconSize.DIALOG) - self.show_vcard_checkbutton.set_active(not self.modify) - self.notebook.set_current_page(6) # show finish page - - def on_forward_button_clicked(self, widget): - cur_page = self.notebook.get_current_page() - - if cur_page == 0: - widget = self.xml.get_object('use_existing_account_radiobutton') - if widget.get_active(): - self.modify = True - self.notebook.set_current_page(1) - else: - self.modify = False - self.notebook.set_current_page(2) - self.back_button.set_sensitive(True) - return + # Sign up combobox and entry + self._ui.server_comboboxtext_sign_up.set_model(servers_model) + self._ui.server_comboboxtext_sign_up_entry.get_completion().set_model( + servers_model) + + def _on_visit_server(self, _widget): + server = self._ui.server_comboboxtext_sign_up_entry.get_text().strip() + server = 'https://' + server + open_uri(server) + return Gdk.EVENT_STOP + + def _check_port_entry(self): + port = self._ui.custom_port_entry.get_text() + if port == '': + self._show_icon(False) + return False + try: + port = int(port) + except Exception: + self._show_icon(True) + self._ui.custom_port_entry.set_icon_tooltip_text( + Gtk.EntryIconPosition.SECONDARY, _('Must be a port number')) + return False + + if port not in range(0, 65535): + self._show_icon(True) + self._ui.custom_port_entry.set_icon_tooltip_text( + Gtk.EntryIconPosition.SECONDARY, + _('Port must be a number between 0 and 65535')) + return False + + self._show_icon(False) + return True + + def _show_icon(self, show): + icon = 'dialog-warning-symbolic' if show else None + self._ui.log_in_address_entry.set_icon_from_icon_name( + Gtk.EntryIconPosition.SECONDARY, icon) + + def _set_complete(self, *args): + server = self._ui.server_comboboxtext_sign_up_entry.get_text() + self._ui.visit_server_button.set_visible(server) + self.complete = server + self.get_toplevel().update_page_complete() + + def is_anonymous(self): + return self._ui.sign_up_anonymously.get_active() + + def is_advanced(self): + return self._ui.sign_up_advanced_checkbutton.get_active() + + def get_server(self): + return self._ui.server_comboboxtext_sign_up_entry.get_text() + + @staticmethod + def _on_activate_link(_label, uri): + # We have to use this, because the default GTK handler + # is not cross-platform compatible + open_uri(uri) + return Gdk.EVENT_STOP + + +class AdvancedSettings(Page): + def __init__(self): + Page.__init__(self) + self.title = _('Advanced settings') - if cur_page == 1: - # We are adding an existing account - anonymous = self.xml.get_object('anonymous_checkbutton1').\ - get_active() - username = self.xml.get_object('username_entry').get_text().strip() - if not username and not anonymous: - pritext = _('Invalid username') - sectext = _( - 'You must provide a username to configure this account.') - ErrorDialog(pritext, sectext) - return - server = self.xml.get_object('server_comboboxtext_entry').\ - get_text().strip() - savepass = self.xml.get_object('save_password_checkbutton').\ - get_active() - password = self.xml.get_object('password_entry').get_text() - - if anonymous: - jid = '' - else: - jid = username + '@' - jid += server - # check if jid is conform to RFC and stringprep it - try: - jid = helpers.parse_jid(jid) - except helpers.InvalidFormat as s: - pritext = _('Invalid XMPP Address') - ErrorDialog(pritext, str(s)) - return - - self.account = server - i = 1 - while self.account in app.config.get_per('accounts'): - self.account = server + str(i) - i += 1 - - username, server = app.get_name_and_server_from_jid(jid) - if self.xml.get_object('anonymous_checkbutton1').get_active(): - self.save_account('', server, False, '', anonymous=True) - else: - self.save_account(username, server, savepass, password) - self.show_finish_page() - elif cur_page == 2: - # We are creating a new account - server = self.xml.get_object('server_comboboxtext_entry1').\ - get_text() - - if not server: - ErrorDialog( - _('Invalid server'), - _('Please provide a server on which you want to register.')) - return - self.account = server - i = 1 - while self.account in app.config.get_per('accounts'): - self.account = server + str(i) - i += 1 - - config = self.get_config('', server, '', '') - # Get advanced options - proxies_combobox = self.xml.get_object('proxies_combobox') - active = proxies_combobox.get_active() - proxy = proxies_combobox.get_model()[active][0] - if proxy == _('None'): - proxy = '' - config['proxy'] = proxy - - config['use_custom_host'] = self.xml.get_object( - 'custom_host_port_checkbutton').get_active() - custom_port = self.xml.get_object('custom_port_entry').get_text() - try: - custom_port = int(custom_port) - except Exception: - ErrorDialog( - _('Invalid entry'), - _('Custom port must be a port number.')) - return - config['custom_port'] = custom_port - config['custom_host'] = self.xml.get_object( - 'custom_host_entry').get_text() - - if self.xml.get_object('anonymous_checkbutton2').get_active(): - self.modify = True - self.save_account('', server, False, '', anonymous=True) - self.show_finish_page() - else: - self.notebook.set_current_page(5) # show creating page - self.back_button.hide() - self.forward_button.hide() - self.update_progressbar_timeout_id = GLib.timeout_add( - 100, self.update_progressbar) - # Get form from serveur - con = connection.Connection(self.account) - app.connections[self.account] = con - con.new_account(self.account, config) - elif cur_page == 3: - checked = self.xml.get_object('ssl_checkbutton').get_active() - if checked: - hostname = app.connections[self.account].new_account_info[ - 'hostname'] - # Check if cert is already in file - certs = '' - my_ca_certs = configpaths.get('MY_CACERTS') - if os.path.isfile(my_ca_certs): - with open(my_ca_certs) as f: - certs = f.read() - if self.ssl_cert in certs: - ErrorDialog( - _('Certificate Already in File'), - _('This certificate is already in file %s, so it\'s ' - 'not added again.') % my_ca_certs) - else: - with open(my_ca_certs, 'a') as f: - f.write(hostname + '\n') - f.write(self.ssl_cert + '\n\n') - app.connections[self.account].new_account_info[ - 'ssl_fingerprint_sha1'] = self.ssl_fingerprint_sha1 - app.connections[self.account].new_account_info[ - 'ssl_fingerprint_sha256'] = self.ssl_fingerprint_sha256 - self.notebook.set_current_page(4) # show fom page - elif cur_page == 4: - if self.is_form: - form = self.data_form_widget.data_form - else: - form = self.data_form_widget.get_submit_form() - app.connections[self.account].send_new_account_infos( - form, self.is_form) - self.xml.get_object('form_vbox').remove(self.data_form_widget) - self.xml.get_object('progressbar_label').set_markup( - '<b>Account is being created</b>\n\nPlease wait…') - self.notebook.set_current_page(5) # show creating page - self.back_button.hide() - self.forward_button.hide() - self.update_progressbar_timeout_id = GLib.timeout_add( - 100, self.update_progressbar) + self._ui = get_builder('account_wizard.ui') + self._ui.manage_proxies_button.connect('clicked', + self._on_proxy_manager) + self.pack_start(self._ui.advanced_grid, True, True, 0) + + self.show_all() + + @staticmethod + def _on_proxy_manager(_widget): + app.app.activate_action('manage-proxies') def update_proxy_list(self): - proxies_combobox = self.xml.get_object('proxies_combobox') model = Gtk.ListStore(str) - proxies_combobox.set_model(model) + self._ui.proxies_combobox.set_model(model) proxies = app.config.get_per('proxies') - proxies.insert(0, _('None')) + proxies.insert(0, _('No Proxy')) for proxy in proxies: model.append([proxy]) - proxies_combobox.set_active(0) + self._ui.proxies_combobox.set_active(0) - def on_manage_proxies_button_clicked(self, _widget): - app.app.activate_action('manage-proxies') + def get_proxy(self): + active = self._ui.proxies_combobox.get_active() + return self._ui.proxies_combobox.get_model()[active][0] - def on_custom_host_port_checkbutton_toggled(self, widget): - self.xml.get_object('custom_host_hbox').set_sensitive( - widget.get_active()) + def get_custom_host(self): + host = self._ui.custom_host_entry.get_text() + port = self._ui.custom_port_entry.get_text() + if not host or not port: + return None - def update_progressbar(self): - self.progressbar.pulse() - return True # loop forever + con_type = self._ui.con_type_combo.get_active_text() - def _nec_new_acc_connected(self, obj): - """ - Connection to server succeded, present the form to the user - """ - # We receive events from all accounts from GED - if obj.conn.name != self.account: - return - if self.update_progressbar_timeout_id is not None: - GLib.source_remove(self.update_progressbar_timeout_id) - self.back_button.show() - self.forward_button.show() - self.is_form = obj.is_form - empty_config = True - if obj.is_form: - dataform = dataforms.extend_form(node=obj.config) - self.data_form_widget = dataforms_widget.DataFormWidget() - self.data_form_widget.selectable = True - self.data_form_widget.set_data_form(dataform) - empty_config = False - else: - self.data_form_widget = FakeDataFormWidget(obj.config) - for field in obj.config: - if field in ('key', 'instructions', 'x', 'registered'): - continue - empty_config = False - break - self.data_form_widget.show_all() - self.xml.get_object('form_vbox').pack_start( - self.data_form_widget, True, True, 0) - if empty_config: - self.forward_button.set_sensitive(False) - self.notebook.set_current_page(4) # show form page - return - self.ssl_fingerprint_sha1 = obj.ssl_fingerprint_sha1 - self.ssl_fingerprint_sha256 = obj.ssl_fingerprint_sha256 - self.ssl_cert = obj.ssl_cert - if obj.ssl_msg: - # An SSL warning occured, show it - hostname = app.connections[self.account].new_account_info[ - 'hostname'] - self.xml.get_object('ssl_label').set_markup(_( - '<b>Security Warning</b>' - '\n\nThe authenticity of the %(hostname)s SSL certificate could' - ' be invalid.\nSSL Error: %(error)s\n' - 'Do you still want to connect to this server?') % { - 'hostname': hostname, 'error': obj.ssl_msg}) - if obj.errnum in (18, 27): - text = _( - 'Add this certificate to the list of trusted ' - 'certificates.\nSHA-1 fingerprint of the certificate:\n' - '%(sha1)s\nSHA-256 fingerprint of the certificate:\n' - '%(sha256)s') % {'sha1': obj.ssl_fingerprint_sha1, - 'sha256': obj.ssl_fingerprint_sha256} - self.xml.get_object('ssl_checkbutton').set_label(text) - else: - self.xml.get_object('ssl_checkbutton').set_no_show_all(True) - self.xml.get_object('ssl_checkbutton').hide() - self.notebook.set_current_page(3) # show SSL page - else: - self.notebook.set_current_page(4) # show form page - - def _nec_new_acc_not_connected(self, obj): - """ - Account creation failed: connection to server failed - """ - # We receive events from all accounts from GED - if obj.conn.name != self.account: - return - if self.account not in app.connections: - return - if self.update_progressbar_timeout_id is not None: - GLib.source_remove(self.update_progressbar_timeout_id) - del app.connections[self.account] - if self.account in app.config.get_per('accounts'): - app.config.del_per('accounts', self.account) - self.back_button.show() - self.cancel_button.show() - self.go_online_checkbutton.hide() - self.show_vcard_checkbutton.hide() - img = self.xml.get_object('finish_image') - img.set_from_icon_name("dialog-error", Gtk.IconSize.DIALOG) - finish_text = '<big><b>%s</b></big>\n\n%s' % ( - _('An error occurred during account creation'), obj.reason) - self.finish_label.set_markup(finish_text) - self.notebook.set_current_page(6) # show finish page - - def _nec_acc_is_ok(self, obj): - """ - Account creation succeeded - """ - # We receive events from all accounts from GED - if obj.conn.name != self.account: - return - self.create_vars(obj.account_info) - self.show_finish_page() - - # Register plugin modules after successful registration - # Some plugins need the registered JID to function properly - app.plugin_manager.register_modules_for_account(obj.conn) - - if self.update_progressbar_timeout_id is not None: - GLib.source_remove(self.update_progressbar_timeout_id) - - def _nec_acc_is_not_ok(self, obj): - """ - Account creation failed - """ - # We receive events from all accounts from GED - if obj.conn.name != self.account: - return - self.back_button.show() - self.cancel_button.show() - self.go_online_checkbutton.hide() - self.show_vcard_checkbutton.hide() - del app.connections[self.account] - if self.account in app.config.get_per('accounts'): - app.config.del_per('accounts', self.account) - img = self.xml.get_object('finish_image') - img.set_from_icon_name("dialog-error", Gtk.IconSize.DIALOG) - finish_text = '<big><b>%s</b></big>\n\n%s' % (_( - 'An error occurred during account creation'), obj.reason) - self.finish_label.set_markup(finish_text) - self.notebook.set_current_page(6) # show finish page - - if self.update_progressbar_timeout_id is not None: - GLib.source_remove(self.update_progressbar_timeout_id) - - def on_advanced_button_clicked(self, widget): - app.app.activate_action('accounts', GLib.Variant('s', self.account)) - self.window.destroy() - - def on_finish_button_clicked(self, widget): - go_online = self.xml.get_object('go_online_checkbutton').get_active() - show_vcard = self.xml.get_object('show_vcard_checkbutton').get_active() - self.window.destroy() - if show_vcard: - app.interface.show_vcard_when_connect.append(self.account) - if go_online: - app.interface.roster.send_status(self.account, 'online', '') - - def on_username_entry_key_press_event(self, widget, event): - # Check for pressed @ and jump to combobox if found - if event.keyval == Gdk.KEY_at: - entry = self.xml.get_object('server_comboboxtext_entry') - entry.grab_focus() - entry.set_position(-1) - return True - - def on_entry_key_press_event(self, widget, event, combobox): - # If backspace is pressed in empty field, return to the nick entry field - backspace = event.keyval == Gdk.KEY_BackSpace - empty = len(combobox.get_active_text()) == 0 - if backspace and empty and self.modify: - username_entry = self.xml.get_object('username_entry') - username_entry.grab_focus() - username_entry.set_position(-1) - return True - - def get_config(self, login, server, savepass, password, anonymous=False): - config = {} - config['name'] = login - config['account_label'] = '%s@%s' % (login, server) - config['hostname'] = server - config['savepass'] = savepass - config['password'] = password - config['anonymous_auth'] = anonymous - config['priority'] = 5 - config['autoconnect'] = True - config['no_log_for'] = '' - config['sync_with_global_status'] = True - config['proxy'] = '' - config['use_custom_host'] = False - config['custom_port'] = 0 - config['custom_host'] = '' - return config - - def save_account(self, login, server, savepass, password, anonymous=False): - if self.account in app.connections: - ErrorDialog( - _('Account name is in use'), - _('You already have an account using this name.')) - return - con = connection.Connection(self.account) - con.password = password + return ('%s:%s' % (host, port), + ConnectionProtocol.TCP, + ConnectionType(con_type)) - config = self.get_config(login, server, savepass, password, anonymous) - if not self.modify: - con.new_account(self.account, config) - return - app.connections[self.account] = con - self.create_vars(config) - - def create_vars(self, config): - app.config.add_per('accounts', self.account) - - config['account_label'] = '%s@%s' % (config['name'], config['hostname']) - if not config['savepass']: - config['password'] = '' - - for opt in config: - app.config.set_per('accounts', self.account, opt, config[opt]) - - # update variables - app.interface.instances[self.account] = { - 'infos': {}, 'disco': {}, - 'gc_config': {}, 'search': {}, - 'sub_request': {}} - app.interface.minimized_controls[self.account] = {} - app.groups[self.account] = {} - app.contacts.add_account(self.account) - app.gc_connected[self.account] = {} - app.automatic_rooms[self.account] = {} - app.newly_added[self.account] = [] - app.to_be_removed[self.account] = [] - app.nicks[self.account] = config['name'] - app.block_signed_in_notifications[self.account] = True - app.sleeper_state[self.account] = 'off' - app.last_message_time[self.account] = {} - app.status_before_autoaway[self.account] = '' - app.gajim_optional_features[self.account] = [] - app.caps_hash[self.account] = '' - helpers.update_optional_features(self.account) - # action must be added before account window is updated - app.app.add_account_actions(self.account) - # refresh accounts window - window = get_app_window('AccountsWindow') - if window is not None: - window.add_account(self.account) - # refresh roster - if len(app.connections) >= 2: - # Do not merge accounts if only one exists - app.interface.roster.regroup = app.config.get('mergeaccounts') - else: - app.interface.roster.regroup = False - app.interface.roster.setup_and_draw_roster() - gui_menu_builder.build_accounts_menu() +class SecurityWarning(Page): + def __init__(self): + Page.__init__(self) + self.title = _('Security Warning') + self._cert = None + self._domain = None + + self._ui = get_builder('account_wizard.ui') + self.pack_start(self._ui.security_warning_box, True, True, 0) + self._ui.view_cert_button.connect('clicked', self._on_view_cert) + self.show_all() + + @property + def cert(self): + return self._cert + + def set_warning(self, domain, cert, errors): + # Clear list + self._cert = cert + self._domain = domain + self._ui.error_list.foreach(self._ui.error_list.remove) + + unknown_error = _('Unknown TLS error \'%s\'') + for error in errors: + error_text = GIO_TLS_ERRORS.get(error, unknown_error % error) + box = Gtk.Box(orientation=Gtk.Orientation.HORIZONTAL, spacing=6) + image = Gtk.Image.new_from_icon_name('dialog-warning-symbolic', + Gtk.IconSize.LARGE_TOOLBAR) + image.get_style_context().add_class('warning-color') + label = Gtk.Label(label=error_text) + label.set_line_wrap(True) + label.set_xalign(0) + label.set_selectable(True) + box.add(image) + box.add(label) + box.show_all() + self._ui.error_list.add(box) + + self._ui.trust_cert_checkbutton.set_visible( + Gio.TlsCertificateFlags.UNKNOWN_CA in errors) + + def _on_view_cert(self, _button): + open_window('CertificateDialog', + account=self._domain, + transient_for=self.get_toplevel(), + cert=self._cert) + + def is_add_to_trusted(self): + return self._ui.trust_cert_checkbutton.get_active() + + +class Form(Page): + def __init__(self): + Page.__init__(self) + self.set_valign(Gtk.Align.FILL) + self.complete = False + self.title = _('Create Account') + self._current_form = None + + heading = Gtk.Label(label=_('Create Account')) + heading.get_style_context().add_class('large-header') + heading.set_max_width_chars(30) + heading.set_line_wrap(True) + heading.set_halign(Gtk.Align.CENTER) + heading.set_justify(Gtk.Justification.CENTER) + self.pack_start(heading, False, True, 0) + + self.show_all() + + def _on_is_valid(self, _widget, is_valid): + self.complete = is_valid + self.get_toplevel().update_page_complete() + + def add_form(self, form): + self.remove_form() + + options = {'hide-fallback-fields': True} + self._current_form = DataFormWidget(form, options) + self._current_form.connect('is-valid', self._on_is_valid) + self._current_form.validate() + self.pack_start(self._current_form, True, True, 0) + self._current_form.show_all() + + def get_submit_form(self): + return self._current_form.get_submit_form() + + def remove_form(self): + if self._current_form is not None: + self.remove(self._current_form) + self._current_form.destroy() + + +class Success(Page): + def __init__(self): + Page.__init__(self) + self.title = _('Account Added') + self._account = None + + heading = Gtk.Label(label=_('Account has been added successfully')) + heading.get_style_context().add_class('large-header') + heading.set_max_width_chars(30) + heading.set_line_wrap(True) + heading.set_halign(Gtk.Align.CENTER) + heading.set_justify(Gtk.Justification.CENTER) + + icon = Gtk.Image.new_from_icon_name('object-select-symbolic', + Gtk.IconSize.DIALOG) + icon.get_style_context().add_class('success-color') + + self.pack_start(icon, False, True, 0) + self.pack_start(heading, False, True, 0) + + self.show_all() + + def set_account(self, account): + self._account = account + + @property + def account(self): + return self._account ===================================== gajim/gtk/const.py ===================================== @@ -113,7 +113,7 @@ WINDOW_MODULES = { 'SingleMessageWindow': 'gajim.gtk.single_message', 'PrivacyListsWindow': 'gajim.gtk.privacy_list', 'Bookmarks': 'gajim.gtk.bookmarks', - 'AccountCreationWizard': 'gajim.gtk.account_wizard', + 'AccountWizard': 'gajim.gtk.account_wizard', 'HistoryWindow': 'gajim.gtk.history', 'ManageProxies': 'gajim.gtk.proxies', 'ServiceDiscoveryWindow': 'gajim.gtk.discovery', ===================================== gajim/gtk/dataform.py ===================================== @@ -142,6 +142,10 @@ class FormGrid(Gtk.Grid): if field.type_ == 'hidden': continue + if options.get('hide-fallback-fields'): + if 'fallback' in field.var: + continue + if field.media: if not self._add_media_field(field, options): # We dont understand this media element, ignore it ===================================== gajim/gtk/proxies.py ===================================== @@ -52,10 +52,13 @@ class ManageProxies(Gtk.ApplicationWindow): # Window callbacks for updating proxy comboboxes window_pref = get_app_window('Preferences') window_accounts = get_app_window('AccountsWindow') + window_account_wizard = get_app_window('AccountWizard') if window_pref is not None: window_pref.update_proxy_list() if window_accounts is not None: window_accounts.update_proxy_list() + if window_account_wizard is not None: + window_account_wizard.update_proxy_list() def _fill_proxies_treeview(self): model = self._ui.proxies_treeview.get_model() ===================================== gajim/gui_interface.py ===================================== @@ -1680,6 +1680,39 @@ class Interface: app.sleeper_state[account] = 'autoxa' return True # renew timeout (loop for ever) + def create_account(self, + account, + username, + domain, + password, + anonymous=False): + + config = {} + config['active'] = False + config['name'] = username + config['account_label'] = '%s@%s' % (username, domain) + config['hostname'] = domain + config['savepass'] = True + config['password'] = password + config['anonymous_auth'] = anonymous + config['autoconnect'] = True + config['sync_with_global_status'] = True + config['proxy'] = '' + config['use_custom_host'] = False + config['custom_port'] = 0 + config['custom_host'] = '' + + app.config.add_per('accounts', account) + for opt in config: + app.config.set_per('accounts', account, opt, config[opt]) + + # refresh accounts window + # Action must be added before account window is updated + app.app.add_account_actions(account) + window = get_app_window('AccountsWindow') + if window is not None: + window.add_account(account) + def enable_account(self, account): if account == app.ZEROCONF_ACC_NAME: app.connections[account] = connection_zeroconf.ConnectionZeroconf( ===================================== gajim/roster_window.py ===================================== @@ -75,7 +75,6 @@ from gajim.gtk.dialogs import InformationDialog from gajim.gtk.dialogs import InvitationReceivedDialog from gajim.gtk.single_message import SingleMessageWindow from gajim.gtk.add_contact import AddNewContactWindow -from gajim.gtk.account_wizard import AccountCreationWizard from gajim.gtk.service_registration import ServiceRegistration from gajim.gtk.discovery import ServiceDiscoveryWindow from gajim.gtk.tooltips import RosterTooltip @@ -5594,8 +5593,8 @@ class RosterWindow: app.config.get_per('accounts', 'Local', 'active'): # if we have no account configured or only Local account but not enabled def _open_wizard(): - app.interface.instances['account_creation_wizard'] = \ - AccountCreationWizard() + open_window('AccountWizard') + # Open wizard only after roster is created, so we can make it # transient for the roster window GLib.idle_add(_open_wizard) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/a8ccbb4b2acc604fdbccb965eb70405… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/compare/a8ccbb4b2acc604fdbccb965eb70405… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/python-nbxmpp][master] TCP: Set timeout when connecting
by Philipp Hörist 16 Mar '20

16 Mar '20

Philipp Hörist pushed to branch master at gajim / python-nbxmpp Commits: 384b50b0 by lovetox at 2020-03-16T22:29:39+01:00 TCP: Set timeout when connecting - - - - - 1 changed file: - nbxmpp/tcp.py Changes: ===================================== nbxmpp/tcp.py ===================================== @@ -38,6 +38,7 @@ class TCPConnection(Connection): Connection.__init__(self, *args, **kwargs) self._client = Gio.SocketClient.new() + self._client.set_timeout(10) if self._address.proxy is not None: self._proxy_resolver = self._address.proxy.get_resolver() View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/384b50b087c4e7eb0fbb1ca6… -- View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/-/commit/384b50b087c4e7eb0fbb1ca6… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] CertificateDialog: Format numbers
by Philipp Hörist 15 Mar '20

15 Mar '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: a8ccbb4b by Daniel Brötzmann at 2020-03-15T23:03:34+01:00 CertificateDialog: Format numbers - - - - - 2 changed files: - gajim/data/gui/certificate_dialog.ui - gajim/gtk/dialogs.py Changes: ===================================== gajim/data/gui/certificate_dialog.ui ===================================== @@ -1,5 +1,5 @@ <?xml version="1.0" encoding="UTF-8"?> - + <interface> <requires lib="gtk+" version="3.20"/> <object class="GtkBox" id="certificate_box"> @@ -32,7 +32,6 @@ <object class="GtkLabel" id="label_cert_for_account"> <property name="visible">True</property> <property name="can_focus">False</property> - <property name="label"><Certificate for account %s></property> <property name="justify">center</property> <style> <class name="large-header"/> @@ -63,6 +62,7 @@ <property name="visible">True</property> <property name="can_focus">False</property> <property name="halign">end</property> + <property name="valign">start</property> <property name="label" translatable="yes">Common Name (CN)</property> <style> <class name="dim-label"/> @@ -91,6 +91,7 @@ <property name="visible">True</property> <property name="can_focus">False</property> <property name="halign">end</property> + <property name="valign">start</property> <property name="label" translatable="yes">Organization (O)</property> <style> <class name="dim-label"/> @@ -119,6 +120,7 @@ <property name="visible">True</property> <property name="can_focus">False</property> <property name="halign">end</property> + <property name="valign">start</property> <property name="label" translatable="yes">Organizational Unit (OU)</property> <style> <class name="dim-label"/> @@ -147,6 +149,7 @@ <property name="visible">True</property> <property name="can_focus">False</property> <property name="halign">end</property> + <property name="valign">start</property> <property name="label" translatable="yes">Serial Number</property> <style> <class name="dim-label"/> @@ -164,10 +167,12 @@ <property name="halign">start</property> <property name="label"><></property> <property name="wrap">True</property> - <property name="wrap_mode">char</property> + <property name="wrap_mode">word-char</property> <property name="selectable">True</property> - <property name="max_width_chars">30</property> <property name="xalign">0</property> + <attributes> + <attribute name="font-desc" value="Monospace 8"/> + </attributes> </object> <packing> <property name="left_attach">1</property> @@ -179,6 +184,7 @@ <property name="visible">True</property> <property name="can_focus">False</property> <property name="halign">end</property> + <property name="valign">start</property> <property name="label" translatable="yes">Common Name (CN)</property> <style> <class name="dim-label"/> @@ -207,6 +213,7 @@ <property name="visible">True</property> <property name="can_focus">False</property> <property name="halign">end</property> + <property name="valign">start</property> <property name="label" translatable="yes">Organization (O)</property> <style> <class name="dim-label"/> @@ -235,6 +242,7 @@ <property name="visible">True</property> <property name="can_focus">False</property> <property name="halign">end</property> + <property name="valign">start</property> <property name="label" translatable="yes">Organizational Unit (OU)</property> <style> <class name="dim-label"/> @@ -263,6 +271,7 @@ <property name="visible">True</property> <property name="can_focus">False</property> <property name="halign">end</property> + <property name="valign">start</property> <property name="label" translatable="yes">Issued on</property> <style> <class name="dim-label"/> @@ -291,6 +300,7 @@ <property name="visible">True</property> <property name="can_focus">False</property> <property name="halign">end</property> + <property name="valign">start</property> <property name="label" translatable="yes">Expires on</property> <style> <class name="dim-label"/> @@ -318,7 +328,8 @@ <object class="GtkLabel"> <property name="visible">True</property> <property name="can_focus">False</property> - <property name="halign">baseline</property> + <property name="halign">end</property> + <property name="valign">start</property> <property name="label" translatable="yes">SHA-1</property> <style> <class name="dim-label"/> @@ -327,57 +338,53 @@ <packing> <property name="left_attach">0</property> <property name="top_attach">13</property> - <property name="width">2</property> </packing> </child> <child> <object class="GtkLabel"> <property name="visible">True</property> <property name="can_focus">False</property> - <property name="halign">baseline</property> <property name="margin_top">6</property> - <property name="label" translatable="yes">SHA-256</property> + <property name="label" translatable="yes">Issued to</property> <style> - <class name="dim-label"/> + <class name="bold"/> </style> </object> <packing> <property name="left_attach">0</property> - <property name="top_attach">15</property> + <property name="top_attach">0</property> <property name="width">2</property> </packing> </child> <child> - <object class="GtkLabel" id="data_sha1"> + <object class="GtkLabel"> <property name="visible">True</property> <property name="can_focus">False</property> - <property name="halign">center</property> - <property name="label"><></property> - <property name="wrap">True</property> - <property name="wrap_mode">char</property> - <property name="selectable">True</property> - <property name="max_width_chars">52</property> + <property name="margin_top">12</property> + <property name="label" translatable="yes">Issued by</property> + <style> + <class name="bold"/> + </style> </object> <packing> <property name="left_attach">0</property> - <property name="top_attach">14</property> + <property name="top_attach">5</property> <property name="width">2</property> </packing> </child> <child> - <object class="GtkLabel" id="data_sha256"> + <object class="GtkLabel"> <property name="visible">True</property> <property name="can_focus">False</property> - <property name="halign">center</property> - <property name="label"><></property> - <property name="wrap">True</property> - <property name="wrap_mode">char</property> - <property name="selectable">True</property> - <property name="max_width_chars">52</property> + <property name="margin_top">12</property> + <property name="label" translatable="yes">Validity</property> + <style> + <class name="bold"/> + </style> </object> <packing> <property name="left_attach">0</property> - <property name="top_attach">16</property> + <property name="top_attach">9</property> <property name="width">2</property> </packing> </child> @@ -385,68 +392,68 @@ <object class="GtkLabel"> <property name="visible">True</property> <property name="can_focus">False</property> - <property name="halign">baseline</property> - <property name="margin_top">6</property> - <property name="label" translatable="yes">Issued to</property> + <property name="margin_top">12</property> + <property name="label" translatable="yes">Fingerprints</property> <style> <class name="bold"/> </style> </object> <packing> <property name="left_attach">0</property> - <property name="top_attach">0</property> + <property name="top_attach">12</property> <property name="width">2</property> </packing> </child> <child> - <object class="GtkLabel"> + <object class="GtkLabel" id="data_sha1"> <property name="visible">True</property> <property name="can_focus">False</property> - <property name="halign">baseline</property> - <property name="margin_top">12</property> - <property name="label" translatable="yes">Issued by</property> - <style> - <class name="bold"/> - </style> + <property name="halign">start</property> + <property name="label"><></property> + <property name="wrap">True</property> + <property name="wrap_mode">char</property> + <property name="selectable">True</property> + <attributes> + <attribute name="font-desc" value="Monospace 8"/> + </attributes> </object> <packing> - <property name="left_attach">0</property> - <property name="top_attach">5</property> - <property name="width">2</property> + <property name="left_attach">1</property> + <property name="top_attach">13</property> </packing> </child> <child> <object class="GtkLabel"> <property name="visible">True</property> <property name="can_focus">False</property> - <property name="halign">baseline</property> - <property name="margin_top">12</property> - <property name="label" translatable="yes">Validity</property> + <property name="halign">end</property> + <property name="valign">start</property> + <property name="label" translatable="yes">SHA-256</property> <style> - <class name="bold"/> + <class name="dim-label"/> </style> </object> <packing> <property name="left_attach">0</property> - <property name="top_attach">9</property> - <property name="width">2</property> + <property name="top_attach">14</property> </packing> </child> <child> - <object class="GtkLabel"> + <object class="GtkLabel" id="data_sha256"> <property name="visible">True</property> <property name="can_focus">False</property> - <property name="halign">baseline</property> - <property name="margin_top">12</property> - <property name="label" translatable="yes">Fingerprints</property> - <style> - <class name="bold"/> - </style> + <property name="halign">start</property> + <property name="label"><></property> + <property name="wrap">True</property> + <property name="wrap_mode">char</property> + <property name="selectable">True</property> + <attributes> + <attribute name="font-desc" value="Monospace 8"/> + </attributes> </object> <packing> - <property name="left_attach">0</property> - <property name="top_attach">12</property> - <property name="width">2</property> + <property name="left_attach">1</property> + <property name="top_attach">14</property> </packing> </child> <child> @@ -468,7 +475,7 @@ </object> <packing> <property name="left_attach">1</property> - <property name="top_attach">17</property> + <property name="top_attach">15</property> </packing> </child> <child> ===================================== gajim/gtk/dialogs.py ===================================== @@ -215,20 +215,19 @@ class ErrorDialog(HigDialog): class CertificateDialog(Gtk.ApplicationWindow): def __init__(self, transient_for, account, cert): Gtk.ApplicationWindow.__init__(self) + self.account = account self.set_name('CertificateDialog') self.set_application(app.app) self.set_show_menubar(False) self.set_resizable(False) self.set_position(Gtk.WindowPosition.CENTER) self.set_title(_('Certificate')) - self.account = account self._ui = get_builder('certificate_dialog.ui') self.add(self._ui.certificate_box) self.connect('key-press-event', self._on_key_press) - self.account = account self._clipboard = Gtk.Clipboard.get(Gdk.SELECTION_CLIPBOARD) cert = convert_gio_to_openssl_cert(cert) @@ -236,11 +235,15 @@ class CertificateDialog(Gtk.ApplicationWindow): issuer = cert.get_issuer() subject = cert.get_subject() - self._headline = _('Certificate for account\n%s') % account + self._headline = _('Certificate for \n%s') % self.account self._it_common_name = subject.commonName or '' self._it_organization = subject.organizationName or '' self._it_org_unit = subject.organizationalUnitName or '' - self._it_serial_number = str(cert.get_serial_number()) + it_serial_no = str(cert.get_serial_number()) + it_serial_no_half = int(len(it_serial_no) / 2) + self._it_serial_number = '%s\n%s' % ( + it_serial_no[:it_serial_no_half], + it_serial_no[it_serial_no_half:]) self._ib_common_name = issuer.commonName or '' self._ib_organization = issuer.organizationName or '' self._ib_org_unit = issuer.organizationalUnitName or '' @@ -250,8 +253,11 @@ class CertificateDialog(Gtk.ApplicationWindow): expires = datetime.strptime(cert.get_notAfter().decode('ascii'), '%Y%m%d%H%M%SZ') self._expires = expires.strftime('%c %Z') - self._sha1 = cert.digest('sha1').decode('utf-8') - self._sha256 = cert.digest('sha256').decode('utf-8') + sha1 = cert.digest('sha1').decode('utf-8') + self._sha1 = '%s\n%s' % (sha1[:29], sha1[30:]) + sha256 = cert.digest('sha256').decode('utf-8') + self._sha256 = '%s\n%s\n%s\n%s' % ( + sha256[:23], sha256[24:47], sha256[48:71], sha256[72:]) # Set labels self._ui.label_cert_for_account.set_text(self._headline) View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/a8ccbb4b2acc604fdbccb965eb704055… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/a8ccbb4b2acc604fdbccb965eb704055… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Remove unused import
by Philipp Hörist 15 Mar '20

15 Mar '20

Philipp Hörist pushed to branch master at gajim / gajim Commits: 466611d8 by lovetox at 2020-03-15T22:52:09+01:00 Remove unused import - - - - - 1 changed file: - gajim/gui_interface.py Changes: ===================================== gajim/gui_interface.py ===================================== @@ -67,7 +67,6 @@ from gajim.session import ChatControlSession from gajim.common import idle from gajim.common.zeroconf import connection_zeroconf -from gajim.common import resolver from gajim.common import caps_cache from gajim.common import proxy65_manager from gajim.common import socks5 View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/466611d858ccce370ca066c49b056eb4… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/-/commit/466611d858ccce370ca066c49b056eb4… You're receiving this email because of your account on dev.gajim.org.

1 0

← Newer
1
...
5
6
7
8
9
10
11
Older →

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits March 2020