Commits September 2019

commits@gajim.org

1 participants
59 discussions

[Git][gajim/gajim][master] Show SSLError dialog for all errors
by Philipp Hörist 12 Sep '19

12 Sep '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: 890846fc by Philipp Hörist at 2019-09-12T18:50:24Z Show SSLError dialog for all errors Fixes #9835 - - - - - 1 changed file: - gajim/gtk/ssl_error_dialog.py Changes: ===================================== gajim/gtk/ssl_error_dialog.py ===================================== @@ -102,5 +102,5 @@ class SSLErrorDialog(Gtk.ApplicationWindow): f.write(self._server + '\n') f.write(pem + '\n\n') - self._con.process_ssl_errors() self.destroy() + self._con.process_ssl_errors() View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/890846fc38aaf0a09d9219aa786a776bf2… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/890846fc38aaf0a09d9219aa786a776bf2… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] ChatControlBase: fix autoscroll on keyboard shortcuts
by Philipp Hörist 11 Sep '19

11 Sep '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: 16046d7e by Andrey Gursky at 2019-09-11T15:17:47Z ChatControlBase: fix autoscroll on keyboard shortcuts The issue reported by concerto [1] is a regression since af312830ef42fdb7. [1] https://conference.gajim.org:5281/muc_log/gajim/2019-09-10#df591057-8693-4e… - - - - - 1 changed file: - gajim/chat_control_base.py Changes: ===================================== gajim/chat_control_base.py ===================================== @@ -698,6 +698,7 @@ class ChatControlBase(MessageControl, ChatCommandProcessor, CommandTools): if event.keyval == Gdk.KEY_Page_Down or \ event.keyval == Gdk.KEY_Page_Up: self.conv_textview.tv.event(event) + self._on_scroll(None, event.keyval) return True if event.get_state() & Gdk.ModifierType.CONTROL_MASK: if event.keyval == Gdk.KEY_Tab: # CTRL + TAB View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/16046d7e87bc8962e35a41dc38f7e56b10… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/16046d7e87bc8962e35a41dc38f7e56b10… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Remove obsolete ConfirmationDialogDoubleCheck
by Philipp Hörist 11 Sep '19

11 Sep '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: ed80f936 by Daniel Brötzmann at 2019-09-11T09:11:27Z Remove obsolete ConfirmationDialogDoubleCheck - - - - - 1 changed file: - gajim/gtk/dialogs.py Changes: ===================================== gajim/gtk/dialogs.py ===================================== @@ -246,78 +246,6 @@ class ErrorDialog(HigDialog): self.popup() -class ConfirmationDialogDoubleCheck(ConfirmationDialog): - """ - HIG compliant confirmation dialog with 2 checkbuttons - """ - - def __init__(self, pritext, sectext='', checktext1='', checktext2='', - tooltip1='', tooltip2='', on_response_ok=None, on_response_cancel=None, - transient_for=None, is_modal=True): - self.user_response_ok = on_response_ok - self.user_response_cancel = on_response_cancel - if transient_for is None: - transient_for = app.app.get_active_window() - HigDialog.__init__(self, transient_for, Gtk.MessageType.QUESTION, - Gtk.ButtonsType.OK_CANCEL, pritext, sectext, self.on_response_ok, - self.on_response_cancel) - - self.set_default_response(Gtk.ResponseType.OK) - - ok_button = self.get_widget_for_response(Gtk.ResponseType.OK) - ok_button.grab_focus() - - vbox = self.get_content_area() - if checktext1: - self.checkbutton1 = Gtk.CheckButton.new_with_mnemonic(checktext1) - if tooltip1: - self.checkbutton1.set_tooltip_text(tooltip1) - vbox.pack_start(self.checkbutton1, False, True, 0) - else: - self.checkbutton1 = None - if checktext2: - self.checkbutton2 = Gtk.CheckButton.new_with_mnemonic(checktext2) - if tooltip2: - self.checkbutton2.set_tooltip_text(tooltip2) - vbox.pack_start(self.checkbutton2, False, True, 0) - else: - self.checkbutton2 = None - - self.set_modal(is_modal) - self.popup() - - def on_response_ok(self, widget): - if self.user_response_ok: - if isinstance(self.user_response_ok, tuple): - self.user_response_ok[0](self.is_checked(), - *self.user_response_ok[1:]) - else: - self.user_response_ok(self.is_checked()) - self.call_cancel_on_destroy = False - self.destroy() - - def on_response_cancel(self, widget): - if self.user_response_cancel: - if isinstance(self.user_response_cancel, tuple): - self.user_response_cancel[0](*self.user_response_cancel[1:]) - else: - self.user_response_cancel() - self.call_cancel_on_destroy = False - self.destroy() - - def is_checked(self): - ''' Get active state of the checkbutton ''' - if self.checkbutton1: - is_checked_1 = self.checkbutton1.get_active() - else: - is_checked_1 = False - if self.checkbutton2: - is_checked_2 = self.checkbutton2.get_active() - else: - is_checked_2 = False - return [is_checked_1, is_checked_2] - - class ConfirmationDialogDoubleRadio(ConfirmationDialog): """ HIG compliant confirmation dialog with 2 radios View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/ed80f936594c11a55dfca162cb6938e7b3… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/ed80f936594c11a55dfca162cb6938e7b3… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Rework SSLErrorDialog
by Philipp Hörist 11 Sep '19

11 Sep '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: ac428f11 by Daniel Brötzmann at 2019-09-11T05:02:45Z Rework SSLErrorDialog - - - - - 5 changed files: - + gajim/data/gui/ssl_error_dialog.ui - gajim/gtk/dialogs.py - + gajim/gtk/ssl_error_dialog.py - gajim/gui_interface.py - + test/gtk/ssl_error_dialog.py Changes: ===================================== gajim/data/gui/ssl_error_dialog.ui ===================================== @@ -0,0 +1,173 @@ +<?xml version="1.0" encoding="UTF-8"?> + +<interface> + <requires lib="gtk+" version="3.20"/> + <object class="GtkBox" id="ssl_error_box"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="border_width">18</property> + <property name="orientation">vertical</property> + <property name="spacing">6</property> + <child> + <object class="GtkLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="margin_bottom">6</property> + <property name="label" translatable="yes">SSL Certificate Verification Error</property> + <style> + <class name="large-header"/> + </style> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">0</property> + </packing> + </child> + <child> + <object class="GtkLabel" id="intro_text"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="margin_right">30</property> + <property name="margin_bottom">6</property> + <property name="wrap">True</property> + <property name="max_width_chars">50</property> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">1</property> + </packing> + </child> + <child> + <object class="GtkLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="label" translatable="yes">Identified Error</property> + <style> + <class name="bold"/> + </style> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">2</property> + </packing> + </child> + <child> + <object class="GtkLabel" id="ssl_error"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="margin_bottom">12</property> + <property name="label" translatable="yes"><error></property> + <property name="wrap">True</property> + <property name="max_width_chars">42</property> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">3</property> + </packing> + </child> + <child> + <object class="GtkCheckButton" id="add_certificate_checkbutton"> + <property name="label" translatable="yes">Add this certificate to the list of _trusted certificates</property> + <property name="can_focus">True</property> + <property name="receives_default">False</property> + <property name="no_show_all">True</property> + <property name="halign">start</property> + <property name="margin_left">15</property> + <property name="margin_right">15</property> + <property name="use_underline">True</property> + <property name="draw_indicator">True</property> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">4</property> + </packing> + </child> + <child> + <object class="GtkCheckButton" id="ignore_error_checkbutton"> + <property name="label" translatable="yes">_Ignore this error for this certificate</property> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="receives_default">False</property> + <property name="halign">start</property> + <property name="margin_left">15</property> + <property name="margin_right">15</property> + <property name="use_underline">True</property> + <property name="draw_indicator">True</property> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">5</property> + </packing> + </child> + <child> + <object class="GtkBox"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="margin_top">12</property> + <property name="spacing">12</property> + <child> + <object class="GtkButton" id="abort_button"> + <property name="label" translatable="yes">_Abort</property> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="receives_default">True</property> + <property name="hexpand">True</property> + <property name="use_underline">True</property> + <signal name="clicked" handler="_on_abort_clicked" swapped="no"/> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">0</property> + </packing> + </child> + <child> + <object class="GtkButton" id="view_cert_button"> + <property name="label" translatable="yes">_View Certificate</property> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="receives_default">True</property> + <property name="halign">center</property> + <property name="use_underline">True</property> + <signal name="clicked" handler="_on_view_cert_clicked" swapped="no"/> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">1</property> + </packing> + </child> + <child> + <object class="GtkButton" id="connect_button"> + <property name="label" translatable="yes">_Connect</property> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="receives_default">True</property> + <property name="hexpand">True</property> + <property name="use_underline">True</property> + <signal name="clicked" handler="_on_connect_clicked" swapped="no"/> + <style> + <class name="destructive-action"/> + </style> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">2</property> + </packing> + </child> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">True</property> + <property name="position">6</property> + </packing> + </child> + </object> +</interface> ===================================== gajim/gtk/dialogs.py ===================================== @@ -13,7 +13,6 @@ # along with Gajim. If not, see <http://www.gnu.org/licenses/>. from datetime import datetime - from collections import namedtuple from gi.repository import GLib @@ -536,6 +535,7 @@ class CertificateDialog(Gtk.ApplicationWindow): self.set_resizable(False) self.set_position(Gtk.WindowPosition.CENTER) self.set_title(_('Certificate')) + self.account = account self._ui = get_builder('certificate_dialog.ui') self.add(self._ui.certificate_box) @@ -603,25 +603,6 @@ class CertificateDialog(Gtk.ApplicationWindow): self._clipboard.set_text(clipboard_text, -1) -class SSLErrorDialog(ConfirmationDialogDoubleCheck): - def __init__(self, account, certificate, pritext, sectext, checktext1, - checktext2, on_response_ok=None, on_response_cancel=None): - self.account = account - self.cert = certificate - ConfirmationDialogDoubleCheck.__init__( - self, pritext, sectext, - checktext1, checktext2, on_response_ok=on_response_ok, - on_response_cancel=on_response_cancel, is_modal=False) - b = Gtk.Button(_('View certificate…')) - b.connect('clicked', self.on_cert_clicked) - b.show_all() - area = self.get_action_area() - area.pack_start(b, True, True, 0) - - def on_cert_clicked(self, button): - CertificateDialog(self, self.account, self.cert) - - class ChangePasswordDialog(Gtk.Dialog): def __init__(self, account, success_cb, transient_for): super().__init__(title=_('Change Password'), ===================================== gajim/gtk/ssl_error_dialog.py ===================================== @@ -0,0 +1,106 @@ +# This file is part of Gajim. +# +# Gajim is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published +# by the Free Software Foundation; version 3 only. +# +# Gajim is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with Gajim. If not, see <http://www.gnu.org/licenses/>. + +import os + +from OpenSSL import crypto + +from gi.repository import Gtk + +from gajim.common import app +from gajim.common import configpaths +from gajim.common.const import SSLError +from gajim.common.connection_handlers_events import OurShowEvent +from gajim.common.i18n import _ + +from gajim.gtk.dialogs import CertificateDialog +from gajim.gtk.util import get_builder + + +class SSLErrorDialog(Gtk.ApplicationWindow): + def __init__(self, account, connection, cert, error_num): + Gtk.ApplicationWindow.__init__(self) + self.set_name('SSLErrorDialog') + self.set_application(app.app) + self.set_show_menubar(False) + self.set_resizable(False) + self.set_position(Gtk.WindowPosition.CENTER) + self.set_title(_('SSL Certificate Verification Error')) + + self._ui = get_builder('ssl_error_dialog.ui') + self.add(self._ui.ssl_error_box) + + self.account = account + self._error_num = error_num + self._con = connection + self._cert = cert + self._server = app.config.get_per('accounts', self.account, 'hostname') + + self._process_error() + + self._ui.connect_signals(self) + self.show_all() + + def _process_error(self): + self._ui.intro_text.set_text( + _('There was an error while attempting to verify the SSL ' + 'certificate of your XMPP server (%s).') % self._server) + + unknown_error = _('Unknown SSL error \'%s\'') % self._error_num + ssl_error = SSLError.get(self._error_num, unknown_error) + self._ui.ssl_error.set_text(ssl_error) + + if self._error_num in (18, 27): + # Errors: 18 Self signed certificate; 27 Certificate not trusted + self._ui.add_certificate_checkbutton.show() + + def _on_abort_clicked(self, _button): + self._con.disconnect(reconnect=False) + app.nec.push_incoming_event(OurShowEvent(None, conn=self._con, + show='offline')) + self.destroy() + + def _on_view_cert_clicked(self, _button): + window = app.get_app_window(CertificateDialog, self.account) + if window is None: + CertificateDialog(self, self.account, self._cert) + else: + window.present() + + def _on_connect_clicked(self, _button): + # Ignore this error + if self._ui.ignore_error_checkbutton.get_active(): + ignore_ssl_errors = app.config.get_per( + 'accounts', self.account, 'ignore_ssl_errors').split() + ignore_ssl_errors.append(str(self._error_num)) + app.config.set_per('accounts', self.account, 'ignore_ssl_errors', + ' '.join(ignore_ssl_errors)) + + if self._ui.add_certificate_checkbutton.get_active(): + pem = crypto.dump_certificate( + crypto.FILETYPE_PEM, self._cert).decode('utf-8') + + # Check if cert is already in file + certs = '' + my_ca_certs = configpaths.get('MY_CACERTS') + if os.path.isfile(my_ca_certs): + with open(my_ca_certs, encoding='utf-8') as f: + certs = f.read() + if pem not in certs: + with open(my_ca_certs, 'a', encoding='utf-8') as f: + f.write(self._server + '\n') + f.write(pem + '\n\n') + + self._con.process_ssl_errors() + self.destroy() ===================================== gajim/gui_interface.py ===================================== @@ -46,7 +46,6 @@ from gi.repository import Gio from nbxmpp import idlequeue from nbxmpp import Hashes2 from nbxmpp.structs import TuneData -import OpenSSL from gajim.common import app from gajim.common import events @@ -86,7 +85,6 @@ from gajim.common.connection_handlers_events import ( from gajim.common.modules.httpupload import HTTPUploadProgressEvent from gajim.common.connection import Connection from gajim.common.file_props import FilesProp -from gajim.common.const import SSLError from gajim import roster_window from gajim.common import ged @@ -103,7 +101,6 @@ from gajim.gtk.dialogs import NewConfirmationCheckDialog from gajim.gtk.dialogs import DialogButton from gajim.gtk.dialogs import InputDialog from gajim.gtk.dialogs import PassphraseDialog -from gajim.gtk.dialogs import SSLErrorDialog from gajim.gtk.dialogs import InvitationReceivedDialog from gajim.gtk.profile import ProfileWindow from gajim.gtk.filechoosers import FileChooserDialog @@ -113,6 +110,7 @@ from gajim.gtk.filetransfer import FileTransfersWindow from gajim.gtk.http_upload_progress import HTTPUploadProgressWindow from gajim.gtk.roster_item_exchange import RosterItemExchangeWindow from gajim.gtk.subscription_request import SubscriptionRequestWindow +from gajim.gtk.ssl_error_dialog import SSLErrorDialog from gajim.gtk.util import get_show_in_roster from gajim.gtk.util import get_show_in_systray @@ -1090,74 +1088,15 @@ class Interface: def handle_event_ssl_error(self, obj): account = obj.conn.name - server = app.config.get_per('accounts', account, 'hostname') - - def on_ok(is_checked): - del self.instances[account]['online_dialog']['ssl_error'] - if is_checked[0]: - - pem = OpenSSL.crypto.dump_certificate( - OpenSSL.crypto.FILETYPE_PEM, obj.cert).decode('utf-8') - - # Check if cert is already in file - certs = '' - my_ca_certs = configpaths.get('MY_CACERTS') - if os.path.isfile(my_ca_certs): - with open(my_ca_certs, encoding='utf-8') as f: - certs = f.read() - if pem in certs: - ErrorDialog(_('Certificate Already in File'), - _('This certificate is already in file %s, so it\'s ' - 'not added again.') % my_ca_certs) - else: - with open(my_ca_certs, 'a', encoding='utf-8') as f: - f.write(server + '\n') - f.write(pem + '\n\n') - - if is_checked[1]: - ignore_ssl_errors = app.config.get_per('accounts', account, - 'ignore_ssl_errors').split() - ignore_ssl_errors.append(str(obj.error_num)) - app.config.set_per('accounts', account, 'ignore_ssl_errors', - ' '.join(ignore_ssl_errors)) - obj.conn.process_ssl_errors() + connection = obj.conn + cert = obj.cert + error_num = obj.error_num - def on_cancel(): - del self.instances[account]['online_dialog']['ssl_error'] - obj.conn.disconnect(reconnect=False) - app.nec.push_incoming_event(OurShowEvent(None, conn=obj.conn, - show='offline')) - - text = _('The authenticity of the %s ' - 'certificate could be invalid') % server - - default_text = _('\nUnknown SSL error: %d') % obj.error_num - ssl_error_text = SSLError.get(obj.error_num, default_text) - text += _('\nSSL Error: <b>%s</b>') % ssl_error_text - - fingerprint_sha1 = obj.cert.digest('sha1').decode('utf-8') - fingerprint_sha256 = obj.cert.digest('sha256').decode('utf-8') - - pritext = _('Error verifying SSL certificate') - sectext = _('There was an error verifying the SSL certificate of your ' - 'XMPP server: %(error)s\nDo you still want to connect to this ' - 'server?') % {'error': text} - if obj.error_num in (18, 27): - checktext1 = _('Add this certificate to the list of trusted ' - 'certificates.\nSHA-1 fingerprint of the certificate:\n%(sha1)s' - '\nSHA-256 fingerprint of the certificate:\n%(sha256)s') % \ - {'sha1': fingerprint_sha1, 'sha256': fingerprint_sha256} + window = app.get_app_window(SSLErrorDialog, account) + if window is None: + SSLErrorDialog(account, connection, cert, error_num) else: - checktext1 = '' - checktext2 = _('Ignore this error for this certificate.') - if 'ssl_error' in self.instances[account]['online_dialog']: - self.instances[account]['online_dialog']['ssl_error'].destroy() - self.instances[account]['online_dialog']['ssl_error'] = \ - SSLErrorDialog(obj.conn.name, obj.cert, pritext, - sectext, checktext1, checktext2, on_response_ok=on_ok, - on_response_cancel=on_cancel) - self.instances[account]['online_dialog']['ssl_error'].set_title( - _('SSL Certificate Verification for %s') % account) + window.present() def handle_event_plain_connection(self, obj): # ('PLAIN_CONNECTION', account, (connection)) ===================================== test/gtk/ssl_error_dialog.py ===================================== @@ -0,0 +1,52 @@ +import gi +gi.require_version('Gtk', '3.0') +from gi.repository import Gtk + +import OpenSSL + +from test.gtk import util +from gajim.common.const import CSSPriority +from gajim.gtk.ssl_error_dialog import SSLErrorDialog + +util.load_style('gajim.css', CSSPriority.APPLICATION) + +cert = ''' +-----BEGIN CERTIFICATE----- +MIIFhDCCBGygAwIBAgISA4oUEifTr7Y+mcdiwu6KWpcVMA0GCSqGSIb3DQEBCwUA +MEoxCzAJBgNVBAYTAlVTMRYwFAYDVQQKEw1MZXQncyBFbmNyeXB0MSMwIQYDVQQD +ExpMZXQncyBFbmNyeXB0IEF1dGhvcml0eSBYMzAeFw0xOTA0MDMxODE3NDVaFw0x +OTA3MDIxODE3NDVaMBsxGTAXBgNVBAMMECoubGlnaHR3aXRjaC5vcmcwggEiMA0G +CSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQC/3mcevikse7QwDYwPcGAD9zHw3UWE +7J8SJR349/rFTF2tBFDvEa62OUKTCg5vPKVKaXHlzruk/A7blgqsEdugycORwPD1 +7YNJ27EldrRtotjclurzKL6D/MgcaQ4cTkPOD3cWbf/L+HClGrpFt7su6Z6cTutC +wiAYAdlfmVgSSv15F1xOTyFyfGJKQnW628Xs8xUvZh5H/SsEEum4MwVVGW06Z/A/ +mwX2jmJUb2M25S1Ma025nZpGYyAAqecTmPb3fStnXm4sdytfZhm4+nj9mH9GQIU1 +t/jO/7X7IFpc9DvVRSumSVqvNaVgiWmTLP4VxlCVJO6mibOXXUUDA5RfAgMBAAGj +ggKRMIICjTAOBgNVHQ8BAf8EBAMCBaAwHQYDVR0lBBYwFAYIKwYBBQUHAwEGCCsG +AQUFBwMCMAwGA1UdEwEB/wQCMAAwHQYDVR0OBBYEFC4/ZRurw2wVFsgJBTb9Fh/3 +0aV9MB8GA1UdIwQYMBaAFKhKamMEfd265tE5t6ZFZe/zqOyhMG8GCCsGAQUFBwEB +BGMwYTAuBggrBgEFBQcwAYYiaHR0cDovL29jc3AuaW50LXgzLmxldHNlbmNyeXB0 +Lm9yZzAvBggrBgEFBQcwAoYjaHR0cDovL2NlcnQuaW50LXgzLmxldHNlbmNyeXB0 +Lm9yZy8wSQYDVR0RBEIwQIIQKi5saWdodHdpdGNoLm9yZ4IOKi5tZXRyb25vbWUu +aW2CDmxpZ2h0d2l0Y2gub3JnggxtZXRyb25vbWUuaW0wTAYDVR0gBEUwQzAIBgZn +gQwBAgEwNwYLKwYBBAGC3xMBAQEwKDAmBggrBgEFBQcCARYaaHR0cDovL2Nwcy5s +ZXRzZW5jcnlwdC5vcmcwggECBgorBgEEAdZ5AgQCBIHzBIHwAO4AdQB0ftqDMa0z +EJEhnM4lT0Jwwr/9XkIgCMY3NXnmEHvMVgAAAWnkosBAAAAEAwBGMEQCICEfmTBk +OxS95eiYsfTH5HdL7kfp68BSin5LqeGyyxk9AiA3qeDZNKklJTdWqYjto7kUqJNd +YiL99SrqwzR6w+AqSwB1ACk8UZZUyDlluqpQ/FgH1Ldvv1h6KXLcpMMM9OVFR/R4 +AAABaeSiwEUAAAQDAEYwRAIgFxouOkJeqkQUe6zNI5w/6YBIQFrsrIZdPcX+r6JI +is8CIEEETzlEyj9lWR/BSSruSp0FT5CuoNNeEG7HxrJ+gVhZMA0GCSqGSIb3DQEB +CwUAA4IBAQAQtfs1NPNMmBQRcKsZyGLZsvpp2hIhdYi72RYnHnIl4MXbhyNj9xtI +cJr9PQ+3FsSnxy7LDjZMpbmBuXhawOyPBPw2M0f0Tv6Eo6miwvP/X1kLE3VjTzCo +6JPh6bEB5wa+kH/pUcGlV6uyT7IuXOiArx0VmIpTA3uwlVdfynOnR3CF20Ds4FLc +JxbGMqRuw/sGiTLKlXc1xVil8WZjL3hokzrgI7K6np2skUjWuMZvhJgwi5QiE7/C +ejsJoYkpvcaiaLAyVymTY/n/oM2oQpv5Mqjit+18RB9c2P+ifH5iDKC/jTKn4NNz +8xSTlUlCBTCozjzscZVeVDIojmejWclT +-----END CERTIFICATE-----''' + +cert = OpenSSL.crypto.load_certificate(OpenSSL.crypto.FILETYPE_PEM, cert) +ssl_error_num = 10 +win = SSLErrorDialog('testacc', None, cert, ssl_error_num) +win.connect('destroy', Gtk.main_quit) +win.show_all() +Gtk.main() View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/ac428f1115fc797079d2718383f44a721e… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/ac428f1115fc797079d2718383f44a721e… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 3 commits: Use Accept (and make it the default) for image pasting
by Philipp Hörist 10 Sep '19

10 Sep '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: a27a4003 by Daniel Brötzmann at 2019-09-07T15:09:32Z Use Accept (and make it the default) for image pasting - - - - - d47bee03 by Daniel Brötzmann at 2019-09-07T15:10:23Z Use Accept default button, adapt some text strings - - - - - 07bb750d by Daniel Brötzmann at 2019-09-09T12:35:06Z Fix handle_event_http_auth answers from NewConfirmationDialog - - - - - 10 changed files: - gajim/chat_control.py - gajim/chat_control_base.py - gajim/dialogs.py - gajim/groupchat_control.py - gajim/gtk/accounts.py - gajim/gtk/filetransfer.py - gajim/gui_interface.py - gajim/history_manager.py - gajim/message_window.py - gajim/roster_window.py Changes: ===================================== gajim/chat_control.py ===================================== @@ -1152,7 +1152,7 @@ class ChatControl(ChatControlBase): [DialogButton.make('Cancel', callback=lambda: on_no(self)), DialogButton.make('Remove', - text=_('Close'), + text=_('_Close'), callback=lambda: on_yes(self))], transient_for=self.parent_win.window).show() return ===================================== gajim/chat_control_base.py ===================================== @@ -622,8 +622,9 @@ class ChatControlBase(MessageControl, ChatCommandProcessor, CommandTools): 'clipboard\'s image into the chat window?'), _('_Do not ask me again'), [DialogButton.make('Cancel'), - DialogButton.make('OK', + DialogButton.make('Accept', text=_('_Paste'), + is_default=True, callback=self._paste_event_confirmed, args=[image])]).show() @@ -1167,12 +1168,12 @@ class ChatControlBase(MessageControl, ChatCommandProcessor, CommandTools): NewConfirmationDialog( _('Privacy'), _('Warning'), - _('If you send a file to <b>%s</b>, ' - 'your real JID will be revealed.' % gc_contact.name), + _('If you send a file to <b>%s</b>, your real XMPP ' + 'address will be revealed.' % gc_contact.name), [DialogButton.make('Cancel'), DialogButton.make( 'OK', - text=_('Continue'), + text=_('_Continue'), callback=lambda: _on_ok(gc_contact))]).show() return _on_ok(gc_contact) ===================================== gajim/dialogs.py ===================================== @@ -667,11 +667,12 @@ class ChangeStatusMessageDialog(TimeoutDialog): self.countdown_enabled = False start_iter, finish_iter = self.message_buffer.get_bounds() status_message_to_save_as_preset = self.message_buffer.get_text( - start_iter, finish_iter, True) + start_iter, finish_iter, True) + def on_ok(msg_name): msg_text = status_message_to_save_as_preset msg_text_1l = helpers.to_one_line(msg_text) - if not msg_name: # msg_name was '' + if not msg_name: # msg_name was '' msg_name = msg_text_1l def _on_ok2(): @@ -681,23 +682,23 @@ class ChangeStatusMessageDialog(TimeoutDialog): self.pep_dict.get('activity_text'), self.pep_dict.get('mood'), self.pep_dict.get('mood_text')] app.config.set_per('statusmsg', msg_name, 'message', - msg_text_1l) + msg_text_1l) app.config.set_per('statusmsg', msg_name, 'activity', - self.pep_dict.get('activity')) + self.pep_dict.get('activity')) app.config.set_per('statusmsg', msg_name, 'subactivity', - self.pep_dict.get('subactivity')) + self.pep_dict.get('subactivity')) app.config.set_per('statusmsg', msg_name, 'activity_text', - self.pep_dict.get('activity_text')) + self.pep_dict.get('activity_text')) app.config.set_per('statusmsg', msg_name, 'mood', - self.pep_dict.get('mood')) + self.pep_dict.get('mood')) app.config.set_per('statusmsg', msg_name, 'mood_text', - self.pep_dict.get('mood_text')) + self.pep_dict.get('mood_text')) if msg_name in self.preset_messages_dict: NewConfirmationDialog( _('Overwrite'), _('Overwrite Status Message?'), - _('Preset name is already in use. ' - 'Do you want to overwrite this preset?'), + _('This name is already in use. Do you want to ' + 'overwrite this preset?'), [DialogButton.make('Cancel'), DialogButton.make('Remove', text=_('_Overwrite'), ===================================== gajim/groupchat_control.py ===================================== @@ -64,7 +64,6 @@ from gajim.common import contacts from gajim.common.const import StyleAttr from gajim.common.const import Chatstate from gajim.common.const import MUCJoinedState -from gajim.common.const import ButtonAction from gajim.chat_control_base import ChatControlBase @@ -1174,9 +1173,8 @@ class GroupchatControl(ChatControlBase): _('<b>%s</b> from <b>%s</b> requests voice') % ( event.voice_request.nick, self.room_name), [DialogButton.make('Cancel'), - DialogButton.make('OK', - text=_('Approve'), - action=ButtonAction.SUGGESTED, + DialogButton.make('Accept', + text=_('_Approve'), callback=on_approve)], modal=False).show() @@ -2278,8 +2276,9 @@ class GroupchatControl(ChatControlBase): _('_Do not ask me again'), [DialogButton.make('Cancel', callback=on_cancel), - DialogButton.make('OK', + DialogButton.make('Accept', text=_('_Leave'), + is_default=True, callback=on_ok)], transient_for=self.parent_win.window).show() return ===================================== gajim/gtk/accounts.py ===================================== @@ -139,7 +139,7 @@ class AccountsWindow(Gtk.ApplicationWindow): _('To apply all changes instantly, you have to re-login.'), [DialogButton.make('Cancel', text=_('_Later')), - DialogButton.make('OK', + DialogButton.make('Accept', text=_('_Re-Login'), callback=lambda *args: relog(account))], transient_for=self).show() @@ -193,8 +193,7 @@ class AccountsWindow(Gtk.ApplicationWindow): NewConfirmationDialog( _('Remove Account'), _('You still have open chats in your account %s') % account, - _('All chat and group chat windows will be closed.\n' - 'Do you want to continue?'), + _('All chat and group chat windows will be closed.'), [DialogButton.make('Cancel'), DialogButton.make('Remove', callback=remove)], @@ -571,8 +570,7 @@ class AccountRow(Gtk.ListBoxRow): NewConfirmationDialog( _('Disable Account'), _('Account %s is still connected') % account, - _('All chat and group chat windows will be closed. ' - 'Do you want to continue?'), + _('All chat and group chat windows will be closed.'), [DialogButton.make('Cancel', callback=lambda: switch.set_active(True)), DialogButton.make('Remove', @@ -972,13 +970,13 @@ class RemoveAccountWindow: else: self._on_remove_success(True) - if self.account in app.connections and \ - app.connections[self.account].connected: + if (self.account in app.connections and + app.connections[self.account].connected): NewConfirmationDialog( _('Remove Account'), - _('Account \'%s\' is still connected to the ' - 'server') % self.account, - _('If you remove it, the connection will be lost.'), + _('Still connected to the server'), + _('Account \'%s\' is still connected to the server. If you ' + 'remove it, the connection will be lost.') % self.account, [DialogButton.make('Cancel'), DialogButton.make('Remove', callback=remove)], ===================================== gajim/gtk/filetransfer.py ===================================== @@ -336,7 +336,7 @@ class FileTransfersWindow: 'Do you want to download it again?') % file_name, [DialogButton.make('Cancel', text=_('_No')), - DialogButton.make('OK', + DialogButton.make('Accept', text=_('_Download Again'), callback=on_yes, args=[jid, @@ -421,16 +421,17 @@ class FileTransfersWindow: NewConfirmationDialog( _('File Transfer Conflict'), - _('This file already exists'), + _('File already exists'), _('Resume download or replace file?'), [DialogButton.make('Cancel', callback=_on_cancel), - DialogButton.make('OK', - text=_('Replace _File'), - callback=_on_replace), DialogButton.make('OK', text=_('Resume _Download'), - callback=_on_resume)]).show() + callback=_on_resume), + DialogButton.make('Accept', + text=_('Replace _File'), + is_default=True, + callback=_on_replace)]).show() # File does not exist yet dirname = os.path.dirname(file_path) @@ -486,8 +487,7 @@ class FileTransfersWindow: sectext, [DialogButton.make('Cancel', callback=_on_cancel), - DialogButton.make('OK', - text=_('_Accept'), + DialogButton.make('Accept', callback=_on_ok)]).show() def set_status(self, file_props, status): ===================================== gajim/gui_interface.py ===================================== @@ -167,7 +167,7 @@ class Interface: obj.stanza, answer) account = obj.conn.name - pri_msg = _('HTTP (%(method)s) Authorization ' + message = _('HTTP (%(method)s) Authorization ' 'for %(url)s (ID: %(id)s)') % { 'method': obj.method, 'url': obj.url, @@ -177,19 +177,19 @@ class Interface: sec_msg = _('Do you accept this request (account: %s)?') % account if obj.msg: sec_msg = obj.msg + '\n' + sec_msg + message = message + '\n' + sec_msg NewConfirmationDialog( - _('Authorization'), - pri_msg, - sec_msg, + _('Authorization Request'), + _('HTTP Authorization Request'), + message, [DialogButton.make('Cancel', text=_('_No'), callback=_response, - args=[obj, 'yes']), - DialogButton.make('OK', - text=_('_Accept'), + args=[obj, 'no']), + DialogButton.make('Accept', callback=_response, - args=[obj, 'no'])]).show() + args=[obj, 'yes'])]).show() def handle_event_iq_error(self, event): ctrl = self.msg_win_mgr.get_control(event.properties.jid.getBare(), ===================================== gajim/history_manager.py ===================================== @@ -245,9 +245,9 @@ class HistoryManager: NewConfirmationDialog( _('Database Cleanup'), - _('Do you want to clean up the database? ' - '(STRONGLY NOT RECOMMENDED IF GAJIM IS RUNNING)'), - _('Normally, the allocated database size will not be freed, it ' + _('Clean up the database?'), + _('This is STRONGLY NOT RECOMMENDED IF GAJIM IS RUNNING.\n' + 'Normally, the allocated database size will not be freed, it ' 'will just become reusable. This operation may take a while.'), [DialogButton.make('Cancel', callback=_on_no), ===================================== gajim/message_window.py ===================================== @@ -358,11 +358,13 @@ class MessageWindow: NewConfirmationCheckDialog( _('Close Tabs'), - _('You are going to close several tabs'), - _('Do you really want to close them all?'), + _('You are about to close several tabs'), + _('Do you really want to close all of them?'), _('_Do not ask me again'), [DialogButton.make('Cancel'), - DialogButton.make('OK', + DialogButton.make('Accept', + text=_('_Close'), + is_default=True, callback=_on_yes1)], transient_for=self.window).show() return True ===================================== gajim/roster_window.py ===================================== @@ -4125,8 +4125,9 @@ class RosterWindow: sectext, _('_Do not ask me again'), [DialogButton.make('Cancel'), - DialogButton.make('OK', + DialogButton.make('Accept', text=_('_Create'), + is_default=True, callback=merge_contacts)]).show() def on_drop_in_group(self, widget, account, c_source, grp_dest, View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/5623dfbaf766e10ad76420a0d16c7c199… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/5623dfbaf766e10ad76420a0d16c7c199… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 3 commits: Remove menu for saving avatar to harddisk
by Philipp Hörist 06 Sep '19

06 Sep '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: 45a200f7 by Philipp Hörist at 2019-09-06T20:23:28Z Remove menu for saving avatar to harddisk All avatars are available under ~/.cache/gajim/avatars - - - - - ea251998 by Philipp Hörist at 2019-09-06T20:23:28Z Avatar: Force avatars to be square - - - - - 5623dfba by Philipp Hörist at 2019-09-06T20:23:28Z Avatar: Remove unused method - - - - - 10 changed files: - gajim/chat_control.py - gajim/data/gui/profile_window.ui - gajim/data/gui/vcard_information_window.ui - gajim/data/gui/zeroconf_information_window.ui - gajim/gtk/avatar.py - gajim/gtk/filechoosers.py - gajim/gtk/profile.py - gajim/gtkgui_helpers.py - gajim/gui_menu_builder.py - gajim/vcard.py Changes: ===================================== gajim/chat_control.py ===================================== @@ -142,13 +142,6 @@ class ChatControl(ChatControlBase): self.show_avatar() # Hook up signals - widget = self.xml.get_object('avatar_eventbox') - widget.set_property('height-request', AvatarSize.CHAT) - - id_ = widget.connect('button-press-event', - self.on_avatar_eventbox_button_press_event) - self.handlers[id_] = widget - widget = self.xml.get_object('location_eventbox') id_ = widget.connect('button-release-event', self.on_location_eventbox_button_release_event) @@ -639,22 +632,6 @@ class ChatControl(ChatControlBase): # Save volume to config app.config.set('audio_output_volume', value) - def on_avatar_eventbox_button_press_event(self, widget, event): - """ - If right-clicked, show popup - """ - if event.button == 3: # right click - if self.TYPE_ID == message_control.TYPE_CHAT: - sha = app.contacts.get_avatar_sha( - self.account, self.contact.jid) - name = self.contact.get_shown_name() - else: - sha = self.gc_contact.avatar_sha - name = self.gc_contact.get_shown_name() - if sha is not None: - gui_menu_builder.show_save_as_menu(sha, name) - return True - def on_location_eventbox_button_release_event(self, widget, event): if 'geoloc' in self.contact.pep: location = self.contact.pep['geoloc'].data ===================================== gajim/data/gui/profile_window.ui ===================================== @@ -43,7 +43,7 @@ <property name="visible">True</property> <property name="can_focus">True</property> <property name="receives_default">False</property> - <signal name="button-press-event" handler="on_PHOTO_button_press_event" swapped="no"/> + <signal name="clicked" handler="_on_set_avatar_clicked" swapped="no"/> <child> <object class="GtkOverlay"> <property name="visible">True</property> @@ -108,7 +108,7 @@ <property name="halign">start</property> <property name="valign">start</property> <property name="use_underline">True</property> - <signal name="button-press-event" handler="on_PHOTO_button_press_event" swapped="no"/> + <signal name="clicked" handler="_on_set_avatar_clicked" swapped="no"/> <child> <object class="GtkBox"> <property name="visible">True</property> ===================================== gajim/data/gui/vcard_information_window.ui ===================================== @@ -364,7 +364,6 @@ <property name="can_focus">False</property> <property name="halign">start</property> <property name="visible_window">False</property> - <signal name="button-press-event" handler="on_PHOTO_eventbox_button_press_event" swapped="no"/> <child> <object class="GtkImage" id="PHOTO_image"> <property name="can_focus">False</property> ===================================== gajim/data/gui/zeroconf_information_window.ui ===================================== @@ -179,7 +179,6 @@ <property name="visible">True</property> <property name="can_focus">False</property> <property name="visible_window">False</property> - <signal name="button-press-event" handler="on_PHOTO_eventbox_button_press_event" swapped="no"/> <child> <object class="GtkImage" id="PHOTO_image"> <property name="visible">True</property> ===================================== gajim/gtk/avatar.py ===================================== @@ -119,6 +119,30 @@ def add_status_to_avatar(surface, show): return context.get_target() +def square(surface, size): + width = surface.get_width() + height = surface.get_height() + if width == height: + return surface + + new_surface = cairo.ImageSurface(cairo.FORMAT_ARGB32, size, size) + new_surface.set_device_scale(*surface.get_device_scale()) + context = cairo.Context(new_surface) + + scale = surface.get_device_scale()[0] + + if width == size: + x_pos = 0 + y_pos = (size - height) / 2 / scale + else: + y_pos = 0 + x_pos = (size - width) / 2 / scale + + context.set_source_surface(surface, x_pos, y_pos) + context.paint() + return context.get_target() + + def clip_circle(surface): new_surface = cairo.ImageSurface(cairo.FORMAT_ARGB32, surface.get_width(), @@ -260,12 +284,6 @@ class AvatarStorage(metaclass=Singleton): return None return path - def pixbuf_from_filename(self, filename): - path = self.get_avatar_path(filename) - if path is None: - return None - return load_pixbuf(path) - def surface_from_filename(self, filename, size, scale): size = size * scale path = self.get_avatar_path(filename) @@ -276,7 +294,8 @@ class AvatarStorage(metaclass=Singleton): if pixbuf is None: return None - return Gdk.cairo_surface_create_from_pixbuf(pixbuf, scale) + surface = Gdk.cairo_surface_create_from_pixbuf(pixbuf, scale) + return square(surface, size) def _load_surface_from_storage(self, contact, size, scale): filename = contact.avatar_sha @@ -288,7 +307,8 @@ class AvatarStorage(metaclass=Singleton): pixbuf = load_pixbuf(path, size) if pixbuf is None: return None - return Gdk.cairo_surface_create_from_pixbuf(pixbuf, scale) + surface = Gdk.cairo_surface_create_from_pixbuf(pixbuf, scale) + return square(surface, size) def _get_avatar_from_storage(self, contact, size, scale): if contact.avatar_sha is None: ===================================== gajim/gtk/filechoosers.py ===================================== @@ -144,12 +144,6 @@ class FileSaveDialog(NativeFileChooserDialog): _action = Gtk.FileChooserAction.SAVE -class AvatarSaveDialog(FileSaveDialog): - - if sys.platform == 'win32': - _filters = [Filter(_('Images'), '*.png;*.jpg;*.jpeg;*.svg', True)] - - class NativeFileOpenDialog(BaseFileOpenDialog, NativeFileChooserDialog): pass ===================================== gajim/gtk/profile.py ===================================== @@ -32,7 +32,6 @@ from gajim.common.const import AvatarSize from gajim.common.helpers import event_filter from gajim import gtkgui_helpers -from gajim.gui_menu_builder import show_save_as_menu from gajim.gtk.dialogs import ErrorDialog from gajim.gtk.dialogs import InformationDialog @@ -127,7 +126,7 @@ class ProfileWindow(Gtk.ApplicationWindow): self.avatar_sha = None self.avatar_mime_type = None - def on_set_avatar_button_clicked(self, widget): + def _on_set_avatar_clicked(self, _button): def on_ok(path_to_file): data, sha = app.interface.avatar_storage.prepare_for_publish( path_to_file) @@ -153,20 +152,6 @@ class ProfileWindow(Gtk.ApplicationWindow): AvatarChooserDialog(on_ok, transient_for=self) - def on_PHOTO_button_press_event(self, widget, event): - """ - If right-clicked, show popup - """ - if event.button == 3: - # right click - nick = app.config.get_per('accounts', self.account, 'name') - if self.avatar_sha is None: - return - show_save_as_menu(self.avatar_sha, nick) - - elif event.button == 1: # left click - self.on_set_avatar_button_clicked(widget) - def on_BDAY_entry_focus_out_event(self, widget, event): txt = widget.get_text() if not txt: ===================================== gajim/gtkgui_helpers.py ===================================== @@ -39,7 +39,6 @@ try: except Exception: pass -from gajim.common.i18n import _ from gajim.common import app HAS_PYWIN32 = True @@ -148,70 +147,6 @@ def scale_pixbuf_from_data(data, size): return scale_pixbuf(pixbuf, size) -def on_avatar_save_as_menuitem_activate(widget, avatar, default_name=''): - from gajim.gtk.dialogs import DialogButton - from gajim.gtk.dialogs import ErrorDialog - from gajim.gtk.dialogs import NewConfirmationDialog - from gajim.gtk.filechoosers import AvatarSaveDialog - - def _on_save_avatar(file_path): - if os.path.exists(file_path): - # Check if we have write permissions - if not os.access(file_path, os.W_OK): - file_name = os.path.basename(file_path) - ErrorDialog( - _('Cannot overwrite existing file \'%s\'' % file_name), - _('A file with this name already exists and you do ' - 'not have permission to overwrite it.')) - return - - app.config.set('last_save_dir', os.path.dirname(file_path)) - if isinstance(avatar, str): - # We got a SHA - pixbuf = app.interface.avatar_storage.pixbuf_from_filename(avatar) - else: - # We got a pixbuf - pixbuf = avatar - extension = os.path.splitext(file_path)[1] - if not extension: - # Silently save as Jpeg image - image_format = 'png' - file_path += '.png' - else: - image_format = extension[1:] # remove leading dot - - # Save image - try: - pixbuf.savev(file_path, image_format, [], []) - except Exception as error: - log.error('Error saving avatar: %s', error) - if os.path.exists(file_path): - os.remove(file_path) - new_file_path = '.'.join(file_path.split('.')[:-1]) + '.png' - - def _on_ok(file_path, pixbuf): - pixbuf.savev(file_path, 'png', [], []) - - NewConfirmationDialog( - _('Error While Saving'), - _('Extension not supported'), - _('Image cannot be saved in %(type)s format.\n' - 'Save as %(new_filename)s?') % { - 'type': image_format, - 'new_filename': new_file_path}, - [DialogButton.make('Cancel'), - DialogButton.make('OK', - text=_('_Save'), - callback=_on_ok, - args=[new_file_path, - pixbuf])]).show() - - AvatarSaveDialog(_on_save_avatar, - path=app.config.get('last_save_dir'), - file_name='%s.png' % default_name, - transient_for=app.app.get_active_window()) - - def create_combobox(value_list, selected_value=None): """ Value_list is [(label1, value1)] ===================================== gajim/gui_menu_builder.py ===================================== @@ -509,18 +509,6 @@ def get_transport_menu(contact, account): return menu -def show_save_as_menu(sha, name): - menu = Gtk.Menu() - menuitem = Gtk.MenuItem.new_with_mnemonic(_('Save _As')) - menuitem.connect( - 'activate', - gtkgui_helpers.on_avatar_save_as_menuitem_activate, sha, name) - menu.append(menuitem) - menu.connect('selection-done', lambda w: w.destroy()) - menu.show_all() - menu.popup_at_pointer() - - def get_singlechat_menu(control_id, account, jid): singlechat_menu = [ (_('Send File…'), [ ===================================== gajim/vcard.py ===================================== @@ -37,7 +37,6 @@ from nbxmpp.util import is_error_result from nbxmpp.protocol import JID from gajim import gtkgui_helpers -from gajim.gui_menu_builder import show_save_as_menu from gajim.common import helpers from gajim.common import app from gajim.common import ged @@ -158,22 +157,6 @@ class VcardWindow: def on_information_notebook_switch_page(self, widget, page, page_num): GLib.idle_add(self.xml.get_object('close_button').grab_focus) - def on_PHOTO_eventbox_button_press_event(self, widget, event): - """ - If right-clicked, show popup - """ - if event.button == 3: # right click - if self.gc_contact: - sha = self.gc_contact.avatar_sha - name = self.gc_contact.get_shown_name() - else: - sha = app.contacts.get_avatar_sha( - self.account, self.contact.jid) - name = self.contact.get_shown_name() - if sha is None: - sha = self.avatar - show_save_as_menu(sha, name) - def set_value(self, entry_name, value): try: widget = self.xml.get_object(entry_name) @@ -499,14 +482,6 @@ class ZeroconfVcardWindow: if event.keyval == Gdk.KEY_Escape: self.window.destroy() - def on_PHOTO_eventbox_button_press_event(self, widget, event): - """ - If right-clicked, show popup - """ - if event.button == 3: # right click - show_save_as_menu(self.contact.avatar_sha, - self.contact.get_shown_name()) - def set_value(self, entry_name, value): try: if value and entry_name == 'URL_label': View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/9f59eb54955249aa11fd84eeb8a4debc8… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/9f59eb54955249aa11fd84eeb8a4debc8… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: CommandSystem: Add setting to disable execution of commands by default
by Philipp Hörist 05 Sep '19

05 Sep '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: 2257da6c by Daniel Brötzmann at 2019-09-05T21:02:00Z CommandSystem: Add setting to disable execution of commands by default - - - - - 9f59eb54 by Daniel Brötzmann at 2019-09-05T21:02:00Z CommandSystem: Fix some pylint errors - - - - - 10 changed files: - gajim/command_system/errors.py - gajim/command_system/framework.py - gajim/command_system/implementation/custom.py - gajim/command_system/implementation/execute.py - gajim/command_system/implementation/hosts.py - gajim/command_system/implementation/middleware.py - gajim/command_system/implementation/standard.py - gajim/command_system/mapping.py - gajim/command_system/tools.py - gajim/common/config.py Changes: ===================================== gajim/command_system/errors.py ===================================== @@ -13,6 +13,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. + class BaseError(Exception): """ Common base for errors which relate to a specific command. @@ -34,16 +35,19 @@ class BaseError(Exception): def __str__(self): return self.message + class DefinitionError(BaseError): """ Used to indicate errors occurred on command definition. """ + class CommandError(BaseError): """ Used to indicate errors occurred during command execution. """ + class NoCommandError(BaseError): """ Used to indicate an inability to find the specified command. ===================================== gajim/command_system/framework.py ===================================== @@ -22,10 +22,16 @@ declarative way. from types import FunctionType from inspect import getargspec, getdoc -from gajim.command_system.dispatcher import Host, Container -from gajim.command_system.dispatcher import get_command, list_commands -from gajim.command_system.mapping import parse_arguments, adapt_arguments -from gajim.command_system.errors import DefinitionError, CommandError, NoCommandError +from gajim.command_system.dispatcher import Host +from gajim.command_system.dispatcher import Container +from gajim.command_system.dispatcher import get_command +from gajim.command_system.dispatcher import list_commands +from gajim.command_system.mapping import parse_arguments +from gajim.command_system.mapping import adapt_arguments +from gajim.command_system.errors import DefinitionError +from gajim.command_system.errors import CommandError +from gajim.command_system.errors import NoCommandError + class CommandHost(metaclass=Host): """ @@ -39,6 +45,7 @@ class CommandHost(metaclass=Host): """ __metaclass__ = Host + class CommandContainer(metaclass=Container): """ Command container is an entity which holds defined commands, @@ -55,6 +62,7 @@ class CommandContainer(metaclass=Container): """ __metaclass__ = Container + class CommandProcessor: """ Command processor is an immediate command emitter. It does not @@ -142,6 +150,7 @@ class CommandProcessor: commands = dict(commands) return sorted(set(commands.values()), key=lambda k: k.__repr__()) + class Command: def __init__(self, handler, *names, **properties): @@ -217,7 +226,8 @@ class Command: # Behavior of this code need to be checked. Might yield # incorrect results on some rare occasions. spec_args = names[:-len(defaults) if defaults else len(names)] - spec_kwargs = list(zip(names[-len(defaults):], defaults)) if defaults else {} + spec_kwargs = list( + zip(names[-len(defaults):], defaults)) if defaults else {} # Removing self from arguments specification. Command handler # should receive the processors as a first argument, which @@ -227,6 +237,7 @@ class Command: return spec_args, spec_kwargs, var_args, var_kwargs + def command(*names, **properties): """ A decorator for defining commands in a declarative way. Provides @@ -287,7 +298,8 @@ def command(*names, **properties): raise DefinitionError("Empty option can be used only with raw commands") if extra and overlap: - raise DefinitionError("Extra and overlap options can not be used together") + raise DefinitionError("Extra and overlap options can not be used " + "together") properties = { 'usage': usage, @@ -323,6 +335,7 @@ def command(*names, **properties): return decorator + def doc(text): """ This decorator is used to bind a documentation (a help) to a ===================================== gajim/command_system/implementation/custom.py ===================================== @@ -35,8 +35,13 @@ detected. """ from gajim.common.i18n import _ -from gajim.command_system.framework import CommandContainer, command, doc -from gajim.command_system.implementation.hosts import ChatCommands, PrivateChatCommands, GroupChatCommands +from gajim.command_system.framework import CommandContainer +from gajim.command_system.framework import command +from gajim.command_system.framework import doc +from gajim.command_system.implementation.hosts import ChatCommands +from gajim.command_system.implementation.hosts import PrivateChatCommands +from gajim.command_system.implementation.hosts import GroupChatCommands + class CustomCommonCommands(CommandContainer): """ @@ -69,6 +74,7 @@ class CustomCommonCommands(CommandContainer): """ return "I don't dance." + class CustomChatCommands(CommandContainer): """ This command container bounds only to the ChatCommands command host. @@ -92,6 +98,7 @@ class CustomChatCommands(CommandContainer): """ return "Buy yourself a stereo." + class CustomPrivateChatCommands(CommandContainer): """ This command container bounds only to the PrivateChatCommands @@ -108,6 +115,7 @@ class CustomPrivateChatCommands(CommandContainer): def make_coffee(self): return "I'm not a coffee machine!" + class CustomGroupChatCommands(CommandContainer): """ This command container bounds only to the GroupChatCommands command ===================================== gajim/command_system/implementation/execute.py ===================================== @@ -37,9 +37,15 @@ from os.path import expanduser from gi.repository import GLib +from gajim.common import app from gajim.common.i18n import _ -from gajim.command_system.framework import CommandContainer, command, doc -from gajim.command_system.implementation.hosts import ChatCommands, PrivateChatCommands, GroupChatCommands +from gajim.command_system.framework import CommandContainer +from gajim.command_system.framework import command +from gajim.command_system.framework import doc +from gajim.command_system.implementation.hosts import ChatCommands +from gajim.command_system.implementation.hosts import PrivateChatCommands +from gajim.command_system.implementation.hosts import GroupChatCommands + class Execute(CommandContainer): AUTOMATIC = True @@ -57,10 +63,18 @@ class Execute(CommandContainer): @classmethod def spawn(cls, processor, expression): - pipes = dict(stdout=PIPE, stderr=PIPE) - directory = expanduser(cls.DIRECTORY) - popen = Popen(expression, shell=True, cwd=directory, **pipes) - cls.monitor(processor, popen) + command_system_execute = app.config.get('command_system_execute') + if command_system_execute: + pipes = dict(stdout=PIPE, stderr=PIPE) + directory = expanduser(cls.DIRECTORY) + popen = Popen(expression, shell=True, cwd=directory, **pipes) + cls.monitor(processor, popen) + else: + processor.echo_error( + _('Command disabled. This command can be enabled by ' + 'setting \'command_system_execute\' to True in ACE ' + '(Advanced Configuration Editor).')) + return @classmethod def monitor(cls, processor, popen): @@ -104,6 +118,7 @@ class Execute(CommandContainer): strip = chr(10) + chr(32) return text.decode().strip(strip) + class Show(Execute): @command("sh", raw=True) ===================================== gajim/command_system/implementation/hosts.py ===================================== @@ -20,6 +20,7 @@ different command processors, which are the source of commands. from gajim.command_system.framework import CommandHost + class ChatCommands(CommandHost): """ This command host is bound to the command processor which processes @@ -27,6 +28,7 @@ class ChatCommands(CommandHost): """ AUTOMATIC = True + class PrivateChatCommands(CommandHost): """ This command host is bound to the command processor which processes @@ -34,6 +36,7 @@ class PrivateChatCommands(CommandHost): """ AUTOMATIC = True + class GroupChatCommands(CommandHost): """ This command host is bound to the command processor which processes ===================================== gajim/command_system/implementation/middleware.py ===================================== @@ -39,7 +39,9 @@ from gajim.common import app from gajim.common.i18n import _ from gajim.command_system.framework import CommandProcessor -from gajim.command_system.errors import CommandError, NoCommandError +from gajim.command_system.errors import CommandError +from gajim.command_system.errors import NoCommandError + class ChatCommandProcessor(CommandProcessor): """ @@ -95,12 +97,14 @@ class ChatCommandProcessor(CommandProcessor): self.echo(help_(self, name)) return True - def command_postprocessor(self, command, name, arguments, args, kwargs, value): + def command_postprocessor(self, command, name, arguments, args, kwargs, + value): # If command returns a string - print it to a user. A convenient # and sufficient in most simple cases shortcut to a using echo. if value and isinstance(value, str): self.echo(value) + class CommandTools: """ Contains a set of basic tools and shortcuts you can use in your ===================================== gajim/command_system/implementation/standard.py ===================================== @@ -17,7 +17,8 @@ Provides an actual implementation for the standard commands. """ -from time import localtime, strftime +from time import localtime +from time import strftime from datetime import date from gi.repository import GLib @@ -28,10 +29,14 @@ from gajim.common.i18n import _ from gajim.common.const import KindConstant from gajim.command_system.errors import CommandError -from gajim.command_system.framework import CommandContainer, command, doc +from gajim.command_system.framework import CommandContainer +from gajim.command_system.framework import command +from gajim.command_system.framework import doc from gajim.command_system.mapping import generate_usage -from gajim.command_system.implementation.hosts import ChatCommands, PrivateChatCommands, GroupChatCommands +from gajim.command_system.implementation.hosts import ChatCommands +from gajim.command_system.implementation.hosts import PrivateChatCommands +from gajim.command_system.implementation.hosts import GroupChatCommands class StandardCommonCommands(CommandContainer): @@ -44,7 +49,8 @@ class StandardCommonCommands(CommandContainer): HOSTS = ChatCommands, PrivateChatCommands, GroupChatCommands @command(overlap=True) - @doc(_("Show help on a given command or a list of available commands if -a is given")) + @doc(_("Show help on a given command or a list of available commands if " + "-a is given")) def help(self, cmd=None, all_=False): if cmd: cmd = self.get_command(cmd) @@ -111,12 +117,13 @@ class StandardCommonCommands(CommandContainer): if date_obj == date.today(): formatted = "[%s] %s: %s" % (time_, contact, row.message) else: - formatted = "[%s, %s] %s: %s" % (date_, time_, contact, row.message) + formatted = "[%s, %s] %s: %s" % ( + date_, time_, contact, row.message) self.echo(formatted) @command(raw=True, empty=True) - #Do not translate online, away, chat, xa, dnd + # Do not translate online, away, chat, xa, dnd @doc(_(""" Set the current status @@ -128,7 +135,7 @@ class StandardCommonCommands(CommandContainer): raise CommandError("Invalid status given") for connection in app.connections.values(): if not app.config.get_per('accounts', connection.name, - 'sync_with_global_status'): + 'sync_with_global_status'): continue if not connection.is_connected: continue @@ -142,7 +149,7 @@ class StandardCommonCommands(CommandContainer): for connection in app.connections.values(): if not app.config.get_per('accounts', connection.name, - 'sync_with_global_status'): + 'sync_with_global_status'): continue if not connection.is_connected: continue @@ -156,12 +163,13 @@ class StandardCommonCommands(CommandContainer): for connection in app.connections.values(): if not app.config.get_per('accounts', connection.name, - 'sync_with_global_status'): + 'sync_with_global_status'): continue if not connection.is_connected: continue connection.change_status('online', message) + class StandardCommonChatCommands(CommandContainer): """ This command container contains standard commands, which are common @@ -180,7 +188,8 @@ class StandardCommonChatCommands(CommandContainer): @doc(_("Send a ping to the contact")) def ping(self): if self.account == app.ZEROCONF_ACC_NAME: - raise CommandError(_('Command is not supported for zeroconf accounts')) + raise CommandError( + _('Command is not supported for zeroconf accounts')) app.connections[self.account].get_module('Ping').send_ping(self.contact) @command @@ -221,6 +230,7 @@ class StandardCommonChatCommands(CommandContainer): def attention(self, message): self.send_message(message, process_commands=False, attention=True) + class StandardChatCommands(CommandContainer): """ This command container contains standard commands which are unique @@ -230,6 +240,7 @@ class StandardChatCommands(CommandContainer): AUTOMATIC = True HOSTS = (ChatCommands,) + class StandardPrivateChatCommands(CommandContainer): """ This command container contains standard commands which are unique @@ -239,6 +250,7 @@ class StandardPrivateChatCommands(CommandContainer): AUTOMATIC = True HOSTS = (PrivateChatCommands,) + class StandardGroupChatCommands(CommandContainer): """ This command container contains standard commands which are unique @@ -275,7 +287,8 @@ class StandardGroupChatCommands(CommandContainer): raise CommandError(_("Nickname not found")) @command('msg', raw=True) - @doc(_("Open a private chat window with a specified participant and send him a message")) + @doc(_("Open a private chat window with a specified participant and send " + "him a message")) def message(self, nick, a_message): nicks = app.contacts.get_nick_list(self.account, self.room_jid) if nick in nicks: @@ -296,7 +309,8 @@ class StandardGroupChatCommands(CommandContainer): @doc(_("Invite a user to a group chat for a reason")) def invite(self, jid, reason): self.connection.get_module('MUC').invite(self.room_jid, jid, reason) - return _("Invited %(jid)s to %(room_jid)s") % {'jid': jid, + return _("Invited %(jid)s to %(room_jid)s") % { + 'jid': jid, 'room_jid': self.room_jid} @command(raw=True, empty=True) @@ -310,7 +324,8 @@ class StandardGroupChatCommands(CommandContainer): GLib.Variant('as', [self.account, jid])) @command('part', 'close', raw=True, empty=True) - @doc(_("Leave the group chat, optionally giving a reason, and close tab or window")) + @doc(_("Leave the group chat, optionally giving a reason, and close tab or " + "window")) def leave(self, reason): self.leave(reason=reason) @@ -322,7 +337,8 @@ class StandardGroupChatCommands(CommandContainer): """)) def ban(self, who, reason=''): if who in app.contacts.get_nick_list(self.account, self.room_jid): - contact = app.contacts.get_gc_contact(self.account, self.room_jid, who) + contact = app.contacts.get_gc_contact( + self.account, self.room_jid, who) who = contact.jid self.connection.get_module('MUC').set_affiliation( self.room_jid, @@ -332,25 +348,25 @@ class StandardGroupChatCommands(CommandContainer): @command(raw=True, empty=True) @doc(_("Kick user from group chat by nickname")) def kick(self, who, reason): - if not who in app.contacts.get_nick_list(self.account, self.room_jid): + if who not in app.contacts.get_nick_list(self.account, self.room_jid): raise CommandError(_("Nickname not found")) self.connection.get_module('MUC').set_role( self.room_jid, who, 'none', reason or str()) @command(raw=True) - #Do not translate moderator, participant, visitor, none + # Do not translate moderator, participant, visitor, none @doc(_("""Set participant role in group chat. Role can be given as one of the following values: moderator, participant, visitor, none""")) def role(self, who, role): if role not in ('moderator', 'participant', 'visitor', 'none'): raise CommandError(_("Invalid role given")) - if not who in app.contacts.get_nick_list(self.account, self.room_jid): + if who not in app.contacts.get_nick_list(self.account, self.room_jid): raise CommandError(_("Nickname not found")) self.connection.get_module('MUC').set_role(self.room_jid, who, role) @command(raw=True) - #Do not translate owner, admin, member, outcast, none + # Do not translate owner, admin, member, outcast, none @doc(_("""Set participant affiliation in group chat. Affiliation can be given as one of the following values: owner, admin, member, outcast, none""")) @@ -401,6 +417,7 @@ class StandardGroupChatCommands(CommandContainer): @doc(_("Send a ping to the contact")) def ping(self, nick): if self.account == app.ZEROCONF_ACC_NAME: - raise CommandError(_('Command is not supported for zeroconf accounts')) + raise CommandError( + _('Command is not supported for zeroconf accounts')) gc_c = app.contacts.get_gc_contact(self.account, self.room_jid, nick) app.connections[self.account].get_module('Ping').send_ping(gc_c) ===================================== gajim/command_system/mapping.py ===================================== @@ -27,7 +27,8 @@ from operator import itemgetter from gajim.common.i18n import _ -from gajim.command_system.errors import DefinitionError, CommandError +from gajim.command_system.errors import DefinitionError +from gajim.command_system.errors import CommandError # Quite complex piece of regular expression logic to parse options and # arguments. Might need some tweaking along the way. @@ -43,6 +44,7 @@ KEY_ENCODING = 'UTF-8' # on command handler argument specification) will be rendered. USAGE_PATTERN = 'Usage: %s %s' + def parse_arguments(arguments): """ Simple yet effective and sufficient in most cases parser which @@ -110,6 +112,7 @@ def parse_arguments(arguments): return args, opts + def adapt_arguments(command, arguments, args, opts): """ Adapt args and opts got from the parser to a specific handler by @@ -268,7 +271,8 @@ def adapt_arguments(command, arguments, args, opts): initial = norm_kwargs.get(key) if isinstance(initial, bool): if not isinstance(value, bool): - raise CommandError("%s: Switch can not take an argument" % key, command) + raise CommandError( + "%s: Switch can not take an argument" % key, command) # Inject the source arguments as a string as a first argument, if # command has enabled the corresponding option. @@ -279,6 +283,7 @@ def adapt_arguments(command, arguments, args, opts): # command handler and being expanded. return tuple(args), dict(opts) + def generate_usage(command, complete=True): """ Extract handler's arguments specification and wrap them in a @@ -323,7 +328,8 @@ def generate_usage(command, complete=True): if spec_args: args += '<%s>' % ', '.join(spec_args) if var_args or sp_extra: - args += (' ' if spec_args else str()) + '<<%s>>' % (var_args or sp_extra) + args += (' ' if spec_args else str()) + '<<%s>>' % ( + var_args or sp_extra) usage += args ===================================== gajim/command_system/tools.py ===================================== @@ -24,6 +24,7 @@ # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + def remove(sequence, target): if isinstance(sequence, list): if target in sequence: ===================================== gajim/common/config.py ===================================== @@ -288,6 +288,7 @@ class Config: 'muclumbus_api_http_uri': [opt_str, 'https://search.jabbercat.org/api/1.0/search'], 'muclumbus_api_pref': [opt_str, 'http', _('API Preferences. Possible values: \'http\', \'iq\'')], 'auto_copy': [opt_bool, True, _('Selecting text will copy it to the clipboard')], + 'command_system_execute': [opt_bool, False, _('If enabled, Gajim will execute commands (/show, /sh, /execute, /exec).')], }, {}) # type: Tuple[Dict[str, List[Any]], Dict[Any, Any]] __options_per_key = { View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/911aaa1f88552992788410210e9cfe34d… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/911aaa1f88552992788410210e9cfe34d… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: Replace PlainConnectionDialog with NewConfirmationCheckDialog
by Philipp Hörist 05 Sep '19

05 Sep '19

Philipp Hörist pushed to branch master at gajim / gajim Commits: 0a3bd34e by Daniel Brötzmann at 2019-09-05T19:33:28Z Replace PlainConnectionDialog with NewConfirmationCheckDialog - - - - - 911aaa1f by Daniel Brötzmann at 2019-09-05T19:34:05Z Remove PlainConnectionDialog - - - - - 2 changed files: - gajim/gtk/dialogs.py - gajim/gui_interface.py Changes: ===================================== gajim/gtk/dialogs.py ===================================== @@ -319,31 +319,6 @@ class ConfirmationDialogDoubleCheck(ConfirmationDialog): return [is_checked_1, is_checked_2] -class PlainConnectionDialog(ConfirmationDialogDoubleCheck): - """ - Dialog that is shown when using an insecure connection - """ - def __init__(self, account, on_ok, on_cancel): - pritext = _('Insecure connection') - sectext = _('You are about to connect to the account %(account)s ' - '(%(server)s) insecurely. This means conversations will not be ' - 'encrypted, and is strongly discouraged.\nAre you sure you want ' - 'to do that?') % {'account': account, - 'server': app.get_hostname_from_account(account)} - checktext1 = _('Yes, I really want to connect insecurely') - tooltip1 = _('Gajim will NOT connect unless you check this box') - checktext2 = _('_Do not ask me again') - ConfirmationDialogDoubleCheck.__init__(self, pritext, sectext, - checktext1, checktext2, tooltip1=tooltip1, on_response_ok=on_ok, - on_response_cancel=on_cancel, is_modal=False) - self.ok_button = self.get_widget_for_response(Gtk.ResponseType.OK) - self.ok_button.set_sensitive(False) - self.checkbutton1.connect('clicked', self.on_checkbutton_clicked) - self.set_title(_('Insecure connection')) - - def on_checkbutton_clicked(self, widget): - self.ok_button.set_sensitive(widget.get_active()) - class ConfirmationDialogDoubleRadio(ConfirmationDialog): """ HIG compliant confirmation dialog with 2 radios ===================================== gajim/gui_interface.py ===================================== @@ -99,10 +99,10 @@ from gajim.gtk.dialogs import ErrorDialog from gajim.gtk.dialogs import WarningDialog from gajim.gtk.dialogs import InformationDialog from gajim.gtk.dialogs import NewConfirmationDialog +from gajim.gtk.dialogs import NewConfirmationCheckDialog from gajim.gtk.dialogs import DialogButton from gajim.gtk.dialogs import InputDialog from gajim.gtk.dialogs import PassphraseDialog -from gajim.gtk.dialogs import PlainConnectionDialog from gajim.gtk.dialogs import SSLErrorDialog from gajim.gtk.dialogs import InvitationReceivedDialog from gajim.gtk.profile import ProfileWindow @@ -1161,34 +1161,38 @@ class Interface: def handle_event_plain_connection(self, obj): # ('PLAIN_CONNECTION', account, (connection)) - def on_ok(is_checked): - if not is_checked[0]: - if is_checked[1]: - app.config.set_per('accounts', obj.conn.name, - 'action_when_plaintext_connection', 'disconnect') - on_cancel() - return - # On cancel call del self.instances, so don't call it another time - # before - del self.instances[obj.conn.name]['online_dialog']\ - ['plain_connection'] - if is_checked[1]: + def _on_connect_anyway(is_checked): + if is_checked: app.config.set_per('accounts', obj.conn.name, - 'action_when_plaintext_connection', 'connect') + 'action_when_plaintext_connection', + 'connect') obj.conn.connection_accepted(obj.xmpp_client, 'plain') - def on_cancel(): - del self.instances[obj.conn.name]['online_dialog']\ - ['plain_connection'] + def _on_abort(is_checked): + if is_checked: + app.config.set_per('accounts', obj.conn.name, + 'action_when_plaintext_connection', + 'disconnect') obj.conn.disconnect(reconnect=False) app.nec.push_incoming_event(OurShowEvent(None, conn=obj.conn, - show='offline')) - - if 'plain_connection' in self.instances[obj.conn.name]['online_dialog']: - self.instances[obj.conn.name]['online_dialog']['plain_connection'].\ - destroy() - self.instances[obj.conn.name]['online_dialog']['plain_connection'] = \ - PlainConnectionDialog(obj.conn.name, on_ok, on_cancel) + show='offline')) + + NewConfirmationCheckDialog( + _('Insecure Connection'), + _('Insecure Connection'), + _('You are about to connect to the account %(account)s ' + '(%(server)s) using an insecure connection method. This means ' + 'conversations will not be encrypted. Connecting PLAIN is ' + 'strongly discouraged.') % { + 'account': obj.conn.name, + 'server': app.get_hostname_from_account(obj.conn.name)}, + _('_Do not ask me again'), + [DialogButton.make('Cancel', + text=_('_Abort'), + callback=_on_abort), + DialogButton.make('Remove', + text=_('_Connect Anyway'), + callback=_on_connect_anyway)]).show() def create_core_handlers_list(self): self.handlers = { View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/18070f5983296936b1f71da5f3ed1bec3… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/18070f5983296936b1f71da5f3ed1bec3… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/python-nbxmpp][master] Add public method to access the openssl connection object
by Philipp Hörist 05 Sep '19

05 Sep '19

Philipp Hörist pushed to branch master at gajim / python-nbxmpp Commits: 40520af1 by Philipp Hörist at 2019-09-05T20:07:53Z Add public method to access the openssl connection object - - - - - 2 changed files: - nbxmpp/client.py - nbxmpp/tls.py Changes: ===================================== nbxmpp/client.py ===================================== @@ -119,6 +119,10 @@ class NonBlockingClient: def get_bound_jid(self): return self._registered_name + def get_ssl_connection(self): + if 'NonBlockingTCP' in self.__dict__: + return self.NonBlockingTCP.get_ssl_connection() + def disconnect(self, message=''): """ Called on disconnection - disconnect callback is picked based on state of ===================================== nbxmpp/tls.py ===================================== @@ -212,6 +212,7 @@ class NonBlockingTLS(PlugIn): None is provided, a default list is used: HIGH:!aNULL """ PlugIn.__init__(self) + self._exported_methods = [self.get_ssl_connection] self.cacerts = cacerts self.mycerts = mycerts if cipher_list is None: @@ -423,3 +424,9 @@ class NonBlockingTLS(PlugIn): return sslObj.get_finished() except AttributeError: raise NotImplementedError + + def get_ssl_connection(self): + try: + return self._owner._sslObj + except Exception: + pass View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/commit/40520af11ae80d17f12f74c0ab… -- View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/commit/40520af11ae80d17f12f74c0ab… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/python-nbxmpp][master] HTTPAuth: Parse attrs correctly
by Philipp Hörist 05 Sep '19

05 Sep '19

Philipp Hörist pushed to branch master at gajim / python-nbxmpp Commits: 63d72fbd by Philipp Hörist at 2019-09-05T19:13:58Z HTTPAuth: Parse attrs correctly Fixes #84 - - - - - 1 changed file: - nbxmpp/modules/http_auth.py Changes: ===================================== nbxmpp/modules/http_auth.py ===================================== @@ -45,7 +45,10 @@ class HTTPAuth: if confirm is None: return - http_auth = confirm.getAttrs().copy() - http_auth['body'] = stanza.getTagData('body') - properties.http_auth = HTTPAuthData(**http_auth) - log.info('Found data: %s', http_auth) + attrs = confirm.getAttrs() + body = stanza.getTagData('body') + id_ = attrs.get('id') + method = attrs.get('method') + url = attrs.get('url') + properties.http_auth = HTTPAuthData(id_, method, url, body) + log.info('HTTPAuth received: %s %s %s %s', id_, method, url, body) View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/commit/63d72fbdefa46f00951f7154a2… -- View it on GitLab: https://dev.gajim.org/gajim/python-nbxmpp/commit/63d72fbdefa46f00951f7154a2… You're receiving this email because of your account on dev.gajim.org.

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits September 2019