Philipp Hörist pushed to branch master at gajim / gajim
Commits:
ead6d4f2 by Philipp Hörist at 2019-06-22T08:46:10Z
Fix is_groupchat call
is_groupchat is now a property
Fixes #9742
- - - - -
1 changed file:
- gajim/gtk/start_chat.py
Changes:
=====================================
gajim/gtk/start_chat.py
=====================================
@@ -98,7 +98,7 @@ class StartChatDialog(Gtk.ApplicationWindow):
for jid in app.contacts.get_jid_list(account):
contact = app.contacts.get_contact_with_highest_priority(
account, jid)
- if contact.is_groupchat():
+ if contact.is_groupchat:
continue
row = ContactRow(account, contact, jid,
contact.get_shown_name(), show_account)
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/ead6d4f2b0a0f8759ed38e74c6cbbcb471…
--
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/ead6d4f2b0a0f8759ed38e74c6cbbcb471…
You're receiving this email because of your account on dev.gajim.org.
Philipp Hörist pushed to branch master at gajim / gajim
Commits:
35769b38 by Philipp Hörist at 2019-06-22T08:42:50Z
Dont make showing received marker a user action
- - - - -
1 changed file:
- gajim/conversation_textview.py
Changes:
=====================================
gajim/conversation_textview.py
=====================================
@@ -428,14 +428,12 @@ class ConversationTextview(GObject.GObject):
return
buffer_ = self.tv.get_buffer()
- buffer_.begin_user_action()
if app.config.get('positive_184_ack'):
begin_iter = buffer_.get_iter_at_mark(self.xep0184_marks[id_])
buffer_.insert_with_tags_by_name(begin_iter, ' ✓',
'xep0184-received')
- buffer_.end_user_action()
del self.xep0184_marks[id_]
def show_focus_out_line(self):
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/35769b38c238433bd7583388882e5d9d78…
--
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/35769b38c238433bd7583388882e5d9d78…
You're receiving this email because of your account on dev.gajim.org.
Philipp Hörist pushed to branch master at gajim / gajim
Commits:
3d45a6e0 by Philipp Hörist at 2019-06-21T22:56:09Z
MessageWindow: Allow only JIDs as argument for get_control()
- - - - -
1 changed file:
- gajim/message_window.py
Changes:
=====================================
gajim/message_window.py
=====================================
@@ -732,25 +732,14 @@ class MessageWindow:
def get_origin(self):
return self.window.get_window().get_origin()
- def get_control(self, key, acct):
+ def get_control(self, jid, acct):
"""
- Return the MessageControl for jid or n, where n is a notebook page index.
- When key is an int index acct may be None
+ Return the MessageControl for jid
"""
-
- if isinstance(key, str):
- jid = key
- try:
- return self._controls[acct][jid]
- except Exception:
- return None
- else:
- page_num = key
- notebook = self.notebook
- if page_num is None:
- page_num = notebook.get_current_page()
- nth_child = notebook.get_nth_page(page_num)
- return self._widget_to_control(nth_child)
+ try:
+ return self._controls[acct][jid]
+ except Exception:
+ return None
def has_control(self, jid, acct):
return acct in self._controls and jid in self._controls[acct]
@@ -801,7 +790,9 @@ class MessageWindow:
ind = ind - 1
if ind < 0:
ind = self.notebook.get_n_pages() - 1
- ctrl = self.get_control(ind, None)
+
+ nth_child = self.notebook.get_nth_page(ind)
+ ctrl = self._widget_to_control(nth_child)
if ctrl.get_nb_unread() > 0:
found = True
break # found
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/3d45a6e0fc8c8fb805117dd8c347f4bd42…
--
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/3d45a6e0fc8c8fb805117dd8c347f4bd42…
You're receiving this email because of your account on dev.gajim.org.
Philipp Hörist pushed to branch master at gajim / gajim
Commits:
542b70aa by Philipp Hörist at 2019-06-21T21:29:23Z
Accounts: Destroy all GroupchatControl on disable
- - - - -
1 changed file:
- gajim/gui_interface.py
Changes:
=====================================
gajim/gui_interface.py
=====================================
@@ -1937,7 +1937,10 @@ class Interface:
self.roster.send_status(account, 'online', '')
def disable_account(self, account):
- self.roster.close_all(account)
+ self.roster.close_all(account, force=True)
+ for jid in self.minimized_controls[account]:
+ ctrl = self.minimized_controls[account][jid]
+ ctrl.shutdown()
if account == app.ZEROCONF_ACC_NAME:
app.connections[account].disable_account()
app.connections[account].cleanup()
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/542b70aa0c91a0c0dc11088b3a0081d225…
--
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/542b70aa0c91a0c0dc11088b3a0081d225…
You're receiving this email because of your account on dev.gajim.org.
Philipp Hörist pushed to branch master at gajim / gajim
Commits:
3431320a by Philipp Hörist at 2019-06-21T20:36:55Z
Remove unused imports
- - - - -
1 changed file:
- gajim/gtk/accounts.py
Changes:
=====================================
gajim/gtk/accounts.py
=====================================
@@ -25,10 +25,7 @@ from gi.repository import GObject
from gajim.common import app
from gajim.common import passwords
-from gajim.common import helpers
from gajim.common.i18n import _
-from gajim.common.connection import Connection
-from gajim.common.zeroconf.connection_zeroconf import ConnectionZeroconf
from gajim import gui_menu_builder
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/3431320accc0600ede7c1393bf85048ed0…
--
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/3431320accc0600ede7c1393bf85048ed0…
You're receiving this email because of your account on dev.gajim.org.
Philipp Hörist pushed to branch master at gajim / gajim
Commits:
7a3b82d1 by Daniel Brötzmann at 2019-06-21T19:39:26Z
MessageWindow: Fix window resizing in one window mode
When using one window mode, we get the allocated size of our message control
notebook and save it before closing. The allocated width of our notebook does
not include the background-size of the Paned's separator. Calculating width
by subtracting roster_hpaned_position from allocated width of our window fixes
this.
- - - - -
1 changed file:
- gajim/message_window.py
Changes:
=====================================
gajim/message_window.py
=====================================
@@ -1031,10 +1031,8 @@ class MessageWindowMgr(GObject.GObject):
size = (app.config.get('msgwin-width'),
app.config.get('msgwin-height'))
if self.mode == self.ONE_MSG_WINDOW_ALWAYS_WITH_ROSTER:
- # Need to add the size of the now visible paned handle, otherwise
- # the saved width of the message window decreases by this amount
- handle_size = win.parent_paned.style_get_property('handle-size')
- size = (hpaned + size[0] + handle_size, size[1])
+ # Add the hpaned position to our message window's size
+ size = (hpaned + size[0], size[1])
elif self.mode == self.ONE_MSG_WINDOW_PERACCT:
size = (app.config.get_per('accounts', acct, 'msgwin-width'),
app.config.get_per('accounts', acct, 'msgwin-height'))
@@ -1245,8 +1243,10 @@ class MessageWindowMgr(GObject.GObject):
size_width_key = type_ + '-msgwin-width'
size_height_key = type_ + '-msgwin-height'
elif self.mode == self.ONE_MSG_WINDOW_ALWAYS_WITH_ROSTER:
- # Ignore any hpaned width
- width = msg_win.notebook.get_allocation().width
+ # Ignore hpaned separator's width and calculate width ourselves
+ win_width = msg_win.window.get_allocation().width
+ hpaned_position = app.config.get('roster_hpaned_position')
+ width = win_width - hpaned_position
if acct:
app.config.set_per('accounts', acct, size_width_key, width)
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/7a3b82d15792c457cc6dae27f9827e72da…
--
View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/7a3b82d15792c457cc6dae27f9827e72da…
You're receiving this email because of your account on dev.gajim.org.