Commits November 2018

commits@gajim.org

1 participants
84 discussions

[Git][gajim/gajim][master] Fix some PyGObject deprecation warnings
by Philipp Hörist 03 Nov '18

03 Nov '18

Philipp Hörist pushed to branch master at gajim / gajim Commits: 09f0835f by André Apitzsch at 2018-11-03T12:58:11Z Fix some PyGObject deprecation warnings like The "flags" argument for dialog construction is deprecated. Please use initializer keywords: modal=True and/or destroy_with_parent=True. or Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "title, transient_for, flags" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations - - - - - 5 changed files: - gajim/application.py - gajim/dialogs.py - gajim/gtk/dialogs.py - gajim/gtk/features.py - gajim/gtk/server_info.py Changes: ===================================== gajim/application.py ===================================== @@ -189,11 +189,12 @@ class GajimApplication(Gtk.Application): caps_cache.initialize(app.logger) except exceptions.DatabaseMalformed as error: dlg = Gtk.MessageDialog( - None, - Gtk.DialogFlags.DESTROY_WITH_PARENT | Gtk.DialogFlags.MODAL, - Gtk.MessageType.ERROR, - Gtk.ButtonsType.OK, - _('Database Error')) + transient_for=None, + destroy_with_parent=True, + modal=True, + message_type=Gtk.MessageType.ERROR, + buttons=Gtk.ButtonsType.OK, + text=_('Database Error')) dlg.format_secondary_text(str(error)) dlg.run() dlg.destroy() ===================================== gajim/dialogs.py ===================================== @@ -1511,8 +1511,9 @@ class TransformChatToMUC: class Dialog(Gtk.Dialog): def __init__(self, parent, title, buttons, default=None, on_response_ok=None, on_response_cancel=None): - Gtk.Dialog.__init__(self, title, parent, - Gtk.DialogFlags.DESTROY_WITH_PARENT) + super().__init__(title=title, + transient_for=parent, + destroy_with_parent=True) self.user_response_ok = on_response_ok self.user_response_cancel = on_response_cancel ===================================== gajim/gtk/dialogs.py ===================================== @@ -900,8 +900,9 @@ class SSLErrorDialog(ConfirmationDialogDoubleCheck): class ChangePasswordDialog(Gtk.Dialog): def __init__(self, account, success_cb, transient_for): - flags = Gtk.DialogFlags.DESTROY_WITH_PARENT - super().__init__(_('Change Password'), None, flags) + super().__init__(title=_('Change Password'), + transient_for=transient_for, + destroy_with_parent=True) self._account = account self._success_cb = success_cb @@ -913,8 +914,6 @@ class ChangePasswordDialog(Gtk.Dialog): self._password2_entry = self._builder.get_object('password2_entry') self._error_label = self._builder.get_object('error_label') - self.set_transient_for(transient_for) - self.add_button(_('_OK'), Gtk.ResponseType.OK) self.set_default_response(Gtk.ResponseType.OK) self.get_style_context().add_class('dialog-margin') ===================================== gajim/gtk/features.py ===================================== @@ -31,8 +31,9 @@ from gajim.common.i18n import _ class FeaturesDialog(Gtk.Dialog): def __init__(self): - flags = Gtk.DialogFlags.DESTROY_WITH_PARENT - super().__init__(_('Features'), None, flags) + super().__init__(title=_('Features'), + transient_for=None, + destroy_with_parent=True) self.set_transient_for(app.interface.roster.window) self.set_resizable(False) @@ -205,12 +206,14 @@ class FeatureItem(Gtk.Grid): if not feature.available: self.feature_dependency_u.set_halign(Gtk.Align.START) - self.feature_dependency_u.set_alignment(0.0, 0.0) + self.feature_dependency_u.set_xalign(0.0) + self.feature_dependency_u.set_yalign(0.0) self.feature_dependency_u.set_line_wrap(True) self.feature_dependency_u.set_max_width_chars(50) self.feature_dependency_u.set_selectable(True) self.feature_dependency_w.set_halign(Gtk.Align.START) - self.feature_dependency_w.set_alignment(0.0, 0.0) + self.feature_dependency_w.set_xalign(0.0) + self.feature_dependency_w.set_yalign(0.0) self.feature_dependency_w.set_line_wrap(True) self.feature_dependency_w.set_max_width_chars(50) self.feature_dependency_w.set_selectable(True) ===================================== gajim/gtk/server_info.py ===================================== @@ -29,8 +29,9 @@ log = logging.getLogger('gajim.gtk.serverinfo') class ServerInfoDialog(Gtk.Dialog): def __init__(self, account): - flags = Gtk.DialogFlags.DESTROY_WITH_PARENT - super().__init__(_('Server Info'), None, flags) + super().__init__(title=_('Server Info'), + transient_for=None, + destroy_with_parent=True) self.account = account self.set_transient_for(app.interface.roster.window) View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/09f0835fbd02f4586181d1ea08310f1765… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/09f0835fbd02f4586181d1ea08310f1765… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][gajim_1.1] Remove unused imports
by Philipp Hörist 03 Nov '18

03 Nov '18

Philipp Hörist pushed to branch gajim_1.1 at gajim / gajim Commits: 4011dbfb by Philipp Hörist at 2018-11-03T13:10:28Z Remove unused imports - - - - - 1 changed file: - gajim/gtkgui_helpers.py Changes: ===================================== gajim/gtkgui_helpers.py ===================================== @@ -30,8 +30,6 @@ import math import logging from io import BytesIO import xml.etree.ElementTree as ET -import xml.sax.saxutils -from xml.sax import ContentHandler # type: ignore from gi.repository import Gtk from gi.repository import Gdk View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/4011dbfb7d8e84a3f8ddcb313f98c90877… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/4011dbfb7d8e84a3f8ddcb313f98c90877… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][gajim_1.1] 11 commits: Fix error with some foreign keyboard layouts
by Philipp Hörist 03 Nov '18

03 Nov '18

Philipp Hörist pushed to branch gajim_1.1 at gajim / gajim Commits: 7121dfbb by Philipp Hörist at 2018-11-03T12:55:50Z Fix error with some foreign keyboard layouts - - - - - 12cd2852 by Philipp Hörist at 2018-11-03T12:56:42Z Remove print statement - - - - - 7e3d3f95 by Philipp Hörist at 2018-11-03T12:57:50Z Use json format for the servers list - - - - - d4986e22 by Philipp Hörist at 2018-11-03T12:58:14Z Remove dead servers from servers list All removed servers did not answer to a IBR request - - - - - f5315619 by André Apitzsch at 2018-11-03T12:58:51Z Setup: move configuration to setup.cfg to improve readability - - - - - b9a6cb4c by Philipp Hörist at 2018-11-03T13:00:28Z Windows: Update dev_env.sh - - - - - 9069b844 by Philipp Hörist at 2018-11-03T13:00:28Z Windows: Fix dev_env.sh - - - - - ac18bd83 by Philipp Hörist at 2018-11-03T13:00:28Z Remove all non-ascii chars from setup.cfg https://github.com/pypa/setuptools/issues/1062 - - - - - 260b6935 by Philipp Hörist at 2018-11-03T13:00:28Z Update win/README.md - - - - - a269f706 by Philipp Hörist at 2018-11-03T13:00:58Z Remove unused shortcut - - - - - 29ad06af by André Apitzsch at 2018-11-03T13:01:09Z Move flake8 config to setup.cfg - - - - - 13 changed files: - − .flake8 - gajim/chat_control_base.py - gajim/common/helpers.py - gajim/data/gui/shortcuts_window.ui - + gajim/data/other/servers.json - − gajim/data/other/servers.xml - gajim/gtk/account_wizard.py - gajim/gtk/dialogs.py - gajim/gtkgui_helpers.py - + setup.cfg - setup.py - win/README.md - win/dev_env.sh Changes: ===================================== .flake8 deleted ===================================== @@ -1,5 +0,0 @@ -[flake8] -ignore = -exclude = .git,__pycache__,.gitlab -max-complexity = 15 -builtins=_ \ No newline at end of file ===================================== gajim/chat_control_base.py ===================================== @@ -82,6 +82,11 @@ class ChatControlBase(MessageControl, ChatCommandProcessor, CommandTools): keycode_c = keymap.get_entries_for_keyval(Gdk.KEY_c)[1][0].keycode except TypeError: keycode_c = 54 + except IndexError: + # FIXME + # On some keyboard layouts there is no keyval for KEY_c + keycode_c = None + try: keycode_ins = keymap.get_entries_for_keyval(Gdk.KEY_Insert)[1][0].keycode except TypeError: ===================================== gajim/common/helpers.py ===================================== @@ -39,6 +39,7 @@ import shlex import socket import time import logging +import json from datetime import datetime, timedelta from distutils.version import LooseVersion as V from encodings.punycode import punycode_encode @@ -1492,3 +1493,15 @@ def get_sync_threshold(jid, archive_info): app.logger.set_archive_infos(jid, sync_threshold=threshold) return threshold return archive_info.sync_threshold + +def load_json(path, key=None, default=None): + try: + with open(path, 'r') as file: + json_dict = json.loads(file.read()) + except Exception: + log.exception('Parsing error') + return default + + if key is None: + return json_dict + return json_dict.get(key, default) ===================================== gajim/data/gui/shortcuts_window.ui ===================================== @@ -75,19 +75,6 @@ </child> </object> </child> - <child> - <object class="GtkShortcutsGroup"> - <property name="visible">1</property> - <property name="title" translatable="yes">Appearance</property> - <child> - <object class="GtkShortcutsShortcut"> - <property name="visible">1</property> - <property name="accelerator"><alt>c</property> - <property name="title" translatable="yes">Toggle full / compact view</property> - </object> - </child> - </object> - </child> <child> <object class="GtkShortcutsGroup"> <property name="visible">1</property> ===================================== gajim/data/other/servers.json ===================================== @@ -0,0 +1,42 @@ +{ + "servers":[ + "0nl1ne.at", + "404.city", + "brauchen.info", + "chatme.im", + "comm.unicate.me", + "creep.im", + "deshalbfrei.org", + "draugr.de", + "im.apinc.org", + "jabber-hosting.de", + "jabber.at", + "jabber.ccc.de", + "jabber.cz", + "jabber.hot-chilli.net", + "jabber.meta.net.nz", + "jabber.no", + "jabber.sk", + "jabber.rueckgr.at", + "jabberes.org", + "jabbim.com", + "jabbim.cz", + "jabbim.pl", + "jabbim.sk", + "jabster.pl", + "lightwitch.org", + "linuxlovers.at", + "njs.netlab.cz", + "pandion.im", + "richim.org", + "suchat.org", + "tigase.im", + "ubuntu-jabber.de", + "ubuntu-jabber.net", + "verdammung.org", + "xabber.de", + "xmpp-hosting.de", + "xmpp.jp", + "zsim.de" + ] +} ===================================== gajim/data/other/servers.xml deleted ===================================== @@ -1,83 +0,0 @@ -<?xml version="1.0" encoding="utf-8"?> - -<query xmlns:reg="urn:xmpp:vcard:registration:1"> - <item jid="0nl1ne.at" /> - <item jid="404.city" /> - <item jid="brauchen.info" /> - <item jid="chatme.im" /> - <item jid="climm.org" /> - <item jid="comm.unicate.me" /> - <item jid="creep.im" /> - <item jid="deshalbfrei.org" /> - <item jid="draugr.de" /> - <item jid="einfachjabber.de" /> - <item jid="forumanalogue.fr" /> - <item jid="im.apinc.org" /> - <item jid="im.flosoft.biz" /> - <item jid="jabber-hosting.de" /> - <item jid="jabber.at" /> - <item jid="jabber.ccc.de" /> - <item jid="jabber.chaotic.de" /> - <item jid="jabber.co.nz" /> - <item jid="jabber.cz" /> - <item jid="jabber.earth.li" /> - <item jid="jabber.fourecks.de" /> - <item jid="jabber.hot-chilli.net" /> - <item jid="jabber.i-pobox.net" /> - <item jid="jabber.me" /> - <item jid="jabber.meta.net.nz" /> - <item jid="jabber.no" /> - <item jid="jabber.sk" /> - <item jid="jabber.org" /> - <item jid="jabber.rueckgr.at" /> - <item jid="jabber.scha.de" /> - <item jid="jabber.second-home.de" /> - <item jid="jabber.smash-net.org" /> - <item jid="jabber.sow.as" /> - <item jid="jabber.theforest.us" /> - <item jid="jabberafrica.org" /> - <item jid="jabberes.org" /> - <item jid="jabberpl.org" /> - <item jid="jabbim.com" /> - <item jid="jabbim.cz" /> - <item jid="jabbim.hu" /> - <item jid="jabbim.pl" /> - <item jid="jabbim.sk" /> - <item jid="jabster.pl" /> - <item jid="jaim.at" /> - <item jid="lightwitch.org" /> - <item jid="linuxlovers.at" /> - <item jid="lsd-25.ru" /> - <item jid="njs.netlab.cz" /> - <item jid="palita.net" /> - <item jid="pandion.im" /> - <item jid="richim.org" /> - <item jid="sss.chaoslab.ru" /> - <item jid="sternenschweif.de" /> - <item jid="suchat.org" /> - <item jid="swissjabber.ch" /> - <item jid="swissjabber.de" /> - <item jid="swissjabber.eu" /> - <item jid="swissjabber.li" /> - <item jid="swissjabber.org" /> - <item jid="tcweb.org" /> - <item jid="tekst.me" /> - <item jid="tigase.im" /> - <item jid="ubuntu-jabber.de" /> - <item jid="ubuntu-jabber.net" /> - <item jid="univers-libre.net" /> - <item jid="uprod.biz" /> - <item jid="verdammung.org" /> - <item jid="wtfismyip.com" /> - <item jid="xabber.de" /> - <item jid="xmpp-hosting.de" /> - <item jid="xmpp.jp" /> - <item jid="xmppnet.de" /> - <item jid="zsim.de" /> -</query> ===================================== gajim/gtk/account_wizard.py ===================================== @@ -55,10 +55,11 @@ class AccountCreationWizard: self.update_proxy_list() - # parse servers.xml - servers_xml = os.path.join( - configpaths.get('DATA'), 'other', 'servers.xml') - servers = gtkgui_helpers.parse_server_xml(servers_xml) + # parse servers.json + server_file_path = os.path.join( + configpaths.get('DATA'), 'other', 'servers.json') + servers = helpers.load_json(server_file_path, 'servers', []) + servers_model = self.xml.get_object('server_liststore') for server in servers: servers_model.append((server,)) ===================================== gajim/gtk/dialogs.py ===================================== @@ -1022,7 +1022,6 @@ class NewConfirmationDialog(Gtk.MessageDialog): class ShortcutsWindow: def __init__(self): transient = app.app.get_active_window() - print(transient) builder = get_builder('shortcuts_window.ui') self.window = builder.get_object('shortcuts_window') self.window.connect('destroy', self._on_window_destroy) ===================================== gajim/gtkgui_helpers.py ===================================== @@ -236,32 +236,6 @@ def scroll_to_end(widget): adj_h.set_value(0) return False - -class ServersXMLHandler(ContentHandler): - def __init__(self): - ContentHandler.__init__(self) - self.servers = [] - - def startElement(self, name, attributes): - if name == 'item': - if 'jid' in attributes.getNames(): - self.servers.append(attributes.getValue('jid')) - - def endElement(self, name): - pass - -def parse_server_xml(path_to_file): - try: - handler = ServersXMLHandler() - xml.sax.parse(path_to_file, handler) - return handler.servers - # handle exception if unable to open file - except IOError as message: - print(_('Error reading file:') + str(message), file=sys.stderr) - # handle exception parsing file - except xml.sax.SAXParseException as message: - print(_('Error parsing file:') + str(message), file=sys.stderr) - def set_unset_urgency_hint(window, unread_messages_no): """ Sets/unset urgency hint in window argument depending if we have unread ===================================== setup.cfg ===================================== @@ -0,0 +1,49 @@ +[flake8] +ignore = +exclude = .git,__pycache__,.gitlab +max-complexity = 15 +builtins=_ + +[metadata] +name = gajim +version = attr: gajim.__version__ +description = A GTK+ Jabber client +author = Philipp Hoerist, Yann Leboulanger +author_email = gajim-devel(a)gajim.org +url = https://gajim.org +license = GPL v3 +classifiers = + Programming Language :: Python :: 3 + +[options] +python_requires = >=3.5 +packages = find: +install_requires = + cssutils>=1.0.2 + keyring + nbxmpp>=0.6.8,<0.7.0 + precis-i18n>=1.0.0 + pyOpenSSL>=0.12 + +[options.package_data] +gajim = + data/activities/*/*/*.png + data/emoticons/*/*.png + data/emoticons/*/LICENSE + data/gui/*.ui + data/icons/hicolor/*/*/*.png + data/icons/hicolor/*/*/*.svg + data/iconsets/*/*/*.gif + data/iconsets/*/*/*.png + data/iconsets/transports/*/*/*.png + data/moods/*/*.png + data/other/* + data/sounds/*.wav + data/style/*.css + data/plugins/*/* + +[options.packages.find] +exclude = + gajim.dev + test* + ===================================== setup.py ===================================== @@ -15,8 +15,6 @@ from distutils.util import convert_path, newer import subprocess -import gajim - pos = [x for x in os.listdir('po') if x[-3:] == ".po"] ALL_LINGUAS = sorted([os.path.split(x)[-1][:-3] for x in pos]) MAN_FILES = ['gajim.1', 'gajim-history-manager.1', 'gajim-remote.1'] @@ -213,32 +211,6 @@ class update_po(Command): update_trans() -package_data_activities = ['data/activities/*/*/*.png'] -package_data_emoticons = ['data/emoticons/*/*.png', - 'data/emoticons/*/LICENSE'] -package_data_gui = ['data/gui/*.ui'] -package_data_icons = ['data/icons/hicolor/*/*/*.png', - 'data/icons/hicolor/*/*/*.svg'] -package_data_iconsets = ['data/iconsets/*/*/*.gif', - 'data/iconsets/*/*/*.png', - 'data/iconsets/transports/*/*/*.png'] -package_data_moods = ['data/moods/*/*.png'] -package_data_other = ['data/other/*'] -package_data_sounds = ['data/sounds/*.wav'] -package_data_style = ['data/style/*.css'] -package_plugins_data = ['data/plugins/*/*'] -package_data = (package_data_activities - + package_data_emoticons - + package_data_gui - + package_data_icons - + package_data_iconsets - + package_data_moods - + package_data_other - + package_data_sounds - + package_data_style - + package_plugins_data) - - # only install subdirectories of data data_files_app_icon = [ ("share/icons/hicolor/64x64/apps", @@ -254,16 +226,6 @@ data_files_app_icon = [ data_files = data_files_app_icon setup( - name="gajim", - description='A GTK+ Jabber client', - version=gajim.__version__, - author="Philipp Hörist, Yann Leboulanger", - author_email="gajim-devel(a)gajim.org", - url='https://gajim.org', - license='GPL v3', - classifiers=[ - 'Programming Language :: Python :: 3', - ], cmdclass={ 'build_py': build, 'install': install, @@ -280,14 +242,5 @@ setup( 'gajim-history-manager = gajim.history_manager:main', ] }, - packages=find_packages(exclude=["gajim.dev", "test*"]), - package_data={'gajim': package_data}, - data_files=data_files, - install_requires=[ - 'keyring', - 'nbxmpp>=0.6.8,<0.7.0', - 'pyOpenSSL>=0.12', - 'cssutils>=1.0.2', - 'precis-i18n>=1.0.0', - ] + data_files=data_files ) ===================================== win/README.md ===================================== @@ -10,7 +10,7 @@ and development on Windows. Download [msys2](http://www.msys2.org/) (msys2-x86_64-xxx.exe) and follow the install instructions on the [msys2](http://www.msys2.org/) startpage (**Important!**) * Fork the master branch on dev.gajim.org -* Execute ``C:\msys64\mingw32.exe`` +* Execute ``C:\msys64\msys2_shell.cmd -mingw64`` * Run ``pacman -S git`` to install git * Run ``git clone https://dev.gajim.org/USERNAME/gajim.git`` * Run ``cd gajim/win`` to end up where this README exists. ===================================== win/dev_env.sh ===================================== @@ -9,18 +9,25 @@ function main { mingw-w64-x86_64-python3-gobject \ mingw-w64-x86_64-python3-pip \ mingw-w64-x86_64-toolchain \ + mingw-w64-x86_64-adwaita-icon-theme \ mingw-w64-x86_64-gtk3 \ + mingw-w64-x86_64-python3-setuptools-scm \ + mingw-w64-x86_64-python3-cryptography \ + mingw-w64-x86_64-python3-certifi \ mingw-w64-x86_64-python3-pyopenssl \ - mingw-w64-x86_64-python3-pillow + mingw-w64-x86_64-python3-pillow \ + mingw-w64-x86_64-python3-six PIP_REQUIREMENTS="\ -certifi git+https://dev.gajim.org/gajim/python-nbxmpp.git git+https://dev.gajim.org/lovetox/pybonjour-python3.git +git+https://github.com/enthought/pywin32-ctypes.git python-axolotl python-gnupg keyring cssutils +qrcode +precis-i18n " pip3 install $(echo "$PIP_REQUIREMENTS" | tr ["\\n"] [" "]) View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/d86f7806dc902f2568bca1194c9c71b17… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/d86f7806dc902f2568bca1194c9c71b17… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] gui_menu_builder: remove unused variable
by Philipp Hörist 03 Nov '18

03 Nov '18

Philipp Hörist pushed to branch master at gajim / gajim Commits: 4e0295fc by André Apitzsch at 2018-11-03T12:47:03Z gui_menu_builder: remove unused variable - - - - - 1 changed file: - gajim/gui_menu_builder.py Changes: ===================================== gajim/gui_menu_builder.py ===================================== @@ -36,9 +36,6 @@ def build_resources_submenu(contacts, account, action, room_jid=None, roster = app.interface.roster sub_menu = Gtk.Menu() - iconset = app.config.get('iconset') - if not iconset: - iconset = app.config.DEFAULT_ICONSET for c in contacts: item = Gtk.MenuItem.new_with_label( '%s (%s)' % (c.resource, str(c.priority))) View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/4e0295fcd97864a69b372fc6d8dd01324f… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/4e0295fcd97864a69b372fc6d8dd01324f… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: DataFormWidget: Color required fields red
by Philipp Hörist 03 Nov '18

03 Nov '18

Philipp Hörist pushed to branch master at gajim / gajim Commits: 5d5d6864 by Philipp Hörist at 2018-11-03T12:44:36Z DataFormWidget: Color required fields red - - - - - 6e416992 by Philipp Hörist at 2018-11-03T12:44:50Z GroupchatConfig: Tidy up some rough edges - - - - - 4 changed files: - gajim/data/gui/groupchat_config.ui - gajim/data/style/gajim.css - gajim/gtk/dataform.py - gajim/gtk/groupchat_config.py Changes: ===================================== gajim/data/gui/groupchat_config.ui ===================================== @@ -323,6 +323,7 @@ <property name="sort_column_id">1</property> <child> <object class="GtkCellRendererText"> + <property name="placeholder_text">Name</property> <signal name="edited" handler="_on_nick_edited" swapped="no"/> </object> <attributes> @@ -442,7 +443,7 @@ <property name="sort_column_id">1</property> <child> <object class="GtkCellRendererText"> - <property name="placeholder_text">spam</property> + <property name="placeholder_text">Spam</property> <signal name="edited" handler="_on_reason_edited" swapped="no"/> </object> <attributes> ===================================== gajim/data/style/gajim.css ===================================== @@ -153,6 +153,7 @@ list.settings > row > box { background-color:@theme_base_color; border-bottom: 1px solid; border-color: @borders;} +#GroupchatConfig treeview { padding: 5px; } /* Popover Treeview */ .popover_treeview { border-radius: 3px; background-color: @theme_bg_color; } @@ -247,5 +248,9 @@ button.flat.link { padding: 0; border: 0; } .field-fixed { font-size: 16px; font-weight: bold; padding-top:5px;} .data-form-title { font-size: 16px; font-weight: bold; } .data-form-widget grid { margin: 18px; } -.data-form-widget scrolledwindow { border: 1px solid; border-color:@unfocused_borders; } .data-form-widget treeview { padding: 5px; } +.field-required { border: 1px solid; border-color: red; } +.field-normal { border: 1px solid; border-color:@unfocused_borders; } + +.entry-field-required { border: 1px solid; border-color: red; } +.entry-field-required:focus { box-shadow: inset 0 0 0 1px red; border-color: red; } \ No newline at end of file ===================================== gajim/gtk/dataform.py ===================================== @@ -214,6 +214,7 @@ class ListMultiField(Field): self._widget.set_min_content_height(100) self._widget.set_max_content_height(300) self._widget.add(self._treeview) + self._widget.get_style_context().add_class('field-normal') class ListMutliTreeView(Gtk.TreeView): @@ -299,6 +300,8 @@ class JidMultiField(Field): self._widget.pack_start(self._scrolled_window, True, True, 0) self._widget.pack_end(self._button_box, False, False, 0) + self._treeview.update_required_css() + def _add_clicked(self, _widget): self._treeview.get_model().append(['']) @@ -314,6 +317,7 @@ class JidMultiField(Field): continue jids.append(row[0]) self._field.values = jids + self._treeview.update_required_css() class JidMutliTreeView(Gtk.TreeView): @@ -344,6 +348,7 @@ class JidMutliTreeView(Gtk.TreeView): iter_ = self._store.get_iter(path) self._store.set_value(iter_, 0, new_text) self._set_values() + self.update_required_css() def _set_values(self): jids = [] @@ -353,6 +358,19 @@ class JidMutliTreeView(Gtk.TreeView): jids.append(row[0]) self._field.values = jids + def update_required_css(self): + style = self.get_parent().get_style_context() + if not self._field.required: + style.add_class('field-normal') + return + + if self._field.values: + style.remove_class('field-required') + style.add_class('field-normal') + else: + style.remove_class('field-normal') + style.add_class('field-required') + class TextSingleField(Field): def __init__(self, field, options): @@ -361,9 +379,20 @@ class TextSingleField(Field): self._widget = Gtk.Entry() self._widget.set_text(field.value) self._widget.connect('changed', self._changed) + self._update_required_css() def _changed(self, _widget): self._field.value = self._widget.get_text() + self._update_required_css() + + def _update_required_css(self): + if not self._field.required: + return + style = self._widget.get_style_context() + if self._field.value: + style.remove_class('entry-field-required') + else: + style.add_class('entry-field-required') class TextPrivateField(TextSingleField): @@ -387,12 +416,23 @@ class TextMultiField(Field): self._widget.set_propagate_natural_height(True) self._widget.set_min_content_height(100) self._widget.set_max_content_height(300) - self._textview = Gtk.TextView() + self._textview = Gtk.TextView() self._textview.get_buffer().set_text(field.value) self._textview.get_buffer().connect('changed', self._changed) self._widget.add(self._textview) + self._update_required_css() def _changed(self, widget): self._field.value = widget.get_text(*widget.get_bounds(), False) + self._update_required_css() + + def _update_required_css(self): + if not self._field.required: + return + style = self._widget.get_style_context() + if self._field.value: + style.remove_class('field-required') + else: + style.add_class('field-required') ===================================== gajim/gtk/groupchat_config.py ===================================== @@ -75,6 +75,7 @@ class GroupchatConfig(Gtk.ApplicationWindow): self._ui.stack.set_visible_child_name('affiliation') self._ui.connect_signals(self) + self.connect('delete-event', self._cancel) self.show_all() self._ui.stack.notify('visible-child-name') @@ -94,19 +95,19 @@ class GroupchatConfig(Gtk.ApplicationWindow): affiliation = 'member' treeview = self._get_current_treeview() - treeview.get_model().append([None, - None, - None, - affiliation, - text, - affiliation_edit, - jid_edit]) + iter_ = treeview.get_model().append([None, + None, + None, + affiliation, + text, + affiliation_edit, + jid_edit]) # Scroll to added row - row = treeview.get_model()[-1] - treeview.scroll_to_cell(row.path, None, False, 0, 0) + path = treeview.get_model().get_path(iter_) + treeview.scroll_to_cell(path, None, False, 0, 0) treeview.get_selection().unselect_all() - treeview.get_selection().select_path(row.path) + treeview.get_selection().select_path(path) def _on_remove(self, *args): treeview = self._get_current_treeview() @@ -286,10 +287,13 @@ class GroupchatConfig(Gtk.ApplicationWindow): return add, remove, modified def _on_cancel(self, *args): + self._cancel() + self.destroy() + + def _cancel(self, *args): if self._form and self._own_affiliation == 'owner': con = app.connections[self.account] con.get_module('MUC').cancel_config(self.jid) - self.destroy() def _set_affiliations(self): add, remove, modified = self._get_diff() View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/21656ebfe8e48ad74b29c5601fb48f880… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/21656ebfe8e48ad74b29c5601fb48f880… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Move flake8 config to setup.cfg
by Philipp Hörist 03 Nov '18

03 Nov '18

Philipp Hörist pushed to branch master at gajim / gajim Commits: 21656ebf by André Apitzsch at 2018-11-03T11:02:45Z Move flake8 config to setup.cfg - - - - - 2 changed files: - − .flake8 - setup.cfg Changes: ===================================== .flake8 deleted ===================================== @@ -1,5 +0,0 @@ -[flake8] -ignore = -exclude = .git,__pycache__,.gitlab -max-complexity = 15 -builtins=_ \ No newline at end of file ===================================== setup.cfg ===================================== @@ -1,3 +1,9 @@ +[flake8] +ignore = +exclude = .git,__pycache__,.gitlab +max-complexity = 15 +builtins=_ + [metadata] name = gajim version = attr: gajim.__version__ View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/21656ebfe8e48ad74b29c5601fb48f880b… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/21656ebfe8e48ad74b29c5601fb48f880b… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Fix displaying PEP icons
by Philipp Hörist 02 Nov '18

02 Nov '18

Philipp Hörist pushed to branch master at gajim / gajim Commits: bf9e01ee by Philipp Hörist at 2018-11-02T21:51:57Z Fix displaying PEP icons - Rename get_pep_as_pixbuf to get_pep_icon - - - - - 3 changed files: - gajim/chat_control.py - gajim/gtkgui_helpers.py - gajim/roster_window.py Changes: ===================================== gajim/chat_control.py ===================================== @@ -416,7 +416,11 @@ class ChatControl(ChatControlBase): pep = self.contact.pep img = self._pep_images[pep_type] if pep_type in pep: - img.set_from_pixbuf(gtkgui_helpers.get_pep_as_pixbuf(pep[pep_type])) + icon = gtkgui_helpers.get_pep_icon(pep[pep_type]) + if isinstance(icon, str): + img.set_from_icon_name(icon, Gtk.IconSize.MENU) + else: + img.set_from_pixbuf(icon) img.set_tooltip_markup(pep[pep_type].as_markup_text()) img.show() else: ===================================== gajim/gtkgui_helpers.py ===================================== @@ -383,7 +383,7 @@ def load_activity_icon(category, activity=None): icon_list = _load_icon_list([activity], path) return icon_list[activity] -def get_pep_as_pixbuf(pep_class): +def get_pep_icon(pep_class): if pep_class == PEPEventType.MOOD: received_mood = pep_class.data['mood'] mood = received_mood if received_mood in MOODS else 'unknown' ===================================== gajim/roster_window.py ===================================== @@ -1088,27 +1088,27 @@ class RosterWindow: pep_dict = app.connections[account].pep if app.config.get('show_mood_in_roster') and 'mood' in pep_dict: self.model[child_iter][Column.MOOD_PIXBUF] = \ - gtkgui_helpers.get_pep_as_pixbuf(pep_dict['mood']) + gtkgui_helpers.get_pep_icon(pep_dict['mood']) else: self.model[child_iter][Column.MOOD_PIXBUF] = None if app.config.get('show_activity_in_roster') and 'activity' in \ pep_dict: self.model[child_iter][Column.ACTIVITY_PIXBUF] = \ - gtkgui_helpers.get_pep_as_pixbuf(pep_dict['activity']) + gtkgui_helpers.get_pep_icon(pep_dict['activity']) else: self.model[child_iter][Column.ACTIVITY_PIXBUF] = None if app.config.get('show_tunes_in_roster') and 'tune' in pep_dict: self.model[child_iter][Column.TUNE_ICON] = \ - gtkgui_helpers.get_pep_as_pixbuf(pep_dict['tune']) + gtkgui_helpers.get_pep_icon(pep_dict['tune']) else: self.model[child_iter][Column.TUNE_ICON] = None if app.config.get('show_location_in_roster') and 'geoloc' in \ pep_dict: self.model[child_iter][Column.LOCATION_ICON] = \ - gtkgui_helpers.get_pep_as_pixbuf(pep_dict['geoloc']) + gtkgui_helpers.get_pep_icon(pep_dict['geoloc']) else: self.model[child_iter][Column.LOCATION_ICON] = None @@ -1392,7 +1392,7 @@ class RosterWindow: pixbuf = None if pep_type in contact.pep: - pixbuf = gtkgui_helpers.get_pep_as_pixbuf(contact.pep[pep_type]) + pixbuf = gtkgui_helpers.get_pep_icon(contact.pep[pep_type]) for child_iter in iters: self.model[child_iter][model_column] = pixbuf View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/bf9e01ee31a231118c9c73d9f3e0d9dd1a… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/bf9e01ee31a231118c9c73d9f3e0d9dd1a… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 3 commits: Set active window as transient for dialogs
by Philipp Hörist 02 Nov '18

02 Nov '18

Philipp Hörist pushed to branch master at gajim / gajim Commits: 0662374c by Philipp Hörist at 2018-11-02T21:17:08Z Set active window as transient for dialogs - - - - - e615a8e2 by Philipp Hörist at 2018-11-02T21:21:15Z Add possibility to get windows by jid This also makes it possible to get windows by an account/jid combination - - - - - 61a791d6 by Philipp Hörist at 2018-11-02T21:24:28Z Rewrite GroupchatConfig dialog - Complete rewrite of the dialog - Use new DataFormWidget - - - - - 9 changed files: - gajim/common/app.py - gajim/common/const.py - gajim/common/modules/muc.py - + gajim/data/gui/groupchat_config.ui - gajim/data/style/gajim.css - gajim/groupchat_control.py - gajim/gtk/dialogs.py - gajim/gtk/groupchat_config.py - gajim/gui_interface.py Changes: ===================================== gajim/common/app.py ===================================== @@ -630,19 +630,22 @@ def prefers_app_menu(): return False return app.prefers_app_menu() -def get_app_window(cls, account=None): +def get_app_window(cls, account=None, jid=None): for win in app.get_windows(): if isinstance(cls, str): - if type(win).__name__ == cls: - if account is not None: - if account != win.account: - continue - return win - elif isinstance(win, cls): - if account is not None: - if account != win.account: - continue - return win + if type(win).__name__ != cls: + continue + elif not isinstance(win, cls): + continue + + if account is not None: + if account != win.account: + continue + + if jid is not None: + if jid != win.jid: + continue + return win return None def load_css_config(): ===================================== gajim/common/const.py ===================================== @@ -193,6 +193,16 @@ class SyncThreshold(IntEnum): return str(self.value) +class MUCUser(IntEnum): + JID = 0 + NICK = 1 + REASON = 1 + NICK_OR_REASON = 1 + ROLE = 2 + AFFILIATION = 3 + AFFILIATION_TEXT = 4 + + ACTIVITIES = { 'doing_chores': { 'category': _('Doing Chores'), ===================================== gajim/common/modules/muc.py ===================================== @@ -17,6 +17,7 @@ import time import logging +import weakref import nbxmpp @@ -187,28 +188,40 @@ class MUC: item = iq.setQuery() for jid in users_dict: affiliation = users_dict[jid].get('affiliation') - reason = users_dict[jid].get('reason') or None + reason = users_dict[jid].get('reason') + nick = users_dict[jid].get('nick') item_tag = item.addChild('item', {'jid': jid, 'affiliation': affiliation}) if reason is not None: item_tag.setTagData('reason', reason) + + if nick is not None: + item_tag.setAttr('nick', nick) log.info('Set affiliation for %s: %s', room_jid, users_dict) self._con.connection.SendAndCallForResponse( iq, self._default_response, {}) - def get_affiliation(self, room_jid, affiliation): + def get_affiliation(self, room_jid, affiliation, success_cb, error_cb): if not app.account_is_connected(self._account): return iq = nbxmpp.Iq(typ='get', to=room_jid, queryNS=nbxmpp.NS_MUC_ADMIN) item = iq.setQuery().setTag('item') item.setAttr('affiliation', affiliation) log.info('Get affiliation %s for %s', affiliation, room_jid) + + weak_success_cb = weakref.WeakMethod(success_cb) + weak_error_cb = weakref.WeakMethod(error_cb) + self._con.connection.SendAndCallForResponse( - iq, self._affiliation_received) + iq, self._affiliation_received, {'affiliation': affiliation, + 'success_cb': weak_success_cb, + 'error_cb': weak_error_cb}) - def _affiliation_received(self, stanza): + def _affiliation_received(self, _con, stanza, affiliation, + success_cb, error_cb): if not nbxmpp.isResultNode(stanza): - log.info('Error: %s', stanza.getError()) + if error_cb() is not None: + error_cb()(affiliation, stanza.getError()) return room_jid = stanza.getFrom().getStripped() @@ -222,8 +235,8 @@ class MUC: log.warning('Invalid JID: %s, ignoring it', item.getAttr('jid')) continue - affiliation = item.getAttr('affiliation') - users_dict[jid] = {'affiliation': affiliation} + + users_dict[jid] = {} if item.has_attr('nick'): users_dict[jid]['nick'] = item.getAttr('nick') if item.has_attr('role'): @@ -231,9 +244,12 @@ class MUC: reason = item.getTagData('reason') if reason: users_dict[jid]['reason'] = reason - log.info('Affiliations received from %s: %s', room_jid, users_dict) - app.nec.push_incoming_event(MucAdminReceivedEvent( - None, conn=self._con, room_jid=room_jid, users_dict=users_dict)) + + log.info('%s affiliations received from %s: %s', + affiliation, room_jid, users_dict) + + if success_cb() is not None: + success_cb()(self._account, room_jid, affiliation, users_dict) def set_role(self, room_jid, nick, role, reason=''): if not app.account_is_connected(self._account): @@ -423,10 +439,6 @@ class GcDeclineReceived(NetworkIncomingEvent): name = 'gc-decline-received' -class MucAdminReceivedEvent(NetworkIncomingEvent): - name = 'muc-admin-received' - - class MucOwnerReceivedEvent(NetworkIncomingEvent): name = 'muc-owner-received' ===================================== gajim/data/gui/groupchat_config.ui ===================================== @@ -0,0 +1,493 @@ +<?xml version="1.0" encoding="UTF-8"?> + +<interface> + <requires lib="gtk+" version="3.20"/> + <object class="GtkListStore" id="affiliation_store"> + <columns> +  + <column type="gchararray"/> +  + <column type="gchararray"/> +  + <column type="gchararray"/> +  + <column type="gchararray"/> +  + <column type="gchararray"/> +  + <column type="gboolean"/> +  + <column type="gboolean"/> + </columns> + </object> + <object class="GtkListStore" id="combo_store"> + <columns> +  + <column type="gchararray"/> +  + <column type="gchararray"/> + </columns> + <data> + <row> + <col id="0" translatable="yes">Owner</col> + <col id="1">owner</col> + </row> + <row> + <col id="0" translatable="yes">Admin</col> + <col id="1">admin</col> + </row> + <row> + <col id="0" translatable="yes">Member</col> + <col id="1">member</col> + </row> + </data> + </object> + <object class="GtkPopover" id="info_popover"> + <property name="can_focus">False</property> + <child> + <object class="GtkLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="margin_left">12</property> + <property name="margin_right">12</property> + <property name="margin_top">12</property> + <property name="margin_bottom">12</property> + <property name="label" translatable="yes"><b>Jabber-ID</b> +&lt;user@domain/resource&gt; (only that resource matches) +&lt;user@domain&gt; (any resource matches) +&lt;domain/resource&gt; (only that resource matches) +&lt;domain&gt; (the domain itself matches, as does any user@domain or domain/resource) +</property> + <property name="use_markup">True</property> + </object> + </child> + </object> + <object class="GtkListStore" id="outcast_store"> + <columns> +  + <column type="gchararray"/> +  + <column type="gchararray"/> +  + <column type="gchararray"/> +  + <column type="gchararray"/> +  + <column type="gchararray"/> +  + <column type="gboolean"/> +  + <column type="gboolean"/> + </columns> + </object> + <object class="GtkGrid" id="grid"> + <property name="name">GroupchatConfig</property> + <property name="width_request">700</property> + <property name="height_request">500</property> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="row_spacing">12</property> + <child> + <object class="GtkBox"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="hexpand">False</property> + <child> + <object class="GtkBox" id="treeview_buttonbox"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="valign">start</property> + <property name="margin_left">12</property> + <property name="vexpand">False</property> + <property name="spacing">6</property> + <child> + <object class="GtkMenuButton"> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="receives_default">True</property> + <property name="popover">info_popover</property> + <child> + <object class="GtkImage"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="icon_name">dialog-information-symbolic</property> + </object> + </child> + <style> + <class name="suggested-action"/> + </style> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">False</property> + <property name="position">0</property> + </packing> + </child> + <child> + <object class="GtkButton" id="add_button"> + <property name="visible">True</property> + <property name="sensitive">False</property> + <property name="can_focus">True</property> + <property name="receives_default">True</property> + <property name="tooltip_text" translatable="yes">Only Admins and Owners can modify the affiliation</property> + <property name="halign">start</property> + <signal name="clicked" handler="_on_add" swapped="no"/> + <child> + <object class="GtkImage"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="icon_name">list-add-symbolic</property> + </object> + </child> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">False</property> + <property name="position">1</property> + </packing> + </child> + <child> + <object class="GtkButton" id="remove_button"> + <property name="label" translatable="yes">Remove</property> + <property name="visible">True</property> + <property name="sensitive">False</property> + <property name="can_focus">True</property> + <property name="receives_default">True</property> + <property name="tooltip_text" translatable="yes">Only Admins and Owners can modify the affiliation</property> + <signal name="clicked" handler="_on_remove" swapped="no"/> + <style> + <class name="destructive-action"/> + </style> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">False</property> + <property name="position">2</property> + </packing> + </child> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">False</property> + <property name="position">0</property> + </packing> + </child> + <child> + <object class="GtkButtonBox" id="close_ok_button_box"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="spacing">6</property> + <property name="layout_style">end</property> + <child> + <object class="GtkButton"> + <property name="label">gtk-cancel</property> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="receives_default">True</property> + <property name="use_stock">True</property> + <signal name="clicked" handler="_on_cancel" swapped="no"/> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">False</property> + <property name="pack_type">end</property> + <property name="position">0</property> + </packing> + </child> + <child> + <object class="GtkButton"> + <property name="label">gtk-ok</property> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="receives_default">True</property> + <property name="use_stock">True</property> + <signal name="clicked" handler="_on_ok" swapped="no"/> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">False</property> + <property name="pack_type">end</property> + <property name="position">1</property> + </packing> + </child> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">False</property> + <property name="pack_type">end</property> + <property name="position">1</property> + </packing> + </child> + </object> + <packing> + <property name="left_attach">1</property> + <property name="top_attach">1</property> + </packing> + </child> + <child> + <object class="GtkStack" id="stack"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="hexpand">True</property> + <property name="vexpand">True</property> + <property name="transition_duration">300</property> + <property name="transition_type">crossfade</property> + <signal name="notify::visible-child-name" handler="_on_switch_page" swapped="no"/> + <child> + <object class="GtkGrid" id="config_grid"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <child> + <placeholder/> + </child> + <child> + <placeholder/> + </child> + <child> + <placeholder/> + </child> + <child> + <placeholder/> + </child> + <child> + <placeholder/> + </child> + <child> + <placeholder/> + </child> + <child> + <placeholder/> + </child> + <child> + <placeholder/> + </child> + <child> + <placeholder/> + </child> + </object> + <packing> + <property name="name">config</property> + <property name="title" translatable="yes">Configuration</property> + </packing> + </child> + <child> + <object class="GtkGrid"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <child> + <object class="GtkScrolledWindow"> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="hexpand">True</property> + <property name="vexpand">True</property> + <property name="hscrollbar_policy">never</property> + <property name="shadow_type">in</property> + <child> + <object class="GtkTreeView" id="affiliation_treeview"> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="model">affiliation_store</property> + <property name="search_column">0</property> + <child internal-child="selection"> + <object class="GtkTreeSelection"> + <property name="mode">multiple</property> + <signal name="changed" handler="_on_selection_changed" swapped="no"/> + </object> + </child> + <child> + <object class="GtkTreeViewColumn"> + <property name="resizable">True</property> + <property name="sizing">autosize</property> + <property name="title">Jabber-ID</property> + <property name="expand">True</property> + <property name="sort_indicator">True</property> + <property name="sort_column_id">0</property> + <child> + <object class="GtkCellRendererText"> + <property name="placeholder_text">user(a)example.org</property> + <signal name="edited" handler="_on_jid_edited" swapped="no"/> + </object> + <attributes> + <attribute name="editable">6</attribute> + <attribute name="text">0</attribute> + </attributes> + </child> + </object> + </child> + <child> + <object class="GtkTreeViewColumn" id="reserved_name_column"> + <property name="resizable">True</property> + <property name="sizing">autosize</property> + <property name="title" translatable="yes">Reserved Name</property> + <property name="sort_indicator">True</property> + <property name="sort_column_id">1</property> + <child> + <object class="GtkCellRendererText"> + <signal name="edited" handler="_on_nick_edited" swapped="no"/> + </object> + <attributes> + <attribute name="editable">6</attribute> + <attribute name="text">1</attribute> + </attributes> + </child> + </object> + </child> + <child> + <object class="GtkTreeViewColumn" id="role_column"> + <property name="visible">False</property> + <property name="resizable">True</property> + <property name="sizing">autosize</property> + <property name="min_width">100</property> + <property name="title" translatable="yes">Role</property> + <property name="sort_indicator">True</property> + <property name="sort_column_id">2</property> + <child> + <object class="GtkCellRendererText"/> + <attributes> + <attribute name="text">2</attribute> + </attributes> + </child> + </object> + </child> + <child> + <object class="GtkTreeViewColumn"> + <property name="resizable">True</property> + <property name="sizing">autosize</property> + <property name="min_width">120</property> + <property name="title" translatable="yes">Affiliation</property> + <property name="sort_indicator">True</property> + <property name="sort_column_id">3</property> + <child> + <object class="GtkCellRendererCombo"> + <property name="has_entry">False</property> + <property name="model">combo_store</property> + <property name="text_column">0</property> + <signal name="changed" handler="_on_affiliation_changed" swapped="no"/> + </object> + <attributes> + <attribute name="editable">5</attribute> + <attribute name="text">4</attribute> + </attributes> + </child> + </object> + </child> + </object> + </child> + <style> + <class name="margin-12"/> + </style> + </object> + <packing> + <property name="left_attach">0</property> + <property name="top_attach">0</property> + </packing> + </child> + </object> + <packing> + <property name="name">affiliation</property> + <property name="title" translatable="yes">Affiliations</property> + <property name="position">1</property> + </packing> + </child> + <child> + <object class="GtkGrid"> + <property name="can_focus">False</property> + <property name="no_show_all">True</property> + <child> + <object class="GtkScrolledWindow"> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="hexpand">True</property> + <property name="vexpand">True</property> + <property name="shadow_type">in</property> + <child> + <object class="GtkTreeView" id="outcast_treeview"> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="model">outcast_store</property> + <property name="search_column">0</property> + <child internal-child="selection"> + <object class="GtkTreeSelection"> + <property name="mode">multiple</property> + <signal name="changed" handler="_on_selection_changed" swapped="no"/> + </object> + </child> + <child> + <object class="GtkTreeViewColumn"> + <property name="resizable">True</property> + <property name="sizing">autosize</property> + <property name="title">Jabber-ID</property> + <property name="expand">True</property> + <property name="sort_indicator">True</property> + <property name="sort_column_id">0</property> + <child> + <object class="GtkCellRendererText"> + <property name="placeholder_text">user(a)example.org</property> + <signal name="edited" handler="_on_outcast_jid_edited" swapped="no"/> + </object> + <attributes> + <attribute name="editable">6</attribute> + <attribute name="text">0</attribute> + </attributes> + </child> + </object> + </child> + <child> + <object class="GtkTreeViewColumn"> + <property name="resizable">True</property> + <property name="sizing">autosize</property> + <property name="min_width">250</property> + <property name="title" translatable="yes">Reason</property> + <property name="sort_indicator">True</property> + <property name="sort_column_id">1</property> + <child> + <object class="GtkCellRendererText"> + <property name="placeholder_text">spam</property> + <signal name="edited" handler="_on_reason_edited" swapped="no"/> + </object> + <attributes> + <attribute name="editable">6</attribute> + <attribute name="text">1</attribute> + </attributes> + </child> + </object> + </child> + </object> + </child> + <style> + <class name="margin-12"/> + </style> + </object> + <packing> + <property name="left_attach">0</property> + <property name="top_attach">0</property> + </packing> + </child> + </object> + <packing> + <property name="name">outcast</property> + <property name="title" translatable="yes">Ban List</property> + <property name="position">2</property> + </packing> + </child> + </object> + <packing> + <property name="left_attach">1</property> + <property name="top_attach">0</property> + </packing> + </child> + <child> + <object class="GtkStackSidebar"> + <property name="width_request">140</property> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="stack">stack</property> + </object> + <packing> + <property name="left_attach">0</property> + <property name="top_attach">0</property> + <property name="height">2</property> + </packing> + </child> + </object> +</interface> ===================================== gajim/data/style/gajim.css ===================================== @@ -146,6 +146,14 @@ list.settings > row > box { #StartChatListBox > row { padding: 10px 20px 10px 10px; } #StartChatListBox > row:not(.activatable) label { color: @insensitive_fg_color } +/* GroupchatConfig */ +#GroupchatConfig buttonbox { margin: 0px 12px 12px 12px; } +#GroupchatConfig stack { border-bottom: 1px solid; border-color: @borders;} +#GroupchatConfig stacksidebar > scrolledwindow { + background-color:@theme_base_color; + border-bottom: 1px solid; + border-color: @borders;} + /* Popover Treeview */ .popover_treeview { border-radius: 3px; background-color: @theme_bg_color; } .popover_treeview { padding: 6px; } @@ -211,6 +219,7 @@ list.settings > row > box { /* Padding/Margins */ .margin-top6 { margin-top: 6px; } +.margin-12 { margin: 12px; } /* Treeview */ treeview.space { padding: 6px; } ===================================== gajim/groupchat_control.py ===================================== @@ -728,18 +728,21 @@ class GroupchatControl(ChatControlBase): _('You may also enter an alternate venue:'), ok_handler=on_ok, transient_for=self.parent_win.window) - def _on_configure_room(self, action, param): - c = app.contacts.get_gc_contact( + def _on_configure_room(self, _action, _param): + contact = app.contacts.get_gc_contact( self.account, self.room_jid, self.nick) - if c.affiliation == 'owner': + if contact.affiliation == 'owner': con = app.connections[self.account] con.get_module('MUC').request_config(self.room_jid) - elif c.affiliation == 'admin': - if self.room_jid not in app.interface.instances[self.account][ - 'gc_config']: - app.interface.instances[self.account]['gc_config'][ - self.room_jid] = GroupchatConfig(self.account, - self.room_jid) + elif contact.affiliation == 'admin': + win = app.get_app_window( + 'GroupchatConfig', self.account, self.room_jid) + if win is not None: + win.present() + else: + GroupchatConfig(self.account, + self.room_jid, + contact.affiliation) def _on_bookmark_room(self, action, param): """ ===================================== gajim/gtk/dialogs.py ===================================== @@ -128,11 +128,8 @@ class NonModalConfirmationDialog(HigDialog): on_response_cancel=None): self.user_response_ok = on_response_ok self.user_response_cancel = on_response_cancel - if hasattr(app.interface, 'roster') and app.interface.roster: - parent = app.interface.roster.window - else: - parent = None - HigDialog.__init__(self, parent, Gtk.MessageType.QUESTION, + transient_for = app.app.get_active_window() + HigDialog.__init__(self, transient_for, Gtk.MessageType.QUESTION, Gtk.ButtonsType.OK_CANCEL, pritext, sectext, self.on_response_ok, self.on_response_cancel) self.set_modal(False) @@ -162,9 +159,8 @@ class WarningDialog(HigDialog): """ def __init__(self, pritext, sectext='', transient_for=None): - if not transient_for and hasattr(app.interface, 'roster') and \ - app.interface.roster: - transient_for = app.interface.roster.window + if transient_for is None: + transient_for = app.app.get_active_window() HigDialog.__init__(self, transient_for, Gtk.MessageType.WARNING, Gtk.ButtonsType.OK, pritext, sectext) self.set_modal(False) @@ -177,13 +173,9 @@ class InformationDialog(HigDialog): """ def __init__(self, pritext, sectext='', transient_for=None): - if transient_for: - parent = transient_for - elif hasattr(app.interface, 'roster') and app.interface.roster: - parent = app.interface.roster.window - else: - parent = None - HigDialog.__init__(self, parent, Gtk.MessageType.INFO, Gtk.ButtonsType.OK, + if transient_for is None: + transient_for = app.app.get_active_window() + HigDialog.__init__(self, transient_for, Gtk.MessageType.INFO, Gtk.ButtonsType.OK, pritext, sectext) self.set_modal(False) self.popup() @@ -196,13 +188,9 @@ class ErrorDialog(HigDialog): def __init__(self, pritext, sectext='', on_response_ok=None, on_response_cancel=None, transient_for=None): - if transient_for: - parent = transient_for - elif hasattr(app.interface, 'roster') and app.interface.roster: - parent = app.interface.roster.window - else: - parent = None - HigDialog.__init__(self, parent, Gtk.MessageType.ERROR, Gtk.ButtonsType.OK, + if transient_for is None: + transient_for = app.app.get_active_window() + HigDialog.__init__(self, transient_for, Gtk.MessageType.ERROR, Gtk.ButtonsType.OK, pritext, sectext, on_response_ok=on_response_ok, on_response_cancel=on_response_cancel) self.popup() @@ -218,13 +206,9 @@ class YesNoDialog(HigDialog): transient_for=None): self.user_response_yes = on_response_yes self.user_response_no = on_response_no - if transient_for: - parent = transient_for - elif hasattr(app.interface, 'roster') and app.interface.roster: - parent = app.interface.roster.window - else: - parent = None - HigDialog.__init__(self, parent, type_, Gtk.ButtonsType.YES_NO, pritext, + if transient_for is None: + transient_for = app.app.get_active_window() + HigDialog.__init__(self, transient_for, type_, Gtk.ButtonsType.YES_NO, pritext, sectext, on_response_yes=self.on_response_yes, on_response_no=self.on_response_no) @@ -308,14 +292,9 @@ class ConfirmationDialogCheck(ConfirmationDialog): on_response_cancel=None, is_modal=True, transient_for=None): self.user_response_ok = on_response_ok self.user_response_cancel = on_response_cancel - - if transient_for: - parent = transient_for - elif hasattr(app.interface, 'roster') and app.interface.roster: - parent = app.interface.roster.window - else: - parent = None - HigDialog.__init__(self, parent, Gtk.MessageType.QUESTION, + if transient_for is None: + transient_for = app.app.get_active_window() + HigDialog.__init__(self, transient_for, Gtk.MessageType.QUESTION, Gtk.ButtonsType.OK_CANCEL, pritext, sectext, self.on_response_ok, self.on_response_cancel) @@ -363,15 +342,12 @@ class ConfirmationDialogDoubleCheck(ConfirmationDialog): def __init__(self, pritext, sectext='', checktext1='', checktext2='', tooltip1='', tooltip2='', on_response_ok=None, on_response_cancel=None, - is_modal=True): + transient_for=None, is_modal=True): self.user_response_ok = on_response_ok self.user_response_cancel = on_response_cancel - - if hasattr(app.interface, 'roster') and app.interface.roster: - parent = app.interface.roster.window - else: - parent = None - HigDialog.__init__(self, parent, Gtk.MessageType.QUESTION, + if transient_for is None: + transient_for = app.app.get_active_window() + HigDialog.__init__(self, transient_for, Gtk.MessageType.QUESTION, Gtk.ButtonsType.OK_CANCEL, pritext, sectext, self.on_response_ok, self.on_response_cancel) @@ -524,13 +500,9 @@ class FTOverwriteConfirmationDialog(ConfirmationDialog): """ def __init__(self, pritext, sectext='', propose_resume=True, on_response=None, transient_for=None): - if transient_for: - parent = transient_for - elif hasattr(app.interface, 'roster') and app.interface.roster: - parent = app.interface.roster.window - else: - parent = None - HigDialog.__init__(self, parent, Gtk.MessageType.QUESTION, + if transient_for is None: + transient_for = app.app.get_active_window() + HigDialog.__init__(self, transient_for, Gtk.MessageType.QUESTION, Gtk.ButtonsType.CANCEL, pritext, sectext) self.on_response = on_response @@ -578,10 +550,9 @@ class CommonInputDialog: label.set_markup(label_str) self.cancel_handler = cancel_handler self.vbox = self.xml.get_object('vbox') - if transient_for: - self.dialog.set_transient_for(transient_for) - else: - self.dialog.set_transient_for(app.interface.roster.window) + if transient_for is None: + transient_for = app.app.get_active_window() + self.dialog.set_transient_for(transient_for) self.ok_handler = ok_handler okbutton = self.xml.get_object('okbutton') @@ -821,8 +792,9 @@ class DoubleInputDialog: if input_str2: self.input_entry2.set_text(input_str2) self.input_entry2.select_region(0, -1) # select all - if transient_for: - self.dialog.set_transient_for(transient_for) + if transient_for is None: + transient_for = app.app.get_active_window() + self.dialog.set_transient_for(transient_for) self.dialog.set_modal(is_modal) @@ -865,7 +837,7 @@ class DoubleInputDialog: class CertificatDialog(InformationDialog): - def __init__(self, parent, account, cert): + def __init__(self, transient_for, account, cert): issuer = cert.get_issuer() subject = cert.get_subject() InformationDialog.__init__(self, @@ -903,7 +875,7 @@ SHA-256 Fingerprint: %(sha256)s img = Gtk.Image.new_from_surface(surface) img.show_all() self.set_image(img) - self.set_transient_for(parent) + self.set_transient_for(transient_for) self.set_title(_('Certificate for account %s') % account) ===================================== gajim/gtk/groupchat_config.py ===================================== @@ -12,237 +12,365 @@ # You should have received a copy of the GNU General Public License # along with Gajim. If not, see <http://www.gnu.org/licenses/>. +import logging + +import nbxmpp from gi.repository import Gtk from gajim.common import app from gajim.common.i18n import _ +from gajim.common.const import MUCUser +from gajim.common.caps_cache import muc_caps_cache -from gajim import dataforms_widget - +from gajim.gtk.dialogs import ErrorDialog +from gajim.gtk.dataform import DataFormWidget from gajim.gtk.util import get_builder -from gajim.gtk.dialogs import InputDialog + +log = logging.getLogger('gajim.gtk.groupchat_config') -class GroupchatConfig: - def __init__(self, account, room_jid, form=None): +class GroupchatConfig(Gtk.ApplicationWindow): + def __init__(self, account, jid, own_affiliation, form=None): + Gtk.ApplicationWindow.__init__(self) + self.set_application(app.app) + self.set_position(Gtk.WindowPosition.CENTER) + self.set_show_menubar(False) + self.set_title(_('Group Chat Configuration')) + self.account = account - self.room_jid = room_jid - self.form = form - self.remove_button = {} - self.affiliation_treeview = {} - self.start_users_dict = {} # list at the beginning - self.affiliation_labels = { - 'outcast': _('Ban List'), - 'member': _('Member List'), - 'owner': _('Owner List'), - 'admin':_('Administrator List') - } - - self._ui = get_builder('data_form_window.ui', ['data_form_window']) - self.window = self._ui.data_form_window - self.window.set_transient_for(app.interface.roster.window) - - if self.form: - self.data_form_widget = dataforms_widget.DataFormWidget(self.form) - # hide scrollbar of this data_form_widget, we already have in this - # widget - sw = self.data_form_widget.xml.get_object( - 'single_form_scrolledwindow') - sw.set_policy(Gtk.PolicyType.NEVER, Gtk.PolicyType.NEVER) - if self.form.title: - self._ui.title_label.set_text(self.form.title) - else: - self._ui.title_hseparator.set_no_show_all(True) - self._ui.title_hseparator.hide() + self.jid = jid + self._own_affiliation = own_affiliation - self.data_form_widget.show() - self._ui.config_vbox.pack_start(self.data_form_widget, True, True, 0) - else: - self._ui.title_label.set_no_show_all(True) - self._ui.title_label.hide() - self._ui.title_hseparator.set_no_show_all(True) - self._ui.title_hseparator.hide() - self._ui.config_hseparator.set_no_show_all(True) - self._ui.config_hseparator.hide() - - # Draw the edit affiliation list things - add_on_vbox = self._ui.add_on_vbox - - for affiliation in self.affiliation_labels: - self.start_users_dict[affiliation] = {} - hbox = Gtk.HBox(spacing=5) - add_on_vbox.pack_start(hbox, False, True, 0) - - label = Gtk.Label(label=self.affiliation_labels[affiliation]) - hbox.pack_start(label, False, True, 0) - - bb = Gtk.HButtonBox() - bb.set_layout(Gtk.ButtonBoxStyle.END) - bb.set_spacing(5) - hbox.pack_start(bb, True, True, 0) - add_button = Gtk.Button(stock=Gtk.STOCK_ADD) - add_button.connect( - 'clicked', self.on_add_button_clicked, affiliation) - bb.pack_start(add_button, True, True, 0) - self.remove_button[affiliation] = Gtk.Button(stock=Gtk.STOCK_REMOVE) - self.remove_button[affiliation].set_sensitive(False) - self.remove_button[affiliation].connect( - 'clicked', self.on_remove_button_clicked, affiliation) - bb.pack_start(self.remove_button[affiliation], True, True, 0) - - # jid, reason, nick, role - liststore = Gtk.ListStore(str, str, str, str) - self.affiliation_treeview[affiliation] = Gtk.TreeView(liststore) - self.affiliation_treeview[affiliation].get_selection().set_mode( - Gtk.SelectionMode.MULTIPLE) - self.affiliation_treeview[affiliation].connect( - 'cursor-changed', - self.on_affiliation_treeview_cursor_changed, - affiliation) - renderer = Gtk.CellRendererText() - col = Gtk.TreeViewColumn(_('JID'), renderer) - col.add_attribute(renderer, 'text', 0) - col.set_resizable(True) - col.set_sort_column_id(0) - self.affiliation_treeview[affiliation].append_column(col) + self._ui = get_builder('groupchat_config.ui') + self.add(self._ui.grid) - if affiliation == 'outcast': - renderer = Gtk.CellRendererText() - renderer.set_property('editable', True) - renderer.connect('edited', self.on_cell_edited) - col = Gtk.TreeViewColumn(_('Reason'), renderer) - col.add_attribute(renderer, 'text', 1) - col.set_resizable(True) - col.set_sort_column_id(1) - self.affiliation_treeview[affiliation].append_column(col) - elif affiliation == 'member': - renderer = Gtk.CellRendererText() - col = Gtk.TreeViewColumn(_('Nick'), renderer) - col.add_attribute(renderer, 'text', 2) - col.set_resizable(True) - col.set_sort_column_id(2) - self.affiliation_treeview[affiliation].append_column(col) - renderer = Gtk.CellRendererText() - col = Gtk.TreeViewColumn(_('Role'), renderer) - col.add_attribute(renderer, 'text', 3) - col.set_resizable(True) - col.set_sort_column_id(3) - self.affiliation_treeview[affiliation].append_column(col) - - sw = Gtk.ScrolledWindow() - sw.add(self.affiliation_treeview[affiliation]) - add_on_vbox.pack_start(sw, True, True, 0) - con = app.connections[self.account] - con.get_module('MUC').get_affiliation(self.room_jid, affiliation) + # Activate Add button only for Admins and Owners + if self._own_affiliation in ('admin', 'owner'): + self._ui.add_button.set_sensitive(True) + self._ui.add_button.set_tooltip_text('') - self._ui.connect_signals(self) - self.window.connect('delete-event', self.on_cancel_button_clicked) - self.window.show_all() + visible = muc_caps_cache.supports(jid, nbxmpp.NS_REGISTER) + self._ui.reserved_name_column.set_visible(visible) - def on_cancel_button_clicked(self, *args): - if self.form: - con = app.connections[self.account] - con.get_module('MUC').cancel_config(self.room_jid) - self.window.destroy() + self._form = form + self._affiliations = {} + self._new_affiliations = {} - def on_cell_edited(self, _cell, path, new_text): - model = self.affiliation_treeview['outcast'].get_model() - new_text = new_text - iter_ = model.get_iter(path) - model[iter_][1] = new_text + con = app.connections[self.account] + for affiliation in ('owner', 'admin', 'member', 'outcast'): + con.get_module('MUC').get_affiliation( + self.jid, + affiliation, + self._on_affiliations_received, + self._on_affiliations_error) - def on_add_button_clicked(self, _widget, affiliation): - if affiliation == 'outcast': - title = _('Banning…') - #You can move '\n' before user@domain if that line is TOO BIG - prompt = _('<b>Whom do you want to ban?</b>\n\n') - elif affiliation == 'member': - title = _('Adding Member…') - prompt = _('<b>Whom do you want to make a member?</b>\n\n') - elif affiliation == 'owner': - title = _('Adding Owner…') - prompt = _('<b>Whom do you want to make an owner?</b>\n\n') + if form is not None: + self._ui.stack.set_visible_child_name('config') + self._data_form_widget = DataFormWidget(form) + self._ui.config_grid.add(self._data_form_widget) + # self._ui.stack.set_visible_child_name('affiliation') + else: + self._ui.stack.get_child_by_name('config').hide() + self._ui.stack.get_child_by_name('config').set_no_show_all(True) + self._ui.stack.set_visible_child_name('affiliation') + + self._ui.connect_signals(self) + self.show_all() + self._ui.stack.notify('visible-child-name') + + def _get_current_treeview(self): + page_name = self._ui.stack.get_visible_child_name() + return getattr(self._ui, '%s_treeview' % page_name) + + def _on_add(self, *args): + page_name = self._ui.stack.get_visible_child_name() + if page_name == 'outcast': + affiliation_edit, jid_edit = self._allowed_to_edit('outcast') + text = None + affiliation = 'outcast' else: - title = _('Adding Administrator…') - prompt = _('<b>Whom do you want to make an administrator?</b>\n\n') - prompt += _( - 'Can be one of the following:\n' - '1. user@domain/resource (only that resource matches).\n' - '2. user@domain (any resource matches).\n' - '3. domain/resource (only that resource matches).\n' - '4. domain (the domain itself matches, as does any user@domain,\n' - 'domain/resource, or address containing a subdomain).') - - def on_ok(jid): - if not jid: - return - model = self.affiliation_treeview[affiliation].get_model() - model.append((jid, '', '', '')) - InputDialog(title, prompt, ok_handler=on_ok) - - def on_remove_button_clicked(self, _widget, affiliation): - selection = self.affiliation_treeview[affiliation].get_selection() - model, paths = selection.get_selected_rows() - row_refs = [] + affiliation_edit, jid_edit = self._allowed_to_edit('member') + text = _('Member') + affiliation = 'member' + + treeview = self._get_current_treeview() + treeview.get_model().append([None, + None, + None, + affiliation, + text, + affiliation_edit, + jid_edit]) + + # Scroll to added row + row = treeview.get_model()[-1] + treeview.scroll_to_cell(row.path, None, False, 0, 0) + treeview.get_selection().unselect_all() + treeview.get_selection().select_path(row.path) + + def _on_remove(self, *args): + treeview = self._get_current_treeview() + model, paths = treeview.get_selection().get_selected_rows() + + owner_count = self._get_owner_count() + references = [] for path in paths: - row_refs.append(Gtk.TreeRowReference.new(model, path)) - for row_ref in row_refs: - path = row_ref.get_path() - iter_ = model.get_iter(path) + if model[path][MUCUser.AFFILIATION] == 'owner': + if owner_count < 2: + # There must be at least one owner + ErrorDialog(_('Error'), + _('A Group Chat needs at least one Owner')) + return + owner_count -= 1 + references.append(Gtk.TreeRowReference.new(model, path)) + + for ref in references: + iter_ = model.get_iter(ref.get_path()) model.remove(iter_) - self.remove_button[affiliation].set_sensitive(False) - - def on_affiliation_treeview_cursor_changed(self, _widget, affiliation): - self.remove_button[affiliation].set_sensitive(True) - - def affiliation_list_received(self, users_dict): - """ - Fill the affiliation treeview - """ - for jid in users_dict: - affiliation = users_dict[jid]['affiliation'] - if affiliation not in self.affiliation_labels.keys(): - # Unknown affiliation or 'none' affiliation, do not show it - continue - self.start_users_dict[affiliation][jid] = users_dict[jid] - tv = self.affiliation_treeview[affiliation] - model = tv.get_model() - reason = users_dict[jid].get('reason', '') - nick = users_dict[jid].get('nick', '') - role = users_dict[jid].get('role', '') - model.append((jid, reason, nick, role)) - - def on_data_form_window_destroy(self, _widget): - del app.interface.instances[self.account]['gc_config'][self.room_jid] - - def on_ok_button_clicked(self, _widget): - if self.form: - form = self.data_form_widget.data_form + + def _on_jid_edited(self, _renderer, path, new_text): + old_text = self._ui.affiliation_store[path][MUCUser.JID] + if new_text == old_text: + return + + if self._jid_exists(new_text): + self._raise_error() + return + + self._ui.affiliation_store[path][MUCUser.JID] = new_text + + def _on_outcast_jid_edited(self, _renderer, path, new_text): + old_text = self._ui.outcast_store[path][MUCUser.JID] + if new_text == old_text: + return + + if self._jid_exists(new_text): + self._raise_error() + return + + self._ui.outcast_store[path][MUCUser.JID] = new_text + self._ui.outcast_store[path][MUCUser.AFFILIATION] = 'outcast' + + def _on_nick_edited(self, _renderer, path, new_text): + self._ui.affiliation_store[path][MUCUser.NICK] = new_text + + def _on_reason_edited(self, _renderer, path, new_text): + self._ui.outcast_store[path][MUCUser.REASON] = new_text + + def _on_affiliation_changed(self, cell_renderer_combo, + path_string, new_iter): + combo_store = cell_renderer_combo.get_property('model') + affiliation_text = combo_store.get_value(new_iter, 0) + affiliation = combo_store.get_value(new_iter, 1) + + store = self._ui.affiliation_treeview.get_model() + + store[path_string][MUCUser.AFFILIATION] = affiliation + store[path_string][MUCUser.AFFILIATION_TEXT] = affiliation_text + + def _on_selection_changed(self, tree_selection): + sensitive = bool(tree_selection.count_selected_rows()) + selected_affiliations = self._get_selected_affiliations(tree_selection) + self._set_remove_button_state(sensitive, selected_affiliations) + + def _jid_exists(self, jid): + stores = [self._ui.affiliation_store, self._ui.outcast_store] + + for store in stores: + for row in store: + if row[MUCUser.JID] == jid: + return True + return False + + @staticmethod + def _get_selected_affiliations(tree_selection): + model, paths = tree_selection.get_selected_rows() + selected_affiliations = set() + for path in paths: + selected_affiliations.add(model[path][MUCUser.AFFILIATION]) + return selected_affiliations + + def _on_switch_page(self, stack, _pspec): + page_name = stack.get_visible_child_name() + self._set_button_box_state(page_name) + if page_name == 'config': + return + + treeview = getattr(self._ui, '%s_treeview' % page_name) + sensitive = bool(treeview.get_selection().count_selected_rows()) + + selected_affiliations = self._get_selected_affiliations( + treeview.get_selection()) + self._set_remove_button_state(sensitive, selected_affiliations) + + def _set_button_box_state(self, page_name): + affiliation = self._own_affiliation in ('admin', 'owner') + page = page_name != 'config' + self._ui.treeview_buttonbox.set_visible(affiliation and page) + + def _set_remove_button_state(self, sensitive, selected_affiliations): + if self._own_affiliation not in ('admin', 'owner'): + self._ui.remove_button.set_sensitive(False) + return + + self._ui.remove_button.set_tooltip_text('') + + if not sensitive: + self._ui.remove_button.set_sensitive(False) + return + + if self._own_affiliation == 'owner': + self._ui.remove_button.set_sensitive(True) + return + + if set(['owner', 'admin']).intersection(selected_affiliations): + self._ui.remove_button.set_sensitive(False) + self._ui.remove_button.set_tooltip_text( + _('You are not allowed to modify the affiliation ' + 'of Admins and Owners')) + return + + self._ui.remove_button.set_sensitive(True) + + def _get_owner_count(self): + owner_count = 0 + for row in self._ui.affiliation_store: + if row[MUCUser.AFFILIATION] == 'owner': + owner_count += 1 + return owner_count + + def _allowed_to_edit(self, affiliation): + if self._own_affiliation == 'owner': + return True, True + + if self._own_affiliation == 'admin': + if affiliation in ('admin', 'owner'): + return False, False + return False, True + return False, False + + def _on_ok(self, *args): + if self._own_affiliation in ('admin', 'owner'): + self._set_affiliations() + + if self._form is not None and self._own_affiliation == 'owner': + form = self._data_form_widget.get_submit_form() con = app.connections[self.account] - con.get_module('MUC').set_config(self.room_jid, form) - for affiliation in self.affiliation_labels: - users_dict = {} - actual_jid_list = [] - model = self.affiliation_treeview[affiliation].get_model() - iter_ = model.get_iter_first() - # add new jid - while iter_: - jid = model[iter_][0] - actual_jid_list.append(jid) - if jid not in self.start_users_dict[affiliation] or \ - (affiliation == 'outcast' and 'reason' in self.start_users_dict[ - affiliation][jid] and self.start_users_dict[affiliation][jid]\ - ['reason'] != model[iter_][1]): - users_dict[jid] = {'affiliation': affiliation} - if affiliation == 'outcast': - users_dict[jid]['reason'] = model[iter_][1] - iter_ = model.iter_next(iter_) - # remove removed one - for jid in self.start_users_dict[affiliation]: - if jid not in actual_jid_list: - users_dict[jid] = {'affiliation': 'none'} - if users_dict: - con = app.connections[self.account] - con.get_module('MUC').set_affiliation( - self.room_jid, users_dict) - self.window.destroy() + con.get_module('MUC').set_config(self.jid, form) + self.destroy() + + def _get_diff(self): + stores = [self._ui.affiliation_store, self._ui.outcast_store] + + self._new_affiliations = {} + for store in stores: + for row in store: + if not row[MUCUser.JID]: + # Ignore empty JID field + continue + + attr = 'nick' + if row[MUCUser.AFFILIATION] == 'outcast': + attr = 'reason' + + self._new_affiliations[row[MUCUser.JID]] = { + 'affiliation': row[MUCUser.AFFILIATION], + attr: row[MUCUser.NICK_OR_REASON]} + + old_jids = set(self._affiliations.keys()) + new_jids = set(self._new_affiliations.keys()) + remove = old_jids - new_jids + add = new_jids - old_jids + modified = new_jids - remove - add + + return add, remove, modified + + def _on_cancel(self, *args): + if self._form and self._own_affiliation == 'owner': + con = app.connections[self.account] + con.get_module('MUC').cancel_config(self.jid) + self.destroy() + + def _set_affiliations(self): + add, remove, modified = self._get_diff() + + diff_dict = {} + for jid in add: + diff_dict[jid] = self._new_affiliations[jid] + + for jid in remove: + diff_dict[jid] = {'affiliation': 'none'} + + for jid in modified: + if self._new_affiliations[jid] == self._affiliations[jid]: + # Not modified + continue + + diff_dict[jid] = self._new_affiliations[jid] + if self._new_affiliations[jid]['affiliation'] == 'outcast': + # New affiliation is outcast, check if the reason changed. + # In case the affiliation was 'admin', 'owner' or 'member' + # before, there is no reason. + new_reason = self._new_affiliations[jid]['reason'] + old_reason = self._affiliations[jid].get('reason') + if new_reason == old_reason: + diff_dict[jid].pop('reason', None) + + else: + # New affiliation is not outcast, check if the nick has changed. + # In case the affiliation was 'outcast' there is no nick. + new_nick = self._new_affiliations[jid]['nick'] + old_nick = self._affiliations[jid].get('nick') + if new_nick == old_nick: + diff_dict[jid].pop('nick', None) + + if not diff_dict: + # No changes were made + return + con = app.connections[self.account] + con.get_module('MUC').set_affiliation(self.jid, diff_dict) + + def _on_affiliations_error(self, affiliation, error): + log.info('Error while requesting %s affiliations: %s', + affiliation, error) + + def _on_affiliations_received(self, _account, _room_jid, + affiliation, users): + + if affiliation == 'outcast': + self._ui.stack.get_child_by_name('outcast').show() + + for jid, attrs in users.items(): + affiliation_edit, jid_edit = self._allowed_to_edit(affiliation) + if affiliation == 'outcast': + reason = attrs.get('reason') + self._ui.outcast_store.append( + [jid, + reason, + None, + affiliation, + None, + affiliation_edit, + jid_edit]) + self._affiliations[jid] = {'affiliation': affiliation, + 'reason': reason} + else: + nick = attrs.get('nick') + role = attrs.get('role') + self._ui.affiliation_store.append( + [jid, + nick, + role, + affiliation, + _(affiliation.capitalize()), + affiliation_edit, + jid_edit]) + self._affiliations[jid] = {'affiliation': affiliation, + 'nick': nick} + if role is not None: + self._ui.role_column.set_visible(True) + + @staticmethod + def _raise_error(): + ErrorDialog(_('Error'), + _('An entry with this Jabber-ID already exists')) ===================================== gajim/gui_interface.py ===================================== @@ -601,16 +601,12 @@ class Interface: _('%(jid)s has been invited in this room') % { 'jid': jid}, graphics=False) del app.automatic_rooms[account][obj.jid] - elif obj.jid not in self.instances[account]['gc_config']: - self.instances[account]['gc_config'][obj.jid] = \ - GroupchatConfig(account, obj.jid, obj.dataform) - - def handle_event_gc_affiliation(self, obj): - #('GC_AFFILIATION', account, (room_jid, users_dict)) - account = obj.conn.name - if obj.room_jid in self.instances[account]['gc_config']: - self.instances[account]['gc_config'][obj.room_jid].\ - affiliation_list_received(obj.users_dict) + else: + win = app.get_app_window('GroupchatConfig', account, obj.jid) + if win is not None: + win.present() + else: + GroupchatConfig(account, obj.jid, 'owner', obj.dataform) def handle_event_gc_decline(self, obj): gc_control = self.msg_win_mgr.get_gc_control(obj.room_jid, obj.account) @@ -1531,7 +1527,6 @@ class Interface: 'message-not-sent': [self.handle_event_msgnotsent], 'message-sent': [self.handle_event_msgsent], 'metacontacts-received': [self.handle_event_metacontacts], - 'muc-admin-received': [self.handle_event_gc_affiliation], 'muc-owner-received': [self.handle_event_gc_config], 'oauth2-credentials-required': [self.handle_oauth2_credentials], 'our-show': [self.handle_event_status], View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/32e736aa32710164cd4fd7412126d0074… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/32e736aa32710164cd4fd7412126d0074… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Remove unused shortcut
by Philipp Hörist 02 Nov '18

02 Nov '18

Philipp Hörist pushed to branch master at gajim / gajim Commits: 32e736aa by Philipp Hörist at 2018-11-02T20:01:26Z Remove unused shortcut - - - - - 1 changed file: - gajim/data/gui/shortcuts_window.ui Changes: ===================================== gajim/data/gui/shortcuts_window.ui ===================================== @@ -75,19 +75,6 @@ </child> </object> </child> - <child> - <object class="GtkShortcutsGroup"> - <property name="visible">1</property> - <property name="title" translatable="yes">Appearance</property> - <child> - <object class="GtkShortcutsShortcut"> - <property name="visible">1</property> - <property name="accelerator"><alt>c</property> - <property name="title" translatable="yes">Toggle full / compact view</property> - </object> - </child> - </object> - </child> <child> <object class="GtkShortcutsGroup"> <property name="visible">1</property> View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/32e736aa32710164cd4fd7412126d00744… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/32e736aa32710164cd4fd7412126d00744… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] ManageSounds GUI Update
by Philipp Hörist 02 Nov '18

02 Nov '18

Philipp Hörist pushed to branch master at gajim / gajim Commits: 7cae8809 by Daniel Brötzmann at 2018-11-02T16:09:28Z ManageSounds GUI Update - - - - - 3 changed files: - gajim/data/gui/manage_sounds_window.ui - gajim/gtk/preferences.py - gajim/gtk/sounds.py Changes: ===================================== gajim/data/gui/manage_sounds_window.ui ===================================== @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?>  <interface> - <requires lib="gtk+" version="3.12"/> + <requires lib="gtk+" version="3.20"/> <object class="GtkListStore" id="liststore1"> <columns>  @@ -19,16 +19,19 @@ <property name="width_request">400</property> <property name="height_request">370</property> <property name="can_focus">False</property> - <property name="border_width">12</property> + <property name="border_width">18</property> <property name="title" translatable="yes">Manage sounds</property> <property name="window_position">center-on-parent</property> + <property name="default_width">400</property> + <property name="default_height">370</property> <property name="type_hint">dialog</property> - <signal name="delete-event" handler="_on_destroy" swapped="no"/> + <signal name="destroy" handler="_on_destroy" swapped="no"/> + <signal name="key-press-event" handler="_on_key_press" swapped="no"/> <child> <placeholder/> </child> <child> - <object class="GtkBox" id="vbox1"> + <object class="GtkBox"> <property name="visible">True</property> <property name="can_focus">False</property> <property name="orientation">vertical</property> @@ -106,7 +109,7 @@ <property name="visible">True</property> <property name="can_focus">True</property> <property name="receives_default">True</property> - <property name="tooltip_text" translatable="yes">Clear File</property> + <property name="tooltip_text" translatable="yes">Clear Sound</property> <signal name="clicked" handler="_on_clear" swapped="no"/> <child> <object class="GtkImage"> @@ -127,9 +130,10 @@ <property name="visible">True</property> <property name="can_focus">True</property> <property name="receives_default">False</property> + <property name="tooltip_text" translatable="yes">Play Sound</property> <signal name="clicked" handler="_on_play" swapped="no"/> <child> - <object class="GtkImage" id="image1370"> + <object class="GtkImage"> <property name="visible">True</property> <property name="can_focus">False</property> <property name="icon_name">media-playback-start-symbolic</property> @@ -150,35 +154,6 @@ <property name="position">1</property> </packing> </child> - <child> - <object class="GtkButtonBox" id="hbuttonbox1"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="spacing">6</property> - <property name="layout_style">end</property> - <child> - <object class="GtkButton" id="close_button"> - <property name="label">gtk-close</property> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="receives_default">True</property> - <property name="use_stock">True</property> - <signal name="clicked" handler="_on_destroy" swapped="no"/> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">False</property> - <property name="position">0</property> - </packing> - </child> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">True</property> - <property name="pack_type">end</property> - <property name="position">2</property> - </packing> - </child> </object> </child> </object> ===================================== gajim/gtk/preferences.py ===================================== @@ -682,7 +682,7 @@ class Preferences(Gtk.ApplicationWindow): def on_manage_sounds_button_clicked(self, widget): if self.sounds_preferences is None: - self.sounds_preferences = ManageSounds(self) + self.sounds_preferences = ManageSounds() else: self.sounds_preferences.window.present() ===================================== gajim/gtk/sounds.py ===================================== @@ -14,6 +14,7 @@ import os +from gi.repository import Gdk from gi.repository import Gtk from gajim.common import app @@ -24,10 +25,10 @@ from gajim.gtk.util import get_builder class ManageSounds: - def __init__(self, transient): + def __init__(self): self._ui = get_builder('manage_sounds_window.ui') self.window = self._ui.manage_sounds_window - self.window.set_transient_for(transient) + self.window.set_transient_for(app.app.get_active_window()) filter_ = Gtk.FileFilter() filter_.set_name(_('All files')) @@ -115,8 +116,11 @@ class ManageSounds: snd_event_config_name = model[iter_][3] helpers.play_sound(snd_event_config_name) + def _on_key_press(self, widget, event): + if event.keyval == Gdk.KEY_Escape: + self.window.destroy() + def _on_destroy(self, *args): - self.window.destroy() window = app.get_app_window('Preferences') if window is not None: window.sounds_preferences = None View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/7cae880920736ae8ad39ea204afd1a09c6… -- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/7cae880920736ae8ad39ea204afd1a09c6… You're receiving this email because of your account on dev.gajim.org.

1 0

← Newer
1
2
3
4
5
6
7
8
9
Older →

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits November 2018