Commits August 2017

commits@gajim.org

1 participants
94 discussions

[Git][gajim/gajim][master] Hide some pylint errors
by Yann Leboulanger 24 Aug '17

24 Aug '17

Yann Leboulanger pushed to branch master at gajim / gajim Commits: 134f72db by Yann Leboulanger at 2017-08-24T23:20:35+02:00 Hide some pylint errors - - - - - 3 changed files: - gajim/common/app.py - gajim/common/jingle_session.py - gajim/common/zeroconf/zeroconf.py Changes: ===================================== gajim/common/app.py ===================================== --- a/gajim/common/app.py +++ b/gajim/common/app.py @@ -42,7 +42,7 @@ from gajim.common.contacts import LegacyContactsAPI from gajim.common.events import Events interface = None # The actual interface (the gtk one for the moment) -thread_interface = None # Interface to run a thread and then a callback +thread_interface = lambda *args: None # Interface to run a thread and then a callback config = config.Config() version = config.get('version') connections = {} # 'account name': 'account (connection.Connection) instance' ===================================== gajim/common/jingle_session.py ===================================== --- a/gajim/common/jingle_session.py +++ b/gajim/common/jingle_session.py @@ -495,12 +495,12 @@ class JingleSession: parse_result = self.__parse_contents(jingle) contents = parse_result[0] rejected_contents = parse_result[1] - for name, creator in rejected_contents: +# for name, creator in rejected_contents: # TODO - content = JingleContent() - self.add_content(name, content, creator) - self.__content_reject(content) - self.contents[(content.creator, content.name)].destroy() +# content = JingleContent() +# self.add_content(name, content, creator) +# self.__content_reject(content) +# self.contents[(content.creator, content.name)].destroy() app.nec.push_incoming_event(JingleRequestReceivedEvent(None, conn=self.connection, jingle_session=self, ===================================== gajim/common/zeroconf/zeroconf.py ===================================== --- a/gajim/common/zeroconf/zeroconf.py +++ b/gajim/common/zeroconf/zeroconf.py @@ -48,7 +48,7 @@ def test_bonjour(): import pybonjour except ImportError: return False - except WindowsError: + except WindowsError: # pylint: disable=undefined-variable return False return True View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/134f72db173d1f1ef7e4061226dd0c150a… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/134f72db173d1f1ef7e4061226dd0c150a… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] fix some pylint errors
by Yann Leboulanger 24 Aug '17

24 Aug '17

Yann Leboulanger pushed to branch master at gajim / gajim Commits: 8d4e815f by Yann Leboulanger at 2017-08-24T23:01:06+02:00 fix some pylint errors - - - - - 7 changed files: - gajim/common/commands.py - gajim/common/dataforms.py - gajim/common/protocol/bytestream.py - gajim/common/socks5.py - gajim/common/zeroconf/client_zeroconf.py - gajim/gui_interface.py - gajim/plugins/pluginmanager.py Changes: ===================================== gajim/common/commands.py ===================================== --- a/gajim/common/commands.py +++ b/gajim/common/commands.py @@ -85,6 +85,10 @@ class ChangeStatusCommand(AdHocCommand): commandnode = 'change-status' commandname = _('Change status information') + def __init__(self, conn, jid, sessionid): + AdHocCommand.__init__(self, conn, jid, sessionid) + self.cb = self.first_step + @staticmethod def isVisibleFor(samejid): """ @@ -93,6 +97,9 @@ class ChangeStatusCommand(AdHocCommand): return samejid def execute(self, request): + return self.cb(request) + + def first_step(self, request): # first query... response, cmd = self.buildResponse(request, defaultaction = 'execute', actions = ['execute']) @@ -120,11 +127,11 @@ class ChangeStatusCommand(AdHocCommand): self.connection.connection.send(response) # for next invocation - self.execute = self.changestatus + self.cb = self.second_step return True # keep the session - def changestatus(self, request): + def second_step(self, request): # check if the data is correct try: form = dataforms.SimpleDataForm(extend = request.getTag('command').\ @@ -184,6 +191,10 @@ class LeaveGroupchatsCommand(AdHocCommand): commandnode = 'leave-groupchats' commandname = _('Leave Groupchats') + def __init__(self, conn, jid, sessionid): + AdHocCommand.__init__(self, conn, jid, sessionid) + self.cb = self.first_step + @staticmethod def isVisibleFor(samejid): """ @@ -192,6 +203,9 @@ class LeaveGroupchatsCommand(AdHocCommand): return samejid def execute(self, request): + return self.cb(request) + + def first_step(self, request): # first query... response, cmd = self.buildResponse(request, defaultaction = 'execute', actions=['execute']) @@ -220,11 +234,11 @@ class LeaveGroupchatsCommand(AdHocCommand): self.connection.connection.send(response) # for next invocation - self.execute = self.leavegroupchats + self.cb = self.second_step return True # keep the session - def leavegroupchats(self, request): + def second_step(self, request): # check if the data is correct try: form = dataforms.SimpleDataForm(extend = request.getTag('command').\ ===================================== gajim/common/dataforms.py ===================================== --- a/gajim/common/dataforms.py +++ b/gajim/common/dataforms.py @@ -305,7 +305,7 @@ class Media(nbxmpp.Node): for uri in value: self.addChild(node=uri) - def fdel(self, value): + def fdel(self): for element in self.getTags('uri'): self.delChild(element) ===================================== gajim/common/protocol/bytestream.py ===================================== --- a/gajim/common/protocol/bytestream.py +++ b/gajim/common/protocol/bytestream.py @@ -720,7 +720,7 @@ class ConnectionSocks5Bytestream(ConnectionBytestream): if file_props.stopped: self.remove_transfer(file_props) else: - app.socks5queue.send_file(file_props, self.name) + app.socks5queue.send_file(file_props, self.name, 'server') raise nbxmpp.NodeProcessed proxy = None ===================================== gajim/common/socks5.py ===================================== --- a/gajim/common/socks5.py +++ b/gajim/common/socks5.py @@ -730,7 +730,7 @@ class Socks5(object): try: fd = self.get_fd() except IOError: - self.disconnect(False) + self.disconnect() self.file_props.error = -6 # file system error return 0 fd.write(self.remaining_buff) @@ -751,7 +751,7 @@ class Socks5(object): try: fd = self.get_fd() except IOError: - self.disconnect(False) + self.disconnect() self.file_props.error = -6 # file system error return 0 try: ===================================== gajim/common/zeroconf/client_zeroconf.py ===================================== --- a/gajim/common/zeroconf/client_zeroconf.py +++ b/gajim/common/zeroconf/client_zeroconf.py @@ -375,7 +375,7 @@ class P2PConnection(IdleObject, PlugIn): self.ais = socket.getaddrinfo(address['host'], address['port'], socket.AF_UNSPEC, socket.SOCK_STREAM) except socket.gaierror as e: - log.info('Lookup failure for %s: %s[%s]', host, e[1], + log.info('Lookup failure for %s: %s[%s]', self.host, e[1], repr(e[0]), exc_info=True) if len(self.addresses_) > 0: return self.get_next_addrinfo() else: ===================================== gajim/gui_interface.py ===================================== --- a/gajim/gui_interface.py +++ b/gajim/gui_interface.py @@ -2582,7 +2582,7 @@ class Interface: win.hide() return True window.connect('delete_event', on_delete) - view.updateNamespace({'gajim': gajim}) + view.updateNamespace({'gajim': app}) app.ipython_window = window def run(self, application): ===================================== gajim/plugins/pluginmanager.py ===================================== --- a/gajim/plugins/pluginmanager.py +++ b/gajim/plugins/pluginmanager.py @@ -568,7 +568,7 @@ class PluginManager(metaclass=Singleton): for option in fields: if conf.get('info', option) is '': - raise configparser.NoOptionError('field empty') + raise configparser.NoOptionError(option, 'info') if option == 'description': setattr(module_attr, option, _(conf.get('info', option))) continue View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/8d4e815f3eff74c237cd8ef0ff22306c64… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/8d4e815f3eff74c237cd8ef0ff22306c64… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Nicer code
by Yann Leboulanger 24 Aug '17

24 Aug '17

Yann Leboulanger pushed to branch master at gajim / gajim Commits: e57817ad by Yann Leboulanger at 2017-08-24T15:41:39+02:00 Nicer code - - - - - 2 changed files: - gajim/adhoc_commands.py - gajim/dataforms_widget.py Changes: ===================================== gajim/adhoc_commands.py ===================================== --- a/gajim/adhoc_commands.py +++ b/gajim/adhoc_commands.py @@ -59,6 +59,13 @@ class CommandWindow: self.jid = jid self.commandnode = commandnode self.data_form_widget = None + self.stage_finish_cb = None + self.stage_back_button_cb = None + self.stage_forward_button_cb = None + self.stage_execute_button_cb = None + self.stage_close_button_cb = None + self.stage_restart_button_cb = None + self.stage_window_delete_cb = None # retrieving widgets from xml self.xml = gtkgui_helpers.get_gtk_builder('adhoc_commands_window.ui') @@ -109,54 +116,48 @@ class CommandWindow: # These functions are set up by appropriate stageX methods. def stage_finish(self, *anything): - pass - - def stage_back_button_clicked(self, *anything): - assert False - - def stage_forward_button_clicked(self, *anything): - assert False - - def stage_execute_button_clicked(self, *anything): - assert False - - def stage_close_button_clicked(self, *anything): - assert False - - def stage_restart_button_clicked(self, *anything): - assert False - - def stage_adhoc_commands_window_delete_event(self, *anything): - assert False - - def do_nothing(self, *anything): - return False + if self.stage_finish_cb: + self.stage_finish_cb(*anything) # Widget callbacks... def on_back_button_clicked(self, *anything): - return self.stage_back_button_clicked(*anything) + if self.stage_back_button_cb: + return self.stage_back_button_cb(*anything) + return False def on_forward_button_clicked(self, *anything): - return self.stage_forward_button_clicked(*anything) + if self.stage_forward_button_cb: + return self.stage_forward_button_cb(*anything) + return False def on_execute_button_clicked(self, *anything): - return self.stage_execute_button_clicked(*anything) + if self.stage_execute_button_cb: + return self.stage_execute_button_cb(*anything) + return False def on_finish_button_clicked(self, *anything): - return self.stage_finish_button_clicked(*anything) + if self.stage_finish_button_cb: + return self.stage_finish_button_cb(*anything) + return False def on_close_button_clicked(self, *anything): - return self.stage_close_button_clicked(*anything) + if self.stage_close_button_cb: + return self.stage_close_button_cb(*anything) + return False def on_restart_button_clicked(self, *anything): - return self.stage_restart_button_clicked(*anything) + if self.stage_restart_button_cb: + return self.stage_restart_button_cb(*anything) + return False def on_adhoc_commands_window_destroy(self, *anything): # TODO: do all actions that are needed to remove this object from memory self.remove_pulsing() def on_adhoc_commands_window_delete_event(self, *anything): - return self.stage_adhoc_commands_window_delete_event(self.window) + if self.stage_window_delete_cb: + return self.stage_window_delete_cb(self.window) + return False def __del__(self): print('Object has been deleted.') @@ -188,10 +189,10 @@ class CommandWindow: self.xml.get_object('retrieving_commands_progressbar')) # setup the callbacks - self.stage_finish = self.stage1_finish - self.stage_close_button_clicked = self.stage1_close_button_clicked - self.stage_restart_button_clicked = self.stage1_restart_button_clicked - self.stage_adhoc_commands_window_delete_event = \ + self.stage_finish_cb = self.stage1_finish + self.stage_close_button_cb = self.stage1_close_button_clicked + self.stage_restart_button_cb = self.stage1_restart_button_clicked + self.stage_window_delete_cb = \ self.stage1_adhoc_commands_window_delete_event def stage1_finish(self): @@ -245,11 +246,11 @@ class CommandWindow: self.command_list_vbox.pack_start(radio, False, True, 0) self.command_list_vbox.show_all() - self.stage_finish = self.stage2_finish - self.stage_close_button_clicked = self.stage2_close_button_clicked - self.stage_restart_button_clicked = self.stage2_restart_button_clicked - self.stage_forward_button_clicked = self.stage2_forward_button_clicked - self.stage_adhoc_commands_window_delete_event = self.do_nothing + self.stage_finish_cb = self.stage2_finish + self.stage_close_button_cb = self.stage2_close_button_clicked + self.stage_restart_button_cb = self.stage2_restart_button_clicked + self.stage_forward_button_cb = self.stage2_forward_button_clicked + self.stage_window_delete_cb = None def stage2_finish(self): """ @@ -296,18 +297,14 @@ class CommandWindow: self.stage3_submit_form() - self.stage_finish = self.stage3_finish - self.stage_back_button_clicked = self.stage3_back_button_clicked - self.stage_forward_button_clicked = self.stage3_forward_button_clicked - self.stage_execute_button_clicked = self.stage3_execute_button_clicked - self.stage_finish_button_clicked = self.stage3_finish_button_clicked - self.stage_close_button_clicked = self.stage3_close_button_clicked - self.stage_restart_button_clicked = self.stage3_restart_button_clicked - self.stage_adhoc_commands_window_delete_event = \ - self.stage3_close_button_clicked - - def stage3_finish(self): - pass + self.stage_finish_cb = None + self.stage_back_button_cb = self.stage3_back_button_clicked + self.stage_forward_button_cb = self.stage3_forward_button_clicked + self.stage_execute_button_cb = self.stage3_execute_button_clicked + self.stage_finish_button_cb = self.stage3_finish_button_clicked + self.stage_close_button_cb = self.stage3_close_button_clicked + self.stage_restart_button_cb = self.stage3_restart_button_clicked + self.stage_window_delete_cb = self.stage3_close_button_clicked def stage3_can_close(self, cb): if self.form_status == 'completed': @@ -447,8 +444,7 @@ class CommandWindow: self.execute_button.hide() self.finish_button.hide() self.close_button.show() - self.stage_adhoc_commands_window_delete_event = \ - self.stage3_close_button_clicked + self.stage_window_delete_cb = self.stage3_close_button_clicked note = command.getTag('note') if note: @@ -480,10 +476,10 @@ class CommandWindow: self.execute_button.set_sensitive(False) self.finish_button.set_sensitive(False) - self.stage_finish = self.do_nothing - self.stage_close_button_clicked = self.stage4_close_button_clicked - self.stage_restart_button_clicked = self.stage4_restart_button_clicked - self.stage_adhoc_commands_window_delete_event = self.do_nothing + self.stage_finish_cb = None + self.stage_close_button_cb = self.stage4_close_button_clicked + self.stage_restart_button_cb = self.stage4_restart_button_clicked + self.stage_window_delete_cb = None def stage4_close_button_clicked(self, widget): self.window.destroy() @@ -532,10 +528,10 @@ class CommandWindow: self.error_description_label.set_text(error) - self.stage_finish = self.do_nothing - self.stage_close_button_clicked = self.stage5_close_button_clicked - self.stage_restart_button_clicked = self.stage5_restart_button_clicked - self.stage_adhoc_commands_window_delete_event = self.do_nothing + self.stage_finish_cb = None + self.stage_close_button_cb = self.stage5_close_button_clicked + self.stage_restart_button_cb = self.stage5_restart_button_clicked + self.stage_window_delete_cb = None def stage5_close_button_clicked(self, widget): self.window.destroy() ===================================== gajim/dataforms_widget.py ===================================== --- a/gajim/dataforms_widget.py +++ b/gajim/dataforms_widget.py @@ -56,6 +56,7 @@ class DataFormWidget(Gtk.Alignment, object): self._data_form = None self.selectable = False + self.clean_cb = None self.xml = gtkgui_helpers.get_gtk_builder('data_form_window.ui', 'data_form_vbox') @@ -143,7 +144,8 @@ class DataFormWidget(Gtk.Alignment, object): rewritten by build_*_data_form, according to type of form which is actually displayed """ - pass + if self.clean_cb: + self.clean_cb() def build_single_data_form(self): '''Invoked when new single form is to be created.''' @@ -162,7 +164,7 @@ class DataFormWidget(Gtk.Alignment, object): self.data_form_types_notebook.page_num( self.single_form_scrolledwindow)) - self.clean_data_form = self.clean_single_data_form + self.clean_cb = self.clean_single_data_form def clean_single_data_form(self): """ @@ -170,7 +172,7 @@ class DataFormWidget(Gtk.Alignment, object): form from widget """ self.singleform.destroy() - self.clean_data_form = self.empty_method # we won't call it twice + self.clean_cb = None # we won't call it twice del self.singleform def build_multiple_data_form(self): @@ -216,7 +218,7 @@ class DataFormWidget(Gtk.Alignment, object): self.data_form_types_notebook.page_num( self.multiple_form_hbox)) - self.clean_data_form = self.clean_multiple_data_form + self.clean_cb = self.clean_multiple_data_form readwrite = self._data_form.type_ != 'result' if not readwrite: @@ -232,7 +234,7 @@ class DataFormWidget(Gtk.Alignment, object): Called as clean_data_form, read the docs of clean_data_form(). Remove form from widget """ - self.clean_data_form = self.empty_method # we won't call it twice + self.clean_cb = None # we won't call it twice del self.multiplemodel def refresh_multiple_buttons(self): View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/e57817addc344e7c06446e394abe5fd68f… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/e57817addc344e7c06446e394abe5fd68f… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 2 commits: fix some import warnings and errors pointed out by pylint
by Philipp Hörist 24 Aug '17

24 Aug '17

Philipp Hörist pushed to branch master at gajim / gajim Commits: 663176cf by André Apitzsch at 2017-08-24T01:18:01+02:00 fix some import warnings and errors pointed out by pylint - - - - - 94cbccec by Philipp Hörist at 2017-08-24T14:44:36+02:00 Merge branch 'imports' into 'master' fix some import warnings and errors pointed out by pylint See merge request !121 - - - - - 3 changed files: - gajim/common/app.py - gajim/common/commands.py - gajim/ipython_view.py Changes: ===================================== gajim/common/app.py ===================================== --- a/gajim/common/app.py +++ b/gajim/common/app.py @@ -30,13 +30,16 @@ import os import logging import locale -import gi import uuid from distutils.version import LooseVersion as V +import gi +import nbxmpp from gajim.common import config -import nbxmpp +from gajim.common import configpaths from gajim.common import ged as ged_module +from gajim.common.contacts import LegacyContactsAPI +from gajim.common.events import Events interface = None # The actual interface (the gtk one for the moment) thread_interface = None # Interface to run a thread and then a callback @@ -54,7 +57,6 @@ log = logging.getLogger('gajim') logger = None -from gajim.common import configpaths gajimpaths = configpaths.gajimpaths VCARD_PATH = gajimpaths['VCARD'] @@ -86,9 +88,6 @@ else: os_info = None # used to cache os information -from gajim.common.contacts import LegacyContactsAPI -from gajim.common.events import Events - gmail_domains = ['gmail.com', 'googlemail.com'] transport_type = {} # list the type of transport @@ -182,7 +181,6 @@ try: except ImportError: HAVE_GPG = False else: - import os import subprocess def test_gpg(binary='gpg'): if os.name == 'nt': ===================================== gajim/common/commands.py ===================================== --- a/gajim/common/commands.py +++ b/gajim/common/commands.py @@ -163,11 +163,11 @@ class ChangeStatusCommand(AdHocCommand): return False # finish the session def find_current_groupchats(account): - import message_control + from gajim import message_control rooms = [] for gc_control in app.interface.msg_win_mgr.get_controls( - message_control.TYPE_GC) + app.interface.minimized_controls[account].\ - values(): + message_control.TYPE_GC) + \ + app.interface.minimized_controls[account].values(): acct = gc_control.account # check if account is the good one if acct != account: ===================================== gajim/ipython_view.py ===================================== --- a/gajim/ipython_view.py +++ b/gajim/ipython_view.py @@ -52,7 +52,7 @@ import re import sys import os from gi.repository import Pango -from StringIO import StringIO +from io import StringIO try: import IPython View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/b9363fe9838c792e1e75f4ed038f11bf8… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/b9363fe9838c792e1e75f4ed038f11bf8… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Remove pylint.rc from gajim folder
by Philipp Hörist 23 Aug '17

23 Aug '17

Philipp Hörist pushed to branch master at gajim / gajim Commits: b9363fe9 by Philipp Hörist at 2017-08-24T00:13:18+02:00 Remove pylint.rc from gajim folder - - - - - 1 changed file: - − gajim/pylint.rc Changes: ===================================== gajim/pylint.rc deleted ===================================== --- a/gajim/pylint.rc +++ /dev/null @@ -1,310 +0,0 @@ -# lint Python modules using external checkers. -# -# This is the main checker controling the other ones and the reports -# generation. It is itself both a raw checker and an astng checker in order -# to: -# * handle message activation / deactivation at the module level -# * handle some basic but necessary stats'data (number of classes, methods...) -# -[MASTER] - -# Specify a configuration file. -#rcfile= - -# Python code to execute, usually for sys.path manipulation such as -# pygtk.require(). -#init-hook= - -# Profiled execution. -profile=no - -# Add <file or directory> to the black list. It should be a base name, not a -# path. You may set this option multiple times. -ignore=CVS - -# Pickle collected data for later comparisons. -persistent=yes - -# Set the cache size for astng objects. -cache-size=500 - -# List of plugins (as comma separated values of python modules names) to load, -# usually to register additional checkers. -load-plugins= - - -[MESSAGES CONTROL] - -# Enable only checker(s) with the given id(s). This option conflicts with the -# disable-checker option -#enable-checker= - -# Enable all checker(s) except those with the given id(s). This option -# conflicts with the enable-checker option -#disable-checker= - -# Enable all messages in the listed categories. -#enable-msg-cat= - -# Disable all messages in the listed categories. -#disable-msg-cat= - -# Enable the message(s) with the given id(s). -enable-msg=R0801 - -# Disable the message(s) with the given id(s). -disable-msg=W0312 -# disable-msg= - - -[REPORTS] - -# set the output format. Available formats are text, parseable, colorized, msvs -# (visual studio) and html -output-format=text - -# Include message's id in output -include-ids=yes - -# Put messages in a separate file for each module / package specified on the -# command line instead of printing them on stdout. Reports (if any) will be -# written in a file name "pylint_global.[txt|html]". -files-output=no - -# Tells wether to display a full report or only the messages -reports=yes - -# Python expression which should return a note less than 10 (10 is the highest -# note).You have access to the variables errors warning, statement which -# respectivly contain the number of errors / warnings messages and the total -# number of statements analyzed. This is used by the global evaluation report -# (R0004). -evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10) - -# Add a comment according to your evaluation note. This is used by the global -# evaluation report (R0004). -comment=no - -# Enable the report(s) with the given id(s). -#enable-report= - -# Disable the report(s) with the given id(s). -#disable-report= - - -# try to find bugs in the code using type inference -# -[TYPECHECK] - -# Tells wether missing members accessed in mixin class should be ignored. A -# mixin class is detected if its name ends with "mixin" (case insensitive). -ignore-mixin-members=yes - -# List of classes names for which member attributes should not be checked -# (useful for classes with attributes dynamicaly set). -ignored-classes=SQLObject - -# When zope mode is activated, consider the acquired-members option to ignore -# access to some undefined attributes. -zope=no - -# List of members which are usually get through zope's acquisition mecanism and -# so shouldn't trigger E0201 when accessed (need zope=yes to be considered). -acquired-members=REQUEST,acl_users,aq_parent - - -# checks for -# * unused variables / imports -# * undefined variables -# * redefinition of variable from builtins or from an outer scope -# * use of variable before assigment -# -[VARIABLES] - -# Tells wether we should check for unused import in __init__ files. -init-import=no - -# A regular expression matching names used for dummy variables (i.e. not used). -dummy-variables-rgx=_|dummy - -# List of additional names supposed to be defined in builtins. Remember that -# you should avoid to define new builtins when possible. -additional-builtins= - - -# checks for : -# * doc strings -# * modules / classes / functions / methods / arguments / variables name -# * number of arguments, local variables, branchs, returns and statements in -# functions, methods -# * required module attributes -# * dangerous default values as arguments -# * redefinition of function / method / class -# * uses of the global statement -# -[BASIC] - -# Required attributes for module, separated by a comma -required-attributes= - -# Regular expression which should only match functions or classes name which do -# not require a docstring -no-docstring-rgx=__.*__ - -# Regular expression which should only match correct module names -module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$ - -# Regular expression which should only match correct module level names -const-rgx=(([A-Z_][A-Z1-9_]*)|(__.*__))$ - -# Regular expression which should only match correct class names -class-rgx=[A-Z_][a-zA-Z0-9]+$ - -# Regular expression which should only match correct function names -function-rgx=[a-z_][a-z0-9_]{2,30}$ - -# Regular expression which should only match correct method names -method-rgx=[a-z_][a-z0-9_]{2,30}$ - -# Regular expression which should only match correct instance attribute names -attr-rgx=[a-z_][a-z0-9_]{2,30}$ - -# Regular expression which should only match correct argument names -argument-rgx=[a-z_][a-z0-9_]{2,30}$ - -# Regular expression which should only match correct variable names -variable-rgx=[a-z_][a-z0-9_]{2,30}$ - -# Regular expression which should only match correct list comprehension / -# generator expression variable names -inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$ - -# Good variable names which should always be accepted, separated by a comma -good-names=i,j,k,ex,Run,_ - -# Bad variable names which should always be refused, separated by a comma -bad-names=foo,bar,baz,toto,tutu,tata - -# List of builtins function names that should not be used, separated by a comma -bad-functions=map,filter,apply,input - - -# checks for sign of poor/misdesign: -# * number of methods, attributes, local variables... -# * size, complexity of functions, methods -# -[DESIGN] - -# Maximum number of arguments for function / method -max-args=5 - -# Maximum number of locals for function / method body -max-locals=15 - -# Maximum number of return / yield for function / method body -max-returns=6 - -# Maximum number of branch for function / method body -max-branchs=12 - -# Maximum number of statements in function / method body -max-statements=50 - -# Maximum number of parents for a class (see R0901). -max-parents=7 - -# Maximum number of attributes for a class (see R0902). -max-attributes=7 - -# Minimum number of public methods for a class (see R0903). -min-public-methods=2 - -# Maximum number of public methods for a class (see R0904). -max-public-methods=20 - - -# checks for -# * external modules dependencies -# * relative / wildcard imports -# * cyclic imports -# * uses of deprecated modules -# -[IMPORTS] - -# Deprecated modules which should not be used, separated by a comma -deprecated-modules=regsub,string,TERMIOS,Bastion,rexec - -# Create a graph of every (i.e. internal and external) dependencies in the -# given file (report R0402 must not be disabled) -import-graph= - -# Create a graph of external dependencies in the given file (report R0402 must -# not be disabled) -ext-import-graph= - -# Create a graph of internal dependencies in the given file (report R0402 must -# not be disabled) -int-import-graph= - - -# checks for : -# * methods without self as first argument -# * overridden methods signature -# * access only to existant members via self -# * attributes not defined in the __init__ method -# * supported interfaces implementation -# * unreachable code -# -[CLASSES] - -# List of interface methods to ignore, separated by a comma. This is used for -# instance to not check methods defines in Zope's Interface base class. -ignore-iface-methods=isImplementedBy,deferred,extends,names,namesAndDescriptions,queryDescriptionFor,getBases,getDescriptionFor,getDoc,getName,getTaggedValue,getTaggedValueTags,isEqualOrExtendedBy,setTaggedValue,isImplementedByInstancesOf,adaptWith,is_implemented_by - -# List of method names used to declare (i.e. assign) instance attributes. -defining-attr-methods=__init__,__new__,setUp - - -# checks for similarities and duplicated code. This computation may be -# memory / CPU intensive, so you should disable it if you experiments some -# problems. -# -[SIMILARITIES] - -# Minimum lines number of a similarity. -min-similarity-lines=4 - -# Ignore comments when computing similarities. -ignore-comments=yes - -# Ignore docstrings when computing similarities. -ignore-docstrings=yes - - -# checks for: -# * warning notes in the code like FIXME, XXX -# * PEP 263: source code with non ascii character but no encoding declaration -# -[MISCELLANEOUS] - -# List of note tags to take in consideration, separated by a comma. -notes=FIXME,XXX,TODO - - -# checks for : -# * unauthorized constructions -# * strict indentation -# * line length -# * use of <> instead of != -# -[FORMAT] - -# Maximum number of characters on a single line. -max-line-length=80 - -# Maximum number of lines in a module -max-module-lines=1000 - -# String used as indentation unit. This is usually " " (4 spaces) or "\t" (1 -# tab). -indent-string=' ' View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/b9363fe9838c792e1e75f4ed038f11bf88… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/b9363fe9838c792e1e75f4ed038f11bf88… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] remove unused import / variable
by Yann Leboulanger 23 Aug '17

23 Aug '17

Yann Leboulanger pushed to branch master at gajim / gajim Commits: 2b065c0e by Yann Leboulanger at 2017-08-24T00:07:14+02:00 remove unused import / variable - - - - - 1 changed file: - gajim/gajim.py Changes: ===================================== gajim/gajim.py ===================================== --- a/gajim/gajim.py +++ b/gajim/gajim.py @@ -39,7 +39,6 @@ import sys import os -import logging import signal import locale import gi @@ -161,7 +160,7 @@ class GajimApplication(Gtk.Application): sys.path.append('.') APP = 'gajim' DIR = '../po' - lang, enc = locale.getdefaultlocale() + lang = locale.getdefaultlocale()[0] os.environ['LANG'] = lang gettext.bindtextdomain(APP, DIR) gettext.textdomain(APP) @@ -228,9 +227,6 @@ class GajimApplication(Gtk.Application): signal.signal(signal.SIGINT, sigint_cb) signal.signal(signal.SIGTERM, sigint_cb) - print("Encodings: d:{}, fs:{}, p:{}".format(sys.getdefaultencoding(), - sys.getfilesystemencoding(), locale.getpreferredencoding())) - # Set Application Menu app.app = self path = os.path.join(configpaths.get('GUI'), 'application_menu.ui') @@ -409,5 +405,5 @@ class GajimApplication(Gtk.Application): if __name__ == '__main__': - app = GajimApplication() - app.run(sys.argv) + appli = GajimApplication() + appli.run(sys.argv) View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/2b065c0e58fec0ce691c9501fcb33f94da… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/2b065c0e58fec0ce691c9501fcb33f94da… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Zeroconf: Call method with correct arguments
by Philipp Hörist 23 Aug '17

23 Aug '17

Philipp Hörist pushed to branch master at gajim / gajim Commits: 1a352c0e by Philipp Hörist at 2017-08-23T23:34:16+02:00 Zeroconf: Call method with correct arguments - - - - - 1 changed file: - gajim/common/zeroconf/zeroconf_bonjour.py Changes: ===================================== gajim/common/zeroconf/zeroconf_bonjour.py ===================================== --- a/gajim/common/zeroconf/zeroconf_bonjour.py +++ b/gajim/common/zeroconf/zeroconf_bonjour.py @@ -93,7 +93,7 @@ class Zeroconf: def new_domain_callback(self, interface, protocol, domain, flags): if domain != "local": - self.browse_domain(interface, protocol, domain) + self.browse_domain(domain) # takes a TXTRecord instance def txt_array_to_dict(self, txt): View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/1a352c0e4723acd345b20a24334bd3fa76… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/1a352c0e4723acd345b20a24334bd3fa76… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Resolver: Raise correct error
by Philipp Hörist 23 Aug '17

23 Aug '17

Philipp Hörist pushed to branch master at gajim / gajim Commits: 28045e9d by Philipp Hörist at 2017-08-23T23:29:38+02:00 Resolver: Raise correct error - - - - - 1 changed file: - gajim/common/resolver.py Changes: ===================================== gajim/common/resolver.py ===================================== --- a/gajim/common/resolver.py +++ b/gajim/common/resolver.py @@ -96,7 +96,7 @@ class GioResolver(CommonResolver): if type_ == 'txt': # TXT record resolution isn't used anywhere at the moment so # implementing it here isn't urgent - raise NotImplemented("Gio resolver does not currently implement TXT records") + raise NotImplementedError("Gio resolver does not currently implement TXT records") else: callback = functools.partial(self._on_ready_srv, host) type_ = Gio.ResolverRecordType.SRV View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/28045e9d36b2061a7949d77bda98cc8120… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/28045e9d36b2061a7949d77bda98cc8120… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] Add keyword arg to prototype
by Philipp Hörist 23 Aug '17

23 Aug '17

Philipp Hörist pushed to branch master at gajim / gajim Commits: 00d091dd by Philipp Hörist at 2017-08-23T23:26:26+02:00 Add keyword arg to prototype this was probably forgotten - - - - - 1 changed file: - gajim/message_control.py Changes: ===================================== gajim/message_control.py ===================================== --- a/gajim/message_control.py +++ b/gajim/message_control.py @@ -169,7 +169,7 @@ class MessageControl(object): # None clears any current label. return None - def prepare_context_menu(self): + def prepare_context_menu(self, hide_buttonbar_items=False): """ Derived classes SHOULD implement this """ View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/00d091dd548436900ec04354f69a1a2104… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/commit/00d091dd548436900ec04354f69a1a2104… You're receiving this email because of your account on dev.gajim.org.

1 0

[Git][gajim/gajim][master] 8 commits: Remove unused code
by Philipp Hörist 23 Aug '17

23 Aug '17

Philipp Hörist pushed to branch master at gajim / gajim Commits: 00e72b1d by Philipp Hörist at 2017-08-23T18:34:17+02:00 Remove unused code Whatever this was, its not used since 4 years see 8f71d9f21955d30cd47fabdf0b95869603887cb9 - - - - - 44a28770 by Philipp Hörist at 2017-08-23T18:46:43+02:00 Fix method call Regression from making gajim a module - - - - - b72c3c10 by Philipp Hörist at 2017-08-23T18:47:39+02:00 Remove unused event handler There exists no 'default_status_eventbox' anymore in Gajim - - - - - 80e5c27f by Philipp Hörist at 2017-08-23T18:57:38+02:00 Use correct inherit pattern - - - - - 6cacc559 by Philipp Hörist at 2017-08-23T19:50:29+02:00 Dont use internal members in Dialogs vbox and action_area are internal members of Gtk.Dialog. We should use the methods provided by the API to get these Objects. - - - - - 4a9ba28a by Philipp Hörist at 2017-08-23T20:01:48+02:00 Fix typo - - - - - 26dda615 by Philipp Hörist at 2017-08-23T20:15:32+02:00 Fix undefined-variable - - - - - 95f4703d by Philipp Hörist at 2017-08-23T20:24:55+02:00 Fix unexpected-keyword-arg - - - - - 6 changed files: - gajim/common/connection_handlers.py - gajim/common/dataforms.py - gajim/config.py - gajim/conversation_textview.py - gajim/dialogs.py - gajim/roster_window.py Changes: ===================================== gajim/common/connection_handlers.py ===================================== --- a/gajim/common/connection_handlers.py +++ b/gajim/common/connection_handlers.py @@ -1788,7 +1788,7 @@ ConnectionHandlersBase, ConnectionJingle, ConnectionIBBytestream): return if result.getType() == 'result': - data = msg.getTags('data', namespace=nbxmpp.NS_BOB) + data = result.getTags('data', namespace=nbxmpp.NS_BOB) if data.getAttr('cid') == cid: for func in self.awaiting_cids[cid]: cb = func[0] ===================================== gajim/common/dataforms.py ===================================== --- a/gajim/common/dataforms.py +++ b/gajim/common/dataforms.py @@ -551,7 +551,7 @@ class DataRecord(ExtendedNode): fdel(self) for field in fields: if not isinstance(field, DataField): - ExtendField(extend=field) + ExtendField(field) self.addChild(node=field) def fdel(self): ===================================== gajim/config.py ===================================== --- a/gajim/config.py +++ b/gajim/config.py @@ -1049,12 +1049,6 @@ class PreferencesWindow: model[iter_][3]) app.config.set_per('defaultstatusmsg', status, 'message', message) - def on_default_status_expander_activate(self, expander): - eventbox = self.xml.get_object('default_status_eventbox') - vbox = self.xml.get_object('status_vbox') - vbox.set_child_packing(eventbox, not expander.get_expanded(), True, 0, - Gtk.PACK_START) - def save_status_messages(self, model): for msg in app.config.get_per('statusmsg'): app.config.del_per('statusmsg', msg) @@ -2155,8 +2149,8 @@ class AccountsWindow: app.interface.roster.setup_and_draw_roster() self.init_accounts() self.select_account(new_name) - gajim.app.remove_account_actions(old_name) - gajim.app.add_account_actions(new_name) + app.app.remove_account_actions(old_name) + app.app.add_account_actions(new_name) gui_menu_builder.build_accounts_menu() title = _('Rename Account') ===================================== gajim/conversation_textview.py ===================================== --- a/gajim/conversation_textview.py +++ b/gajim/conversation_textview.py @@ -220,8 +220,6 @@ class ConversationTextview(GObject.GObject): id_ = self.tv.connect('button_press_event', self.on_textview_button_press_event) self.handlers[id_] = self.tv - id_ = self.tv.connect('draw', self.on_textview_draw) - self.handlers[id_] = self.tv self.account = account self.cursor_changed = False @@ -520,34 +518,6 @@ class ConversationTextview(GObject.GObject): # appeared) GLib.idle_add(self.scroll_to_end_iter) - def on_textview_draw(self, widget, ctx): - return - #TODO - expalloc = event.area - exp_x0 = expalloc.x - exp_y0 = expalloc.y - exp_x1 = exp_x0 + expalloc.width - exp_y1 = exp_y0 + expalloc.height - - try: - tryfirst = [self.image_cache[(exp_x0, exp_y0)]] - except KeyError: - tryfirst = [] - - for image in tryfirst + self.images: - imgalloc = image.allocation - img_x0 = imgalloc.x - img_y0 = imgalloc.y - img_x1 = img_x0 + imgalloc.width - img_y1 = img_y0 + imgalloc.height - - if img_x0 <= exp_x0 and img_y0 <= exp_y0 and \ - exp_x1 <= img_x1 and exp_y1 <= img_y1: - self.image_cache[(img_x0, img_y0)] = image - widget.propagate_expose(image, event) - return True - return False - def clear(self, tv = None): """ Clear text in the textview ===================================== gajim/dialogs.py ===================================== --- a/gajim/dialogs.py +++ b/gajim/dialogs.py @@ -565,18 +565,17 @@ class TimeoutDialog: Class designed to be derivated to create timeout'd dialogs (dialogs that closes automatically after a timeout) """ - def __init__(self, timeout, on_timeout): + def __init__(self, timeout): self.countdown_left = timeout self.countdown_enabled = True self.title_text = '' - self.on_timeout = on_timeout def run_timeout(self): if self.countdown_left > 0: self.countdown() GLib.timeout_add_seconds(1, self.countdown) - def on_timeout(): + def on_timeout(self): """ To be implemented in derivated classes """ @@ -598,7 +597,7 @@ class TimeoutDialog: class ChangeStatusMessageDialog(TimeoutDialog): def __init__(self, on_response, show=None, show_pep=True): countdown_time = app.config.get('change_status_window_timeout') - TimeoutDialog.__init__(self, countdown_time, self.on_timeout) + TimeoutDialog.__init__(self, countdown_time) self.show = show self.pep_dict = {} self.show_pep = show_pep @@ -1390,7 +1389,7 @@ class Dialog(Gtk.Dialog): self.user_response_ok = on_response_ok self.user_response_cancel = on_response_cancel self.set_border_width(6) - self.vbox.set_spacing(12) + self.get_content_area().set_spacing(12) self.set_resizable(False) for stock, response in buttons: @@ -1423,7 +1422,7 @@ class Dialog(Gtk.Dialog): self.destroy() def get_button(self, index): - buttons = self.action_area.get_children() + buttons = self.get_action_area().get_children() return index < len(buttons) and buttons[index] or None @@ -1674,20 +1673,21 @@ class YesNoDialog(HigDialog): sectext, on_response_yes=self.on_response_yes, on_response_no=self.on_response_no) + vbox = self.get_content_area() if checktext: self.checkbutton = Gtk.CheckButton.new_with_mnemonic(checktext) - self.vbox.pack_start(self.checkbutton, False, True, 0) + vbox.pack_start(self.checkbutton, False, True, 0) else: self.checkbutton = None if text_label: label = Gtk.Label(label=text_label) - self.vbox.pack_start(label, False, True, 0) + vbox.pack_start(label, False, True, 0) buff = Gtk.TextBuffer() self.textview = Gtk.TextView.new_with_buffer(buff) frame = Gtk.Frame() frame.set_shadow_type(Gtk.ShadowType.IN) frame.add(self.textview) - self.vbox.pack_start(frame, False, True, 0) + vbox.pack_start(frame, False, True, 0) else: self.textview = None self.set_modal(False) @@ -1765,11 +1765,11 @@ class ConfirmationDialogCheck(ConfirmationDialog): self.set_default_response(Gtk.ResponseType.OK) - ok_button = self.action_area.get_children()[0] # right to left + ok_button = self.get_action_area().get_children()[0] # right to left ok_button.grab_focus() self.checkbutton = Gtk.CheckButton.new_with_mnemonic(checktext) - self.vbox.pack_start(self.checkbutton, False, True, 0) + self.get_content_area().pack_start(self.checkbutton, False, True, 0) self.set_modal(is_modal) self.popup() @@ -1820,21 +1820,22 @@ class ConfirmationDialogDoubleCheck(ConfirmationDialog): self.set_default_response(Gtk.ResponseType.OK) - ok_button = self.action_area.get_children()[0] # right to left + ok_button = self.get_action_area().get_children()[0] # right to left ok_button.grab_focus() + vbox = self.get_content_area() if checktext1: self.checkbutton1 = Gtk.CheckButton.new_with_mnemonic(checktext1) if tooltip1: self.checkbutton1.set_tooltip_text(tooltip1) - self.vbox.pack_start(self.checkbutton1, False, True, 0) + vbox.pack_start(self.checkbutton1, False, True, 0) else: self.checkbutton1 = None if checktext2: self.checkbutton2 = Gtk.CheckButton.new_with_mnemonic(checktext2) if tooltip2: self.checkbutton2.set_tooltip_text(tooltip2) - self.vbox.pack_start(self.checkbutton2, False, True, 0) + vbox.pack_start(self.checkbutton2, False, True, 0) else: self.checkbutton2 = None @@ -1889,7 +1890,7 @@ class PlainConnectionDialog(ConfirmationDialogDoubleCheck): ConfirmationDialogDoubleCheck.__init__(self, pritext, sectext, checktext1, checktext2, tooltip1=tooltip1, on_response_ok=on_ok, on_response_cancel=on_cancel, is_modal=False) - self.ok_button = self.action_area.get_children()[0] # right to left + self.ok_button = self.get_action_area().get_children()[0] # right to left self.ok_button.set_sensitive(False) self.checkbutton1.connect('clicked', self.on_checkbutton_clicked) self.set_title(_('Insecure connection')) @@ -1917,15 +1918,16 @@ class ConfirmationDialogDoubleRadio(ConfirmationDialog): self.set_default_response(Gtk.ResponseType.OK) - ok_button = self.action_area.get_children()[0] # right to left + ok_button = self.get_action_area().get_children()[0] # right to left ok_button.grab_focus() + vbox = self.get_content_area() self.radiobutton1 = Gtk.RadioButton(label=radiotext1) - self.vbox.pack_start(self.radiobutton1, False, True, 0) + vbox.pack_start(self.radiobutton1, False, True, 0) self.radiobutton2 = Gtk.RadioButton(group=self.radiobutton1, label=radiotext2) - self.vbox.pack_start(self.radiobutton2, False, True, 0) + vbox.pack_start(self.radiobutton2, False, True, 0) self.set_modal(is_modal) self.popup() @@ -4770,8 +4772,9 @@ class AvatarChooserDialog(ImageChooserDialog): if on_response_clear: button.connect('clicked', self.on_clear) button.show_all() - self.action_area.pack_start(button, True, True, 0) - self.action_area.reorder_child(button, 0) + action_area = self.get_action_area() + action_area.pack_start(button, True, True, 0) + action_area.reorder_child(button, 0) def on_clear(self, widget): if isinstance(self.response_clear, tuple): @@ -5038,7 +5041,7 @@ class DataFormWindow(Dialog): self.dataform_widget.set_sensitive(True) self.dataform_widget.data_form = self.dataform self.dataform_widget.show_all() - self.vbox.pack_start(self.dataform_widget, True, True, 0) + self.get_content_area().pack_start(self.dataform_widget, True, True, 0) def on_ok(self): form = self.dataform_widget.data_form @@ -5051,7 +5054,7 @@ class DataFormWindow(Dialog): class ResourceConflictDialog(TimeoutDialog, InputDialog): def __init__(self, title, text, resource, ok_handler): - TimeoutDialog.__init__(self, 15, self.on_timeout) + TimeoutDialog.__init__(self, 15) InputDialog.__init__(self, title, text, input_str=resource, is_modal=False, ok_handler=ok_handler) self.title_text = title ===================================== gajim/roster_window.py ===================================== --- a/gajim/roster_window.py +++ b/gajim/roster_window.py @@ -3698,7 +3698,7 @@ class RosterWindow: _('You are participating in one or more group chats'), _('Changing your status to invisible will result in ' 'disconnection from those group chats. Are you sure you ' - 'want to go invisible?'), on_reponse_ok=on_ok, + 'want to go invisible?'), on_response_ok=on_ok, on_response_cancel=on_cancel) return View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/1750217e7fa7a4f1424b7de2437617c47… --- View it on GitLab: https://dev.gajim.org/gajim/gajim/compare/1750217e7fa7a4f1424b7de2437617c47… You're receiving this email because of your account on dev.gajim.org.

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits August 2017