Commits January 2016

commits@gajim.org

1 participants
71 discussions

gajim-plugins: Refactor encryption en/disabled code
by Gajim Plugins 10 Jan '16

10 Jan '16

changeset 47bd067b9ae2 in /home/hg/repos/gajim-plugins author: Bahtiar `kalkin-` Gadimov <bahtiar(a)gadimov.de> branches: details:gajim-plugins?cmd=changeset;node=47bd067b9ae2 description: Refactor encryption en/disabled code - All the logic is in the Checkbox - Use unicode LOCK & OPEN_LOCK chars diffstat: omemo/ui.py | 14 ++++++-------- 1 files changed, 6 insertions(+), 8 deletions(-) diffs (34 lines): diff -r a90727b49800 -r 47bd067b9ae2 omemo/ui.py --- a/omemo/ui.py Thu Jan 07 23:32:07 2016 +0100 +++ b/omemo/ui.py Thu Jan 07 23:39:38 2016 +0100 @@ -75,9 +75,14 @@ if enabled: self.plugin.omemo_enable_for(self.contact) self.chat_control._show_lock_image(True, 'OMEMO', True, True, False) + self.chat_control.print_conversation_line( + u'\U0001F512 OMEMO encryption enabled ', 'status', '', None) else: self.plugin.omemo_disable_for(self.contact) - self.chat_control._show_lock_image(False, 'OMEMO', False, True, False) + self.chat_control._show_lock_image(False, 'OMEMO', False, True, + False) + self.chat_control.print_conversation_line( + u'\U0001F513 OMEMO encryption disabled', 'status', '', None) def _add_widget(widget, chat_control): @@ -124,14 +129,7 @@ def activate_omemo(self): if not self.checkbox.get_active(): - self.chat_control.print_conversation_line( - 'OMEMO encryption activated', 'status', '', None) - self.chat_control._show_lock_image(True, 'OMEMO', True, True, True) self.checkbox.set_active(True) - elif self.last_msg_plain: - self.chat_control.print_conversation_line( - 'OMEMO encryption activated', 'status', '', None) - self.last_msg_plain = False def plain_warning(self): if not self.last_msg_plain:

1 0

gajim-plugins: Make logging less verbose
by Gajim Plugins 10 Jan '16

10 Jan '16

changeset 6d12283cb71f in /home/hg/repos/gajim-plugins author: Bahtiar `kalkin-` Gadimov <bahtiar(a)gadimov.de> branches: details:gajim-plugins?cmd=changeset;node=6d12283cb71f description: Make logging less verbose If you are working on `gajim-omemo` you can just use `./launch.sh -l plugin_system.omemo=INFO` to get only the important bits. diffstat: omemo/__init__.py | 17 +++++++++-------- omemo/state.py | 10 ++++++---- 2 files changed, 15 insertions(+), 12 deletions(-) diffs (86 lines): diff -r 7f9ea09339e6 -r 6d12283cb71f omemo/__init__.py --- a/omemo/__init__.py Fri Jan 08 02:25:13 2016 +0100 +++ b/omemo/__init__.py Sun Jan 10 12:52:54 2016 +0100 @@ -172,7 +172,7 @@ my_jid = gajim.get_jid_from_account(account_name) if contact_jid == my_jid: - log.debug(state.name + ' ⇒ Received own device_list:' + str( + log.info(state.name + ' ⇒ Received own device_list:' + str( devices_list)) state.add_own_devices(devices_list) @@ -185,8 +185,8 @@ devices_list.append(state.own_device_id) self.publish_own_devices_list(state) else: - log.debug(account_name + ' ⇒ Received device_list for ' + - contact_jid + ':' + str(devices_list)) + log.info(account_name + ' ⇒ Received device_list for ' + + contact_jid + ':' + str(devices_list)) state.add_devices(contact_jid, devices_list) if account_name in self.ui_list and contact_jid not in self.ui_list[ account_name]: @@ -226,7 +226,7 @@ self.ui_list[account_name][contact_jid] = Ui(self, chat_control, omemo_enabled) else: - log.debug(account_name + " ⇒ No OMEMO dev_keys for " + contact_jid) + log.warn(account_name + " ⇒ No OMEMO dev_keys for " + contact_jid) def are_keys_missing(self, contact): """ Used by the ui to set the state of the PreKeyButton. """ @@ -236,8 +236,9 @@ result = 0 result += len(state.devices_without_sessions(str(contact.jid))) result += len(state.own_devices_without_sessions(my_jid)) - log.debug(account + " ⇒ Missing keys for " + contact.jid + ": " + str( - result)) + if result > 0: + log.warn(account + " ⇒ Missing keys for " + contact.jid + ": " + + str(result)) return result @log_calls('OmemoPlugin') @@ -389,12 +390,12 @@ if successful(stanza): log.debug(account + ' → Publishing bundle was successful') if not state.own_device_id_published(): - log.debug(account + ' → Device list needs updating') + log.warn(account + ' → Device list needs updating') self.publish_own_devices_list(state) else: log.debug(account + ' → Device list up to date') else: - log.debug(account + ' → Publishing bundle was NOT successful') + log.error(account + ' → Publishing bundle was NOT successful') @log_calls('OmemoPlugin') def clear_device_list(self, contact): diff -r 7f9ea09339e6 -r 6d12283cb71f omemo/state.py --- a/omemo/state.py Fri Jan 08 02:25:13 2016 +0100 +++ b/omemo/state.py Sun Jan 10 12:52:54 2016 +0100 @@ -219,8 +219,9 @@ missing_devices = [dev for dev in known_devices if not self.store.containsSession(jid, dev)] - log.debug(self.name + ' → Missing device sessions: ' + str( - missing_devices)) + if missing_devices: + log.debug(self.name + ' → Missing device sessions: ' + str( + missing_devices)) return missing_devices def own_devices_without_sessions(self, own_jid): @@ -240,8 +241,9 @@ missing_devices = [dev for dev in known_devices if not self.store.containsSession(own_jid, dev)] - log.debug(self.name + ' → Missing device sessions: ' + str( - missing_devices)) + if missing_devices: + log.debug(self.name + ' → Missing device sessions: ' + str( + missing_devices)) return missing_devices def get_session_cipher(self, jid, device_id):

1 0

gajim-plugins: Fix flake8 max-line-length
by Gajim Plugins 10 Jan '16

10 Jan '16

changeset a90727b49800 in /home/hg/repos/gajim-plugins author: Bahtiar `kalkin-` Gadimov <bahtiar(a)gadimov.de> branches: details:gajim-plugins?cmd=changeset;node=a90727b49800 description: Fix flake8 max-line-length diffstat: omemo/setup.cfg | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diffs (6 lines): diff -r 99f455f0dd0f -r a90727b49800 omemo/setup.cfg --- a/omemo/setup.cfg Thu Jan 07 21:36:26 2016 +0100 +++ b/omemo/setup.cfg Thu Jan 07 23:32:07 2016 +0100 @@ -1,1 +1,2 @@ +[flake8] max-line-length=80

1 0

gajim-plugins: Add archlinux PKGBUILD
by Gajim Plugins 10 Jan '16

10 Jan '16

changeset 7f9ea09339e6 in /home/hg/repos/gajim-plugins author: cippaciong <lacapannadelloziotom(a)gmail.com> branches: details:gajim-plugins?cmd=changeset;node=7f9ea09339e6 description: Add archlinux PKGBUILD diffstat: omemo/pkgs/PKGBUILD | 23 +++++++++++++++++++++++ 1 files changed, 23 insertions(+), 0 deletions(-) diffs (27 lines): diff -r 617d132b2a2e -r 7f9ea09339e6 omemo/pkgs/PKGBUILD --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/omemo/pkgs/PKGBUILD Fri Jan 08 02:25:13 2016 +0100 @@ -0,0 +1,23 @@ +# Maintainer: Tommaso Sardelli <lacapannadelloziotom AT gmail DOT com> + +pkgname=gajim-plugin-omemo +_pkgname=gajim-omemo +pkgver=0.2 +pkgrel=1 +pkgdesc="Gajim plugin for OMEMO Multi-End Message and Object Encryption." +arch=(any) +url="https://github.com/kalkin/${_pkgname}" +license=('GPL') +depends=("gajim" "python2-axolotl-git") +provides=('gajim-plugin-omemo') +conflicts=('gajim-plugin-omemo-git') +source=("https://github.com/kalkin/${_pkgname}/archive/${pkgver}.tar.gz") +sha512sums=('c7a5f78011c3c2fcce03871620a5980fb3b8a2450e46d8e640e19f2bd0c058a89710ccddd051b135098509c46ef2cb2300256de9550df188149a148778f1a0c2') + +package() { + cd $srcdir/gajim-omemo-${pkgver} + install -d ${pkgdir}/usr/share/gajim/plugins/omemo + cp -r * ${pkgdir}/usr/share/gajim/plugins/omemo/ +} + +# vim:set ts=2 sw=2 et:

1 0

gajim-plugins: Add Hacking section to README
by Gajim Plugins 10 Jan '16

10 Jan '16

changeset 617d132b2a2e in /home/hg/repos/gajim-plugins author: Bahtiar `kalkin-` Gadimov <bahtiar(a)gadimov.de> branches: details:gajim-plugins?cmd=changeset;node=617d132b2a2e description: Add Hacking section to README diffstat: omemo/README.md | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diffs (19 lines): diff -r 7a65f354e2d4 -r 617d132b2a2e omemo/README.md --- a/omemo/README.md Fri Jan 08 00:03:39 2016 +0100 +++ b/omemo/README.md Fri Jan 08 00:04:01 2016 +0100 @@ -35,6 +35,15 @@ To see OMEMO related debug output start Gajim with the parameter `-l gajim.plugin_system.omemo=DEBUG`. +## Hacking +This repository contains the current development version. If you want to +contribute clone the git repository into your Gajim's plugin directory. +```shell +mkdir ~/.local/share/gajim/plugins -p +cd ~/.local/share/gajim/plugins +git clone https://github.com/kalkin/gajim-omemo +``` + ## Support this project I develop this project in my free time. Your donation allows me to spend more time working on it and on free software generally.

1 0

gajim-plugins: Simplified UI handling
by Gajim Plugins 10 Jan '16

10 Jan '16

changeset ad2208598bfe in /home/hg/repos/gajim-plugins author: Bahtiar `kalkin-` Gadimov <bahtiar(a)gadimov.de> branches: details:gajim-plugins?cmd=changeset;node=ad2208598bfe description: Simplified UI handling - Remove UI.available logic. UI object is now only created if needed - Remove UI.last_plain_msg logic. If a plain message is received we just print a warning as status msg - Simplified OmemoState.device_ids_for - Should fix #16 & #18 diffstat: omemo/__init__.py | 64 +++++++++++++++++++++++++----------------------------- omemo/state.py | 12 ---------- omemo/ui.py | 21 +++-------------- 3 files changed, 34 insertions(+), 63 deletions(-) diffs (189 lines): diff -r 47bd067b9ae2 -r ad2208598bfe omemo/__init__.py --- a/omemo/__init__.py Thu Jan 07 23:39:38 2016 +0100 +++ b/omemo/__init__.py Thu Jan 07 23:42:45 2016 +0100 @@ -166,10 +166,10 @@ devices_list = unpack_device_list_update(event) if len(devices_list) == 0: return False - account = event.conn.name + account_name = event.conn.name contact_jid = gajim.get_jid_without_resource(event.fjid) - state = self.get_omemo_state(account) - my_jid = gajim.get_jid_from_account(account) + state = self.get_omemo_state(account_name) + my_jid = gajim.get_jid_from_account(account_name) if contact_jid == my_jid: log.debug(state.name + ' ⇒ Received own device_list:' + str( @@ -185,14 +185,19 @@ devices_list.append(state.own_device_id) self.publish_own_devices_list(state) else: - log.debug(account + ' ⇒ Received device_list for ' + contact_jid + - ':' + str(devices_list)) + log.debug(account_name + ' ⇒ Received device_list for ' + + contact_jid + ':' + str(devices_list)) state.add_devices(contact_jid, devices_list) - if account in self.ui_list and contact_jid in self.ui_list[ - account]: - self.ui_list[account][contact_jid].toggle_omemo(True) + if account_name in self.ui_list and contact_jid not in self.ui_list[ + account_name]: - self.update_prekeys(account, contact_jid) + chat_control = gajim.interface.msg_win_mgr.get_control( + contact_jid, account_name) + + if chat_control is not None: + self.connect_ui(chat_control) + + self.update_prekeys(account_name, contact_jid) return True @@ -210,13 +215,18 @@ @log_calls('OmemoPlugin') def connect_ui(self, chat_control): - account = chat_control.contact.account.name - jid = chat_control.contact.jid - if account not in self.ui_list: - self.ui_list[account] = {} - state = self.get_omemo_state(account) - omemo_enabled = jid in state.omemo_enabled - self.ui_list[account][jid] = Ui(self, chat_control, omemo_enabled) + account_name = chat_control.contact.account.name + contact_jid = chat_control.contact.jid + if account_name not in self.ui_list: + self.ui_list[account_name] = {} + state = self.get_omemo_state(account_name) + if contact_jid in state.device_ids: + log.debug(account_name + " ⇒ Adding OMEMO ui for " + contact_jid) + omemo_enabled = contact_jid in state.omemo_enabled + self.ui_list[account_name][contact_jid] = Ui(self, chat_control, + omemo_enabled) + else: + log.debug(account_name + " ⇒ No OMEMO dev_keys for " + contact_jid) def are_keys_missing(self, contact): """ Used by the ui to set the state of the PreKeyButton. """ @@ -226,6 +236,8 @@ result = 0 result += len(state.devices_without_sessions(str(contact.jid))) result += len(state.own_devices_without_sessions(my_jid)) + log.debug(account + " ⇒ Missing keys for " + contact.jid + ": " + str( + result)) return result @log_calls('OmemoPlugin') @@ -269,8 +281,8 @@ device_id : int The device_id for which we are missing an axolotl session """ - log.debug(state.name + '→ Fetch bundle device ' + str(device_id) + '#' + - jid) + log.debug(state.name + '→ Fetch bundle device ' + str(device_id) + '#' + + jid) iq = BundleInformationQuery(jid, device_id) iq_id = str(iq.getAttr('id')) iq_ids_to_callbacks[iq_id] = \ @@ -437,22 +449,6 @@ state = self.get_omemo_state(account) state.omemo_enabled.remove(contact.jid) - @log_calls('OmemoPlugin') - def has_omemo(self, contact): - """ Used by the ui to find out if omemo controls should be displayed for - the given contact. - - Returns - ------- - bool - True if there are known device_ids/clients supporting OMEMO - """ - account = contact.account.name - state = self.get_omemo_state(account) - if state.device_ids_for(contact): - return True - return False - @log_calls('OmemoPlugin') def anydup(thelist): diff -r 47bd067b9ae2 -r ad2208598bfe omemo/state.py --- a/omemo/state.py Thu Jan 07 23:39:38 2016 +0100 +++ b/omemo/state.py Thu Jan 07 23:42:45 2016 +0100 @@ -95,18 +95,6 @@ def own_device_id_published(self): return self.own_device_id in self.own_devices - def device_ids_for(self, contact): - account = contact.account.name - log.debug(account + ' ⇒ Searching device_ids for contact ' + - contact.jid) - if contact.jid not in self.device_ids: - log.debug(contact.jid + '¬∈ devices_ids[' + account + ']') - return None - - log.debug(account + ' ⇒ found device_ids ' + str(self.device_ids[ - contact.jid])) - return self.device_ids[contact.jid] - @property def bundle(self): prekeys = [ diff -r 47bd067b9ae2 -r ad2208598bfe omemo/ui.py --- a/omemo/ui.py Thu Jan 07 23:39:38 2016 +0100 +++ b/omemo/ui.py Thu Jan 07 23:42:45 2016 +0100 @@ -91,21 +91,17 @@ send_button_pos = actions_hbox.child_get_property(send_button, 'position') actions_hbox.add_with_properties(widget, 'position', send_button_pos - 2, 'expand', False) + widget.show_all() class Ui(object): - last_msg_plain = True - def __init__(self, plugin, chat_control, enabled): contact = chat_control.contact self.prekey_button = PreKeyButton(plugin, contact) self.checkbox = Checkbox(plugin, chat_control) self.clear_button = ClearDevicesButton(plugin, contact) - available = plugin.has_omemo(contact) - self.toggle_omemo(available) - self.checkbox.set_active(enabled) self.chat_control = chat_control @@ -113,14 +109,6 @@ _add_widget(self.checkbox, chat_control) _add_widget(self.clear_button, chat_control) - def toggle_omemo(self, available): - if available: - self.checkbox.set_no_show_all(False) - self.checkbox.show() - else: - self.checkbox.set_no_show_all(True) - self.checkbox.hide() - def encryption_active(self): return self.checkbox.get_active() @@ -132,10 +120,9 @@ self.checkbox.set_active(True) def plain_warning(self): - if not self.last_msg_plain: - self.chat_control.print_conversation_line( - 'Received plaintext message!', 'status', '', None) - self.last_msg_plain = True + self.chat_control.print_conversation_line( + 'Received plaintext message! ' + + 'Your next message will still be encrypted!', 'status', '', None) def update_prekeys(self): self.prekey_button.refresh()

1 0

gajim-plugins: Release OMEMO plugin version 0.3
by Gajim Plugins 10 Jan '16

10 Jan '16

changeset 0ad2a8bf5e82 in /home/hg/repos/gajim-plugins author: Bahtiar `kalkin-` Gadimov <bahtiar(a)gadimov.de> branches: details:gajim-plugins?cmd=changeset;node=0ad2a8bf5e82 description: Release OMEMO plugin version 0.3 diffstat: omemo/CHANGELOG | 16 +++++ omemo/README.md | 33 ++++++----- omemo/__init__.py | 112 ++++++++++++++++++++++----------------- omemo/manifest.ini | 2 +- omemo/pkgs/PKGBUILD | 23 ++++++++ omemo/setup.cfg | 2 + omemo/state.py | 29 +++------ omemo/store/encryption.py | 58 ++++++++++++++++++++ omemo/store/liteaxolotlstore.py | 2 + omemo/test_encryption_store.py | 31 +++++++++++ omemo/ui.py | 52 ++++++------------ 11 files changed, 241 insertions(+), 119 deletions(-) diffs (truncated from 670 to 300 lines): diff -r a761d5282b57 -r 0ad2a8bf5e82 omemo/CHANGELOG --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/omemo/CHANGELOG Sun Jan 10 21:12:12 2016 +0100 @@ -0,0 +1,16 @@ +0.3 / 2016-01-10 +================== + * Save if OMEMO is enabled between restarts - #17 + * Disable OMEMO if dependencies are missing - #9 + * Make logging less verbose + * Add Arch Linux PKGBUILD file (Thanks Tommaso Sardelli) + * Extend README + * Fix hiding OMEMO controls in muc + * Fix "'ChatControl' object has no attribute 'lock_image'" bug - #16 + * Ui clearly displays which message is encrypted (and how) - #15 + * Plaintext messages are now always marked - #15 + +# 2015-12-27 +- Fix crash, if jid is not in list (Thanks Mic92) +- Fix clear_device_list, if account is not connected (Thanks Mic92) +- Provide python-axolotl installation instructions in README and manifest.ini diff -r a761d5282b57 -r 0ad2a8bf5e82 omemo/README.md --- a/omemo/README.md Sun Dec 27 18:03:23 2015 +0100 +++ b/omemo/README.md Sun Jan 10 21:12:12 2016 +0100 @@ -8,28 +8,20 @@ **DO NOT rely on this plugin to protect sensitive information!** ## Installation -You can install this plugin via the Gajim PluginManager or by cloning the git repository into Gajim's plugin directory. - -```shell -mkdir ~/.local/share/gajim/plugins -p -cd ~/.local/share/gajim/plugins -git clone git@github.com:kalkin/gajim-omemo.git -``` - -### Dependencies -#### Gajim -You need Gajim version 0.16.4. If your package manager does not provide an up to date -version you can install it from the official Mercurial repository. +Install the current stable version via the Gajim PluginManager. You *need* Gajim +version *0.16.5*. If your package manager does not provide an up to date version +you can install it from the official Mercurial repository. *DO NOT USE* gajim +0.16.4 it contains a vulnerability, which is fixed in 0.16.5. ```shell hg clone https://hg.gajim.org/gajim cd gajim -hg update gajim-0.16.4 --clean +hg update gajim-0.16.5 --clean ``` -#### Python libraries +### Python libraries You *have* to install `python-axolotl` via `pip`. Depending on your setup you might want to use `pip2` as Gajim is using python2.7. If you are using the official repository, -do not forget to install the `nxmpp` dependency via pip or you package manager. +do not forget to install the `nbxmpp` dependency via pip or you package manager. ## Running Enable *OMEMO Multi-End Message and Object Encryption* in the Plugin-Manager. @@ -43,13 +35,22 @@ To see OMEMO related debug output start Gajim with the parameter `-l gajim.plugin_system.omemo=DEBUG`. +## Hacking +This repository contains the current development version. If you want to +contribute clone the git repository into your Gajim's plugin directory. +```shell +mkdir ~/.local/share/gajim/plugins -p +cd ~/.local/share/gajim/plugins +git clone https://github.com/kalkin/gajim-omemo +``` + ## Support this project I develop this project in my free time. Your donation allows me to spend more time working on it and on free software generally. My Bitcoin Address is: `1CnNM3Mree9hU8eRjCXrfCWV mX6oBnEfV1` -[![Support Me via Flattr](http://api.flattr.com/button/flattr-badge-large.png)](https://flatt… +[![Support Me via Flattr](http://api.flattr.com/button/flattr-badge-large.png)](https://flatt… ## I found a bug Please report it to the [issue diff -r a761d5282b57 -r 0ad2a8bf5e82 omemo/__init__.py --- a/omemo/__init__.py Sun Dec 27 18:03:23 2015 +0100 +++ b/omemo/__init__.py Sun Jan 10 21:12:12 2016 +0100 @@ -25,7 +25,6 @@ from plugins import GajimPlugin from plugins.helpers import log_calls -from .state import OmemoState from .ui import Ui from .xmpp import ( NS_NOTIFY, NS_OMEMO, BundleInformationAnnouncement, BundleInformationQuery, @@ -34,7 +33,15 @@ iq_ids_to_callbacks = {} +AXOLOTL_MISSING = 'Please install python-axolotl.' + log = logging.getLogger('gajim.plugin_system.omemo') +try: + from .state import OmemoState + HAS_AXOLOTL = True +except ImportError: + log.error(AXOLOTL_MISSING) + HAS_AXOLOTL = False class OmemoPlugin(GajimPlugin): @@ -45,6 +52,10 @@ @log_calls('OmemoPlugin') def init(self): + if not HAS_AXOLOTL: + self.activatable = False + self.available_text = _(AXOLOTL_MISSING) + return self.events_handlers = { 'message-received': (ged.PRECORE, self.message_received), 'pep-received': (ged.PRECORE, self.handle_device_list_update), @@ -54,18 +65,24 @@ (ged.PRECORE, self.handle_outgoing_msgs), } self.config_dialog = None - self.gui_extension_points = {'chat_control_base': + self.gui_extension_points = {'chat_control': (self.connect_ui, None)} SUPPORTED_PERSONAL_USER_EVENTS.append(DevicelistPEP) @log_calls('OmemoPlugin') def get_omemo_state(self, account): + """ Returns the the OmemoState for specified account. Creates the + OmemoState if it does not exist yet. + """ if account not in self.omemo_states: self.omemo_states[account] = OmemoState(account) return self.omemo_states[account] @log_calls('OmemoPlugin') def signed_in(self, show): + """ + On sign in announce OMEMO support for each account. + """ account = show.conn.name state = self.get_omemo_state(account) self.announce_support(state) @@ -160,15 +177,13 @@ devices_list = unpack_device_list_update(event) if len(devices_list) == 0: return False - account = event.conn.name + account_name = event.conn.name contact_jid = gajim.get_jid_without_resource(event.fjid) - state = self.get_omemo_state(account) - my_jid = gajim.get_jid_from_account(account) - - log.debug(account + ' ⇒ Received OMEMO pep for jid ' + contact_jid) + state = self.get_omemo_state(account_name) + my_jid = gajim.get_jid_from_account(account_name) if contact_jid == my_jid: - log.debug(state.name + ' ⇒ Received own device_list ' + str( + log.info(state.name + ' ⇒ Received own device_list:' + str( devices_list)) state.add_own_devices(devices_list) @@ -181,12 +196,19 @@ devices_list.append(state.own_device_id) self.publish_own_devices_list(state) else: + log.info(account_name + ' ⇒ Received device_list for ' + + contact_jid + ':' + str(devices_list)) state.add_devices(contact_jid, devices_list) - if account in self.ui_list and contact_jid in self.ui_list[ - account]: - self.ui_list[account][contact_jid].toggle_omemo(True) + if account_name in self.ui_list and contact_jid not in self.ui_list[ + account_name]: - self.update_prekeys(account, contact_jid) + chat_control = gajim.interface.msg_win_mgr.get_control( + contact_jid, account_name) + + if chat_control is not None: + self.connect_ui(chat_control) + + self.update_prekeys(account_name, contact_jid) return True @@ -204,11 +226,18 @@ @log_calls('OmemoPlugin') def connect_ui(self, chat_control): - account = chat_control.contact.account.name - jid = chat_control.contact.jid - if account not in self.ui_list: - self.ui_list[account] = {} - self.ui_list[account][jid] = Ui(self, chat_control) + account_name = chat_control.contact.account.name + contact_jid = chat_control.contact.jid + if account_name not in self.ui_list: + self.ui_list[account_name] = {} + state = self.get_omemo_state(account_name) + if contact_jid in state.device_ids: + log.debug(account_name + " ⇒ Adding OMEMO ui for " + contact_jid) + omemo_enabled = state.encryption.is_active(contact_jid) + self.ui_list[account_name][contact_jid] = Ui(self, chat_control, + omemo_enabled) + else: + log.warn(account_name + " ⇒ No OMEMO dev_keys for " + contact_jid) def are_keys_missing(self, contact): """ Used by the ui to set the state of the PreKeyButton. """ @@ -218,6 +247,9 @@ result = 0 result += len(state.devices_without_sessions(str(contact.jid))) result += len(state.own_devices_without_sessions(my_jid)) + if result > 0: + log.warn(account + " ⇒ Missing keys for " + contact.jid + ": " + + str(result)) return result @log_calls('OmemoPlugin') @@ -233,10 +265,13 @@ del iq_ids_to_callbacks[id_] @log_calls('OmemoPlugin') - def query_prekey(self, contact): - account = contact.account.name + def query_prekey(self, recipient): + """ Calls OmemoPlugin.fetch_device_bundle_information() for each own or + recipient device key missing. + """ + account = recipient.account.name state = self.get_omemo_state(account) - to_jid = contact.jid + to_jid = recipient.jid my_jid = gajim.get_jid_from_account(account) for device_id in state.devices_without_sessions(to_jid): self.fetch_device_bundle_information(state, to_jid, device_id) @@ -258,8 +293,8 @@ device_id : int The device_id for which we are missing an axolotl session """ - log.debug(state.name + '→ Fetch bundle information for dev ' + str( - device_id) + ' and jid ' + jid) + log.debug(state.name + '→ Fetch bundle device ' + str(device_id) + '#' + + jid) iq = BundleInformationQuery(jid, device_id) iq_id = str(iq.getAttr('id')) iq_ids_to_callbacks[iq_id] = \ @@ -366,12 +401,12 @@ if successful(stanza): log.debug(account + ' → Publishing bundle was successful') if not state.own_device_id_published(): - log.debug(account + ' → Device list needs updating') + log.warn(account + ' → Device list needs updating') self.publish_own_devices_list(state) else: log.debug(account + ' → Device list up to date') else: - log.debug(account + ' → Publishing bundle was NOT successful') + log.error(account + ' → Publishing bundle was NOT successful') @log_calls('OmemoPlugin') def clear_device_list(self, contact): @@ -397,7 +432,7 @@ state = self.get_omemo_state(account) full_jid = str(event.msg_iq.getAttr('to')) to_jid = gajim.get_jid_without_resource(full_jid) - if to_jid not in state.omemo_enabled: + if not state.encryption.is_active(to_jid): return False try: msg_dict = state.create_msg( @@ -412,40 +447,19 @@ return True @log_calls('OmemoPlugin') - def is_omemo_enabled(self, contact): - account = contact.account.name - state = self.get_omemo_state(account) - return contact.jid in state.omemo_enabled - - @log_calls('OmemoPlugin') def omemo_enable_for(self, contact): """ Used by the ui to enable omemo for a specified contact """ account = contact.account.name state = self.get_omemo_state(account) - state.omemo_enabled |= {contact.jid} + state.encryption.activate(contact.jid) @log_calls('OmemoPlugin') def omemo_disable_for(self, contact): """ Used by the ui to disable omemo for a specified contact """ + # TODO Migrate this account = contact.account.name state = self.get_omemo_state(account)

1 0

gajim-plugins: Disable OMEMO if dependencies are missing - #9
by Gajim Plugins 10 Jan '16

10 Jan '16

changeset 1d4888f206b1 in /home/hg/repos/gajim-plugins author: Bahtiar `kalkin-` Gadimov <bahtiar(a)gadimov.de> branches: details:gajim-plugins?cmd=changeset;node=1d4888f206b1 description: Disable OMEMO if dependencies are missing - #9 diffstat: omemo/__init__.py | 13 ++++++++++++- 1 files changed, 12 insertions(+), 1 deletions(-) diffs (38 lines): diff -r ec4b8b0e70fe -r 1d4888f206b1 omemo/__init__.py --- a/omemo/__init__.py Mon Jan 04 21:34:05 2016 +0100 +++ b/omemo/__init__.py Sun Jan 10 16:51:11 2016 +0100 @@ -25,7 +25,6 @@ from plugins import GajimPlugin from plugins.helpers import log_calls -from .state import OmemoState from .ui import Ui from .xmpp import ( NS_NOTIFY, NS_OMEMO, BundleInformationAnnouncement, BundleInformationQuery, @@ -34,7 +33,15 @@ iq_ids_to_callbacks = {} +AXOLOTL_MISSING = 'Please install python-axolotl.' + log = logging.getLogger('gajim.plugin_system.omemo') +try: + from .state import OmemoState + HAS_AXOLOTL = True +except ImportError: + log.error(AXOLOTL_MISSING) + HAS_AXOLOTL = False class OmemoPlugin(GajimPlugin): @@ -45,6 +52,10 @@ @log_calls('OmemoPlugin') def init(self): + if not HAS_AXOLOTL: + self.activatable = False + self.available_text = _(AXOLOTL_MISSING) + return self.events_handlers = { 'message-received': (ged.PRECORE, self.message_received), 'pep-received': (ged.PRECORE, self.handle_device_list_update),

1 0

gajim-plugins: Stable versions are available via PluginManager
by Gajim Plugins 10 Jan '16

10 Jan '16

changeset 7a65f354e2d4 in /home/hg/repos/gajim-plugins author: Bahtiar `kalkin-` Gadimov <bahtiar(a)gadimov.de> branches: details:gajim-plugins?cmd=changeset;node=7a65f354e2d4 description: Stable versions are available via PluginManager diffstat: omemo/README.md | 18 +++++------------- 1 files changed, 5 insertions(+), 13 deletions(-) diffs (34 lines): diff -r ad2208598bfe -r 7a65f354e2d4 omemo/README.md --- a/omemo/README.md Thu Jan 07 23:42:45 2016 +0100 +++ b/omemo/README.md Fri Jan 08 00:03:39 2016 +0100 @@ -8,25 +8,17 @@ **DO NOT rely on this plugin to protect sensitive information!** ## Installation -You can install this plugin via the Gajim PluginManager or by cloning the git repository into Gajim's plugin directory. - -```shell -mkdir ~/.local/share/gajim/plugins -p -cd ~/.local/share/gajim/plugins -git clone https://github.com/kalkin/gajim-omemo -``` - -### Dependencies -#### Gajim -You need Gajim version 0.16.5. If your package manager does not provide an up to date -version you can install it from the official Mercurial repository. *DO NOT USE* gajim 0.16.4 it contains a vulnerability, which is fixed in 0.16.5. +Install the current stable version via the Gajim PluginManager. You *need* Gajim +version *0.16.5*. If your package manager does not provide an up to date version +you can install it from the official Mercurial repository. *DO NOT USE* gajim +0.16.4 it contains a vulnerability, which is fixed in 0.16.5. ```shell hg clone https://hg.gajim.org/gajim cd gajim hg update gajim-0.16.5 --clean ``` -#### Python libraries +### Python libraries You *have* to install `python-axolotl` via `pip`. Depending on your setup you might want to use `pip2` as Gajim is using python2.7. If you are using the official repository, do not forget to install the `nbxmpp` dependency via pip or you package manager.

1 0

gajim-plugins: Do not use unicode LOCK & LOCK_OPEN chars - #25
by Gajim Plugins 10 Jan '16

10 Jan '16

changeset afc9889d75c5 in /home/hg/repos/gajim-plugins author: Bahtiar `kalkin-` Gadimov <bahtiar(a)gadimov.de> branches: details:gajim-plugins?cmd=changeset;node=afc9889d75c5 description: Do not use unicode LOCK & LOCK_OPEN chars - #25 diffstat: omemo/ui.py | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diffs (21 lines): diff -r 1d4888f206b1 -r afc9889d75c5 omemo/ui.py --- a/omemo/ui.py Sun Jan 10 16:51:11 2016 +0100 +++ b/omemo/ui.py Sun Jan 10 16:58:49 2016 +0100 @@ -77,7 +77,7 @@ self.plugin.omemo_enable_for(self.contact) self.chat_control._show_lock_image(True, 'OMEMO', True, True, False) self.chat_control.print_conversation_line( - u'\U0001F512 OMEMO encryption enabled ', 'status', '', None) + u'OMEMO encryption enabled ', 'status', '', None) else: log.info(self.contact.account.name + ' ⇒ Disable OMEMO for ' + self.contact.jid) @@ -85,7 +85,7 @@ self.chat_control._show_lock_image(False, 'OMEMO', False, True, False) self.chat_control.print_conversation_line( - u'\U0001F513 OMEMO encryption disabled', 'status', '', None) + u'OMEMO encryption disabled', 'status', '', None) def _add_widget(widget, chat_control):

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits January 2016