Commits June 2012

commits@gajim.org

4 participants
49 discussions

gajim: handle ft_send_local_ips option with jingle FT
by Yann Leboulanger 14 Jun '12

14 Jun '12

changeset 9d43ef511f51 in /home/hg/repos/gajim details:http://hg.gajim.org/gajim?cmd=changeset;node=9d43ef511f51 description: handle ft_send_local_ips option with jingle FT diffstat: src/common/jingle_transport.py | 11 +++++++---- 1 files changed, 7 insertions(+), 4 deletions(-) diffs (49 lines): diff -r 8c052a48f991 -r 9d43ef511f51 src/common/jingle_transport.py --- a/src/common/jingle_transport.py Thu Jun 14 12:45:11 2012 -0400 +++ b/src/common/jingle_transport.py Thu Jun 14 19:46:17 2012 +0200 @@ -78,7 +78,7 @@ Return the list of transport candidates from a transport stanza """ return [] - + def set_connection(self, conn): self.connection = conn if not self.sid: @@ -89,7 +89,7 @@ def set_our_jid(self, jid): self.ourjid = jid - + def set_sid(self, sid): self.sid = sid @@ -168,6 +168,9 @@ self.candidates.append(cand) def _add_local_ips_as_candidates(self): + if not gajim.config.get_per('accounts', self.connection.name, + 'ft_send_local_ips'): + return if not self.connection: return local_ip_cand = [] @@ -259,7 +262,7 @@ self.file_props.session_sid) if sesn is None: return - + iq = xmpp.Iq(to=proxy['jid'], frm=self.ourjid, typ='set') auth_id = "au_" + proxy['sid'] iq.setID(auth_id) @@ -321,7 +324,7 @@ transport.setAttr('block-size', self.block_sz) transport.setAttr('sid', self.sid) return transport - + try: import farstream except Exception:

1 0

gajim: minor fixes
by Jefry Lagrange 14 Jun '12

14 Jun '12

changeset 8c052a48f991 in /home/hg/repos/gajim details:http://hg.gajim.org/gajim?cmd=changeset;node=8c052a48f991 description: minor fixes diffstat: src/common/file_props.py | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diffs (11 lines): diff -r 12b831df9681 -r 8c052a48f991 src/common/file_props.py --- a/src/common/file_props.py Thu Jun 14 18:43:47 2012 +0200 +++ b/src/common/file_props.py Thu Jun 14 12:45:11 2012 -0400 @@ -134,6 +134,7 @@ self.fd = None self.startexmpp = None self.session_type = None + self.request_id = None def getsid(self): # Getter of the property sid

1 0

gajim: some typo + disable Jingle FT for the moment
by Yann Leboulanger 14 Jun '12

14 Jun '12

changeset 12b831df9681 in /home/hg/repos/gajim details:http://hg.gajim.org/gajim?cmd=changeset;node=12b831df9681 description: some typo + disable Jingle FT for the moment diffstat: src/common/protocol/bytestream.py | 2 +- src/filetransfers_window.py | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diffs (48 lines): diff -r 09b7322ab266 -r 12b831df9681 src/common/protocol/bytestream.py --- a/src/common/protocol/bytestream.py Thu Jun 14 18:34:07 2012 +0200 +++ b/src/common/protocol/bytestream.py Thu Jun 14 18:43:47 2012 +0200 @@ -216,7 +216,7 @@ self.connection.send(iq) def _siResultCB(self, con, iq_obj): - file_props = FilesProp.getFileProp(con.name, iq_obj.getAttr('id')) + file_props = FilesProp.getFileProp(self.name, iq_obj.getAttr('id')) if not file_props: return if file_props.request_id: diff -r 09b7322ab266 -r 12b831df9681 src/filetransfers_window.py --- a/src/filetransfers_window.py Thu Jun 14 18:34:07 2012 +0200 +++ b/src/filetransfers_window.py Thu Jun 14 18:43:47 2012 +0200 @@ -250,11 +250,11 @@ def show_hash_error(self, jid, file_props, account): def on_yes(dummy): # Request the file to the sender - sid = gajim.connections[account].start_file_transfer(jid, - file_props, + sid = gajim.connections[account].start_file_transfer(jid, + file_props, True) file_props.sid = sid - + if file_props.type_ == 'r': file_name = os.path.basename(file_props.file_name) @@ -336,7 +336,7 @@ file_path, file_name, file_desc) if file_props is None: return False - if contact.supports(NS_JINGLE_FILE_TRANSFER): + if contact.supports(NS_JINGLE_FILE_TRANSFER) and False: log.info("contact %s supports jingle file transfer"%(contact.get_full_jid())) gajim.connections[account].start_file_transfer(contact.get_full_jid(), file_props) @@ -574,7 +574,7 @@ gajim.events.remove_events(account, jid, event) gajim.interface.roster.draw_contact(jid, account) gajim.interface.roster.show_title() - FilesProp.deleteFileProp(files_props) + FilesProp.deleteFileProp(file_props) del(file_props) def set_progress(self, typ, sid, transfered_size, iter_=None):

1 0

gajim: jingle IBB and normal IBB are different
by Yann Leboulanger 14 Jun '12

14 Jun '12

changeset 09b7322ab266 in /home/hg/repos/gajim details:http://hg.gajim.org/gajim?cmd=changeset;node=09b7322ab266 description: jingle IBB and normal IBB are different diffstat: src/common/connection_handlers_events.py | 36 +++++++++++++++++++------------ src/common/protocol/bytestream.py | 14 ++++++------ src/common/xmpp/protocol.py | 28 ++++++++++++------------ 3 files changed, 43 insertions(+), 35 deletions(-) diffs (196 lines): diff -r d2bdd3a5f1f2 -r 09b7322ab266 src/common/connection_handlers_events.py --- a/src/common/connection_handlers_events.py Thu Jun 14 12:27:23 2012 -0400 +++ b/src/common/connection_handlers_events.py Thu Jun 14 18:34:07 2012 +0200 @@ -1978,6 +1978,21 @@ self.file_props.stream_methods = xmpp.NS_BYTESTREAM file_tag = self.jingle_content.getTag('description').getTag( 'offer').getTag('file') + for child in file_tag.getChildren(): + name = child.getName() + val = child.getData() + if val is None: + continue + if name == 'name': + self.file_props.name = val + if name == 'size': + self.file_props.size = val + if name == 'hash': + self.file_props.algo = child.getAttr('algo') + self.file_props.hash_ = val + if name == 'date': + self.file_props.date = val + else: profile = si.getAttr('profile') if profile != xmpp.NS_FILE: @@ -2002,20 +2017,13 @@ typ='stream') raise xmpp.NodeProcessed file_tag = si.getTag('file') - for child in file_tag.getChildren(): - name = child.getName() - val = child.getData() - if val is None: - continue - if name == 'name': - self.file_props.name = val - if name == 'size': - self.file_props.size = val - if name == 'hash': - self.file_props.algo = child.getAttr('algo') - self.file_props.hash_ = val - if name == 'date': - self.file_props.date = val + for name, val in file_tag.getAttrs().items(): + if val is None: + continue + if name == 'name': + self.file_props.name = val + if name == 'size': + self.file_props.size = val file_desc_tag = file_tag.getTag('desc') if file_desc_tag is not None: self.file_props.desc = file_desc_tag.getData() diff -r d2bdd3a5f1f2 -r 09b7322ab266 src/common/protocol/bytestream.py --- a/src/common/protocol/bytestream.py Thu Jun 14 12:27:23 2012 -0400 +++ b/src/common/protocol/bytestream.py Thu Jun 14 18:34:07 2012 +0200 @@ -569,7 +569,7 @@ err.setData(msg) self.connection.send(iq) if code == 404: - file_props = FilesProp.getFileProp(self.name, sid) + file_props = FilesProp.getFileProp(self.name, sid) if file_props is not None: self.disconnect_transfer(file_props) file_props.error = -3 @@ -584,7 +584,7 @@ """ if not self.connection or self.connected < 2: return - file_props = FilesProp.getFileProp(self.connection, proxy['sid']) + file_props = FilesProp.getFileProp(self.connection, proxy['sid']) iq = xmpp.Iq(to=proxy['initiator'], typ='set') auth_id = "au_" + proxy['sid'] iq.setID(auth_id) @@ -617,7 +617,7 @@ id_ = unicode(iq_obj.getAttr('id')) query = iq_obj.getTag('query') sid = unicode(query.getAttr('sid')) - file_props = FilesProp.getFileProp(self.name, sid) + file_props = FilesProp.getFileProp(self.name, sid) streamhosts = [] for item in query.getChildren(): if item.getName() == 'streamhost': @@ -780,14 +780,14 @@ blocksize = stanza.getTagAttr('open', 'block-size') log.debug('StreamOpenHandler called sid->%s blocksize->%s' % (sid, blocksize)) - file_props = FilesProp.getFileProp(self.name, sid) + file_props = FilesProp.getFileProp(self.name, sid) try: blocksize = int(blocksize) except: err = xmpp.ERR_BAD_REQUEST if not sid or not blocksize: err = xmpp.ERR_BAD_REQUEST - elif not file_props: + elif not file_props: err = xmpp.ERR_UNEXPECTED_REQUEST if err: rep = xmpp.Error(stanza, err) @@ -900,8 +900,8 @@ seq = '' data = '' err = None - file_props = FilesProp.getFileProp(self.name, sid) - if file_props is None: + file_props = FilesProp.getFileProp(self.name, sid) + if file_props is None: err = xmpp.ERR_ITEM_NOT_FOUND else: if not data: diff -r d2bdd3a5f1f2 -r 09b7322ab266 src/common/xmpp/protocol.py --- a/src/common/xmpp/protocol.py Thu Jun 14 12:27:23 2012 -0400 +++ b/src/common/xmpp/protocol.py Thu Jun 14 18:34:07 2012 +0200 @@ -167,7 +167,7 @@ NS_HASHES_SHA1 = 'urn:xmpp:hash-function-textual-names:sha-1' NS_HASHES_SHA256 = 'urn:xmpp:hash-function-textual-names:sha-256' NS_HASHES_SHA512 = 'urn:xmpp:hash-function-textual-names:sha-512' - + xmpp_stream_error_conditions = ''' bad-format -- -- -- The entity has sent XML that cannot be processed. bad-namespace-prefix -- -- -- The entity has sent a namespace prefix that is unsupported, or has sent no namespace prefix on an element that requires such a prefix. @@ -1037,12 +1037,12 @@ attrs={'id': self.getID()}) iq.setQuery(self.getQuery().getName()).setNamespace(self.getQueryNS()) return iq - -class Hashes(Node): + +class Hashes(Node): """ Hash elements for various XEPs as defined in XEP-300 """ - + """ RECOMENDED HASH USE: Algorithm Support @@ -1053,14 +1053,14 @@ SHA-256 MUST SHA-512 SHOULD """ - + supported = ('md5', 'sha-1', 'sha-256', 'sha-512') - + def __init__(self, nsp=NS_HASHES): Node.__init__(self, None, {}, [], None, None, False, None) self.setNamespace(nsp) self.setName('hash') - + def calculateHash(self, algo, file_string): """ Calculate the hash and add it. It is preferable doing it here @@ -1078,12 +1078,12 @@ hl = hashlib.sha256() elif algo == 'sha-512': hl = hashlib.sha512() - + if hl: hl.update(file_string) hash_ = hl.hexdigest() else: # if it is a file - + if algo == 'md5': hl = hashlib.md5() elif algo == 'sha-1': @@ -1092,18 +1092,18 @@ hl = hashlib.sha256() elif algo == 'sha-512': hl = hashlib.sha512() - + if hl: for line in file_string: hl.update(line) hash_ = hl.hexdigest() - - return hash_ - + + return hash_ + def addHash(self, hash_, algo): self.setAttr('algo', algo) self.setData(hash_) - + class Acks(Node): """ Acknowledgement elements for Stream Management

1 0

gajim: file_props refactoring
by Jefry Lagrange 14 Jun '12

14 Jun '12

changeset d2bdd3a5f1f2 in /home/hg/repos/gajim details:http://hg.gajim.org/gajim?cmd=changeset;node=d2bdd3a5f1f2 description: file_props refactoring diffstat: src/chat_control.py | 18 +- src/common/connection_handlers_events.py | 99 +++--- src/common/file_props.py | 153 ++++++++++ src/common/jingle.py | 2 +- src/common/jingle_content.py | 16 +- src/common/jingle_ft.py | 46 +- src/common/jingle_ftstates.py | 43 +- src/common/jingle_transport.py | 18 +- src/common/protocol/bytestream.py | 448 ++++++++++++++---------------- src/common/proxy65_manager.py | 15 +- src/common/socks5.py | 389 ++++++++++++-------------- src/filetransfers_window.py | 273 +++++++++--------- src/gui_interface.py | 109 +++---- src/tooltips.py | 49 +- 14 files changed, 875 insertions(+), 803 deletions(-) diffs (truncated from 3333 to 300 lines): diff -r e7832358c2e3 -r d2bdd3a5f1f2 src/chat_control.py --- a/src/chat_control.py Sun Jun 10 17:08:54 2012 -0400 +++ b/src/chat_control.py Thu Jun 14 12:27:23 2012 -0400 @@ -3203,11 +3203,11 @@ """ Show an InfoBar on top of control """ - markup = '%s: %s' % (_('File transfer'), file_props['name']) - if 'desc' in file_props and file_props['desc']: - markup += ' (%s)' % file_props['desc'] + markup = '%s: %s' % (_('File transfer'), file_props.name) + if file_props.desc: + markup += ' (%s)' % file_props.desc markup += '\n%s: %s' % (_('Size'), helpers.convert_bytes( - file_props['size'])) + file_props.size)) b1 = gtk.Button(_('_Accept')) b1.connect('clicked', self._on_accept_file_request, file_props) b2 = gtk.Button(stock=gtk.STOCK_CANCEL) @@ -3216,9 +3216,7 @@ gtk.MESSAGE_QUESTION) def _on_open_ft_folder(self, widget, file_props): - if 'file-name' not in file_props: - return - path = os.path.split(file_props['file-name'])[0] + path = os.path.split(file_props.file_name)[0] if os.path.exists(path) and os.path.isdir(path): helpers.launch_file_manager(path) ev = self._get_file_props_event(file_props, 'file-completed') @@ -3232,9 +3230,9 @@ def _got_file_completed(self, file_props): markup = '%s: %s' % (_('File transfer completed'), - file_props['name']) - if 'desc' in file_props and file_props['desc']: - markup += ' (%s)' % file_props['desc'] + file_props.name) + if file_props.desc: + markup += ' (%s)' % file_props.desc b1 = gtk.Button(_('_Open Containing Folder')) b1.connect('clicked', self._on_open_ft_folder, file_props) b2 = gtk.Button(stock=gtk.STOCK_OK) diff -r e7832358c2e3 -r d2bdd3a5f1f2 src/common/connection_handlers_events.py --- a/src/common/connection_handlers_events.py Sun Jun 10 17:08:54 2012 -0400 +++ b/src/common/connection_handlers_events.py Thu Jun 14 12:27:23 2012 -0400 @@ -37,6 +37,7 @@ from common.pep import SUPPORTED_PERSONAL_USER_EVENTS from common.xmpp.protocol import NS_CHATSTATES from common.jingle_transport import JingleTransportSocks5 +from common.file_props import FilesProp import gtkgui_helpers @@ -1940,16 +1941,44 @@ self.get_id() self.fjid = self.conn._ft_get_from(self.stanza) self.jid = gajim.get_jid_without_resource(self.fjid) - self.file_props = {'type': 'r'} - self.file_props['sender'] = self.fjid - self.file_props['request-id'] = self.id_ if self.jingle_content: - self.file_props['session-type'] = 'jingle' - self.file_props['stream-methods'] = xmpp.NS_BYTESTREAM + self.FT_content.use_security = bool(self.jingle_content.getTag( + 'security')) + if not self.FT_content.transport: + self.FT_content.transport = JingleTransportSocks5() + self.FT_content.transport.set_our_jid( + self.FT_content.session.ourjid) + self.FT_content.transport.set_connection( + self.FT_content.session.connection) + sid = self.FT_content.transport.sid + self.file_props = FilesProp.getNewFileProp(self.conn.name, sid) + self.file_props.session_sid = unicode( + self.stanza.getTag('jingle').getAttr('sid') + ) + self.FT_content.file_props = self.file_props + self.FT_content.transport.set_file_props(self.file_props) + if self.file_props.streamhosts: + self.file_props.streamhosts.extend( + self.FT_content.transport.remote_candidates) + else: + self.file_props.streamhosts = \ + self.FT_content.transport.remote_candidates + for host in self.file_props.streamhosts: + host['initiator'] = self.FT_content.session.initiator + host['target'] = self.FT_content.session.responder + else: + si = self.stanza.getTag('si') + self.file_props = FilesProp.getNewFileProp(self.conn.name, + unicode(si.getAttr('id')) + ) + self.file_props.sender = self.fjid + self.file_props.request_id = self.id_ + if self.jingle_content: + self.file_props.session_type = 'jingle' + self.file_props.stream_methods = xmpp.NS_BYTESTREAM file_tag = self.jingle_content.getTag('description').getTag( 'offer').getTag('file') else: - si = self.stanza.getTag('si') profile = si.getAttr('profile') if profile != xmpp.NS_FILE: self.conn.send_file_rejection(self.file_props, code='400', @@ -1965,7 +1994,7 @@ for f in self.dataform.iter_fields(): if f.var == 'stream-method' and f.type == 'list-single': values = [o[1] for o in f.options] - self.file_props['stream-methods'] = ' '.join(values) + self.file_props.stream_methods = ' '.join(values) if xmpp.NS_BYTESTREAM in values or xmpp.NS_IBB in values: break else: @@ -1975,54 +2004,30 @@ file_tag = si.getTag('file') for child in file_tag.getChildren(): name = child.getName() - if name in ('name', 'size', 'hash', 'date'): - val = child.getData() - if val is None: - continue - self.file_props[name] = val - # Delete this, it shouldn't be necesary after file_props gets - # refactored. - if name == 'hash': - self.file_props['algo'] = child.getAttr('algo') + val = child.getData() + if val is None: + continue + if name == 'name': + self.file_props.name = val + if name == 'size': + self.file_props.size = val + if name == 'hash': + self.file_props.algo = child.getAttr('algo') + self.file_props.hash_ = val + if name == 'date': + self.file_props.date = val file_desc_tag = file_tag.getTag('desc') if file_desc_tag is not None: - self.file_props['desc'] = file_desc_tag.getData() + self.file_props.desc = file_desc_tag.getData() if not self.jingle_content: mime_type = si.getAttr('mime-type') if mime_type is not None: - self.file_props['mime-type'] = mime_type + self.file_props.mime_type = mime_type - self.file_props['receiver'] = self.conn._ft_get_our_jid() - self.file_props['transfered_size'] = [] - if self.jingle_content: - self.FT_content.use_security = bool(self.jingle_content.getTag( - 'security')) - self.file_props['session-sid'] = unicode(self.stanza.getTag( - 'jingle').getAttr('sid')) + self.file_props.receiver = self.conn._ft_get_our_jid() + self.file_props.transfered_size = [] - self.FT_content.file_props = self.file_props - if not self.FT_content.transport: - self.FT_content.transport = JingleTransportSocks5() - self.FT_content.transport.set_our_jid( - self.FT_content.session.ourjid) - self.FT_content.transport.set_connection( - self.FT_content.session.connection) - self.file_props['sid'] = self.FT_content.transport.sid - self.FT_content.session.connection.files_props[ - self.file_props['sid']] = self.file_props - self.FT_content.transport.set_file_props(self.file_props) - if self.file_props.has_key('streamhosts'): - self.file_props['streamhosts'].extend( - self.FT_content.transport.remote_candidates) - else: - self.file_props['streamhosts'] = \ - self.FT_content.transport.remote_candidates - for host in self.file_props['streamhosts']: - host['initiator'] = self.FT_content.session.initiator - host['target'] = self.FT_content.session.responder - else: - self.file_props['sid'] = unicode(si.getAttr('id')) return True class FileRequestErrorEvent(nec.NetworkIncomingEvent): diff -r e7832358c2e3 -r d2bdd3a5f1f2 src/common/file_props.py --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/src/common/file_props.py Thu Jun 14 12:27:23 2012 -0400 @@ -0,0 +1,153 @@ +""" +This module is in charge of taking care of all the infomation related to +individual files. Files are identified by the account name and its sid. + + +>>> print FilesProp.getFileProp('jabberid', '10') +None +>>> fp = FilesProp() +Traceback (most recent call last): + ... +Exception: this class should not be instatiated +>>> print FilesProp.getAllFileProp() +[] +>>> fp = FilesProp.getNewFileProp('jabberid', '10') +>>> fp2 = FilesProp.getFileProp('jabberid', '10') +>>> fp == fp2 +True +""" + +class FilesProp: + _files_props = {} + + def __init__(self): + raise Exception('this class should not be instatiated') + + @classmethod + def getNewFileProp(cls, account, sid): + fp = FileProp(account, sid) + cls.setFileProp(fp, account, sid) + return fp + + @classmethod + def getFileProp(cls, account, sid): + if (account, sid) in cls._files_props.keys(): + return cls._files_props[account, sid] + + @classmethod + def getFilePropByAccount(cls, account): + # Returns a list of file_props in one account + file_props = [] + for account, sid in cls._files_props: + if account == account: + file_props.append(cls._files_props[account, sid]) + return file_props + + @classmethod + def getFilePropByType(cls, type_, sid): + # This method should be deleted. Getting fileprop by type and sid is not + # unique enough. More than one fileprop might have the same type and sid + files_prop = cls.getAllFileProp() + for fp in files_prop: + if fp.type_ == type_ and fp.sid == sid: + return fp + + @classmethod + def getFilePropBySid(cls, sid): + # This method should be deleted. It is kept to make things compatible + # This method should be replaced and instead get the file_props by + # account and sid + files_prop = cls.getAllFileProp() + for fp in files_prop: + if fp.sid == sid: + return fp + + @classmethod + def getAllFileProp(cls): + return cls._files_props.values() + + @classmethod + def setFileProp(cls, fp, account, sid): + cls._files_props[account, sid] = fp + + @classmethod + def deleteFileProp(cls, file_prop): + files_props = cls._files_props + a = s = None + for account, sid in files_props: + fp = files_props[account, sid] + if fp is file_prop: + a = account + s = sid + if a != None and s != None: + del files_props[a, s] + + +class FileProp(object): + + def __init__(self, account, sid): + # Do not instatiate this class directly. Call FilesProp.getNeFileProp + # instead + self.streamhosts = [] + self.transfered_size = [] + self.started = False + self.completed = False + self.paused = False + self.stalled = False + self.connected = False + self.stopped = False + self.is_a_proxy = False + self.proxyhost = None + self.proxy_sender = None + self.proxy_receiver = None + self.streamhost_used = None + # method callback called in case of transfer failure + self.failure_cb = None + # method callback called when disconnecting + self.disconnect_cb = None + self.continue_cb = None + self.sha_str = None + # transfer type: 's' for sending and 'r' for receiving + self.type_ = None

1 0

gajim: [Schnouki ] using paint_shadow() rather than paint_flat_b...
by Fomin Denis 13 Jun '12

13 Jun '12

changeset 8c3223cea458 in /home/hg/repos/gajim details:http://hg.gajim.org/gajim?cmd=changeset;node=8c3223cea458 description: [Schnouki ] using paint_shadow() rather than paint_flat_box() to add these borders/shadows. Fixes #5899 diffstat: src/tooltips.py | 10 ++-------- 1 files changed, 2 insertions(+), 8 deletions(-) diffs (20 lines): diff -r e7832358c2e3 -r 8c3223cea458 src/tooltips.py --- a/src/tooltips.py Sun Jun 10 17:08:54 2012 -0400 +++ b/src/tooltips.py Wed Jun 13 17:17:45 2012 +0400 @@ -135,14 +135,8 @@ def expose(self, widget, event): style = self.win.get_style() size = self.win.get_size() - style.paint_flat_box(self.win.window, gtk.STATE_NORMAL, gtk.SHADOW_OUT, - None, self.win, 'tooltip', 0, 0, -1, 1) - style.paint_flat_box(self.win.window, gtk.STATE_NORMAL, gtk.SHADOW_OUT, - None, self.win, 'tooltip', 0, size[1] - 1, -1, 1) - style.paint_flat_box(self.win.window, gtk.STATE_NORMAL, gtk.SHADOW_OUT, - None, self.win, 'tooltip', 0, 0, 1, -1) - style.paint_flat_box(self.win.window, gtk.STATE_NORMAL, gtk.SHADOW_OUT, - None, self.win, 'tooltip', size[0] - 1, 0, 1, -1) + style.paint_shadow(self.win.window, gtk.STATE_NORMAL, gtk.SHADOW_OUT, + None, self.win, 'tooltip', 0, 0, size[0], size[1]) return True def show_tooltip(self, data, widget_height, widget_y_position):

1 0

gajim: make werequest an optional argument in JingleSession
by Jefry Lagrange 10 Jun '12

10 Jun '12

changeset e7832358c2e3 in /home/hg/repos/gajim details:http://hg.gajim.org/gajim?cmd=changeset;node=e7832358c2e3 description: make werequest an optional argument in JingleSession diffstat: src/common/jingle.py | 4 ++-- src/common/jingle_session.py | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diffs (34 lines): diff -r b8909ee93957 -r e7832358c2e3 src/common/jingle.py --- a/src/common/jingle.py Sat Jun 09 15:17:16 2012 -0400 +++ b/src/common/jingle.py Sun Jun 10 17:08:54 2012 -0400 @@ -101,7 +101,7 @@ # do we need to create a new jingle object if sid not in self._sessions: #TODO: tie-breaking and other things... - newjingle = JingleSession(con=self, werequest=False, weinitiate=False, jid=jid, + newjingle = JingleSession(con=self, weinitiate=False, jid=jid, iq_id=id_, sid=sid) self._sessions[sid] = newjingle @@ -148,7 +148,7 @@ if contact is None: return use_security = contact.supports(xmpp.NS_JINGLE_XTLS) - jingle = JingleSession(self, request, weinitiate=True, jid=jid) + jingle = JingleSession(self, weinitiate=True, jid=jid, werequest=request) # this is a file transfer jingle.session_type_FT = True self._sessions[jingle.sid] = jingle diff -r b8909ee93957 -r e7832358c2e3 src/common/jingle_session.py --- a/src/common/jingle_session.py Sat Jun 09 15:17:16 2012 -0400 +++ b/src/common/jingle_session.py Sun Jun 10 17:08:54 2012 -0400 @@ -63,7 +63,8 @@ negotiated between an initiator and a responder. """ - def __init__(self, con, werequest, weinitiate, jid, iq_id=None, sid=None): + def __init__(self, con, weinitiate, jid, iq_id=None, sid=None, + werequest=False): """ con -- connection object, weinitiate -- boolean, are we the initiator?

1 0

gajim: start listening when we get session initiate. Fixes #7175
by Jefry Lagrange 09 Jun '12

09 Jun '12

changeset b8909ee93957 in /home/hg/repos/gajim details:http://hg.gajim.org/gajim?cmd=changeset;node=b8909ee93957 description: start listening when we get session initiate. Fixes #7175 diffstat: src/common/jingle_ft.py | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diffs (15 lines): diff -r ac7c628635eb -r b8909ee93957 src/common/jingle_ft.py --- a/src/common/jingle_ft.py Fri Jun 08 20:02:45 2012 -0400 +++ b/src/common/jingle_ft.py Sat Jun 09 15:17:16 2012 -0400 @@ -117,9 +117,11 @@ gajim.nec.push_incoming_event(FileRequestReceivedEvent(None, conn=self.session.connection, stanza=stanza, jingle_content=content, FT_content=self)) + self._listen_host() # Delete this after file_props refactoring this shouldn't be necesary self.session.file_hash = self.file_props['hash'] self.session.hash_algo = self.file_props['algo'] + def __on_session_initiate_sent(self, stanza, content, error, action): # Calculate file_hash in a new thread # if we haven't sent the hash already.

1 0

gajim: dont cancel when we cant bind to port. Fixes #7173
by Jefry Lagrange 09 Jun '12

09 Jun '12

changeset ac7c628635eb in /home/hg/repos/gajim details:http://hg.gajim.org/gajim?cmd=changeset;node=ac7c628635eb description: dont cancel when we cant bind to port. Fixes #7173 diffstat: src/common/socks5.py | 10 +--------- 1 files changed, 1 insertions(+), 9 deletions(-) diffs (34 lines): diff -r e2ec1b037b4d -r ac7c628635eb src/common/socks5.py --- a/src/common/socks5.py Wed May 30 08:30:49 2012 +0200 +++ b/src/common/socks5.py Fri Jun 08 20:02:45 2012 -0400 @@ -22,7 +22,6 @@ ## along with Gajim. If not, see <http://www.gnu.org/licenses/>. ## - import socket import struct import hashlib @@ -98,13 +97,6 @@ fingerprint=fingerprint) self.listener.queue = self self.listener.bind() - if self.listener.started is False: - self.listener = None - # We cannot bind port, call error callback and fail - self.error_cb(_('Unable to bind to port %s.') % port, - _('Maybe you have another running instance of Gajim. File ' - 'Transfer will be cancelled.')) - return None else: # There is already a listener, we update the file's information # on the new connection. @@ -1473,7 +1465,7 @@ self.ai = None continue if not self.ai: - # unable to bind, show error dialog + log.error('unable to bind to port ' + str(self.port)) return None self._serv.listen(socket.SOMAXCONN) self._serv.setblocking(False)

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits June 2012