changeset c7a32812c477 in /home/hg/repos/gajim
details:http://hg.gajim.org/gajim?cmd=changeset;node=c7a32812c477
description: prevent traceback when a wrong certificate is being checked. Fixes #7242
diffstat:
src/common/check_X509.py | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diffs (17 lines):
diff -r ccef4ef8fe6b -r c7a32812c477 src/common/check_X509.py
--- a/src/common/check_X509.py Sat Oct 06 19:07:48 2012 +0200
+++ b/src/common/check_X509.py Mon Oct 08 11:14:47 2012 +0200
@@ -133,7 +133,12 @@
for i in range(0, cnt):
ext = cert.get_extension(i)
if ext.get_short_name() == 'subjectAltName':
- r = _parse_asn1(ext.get_data())
+ try:
+ r = _parse_asn1(ext.get_data())
+ except:
+ log.error('Wrong data in certificate: subjectAltName=%s' % \
+ ext.get_data())
+ continue
if 'otherName' in r:
if oid_xmppaddr in r['otherName']:
for host in r['otherName'][oid_xmppaddr]:
changeset ccef4ef8fe6b in /home/hg/repos/gajim
details:http://hg.gajim.org/gajim?cmd=changeset;node=ccef4ef8fe6b
description: prevent some traceback. see #7152
diffstat:
src/roster_window.py | 27 ++++++++++++++++++++++-----
1 files changed, 22 insertions(+), 5 deletions(-)
diffs (66 lines):
diff -r 12008ffd5492 -r ccef4ef8fe6b src/roster_window.py
--- a/src/roster_window.py Sat Oct 06 19:06:56 2012 +0200
+++ b/src/roster_window.py Sat Oct 06 19:07:48 2012 +0200
@@ -5059,7 +5059,10 @@
"""
When a row is added, set properties for icon renderer
"""
- type_ = model[titer][C_TYPE]
+ try:
+ type_ = model[titer][C_TYPE]
+ except TypeError:
+ return
if type_ == 'account':
self._set_account_row_background_color(renderer)
renderer.set_property('xalign', 0)
@@ -5089,8 +5092,11 @@
"""
When a row is added, set properties for name renderer
"""
+ try:
+ type_ = model[titer][C_TYPE]
+ except TypeError:
+ return
theme = gajim.config.get('roster_theme')
- type_ = model[titer][C_TYPE]
if type_ == 'account':
color = gajim.config.get_per('themes', theme, 'accounttextcolor')
if color:
@@ -5152,7 +5158,10 @@
"""
When a row is added, draw the respective pep icon
"""
- type_ = model[titer][C_TYPE]
+ try:
+ type_ = model[titer][C_TYPE]
+ except TypeError:
+ return
# allocate space for the icon only if needed
if not model[titer][data]:
@@ -5176,7 +5185,11 @@
"""
When a row is added, set properties for avatar renderer
"""
- type_ = model[titer][C_TYPE]
+ try:
+ type_ = model[titer][C_TYPE]
+ except TypeError:
+ return
+
if type_ in ('group', 'account'):
renderer.set_property('visible', False)
return
@@ -5208,7 +5221,11 @@
"""
When a row is added, set properties for padlock renderer
"""
- type_ = model[titer][C_TYPE]
+ try:
+ type_ = model[titer][C_TYPE]
+ except TypeError:
+ return
+
# allocate space for the icon only if needed
if type_ == 'account' and model[titer][C_PADLOCK_PIXBUF]:
renderer.set_property('visible', True)