Author: roidelapluie
Date: 2007-08-29 22:40:32 +0200 (Wed, 29 Aug 2007)
New Revision: 8594
Modified:
branches/gajim_0.11.1/src/common/connection.py
branches/gajim_0.11.1/src/roster_window.py
Log:
Cleanup connection.connect(). Fix #3061.
Modified: branches/gajim_0.11.1/src/common/connection.py
===================================================================
--- branches/gajim_0.11.1/src/common/connection.py 2007-08-29 20:34:40 UTC (rev 8593)
+++ branches/gajim_0.11.1/src/common/connection.py 2007-08-29 20:40:32 UTC (rev 8594)
@@ -285,16 +285,13 @@
def connect(self, data = None):
''' Start a connection to the Jabber server.
Returns connection, and connection type ('tls', 'ssl', 'tcp', '')
- data MUST contain name, hostname, resource, usessl, proxy,
- use_custom_host, custom_host (if use_custom_host), custom_port (if
- use_custom_host), '''
+ data MUST contain hostname, usessl, proxy, use_custom_host,
+ custom_host (if use_custom_host), custom_port (if use_custom_host)'''
if self.connection:
return self.connection, ''
if data:
- name = data['name']
hostname = data['hostname']
- resource = data['resource']
usessl = data['usessl']
self.try_connecting_for_foo_secs = 45
p = data['proxy']
@@ -304,9 +301,7 @@
custom_h = data['custom_host']
custom_p = data['custom_port']
else:
- name = gajim.config.get_per('accounts', self.name, 'name')
hostname = gajim.config.get_per('accounts', self.name, 'hostname')
- resource = gajim.config.get_per('accounts', self.name, 'resource')
usessl = gajim.config.get_per('accounts', self.name, 'usessl')
self.try_connecting_for_foo_secs = gajim.config.get_per('accounts',
self.name, 'try_connecting_for_foo_secs')
@@ -317,7 +312,7 @@
custom_h = gajim.config.get_per('accounts', self.name, 'custom_host')
custom_p = gajim.config.get_per('accounts', self.name, 'custom_port')
- #create connection if it doesn't already exist
+ # create connection if it doesn't already exist
self.connected = 1
if p and p in gajim.config.get_per('proxies'):
proxy = {'host': gajim.config.get_per('proxies', p, 'host')}
@@ -434,10 +429,8 @@
self.dispatch('CON_TYPE', con_type)
ConnectionHandlers._register_handlers(self, con, con_type)
name = gajim.config.get_per('accounts', self.name, 'name')
- hostname = gajim.config.get_per('accounts', self.name, 'hostname')
- resource = gajim.config.get_per('accounts', self.name, 'resource')
self.connection = con
- con.auth(name, self.password, resource, 1, self.__on_auth)
+ con.auth(name, self.password, self.server_resource, 1, self.__on_auth)
def __on_auth(self, con, auth):
if not con:
@@ -887,6 +880,7 @@
if self.connection:
return
self._hostname = config['hostname']
+ self.server_resource = config['resource']
self.new_account_info = config
self.name = name
self.on_connect_success = self._on_new_account
Modified: branches/gajim_0.11.1/src/roster_window.py
===================================================================
--- branches/gajim_0.11.1/src/roster_window.py 2007-08-29 20:34:40 UTC (rev 8593)
+++ branches/gajim_0.11.1/src/roster_window.py 2007-08-29 20:40:32 UTC (rev 8594)
@@ -1326,8 +1326,7 @@
contact = gajim.contacts.create_contact(jid = jid,
name = account_name, show = connection.get_status(), sub = '',
status = connection.status,
- resource = gajim.config.get_per('accounts', connection.name,
- 'resource'),
+ resource = connection.server_resource,
priority = connection.priority,
keyID = gajim.config.get_per('accounts', connection.name,
'keyid'))
@@ -2659,7 +2658,7 @@
gajim.connections[account].unsubscribe(contact.jid, remove_auth)
for c in gajim.contacts.get_contact(account, contact.jid):
self.remove_contact(c, account)
- gajim.contacts.remove_jid(account, c.jid)
+ gajim.contacts.remove_jid(account, contact.jid)
# redraw group rows for contact numbers
for group in c.groups:
self.draw_group(group, account)