[Gajim-devel] Cert encoding error in nbxmpp [PATCH]

[Robert Marx]

Dear Gajim developers,

python-nbxmpp (master) seems to fail loading certificates that contain
characters which are not allowed in utf-8 files. Some Linux
distributions ship certificates that are encoded using ISO8859-1. This
prevents gajim from establishing TLS connections, thus effectively
rendering it nonfunctional. Ive read (ok skimmed) the relevant RFCs
concerning the PEM and crt file formats and could not find any
indication that these files (PEM, crt) are required to be UTF8 encoded.

I've attached a patch against the master branch that fixes this problem
with certificates using the ISO8859-1 encoding. The patch might be
extended by including other encoding options. The ANSI encoding might be
superfluous (probably a strict subset of UTF8) but I included it
nonetheless to be safe.

Cheers
Robert

PS: Sorry for not going through gitlab, but I happen to be hesitant to
subscribe for a single patch.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gajim.org/pipermail/gajim-devel/attachments/20180607/849c4ab4/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cert_encodings_base_master.patch
Type: text/x-patch
Size: 1552 bytes
Desc: not available
URL: <http://lists.gajim.org/pipermail/gajim-devel/attachments/20180607/849c4ab4/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pEpkey.asc
Type: application/pgp-keys
Size: 6911 bytes
Desc: not available
URL: <http://lists.gajim.org/pipermail/gajim-devel/attachments/20180607/849c4ab4/attachment.key>