[Gajim-devel] two patches

Aleksey Rybalkin aleksey at rybalkin.org
Mon Apr 23 20:03:06 CEST 2012

Good day everyone.

Attached to this message are two patches I made today.

First is about fixing closing/reordering of stacking old-school popup
notifications. Rationale: I prefer to use big 'notification_timeout', so
popups are stacking up and when I close one which is not the bottom one I
expect it close (not the bottom one) and not to have empty space in place
of popup I am closing. That was old buggy behavior. Now we save index for
each popup window and close popups based on that. Also we re-index popups
while reordering them on screen.

Second is about adding new configuration option
'show_popup_for_all_unread'. Rationale: I prefer to receive popup
notifications even after I opened the chat window after receiving the
first message. That is because I use tiling window manager and no panel
and don't have systray, so some chat window can be open on desktop 5 while
I am working on e.g. desktop 2 and I will not know that I received new
message in that chat.

I should also say that this is my first ever attempt to contribute to
known open source project, so if I made mistakes I apologize and ready to
fix them.

FYI: I based my fixes on current hg master branch and used `hg diff -c
[revision]` to produce .diff files. If merging from forked repository is
preferable I can create one on bitbucket for example. Also I suppose new
configuration option may have more appropriate name. Any suggestions will
be appreciated. If there are style errors I am ready to fix them too.

Thank you for your work on Gajim.

Aleksey Rybalkin
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fix_popups.diff
URL: <http://www.lagaule.org/pipermail/gajim-devel/attachments/20120423/c0c5737f/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: show_popup_for_all_unread.diff
URL: <http://www.lagaule.org/pipermail/gajim-devel/attachments/20120423/c0c5737f/attachment-0001.ksh>

More information about the Gajim-devel mailing list