Daniel Brötzmann pushed to branch master at gajim / gajim

Commits:

1 changed file:

Changes:

  • gajim/gtk/manage_sounds.py
    ... ... @@ -27,7 +27,7 @@
    27 27
    28 28
    29 29 
     class ManageSounds(Gtk.ApplicationWindow):
    30 
    -    def __init__(self, transient_for):
    30 
    +    def __init__(self, transient_for: Gtk.Window) -> None:
    31 31 
             Gtk.ApplicationWindow.__init__(self)
    32 32 
             self.set_application(app.app)
    33 33 
             self.set_position(Gtk.WindowPosition.CENTER)
    ... ... @@ -61,7 +61,10 @@ def __init__(self, transient_for):
    61 61 
             self.show_all()
    62 62
    63 63 
         @staticmethod
    64 
    -    def _on_row_changed(model, path, iter_):
    64 
    +    def _on_row_changed(model: Gtk.TreeModel,
    65 
    +                        path: Gtk.TreePath,
    66 
    +                        iter_: Gtk.TreeIter
    67 
    +                        ) -> None:
    65 68 
             sound_event = model[iter_][3]
    66 69 
             app.settings.set_soundevent_setting(sound_event,
    67 70 
                                                 'enabled',
    ... ... @@ -70,17 +73,19 @@ def _on_row_changed(model, path, iter_):
    70 73 
                                                 'path',
    71 74 
                                                 model[iter_][2])
    72 75
    73 
    -    def _on_toggle(self, _cell, path):
    76 
    +    def _on_toggle(self,
    77 
    +                   _cell: Gtk.CellRendererToggle,
    78 
    +                   path: Gtk.TreePath
    79 
    +                   ) -> None:
    74 80 
             if self._ui.filechooser.get_filename() is None:
    75 81 
                 return
    76 82 
             model = self._ui.sounds_treeview.get_model()
    77 83 
             model[path][0] = not model[path][0]
    78 84
    79 
    -    def _fill_sound_treeview(self):
    85 
    +    def _fill_sound_treeview(self) -> None:
    80 86 
             model = self._ui.sounds_treeview.get_model()
    81 87 
             model.clear()
    82 88
    83 
    -        # pylint: disable=line-too-long
    84 89 
             sounds_dict = {
    85 90 
                 'attention_received': _('Attention Message Received'),
    86 91 
                 'first_message_received': _('Message Received'),
    ... ... @@ -90,7 +95,6 @@ def _fill_sound_treeview(self):
    90 95 
                 'muc_message_highlight': _('Group Chat Message Highlight'),
    91 96 
                 'muc_message_received': _('Group Chat Message Received'),
    92 97 
             }
    93 
    -        # pylint: enable=line-too-long
    94 98
    95 99 
             for sound_event, sound_name in sounds_dict.items():
    96 100 
                 settings = app.settings.get_soundevent_settings(sound_event)
    ... ... @@ -99,7 +103,7 @@ def _fill_sound_treeview(self):
    99 103 
                               settings['path'],
    100 104 
                               sound_event))
    101 105
    102 
    -    def _on_cursor_changed(self, treeview):
    106 
    +    def _on_cursor_changed(self, treeview: Gtk.TreeView) -> None:
    103 107 
             model, iter_ = treeview.get_selection().get_selected()
    104 108 
             path_to_snd_file = check_soundfile_path(model[iter_][2])
    105 109 
             if path_to_snd_file is None:
    ... ... @@ -107,7 +111,7 @@ def _on_cursor_changed(self, treeview):
    107 111 
             else:
    108 112 
                 self._ui.filechooser.set_filename(str(path_to_snd_file))
    109 113
    110 
    -    def _on_file_set(self, button):
    114 
    +    def _on_file_set(self, button: Gtk.FileChooserButton) -> None:
    111 115 
             model, iter_ = self._ui.sounds_treeview.get_selection().get_selected()
    112 116
    113 117 
             filename = button.get_filename()
    ... ... @@ -120,17 +124,17 @@ def _on_file_set(self, button):
    120 124 
             # set the sound to enabled
    121 125 
             model[iter_][0] = True
    122 126
    123 
    -    def _on_clear(self, *args):
    127 
    +    def _on_clear(self, _button: Gtk.Button) -> None:
    124 128 
             self._ui.filechooser.unselect_all()
    125 129 
             model, iter_ = self._ui.sounds_treeview.get_selection().get_selected()
    126 130 
             model[iter_][2] = ''
    127 131 
             model[iter_][0] = False
    128 132
    129 
    -    def _on_play(self, *args):
    133 
    +    def _on_play(self, _button: Gtk.Button) -> None:
    130 134 
             model, iter_ = self._ui.sounds_treeview.get_selection().get_selected()
    131 135 
             snd_event_config_name = model[iter_][3]
    132 136 
             play_sound(snd_event_config_name, None, force=True)
    133 137
    134 
    -    def _on_key_press(self, _widget, event):
    138 
    +    def _on_key_press(self, _widget: Gtk.Widget, event: Gdk.EventKey) -> None:
    135 139 
             if event.keyval == Gdk.KEY_Escape:
    136 140 
                 self.destroy()

    • —
    View it on GitLab.
    You're receiving this email because of your account on dev.gajim.org. If you'd like to receive fewer emails, you can adjust your notification settings.